)]}'
{"neutron/tests/unit/db/test_l3_dvr_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"42472d048f6e13cef96c849041ae701d4e80c5fa","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            \u0027device_owner\u0027: [l3_const.DEVICE_OWNER_AGENT_GW]})"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _test_prepare_direct_delete_dvr_internal_ports(self, port):"},{"line_number":159,"context_line":"        with mock.patch.object(manager.NeutronManager, \u0027get_plugin\u0027) as gp:"},{"line_number":160,"context_line":"            plugin \u003d mock.Mock()"},{"line_number":161,"context_line":"            gp.return_value \u003d plugin"},{"line_number":162,"context_line":"            plugin.get_ports.return_value \u003d [port]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_cec47a43","line":159,"updated":"2015-03-02 08:37:58.000000000","message":"consider with mock.patch.object(manager.NeutronManager.get_plugin(), \u0027get_ports\u0027, return_value\u003d[port]):","commit_id":"0d29a8479198ac7d57abb45a4f60e44f59ba16cd"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"34d1cd5000a1f2e9dd60a694a8bc8de4ad63ed85","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            \u0027device_owner\u0027: [l3_const.DEVICE_OWNER_AGENT_GW]})"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _test_prepare_direct_delete_dvr_internal_ports(self, port):"},{"line_number":159,"context_line":"        with mock.patch.object(manager.NeutronManager, \u0027get_plugin\u0027) as gp:"},{"line_number":160,"context_line":"            plugin \u003d mock.Mock()"},{"line_number":161,"context_line":"            gp.return_value \u003d plugin"},{"line_number":162,"context_line":"            plugin.get_ports.return_value \u003d [port]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_4fc86874","line":159,"in_reply_to":"ba7be1f8_cec47a43","updated":"2015-03-02 18:47:19.000000000","message":"Oleg, this does not work the way mentioned above. \nSince this test class is isolated then it looks for the definition of the core_plugin and fails there.\nSo I will use the original method to mock the plugin and then get the ports.","commit_id":"0d29a8479198ac7d57abb45a4f60e44f59ba16cd"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"1ec884d4cbb253cd1f39f969777832ff9e5392d4","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            \u0027device_owner\u0027: [l3_const.DEVICE_OWNER_AGENT_GW]})"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def _test_prepare_direct_delete_dvr_internal_ports(self, port):"},{"line_number":159,"context_line":"        with mock.patch.object(manager.NeutronManager, \u0027get_plugin\u0027) as gp:"},{"line_number":160,"context_line":"            plugin \u003d mock.Mock()"},{"line_number":161,"context_line":"            gp.return_value \u003d plugin"},{"line_number":162,"context_line":"            plugin.get_ports.return_value \u003d [port]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_74a89f77","line":159,"in_reply_to":"ba7be1f8_cec47a43","updated":"2015-03-02 18:26:47.000000000","message":"will address it in the next patch.","commit_id":"0d29a8479198ac7d57abb45a4f60e44f59ba16cd"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"42472d048f6e13cef96c849041ae701d4e80c5fa","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        }"},{"line_number":180,"context_line":"        self._test_prepare_direct_delete_dvr_internal_ports(port)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_prevent_delete_router_intf_ports(self):"},{"line_number":183,"context_line":"        port \u003d {"},{"line_number":184,"context_line":"            \u0027id\u0027: \u0027my_port_id\u0027,"},{"line_number":185,"context_line":"            \u0027device_owner\u0027: l3_const.DEVICE_OWNER_ROUTER_INTF"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_4e07aa81","line":182,"updated":"2015-03-02 08:37:58.000000000","message":"is it related to the patch or dvr?","commit_id":"0d29a8479198ac7d57abb45a4f60e44f59ba16cd"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"34d1cd5000a1f2e9dd60a694a8bc8de4ad63ed85","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        }"},{"line_number":180,"context_line":"        self._test_prepare_direct_delete_dvr_internal_ports(port)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_prevent_delete_router_intf_ports(self):"},{"line_number":183,"context_line":"        port \u003d {"},{"line_number":184,"context_line":"            \u0027id\u0027: \u0027my_port_id\u0027,"},{"line_number":185,"context_line":"            \u0027device_owner\u0027: l3_const.DEVICE_OWNER_ROUTER_INTF"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_efae7c97","line":182,"in_reply_to":"ba7be1f8_3477073d","updated":"2015-03-02 18:47:19.000000000","message":"For now I will go ahead and remove this function. since this is not related to this patch.\nWill add this test case in a separate patch.","commit_id":"0d29a8479198ac7d57abb45a4f60e44f59ba16cd"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"1ec884d4cbb253cd1f39f969777832ff9e5392d4","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        }"},{"line_number":180,"context_line":"        self._test_prepare_direct_delete_dvr_internal_ports(port)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_prevent_delete_router_intf_ports(self):"},{"line_number":183,"context_line":"        port \u003d {"},{"line_number":184,"context_line":"            \u0027id\u0027: \u0027my_port_id\u0027,"},{"line_number":185,"context_line":"            \u0027device_owner\u0027: l3_const.DEVICE_OWNER_ROUTER_INTF"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_3477073d","line":182,"in_reply_to":"ba7be1f8_4e07aa81","updated":"2015-03-02 18:26:47.000000000","message":"This is related to the patch. There was not unit test for deleting the \"INTF\" ports for DVR so added in.","commit_id":"0d29a8479198ac7d57abb45a4f60e44f59ba16cd"}]}