)]}'
{"etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8ce36c87ca28dd2bcf4e494a3aabe01e9fe0a68a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"#   ovs-vsctl set-manager ptcp:6640:127.0.0.1"},{"line_number":51,"context_line":"# ovsdb_connection \u003d tcp:127.0.0.1:6640"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# (StrOpt) OpenFlow driver module to use. \u0027ovs-ofctl\u0027 is the only choice."},{"line_number":54,"context_line":"# ofp_driver \u003d ovs-ofctl"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[agent]"}],"source_content_type":"text/x-properties","patch_set":42,"id":"7aaa499b_499cf25c","line":53,"updated":"2015-04-15 17:19:03.000000000","message":"perhaps \u0027is currently the only available choice\u0027 is better?","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5742a7b11e2042c3f2bff92bc5755414df085706","unresolved":false,"context_lines":[{"line_number":50,"context_line":"#   ovs-vsctl set-manager ptcp:6640:127.0.0.1"},{"line_number":51,"context_line":"# ovsdb_connection \u003d tcp:127.0.0.1:6640"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# (StrOpt) OpenFlow driver module to use. \u0027ovs-ofctl\u0027 is the only choice."},{"line_number":54,"context_line":"# ofp_driver \u003d ovs-ofctl"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[agent]"}],"source_content_type":"text/x-properties","patch_set":42,"id":"dac4157f_d67255ad","line":53,"in_reply_to":"7aaa499b_499cf25c","updated":"2015-04-20 03:42:24.000000000","message":"Done","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8ce36c87ca28dd2bcf4e494a3aabe01e9fe0a68a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# ovsdb_connection \u003d tcp:127.0.0.1:6640"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# (StrOpt) OpenFlow driver module to use. \u0027ovs-ofctl\u0027 is the only choice."},{"line_number":54,"context_line":"# ofp_driver \u003d ovs-ofctl"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[agent]"},{"line_number":57,"context_line":"# Agent\u0027s polling interval in seconds"}],"source_content_type":"text/x-properties","patch_set":42,"id":"7aaa499b_e9d97e23","line":54,"updated":"2015-04-15 17:19:03.000000000","message":"what does ofp stand for? Open Flow Protocol? I\u0027d shorten it of_driver or rename it to openflow_interface, just like we did ovsdb_interface.\n\nand have options \u0027native\u0027 or \u0027ofctl\u0027","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5742a7b11e2042c3f2bff92bc5755414df085706","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# ovsdb_connection \u003d tcp:127.0.0.1:6640"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# (StrOpt) OpenFlow driver module to use. \u0027ovs-ofctl\u0027 is the only choice."},{"line_number":54,"context_line":"# ofp_driver \u003d ovs-ofctl"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[agent]"},{"line_number":57,"context_line":"# Agent\u0027s polling interval in seconds"}],"source_content_type":"text/x-properties","patch_set":42,"id":"dac4157f_b66801bc","line":54,"in_reply_to":"7aaa499b_e9d97e23","updated":"2015-04-20 03:42:24.000000000","message":"Done.\n\ni kept \"ovs-ofctl\" because \"ofctl\" is confusing with ryu \"ofctl\" application which will be used for ryu-based interface.","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3483bab4db582b45767517379c720fa34a0579fc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# ovsdb_connection \u003d tcp:127.0.0.1:6640"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# (StrOpt) OpenFlow driver module to use. \u0027ovs-ofctl\u0027 is the only choice."},{"line_number":54,"context_line":"# ofp_driver \u003d ovs-ofctl"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[agent]"},{"line_number":57,"context_line":"# Agent\u0027s polling interval in seconds"}],"source_content_type":"text/x-properties","patch_set":42,"id":"5aa745d1_f56d53cd","line":54,"in_reply_to":"7aaa499b_e9d97e23","updated":"2015-04-16 03:55:46.000000000","message":"ofp \u003d\u003d OpenFlow Protocol, yes.  it\u0027s a commonly used acronym.\n\nmaking it similar to ovsdb option sounds good to me.","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"}],"neutron/cmd/eventlet/plugins/ovs_neutron_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8ce36c87ca28dd2bcf4e494a3aabe01e9fe0a68a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.plugins.openvswitch.agent.main as agent_main"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aaa499b_a906d683","line":16,"updated":"2015-04-15 17:19:03.000000000","message":"why was this change necessary? Can you elaborate?","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3483bab4db582b45767517379c720fa34a0579fc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import neutron.plugins.openvswitch.agent.main as agent_main"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":42,"id":"5aa745d1_f57b137a","line":16,"in_reply_to":"7aaa499b_a906d683","updated":"2015-04-16 03:55:46.000000000","message":"neutron/plugins/openvswitch/agent/main.py separation in this patch predates the use of neutron/cmd directory.\nit might not be absolutely necessary anymore.","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"}],"neutron/plugins/openvswitch/agent/main.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8ce36c87ca28dd2bcf4e494a3aabe01e9fe0a68a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"_main_modules \u003d {"},{"line_number":33,"context_line":"    \u0027ovs-ofctl\u0027: \u0027neutron.plugins.openvswitch.agent.ovs_ofctl.main\u0027,"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"7aaa499b_6981eec2","line":33,"updated":"2015-04-15 17:19:03.000000000","message":"I find this way of loading the agent a bit prone to breakage, what\u0027s the reason why we need to load the entire module dynamically?","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3483bab4db582b45767517379c720fa34a0579fc","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"_main_modules \u003d {"},{"line_number":33,"context_line":"    \u0027ovs-ofctl\u0027: \u0027neutron.plugins.openvswitch.agent.ovs_ofctl.main\u0027,"},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"5aa745d1_756263da","line":33,"in_reply_to":"7aaa499b_6981eec2","updated":"2015-04-16 03:55:46.000000000","message":"because ryu-based driver does \"import ryu.foo.bar\", which might not be available.","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"}],"neutron/plugins/openvswitch/agent/openflow/ovs_ofctl/br_dvr_process.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5e5412a4f0e067f6ddbc3ad74508a220631bdd1c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2014,2015 VA Linux Systems Japan K.K."},{"line_number":2,"context_line":"# Copyright (C) 2014,2015 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":57,"id":"7a016987_5cefc11d","line":2,"updated":"2015-05-22 22:38:52.000000000","message":"we really don\u0027t need this twice, but ok.","commit_id":"5eb1d93eda21c9ea01f6dc9fd11fda41a0b92bda"}],"neutron/plugins/openvswitch/agent/openflow/ovs_ofctl/br_int.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"faf2ee23640b75611bf08ac30b90429ab97ba5d4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.delete_flows(in_port\u003dport, dl_vlan\u003ddl_vlan)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @staticmethod"},{"line_number":66,"context_line":"    def _dvr_to_src_mac_table_id(network_type):"},{"line_number":67,"context_line":"        if network_type \u003d\u003d p_const.TYPE_VLAN:"},{"line_number":68,"context_line":"            return constants.DVR_TO_SRC_MAC_VLAN"},{"line_number":69,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":61,"id":"7a016987_0a50c930","line":66,"updated":"2015-05-25 09:12:29.000000000","message":"What is the reason we have DVR related logic not in OVSDVRProcessMixin but in this class?\nAre DVR related methods specific to a particular bridge defined here? I just would like to clarify the criteria.","commit_id":"ad118015ae59a945dedb8f20dbd7729ff4b45170"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1b5223fd947bf4c1acdf200045139afd39531734","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.delete_flows(in_port\u003dport, dl_vlan\u003ddl_vlan)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @staticmethod"},{"line_number":66,"context_line":"    def _dvr_to_src_mac_table_id(network_type):"},{"line_number":67,"context_line":"        if network_type \u003d\u003d p_const.TYPE_VLAN:"},{"line_number":68,"context_line":"            return constants.DVR_TO_SRC_MAC_VLAN"},{"line_number":69,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":61,"id":"7a016987_9a6be8b6","line":66,"in_reply_to":"7a016987_0a50c930","updated":"2015-05-25 09:48:37.000000000","message":"yes, OVSDVRProcessMixin is, as mentioned in its docstring, used only for logic shared between br-tun and br-phys.","commit_id":"ad118015ae59a945dedb8f20dbd7729ff4b45170"}],"neutron/plugins/openvswitch/agent/openflow/ovs_ofctl/main.py":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"15758645a8279f95bd36d761eb9d14dc31cdba3f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2014,2015 VA Linux Systems Japan K.K."},{"line_number":2,"context_line":"# Copyright (C) 2014 Fumihiko Kakuma \u003ckakuma at valinux co jp\u003e"},{"line_number":3,"context_line":"# Copyright (C) 2014,2015 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":57,"id":"7a016987_170ec28b","line":2,"updated":"2015-05-22 23:02:39.000000000","message":"Should this person be a co-author in the commit message?","commit_id":"5eb1d93eda21c9ea01f6dc9fd11fda41a0b92bda"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"32af7de381c25850f134dcb918bf389e10e63360","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2014,2015 VA Linux Systems Japan K.K."},{"line_number":2,"context_line":"# Copyright (C) 2014 Fumihiko Kakuma \u003ckakuma at valinux co jp\u003e"},{"line_number":3,"context_line":"# Copyright (C) 2014,2015 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":57,"id":"7a016987_fffc1c73","line":2,"in_reply_to":"7a016987_170ec28b","updated":"2015-05-23 04:40:06.000000000","message":"some parts of these patches were derived from ofagent, which has kakuma\u0027s copyright notice.\nhowever, this specific file seems to have nothing from ofagent.\nit\u0027s probably just a copy-and-paste mistake and i will remove it.","commit_id":"5eb1d93eda21c9ea01f6dc9fd11fda41a0b92bda"}],"neutron/plugins/openvswitch/agent/openflow/ovs_ofctl/ofswitch.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5e5412a4f0e067f6ddbc3ad74508a220631bdd1c","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @staticmethod"},{"line_number":31,"context_line":"    def _conv_args(kwargs):"},{"line_number":32,"context_line":"        for our_name, ovs_ofctl_name in _keywords.iteritems():"},{"line_number":33,"context_line":"            if our_name in kwargs:"},{"line_number":34,"context_line":"                kwargs[ovs_ofctl_name] \u003d kwargs.pop(our_name)"},{"line_number":35,"context_line":"        return kwargs"}],"source_content_type":"text/x-python","patch_set":57,"id":"7a016987_dcc29184","line":32,"updated":"2015-05-22 22:38:52.000000000","message":"this should be items() instead","commit_id":"5eb1d93eda21c9ea01f6dc9fd11fda41a0b92bda"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"32af7de381c25850f134dcb918bf389e10e63360","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @staticmethod"},{"line_number":31,"context_line":"    def _conv_args(kwargs):"},{"line_number":32,"context_line":"        for our_name, ovs_ofctl_name in _keywords.iteritems():"},{"line_number":33,"context_line":"            if our_name in kwargs:"},{"line_number":34,"context_line":"                kwargs[ovs_ofctl_name] \u003d kwargs.pop(our_name)"},{"line_number":35,"context_line":"        return kwargs"}],"source_content_type":"text/x-python","patch_set":57,"id":"7a016987_5f1a10c7","line":32,"in_reply_to":"7a016987_dcc29184","updated":"2015-05-23 04:40:06.000000000","message":"Done","commit_id":"5eb1d93eda21c9ea01f6dc9fd11fda41a0b92bda"}],"neutron/plugins/openvswitch/agent/openflow/ovs_ofctl/ovs_bridge.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"faf2ee23640b75611bf08ac30b90429ab97ba5d4","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class OVSAgentBridge(ofswitch.OpenFlowSwitchMixin, ovs_lib.OVSBridge):"},{"line_number":23,"context_line":"    \"\"\"Common code for bridges used by OVS agent"},{"line_number":24,"context_line":"    \"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def setup_controllers(self, conf):"},{"line_number":27,"context_line":"        self.set_protocols(\"[OpenFlow10]\")"}],"source_content_type":"text/x-python","patch_set":61,"id":"7a016987_6a9e1d64","line":24,"updated":"2015-05-25 09:12:29.000000000","message":"Nit: in this case, closing triple quotes should be placed at L.23. one-line docstring is recommended.","commit_id":"ad118015ae59a945dedb8f20dbd7729ff4b45170"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1b5223fd947bf4c1acdf200045139afd39531734","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class OVSAgentBridge(ofswitch.OpenFlowSwitchMixin, ovs_lib.OVSBridge):"},{"line_number":23,"context_line":"    \"\"\"Common code for bridges used by OVS agent"},{"line_number":24,"context_line":"    \"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def setup_controllers(self, conf):"},{"line_number":27,"context_line":"        self.set_protocols(\"[OpenFlow10]\")"}],"source_content_type":"text/x-python","patch_set":61,"id":"7a016987_9ab3e897","line":24,"in_reply_to":"7a016987_6a9e1d64","updated":"2015-05-25 09:48:37.000000000","message":"Done","commit_id":"ad118015ae59a945dedb8f20dbd7729ff4b45170"}],"neutron/plugins/openvswitch/agent/ovs_dvr_neutron_agent.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"faf2ee23640b75611bf08ac30b90429ab97ba5d4","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"            if self.enable_tunneling:"},{"line_number":307,"context_line":"                # Table 0 (default) will now sort DVR traffic from other"},{"line_number":308,"context_line":"                # traffic depending on in_port"},{"line_number":309,"context_line":"                self.int_br.add_flow(table\u003dconstants.LOCAL_SWITCHING,"},{"line_number":310,"context_line":"                                     priority\u003d2,"},{"line_number":311,"context_line":"                                     in_port\u003dself.patch_tun_ofport,"}],"source_content_type":"text/x-python","patch_set":61,"id":"7a016987_c545026f","side":"PARENT","line":308,"updated":"2015-05-25 09:12:29.000000000","message":"It seems we are dropping the comment L.307-308 and L.315-316.\nIs it intended?","commit_id":"6ba78cec1a77921a591f99b717ff093ca3688c31"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1b5223fd947bf4c1acdf200045139afd39531734","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"            if self.enable_tunneling:"},{"line_number":307,"context_line":"                # Table 0 (default) will now sort DVR traffic from other"},{"line_number":308,"context_line":"                # traffic depending on in_port"},{"line_number":309,"context_line":"                self.int_br.add_flow(table\u003dconstants.LOCAL_SWITCHING,"},{"line_number":310,"context_line":"                                     priority\u003d2,"},{"line_number":311,"context_line":"                                     in_port\u003dself.patch_tun_ofport,"}],"source_content_type":"text/x-python","patch_set":61,"id":"7a016987_9a29a8e8","side":"PARENT","line":308,"in_reply_to":"7a016987_c545026f","updated":"2015-05-25 09:48:37.000000000","message":"no.  restored.","commit_id":"6ba78cec1a77921a591f99b717ff093ca3688c31"}],"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8ce36c87ca28dd2bcf4e494a3aabe01e9fe0a68a","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"        cfg.CONF.set_default(\u0027ip_lib_force_root\u0027, True)"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"def main(backend_info):"},{"line_number":1587,"context_line":"    try:"},{"line_number":1588,"context_line":"        agent_config \u003d create_agent_config_map(cfg.CONF)"},{"line_number":1589,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aaa499b_89f55a58","line":1586,"updated":"2015-04-15 17:19:03.000000000","message":"this feels too magic-y. I don\u0027t think that passing a magic tuple like this to the main is very readable and maintainable.","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b1696501abb2dc8e045bf0115539206f9c6a7639","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"        cfg.CONF.set_default(\u0027ip_lib_force_root\u0027, True)"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"def main(backend_info):"},{"line_number":1587,"context_line":"    try:"},{"line_number":1588,"context_line":"        agent_config \u003d create_agent_config_map(cfg.CONF)"},{"line_number":1589,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":42,"id":"dac4157f_cc808249","line":1586,"in_reply_to":"5aa745d1_f5f2f305","updated":"2015-04-20 06:02:54.000000000","message":"the latest ps has less magic.","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3483bab4db582b45767517379c720fa34a0579fc","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"        cfg.CONF.set_default(\u0027ip_lib_force_root\u0027, True)"},{"line_number":1584,"context_line":""},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"def main(backend_info):"},{"line_number":1587,"context_line":"    try:"},{"line_number":1588,"context_line":"        agent_config \u003d create_agent_config_map(cfg.CONF)"},{"line_number":1589,"context_line":"    except ValueError:"}],"source_content_type":"text/x-python","patch_set":42,"id":"5aa745d1_f5f2f305","line":1586,"in_reply_to":"7aaa499b_89f55a58","updated":"2015-04-16 03:55:46.000000000","message":"i\u0027ll try to find a way with less magic.","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"}],"neutron/plugins/openvswitch/agent/ovs_ofctl/br_int.py":[{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"80072df14b096be3b1535bba2fae78078f1f4a59","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            return constants.DVR_TO_SRC_MAC"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def install_dvr_to_src_mac(self, network_type,"},{"line_number":72,"context_line":"                               vlan_tag, gateway_mac, dst_mac, dst_port):"},{"line_number":73,"context_line":"        table_id \u003d self._dvr_to_src_mac_table_id(network_type)"},{"line_number":74,"context_line":"        self.add_flow(table\u003dtable_id,"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aa53dc9_fee96b1b","line":71,"updated":"2015-04-08 07:46:33.000000000","message":"A question: why wrap all the related openflows rules operations? To reduce the redundancy code? Since after this patch merged. If new flows are added, new methods should be added here.","commit_id":"8b8991a81f86ac37fc214c61849bc7ad7c97470e"},{"author":{"_account_id":8172,"name":"Wei Hu","email":"huwei.xtu@gmail.com","username":"WeiHu"},"change_message_id":"dd5bb9372d880e3bee47c10d50428b3437c7475a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            return constants.DVR_TO_SRC_MAC"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def install_dvr_to_src_mac(self, network_type,"},{"line_number":72,"context_line":"                               vlan_tag, gateway_mac, dst_mac, dst_port):"},{"line_number":73,"context_line":"        table_id \u003d self._dvr_to_src_mac_table_id(network_type)"},{"line_number":74,"context_line":"        self.add_flow(table\u003dtable_id,"}],"source_content_type":"text/x-python","patch_set":34,"id":"7aaa499b_82bfdecf","line":71,"in_reply_to":"9aa53dc9_deb907cd","updated":"2015-04-13 08:06:14.000000000","message":"OK. But I still not agree #2. We still need to pass the raw parameters to this method. And in the future, if someone want to add some other new flow rules, seems those bridge relate classes will also need updated. However, if it is must to your other patch, maybe it is fine here.","commit_id":"8b8991a81f86ac37fc214c61849bc7ad7c97470e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"94ff3a9fd8ebde8141e103edef8162327aab0066","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        else:"},{"line_number":69,"context_line":"            return constants.DVR_TO_SRC_MAC"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def install_dvr_to_src_mac(self, network_type,"},{"line_number":72,"context_line":"                               vlan_tag, gateway_mac, dst_mac, dst_port):"},{"line_number":73,"context_line":"        table_id \u003d self._dvr_to_src_mac_table_id(network_type)"},{"line_number":74,"context_line":"        self.add_flow(table\u003dtable_id,"}],"source_content_type":"text/x-python","patch_set":34,"id":"9aa53dc9_deb907cd","line":71,"in_reply_to":"9aa53dc9_fee96b1b","updated":"2015-04-08 07:57:24.000000000","message":"because:\n\n* this is a preparation of the following patch, which will introduce another implementation.  see https://review.openstack.org/#/c/153946/\n* it\u0027s anyway a good idea to have a higher level abstraction than raw \"add-flow\" etc","commit_id":"8b8991a81f86ac37fc214c61849bc7ad7c97470e"}],"neutron/plugins/openvswitch/agent/ovs_ofctl/ofswitch.py":[{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"fcb22e4085adb6caed4e7de6ce08bdac6d2b6167","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def delete_flows(self, **kwargs):"},{"line_number":69,"context_line":"        if kwargs:"},{"line_number":70,"context_line":"            super(OpenFlowSwitch, self).delete_flows(**self._conv_args(kwargs))"},{"line_number":71,"context_line":"        else:"},{"line_number":72,"context_line":"            super(OpenFlowSwitch, self).remove_all_flows()"}],"source_content_type":"text/x-python","patch_set":30,"id":"da9b358b_82f91d50","line":70,"updated":"2015-03-30 09:17:02.000000000","message":"Is this a mistake or just a work in progress?\nOpenFlowSwitch inherit from object.. where the delete flows are implemented?\n\nguess you meant to add the mixin\u0027s to it","commit_id":"16a15b480fd0053aca71ecd6033faa9682be1f7a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d189714efd49254bc75da383f35725aef0448cd3","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def delete_flows(self, **kwargs):"},{"line_number":69,"context_line":"        if kwargs:"},{"line_number":70,"context_line":"            super(OpenFlowSwitch, self).delete_flows(**self._conv_args(kwargs))"},{"line_number":71,"context_line":"        else:"},{"line_number":72,"context_line":"            super(OpenFlowSwitch, self).remove_all_flows()"}],"source_content_type":"text/x-python","patch_set":30,"id":"da9b358b_f912bf61","line":70,"in_reply_to":"da9b358b_82f91d50","updated":"2015-03-31 00:50:33.000000000","message":"this calls ovs_lib.OVSBridge.delete_flows.\nsee ovs_bridge.py how this class is used.\ni\u0027ll add a comment.","commit_id":"16a15b480fd0053aca71ecd6033faa9682be1f7a"}],"neutron/tests/functional/agent/test_ovs_flows.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8ce36c87ca28dd2bcf4e494a3aabe01e9fe0a68a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Mirantis, Inc."},{"line_number":2,"context_line":"# Copyright (C) 2015 VA Linux Systems Japan K.K."},{"line_number":3,"context_line":"# Copyright (C) 2015 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":42,"id":"7aaa499b_493e32db","line":2,"updated":"2015-04-15 17:19:03.000000000","message":"no need to add a copyright change for every file you touch; if all of us did that, the copyright section would be almost as long as the actual code!","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b1696501abb2dc8e045bf0115539206f9c6a7639","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Mirantis, Inc."},{"line_number":2,"context_line":"# Copyright (C) 2015 VA Linux Systems Japan K.K."},{"line_number":3,"context_line":"# Copyright (C) 2015 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":42,"id":"dac4157f_6cb9762e","line":2,"in_reply_to":"7aaa499b_493e32db","updated":"2015-04-20 06:02:54.000000000","message":"it\u0027s historical.  i will remove.","commit_id":"dfa30af64b9137b36e87ed57c5887f879b671229"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5e5412a4f0e067f6ddbc3ad74508a220631bdd1c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self._main_thread \u003d eventlet.spawn(self._kick_main)"},{"line_number":47,"context_line":"        self.addCleanup(self._kill_main)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # wait for _kick_main -\u003e of_interface main -\u003e _agent_main"},{"line_number":50,"context_line":"        while not self.init_done:"},{"line_number":51,"context_line":"            self.init_done_ev.wait()"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":57,"id":"7a016987_177002a3","line":49,"updated":"2015-05-22 22:38:52.000000000","message":"this looks potentially race-y or undetermined, can you elaborate why it\u0027s done this way?","commit_id":"5eb1d93eda21c9ea01f6dc9fd11fda41a0b92bda"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"32af7de381c25850f134dcb918bf389e10e63360","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self._main_thread \u003d eventlet.spawn(self._kick_main)"},{"line_number":47,"context_line":"        self.addCleanup(self._kill_main)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # wait for _kick_main -\u003e of_interface main -\u003e _agent_main"},{"line_number":50,"context_line":"        while not self.init_done:"},{"line_number":51,"context_line":"            self.init_done_ev.wait()"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":57,"id":"7a016987_bfa6a4ab","line":49,"in_reply_to":"7a016987_177002a3","updated":"2015-05-23 04:40:06.000000000","message":"i added a comment.","commit_id":"5eb1d93eda21c9ea01f6dc9fd11fda41a0b92bda"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"faf2ee23640b75611bf08ac30b90429ab97ba5d4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # the agent rpc_loop runs in another thread.  However, for FT we need"},{"line_number":56,"context_line":"        # to run setUp() and test_xxx() in the same thread.  So I made this"},{"line_number":57,"context_line":"        # run of_interface\u0027s main in a separate thread instead."},{"line_number":58,"context_line":"        while not self.init_done:"},{"line_number":59,"context_line":"            self.init_done_ev.wait()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _kick_main(self):"}],"source_content_type":"text/x-python","patch_set":61,"id":"7a016987_574ae955","line":58,"updated":"2015-05-25 09:12:29.000000000","message":"Isn\u0027t it better to set some timeout?","commit_id":"ad118015ae59a945dedb8f20dbd7729ff4b45170"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1b5223fd947bf4c1acdf200045139afd39531734","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        # the agent rpc_loop runs in another thread.  However, for FT we need"},{"line_number":56,"context_line":"        # to run setUp() and test_xxx() in the same thread.  So I made this"},{"line_number":57,"context_line":"        # run of_interface\u0027s main in a separate thread instead."},{"line_number":58,"context_line":"        while not self.init_done:"},{"line_number":59,"context_line":"            self.init_done_ev.wait()"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _kick_main(self):"}],"source_content_type":"text/x-python","patch_set":61,"id":"7a016987_0d29008a","line":58,"in_reply_to":"7a016987_574ae955","updated":"2015-05-25 09:48:37.000000000","message":"it just waits for the other thread to execute some code.\nno long-blocking calls (like waiting for a tcp connection) are involved.","commit_id":"ad118015ae59a945dedb8f20dbd7729ff4b45170"}]}
