)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f1fbc3f7299e62f4c67738e084bd583a5012e1fa","unresolved":false,"context_lines":[{"line_number":16,"context_line":"The mechanism driver implements the abstract method given in"},{"line_number":17,"context_line":"mech_agent.SimpleAgentMechanismDriverBase"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: 1426365"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I57b2abb58671b8a1c6a2734959346ddeb8fda988"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba7be1f8_53bd91d6","line":19,"updated":"2015-03-02 07:59:23.000000000","message":"please target the core-vendor-decomposition blueprint spec.","commit_id":"8db7c8ffb8b3ed93ad4c163129895ec8653a6f62"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9e5619fb514234edbf15cfcf144ed7bf72e63cf4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"The mechanism driver implements the abstract method given in"},{"line_number":17,"context_line":"mech_agent.SimpleAgentMechanismDriverBase."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: 1426365"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I57b2abb58671b8a1c6a2734959346ddeb8fda988"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_c3a269ad","line":19,"updated":"2015-03-12 21:54:26.000000000","message":"hello?","commit_id":"137ebe539eb0d81705ccef12d701a0244eb58446"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"9ce876753381ff56a9b22251e6b79e1b8b83981d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"The mechanism driver implements the abstract method given in"},{"line_number":17,"context_line":"mech_agent.SimpleAgentMechanismDriverBase."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: 1426365"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I57b2abb58671b8a1c6a2734959346ddeb8fda988"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_d5176dec","line":19,"in_reply_to":"9a80dd14_55a37dff","updated":"2015-03-13 06:07:55.000000000","message":"You mean Do I need to add this in the commit msg?\n\nPartially-implements: blueprint core-vendor-decomposition","commit_id":"137ebe539eb0d81705ccef12d701a0244eb58446"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7a4d01b0e08cc5bceeed9c0ccba8c1debd6688a1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"The mechanism driver implements the abstract method given in"},{"line_number":17,"context_line":"mech_agent.SimpleAgentMechanismDriverBase."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: 1426365"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I57b2abb58671b8a1c6a2734959346ddeb8fda988"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_55a37dff","line":19,"in_reply_to":"9a80dd14_c3297c9c","updated":"2015-03-13 05:59:03.000000000","message":"you did not address my comment on PS1","commit_id":"137ebe539eb0d81705ccef12d701a0244eb58446"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"5a80f7daa1d4ac8d40f9334eebd48dc3cf31c5cd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"The mechanism driver implements the abstract method given in"},{"line_number":17,"context_line":"mech_agent.SimpleAgentMechanismDriverBase."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: 1426365"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I57b2abb58671b8a1c6a2734959346ddeb8fda988"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a80dd14_c3297c9c","line":19,"in_reply_to":"9a80dd14_c3a269ad","updated":"2015-03-13 04:28:09.000000000","message":"Hi :)\n\nSorry, I didn\u0027t get you.","commit_id":"137ebe539eb0d81705ccef12d701a0244eb58446"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0ef6b8d3af8d506c2f0dd0137d2fe4a0c7b05cad","unresolved":false,"context_lines":[{"line_number":13,"context_line":"We need to have thin mechanism driver in neutron which integrates"},{"line_number":14,"context_line":"the ml2 plugin with the OVSvApp L2 Agent."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The mechanism driver implements the abstract method given in"},{"line_number":17,"context_line":"mech_agent.SimpleAgentMechanismDriverBase."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: 1426365"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_21a0d8a4","line":16,"updated":"2015-03-18 01:13:56.000000000","message":"can you take care of [1]. It\u0027s probably best to remove it.\n\n[1] https://github.com/openstack/neutron/blob/master/doc/source/devref/contribute.rst#networking-vsphere","commit_id":"d4dd1db9a75568c116a03cff2e778fc92f58d7a0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3e4fa9a80062942807700a140aa60aaddfa6208b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"We need to have thin mechanism driver in neutron which integrates"},{"line_number":14,"context_line":"the ml2 plugin with the OVSvApp L2 Agent."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The mechanism driver implements the abstract method given in"},{"line_number":17,"context_line":"mech_agent.SimpleAgentMechanismDriverBase."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: 1426365"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_014834b2","line":16,"in_reply_to":"9a80dd14_21a0d8a4","updated":"2015-03-18 01:24:51.000000000","message":"never mind, I took care of it here:\n\n[1] https://review.openstack.org/#/c/165267/","commit_id":"d4dd1db9a75568c116a03cff2e778fc92f58d7a0"}],"neutron/plugins/ml2/drivers/ovsvapp/mech_driver.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f1fbc3f7299e62f4c67738e084bd583a5012e1fa","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class OVSvAppAgentMechanismDriver(mech_agent.SimpleAgentMechanismDriverBase):"},{"line_number":29,"context_line":"    \"\"\"Attach to networks using OVSvApp Agent."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    The OVSvAppAgentMechanismDriver integrates the ml2 plugin with the"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_f3c76562","line":28,"updated":"2015-03-02 07:59:23.000000000","message":"This driver has configs he needs to work with, do you intend to maintain these (and its respective ini file) here?","commit_id":"8db7c8ffb8b3ed93ad4c163129895ec8653a6f62"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"bc85f503ec4c438dbc60293c59074c5d2ac24f66","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class OVSvAppAgentMechanismDriver(mech_agent.SimpleAgentMechanismDriverBase):"},{"line_number":29,"context_line":"    \"\"\"Attach to networks using OVSvApp Agent."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    The OVSvAppAgentMechanismDriver integrates the ml2 plugin with the"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_2e7996fc","line":28,"in_reply_to":"ba7be1f8_4e85ea57","updated":"2015-03-02 08:57:28.000000000","message":"Done","commit_id":"8db7c8ffb8b3ed93ad4c163129895ec8653a6f62"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"964beaa64705fbf27edb9488ef4a3a9200b1f5b8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class OVSvAppAgentMechanismDriver(mech_agent.SimpleAgentMechanismDriverBase):"},{"line_number":29,"context_line":"    \"\"\"Attach to networks using OVSvApp Agent."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    The OVSvAppAgentMechanismDriver integrates the ml2 plugin with the"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_4e85ea57","line":28,"in_reply_to":"ba7be1f8_53f11169","updated":"2015-03-02 08:23:23.000000000","message":"understood. If you like, though, you could also include the entry point for the agent\u0027s main(), in which case including the .ini would be useful. Please get familiar with the decomp blueprint spec.","commit_id":"8db7c8ffb8b3ed93ad4c163129895ec8653a6f62"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"be8a959f620972269e919c42d791a5c6836d2b72","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class OVSvAppAgentMechanismDriver(mech_agent.SimpleAgentMechanismDriverBase):"},{"line_number":29,"context_line":"    \"\"\"Attach to networks using OVSvApp Agent."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    The OVSvAppAgentMechanismDriver integrates the ml2 plugin with the"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_53f11169","line":28,"in_reply_to":"ba7be1f8_f3c76562","updated":"2015-03-02 08:09:34.000000000","message":"The configs we have for OVSvApp L2 agent. We do not have any special config for OVSvApp mechanism driver. We are using these configs in ml2_conf.ini to load this:\n\n [ml2]\n tenant_network_types \u003d vlan, vxlan\n type_drivers \u003d local,flat,vlan,gre,vxlan\n mechanism_drivers \u003d ovsvapp,logger","commit_id":"8db7c8ffb8b3ed93ad4c163129895ec8653a6f62"}],"setup.cfg":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f1fbc3f7299e62f4c67738e084bd583a5012e1fa","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    gre \u003d neutron.plugins.ml2.drivers.type_gre:GreTypeDriver"},{"line_number":164,"context_line":"    vxlan \u003d neutron.plugins.ml2.drivers.type_vxlan:VxlanTypeDriver"},{"line_number":165,"context_line":"neutron.ml2.mechanism_drivers \u003d"},{"line_number":166,"context_line":"    ovsvapp \u003d neutron.plugins.ml2.drivers.ovsvapp.mech_driver:OVSvAppAgentMechanismDriver"},{"line_number":167,"context_line":"    opendaylight \u003d neutron.plugins.ml2.drivers.opendaylight.driver:OpenDaylightMechanismDriver"},{"line_number":168,"context_line":"    logger \u003d neutron.tests.unit.ml2.drivers.mechanism_logger:LoggerMechanismDriver"},{"line_number":169,"context_line":"    test \u003d neutron.tests.unit.ml2.drivers.mechanism_test:TestMechanismDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ba7be1f8_139a396e","line":166,"updated":"2015-03-02 07:59:23.000000000","message":"what about the ini file?","commit_id":"8db7c8ffb8b3ed93ad4c163129895ec8653a6f62"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"be8a959f620972269e919c42d791a5c6836d2b72","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    gre \u003d neutron.plugins.ml2.drivers.type_gre:GreTypeDriver"},{"line_number":164,"context_line":"    vxlan \u003d neutron.plugins.ml2.drivers.type_vxlan:VxlanTypeDriver"},{"line_number":165,"context_line":"neutron.ml2.mechanism_drivers \u003d"},{"line_number":166,"context_line":"    ovsvapp \u003d neutron.plugins.ml2.drivers.ovsvapp.mech_driver:OVSvAppAgentMechanismDriver"},{"line_number":167,"context_line":"    opendaylight \u003d neutron.plugins.ml2.drivers.opendaylight.driver:OpenDaylightMechanismDriver"},{"line_number":168,"context_line":"    logger \u003d neutron.tests.unit.ml2.drivers.mechanism_logger:LoggerMechanismDriver"},{"line_number":169,"context_line":"    test \u003d neutron.tests.unit.ml2.drivers.mechanism_test:TestMechanismDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ba7be1f8_537cb1eb","line":166,"in_reply_to":"ba7be1f8_139a396e","updated":"2015-03-02 08:09:34.000000000","message":"ovsvapp_agent.ini is basically for OVSvApp L2 agent, Hence, I feel it should be under stackforge/networking-vsphere.","commit_id":"8db7c8ffb8b3ed93ad4c163129895ec8653a6f62"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"964beaa64705fbf27edb9488ef4a3a9200b1f5b8","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    gre \u003d neutron.plugins.ml2.drivers.type_gre:GreTypeDriver"},{"line_number":164,"context_line":"    vxlan \u003d neutron.plugins.ml2.drivers.type_vxlan:VxlanTypeDriver"},{"line_number":165,"context_line":"neutron.ml2.mechanism_drivers \u003d"},{"line_number":166,"context_line":"    ovsvapp \u003d neutron.plugins.ml2.drivers.ovsvapp.mech_driver:OVSvAppAgentMechanismDriver"},{"line_number":167,"context_line":"    opendaylight \u003d neutron.plugins.ml2.drivers.opendaylight.driver:OpenDaylightMechanismDriver"},{"line_number":168,"context_line":"    logger \u003d neutron.tests.unit.ml2.drivers.mechanism_logger:LoggerMechanismDriver"},{"line_number":169,"context_line":"    test \u003d neutron.tests.unit.ml2.drivers.mechanism_test:TestMechanismDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ba7be1f8_6ef38e0a","line":166,"in_reply_to":"ba7be1f8_537cb1eb","updated":"2015-03-02 08:23:23.000000000","message":"understood. If the driver does require a special agent, your choice is to contribute the agent\u0027s main() too.","commit_id":"8db7c8ffb8b3ed93ad4c163129895ec8653a6f62"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"bc85f503ec4c438dbc60293c59074c5d2ac24f66","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    gre \u003d neutron.plugins.ml2.drivers.type_gre:GreTypeDriver"},{"line_number":164,"context_line":"    vxlan \u003d neutron.plugins.ml2.drivers.type_vxlan:VxlanTypeDriver"},{"line_number":165,"context_line":"neutron.ml2.mechanism_drivers \u003d"},{"line_number":166,"context_line":"    ovsvapp \u003d neutron.plugins.ml2.drivers.ovsvapp.mech_driver:OVSvAppAgentMechanismDriver"},{"line_number":167,"context_line":"    opendaylight \u003d neutron.plugins.ml2.drivers.opendaylight.driver:OpenDaylightMechanismDriver"},{"line_number":168,"context_line":"    logger \u003d neutron.tests.unit.ml2.drivers.mechanism_logger:LoggerMechanismDriver"},{"line_number":169,"context_line":"    test \u003d neutron.tests.unit.ml2.drivers.mechanism_test:TestMechanismDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ba7be1f8_ee1f7eb5","line":166,"in_reply_to":"ba7be1f8_6ef38e0a","updated":"2015-03-02 08:57:28.000000000","message":"Done","commit_id":"8db7c8ffb8b3ed93ad4c163129895ec8653a6f62"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9e5619fb514234edbf15cfcf144ed7bf72e63cf4","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"[entry_points]"},{"line_number":91,"context_line":"console_scripts \u003d"},{"line_number":92,"context_line":"    neutron-ovsvapp-agent \u003d networking_vsphere.service:main"},{"line_number":93,"context_line":"    neutron-cisco-cfg-agent \u003d networking_cisco.plugins.cisco.cfg_agent.cfg_agent:main"},{"line_number":94,"context_line":"    neutron-db-manage \u003d neutron.db.migration.cli:main"},{"line_number":95,"context_line":"    neutron-debug \u003d neutron.debug.shell:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9a80dd14_0333a162","line":92,"updated":"2015-03-12 21:54:26.000000000","message":"not sure if we should have entry points that have direct external dependencies. If you want to have this here, it\u0027s probably best to include the main inside the neutron tree itself.\n\nAs for the line below. I\u0027ll reach out to Henry, as this might have been merged by accident.","commit_id":"137ebe539eb0d81705ccef12d701a0244eb58446"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"5a80f7daa1d4ac8d40f9334eebd48dc3cf31c5cd","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"[entry_points]"},{"line_number":91,"context_line":"console_scripts \u003d"},{"line_number":92,"context_line":"    neutron-ovsvapp-agent \u003d networking_vsphere.service:main"},{"line_number":93,"context_line":"    neutron-cisco-cfg-agent \u003d networking_cisco.plugins.cisco.cfg_agent.cfg_agent:main"},{"line_number":94,"context_line":"    neutron-db-manage \u003d neutron.db.migration.cli:main"},{"line_number":95,"context_line":"    neutron-debug \u003d neutron.debug.shell:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9a80dd14_433e6cdb","line":92,"in_reply_to":"9a80dd14_0333a162","updated":"2015-03-13 04:28:09.000000000","message":"Sure, do let me know I will update the patchset accordingly :)","commit_id":"137ebe539eb0d81705ccef12d701a0244eb58446"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7a4d01b0e08cc5bceeed9c0ccba8c1debd6688a1","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"[entry_points]"},{"line_number":91,"context_line":"console_scripts \u003d"},{"line_number":92,"context_line":"    neutron-ovsvapp-agent \u003d networking_vsphere.service:main"},{"line_number":93,"context_line":"    neutron-cisco-cfg-agent \u003d networking_cisco.plugins.cisco.cfg_agent.cfg_agent:main"},{"line_number":94,"context_line":"    neutron-db-manage \u003d neutron.db.migration.cli:main"},{"line_number":95,"context_line":"    neutron-debug \u003d neutron.debug.shell:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9a80dd14_d58dad7d","line":92,"in_reply_to":"9a80dd14_433e6cdb","updated":"2015-03-13 05:59:03.000000000","message":"This entry point must be removed, as is.\n\nIf you want to keep it here, it should not point to an external dependency, but to an main() that\u0027s in-tree, like the nec-agent.","commit_id":"137ebe539eb0d81705ccef12d701a0244eb58446"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"9ce876753381ff56a9b22251e6b79e1b8b83981d","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"[entry_points]"},{"line_number":91,"context_line":"console_scripts \u003d"},{"line_number":92,"context_line":"    neutron-ovsvapp-agent \u003d networking_vsphere.service:main"},{"line_number":93,"context_line":"    neutron-cisco-cfg-agent \u003d networking_cisco.plugins.cisco.cfg_agent.cfg_agent:main"},{"line_number":94,"context_line":"    neutron-db-manage \u003d neutron.db.migration.cli:main"},{"line_number":95,"context_line":"    neutron-debug \u003d neutron.debug.shell:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9a80dd14_55db7d4e","line":92,"in_reply_to":"9a80dd14_d58dad7d","updated":"2015-03-13 06:07:55.000000000","message":"Thanks for the clarification.","commit_id":"137ebe539eb0d81705ccef12d701a0244eb58446"}]}