)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"579a8361efbabd2d420ec2526037450550389a77","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix dvr update for subnet attach mutli subnets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug: #1427122"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fix method dvr_update_router_addvm to notify every"},{"line_number":12,"context_line":"routers attached to subnet where the vm will boot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_102c4a4a","line":9,"updated":"2015-03-04 07:09:34.000000000","message":"This should be Closes-Bug: #1427122 and it should above Change-Id. See https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"531276172f75c4faeadcc39181f0a472a1646b2d"},{"author":{"_account_id":6502,"name":"Andrey Epifanov","email":"aepifanov@mirantis.com","username":"aepifanov"},"change_message_id":"20c8b16c1e3700973a01b1c9cba32afc0ea2d12d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix dvr update for subnet attach mutli subnets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug: #1427122"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fix method dvr_update_router_addvm to notify every"},{"line_number":12,"context_line":"routers attached to subnet where the vm will boot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa963961_65e4000d","line":9,"updated":"2015-03-26 13:46:42.000000000","message":"Please use Closes-Bug: #1427122 instead of just Bug:","commit_id":"58505f8e68903938f6d0c7af0bf7caf34dd0dabc"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"70e7c717ae147d9a41ea1f493510c04be100ea4f","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"But when a subnet attaches multiple routers, get_ports in"},{"line_number":20,"context_line":"this method will return all distributed router interfaces"},{"line_number":21,"context_line":"and the routers hold thoes interfaces should be notified"},{"line_number":22,"context_line":"when an instance booted on the subnet. So it should also"},{"line_number":23,"context_line":"be unnecessary to break in for loop."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da20952f_11c79713","line":21,"updated":"2015-08-26 20:29:38.000000000","message":"typo: those","commit_id":"9c65d3382374a82f720a16128f0a678f4e67d31a"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"167d5495089c82c1661c64ec70c8b9f373a01cd3","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"But when a subnet attaches multiple routers, get_ports in"},{"line_number":20,"context_line":"this method will return all distributed router interfaces"},{"line_number":21,"context_line":"and the routers hold thoes interfaces should be notified"},{"line_number":22,"context_line":"when an instance booted on the subnet. So it should also"},{"line_number":23,"context_line":"be unnecessary to break in for loop."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da20952f_079af5c5","line":21,"in_reply_to":"da20952f_11c79713","updated":"2015-09-01 18:11:18.000000000","message":"Done","commit_id":"9c65d3382374a82f720a16128f0a678f4e67d31a"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8fc8ad974a3b8252b08851dac80266bf701dbdc6","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            filter_sub \u003d {\u0027fixed_ips\u0027: {\u0027subnet_id\u0027: [subnet]},"},{"line_number":106,"context_line":"                          \u0027device_owner\u0027:"},{"line_number":107,"context_line":"                          [n_const.DEVICE_OWNER_DVR_INTERFACE]}"},{"line_number":108,"context_line":"            router_id \u003d None"},{"line_number":109,"context_line":"            ports \u003d self._core_plugin.get_ports(context, filters\u003dfilter_sub)"},{"line_number":110,"context_line":"            # ports is not just a list, but a list of a list, so go through"},{"line_number":111,"context_line":"            # the first element"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_471c3a77","line":108,"updated":"2015-08-27 19:08:16.000000000","message":"This is no longer required as router_id is only used in the for() loop now after it\u0027s been assigned.","commit_id":"9c65d3382374a82f720a16128f0a678f4e67d31a"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"4cae868d87ea49e814cdee5fa7b42fa7a765aef2","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            filter_sub \u003d {\u0027fixed_ips\u0027: {\u0027subnet_id\u0027: [subnet]},"},{"line_number":106,"context_line":"                          \u0027device_owner\u0027:"},{"line_number":107,"context_line":"                          [n_const.DEVICE_OWNER_DVR_INTERFACE]}"},{"line_number":108,"context_line":"            router_id \u003d None"},{"line_number":109,"context_line":"            ports \u003d self._core_plugin.get_ports(context, filters\u003dfilter_sub)"},{"line_number":110,"context_line":"            # ports is not just a list, but a list of a list, so go through"},{"line_number":111,"context_line":"            # the first element"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_ac5a0e4f","line":108,"in_reply_to":"da20952f_471c3a77","updated":"2015-09-01 18:10:46.000000000","message":"Done","commit_id":"9c65d3382374a82f720a16128f0a678f4e67d31a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8fc8ad974a3b8252b08851dac80266bf701dbdc6","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                          \u0027device_owner\u0027:"},{"line_number":107,"context_line":"                          [n_const.DEVICE_OWNER_DVR_INTERFACE]}"},{"line_number":108,"context_line":"            router_id \u003d None"},{"line_number":109,"context_line":"            ports \u003d self._core_plugin.get_ports(context, filters\u003dfilter_sub)"},{"line_number":110,"context_line":"            # ports is not just a list, but a list of a list, so go through"},{"line_number":111,"context_line":"            # the first element"},{"line_number":112,"context_line":"            for port in ports[0]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_40389ba0","line":109,"updated":"2015-08-27 19:08:16.000000000","message":"So I know it\u0027s a nit, but maybe it\u0027s worthwhile to break out this filter and the get_ports call, something like _get_agent_gw_ports_exist_for_network, that way it can return ports[0] and keep this cleaner.  Just a thought.","commit_id":"9c65d3382374a82f720a16128f0a678f4e67d31a"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"4cae868d87ea49e814cdee5fa7b42fa7a765aef2","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                          \u0027device_owner\u0027:"},{"line_number":107,"context_line":"                          [n_const.DEVICE_OWNER_DVR_INTERFACE]}"},{"line_number":108,"context_line":"            router_id \u003d None"},{"line_number":109,"context_line":"            ports \u003d self._core_plugin.get_ports(context, filters\u003dfilter_sub)"},{"line_number":110,"context_line":"            # ports is not just a list, but a list of a list, so go through"},{"line_number":111,"context_line":"            # the first element"},{"line_number":112,"context_line":"            for port in ports[0]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_8c0b8a2b","line":109,"in_reply_to":"da20952f_40389ba0","updated":"2015-09-01 18:10:46.000000000","message":"Honestly, I\u0027d rather leave that for another patchset","commit_id":"9c65d3382374a82f720a16128f0a678f4e67d31a"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"dc7a2cf79970a06bc92598e618ea9282d1041503","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                          [n_const.DEVICE_OWNER_DVR_INTERFACE]}"},{"line_number":109,"context_line":"            ports \u003d self._core_plugin.get_ports(context, filters\u003dfilter_sub)"},{"line_number":110,"context_line":"            # ports is not just a list, but a list of a list, so go through"},{"line_number":111,"context_line":"            # the first element"},{"line_number":112,"context_line":"            for port in ports[0]:"},{"line_number":113,"context_line":"                router_id \u003d port[\u0027device_id\u0027]"},{"line_number":114,"context_line":"                router_dict \u003d self.get_router(context, router_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_61f078ca","line":111,"updated":"2015-09-01 20:49:01.000000000","message":"?? not sure what you mean here. which plugin are you refereing to?. I tested with \n/opt/stack/neutron/neutron/db/db_base_plugin_v2.py and in the case where a subnet has two dvr routers attached to it, it returns a list of dictionaries, not a list of lists. The line \"fort port in ports[0]\" returns a \n***KeyError : 0","commit_id":"dfa88e96e8d60214ec1be00736daa64929cf9d73"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"4b89480d5746b0516793bc4534c288449880c245","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                          [n_const.DEVICE_OWNER_DVR_INTERFACE]}"},{"line_number":109,"context_line":"            ports \u003d self._core_plugin.get_ports(context, filters\u003dfilter_sub)"},{"line_number":110,"context_line":"            # ports is not just a list, but a list of a list, so go through"},{"line_number":111,"context_line":"            # the first element"},{"line_number":112,"context_line":"            for port in ports[0]:"},{"line_number":113,"context_line":"                router_id \u003d port[\u0027device_id\u0027]"},{"line_number":114,"context_line":"                router_dict \u003d self.get_router(context, router_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_50117fae","line":111,"in_reply_to":"da20952f_61f078ca","updated":"2015-09-01 21:38:27.000000000","message":"Yes, this change was needed at one point and leaked through one of the rebases.  Am removing it.","commit_id":"dfa88e96e8d60214ec1be00736daa64929cf9d73"}],"neutron/tests/unit/scheduler/test_l3_agent_scheduler.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8fc8ad974a3b8252b08851dac80266bf701dbdc6","unresolved":false,"context_lines":[{"line_number":992,"context_line":"                self.dut.l3_rpc_notifier.routers_updated("},{"line_number":993,"context_line":"                    self.adminContext, [\u0027r2\u0027], None, payload)"},{"line_number":994,"context_line":"            ]"},{"line_number":995,"context_line":"            self.dut.l3_rpc_notifier.routers_updatedssert_has_calls(calls,"},{"line_number":996,"context_line":"                                                             any_order\u003dTrue)"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"    def test_get_dvr_routers_by_portid(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_3b759f97","line":995,"updated":"2015-08-27 19:08:16.000000000","message":"updatedssert_has_calls ?","commit_id":"9c65d3382374a82f720a16128f0a678f4e67d31a"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"4cae868d87ea49e814cdee5fa7b42fa7a765aef2","unresolved":false,"context_lines":[{"line_number":992,"context_line":"                self.dut.l3_rpc_notifier.routers_updated("},{"line_number":993,"context_line":"                    self.adminContext, [\u0027r2\u0027], None, payload)"},{"line_number":994,"context_line":"            ]"},{"line_number":995,"context_line":"            self.dut.l3_rpc_notifier.routers_updatedssert_has_calls(calls,"},{"line_number":996,"context_line":"                                                             any_order\u003dTrue)"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"    def test_get_dvr_routers_by_portid(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_47330df7","line":995,"in_reply_to":"da20952f_3b759f97","updated":"2015-09-01 18:10:46.000000000","message":"I have no idea how that happened.... but fixed","commit_id":"9c65d3382374a82f720a16128f0a678f4e67d31a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e535f07cce48be69cd8c51d0449de9389fc2cbc6","unresolved":false,"context_lines":[{"line_number":995,"context_line":"                           \u0027.L3AgentNotifyAPI\u0027):"},{"line_number":996,"context_line":"            self.dut.dvr_update_router_addvm(self.adminContext, port)"},{"line_number":997,"context_line":"            self.assertEqual("},{"line_number":998,"context_line":"                self.dut.l3_rpc_notifier.routers_updated.call_count, 2)"},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"    def test_get_dvr_routers_by_portid(self):"},{"line_number":1001,"context_line":"        dvr_port \u003d {"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_f823d1bc","line":998,"updated":"2015-09-08 21:53:27.000000000","message":"I\u0027d feel a little better if this checked the details of the calls.","commit_id":"7fc6cdb558ac5b8305a55fc94d0d9110e4773715"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"f033d2d92065486da56fab35820356a037445f17","unresolved":false,"context_lines":[{"line_number":995,"context_line":"                           \u0027.L3AgentNotifyAPI\u0027):"},{"line_number":996,"context_line":"            self.dut.dvr_update_router_addvm(self.adminContext, port)"},{"line_number":997,"context_line":"            self.assertEqual("},{"line_number":998,"context_line":"                self.dut.l3_rpc_notifier.routers_updated.call_count, 2)"},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"    def test_get_dvr_routers_by_portid(self):"},{"line_number":1001,"context_line":"        dvr_port \u003d {"}],"source_content_type":"text/x-python","patch_set":12,"id":"da20952f_fb717045","line":998,"in_reply_to":"da20952f_f823d1bc","updated":"2015-09-09 13:17:53.000000000","message":"Done","commit_id":"7fc6cdb558ac5b8305a55fc94d0d9110e4773715"}],"neutron/tests/unit/test_l3_schedulers.py":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"579a8361efbabd2d420ec2526037450550389a77","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        super(L3DvrSchedulerTestCase, self).setUp()"},{"line_number":826,"context_line":"        self.adminContext \u003d q_context.get_admin_context()"},{"line_number":827,"context_line":"        self.dut \u003d L3DvrScheduler()"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"    def test_dvr_update_router_addvm(self):"},{"line_number":830,"context_line":"        port \u003d {"},{"line_number":831,"context_line":"                \u0027device_id\u0027: \u0027abcd\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_90dcba76","line":828,"updated":"2015-03-04 07:09:34.000000000","message":"Suggest to write a separate test case for one subnet on two routers as described in the bug report.","commit_id":"531276172f75c4faeadcc39181f0a472a1646b2d"}]}
