)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c5c27f0df47f0c08f245577a625eede0e6df7700","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- database models (and a module with constants they use)"},{"line_number":13,"context_line":"- integration module pointing to the external repository"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"A new plugin whose business logic is contained in"},{"line_number":16,"context_line":"stackforge/vmware-nsx is also added to the integration module"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I8a01a977889b36015a9cfa900173c05bfd516457"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_a2eeaf20","line":15,"updated":"2015-03-04 22:40:31.000000000","message":"I still don\u0027t fully understand why this needs to be part of the same patch, rather than a patch on its own, which IMO is what you should be doing. Can you elaborate why are you combining the two?","commit_id":"85adbd52bdb6a1ebd44caa49719e292b093903a5"}],"neutron/plugins/vmware/extensions/networkgw.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"73150a2144b8cc34d8132a913d95d387811e6d53","unresolved":false,"context_lines":[{"line_number":29,"context_line":"DEVICE_ID_ATTR \u003d \u0027id\u0027"},{"line_number":30,"context_line":"IFACE_NAME_ATTR \u003d \u0027interface_name\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# TODO(salv-orlando): This type definition is duplicated into"},{"line_number":33,"context_line":"# stackforge/vmware-nsx. This temporary duplication should be removed once the"},{"line_number":34,"context_line":"# plugin decomposition is finished."},{"line_number":35,"context_line":"# Allowed network types for the NSX Plugin"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba7be1f8_0a92944b","line":32,"updated":"2015-03-04 01:13:47.000000000","message":"why does it matter? Why doesn\u0027t we remove this file all together as well ?","commit_id":"ca9478adb7c4d9ffd2ea046e5dbf27048f247ad6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"c072b0e03c5705a538e10026dd8bcd517e67350a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"DEVICE_ID_ATTR \u003d \u0027id\u0027"},{"line_number":30,"context_line":"IFACE_NAME_ATTR \u003d \u0027interface_name\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# TODO(salv-orlando): This type definition is duplicated into"},{"line_number":33,"context_line":"# stackforge/vmware-nsx. This temporary duplication should be removed once the"},{"line_number":34,"context_line":"# plugin decomposition is finished."},{"line_number":35,"context_line":"# Allowed network types for the NSX Plugin"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_bf67c2e9","line":32,"in_reply_to":"ba7be1f8_0a92944b","updated":"2015-03-04 12:00:50.000000000","message":"for reasons that are not entirely clear to me it was agreed to keep API extensions in tree.\n\nI believe it\u0027s not necessary, but I\u0027m just a humble servant","commit_id":"ca9478adb7c4d9ffd2ea046e5dbf27048f247ad6"}],"neutron/plugins/vmware/plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a7d3b351158493b186fcadec76ebe42aa3e181b4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# and replaced by the \u0027NsxMhPlugin\u0027 name"},{"line_number":24,"context_line":"NsxPlugin \u003d NsxMhPlugin"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"NsxVPlugin \u003d nsx_v.NsxVPluginV2"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_8237fdaf","line":26,"updated":"2015-03-04 16:17:10.000000000","message":"there\u0027s no entry point for this (new) plugin. Shall this be introduced with a different patch?","commit_id":"3ebed48e0b0e3f63d2e16564940880b9fdad8ba3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d29fd2e0329166e31d0f4eb8a683f2b8676c9e0a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# and replaced by the \u0027NsxMhPlugin\u0027 name"},{"line_number":24,"context_line":"NsxPlugin \u003d NsxMhPlugin"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"NsxVPlugin \u003d nsx_v.NsxVPluginV2"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_f2995a6f","line":26,"in_reply_to":"9a80dd14_1288ae1e","updated":"2015-03-04 20:55:04.000000000","message":"because I want to get this done, unless you feel the process has to be atomic.","commit_id":"3ebed48e0b0e3f63d2e16564940880b9fdad8ba3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"b08a70bc250f3246a000e42a35280000d9687f4d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# and replaced by the \u0027NsxMhPlugin\u0027 name"},{"line_number":24,"context_line":"NsxPlugin \u003d NsxMhPlugin"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"NsxVPlugin \u003d nsx_v.NsxVPluginV2"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_4c344ade","line":26,"in_reply_to":"9a80dd14_523ce62f","updated":"2015-03-04 21:52:45.000000000","message":"I respectfully invite you to be less aggressive when performing your task as a reviewer. Your tone is intimidatory and makes me feel insecure and vulnerable.","commit_id":"3ebed48e0b0e3f63d2e16564940880b9fdad8ba3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"4ebc90e94b3c018682a9b5250a73e26edcff19a4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# and replaced by the \u0027NsxMhPlugin\u0027 name"},{"line_number":24,"context_line":"NsxPlugin \u003d NsxMhPlugin"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"NsxVPlugin \u003d nsx_v.NsxVPluginV2"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_cc1d9f75","line":26,"in_reply_to":"9a80dd14_8237fdaf","updated":"2015-03-04 20:22:32.000000000","message":"this was asked also in the previous patchset... yes there will be in a subsequent patch (still reasoning on naming...)","commit_id":"3ebed48e0b0e3f63d2e16564940880b9fdad8ba3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b46f70737e01da36d863ee62bed10619a9f61d42","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# and replaced by the \u0027NsxMhPlugin\u0027 name"},{"line_number":24,"context_line":"NsxPlugin \u003d NsxMhPlugin"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"NsxVPlugin \u003d nsx_v.NsxVPluginV2"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_1288ae1e","line":26,"in_reply_to":"9a80dd14_cc1d9f75","updated":"2015-03-04 20:54:14.000000000","message":"gotcha; so if this is incomplete and you\u0027re still pondering...let me be pedantic and ask you to defer this change to the follow-up patch you\u0027re planning to file.","commit_id":"3ebed48e0b0e3f63d2e16564940880b9fdad8ba3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"221aeb6e7ac68040ea585e96bfe594f04b046bd4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# and replaced by the \u0027NsxMhPlugin\u0027 name"},{"line_number":24,"context_line":"NsxPlugin \u003d NsxMhPlugin"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"NsxVPlugin \u003d nsx_v.NsxVPluginV2"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_523ce62f","line":26,"in_reply_to":"9a80dd14_f2995a6f","updated":"2015-03-04 20:58:25.000000000","message":"I beg your pardon? What stops you to get \u0027this done\u0027 if you didn\u0027t have line 26?","commit_id":"3ebed48e0b0e3f63d2e16564940880b9fdad8ba3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c5c27f0df47f0c08f245577a625eede0e6df7700","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# and replaced by the \u0027NsxMhPlugin\u0027 name"},{"line_number":24,"context_line":"NsxPlugin \u003d NsxMhPlugin"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"NsxVPlugin \u003d nsx_v.NsxVPluginV2"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_623117ec","line":26,"updated":"2015-03-04 22:40:31.000000000","message":"so I am slightly confused now...what plugin is the VMware CI testing? Can you clarify?","commit_id":"85adbd52bdb6a1ebd44caa49719e292b093903a5"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"cf174c48d8ce5e3a7227faed714dcbe8e82f0aaa","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from vmware_nsx.neutron.plugins.vmware.plugins import base as nsx_mh"},{"line_number":19,"context_line":"from vmware_nsx.neutron.plugins.vmware.plugins import nsx_v"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"NsxMhPlugin \u003d nsx_mh.NsxPluginV2"},{"line_number":22,"context_line":"# The \u0027NsxPlugin\u0027 name will be deprecated in Liberty"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_e86874f7","line":19,"updated":"2015-03-05 09:07:48.000000000","message":"unused import","commit_id":"9a55f9ab3957fd6d4d41773ac52566876ea562b9"}],"setup.cfg":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"243cf7049a2b97c0e680a2a45b22bdfda0cee770","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    metaplugin \u003d neutron.plugins.metaplugin.meta_neutron_plugin:MetaPluginV2"},{"line_number":130,"context_line":"    oneconvergence \u003d neutron.plugins.oneconvergence.plugin:OneConvergencePluginV2"},{"line_number":131,"context_line":"    plumgrid \u003d neutron.plugins.plumgrid.plumgrid_plugin.plumgrid_plugin:NeutronPluginPLUMgridV2"},{"line_number":132,"context_line":"    vmware \u003d neutron.plugins.vmware.plugin:NsxPlugin"},{"line_number":133,"context_line":"neutron.service_plugins \u003d"},{"line_number":134,"context_line":"    dummy \u003d neutron.tests.unit.dummy_plugin:DummyServicePlugin"},{"line_number":135,"context_line":"    router \u003d neutron.services.l3_router.l3_router_plugin:L3RouterPlugin"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"9a80dd14_2d63b9b2","line":132,"updated":"2015-03-04 06:31:51.000000000","message":"don\u0027t you want to update this?\nand how about NsxVPlugin?","commit_id":"ca9478adb7c4d9ffd2ea046e5dbf27048f247ad6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"c072b0e03c5705a538e10026dd8bcd517e67350a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    metaplugin \u003d neutron.plugins.metaplugin.meta_neutron_plugin:MetaPluginV2"},{"line_number":130,"context_line":"    oneconvergence \u003d neutron.plugins.oneconvergence.plugin:OneConvergencePluginV2"},{"line_number":131,"context_line":"    plumgrid \u003d neutron.plugins.plumgrid.plumgrid_plugin.plumgrid_plugin:NeutronPluginPLUMgridV2"},{"line_number":132,"context_line":"    vmware \u003d neutron.plugins.vmware.plugin:NsxPlugin"},{"line_number":133,"context_line":"neutron.service_plugins \u003d"},{"line_number":134,"context_line":"    dummy \u003d neutron.tests.unit.dummy_plugin:DummyServicePlugin"},{"line_number":135,"context_line":"    router \u003d neutron.services.l3_router.l3_router_plugin:L3RouterPlugin"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"9a80dd14_ff8f7a73","line":132,"in_reply_to":"9a80dd14_2d63b9b2","updated":"2015-03-04 12:00:50.000000000","message":"i will add an entry for nsxv in a subsequent patch.\nWe are still completing the external CI, I will then add the entry for the driver.\n\nI don\u0027t want to change the entry for the current plugin in this release cycle, as the consensus is to deprecate the vmware name in the next release.","commit_id":"ca9478adb7c4d9ffd2ea046e5dbf27048f247ad6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2a4a87d75ee109a909251158427d54d4b28321f2","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    oneconvergence \u003d neutron.plugins.oneconvergence.plugin:OneConvergencePluginV2"},{"line_number":131,"context_line":"    plumgrid \u003d neutron.plugins.plumgrid.plumgrid_plugin.plumgrid_plugin:NeutronPluginPLUMgridV2"},{"line_number":132,"context_line":"    vmware \u003d neutron.plugins.vmware.plugin:NsxMhPlugin"},{"line_number":133,"context_line":"    vmware_nsxv \u003d neutron.plugins.vmware.plugin:NsxVPlugin"},{"line_number":134,"context_line":"neutron.service_plugins \u003d"},{"line_number":135,"context_line":"    dummy \u003d neutron.tests.unit.dummy_plugin:DummyServicePlugin"},{"line_number":136,"context_line":"    router \u003d neutron.services.l3_router.l3_router_plugin:L3RouterPlugin"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"9a80dd14_a204ef15","line":133,"updated":"2015-03-04 22:36:14.000000000","message":"does this mean that now we\u0027d need to see 3rd party CI for this plugin too? If so, should you mark this as WIP?","commit_id":"85adbd52bdb6a1ebd44caa49719e292b093903a5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5eb970313ec22231d77c535be7e1020e70779e34","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    neutron-mlnx-agent \u003d neutron.plugins.mlnx.agent.eswitch_neutron_agent:main"},{"line_number":103,"context_line":"    neutron-nec-agent \u003d neutron.plugins.nec.agent.nec_neutron_agent:main"},{"line_number":104,"context_line":"    neutron-netns-cleanup \u003d neutron.cmd.netns_cleanup:main"},{"line_number":105,"context_line":"    neutron-ns-metadata-proxy \u003d neutron.cmd.eventlet.agents.metadata_proxy:main"},{"line_number":106,"context_line":"    neutron-nsx-manage \u003d neutron.plugins.vmware.shell:main"},{"line_number":107,"context_line":"    neutron-nvsd-agent \u003d neutron.plugins.oneconvergence.agent.nvsd_neutron_agent:main"},{"line_number":108,"context_line":"    neutron-openvswitch-agent \u003d neutron.plugins.openvswitch.agent.ovs_neutron_agent:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"9a80dd14_711d5fbd","line":105,"updated":"2015-03-05 00:55:02.000000000","message":"any reason why this is remaining?","commit_id":"9a55f9ab3957fd6d4d41773ac52566876ea562b9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"cf174c48d8ce5e3a7227faed714dcbe8e82f0aaa","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    neutron-nec-agent \u003d neutron.plugins.nec.agent.nec_neutron_agent:main"},{"line_number":104,"context_line":"    neutron-netns-cleanup \u003d neutron.cmd.netns_cleanup:main"},{"line_number":105,"context_line":"    neutron-ns-metadata-proxy \u003d neutron.cmd.eventlet.agents.metadata_proxy:main"},{"line_number":106,"context_line":"    neutron-nsx-manage \u003d neutron.plugins.vmware.shell:main"},{"line_number":107,"context_line":"    neutron-nvsd-agent \u003d neutron.plugins.oneconvergence.agent.nvsd_neutron_agent:main"},{"line_number":108,"context_line":"    neutron-openvswitch-agent \u003d neutron.plugins.openvswitch.agent.ovs_neutron_agent:main"},{"line_number":109,"context_line":"    neutron-ovs-cleanup \u003d neutron.cmd.ovs_cleanup:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"9a80dd14_28a52c53","line":106,"updated":"2015-03-05 09:07:48.000000000","message":"this should be removed","commit_id":"9a55f9ab3957fd6d4d41773ac52566876ea562b9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5c22e392f570d1a45acd9a74836b8f9b47e59b2f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    neutron-nec-agent \u003d neutron.plugins.nec.agent.nec_neutron_agent:main"},{"line_number":103,"context_line":"    neutron-netns-cleanup \u003d neutron.cmd.netns_cleanup:main"},{"line_number":104,"context_line":"    neutron-ns-metadata-proxy \u003d neutron.cmd.eventlet.agents.metadata_proxy:main"},{"line_number":105,"context_line":"    neutron-nsx-manage \u003d neutron.plugins.vmware.shell:main"},{"line_number":106,"context_line":"    neutron-nvsd-agent \u003d neutron.plugins.oneconvergence.agent.nvsd_neutron_agent:main"},{"line_number":107,"context_line":"    neutron-openvswitch-agent \u003d neutron.plugins.openvswitch.agent.ovs_neutron_agent:main"},{"line_number":108,"context_line":"    neutron-ovs-cleanup \u003d neutron.cmd.ovs_cleanup:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"9a80dd14_245f06e7","line":105,"updated":"2015-03-05 14:41:34.000000000","message":"why to keep this?","commit_id":"68b7ae1ebaf7db0b1d532c23c1795decdc34d567"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"38e2627aea051b7917f80cbbf7c1e64b0ac12d48","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    neutron-nec-agent \u003d neutron.plugins.nec.agent.nec_neutron_agent:main"},{"line_number":103,"context_line":"    neutron-netns-cleanup \u003d neutron.cmd.netns_cleanup:main"},{"line_number":104,"context_line":"    neutron-ns-metadata-proxy \u003d neutron.cmd.eventlet.agents.metadata_proxy:main"},{"line_number":105,"context_line":"    neutron-nsx-manage \u003d neutron.plugins.vmware.shell:main"},{"line_number":106,"context_line":"    neutron-nvsd-agent \u003d neutron.plugins.oneconvergence.agent.nvsd_neutron_agent:main"},{"line_number":107,"context_line":"    neutron-openvswitch-agent \u003d neutron.plugins.openvswitch.agent.ovs_neutron_agent:main"},{"line_number":108,"context_line":"    neutron-ovs-cleanup \u003d neutron.cmd.ovs_cleanup:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"9a80dd14_8ad519bb","line":105,"in_reply_to":"9a80dd14_245f06e7","updated":"2015-03-05 15:28:12.000000000","message":"because I forgot to remove it.\nIt\u0027s not doing any harm unless you decide to call it, in which case it will fail.","commit_id":"68b7ae1ebaf7db0b1d532c23c1795decdc34d567"}]}