)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"9c87d6eee5011286071418a51e6bde681f94e923","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"            for port in port_qry.filter("},{"line_number":1116,"context_line":"                and_(models_v2.Port.network_id \u003d\u003d network_id,"},{"line_number":1117,"context_line":"                     models_v2.Port.device_owner"},{"line_number":1118,"context_line":"                     not in constants.ROUTER_INTERFACE_OWNERS)):"},{"line_number":1119,"context_line":"                ip_address \u003d self._calculate_ipv6_eui64_addr("},{"line_number":1120,"context_line":"                    context, subnet, port[\u0027mac_address\u0027])"},{"line_number":1121,"context_line":"                allocated \u003d models_v2.IPAllocation(network_id\u003dnetwork_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_240a6079","line":1118,"updated":"2015-03-03 07:33:45.000000000","message":"I suppose dhcp port should also allocate SLAAC address in this case. Can we add unit test to check dhcp port and router interface port?","commit_id":"7c63871c2d6d08672f552302902b040790f65369"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"2e4e89f9d41f877b969e52794c77283bbe2de48f","unresolved":false,"context_lines":[{"line_number":1115,"context_line":"            for port in port_qry.filter("},{"line_number":1116,"context_line":"                and_(models_v2.Port.network_id \u003d\u003d network_id,"},{"line_number":1117,"context_line":"                     models_v2.Port.device_owner"},{"line_number":1118,"context_line":"                     not in constants.ROUTER_INTERFACE_OWNERS)):"},{"line_number":1119,"context_line":"                ip_address \u003d self._calculate_ipv6_eui64_addr("},{"line_number":1120,"context_line":"                    context, subnet, port[\u0027mac_address\u0027])"},{"line_number":1121,"context_line":"                allocated \u003d models_v2.IPAllocation(network_id\u003dnetwork_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_6ae5eca2","line":1118,"in_reply_to":"ba7be1f8_240a6079","updated":"2015-03-03 15:37:24.000000000","message":"Done","commit_id":"7c63871c2d6d08672f552302902b040790f65369"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"8d2c0b1e9a4be80bc3327f0251b6e6d123c17523","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"                     models_v2.Port.device_owner !\u003d"},{"line_number":1118,"context_line":"                     constants.DEVICE_OWNER_ROUTER_INTF,"},{"line_number":1119,"context_line":"                     models_v2.Port.device_owner !\u003d"},{"line_number":1120,"context_line":"                     constants.DEVICE_OWNER_DVR_INTERFACE)):"},{"line_number":1121,"context_line":"                ip_address \u003d self._calculate_ipv6_eui64_addr("},{"line_number":1122,"context_line":"                    context, subnet, port[\u0027mac_address\u0027])"},{"line_number":1123,"context_line":"                allocated \u003d models_v2.IPAllocation(network_id\u003dnetwork_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_b99682ee","line":1120,"updated":"2015-03-12 22:48:58.000000000","message":"~models_v2.Port.device_owner.in_(q_const.ROUTER_INTERFACE_OWNERS)","commit_id":"5d046f266d59859977d99be97a9b0090aa0fa838"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"6a636999c259e464c6060d9c151ad50d539534f2","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"                     models_v2.Port.device_owner !\u003d"},{"line_number":1118,"context_line":"                     constants.DEVICE_OWNER_ROUTER_INTF,"},{"line_number":1119,"context_line":"                     models_v2.Port.device_owner !\u003d"},{"line_number":1120,"context_line":"                     constants.DEVICE_OWNER_DVR_INTERFACE)):"},{"line_number":1121,"context_line":"                ip_address \u003d self._calculate_ipv6_eui64_addr("},{"line_number":1122,"context_line":"                    context, subnet, port[\u0027mac_address\u0027])"},{"line_number":1123,"context_line":"                allocated \u003d models_v2.IPAllocation(network_id\u003dnetwork_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_7dc22d86","line":1120,"in_reply_to":"9a80dd14_b99682ee","updated":"2015-03-13 02:58:29.000000000","message":"Done","commit_id":"5d046f266d59859977d99be97a9b0090aa0fa838"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6400dfbe96c0f86d403d1baed4db7775232e2877","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"            network_id \u003d subnet[\u0027network_id\u0027]"},{"line_number":1201,"context_line":"            port_qry \u003d context.session.query(models_v2.Port)"},{"line_number":1202,"context_line":"            for port in port_qry.filter("},{"line_number":1203,"context_line":"                and_(models_v2.Port.network_id \u003d\u003d network_id,"},{"line_number":1204,"context_line":"                     ~models_v2.Port.device_owner.in_("},{"line_number":1205,"context_line":"                         constants.ROUTER_INTERFACE_OWNERS))):"},{"line_number":1206,"context_line":"                ip_address \u003d self._calculate_ipv6_eui64_addr("}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_fad78921","line":1203,"updated":"2015-04-01 15:40:03.000000000","message":"I stuck this in the middle:\n\n+                     models_v2.Port.device_owner !\u003d\n+                     constants.DEVICE_OWNER_ROUTER_SNAT,\n\nAnd it seemed to work better, otherwise I was getting an error trying to add an interface on the router in this new subnet.  Do we need a new constant with all the router owners?\n\nBut I also am seeing a complete failure for Floating IPv4 addresses now with this and DVR enabled.  I have not determined yet why that is happening though.\n\nMy local.conf in devstack really just has these two items (in addition to other things to get OVS/ML2 configured):\n\nQ_DVR_MODE\u003ddvr_snat\nIP_VERSION\u003d4+6","commit_id":"c764ef1f040cf82e9f816b657cf07de47be65e95"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"791211b6d1232d2daed33492e6ae78165346389f","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"            network_id \u003d subnet[\u0027network_id\u0027]"},{"line_number":1201,"context_line":"            port_qry \u003d context.session.query(models_v2.Port)"},{"line_number":1202,"context_line":"            for port in port_qry.filter("},{"line_number":1203,"context_line":"                and_(models_v2.Port.network_id \u003d\u003d network_id,"},{"line_number":1204,"context_line":"                     ~models_v2.Port.device_owner.in_("},{"line_number":1205,"context_line":"                         constants.ROUTER_INTERFACE_OWNERS))):"},{"line_number":1206,"context_line":"                ip_address \u003d self._calculate_ipv6_eui64_addr("}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_c0397343","line":1203,"in_reply_to":"baa041b7_27eef98b","updated":"2015-04-01 17:47:03.000000000","message":"Dane, with the devstack patch applied (and my change from above) things worked better, there was only one issue, possibly unrelated, but I could not ping the initial IPv6 address assigned to the VM:\n\n$ ping6 -n fd0d:b4fb:6f1b:0:f816:3eff:fe2b:c6a0\nPING fd0d:b4fb:6f1b:0:f816:3eff:fe2b:c6a0(fd0d:b4fb:6f1b:0:f816:3eff:fe2b:c6a0) 56 data bytes\nFrom fdec:77dc:ebd0::1 icmp_seq\u003d1 Time exceeded: Hop limit\nFrom fdec:77dc:ebd0::1 icmp_seq\u003d2 Time exceeded: Hop limit\n\nThe \"new\" address was fine after adding a route:\n\n$ sudo ip r a fd0d:b4fb:5e0a::/64 via 2001:db8::1 dev br-ex metric 1024\n(that mimics the one for the other prefix)\n$ ping6 -n fd0d:b4fb:5e0a:0:f816:3eff:fe2b:c6a0\nPING fd0d:b4fb:5e0a:0:f816:3eff:fe2b:c6a0(fd0d:b4fb:5e0a:0:f816:3eff:fe2b:c6a0) 56 data bytes\n64 bytes from fd0d:b4fb:5e0a:0:f816:3eff:fe2b:c6a0: icmp_seq\u003d1 ttl\u003d62 time\u003d6.15 ms\n64 bytes from fd0d:b4fb:5e0a:0:f816:3eff:fe2b:c6a0: icmp_seq\u003d2 ttl\u003d62 time\u003d4.84 ms\n\nIn your testing could you ping both IPs?  If so then there could just be another DVR issue hiding in here.","commit_id":"c764ef1f040cf82e9f816b657cf07de47be65e95"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"f50eeef19ae1455a827e0007f1721ed55f0f809d","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"            network_id \u003d subnet[\u0027network_id\u0027]"},{"line_number":1201,"context_line":"            port_qry \u003d context.session.query(models_v2.Port)"},{"line_number":1202,"context_line":"            for port in port_qry.filter("},{"line_number":1203,"context_line":"                and_(models_v2.Port.network_id \u003d\u003d network_id,"},{"line_number":1204,"context_line":"                     ~models_v2.Port.device_owner.in_("},{"line_number":1205,"context_line":"                         constants.ROUTER_INTERFACE_OWNERS))):"},{"line_number":1206,"context_line":"                ip_address \u003d self._calculate_ipv6_eui64_addr("}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_9274cffd","line":1203,"in_reply_to":"baa041b7_c0397343","updated":"2015-04-02 03:33:12.000000000","message":"Brian, looks like the DevStack script wasn\u0027t setting the next-hop for the routes on the host reliably (it\u0027s always using 2001:db8::1, but sometimes the br-ex address is something else, e.g. 2001:db8::3). I\u0027ll upload a new devstack script patch (review 161877), and rebase this patch set with the DVR SNAT change (and new UT test case).","commit_id":"c764ef1f040cf82e9f816b657cf07de47be65e95"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b9bcdd87bf2640904bd2d723b9a6161ce1ef3985","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"            network_id \u003d subnet[\u0027network_id\u0027]"},{"line_number":1201,"context_line":"            port_qry \u003d context.session.query(models_v2.Port)"},{"line_number":1202,"context_line":"            for port in port_qry.filter("},{"line_number":1203,"context_line":"                and_(models_v2.Port.network_id \u003d\u003d network_id,"},{"line_number":1204,"context_line":"                     ~models_v2.Port.device_owner.in_("},{"line_number":1205,"context_line":"                         constants.ROUTER_INTERFACE_OWNERS))):"},{"line_number":1206,"context_line":"                ip_address \u003d self._calculate_ipv6_eui64_addr("}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_27eef98b","line":1203,"in_reply_to":"baa041b7_f509dade","updated":"2015-04-01 16:36:36.000000000","message":"Dane, yes, I\u0027ll give it a try in the next couple of hours","commit_id":"c764ef1f040cf82e9f816b657cf07de47be65e95"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"6320ad43a6dd8db1c02712e83502bec49eff2786","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"            network_id \u003d subnet[\u0027network_id\u0027]"},{"line_number":1201,"context_line":"            port_qry \u003d context.session.query(models_v2.Port)"},{"line_number":1202,"context_line":"            for port in port_qry.filter("},{"line_number":1203,"context_line":"                and_(models_v2.Port.network_id \u003d\u003d network_id,"},{"line_number":1204,"context_line":"                     ~models_v2.Port.device_owner.in_("},{"line_number":1205,"context_line":"                         constants.ROUTER_INTERFACE_OWNERS))):"},{"line_number":1206,"context_line":"                ip_address \u003d self._calculate_ipv6_eui64_addr("}],"source_content_type":"text/x-python","patch_set":4,"id":"baa041b7_f509dade","line":1203,"in_reply_to":"baa041b7_fad78921","updated":"2015-04-01 15:58:33.000000000","message":"Brian, can you try with the change you\u0027ve described, but also use this devstack patch?: https://review.openstack.org/#/c/161877","commit_id":"c764ef1f040cf82e9f816b657cf07de47be65e95"}]}
