)]}'
{"neutron/plugins/ml2/drivers/type_flat.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2a8ddb35774d5223107b8df1edf674489f7a7e56","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        if \u0027*\u0027 in self.flat_networks:"},{"line_number":70,"context_line":"            LOG.info(_LI(\"Arbitrary flat physical_network names allowed\"))"},{"line_number":71,"context_line":"            self.flat_networks \u003d None"},{"line_number":72,"context_line":"        elif not self.flat_networks:"},{"line_number":73,"context_line":"            msg \u003d _(\"No allowable flat physical_networks set.\")"},{"line_number":74,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":75,"context_line":"        elif all(self.flat_networks):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_6e659544","line":72,"updated":"2015-03-04 16:03:55.000000000","message":"please add a unit test for this","commit_id":"7f7b87f60f648fa3e0a0d28b891e95f6c45041f5"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"035f913cad446b9cbaa9e01d0a1c33c9448ef17f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        if \u0027*\u0027 in self.flat_networks:"},{"line_number":70,"context_line":"            LOG.info(_LI(\"Arbitrary flat physical_network names allowed\"))"},{"line_number":71,"context_line":"            self.flat_networks \u003d None"},{"line_number":72,"context_line":"        elif not self.flat_networks:"},{"line_number":73,"context_line":"            msg \u003d _(\"No allowable flat physical_networks set.\")"},{"line_number":74,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":75,"context_line":"        elif not all(self.flat_networks):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_20d34005","line":72,"updated":"2015-03-06 10:56:21.000000000","message":"It would be better to move this check before line 69. It makes sense to check that self.flat_networks is not None and then if \u0027*\u0027 in self.flat_networks","commit_id":"296df3cc920fa8d7af3f0cc2f654cbbab2f62dcc"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d19ecdee69f9bab0d9af891909b2c85405239cf5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        if \u0027*\u0027 in self.flat_networks:"},{"line_number":70,"context_line":"            LOG.info(_LI(\"Arbitrary flat physical_network names allowed\"))"},{"line_number":71,"context_line":"            self.flat_networks \u003d None"},{"line_number":72,"context_line":"        elif not self.flat_networks:"},{"line_number":73,"context_line":"            msg \u003d _(\"No allowable flat physical_networks set.\")"},{"line_number":74,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":75,"context_line":"        elif not all(self.flat_networks):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_2027c0cb","line":72,"in_reply_to":"9a80dd14_20d34005","updated":"2015-03-06 11:03:36.000000000","message":"OK, not None, but empty list, the bug is about that.","commit_id":"296df3cc920fa8d7af3f0cc2f654cbbab2f62dcc"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"035f913cad446b9cbaa9e01d0a1c33c9448ef17f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if self.flat_networks is not None and ("},{"line_number":97,"context_line":"                not self.flat_networks or"},{"line_number":98,"context_line":"                physical_network not in self.flat_networks):"},{"line_number":99,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"},{"line_number":100,"context_line":"                   % physical_network)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_c032645e","line":97,"updated":"2015-03-06 10:56:21.000000000","message":"I don\u0027t think you need this condition, it\u0027s gonna be always false since you check that self.flat_networks is not None in line 96.","commit_id":"296df3cc920fa8d7af3f0cc2f654cbbab2f62dcc"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"6282f3eb58199f3322c6afd3d6573463ea7e8225","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if self.flat_networks is not None and ("},{"line_number":97,"context_line":"                not self.flat_networks or"},{"line_number":98,"context_line":"                physical_network not in self.flat_networks):"},{"line_number":99,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"},{"line_number":100,"context_line":"                   % physical_network)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_51ae44e7","line":97,"in_reply_to":"9a80dd14_400bd429","updated":"2015-03-06 11:46:48.000000000","message":"Thinking for a while, I agree that it is not needed, as physical_network not in self.flat_networks will return false for empty list.","commit_id":"296df3cc920fa8d7af3f0cc2f654cbbab2f62dcc"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d19ecdee69f9bab0d9af891909b2c85405239cf5","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if self.flat_networks is not None and ("},{"line_number":97,"context_line":"                not self.flat_networks or"},{"line_number":98,"context_line":"                physical_network not in self.flat_networks):"},{"line_number":99,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"},{"line_number":100,"context_line":"                   % physical_network)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_400bd429","line":97,"in_reply_to":"9a80dd14_c032645e","updated":"2015-03-06 11:03:36.000000000","message":"When I check \u0027not self.flat_networks\u0027 - I mean that self.flat_networks is not an empty list, so it won\u0027t be always false and we need this check.","commit_id":"296df3cc920fa8d7af3f0cc2f654cbbab2f62dcc"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f1ad5c8f8e3fa8da78f6b20d545c33b3ff7cd7d1","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _parse_networks(self, entries):"},{"line_number":68,"context_line":"        self.flat_networks \u003d entries"},{"line_number":69,"context_line":"        if not self.flat_networks:"},{"line_number":70,"context_line":"            msg \u003d _(\"No allowable flat physical_networks set.\")"},{"line_number":71,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":72,"context_line":"        elif \u0027*\u0027 in self.flat_networks:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_96cf29b3","line":69,"updated":"2015-03-11 10:46:53.000000000","message":"Seems before the change default [] was equal to [\u0027*\u0027]. Now [] becomes invalid. I think we should either change default to * or remove it to fail early in case flat_networks are not specified in the config. Not sure what\u0027s the best option so I\u0027d like to know other reviewers opinions.","commit_id":"61220206aa3ca123dfd200efe21a6e819d01255c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"192769b3a7423d56869c2eab6dcebbe8ce07b372","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _parse_networks(self, entries):"},{"line_number":68,"context_line":"        self.flat_networks \u003d entries"},{"line_number":69,"context_line":"        if not self.flat_networks:"},{"line_number":70,"context_line":"            msg \u003d _(\"No allowable flat physical_networks set.\")"},{"line_number":71,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":72,"context_line":"        elif \u0027*\u0027 in self.flat_networks:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_98503360","line":69,"in_reply_to":"9a80dd14_56a93123","updated":"2015-03-11 12:00:04.000000000","message":"Ah, missed that, sorry. What if we don\u0027t change behavior here and just fail at #98 (just like it\u0027s done it this revision) on attempt to create provider net while physical networks are not configured.","commit_id":"61220206aa3ca123dfd200efe21a6e819d01255c"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"2710921f48c40d489ab3a0292e750d30405f43c8","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _parse_networks(self, entries):"},{"line_number":68,"context_line":"        self.flat_networks \u003d entries"},{"line_number":69,"context_line":"        if not self.flat_networks:"},{"line_number":70,"context_line":"            msg \u003d _(\"No allowable flat physical_networks set.\")"},{"line_number":71,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":72,"context_line":"        elif \u0027*\u0027 in self.flat_networks:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_56a93123","line":69,"in_reply_to":"9a80dd14_96cf29b3","updated":"2015-03-11 10:59:50.000000000","message":"I wrote an email to openstack-dev about this concerns a week ago http://lists.openstack.org/pipermail/openstack-dev/2015-March/058373.html But I didn\u0027t get any answers. Looking forward more input here.","commit_id":"61220206aa3ca123dfd200efe21a6e819d01255c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"74de491126cd46bb1b6a40beca6804630ea07cde","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _parse_networks(self, entries):"},{"line_number":68,"context_line":"        self.flat_networks \u003d entries"},{"line_number":69,"context_line":"        if not self.flat_networks:"},{"line_number":70,"context_line":"            msg \u003d _(\"No allowable flat physical_networks set.\")"},{"line_number":71,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":72,"context_line":"        elif \u0027*\u0027 in self.flat_networks:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_29829b00","line":69,"in_reply_to":"9a80dd14_98503360","updated":"2015-03-11 12:50:48.000000000","message":"I am not familiar with flat networks. If two tenants each create a flat tenant network on the same physical network, can they see each other\u0027s traffic? If so then that sounds like a bad thing and maybe the default behaviour should be changed.","commit_id":"61220206aa3ca123dfd200efe21a6e819d01255c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"f1ad5c8f8e3fa8da78f6b20d545c33b3ff7cd7d1","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if not physical_network:"},{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if (self.flat_networks is not None and"},{"line_number":97,"context_line":"                physical_network not in self.flat_networks):"},{"line_number":98,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"},{"line_number":99,"context_line":"                   % physical_network)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_bbba56be","line":96,"updated":"2015-03-11 10:46:53.000000000","message":"flat_networks can\u0027t be empty list now so this change is not neded","commit_id":"61220206aa3ca123dfd200efe21a6e819d01255c"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"72590995416bf52b1ca447e772fc804f7018a5dd","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if not physical_network:"},{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if (self.flat_networks is not None and"},{"line_number":97,"context_line":"                physical_network not in self.flat_networks):"},{"line_number":98,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"},{"line_number":99,"context_line":"                   % physical_network)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_c2da48e8","line":96,"in_reply_to":"9a80dd14_bbba56be","updated":"2015-03-19 14:27:26.000000000","message":"I think it is better to leave this check to make sure that we can\u0027t create any network if flat_networks is just [].","commit_id":"61220206aa3ca123dfd200efe21a6e819d01255c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"74de491126cd46bb1b6a40beca6804630ea07cde","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if (self.flat_networks is not None and"},{"line_number":97,"context_line":"                physical_network not in self.flat_networks):"},{"line_number":98,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"},{"line_number":99,"context_line":"                   % physical_network)"},{"line_number":100,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_591f2f6c","line":97,"updated":"2015-03-11 12:50:48.000000000","message":"OK, but now I have to ask how this is better than the original?","commit_id":"61220206aa3ca123dfd200efe21a6e819d01255c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"2ce34c3e4fe6c7d0412abbaa2d04e52ddb59bbbb","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"flat_opts \u003d ["},{"line_number":31,"context_line":"    cfg.ListOpt(\u0027flat_networks\u0027,"},{"line_number":32,"context_line":"                default\u003d[\u0027*\u0027],"},{"line_number":33,"context_line":"                help\u003d_(\"List of physical_network names with which flat \""},{"line_number":34,"context_line":"                       \"networks can be created. Use * to allow flat \""},{"line_number":35,"context_line":"                       \"networks with arbitrary physical_network names.\"))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_c692539e","line":32,"updated":"2015-03-19 16:46:59.000000000","message":"I agree with Bob. Revert.","commit_id":"5a241c552abfa92abf82d97857ffd2d758643eb8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"2ce34c3e4fe6c7d0412abbaa2d04e52ddb59bbbb","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.flat_networks \u003d entries"},{"line_number":71,"context_line":"        if not self.flat_networks:"},{"line_number":72,"context_line":"            msg \u003d _(\"No allowable flat physical_networks set.\")"},{"line_number":73,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":74,"context_line":"        elif \u0027*\u0027 in self.flat_networks:"},{"line_number":75,"context_line":"            LOG.info(_LI(\"Arbitrary flat physical_network names allowed\"))"},{"line_number":76,"context_line":"            self.flat_networks \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_e6e2f72e","line":73,"updated":"2015-03-19 16:46:59.000000000","message":"I agree with Bob, this is not an error. Revert.","commit_id":"5a241c552abfa92abf82d97857ffd2d758643eb8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"2ce34c3e4fe6c7d0412abbaa2d04e52ddb59bbbb","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":97,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":98,"context_line":"        if (self.flat_networks is not None and"},{"line_number":99,"context_line":"                physical_network not in self.flat_networks):"},{"line_number":100,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"},{"line_number":101,"context_line":"                   % physical_network)"},{"line_number":102,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_a6c39f88","line":99,"updated":"2015-03-19 16:46:59.000000000","message":"Now this fixes the actual bug. Thank you!","commit_id":"5a241c552abfa92abf82d97857ffd2d758643eb8"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4519304815053b1b203faa0f682485f2151c0ab6","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":97,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":98,"context_line":"        if (self.flat_networks is not None and"},{"line_number":99,"context_line":"                physical_network not in self.flat_networks):"},{"line_number":100,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"},{"line_number":101,"context_line":"                   % physical_network)"},{"line_number":102,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_815be584","line":99,"in_reply_to":"9a80dd14_a6c39f88","updated":"2015-03-19 17:11:40.000000000","message":"Yeah, also came to that conclusion on PS7","commit_id":"5a241c552abfa92abf82d97857ffd2d758643eb8"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3afab5a7925bd9595c059efa7991d9b8f7b4d409","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                        \"Available variants %(available)s\") % {"},{"line_number":142,"context_line":"                            \u0027unknown\u0027: unknown_phy_nets,"},{"line_number":143,"context_line":"                            \u0027available\u0027: known_phy_nets}"},{"line_number":144,"context_line":"                raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"            if len(segments) \u003e 1:"},{"line_number":147,"context_line":"                network[mpnet.SEGMENTS] \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_b6ca966c","line":144,"updated":"2015-03-04 08:24:13.000000000","message":"what will happen for non-vlan networks?","commit_id":"3c735d06f13377f5b0ac41cfc4d2bb3d421bc9a6"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"966526fa53cb7ef61baff46c20a072b247168260","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                        \"Available variants %(available)s\") % {"},{"line_number":142,"context_line":"                            \u0027unknown\u0027: unknown_phy_nets,"},{"line_number":143,"context_line":"                            \u0027available\u0027: known_phy_nets}"},{"line_number":144,"context_line":"                raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"            if len(segments) \u003e 1:"},{"line_number":147,"context_line":"                network[mpnet.SEGMENTS] \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_b6d7f6be","line":144,"in_reply_to":"9a80dd14_b6ca966c","updated":"2015-03-04 09:15:48.000000000","message":"If --provider:physical_network was not set, it is None and validate_physical_network returns empty list. For non-vlan networks we don\u0027t have to set physical_network names or am I missing something?","commit_id":"3c735d06f13377f5b0ac41cfc4d2bb3d421bc9a6"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"7e78d7285285011c59b0b67c45c40019e3659df9","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            for attr in provider.ATTRIBUTES:"},{"line_number":159,"context_line":"                network[attr] \u003d None"},{"line_number":160,"context_line":"        else:"},{"line_number":161,"context_line":"            known_phy_nets \u003d utils.parse_network_vlan_ranges("},{"line_number":162,"context_line":"                cfg.CONF.ml2_type_vlan.network_vlan_ranges).keys()"},{"line_number":163,"context_line":"            unknown_phy_nets \u003d self.validate_physical_network(segments,"},{"line_number":164,"context_line":"                                                              known_phy_nets)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_1f90c994","line":161,"updated":"2015-03-04 14:29:40.000000000","message":"Yamamoto has a point I think. PHYSICAL_NETWORK is set also for network_type flat , I am afraid you have to reconsider your algorithm.","commit_id":"16496769597fffcee69123aa5a5de1aefb9cbc70"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d341f2d71dfbb7a249ccee99542455398fef4bfa","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            for attr in provider.ATTRIBUTES:"},{"line_number":159,"context_line":"                network[attr] \u003d None"},{"line_number":160,"context_line":"        else:"},{"line_number":161,"context_line":"            known_phy_nets \u003d utils.parse_network_vlan_ranges("},{"line_number":162,"context_line":"                cfg.CONF.ml2_type_vlan.network_vlan_ranges).keys()"},{"line_number":163,"context_line":"            unknown_phy_nets \u003d self.validate_physical_network(segments,"},{"line_number":164,"context_line":"                                                              known_phy_nets)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_629beec9","line":161,"in_reply_to":"9a80dd14_1f90c994","updated":"2015-03-04 14:43:32.000000000","message":"yeah, I missed that, thanks for pointing this","commit_id":"16496769597fffcee69123aa5a5de1aefb9cbc70"}],"neutron/tests/unit/ml2/drivers/test_l2population.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"93b8e652d1d6ca46eeaa38e9845bce60bc24ceb9","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    _mechanism_drivers \u003d [\u0027openvswitch\u0027, \u0027fake_agent\u0027, \u0027l2population\u0027]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def setUp(self):"},{"line_number":108,"context_line":"        self.config(flat_networks\u003d[\u0027noagent\u0027, \u0027physnet1\u0027],"},{"line_number":109,"context_line":"                    group\u003d\u0027ml2_type_flat\u0027)"},{"line_number":110,"context_line":"        super(TestL2PopulationRpcTestCase, self).setUp()"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_d06f97c3","line":108,"updated":"2015-03-06 09:05:40.000000000","message":"why does physnet1 need to be here?\nas far as i understand it\u0027s of vlan type.\n\nbesides that, probably it\u0027s more consistent to do this in Ml2PluginV2TestCase.setUp(), where network_vlan_ranges\nis overriden.","commit_id":"147fafaf6c4990ae79bd5b86babda4b5863ed46a"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"391ad052e25a24603a7fd3d0b622929528ba5e12","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    _mechanism_drivers \u003d [\u0027openvswitch\u0027, \u0027fake_agent\u0027, \u0027l2population\u0027]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def setUp(self):"},{"line_number":108,"context_line":"        self.config(flat_networks\u003d[\u0027noagent\u0027, \u0027physnet1\u0027],"},{"line_number":109,"context_line":"                    group\u003d\u0027ml2_type_flat\u0027)"},{"line_number":110,"context_line":"        super(TestL2PopulationRpcTestCase, self).setUp()"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_b064e349","line":108,"in_reply_to":"9a80dd14_d06f97c3","updated":"2015-03-06 09:09:33.000000000","message":"Agreed, I was going to move it there, just look for reviewer\u0027s comments.","commit_id":"147fafaf6c4990ae79bd5b86babda4b5863ed46a"}],"neutron/tests/unit/ml2/test_type_flat.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"1a4d956e7b429437f7527f0f01a1dcbc48a8b902","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                          segment)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_validate_provider_segment_with_empty_physical_nets_list(self):"},{"line_number":92,"context_line":"        cfg.CONF.set_override(\u0027flat_networks\u0027, [],"},{"line_number":93,"context_line":"                              group\u003d\u0027ml2_type_flat\u0027)"},{"line_number":94,"context_line":"        segment \u003d {api.NETWORK_TYPE: p_const.TYPE_FLAT,"},{"line_number":95,"context_line":"                   api.PHYSICAL_NETWORK: \u0027flat_net\u0027}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_2dd5ac42","line":92,"updated":"2015-03-20 10:15:02.000000000","message":"not needed now, right?","commit_id":"9b707844da74c765498ea0e0a764ea3a0b777a11"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"22dfefff9529b6e724e3f4336d87e1e323a66a8c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                          segment)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_validate_provider_segment_with_empty_physical_nets_list(self):"},{"line_number":92,"context_line":"        cfg.CONF.set_override(\u0027flat_networks\u0027, [],"},{"line_number":93,"context_line":"                              group\u003d\u0027ml2_type_flat\u0027)"},{"line_number":94,"context_line":"        segment \u003d {api.NETWORK_TYPE: p_const.TYPE_FLAT,"},{"line_number":95,"context_line":"                   api.PHYSICAL_NETWORK: \u0027flat_net\u0027}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_d499f81f","line":92,"in_reply_to":"9a80dd14_2dd5ac42","updated":"2015-03-20 11:27:50.000000000","message":"Yes, we need this, as this in fact checks that provided fix works. But I see that in this variant it is not working as configs are not overridden.  Will add new patch set for this.","commit_id":"9b707844da74c765498ea0e0a764ea3a0b777a11"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"59a1f1ffeba856583b7d9a19f08e1d5eb9ccf1c4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                          segment)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_validate_provider_segment_with_empty_physical_nets_list(self):"},{"line_number":92,"context_line":"        cfg.CONF.set_override(\u0027flat_networks\u0027, [],"},{"line_number":93,"context_line":"                              group\u003d\u0027ml2_type_flat\u0027)"},{"line_number":94,"context_line":"        segment \u003d {api.NETWORK_TYPE: p_const.TYPE_FLAT,"},{"line_number":95,"context_line":"                   api.PHYSICAL_NETWORK: \u0027flat_net\u0027}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_9a46c7a5","line":92,"in_reply_to":"9a80dd14_d499f81f","updated":"2015-03-20 12:24:10.000000000","message":"I meant that it is [] by default. Didn\u0027t notice that it was overriden in setUp() so yes, it\u0027s needed","commit_id":"9b707844da74c765498ea0e0a764ea3a0b777a11"}]}