)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"63f58a0b9c32171ba34ae88ab8695efe91d2fc3a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem is that if one try to communicate from a tenant network"},{"line_number":10,"context_line":"to floatingip which attached to a port on the same network, the"},{"line_number":11,"context_line":"communication fails."},{"line_number":12,"context_line":"This problem is a regressin cased by"},{"line_number":13,"context_line":"https://review.openstack.org/131905/ ."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_e5c20de8","line":11,"updated":"2015-03-13 02:12:47.000000000","message":"Generally, a space between paragraphs is good.","commit_id":"fb2278ede217a3fd9bf37eff30c3fb2f00ad41f1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c5dff3d0613bcfd17f646bd9f70b34d3f0387721","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem is that if one try to communicate from a tenant network"},{"line_number":10,"context_line":"to floatingip which attached to a port on the same network, the"},{"line_number":11,"context_line":"communication fails."},{"line_number":12,"context_line":"This problem is a regressin cased by"},{"line_number":13,"context_line":"https://review.openstack.org/131905/ ."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_23f17801","line":11,"in_reply_to":"9a80dd14_e5c20de8","updated":"2015-03-13 06:02:06.000000000","message":"Done","commit_id":"fb2278ede217a3fd9bf37eff30c3fb2f00ad41f1"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"63f58a0b9c32171ba34ae88ab8695efe91d2fc3a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The problem is that if one try to communicate from a tenant network"},{"line_number":10,"context_line":"to floatingip which attached to a port on the same network, the"},{"line_number":11,"context_line":"communication fails."},{"line_number":12,"context_line":"This problem is a regressin cased by"},{"line_number":13,"context_line":"https://review.openstack.org/131905/ ."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fix makes DNATed packets to internal interfaces SNATed so that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_456919bd","line":12,"updated":"2015-03-13 02:12:47.000000000","message":"*regression caused by\n\nAlso, could you use a reference like this [1] just to clean up the formatting a bit.\n\n[1] https://review.openstack.org/131905/","commit_id":"fb2278ede217a3fd9bf37eff30c3fb2f00ad41f1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c5dff3d0613bcfd17f646bd9f70b34d3f0387721","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The problem is that if one try to communicate from a tenant network"},{"line_number":10,"context_line":"to floatingip which attached to a port on the same network, the"},{"line_number":11,"context_line":"communication fails."},{"line_number":12,"context_line":"This problem is a regressin cased by"},{"line_number":13,"context_line":"https://review.openstack.org/131905/ ."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fix makes DNATed packets to internal interfaces SNATed so that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_83db047b","line":12,"in_reply_to":"9a80dd14_456919bd","updated":"2015-03-13 06:02:06.000000000","message":"Done","commit_id":"fb2278ede217a3fd9bf37eff30c3fb2f00ad41f1"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"63f58a0b9c32171ba34ae88ab8695efe91d2fc3a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to floatingip which attached to a port on the same network, the"},{"line_number":11,"context_line":"communication fails."},{"line_number":12,"context_line":"This problem is a regressin cased by"},{"line_number":13,"context_line":"https://review.openstack.org/131905/ ."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fix makes DNATed packets to internal interfaces SNATed so that"},{"line_number":16,"context_line":"reply packets return to the router surely."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_a5a4954b","line":13,"updated":"2015-03-13 02:12:47.000000000","message":"I\u0027m struggling to see how this patch caused the regression.  Could you provide a little more detail?  Thinking out loud here...\n\nThe patch basically changed this (in the POSTROUTING chain):\n\n-s %(internal_cidr)s -j SNAT --to-source ...\n\n... to this:\n\n-o %(interface_name)s -j SNAT --to-source ...\n\n... which catches a super-set of the packets going out the external interface compared to the old rules, right? I guess the old rules would *also* catch packets that were not going out the external gateway interface because there was no -o \u003cinterface\u003e option.  They caught packets going out the internal interfaces, too.  So, even traffic to private IPs through the router was getting SNAT.  Seems like that was a bug.\n\nI still haven\u0027t wrapped my head around why this doesn\u0027t work now.  Still thinking out loud...\n\nOkay, if the router DNATs but does not SNAT the packets then the other VM is going to send return packets directly to the private IP of the initiator.  So, the router doesn\u0027t see the return traffic.  conntrack then is probably broken and iptables can\u0027t reverse the DNAT operation on the return traffic so the return packets have the target\u0027s source ip as the source.  Okay, I\u0027m seeing the problem now.  The bug report and -- to some extent -- this commit message could use a good description to help other reviewers with this.","commit_id":"fb2278ede217a3fd9bf37eff30c3fb2f00ad41f1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c5dff3d0613bcfd17f646bd9f70b34d3f0387721","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to floatingip which attached to a port on the same network, the"},{"line_number":11,"context_line":"communication fails."},{"line_number":12,"context_line":"This problem is a regressin cased by"},{"line_number":13,"context_line":"https://review.openstack.org/131905/ ."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fix makes DNATed packets to internal interfaces SNATed so that"},{"line_number":16,"context_line":"reply packets return to the router surely."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_35d7e94c","line":13,"in_reply_to":"9a80dd14_a5a4954b","updated":"2015-03-13 06:02:06.000000000","message":"I tried to add explanation more. please examine new PS.","commit_id":"fb2278ede217a3fd9bf37eff30c3fb2f00ad41f1"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"63f58a0b9c32171ba34ae88ab8695efe91d2fc3a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"https://review.openstack.org/131905/ ."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fix makes DNATed packets to internal interfaces SNATed so that"},{"line_number":16,"context_line":"reply packets return to the router surely."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ifa695ac5428fb0edba60129a4d61ec0e127a5818"},{"line_number":19,"context_line":"Closes-Bug: #1428887"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_0c9ca90e","line":16,"updated":"2015-03-13 02:12:47.000000000","message":"You should mention that the return traffic needs to go through the router to complete the conntrack association and to reverse the effect of DNAT on the return packets.  I think I have that right.\n\nSo, I think I agree that packets from internal subnets that get DNATed should also be SNATed.  I\u0027ll have to think about the implementation a bit.","commit_id":"fb2278ede217a3fd9bf37eff30c3fb2f00ad41f1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c5dff3d0613bcfd17f646bd9f70b34d3f0387721","unresolved":false,"context_lines":[{"line_number":13,"context_line":"https://review.openstack.org/131905/ ."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fix makes DNATed packets to internal interfaces SNATed so that"},{"line_number":16,"context_line":"reply packets return to the router surely."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ifa695ac5428fb0edba60129a4d61ec0e127a5818"},{"line_number":19,"context_line":"Closes-Bug: #1428887"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a80dd14_75cde1b6","line":16,"in_reply_to":"9a80dd14_0c9ca90e","updated":"2015-03-13 06:02:06.000000000","message":"ditto","commit_id":"fb2278ede217a3fd9bf37eff30c3fb2f00ad41f1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1919fe26b36467b7a8e6e76aba8f8849b30e024a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Before [1] SNAT rule is as follows:"},{"line_number":17,"context_line":"-s %(internal_cidr)s -j SNAT --to-source ..."},{"line_number":18,"context_line":"(for each internal interdace)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"After [1] SNAT rule is as follows:"},{"line_number":21,"context_line":"-s %(interface_name)s -j SNAT --to-source ..."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_074632c0","line":18,"updated":"2015-03-13 13:17:02.000000000","message":"interface","commit_id":"804ee8623c2d7fc160c4d7889d7a708d2e6ae995"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8ea43f570d114c5f7aa046630c2e9635e86caa39","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Before [1] SNAT rule is as follows:"},{"line_number":17,"context_line":"-s %(internal_cidr)s -j SNAT --to-source ..."},{"line_number":18,"context_line":"(for each internal interdace)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"After [1] SNAT rule is as follows:"},{"line_number":21,"context_line":"-s %(interface_name)s -j SNAT --to-source ..."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_dbf4b7f2","line":18,"in_reply_to":"9a80dd14_074632c0","updated":"2015-03-16 03:22:37.000000000","message":"Done","commit_id":"804ee8623c2d7fc160c4d7889d7a708d2e6ae995"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1919fe26b36467b7a8e6e76aba8f8849b30e024a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"(for each internal interdace)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"After [1] SNAT rule is as follows:"},{"line_number":21,"context_line":"-s %(interface_name)s -j SNAT --to-source ..."},{"line_number":22,"context_line":"(for an external interface)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The new rule was considerd a super-set of the packets going out the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_a7464679","line":21,"updated":"2015-03-13 13:17:02.000000000","message":"-o","commit_id":"804ee8623c2d7fc160c4d7889d7a708d2e6ae995"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8ea43f570d114c5f7aa046630c2e9635e86caa39","unresolved":false,"context_lines":[{"line_number":18,"context_line":"(for each internal interdace)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"After [1] SNAT rule is as follows:"},{"line_number":21,"context_line":"-s %(interface_name)s -j SNAT --to-source ..."},{"line_number":22,"context_line":"(for an external interface)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The new rule was considerd a super-set of the packets going out the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_7bd2eb5c","line":21,"in_reply_to":"9a80dd14_a7464679","updated":"2015-03-16 03:22:37.000000000","message":"Done","commit_id":"804ee8623c2d7fc160c4d7889d7a708d2e6ae995"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1919fe26b36467b7a8e6e76aba8f8849b30e024a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"2-1) came in from internal interface"},{"line_number":39,"context_line":"should be SNATed because the return traffic needs to go through the"},{"line_number":40,"context_line":"router to complete the conntrack association and to reverse the effect"},{"line_number":41,"context_line":"of DNAT on the retun packets. If a packet is not SNATed, the return"},{"line_number":42,"context_line":"packet may be sent directly to the private IP of the initiator."},{"line_number":43,"context_line":"The old rules done SNAT in this case but the new rule dosn\u0027t."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_87cea22b","line":41,"range":{"start_line":41,"start_character":15,"end_line":41,"end_character":20},"updated":"2015-03-13 13:17:02.000000000","message":"return","commit_id":"804ee8623c2d7fc160c4d7889d7a708d2e6ae995"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8ea43f570d114c5f7aa046630c2e9635e86caa39","unresolved":false,"context_lines":[{"line_number":38,"context_line":"2-1) came in from internal interface"},{"line_number":39,"context_line":"should be SNATed because the return traffic needs to go through the"},{"line_number":40,"context_line":"router to complete the conntrack association and to reverse the effect"},{"line_number":41,"context_line":"of DNAT on the retun packets. If a packet is not SNATed, the return"},{"line_number":42,"context_line":"packet may be sent directly to the private IP of the initiator."},{"line_number":43,"context_line":"The old rules done SNAT in this case but the new rule dosn\u0027t."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_dbcbd7a1","line":41,"in_reply_to":"9a80dd14_87cea22b","updated":"2015-03-16 03:22:37.000000000","message":"Done","commit_id":"804ee8623c2d7fc160c4d7889d7a708d2e6ae995"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1919fe26b36467b7a8e6e76aba8f8849b30e024a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"nothing to do."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This patch adds a rule for the case 2-1)."},{"line_number":49,"context_line":"This patch also adds mangle rules to examin whether a packet came from"},{"line_number":50,"context_line":"external interface."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Change-Id: Ifa695ac5428fb0edba60129a4d61ec0e127a5818"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_e7d83ef1","line":49,"range":{"start_line":49,"start_character":37,"end_line":49,"end_character":43},"updated":"2015-03-13 13:17:02.000000000","message":"examine","commit_id":"804ee8623c2d7fc160c4d7889d7a708d2e6ae995"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8ea43f570d114c5f7aa046630c2e9635e86caa39","unresolved":false,"context_lines":[{"line_number":46,"context_line":"nothing to do."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"This patch adds a rule for the case 2-1)."},{"line_number":49,"context_line":"This patch also adds mangle rules to examin whether a packet came from"},{"line_number":50,"context_line":"external interface."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Change-Id: Ifa695ac5428fb0edba60129a4d61ec0e127a5818"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_5bb7e720","line":49,"in_reply_to":"9a80dd14_e7d83ef1","updated":"2015-03-16 03:22:37.000000000","message":"Done","commit_id":"804ee8623c2d7fc160c4d7889d7a708d2e6ae995"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"c7094f6206796b14eb04dd0fe2040ea5fd29f66a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to floatingip which attached to a port on the same network, the"},{"line_number":11,"context_line":"communication fails."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This problem is a regressin cased by [1]."},{"line_number":14,"context_line":"[1] https://review.openstack.org/131905/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Before [1] SNAT rule is as follows:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_10970649","line":13,"updated":"2015-03-16 09:20:54.000000000","message":"s/regressin/regression/ ??","commit_id":"addc7456a0609a931927b6c0020a98e8bb806388"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"1925ecf0b70e761b8d49e5cd5388b53d46515c7e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to floatingip which attached to a port on the same network, the"},{"line_number":11,"context_line":"communication fails."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This problem is a regressin cased by [1]."},{"line_number":14,"context_line":"[1] https://review.openstack.org/131905/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Before [1] SNAT rule is as follows:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_d9e49110","line":13,"in_reply_to":"9a80dd14_10970649","updated":"2015-03-16 22:47:54.000000000","message":"Done","commit_id":"addc7456a0609a931927b6c0020a98e8bb806388"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"c7094f6206796b14eb04dd0fe2040ea5fd29f66a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"-o %(interface_name)s -j SNAT --to-source ..."},{"line_number":22,"context_line":"(for an external interface)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The new rule was considerd a super-set of the packets going out the"},{"line_number":25,"context_line":"external interface compared to the old rules. This is true but"},{"line_number":26,"context_line":"there is a lack of consideration."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_90913649","line":24,"updated":"2015-03-16 09:20:54.000000000","message":"out (of) the ??","commit_id":"addc7456a0609a931927b6c0020a98e8bb806388"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"1925ecf0b70e761b8d49e5cd5388b53d46515c7e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"-o %(interface_name)s -j SNAT --to-source ..."},{"line_number":22,"context_line":"(for an external interface)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The new rule was considerd a super-set of the packets going out the"},{"line_number":25,"context_line":"external interface compared to the old rules. This is true but"},{"line_number":26,"context_line":"there is a lack of consideration."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_59d1812e","line":24,"in_reply_to":"9a80dd14_90913649","updated":"2015-03-16 22:47:54.000000000","message":"Done","commit_id":"addc7456a0609a931927b6c0020a98e8bb806388"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"c7094f6206796b14eb04dd0fe2040ea5fd29f66a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"was applied already. So we should consider the following three cases."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"1) going out to external interface"},{"line_number":34,"context_line":"should be SNATed. It is OK under the new rule but there were lacks"},{"line_number":35,"context_line":"under the old rules. ([1] fixed this.)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"2) DNATed (and going out to internal interface)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_04934ba3","line":34,"updated":"2015-03-16 09:20:54.000000000","message":"Some simple note on what is lacking here with the new rule might be helpful to understand.","commit_id":"addc7456a0609a931927b6c0020a98e8bb806388"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"1925ecf0b70e761b8d49e5cd5388b53d46515c7e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"was applied already. So we should consider the following three cases."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"1) going out to external interface"},{"line_number":34,"context_line":"should be SNATed. It is OK under the new rule but there were lacks"},{"line_number":35,"context_line":"under the old rules. ([1] fixed this.)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"2) DNATed (and going out to internal interface)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_3c5d9b16","line":34,"in_reply_to":"9a80dd14_04934ba3","updated":"2015-03-16 22:47:54.000000000","message":"Done","commit_id":"addc7456a0609a931927b6c0020a98e8bb806388"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"c7094f6206796b14eb04dd0fe2040ea5fd29f66a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"router to complete the conntrack association and to reverse the effect"},{"line_number":41,"context_line":"of DNAT on the return packets. If a packet is not SNATed, the return"},{"line_number":42,"context_line":"packet may be sent directly to the private IP of the initiator."},{"line_number":43,"context_line":"The old rules done SNAT in this case but the new rule dosn\u0027t."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"2-2) came in from external interface"},{"line_number":46,"context_line":"nothing to do."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_e4de376c","line":43,"updated":"2015-03-16 09:20:54.000000000","message":"s/dosn\u0027t/doesn\u0027t/ ??","commit_id":"addc7456a0609a931927b6c0020a98e8bb806388"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"1925ecf0b70e761b8d49e5cd5388b53d46515c7e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"router to complete the conntrack association and to reverse the effect"},{"line_number":41,"context_line":"of DNAT on the return packets. If a packet is not SNATed, the return"},{"line_number":42,"context_line":"packet may be sent directly to the private IP of the initiator."},{"line_number":43,"context_line":"The old rules done SNAT in this case but the new rule dosn\u0027t."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"2-2) came in from external interface"},{"line_number":46,"context_line":"nothing to do."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a80dd14_3915ade5","line":43,"in_reply_to":"9a80dd14_e4de376c","updated":"2015-03-16 22:47:54.000000000","message":"Done","commit_id":"addc7456a0609a931927b6c0020a98e8bb806388"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1cfbcc2c49f627884b63bf7bfa6ccf415b998947","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make floatingip reachable from the same network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem is that if one try to communicate from a tenant network"},{"line_number":10,"context_line":"to floatingip which attached to a port on the same network, the"},{"line_number":11,"context_line":"communication fails."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a6ced46_679d3359","line":9,"updated":"2015-03-27 03:01:59.000000000","message":"*tries","commit_id":"a18fc6ba3a1aabd47305df153dc10deac1a3672d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7a0fb96ac6e5e069c123ec9c22155ab4142bc209","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make floatingip reachable from the same network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The problem is that if one try to communicate from a tenant network"},{"line_number":10,"context_line":"to floatingip which attached to a port on the same network, the"},{"line_number":11,"context_line":"communication fails."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa963961_1c0fb4e2","line":9,"in_reply_to":"1a6ced46_679d3359","updated":"2015-03-27 05:37:02.000000000","message":"Done","commit_id":"a18fc6ba3a1aabd47305df153dc10deac1a3672d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1cfbcc2c49f627884b63bf7bfa6ccf415b998947","unresolved":false,"context_lines":[{"line_number":21,"context_line":"-o %(interface_name)s -j SNAT --to-source ..."},{"line_number":22,"context_line":"(for an external interface)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The new rule was considerd a super-set of the packets going out to"},{"line_number":25,"context_line":"the external interface compared to the old rules. This is true but"},{"line_number":26,"context_line":"there is a lack of consideration."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a6ced46_07b9dfcb","line":24,"updated":"2015-03-27 03:01:59.000000000","message":"*considered","commit_id":"a18fc6ba3a1aabd47305df153dc10deac1a3672d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7a0fb96ac6e5e069c123ec9c22155ab4142bc209","unresolved":false,"context_lines":[{"line_number":21,"context_line":"-o %(interface_name)s -j SNAT --to-source ..."},{"line_number":22,"context_line":"(for an external interface)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The new rule was considerd a super-set of the packets going out to"},{"line_number":25,"context_line":"the external interface compared to the old rules. This is true but"},{"line_number":26,"context_line":"there is a lack of consideration."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa963961_dcf94cca","line":24,"in_reply_to":"1a6ced46_07b9dfcb","updated":"2015-03-27 05:37:02.000000000","message":"Done","commit_id":"a18fc6ba3a1aabd47305df153dc10deac1a3672d"}],"etc/l3_agent.ini":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"08944596eb05db460d97052ae603c73a3b6b893e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"# metadata_proxy_socket \u003d $state_path/metadata_proxy"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# Iptables mangle mark used to mark ingress from external network"},{"line_number":81,"context_line":"# external_ingress_mark \u003d 0x2"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# router_delete_namespaces, which is false by default, can be set to True if"},{"line_number":84,"context_line":"# namespaces can be deleted cleanly on the host running the L3 agent."}],"source_content_type":"text/x-properties","patch_set":4,"id":"9a80dd14_ffae2c97","line":81,"updated":"2015-03-12 16:51:39.000000000","message":"can you elaborate why this must be a configurable value? I don\u0027t see the value of exposing this to the admin.","commit_id":"fb2278ede217a3fd9bf37eff30c3fb2f00ad41f1"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"63f58a0b9c32171ba34ae88ab8695efe91d2fc3a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"# metadata_proxy_socket \u003d $state_path/metadata_proxy"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# Iptables mangle mark used to mark ingress from external network"},{"line_number":81,"context_line":"# external_ingress_mark \u003d 0x2"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# router_delete_namespaces, which is false by default, can be set to True if"},{"line_number":84,"context_line":"# namespaces can be deleted cleanly on the host running the L3 agent."}],"source_content_type":"text/x-properties","patch_set":4,"id":"9a80dd14_056c81cf","line":81,"in_reply_to":"9a80dd14_366e2130","updated":"2015-03-13 02:12:47.000000000","message":"A little history:  https://review.openstack.org/#/c/133484/6/neutron/agent/l3_agent.py","commit_id":"fb2278ede217a3fd9bf37eff30c3fb2f00ad41f1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"438ee19069f5dc5eae87410609c4983f7628de20","unresolved":false,"context_lines":[{"line_number":78,"context_line":"# metadata_proxy_socket \u003d $state_path/metadata_proxy"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"# Iptables mangle mark used to mark ingress from external network"},{"line_number":81,"context_line":"# external_ingress_mark \u003d 0x2"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# router_delete_namespaces, which is false by default, can be set to True if"},{"line_number":84,"context_line":"# namespaces can be deleted cleanly on the host running the L3 agent."}],"source_content_type":"text/x-properties","patch_set":4,"id":"9a80dd14_366e2130","line":81,"in_reply_to":"9a80dd14_ffae2c97","updated":"2015-03-12 22:20:53.000000000","message":"make consistent with \u0027metadata_access_mark\u0027. it maybe conflict as far as \u0027metadata_access_mark\u0027 is configurable.","commit_id":"fb2278ede217a3fd9bf37eff30c3fb2f00ad41f1"}],"neutron/agent/l3/agent.py":[{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"22302121b8704d623dcdb2bf706a1e3c933f5d6a","unresolved":false,"context_lines":[{"line_number":708,"context_line":"                  (interface_name, ex_gw_ip)),"},{"line_number":709,"context_line":"                 (\u0027snat\u0027, \u0027-m mark ! --mark %s \u0027"},{"line_number":710,"context_line":"                  \u0027-m conntrack --ctstate DNAT \u0027"},{"line_number":711,"context_line":"                  \u0027-j SNAT --to-source %s\u0027 % (mark, ex_gw_ip))]"},{"line_number":712,"context_line":"        return rules"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    def _internal_network_added(self, ns_name, network_id, port_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_75e081fa","line":711,"updated":"2015-03-13 06:08:09.000000000","message":"\u0027-m conntrack --ctstate DNAT\u0027 may be redundant and unnecessary.","commit_id":"804ee8623c2d7fc160c4d7889d7a708d2e6ae995"}],"neutron/agent/l3/config.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d9a04240b73e74aa72e3596d4e0f208a3e07c83f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    cfg.StrOpt(\u0027external_ingress_mark\u0027,"},{"line_number":69,"context_line":"               default\u003d\u00270x2\u0027,"},{"line_number":70,"context_line":"               help\u003d_(\u0027Iptables mangle mark used to mark ingress from \u0027"},{"line_number":71,"context_line":"                      \u0027external network\u0027)),"},{"line_number":72,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_7219ea21","line":71,"updated":"2015-03-11 06:31:55.000000000","message":"I guess you should add the parameter to etc/l3_agent.ini.","commit_id":"6931421af17db0fbb1be8b4fa248cb44113e4ec8"},{"author":{"_account_id":12955,"name":"Aman Kumar","email":"aman.kumar3@hpe.com","username":"amank"},"change_message_id":"c410981f3e54a3f8652abd840ad64a6361d882af","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    cfg.StrOpt(\u0027external_ingress_mark\u0027,"},{"line_number":69,"context_line":"               default\u003d\u00270x2\u0027,"},{"line_number":70,"context_line":"               help\u003d_(\u0027Iptables mangle mark used to mark ingress from \u0027"},{"line_number":71,"context_line":"                      \u0027external network\u0027)),"},{"line_number":72,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_8c8e4226","line":71,"in_reply_to":"9a80dd14_7219ea21","updated":"2015-03-11 08:29:09.000000000","message":"+1","commit_id":"6931421af17db0fbb1be8b4fa248cb44113e4ec8"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"036b470806392f1e4479b290795c61b271c124c0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    cfg.StrOpt(\u0027external_ingress_mark\u0027,"},{"line_number":69,"context_line":"               default\u003d\u00270x2\u0027,"},{"line_number":70,"context_line":"               help\u003d_(\u0027Iptables mangle mark used to mark ingress from \u0027"},{"line_number":71,"context_line":"                      \u0027external network\u0027)),"},{"line_number":72,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_077cc4b4","line":71,"in_reply_to":"9a80dd14_8c8e4226","updated":"2015-03-11 22:51:28.000000000","message":"Done","commit_id":"6931421af17db0fbb1be8b4fa248cb44113e4ec8"}],"neutron/agent/linux/iptables_manager.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"63f58a0b9c32171ba34ae88ab8695efe91d2fc3a","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            self.ipv4[\u0027nat\u0027].add_rule(\u0027snat\u0027, \u0027-j $float-snat\u0027)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            self.ipv4[\u0027mangle\u0027].add_chain(\u0027mark\u0027)"},{"line_number":368,"context_line":"            self.ipv4[\u0027mangle\u0027].add_rule(\u0027PREROUTING\u0027, \u0027-j $mark\u0027)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def get_chain(self, table, chain, ip_version\u003d4, wrap\u003dTrue):"},{"line_number":371,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_8fcfab55","line":368,"updated":"2015-03-13 02:12:47.000000000","message":"Is this $ correct here?","commit_id":"fb2278ede217a3fd9bf37eff30c3fb2f00ad41f1"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"c5dff3d0613bcfd17f646bd9f70b34d3f0387721","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            self.ipv4[\u0027nat\u0027].add_rule(\u0027snat\u0027, \u0027-j $float-snat\u0027)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            self.ipv4[\u0027mangle\u0027].add_chain(\u0027mark\u0027)"},{"line_number":368,"context_line":"            self.ipv4[\u0027mangle\u0027].add_rule(\u0027PREROUTING\u0027, \u0027-j $mark\u0027)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def get_chain(self, table, chain, ip_version\u003d4, wrap\u003dTrue):"},{"line_number":371,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a80dd14_833864d4","line":368,"in_reply_to":"9a80dd14_8fcfab55","updated":"2015-03-13 06:02:06.000000000","message":"yes. this is same as line 364,365.","commit_id":"fb2278ede217a3fd9bf37eff30c3fb2f00ad41f1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"01dcb8971c6efbdefd5cd6b64d89d3902e48e519","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            # the snat chain."},{"line_number":364,"context_line":"            self.ipv4[\u0027nat\u0027].add_chain(\u0027float-snat\u0027)"},{"line_number":365,"context_line":"            self.ipv4[\u0027nat\u0027].add_rule(\u0027snat\u0027, \u0027-j $float-snat\u0027)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            self.ipv4[\u0027mangle\u0027].add_chain(\u0027mark\u0027)"},{"line_number":368,"context_line":"            self.ipv4[\u0027mangle\u0027].add_rule(\u0027PREROUTING\u0027, \u0027-j $mark\u0027)"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6ced46_3032cf10","line":366,"updated":"2015-03-24 17:04:18.000000000","message":"nit: should probably have a comment here as above do","commit_id":"a18fc6ba3a1aabd47305df153dc10deac1a3672d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"7a0fb96ac6e5e069c123ec9c22155ab4142bc209","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            # the snat chain."},{"line_number":364,"context_line":"            self.ipv4[\u0027nat\u0027].add_chain(\u0027float-snat\u0027)"},{"line_number":365,"context_line":"            self.ipv4[\u0027nat\u0027].add_rule(\u0027snat\u0027, \u0027-j $float-snat\u0027)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            self.ipv4[\u0027mangle\u0027].add_chain(\u0027mark\u0027)"},{"line_number":368,"context_line":"            self.ipv4[\u0027mangle\u0027].add_rule(\u0027PREROUTING\u0027, \u0027-j $mark\u0027)"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa963961_bcf688d5","line":366,"in_reply_to":"1a6ced46_1bb88a75","updated":"2015-03-27 05:37:02.000000000","message":"Done","commit_id":"a18fc6ba3a1aabd47305df153dc10deac1a3672d"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"2e538e93438c29cb8447d3c8c9a5d92133848289","unresolved":false,"context_lines":[{"line_number":363,"context_line":"            # the snat chain."},{"line_number":364,"context_line":"            self.ipv4[\u0027nat\u0027].add_chain(\u0027float-snat\u0027)"},{"line_number":365,"context_line":"            self.ipv4[\u0027nat\u0027].add_rule(\u0027snat\u0027, \u0027-j $float-snat\u0027)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            self.ipv4[\u0027mangle\u0027].add_chain(\u0027mark\u0027)"},{"line_number":368,"context_line":"            self.ipv4[\u0027mangle\u0027].add_rule(\u0027PREROUTING\u0027, \u0027-j $mark\u0027)"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6ced46_1bb88a75","line":366,"in_reply_to":"1a6ced46_3032cf10","updated":"2015-03-24 21:49:59.000000000","message":"Thank you for the comment. will do next upload.","commit_id":"a18fc6ba3a1aabd47305df153dc10deac1a3672d"}],"neutron/tests/functional/agent/test_l3_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bcc06a02e231ad27230be4d8fb120c8146b7e16f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                                 extra_routes\u003dextra_routes)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def manage_router(self, agent, router):"},{"line_number":117,"context_line":"        #self.addCleanup(self._delete_router, agent, router[\u0027id\u0027])"},{"line_number":118,"context_line":"        ri \u003d self._create_router(agent, router)"},{"line_number":119,"context_line":"        return ri"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa963961_613bb4ec","line":117,"updated":"2015-03-27 07:58:11.000000000","message":"leftover commented code","commit_id":"16966e293b23c45267b01a09c31ede1c6f39e019"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"26f1b4c26546fa78969d79c42b459aa512321a07","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                                 extra_routes\u003dextra_routes)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def manage_router(self, agent, router):"},{"line_number":117,"context_line":"        #self.addCleanup(self._delete_router, agent, router[\u0027id\u0027])"},{"line_number":118,"context_line":"        ri \u003d self._create_router(agent, router)"},{"line_number":119,"context_line":"        return ri"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da9b358b_be41e73b","line":117,"in_reply_to":"fa963961_613bb4ec","updated":"2015-03-29 22:21:21.000000000","message":"oops. done.","commit_id":"16966e293b23c45267b01a09c31ede1c6f39e019"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"32092a097aedd0939fc791090417ebe21b76fdbe","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                router1.get_ha_device_name()))"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def test_fip_connection_from_same_subnet(self):"},{"line_number":566,"context_line":"        \u0027\u0027\u0027Test connection to floaingip which is associated with"},{"line_number":567,"context_line":"           fixed_ip on the same subnet of the source fixed_ip."},{"line_number":568,"context_line":"           In other words it confirms that return packets surely"},{"line_number":569,"context_line":"           go through the router."}],"source_content_type":"text/x-python","patch_set":11,"id":"da9b358b_5e7e5baf","line":566,"updated":"2015-03-29 23:49:48.000000000","message":"floaingip -\u003e floatingip","commit_id":"17a5590bf59289dc3a2e345b1965abd22b712a38"}]}
