)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"cc1cc68eafedf7a2363d6204e059b7e9a937dd5f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"if network_device_mtu parameter is configured, set the MTU for"},{"line_number":10,"context_line":"fpr and rfp interfaces to the value specified by the parameter"},{"line_number":11,"context_line":"at the time of creation of these interfaces."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1429162"},{"line_number":14,"context_line":"Change-Id: Ie41122d1f7306dfd3debbbb8dbf2ecabf716dcb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_08fabf42","line":12,"updated":"2015-03-07 02:26:00.000000000","message":"The patch topic should be \u0027bug/1429162\u0027 by the way.","commit_id":"70f5fb8c74a4bf8d35e52f870eb8b5f545b1cd6e"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"3ada90b9010b43ee47c8a25c3ef8df3d7b2ef631","unresolved":false,"context_lines":[{"line_number":9,"context_line":"if network_device_mtu parameter is configured, set the MTU for"},{"line_number":10,"context_line":"fpr and rfp interfaces to the value specified by the parameter"},{"line_number":11,"context_line":"at the time of creation of these interfaces."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1429162"},{"line_number":14,"context_line":"Change-Id: Ie41122d1f7306dfd3debbbb8dbf2ecabf716dcb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_3cbde0b7","line":12,"in_reply_to":"9a80dd14_08fabf42","updated":"2015-03-09 15:16:51.000000000","message":"Done","commit_id":"70f5fb8c74a4bf8d35e52f870eb8b5f545b1cd6e"},{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"0603b2299c8102d35eae487bd33bde77ad6a4e05","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-03-16 11:57:47 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"If configured, set the MTU for fpr/rfp intefaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if network_device_mtu parameter is configured, set the MTU for"},{"line_number":10,"context_line":"fpr and rfp interfaces to the value specified by the parameter"},{"line_number":11,"context_line":"at the time of creation of these interfaces."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_c162e6d8","line":8,"updated":"2015-03-16 18:46:35.000000000","message":"where would this be configured?","commit_id":"6bc6e933f97d792aac476641101ebda7e5e46c44"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"31c4a13e7c99dfd8d12e50cc7aa4b677357c6612","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-03-16 11:57:47 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"If configured, set the MTU for fpr/rfp intefaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if network_device_mtu parameter is configured, set the MTU for"},{"line_number":10,"context_line":"fpr and rfp interfaces to the value specified by the parameter"},{"line_number":11,"context_line":"at the time of creation of these interfaces."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_7f3ccee1","line":8,"in_reply_to":"9a80dd14_c162e6d8","updated":"2015-03-19 15:39:17.000000000","message":"the MTU would be configured in configuration file for the l3 agent by setting the parameter \u0027network_device_mtu\u0027 to the desired value.\n\nNote: The parameter \u0027network_device_mtu\u0027 is an existing configuration parameter. This patch is not introducing a new parameter but merely making the code honor it for fpr/rfp interfaces","commit_id":"6bc6e933f97d792aac476641101ebda7e5e46c44"}],"neutron/agent/l3/dvr_fip_ns.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"c25484a35b60f2a328fab1fac3161df1ee90804a","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                                              ri.ns_name)"},{"line_number":198,"context_line":"            self._internal_ns_interface_added(str(fip_2_rtr),"},{"line_number":199,"context_line":"                                              fip_2_rtr_name,"},{"line_number":200,"context_line":"                                              fip_ns_name)"},{"line_number":201,"context_line":"            if self.agent_conf.network_device_mtu:"},{"line_number":202,"context_line":"                int_dev[0].link.set_mtu(self.agent_conf.network_device_mtu)"},{"line_number":203,"context_line":"                int_dev[1].link.set_mtu(self.agent_conf.network_device_mtu)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_08f0ff8f","line":200,"updated":"2015-03-07 02:21:18.000000000","message":"What do you think about adding an optional MTU argument to IPWrapper.add_veth, instead of the caller setting it? One indicator that the MTU is being set at the wrong level is that the testing is done at a higher level than necessary.","commit_id":"70f5fb8c74a4bf8d35e52f870eb8b5f545b1cd6e"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"3ada90b9010b43ee47c8a25c3ef8df3d7b2ef631","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                                              ri.ns_name)"},{"line_number":198,"context_line":"            self._internal_ns_interface_added(str(fip_2_rtr),"},{"line_number":199,"context_line":"                                              fip_2_rtr_name,"},{"line_number":200,"context_line":"                                              fip_ns_name)"},{"line_number":201,"context_line":"            if self.agent_conf.network_device_mtu:"},{"line_number":202,"context_line":"                int_dev[0].link.set_mtu(self.agent_conf.network_device_mtu)"},{"line_number":203,"context_line":"                int_dev[1].link.set_mtu(self.agent_conf.network_device_mtu)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_373edb8c","line":200,"in_reply_to":"9a80dd14_08f0ff8f","updated":"2015-03-09 15:16:51.000000000","message":"That would work too and I did think about it. But then there is already an existing method to set the MTU and quite a bit of existing code uses it. So decided to keep it consistent. Having one common method is sometime helpful in building up future functionality, say one wants to add some sort of compatibility test for MTUs, set_mtu can be a central place for such additions.","commit_id":"70f5fb8c74a4bf8d35e52f870eb8b5f545b1cd6e"}],"neutron/tests/unit/agent/test_dvr_fip_ns.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"c25484a35b60f2a328fab1fac3161df1ee90804a","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @mock.patch.object(ip_lib, \u0027IPWrapper\u0027)"},{"line_number":113,"context_line":"    @mock.patch.object(ip_lib, \u0027IPDevice\u0027)"},{"line_number":114,"context_line":"    @mock.patch.object(ip_lib, \u0027device_exists\u0027)"},{"line_number":115,"context_line":"    def _test_create_rtr_2_fip_link(self,"},{"line_number":116,"context_line":"                                    device_exists,"},{"line_number":117,"context_line":"                                    IPDevice,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_a85d337b","line":114,"updated":"2015-03-07 02:21:18.000000000","message":"Please consider asserting the expected MTU for all devices in the DVR functional tests.","commit_id":"70f5fb8c74a4bf8d35e52f870eb8b5f545b1cd6e"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"3ada90b9010b43ee47c8a25c3ef8df3d7b2ef631","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @mock.patch.object(ip_lib, \u0027IPWrapper\u0027)"},{"line_number":113,"context_line":"    @mock.patch.object(ip_lib, \u0027IPDevice\u0027)"},{"line_number":114,"context_line":"    @mock.patch.object(ip_lib, \u0027device_exists\u0027)"},{"line_number":115,"context_line":"    def _test_create_rtr_2_fip_link(self,"},{"line_number":116,"context_line":"                                    device_exists,"},{"line_number":117,"context_line":"                                    IPDevice,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_d76bbf82","line":114,"in_reply_to":"9a80dd14_a85d337b","updated":"2015-03-09 15:16:51.000000000","message":"sure, I will talk to Adolfo to consider this as enhancements to the DVR functional tests.","commit_id":"70f5fb8c74a4bf8d35e52f870eb8b5f545b1cd6e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"bac563a0a574481e95998822c7a9dbba47b908d5","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @mock.patch.object(ip_lib, \u0027IPWrapper\u0027)"},{"line_number":113,"context_line":"    @mock.patch.object(ip_lib, \u0027IPDevice\u0027)"},{"line_number":114,"context_line":"    @mock.patch.object(ip_lib, \u0027device_exists\u0027)"},{"line_number":115,"context_line":"    def _test_create_rtr_2_fip_link(self,"},{"line_number":116,"context_line":"                                    device_exists,"},{"line_number":117,"context_line":"                                    IPDevice,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_72ea21ad","line":114,"in_reply_to":"9a80dd14_d76bbf82","updated":"2015-03-09 15:24:48.000000000","message":"There\u0027s no reason to do this in a separate patch...","commit_id":"70f5fb8c74a4bf8d35e52f870eb8b5f545b1cd6e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"c25484a35b60f2a328fab1fac3161df1ee90804a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def _test_create_rtr_2_fip_link(self,"},{"line_number":116,"context_line":"                                    device_exists,"},{"line_number":117,"context_line":"                                    IPDevice,"},{"line_number":118,"context_line":"                                    IPWrapper,"},{"line_number":119,"context_line":"                                    isMtuSet\u003dFalse):"},{"line_number":120,"context_line":"        ri \u003d mock.Mock()"},{"line_number":121,"context_line":"        ri.router_id \u003d _uuid()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_68325b60","line":118,"updated":"2015-03-07 02:21:18.000000000","message":"The convention is lower case separated by underscore (is_mtu_set)","commit_id":"70f5fb8c74a4bf8d35e52f870eb8b5f545b1cd6e"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"3ada90b9010b43ee47c8a25c3ef8df3d7b2ef631","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def _test_create_rtr_2_fip_link(self,"},{"line_number":116,"context_line":"                                    device_exists,"},{"line_number":117,"context_line":"                                    IPDevice,"},{"line_number":118,"context_line":"                                    IPWrapper,"},{"line_number":119,"context_line":"                                    isMtuSet\u003dFalse):"},{"line_number":120,"context_line":"        ri \u003d mock.Mock()"},{"line_number":121,"context_line":"        ri.router_id \u003d _uuid()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_1730f79d","line":118,"in_reply_to":"9a80dd14_68325b60","updated":"2015-03-09 15:16:51.000000000","message":"Done","commit_id":"70f5fb8c74a4bf8d35e52f870eb8b5f545b1cd6e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"c25484a35b60f2a328fab1fac3161df1ee90804a","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            device.link.set_mtu.assert_called_with(2000)"},{"line_number":147,"context_line":"        device.route.add_gateway.assert_called_once_with("},{"line_number":148,"context_line":"            \u0027169.254.31.29\u0027, table\u003d16)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_create_rtr_2_fip_link(self):"},{"line_number":151,"context_line":"        self._test_create_rtr_2_fip_link()"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_c840a7a7","line":149,"updated":"2015-03-07 02:21:18.000000000","message":"There\u0027s no need for this test as you\u0027re invoking all code paths with the other test.","commit_id":"70f5fb8c74a4bf8d35e52f870eb8b5f545b1cd6e"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"3ada90b9010b43ee47c8a25c3ef8df3d7b2ef631","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            device.link.set_mtu.assert_called_with(2000)"},{"line_number":147,"context_line":"        device.route.add_gateway.assert_called_once_with("},{"line_number":148,"context_line":"            \u0027169.254.31.29\u0027, table\u003d16)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_create_rtr_2_fip_link(self):"},{"line_number":151,"context_line":"        self._test_create_rtr_2_fip_link()"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_d254adcb","line":149,"in_reply_to":"9a80dd14_c840a7a7","updated":"2015-03-09 15:16:51.000000000","message":"I see your point, updated the test accordingly.","commit_id":"70f5fb8c74a4bf8d35e52f870eb8b5f545b1cd6e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6bb9fd07b91706519a57889271fc9c9043349ce9","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                                               fip_ns_name)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        device \u003d IPDevice()"},{"line_number":140,"context_line":"        device.link.set_mtu.assert_called_with(2000)"},{"line_number":141,"context_line":"        device.route.add_gateway.assert_called_once_with("},{"line_number":142,"context_line":"            \u0027169.254.31.29\u0027, table\u003d16)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_7e7739a0","line":140,"updated":"2015-03-09 23:32:04.000000000","message":"shouldn\u0027t want you to assert that you actually got two calls?","commit_id":"a0081fd97332d397d76829b96228ac7fcb5c709f"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"0e625ecb8efd95d61490c887478e2f7133f213c7","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                                               fip_ns_name)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        device \u003d IPDevice()"},{"line_number":140,"context_line":"        device.link.set_mtu.assert_called_with(2000)"},{"line_number":141,"context_line":"        device.route.add_gateway.assert_called_once_with("},{"line_number":142,"context_line":"            \u0027169.254.31.29\u0027, table\u003d16)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_2494d489","line":140,"in_reply_to":"9a80dd14_7e7739a0","updated":"2015-03-10 00:39:17.000000000","message":"Done","commit_id":"a0081fd97332d397d76829b96228ac7fcb5c709f"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"437dc1c6a3e06004bbf144c3f65359adcd4704f1","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                                               fip_ns_name)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        device \u003d IPDevice()"},{"line_number":140,"context_line":"        device.link.set_mtu.assert_called_with(2000)"},{"line_number":141,"context_line":"        self.assertEqual(device.link.set_mtu.call_count, 2)"},{"line_number":142,"context_line":"        device.route.add_gateway.assert_called_once_with("},{"line_number":143,"context_line":"            \u0027169.254.31.29\u0027, table\u003d16)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_7fd46547","line":140,"updated":"2015-03-10 19:31:55.000000000","message":"As per my previous comment, this mock-based unit test doesn\u0027t do anything that the functional test doesn\u0027t do better.  If you want to validate something in a unit test, the case where setting the mtu is not performed is suggested, since it doesn\u0027t require interacting with the system.","commit_id":"0b8f77ef31476782bd05476ddb460819bb413216"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"b50517004d76fbc435c624d68d1e996fe7e2a6d6","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        pair \u003d lla.LinkLocalAddressPair(\u0027169.254.31.28/31\u0027)"},{"line_number":127,"context_line":"        allocator.allocate.return_value \u003d pair"},{"line_number":128,"context_line":"        device_exists.return_value \u003d False"},{"line_number":129,"context_line":"        ip_wrapper \u003d IPWrapper()"},{"line_number":130,"context_line":"        self.conf.network_device_mtu \u003d 2000"},{"line_number":131,"context_line":"        ip_wrapper.add_veth.return_value \u003d (IPDevice(), IPDevice())"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_f1a08193","line":129,"updated":"2015-03-17 06:42:51.000000000","message":"pedant nit: I would keep the IP wrapper down @ 134 where it\u0027s used, it\u0027s been moved up unnecessarily.","commit_id":"6bc6e933f97d792aac476641101ebda7e5e46c44"},{"author":{"_account_id":9077,"name":"Rajeev Grover","email":"rgrover687@gmail.com","username":"rajeev"},"change_message_id":"31c4a13e7c99dfd8d12e50cc7aa4b677357c6612","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        pair \u003d lla.LinkLocalAddressPair(\u0027169.254.31.28/31\u0027)"},{"line_number":127,"context_line":"        allocator.allocate.return_value \u003d pair"},{"line_number":128,"context_line":"        device_exists.return_value \u003d False"},{"line_number":129,"context_line":"        ip_wrapper \u003d IPWrapper()"},{"line_number":130,"context_line":"        self.conf.network_device_mtu \u003d 2000"},{"line_number":131,"context_line":"        ip_wrapper.add_veth.return_value \u003d (IPDevice(), IPDevice())"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_f288f56c","line":129,"in_reply_to":"9a80dd14_f1a08193","updated":"2015-03-19 15:39:17.000000000","message":"Miguel,\n there is now an additional use of IP wrapper @ 131 (Patch set 5) so had to move it up. Thanks for reviewing the code.","commit_id":"6bc6e933f97d792aac476641101ebda7e5e46c44"}]}
