)]}'
{"neutron/tests/functional/agent/test_l3_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d9fc185ae5c4531882b789e8505c47ab8f0197dd","unresolved":false,"context_lines":[{"line_number":613,"context_line":"            router1_info[\u0027_floatingips\u0027][0][\u0027floating_network_id\u0027])"},{"line_number":614,"context_line":"        router1 \u003d self.manage_router(self.agent, router1_info)"},{"line_number":615,"context_line":"        self._assert_snat_namespace_does_not_exist(router1)"},{"line_number":616,"context_line":"        self.assertTrue(self._namespace_exists(router1.ns_name))"},{"line_number":617,"context_line":"        fip1_ns \u003d router1.fip_ns.get_name()"},{"line_number":618,"context_line":"        dvr_router2_kwargs \u003d {\u0027ip_addr\u0027: \u002719.4.5.3\u0027,"},{"line_number":619,"context_line":"                              \u0027cidr\u0027: \u002719.4.5.0/24\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_1dd8281d","line":616,"updated":"2015-03-13 19:18:38.000000000","message":"can we avoid intermingling the various asserts between router1 and router2, and define variables closer to where they are used? for instance you could move the assert on fip1_ns closer to like 617.","commit_id":"4244aeae3c60f9b0bd4a10940913d2648e455fcf"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"d3206cecd5414bcd7deced32167a40f6e9e53927","unresolved":false,"context_lines":[{"line_number":613,"context_line":"            router1_info[\u0027_floatingips\u0027][0][\u0027floating_network_id\u0027])"},{"line_number":614,"context_line":"        router1 \u003d self.manage_router(self.agent, router1_info)"},{"line_number":615,"context_line":"        self._assert_snat_namespace_does_not_exist(router1)"},{"line_number":616,"context_line":"        self.assertTrue(self._namespace_exists(router1.ns_name))"},{"line_number":617,"context_line":"        fip1_ns \u003d router1.fip_ns.get_name()"},{"line_number":618,"context_line":"        dvr_router2_kwargs \u003d {\u0027ip_addr\u0027: \u002719.4.5.3\u0027,"},{"line_number":619,"context_line":"                              \u0027cidr\u0027: \u002719.4.5.0/24\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_6e15e73e","line":616,"in_reply_to":"9a80dd14_1dd8281d","updated":"2015-03-13 22:42:09.000000000","message":"will fix it.","commit_id":"4244aeae3c60f9b0bd4a10940913d2648e455fcf"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"e7bbcf2eeb7b1aa6f5772a7593d86dea2d8a692a","unresolved":false,"context_lines":[{"line_number":808,"context_line":"                              \u0027subnet_cidr\u0027: \u002719.4.4.0/24\u0027,"},{"line_number":809,"context_line":"                              \u0027gateway_ip\u0027: \u002719.4.4.1\u0027,"},{"line_number":810,"context_line":"                              \u0027gateway_mac\u0027: \u0027ca:fe:de:ab:cd:ef\u0027}"},{"line_number":811,"context_line":"        router1_info \u003d self.generate_dvr_router_info(**dvr_router1_kwargs)"},{"line_number":812,"context_line":"        mocked1_ext_net_id \u003d ("},{"line_number":813,"context_line":"            neutron_l3_agent.L3PluginApi.return_value.get_external_network_id)"},{"line_number":814,"context_line":"        mocked1_ext_net_id.return_value \u003d ("}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_63a055f5","line":811,"updated":"2015-04-02 11:09:08.000000000","message":"seems like lines 811-821 are a duplicate of lines 826-836. Maybe you can create an helper method to extract those line and avoid code duplication, something line \"_test_dvr_router_fips_ext_network\"","commit_id":"0523bc81a739c5ebaea78a6c7b78101649b1677f"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"9888d8c39101cd4637a6ad25ed60627b29755390","unresolved":false,"context_lines":[{"line_number":808,"context_line":"                              \u0027subnet_cidr\u0027: \u002719.4.4.0/24\u0027,"},{"line_number":809,"context_line":"                              \u0027gateway_ip\u0027: \u002719.4.4.1\u0027,"},{"line_number":810,"context_line":"                              \u0027gateway_mac\u0027: \u0027ca:fe:de:ab:cd:ef\u0027}"},{"line_number":811,"context_line":"        router1_info \u003d self.generate_dvr_router_info(**dvr_router1_kwargs)"},{"line_number":812,"context_line":"        mocked1_ext_net_id \u003d ("},{"line_number":813,"context_line":"            neutron_l3_agent.L3PluginApi.return_value.get_external_network_id)"},{"line_number":814,"context_line":"        mocked1_ext_net_id.return_value \u003d ("}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_d4efa085","line":811,"in_reply_to":"baa041b7_63a055f5","updated":"2015-04-03 18:19:14.000000000","message":"Addressed your review comments in patch 9","commit_id":"0523bc81a739c5ebaea78a6c7b78101649b1677f"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"4cdd2da8347441f39eb5185ebf7e2c6c42392eea","unresolved":false,"context_lines":[{"line_number":895,"context_line":"    def _validate_fips_for_external_network(self, router, fip_ns):"},{"line_number":896,"context_line":"        self.assertTrue(self._namespace_exists(router.ns_name))"},{"line_number":897,"context_line":"        self.assertTrue(self._namespace_exists(fip_ns))"},{"line_number":898,"context_line":"        self._assert_dvr_floating_ips(router)"},{"line_number":899,"context_line":"        self._assert_snat_namespace_does_not_exist(router)"},{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    def test_dvr_router_fips_for_multiple_ext_networks(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aaa499b_f8c76a43","line":898,"updated":"2015-04-13 14:40:24.000000000","message":"I don\u0027t know if this next assertion makes sense in the context of this method?","commit_id":"61aa4a57b17594bb0412f870f361a8a35ec07b62"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"4cdd2da8347441f39eb5185ebf7e2c6c42392eea","unresolved":false,"context_lines":[{"line_number":985,"context_line":"            enable_floating_ip\u003dTrue,"},{"line_number":986,"context_line":"            enable_ha\u003denable_ha,"},{"line_number":987,"context_line":"            **kwargs)"},{"line_number":988,"context_line":"        internal_ports \u003d router.get(l3_constants.INTERFACE_KEY, [])"},{"line_number":989,"context_line":"        router[\u0027distributed\u0027] \u003d True"},{"line_number":990,"context_line":"        router[\u0027gw_port_host\u0027] \u003d self.agent.conf.host"},{"line_number":991,"context_line":"        router[\u0027gw_port\u0027][\u0027binding:host_id\u0027] \u003d self.agent.conf.host"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aaa499b_b890c2ed","line":988,"updated":"2015-04-13 14:40:24.000000000","message":"I wish that this function and the router generation code in the unit test file lived next to each other, but that\u0027s completely unrelated to this patch, just a general gripe...","commit_id":"61aa4a57b17594bb0412f870f361a8a35ec07b62"}],"neutron/tests/unit/agent/l3/test_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"03c98a055f3e3e8d4db6a42a85155a29b06c4f19","unresolved":false,"context_lines":[{"line_number":180,"context_line":"def prepare_router_data(ip_version\u003d4, enable_snat\u003dNone, num_internal_ports\u003d1,"},{"line_number":181,"context_line":"                        enable_floating_ip\u003dFalse, enable_ha\u003dFalse,"},{"line_number":182,"context_line":"                        extra_routes\u003dFalse, dual_stack\u003dFalse,"},{"line_number":183,"context_line":"                        v6_ext_gw_with_sub\u003dTrue, **kwargs):"},{"line_number":184,"context_line":"    fixed_ips \u003d []"},{"line_number":185,"context_line":"    subnets \u003d []"},{"line_number":186,"context_line":"    for loop_version in (4, 6):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7aaa499b_c52aa92c","line":183,"updated":"2015-04-10 20:26:42.000000000","message":"(no action required): someone might make the argument that it\u0027d be better to expand all named args or none of them. So maybe something to bear in mind if you have to respin.","commit_id":"61aa4a57b17594bb0412f870f361a8a35ec07b62"}]}
