)]}'
{"neutron/api/v2/base.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"283f9edbcc75790dbd72f7e05180e71b7b6e5d67","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        policy.init()"},{"line_number":418,"context_line":"        # Store requested resource amounts grouping them by tenant"},{"line_number":419,"context_line":"        # This won\u0027t work with multiple resources. However because of the"},{"line_number":420,"context_line":"        # icurrent structure of this controller there will hardly be more than"},{"line_number":421,"context_line":"        # one resource for which reservations are being made"},{"line_number":422,"context_line":"        request_deltas \u003d {}"},{"line_number":423,"context_line":"        for item in items:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_957538cc","line":420,"range":{"start_line":420,"start_character":10,"end_line":420,"end_character":19},"updated":"2015-08-12 05:07:25.000000000","message":"icurrent -\u003e current","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d08fb0bbbbb37e36beeb2b9c4d5bc83b21dc8051","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        policy.init()"},{"line_number":418,"context_line":"        # Store requested resource amounts grouping them by tenant"},{"line_number":419,"context_line":"        # This won\u0027t work with multiple resources. However because of the"},{"line_number":420,"context_line":"        # icurrent structure of this controller there will hardly be more than"},{"line_number":421,"context_line":"        # one resource for which reservations are being made"},{"line_number":422,"context_line":"        request_deltas \u003d {}"},{"line_number":423,"context_line":"        for item in items:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_5179a9c6","line":420,"in_reply_to":"1a4dcd0f_957538cc","updated":"2015-08-13 15:40:53.000000000","message":"Done","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"283f9edbcc75790dbd72f7e05180e71b7b6e5d67","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                # no tenant_id - no quota check"},{"line_number":432,"context_line":"                continue"},{"line_number":433,"context_line":"            tenant_id \u003d item[self._resource][\u0027tenant_id\u0027]"},{"line_number":434,"context_line":"            delta \u003d request_deltas.setdefault(tenant_id, 0)"},{"line_number":435,"context_line":"            delta \u003d delta + 1"},{"line_number":436,"context_line":"            request_deltas[tenant_id] \u003d delta"},{"line_number":437,"context_line":"        # Quota enforcement"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_5529f099","line":434,"range":{"start_line":434,"start_character":35,"end_line":434,"end_character":45},"updated":"2015-08-12 05:07:25.000000000","message":"setdefault() works, but .get() looks enough since request_deltas[tenant_id] is assigned at L.436. I might be missing something.","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d08fb0bbbbb37e36beeb2b9c4d5bc83b21dc8051","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                # no tenant_id - no quota check"},{"line_number":432,"context_line":"                continue"},{"line_number":433,"context_line":"            tenant_id \u003d item[self._resource][\u0027tenant_id\u0027]"},{"line_number":434,"context_line":"            delta \u003d request_deltas.setdefault(tenant_id, 0)"},{"line_number":435,"context_line":"            delta \u003d delta + 1"},{"line_number":436,"context_line":"            request_deltas[tenant_id] \u003d delta"},{"line_number":437,"context_line":"        # Quota enforcement"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_f13555f6","line":434,"in_reply_to":"1a4dcd0f_5529f099","updated":"2015-08-13 15:40:53.000000000","message":"nah you\u0027re right.","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"}],"neutron/db/quota/api.py":[{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"32500b4512555491ea995191a824bc770c94b83b","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    # This method is usually called from within another transaction."},{"line_number":202,"context_line":"    # Consider using begin_nested"},{"line_number":203,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":204,"context_line":"        expiration \u003d expiration or (utcnow() + datetime.timedelta(0, 60))"},{"line_number":205,"context_line":"        resv \u003d quota_models.Reservation(tenant_id\u003dtenant_id,"},{"line_number":206,"context_line":"                                        expiration\u003dexpiration)"},{"line_number":207,"context_line":"        context.session.add(resv)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_df69a2fa","line":204,"updated":"2015-07-08 12:48:56.000000000","message":"I thought the spec suggested a default of at least 120 seconds?","commit_id":"5cbf6e1390e0771a1f9545e97eb5a442ebc2f2b7"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"90bdc87b61f2e24ce4845ab26c3ced3488e823ee","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    # This method is usually called from within another transaction."},{"line_number":202,"context_line":"    # Consider using begin_nested"},{"line_number":203,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":204,"context_line":"        expiration \u003d expiration or (utcnow() + datetime.timedelta(0, 60))"},{"line_number":205,"context_line":"        resv \u003d quota_models.Reservation(tenant_id\u003dtenant_id,"},{"line_number":206,"context_line":"                                        expiration\u003dexpiration)"},{"line_number":207,"context_line":"        context.session.add(resv)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_5b48265c","line":204,"in_reply_to":"ba3cc151_df69a2fa","updated":"2015-07-08 22:34:42.000000000","message":"I don\u0027t remember the spec that I wrote...! but yeah I can do 120","commit_id":"5cbf6e1390e0771a1f9545e97eb5a442ebc2f2b7"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"e1c68981cd922f00ed1f1a5625c4d9f584dec209","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    # This method is usually called from within another transaction."},{"line_number":200,"context_line":"    # Consider using begin_nested"},{"line_number":201,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":202,"context_line":"        expiration \u003d expiration or (utcnow() + datetime.timedelta(0, 60))"},{"line_number":203,"context_line":"        resv \u003d quota_models.Reservation(tenant_id\u003dtenant_id,"},{"line_number":204,"context_line":"                                        expiration\u003dexpiration)"},{"line_number":205,"context_line":"        context.session.add(resv)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a50d1a3_c92deda9","line":202,"updated":"2015-07-30 14:51:06.000000000","message":"salv-orlando: 120 seconds? :)","commit_id":"905c304ec1c1ea71287324595437c7ddb4f22d29"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"283f9edbcc75790dbd72f7e05180e71b7b6e5d67","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.db.quota import models as quota_models"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Wrapper for utcnow - needed for mocking it in unit tests"},{"line_number":26,"context_line":"def utcnow():"},{"line_number":27,"context_line":"    return datetime.datetime.utcnow()"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_0319f287","line":25,"updated":"2015-08-12 05:07:25.000000000","message":"(just a question) Can\u0027t we mock datetime.datetime.utcnow directly?","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d08fb0bbbbb37e36beeb2b9c4d5bc83b21dc8051","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.db.quota import models as quota_models"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Wrapper for utcnow - needed for mocking it in unit tests"},{"line_number":26,"context_line":"def utcnow():"},{"line_number":27,"context_line":"    return datetime.datetime.utcnow()"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_2c6fe460","line":25,"in_reply_to":"1a4dcd0f_0319f287","updated":"2015-08-13 15:40:53.000000000","message":"no we can\u0027t!\n\n\u003e\u003e\u003e patcher \u003d mock.patch(\u0027datetime.datetime.utcnow\u0027)\n\u003e\u003e\u003e patcher.start()\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  File \"/usr/local/lib/python2.7/dist-packages/mock/mock.py\", line 1490, in start\n    result \u003d self.__enter__()\n  File \"/usr/local/lib/python2.7/dist-packages/mock/mock.py\", line 1453, in __enter__\n    setattr(self.target, self.attribute, new_attr)\nTypeError: can\u0027t set attributes of built-in/extension type \u0027datetime.datetime\u0027\n\nan explanation: http://stackoverflow.com/questions/192649/can-you-monkey-patch-methods-on-core-types-in-python/192857#192857","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"283f9edbcc75790dbd72f7e05180e71b7b6e5d67","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    query \u003d common_db_api.model_query(context, quota_models.QuotaUsage)"},{"line_number":164,"context_line":"    query \u003d query.filter_by(resource\u003dresource).filter_by(tenant_id\u003dtenant_id)"},{"line_number":165,"context_line":"    value \u003d query.update({\u0027dirty\u0027: dirty})"},{"line_number":166,"context_line":"    return value"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"def set_resources_quota_usage_dirty(context, resources, tenant_id, dirty\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_d859b5fe","line":166,"updated":"2015-08-12 05:07:25.000000000","message":"nit: what\u0027s the difference from the previous version?","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d08fb0bbbbb37e36beeb2b9c4d5bc83b21dc8051","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    query \u003d common_db_api.model_query(context, quota_models.QuotaUsage)"},{"line_number":164,"context_line":"    query \u003d query.filter_by(resource\u003dresource).filter_by(tenant_id\u003dtenant_id)"},{"line_number":165,"context_line":"    value \u003d query.update({\u0027dirty\u0027: dirty})"},{"line_number":166,"context_line":"    return value"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"def set_resources_quota_usage_dirty(context, resources, tenant_id, dirty\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_cc38c0a2","line":166,"in_reply_to":"1a4dcd0f_d859b5fe","updated":"2015-08-13 15:40:53.000000000","message":"there should have been no difference.\n\nThe story is that at some point I added a log stament before returning to do some debugging. then i removed the log statement but did not restore the code as it was before.\n\nthanks for noticing this.","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"283f9edbcc75790dbd72f7e05180e71b7b6e5d67","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    # This method is usually called from within another transaction."},{"line_number":200,"context_line":"    # Consider using begin_nested"},{"line_number":201,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":202,"context_line":"        expiration \u003d expiration or (utcnow() + datetime.timedelta(0, 60))"},{"line_number":203,"context_line":"        resv \u003d quota_models.Reservation(tenant_id\u003dtenant_id,"},{"line_number":204,"context_line":"                                        expiration\u003dexpiration)"},{"line_number":205,"context_line":"        context.session.add(resv)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_3eb6813e","line":202,"range":{"start_line":202,"start_character":69,"end_line":202,"end_character":71},"updated":"2015-08-12 05:07:25.000000000","message":"The same question as Ryan\u0027s comment in patch set 17.\n\nThe last paragraph in \"Proposed Changes\" section (just before Data Model Change section) in the spec proposed for Kilo [1] says:\n\n----\n\nIt is also worth noting that the proposed expiration timestamps will prevent stale records from preventing acquiring the reservation facility or create ‘ghost’ resource reservation. The expiration timeout might be configurable, but a default of at least two minutes is advisable considering that the current neutron implementation still suffers of DB deadlocks triggered by eventlet, which with the default MySql setting block threads for about 50 seconds.\n\n----\n\nIt suggests a default value should be at least two minutes.\n\n[1] http://specs.openstack.org/openstack/neutron-specs/specs/kilo-backlog/better-quotas.html#proposed-change","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d08fb0bbbbb37e36beeb2b9c4d5bc83b21dc8051","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    # This method is usually called from within another transaction."},{"line_number":200,"context_line":"    # Consider using begin_nested"},{"line_number":201,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":202,"context_line":"        expiration \u003d expiration or (utcnow() + datetime.timedelta(0, 60))"},{"line_number":203,"context_line":"        resv \u003d quota_models.Reservation(tenant_id\u003dtenant_id,"},{"line_number":204,"context_line":"                                        expiration\u003dexpiration)"},{"line_number":205,"context_line":"        context.session.add(resv)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_ccea000f","line":202,"in_reply_to":"1a4dcd0f_3eb6813e","updated":"2015-08-13 15:40:53.000000000","message":"I\u0027m sorry I forgot to this change","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"283f9edbcc75790dbd72f7e05180e71b7b6e5d67","unresolved":false,"context_lines":[{"line_number":235,"context_line":"def remove_reservation(context, reservation_id, set_dirty\u003dFalse):"},{"line_number":236,"context_line":"    delete_query \u003d context.session.query(quota_models.Reservation).filter_by("},{"line_number":237,"context_line":"        id\u003dreservation_id)"},{"line_number":238,"context_line":"    reservation \u003d delete_query.first()"},{"line_number":239,"context_line":"    if not reservation:"},{"line_number":240,"context_line":"        # TODO(salv-orlando): Raise here and then handle the exception?"},{"line_number":241,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_18a71dbe","line":238,"updated":"2015-08-12 05:07:25.000000000","message":"one() can be used instead of first()? In case of one(), we need an extra try/except. Both works. one() is a bit clearer to me.","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d08fb0bbbbb37e36beeb2b9c4d5bc83b21dc8051","unresolved":false,"context_lines":[{"line_number":235,"context_line":"def remove_reservation(context, reservation_id, set_dirty\u003dFalse):"},{"line_number":236,"context_line":"    delete_query \u003d context.session.query(quota_models.Reservation).filter_by("},{"line_number":237,"context_line":"        id\u003dreservation_id)"},{"line_number":238,"context_line":"    reservation \u003d delete_query.first()"},{"line_number":239,"context_line":"    if not reservation:"},{"line_number":240,"context_line":"        # TODO(salv-orlando): Raise here and then handle the exception?"},{"line_number":241,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_2c5b6423","line":238,"in_reply_to":"1a4dcd0f_18a71dbe","updated":"2015-08-13 15:40:53.000000000","message":"I used first because there have been instances where I\u0027ve been asked to the opposite.\n\nThe complain there was that one raises if both no records or multiple records are found, so you had to handle both exceptions.\n\nI can change the code to use one anyway, it won\u0027t cost me a thing.","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"283f9edbcc75790dbd72f7e05180e71b7b6e5d67","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        quota_models.ResourceDelta.resource.in_(resources),"},{"line_number":279,"context_line":"        exp_expr)).group_by("},{"line_number":280,"context_line":"        quota_models.ResourceDelta.resource)"},{"line_number":281,"context_line":"    return (dict((resource, total_reserved)"},{"line_number":282,"context_line":"            for (resource, exp, total_reserved) in resv_query))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_b8406960","line":281,"range":{"start_line":281,"start_character":11,"end_line":281,"end_character":17},"updated":"2015-08-12 05:07:25.000000000","message":"nit: The outer most parentheses are unnecessary.","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d08fb0bbbbb37e36beeb2b9c4d5bc83b21dc8051","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        quota_models.ResourceDelta.resource.in_(resources),"},{"line_number":279,"context_line":"        exp_expr)).group_by("},{"line_number":280,"context_line":"        quota_models.ResourceDelta.resource)"},{"line_number":281,"context_line":"    return (dict((resource, total_reserved)"},{"line_number":282,"context_line":"            for (resource, exp, total_reserved) in resv_query))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_6cac0ced","line":281,"in_reply_to":"1a4dcd0f_b8406960","updated":"2015-08-13 15:40:53.000000000","message":"Done","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"5702a9bf9775352009917d8acdebf41ff8a48897","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    # This method is usually called from within another transaction."},{"line_number":200,"context_line":"    # Consider using begin_nested"},{"line_number":201,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":202,"context_line":"        expiration \u003d expiration or (utcnow() + datetime.timedelta(0, 120))"},{"line_number":203,"context_line":"        resv \u003d quota_models.Reservation(tenant_id\u003dtenant_id,"},{"line_number":204,"context_line":"                                        expiration\u003dexpiration)"},{"line_number":205,"context_line":"        context.session.add(resv)"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a4dcd0f_49ac6235","line":202,"updated":"2015-08-14 17:09:39.000000000","message":"This conflicts with the devref in the patch series.","commit_id":"884edc8a412a723fcb2274dd8d18ae08f355838a"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"0d99360ce3a4d258fb27521c16746af74881f4b2","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    # This method is usually called from within another transaction."},{"line_number":200,"context_line":"    # Consider using begin_nested"},{"line_number":201,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":202,"context_line":"        expiration \u003d expiration or (utcnow() + datetime.timedelta(0, 120))"},{"line_number":203,"context_line":"        resv \u003d quota_models.Reservation(tenant_id\u003dtenant_id,"},{"line_number":204,"context_line":"                                        expiration\u003dexpiration)"},{"line_number":205,"context_line":"        context.session.add(resv)"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a4dcd0f_71a4894a","line":202,"in_reply_to":"1a4dcd0f_49ac6235","updated":"2015-08-16 03:47:36.000000000","message":"I\u0027ve raised this in this patchset before - I don\u0027t really care which it is (60 or 120) - I just am looking for consistency at this point","commit_id":"884edc8a412a723fcb2274dd8d18ae08f355838a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1e69c7d31a2a8391775b2294c5d7b3bcdbb6bca7","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    # This method is usually called from within another transaction."},{"line_number":200,"context_line":"    # Consider using begin_nested"},{"line_number":201,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":202,"context_line":"        expiration \u003d expiration or (utcnow() + datetime.timedelta(0, 120))"},{"line_number":203,"context_line":"        resv \u003d quota_models.Reservation(tenant_id\u003dtenant_id,"},{"line_number":204,"context_line":"                                        expiration\u003dexpiration)"},{"line_number":205,"context_line":"        context.session.add(resv)"}],"source_content_type":"text/x-python","patch_set":22,"id":"fa1b9901_36263c69","line":202,"in_reply_to":"1a4dcd0f_71a4894a","updated":"2015-08-17 22:18:58.000000000","message":"you\u0027re right guys I\u0027m a mess at being consistent\n\nwell I\u0027m probably a mess at anything, but that\u0027s ok","commit_id":"884edc8a412a723fcb2274dd8d18ae08f355838a"}],"neutron/db/quota/driver.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"472cde721d55ccf0347f977e2c6aeaf76d8ccb49","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            # instances"},{"line_number":172,"context_line":"            # FIXME(salv-orlando): the way in which the plural name for the"},{"line_number":173,"context_line":"            # resource is calculated is a bug waiting to manifest and annoy"},{"line_number":174,"context_line":"            # people"},{"line_number":175,"context_line":"            current_usages \u003d dict("},{"line_number":176,"context_line":"                (resource, resources[resource].count("},{"line_number":177,"context_line":"                    context, plugin, \u0027%ss\u0027 % resource, tenant_id)) for"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_eb4f56bc","line":174,"updated":"2015-06-22 14:39:20.000000000","message":"ha! it\u0027s biting me already ;)","commit_id":"2f6c7ef4a73c44d298bb7602bbd72bbfed950514"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"175e9493826d63b7fcd725d9237c893330d6f926","unresolved":false,"context_lines":[{"line_number":145,"context_line":"            context, tenant_id\u003dtenant_id)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @oslo_db_api.wrap_db_retry(max_retries\u003ddb_api.MAX_RETRIES,"},{"line_number":148,"context_line":"                               retry_on_request\u003dTrue,"},{"line_number":149,"context_line":"                               retry_on_deadlock\u003dTrue)"},{"line_number":150,"context_line":"    def make_reservation(self, context, tenant_id, resources, deltas, plugin):"},{"line_number":151,"context_line":"        # Lock current reservation table"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a50d1a3_73b3f0e9","line":148,"updated":"2015-07-22 09:25:48.000000000","message":"I don\u0027t think we really need retry_on_request\u003dTrue...","commit_id":"8c7c8237b28a38e9bc1e83d0b3c7e90dc0ffb483"}],"neutron/db/securitygroups_db.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a6740bd0a09224d3cb9299b95abdc772c36af975","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                                 security_group_rules)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def create_security_group_rule_bulk_native(self, context,"},{"line_number":350,"context_line":"                                               security_group_rules):"},{"line_number":351,"context_line":"        r \u003d security_group_rules[\u0027security_group_rules\u0027]"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        scoped_session(context.session)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_e017c1a0","line":350,"updated":"2015-06-19 07:33:06.000000000","message":"This is seems to be unrelated to current change..","commit_id":"d017a6597f20f9a8c4cc08a57d3c10e2900db862"}],"neutron/db/securitygroups_rpc_base.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a6740bd0a09224d3cb9299b95abdc772c36af975","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                        security_group_rules):"},{"line_number":81,"context_line":"        rules \u003d super(SecurityGroupServerRpcMixin,"},{"line_number":82,"context_line":"                      self).create_security_group_rule_bulk_native("},{"line_number":83,"context_line":"                          context, security_group_rules)"},{"line_number":84,"context_line":"        sgids \u003d set([r[\u0027security_group_id\u0027] for r in rules])"},{"line_number":85,"context_line":"        self.notifier.security_groups_rule_updated(context, list(sgids))"},{"line_number":86,"context_line":"        return rules"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_c062bd3d","line":83,"updated":"2015-06-19 07:33:06.000000000","message":"the same","commit_id":"d017a6597f20f9a8c4cc08a57d3c10e2900db862"}],"neutron/tests/unit/db/quota/test_api.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"283f9edbcc75790dbd72f7e05180e71b7b6e5d67","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        routine \u003d \u0027neutron.db.quota.api.set_resources_quota_usage_dirty\u0027"},{"line_number":248,"context_line":"        with mock.patch(routine) as mock_routine:"},{"line_number":249,"context_line":"            self._test_remove_reservation(False)"},{"line_number":250,"context_line":"            mock_routine.assert_called_once_with("},{"line_number":251,"context_line":"                self.context,"},{"line_number":252,"context_line":"                mock.ANY,"},{"line_number":253,"context_line":"                self.tenant_id)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_63523637","line":250,"range":{"start_line":250,"start_character":12,"end_line":250,"end_character":48},"updated":"2015-08-12 05:07:25.000000000","message":"(FYI) precisely speaking, this sentence can be out of with-clause.\nWhen exiting the mock clause, the mocked method is stopped, but \"mock_routine\" (from with clause) can be accessed even after exiting with-clause.","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"d08fb0bbbbb37e36beeb2b9c4d5bc83b21dc8051","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        routine \u003d \u0027neutron.db.quota.api.set_resources_quota_usage_dirty\u0027"},{"line_number":248,"context_line":"        with mock.patch(routine) as mock_routine:"},{"line_number":249,"context_line":"            self._test_remove_reservation(False)"},{"line_number":250,"context_line":"            mock_routine.assert_called_once_with("},{"line_number":251,"context_line":"                self.context,"},{"line_number":252,"context_line":"                mock.ANY,"},{"line_number":253,"context_line":"                self.tenant_id)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a4dcd0f_0cab0876","line":250,"in_reply_to":"1a4dcd0f_63523637","updated":"2015-08-13 15:40:53.000000000","message":"Done","commit_id":"939bc42ff7d468aa43e856703f451bf5c202adbc"}]}
