)]}'
{"neutron/tests/functional/plugins/openvswitch/test_ovs_agent.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"df1ad077a696417cc7cacf6eab661092aa7d58f7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.init_done_ev \u003d eventlet.event.Event()"},{"line_number":44,"context_line":"        self._main_thread \u003d eventlet.spawn(self._kick_main)"},{"line_number":45,"context_line":"        self.addCleanup(self._kill_main)"},{"line_number":46,"context_line":"        while not self.init_done:"},{"line_number":47,"context_line":"            self.init_done_ev.wait()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _kick_main(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"baa041b7_b104667e","line":46,"updated":"2015-04-02 10:55:11.000000000","message":"instead of using eventlet Event and mocking the main, why don\u0027t you use the main of the l2 agent and mock only what\u0027s needed? Something similar it\u0027s done for the l3 agent functional test. This would simplify the code a lot.","commit_id":"0c84875c01fafbfc18a9e7e928bb089394bb7b53"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"426df364fe6c230c08c1430554b44263d34baf6a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.init_done_ev \u003d eventlet.event.Event()"},{"line_number":44,"context_line":"        self._main_thread \u003d eventlet.spawn(self._kick_main)"},{"line_number":45,"context_line":"        self.addCleanup(self._kill_main)"},{"line_number":46,"context_line":"        while not self.init_done:"},{"line_number":47,"context_line":"            self.init_done_ev.wait()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _kick_main(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"baa041b7_2761073a","line":46,"in_reply_to":"baa041b7_57e50007","updated":"2015-04-03 15:23:13.000000000","message":"Got it.","commit_id":"0c84875c01fafbfc18a9e7e928bb089394bb7b53"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"16dbc676b765ae66143c4e8090ba8d0d5bc9948b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.init_done_ev \u003d eventlet.event.Event()"},{"line_number":44,"context_line":"        self._main_thread \u003d eventlet.spawn(self._kick_main)"},{"line_number":45,"context_line":"        self.addCleanup(self._kill_main)"},{"line_number":46,"context_line":"        while not self.init_done:"},{"line_number":47,"context_line":"            self.init_done_ev.wait()"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def _kick_main(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"baa041b7_57e50007","line":46,"in_reply_to":"baa041b7_b104667e","updated":"2015-04-02 15:41:33.000000000","message":"because this is a functional test of openflow drivers.\n\nIMO the entire agent is better tested by tempest etc.","commit_id":"0c84875c01fafbfc18a9e7e928bb089394bb7b53"}]}