)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"75a044f42a15f629f021d2b71d4082dd1f72b8ad","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rossella \u003crsblendido@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-13 17:00:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OVS agent react to events instead of polling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVSDB monitor generates the events that the OVS agent"},{"line_number":10,"context_line":"needs to process (device added or updated). Instead of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"1a4dcd0f_95ecafbc","line":7,"updated":"2015-08-15 00:28:51.000000000","message":"reacts","commit_id":"bb9fa02a049a7351c30d4a22f93ed573cf54e07e"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c30862e1cafdc18b1f18771569616864511518e2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     rossella \u003crsblendido@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-13 17:00:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OVS agent react to events instead of polling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVSDB monitor generates the events that the OVS agent"},{"line_number":10,"context_line":"needs to process (device added or updated). Instead of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"1a4dcd0f_cb45b36f","line":7,"in_reply_to":"1a4dcd0f_95ecafbc","updated":"2015-08-15 15:17:03.000000000","message":"Done","commit_id":"bb9fa02a049a7351c30d4a22f93ed573cf54e07e"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3774a3b31ac50a451259045ca12dd56d9fd9e0c3","unresolved":false,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def process_port_iface_id(self, result):"},{"line_number":375,"context_line":"        if result[\u0027ofport\u0027] \u003d\u003d UNASSIGNED_OFPORT:"},{"line_number":376,"context_line":"            LOG.warn(_LW(\"Found not yet ready openvswitch port: %s\"),"},{"line_number":377,"context_line":"                     result[\u0027name\u0027])"},{"line_number":378,"context_line":"        elif result[\u0027ofport\u0027] \u003d\u003d INVALID_OFPORT:"},{"line_number":379,"context_line":"            LOG.warn(_LW(\"Found failed openvswitch port: %s\"),"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a50d1a3_fb6292d8","line":376,"updated":"2015-08-01 22:56:54.000000000","message":"Is this even worthy of a warning message? This shows up during normal operations depending on the timing, right? Might be time for us to downgrade this.","commit_id":"19f4817721ba8f7bfb0c76dc94af28a1c50ec808"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"cca5ab016d0ddcd2be21eb4ba44bc90ce1dc565a","unresolved":false,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def process_port_iface_id(self, result):"},{"line_number":375,"context_line":"        if result[\u0027ofport\u0027] \u003d\u003d UNASSIGNED_OFPORT:"},{"line_number":376,"context_line":"            LOG.warn(_LW(\"Found not yet ready openvswitch port: %s\"),"},{"line_number":377,"context_line":"                     result[\u0027name\u0027])"},{"line_number":378,"context_line":"        elif result[\u0027ofport\u0027] \u003d\u003d INVALID_OFPORT:"},{"line_number":379,"context_line":"            LOG.warn(_LW(\"Found failed openvswitch port: %s\"),"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a4dcd0f_f13870d5","line":376,"in_reply_to":"3a50d1a3_fb6292d8","updated":"2015-08-11 13:53:41.000000000","message":"Done","commit_id":"19f4817721ba8f7bfb0c76dc94af28a1c50ec808"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8a60a254d703065a17b721c4cc0f0c1fa2219e47","unresolved":false,"context_lines":[{"line_number":1687,"context_line":"                    LOG.exception(_LE(\"Error while synchronizing tunnels\"))"},{"line_number":1688,"context_line":"                    tunnel_sync \u003d True"},{"line_number":1689,"context_line":"            ovs_restarted |\u003d (ovs_status \u003d\u003d constants.OVS_RESTARTED)"},{"line_number":1690,"context_line":"            if self._agent_has_updates(polling_manager) or sync:"},{"line_number":1691,"context_line":"                try:"},{"line_number":1692,"context_line":"                    LOG.debug(\"Agent rpc_loop - iteration:%(iter_num)d - \""},{"line_number":1693,"context_line":"                              \"starting polling. Elapsed:%(elapsed).3f\","}],"source_content_type":"text/x-python","patch_set":25,"id":"da20952f_de78d1c6","line":1690,"updated":"2015-09-03 21:14:17.000000000","message":"is _agent_has_updates guaranteed to return true if OVS has restarted?","commit_id":"02c9f7100bd8a1f8319b7b25436fac073d059e5b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"495ad94e3ed6705ef04def20bdd628144b917f03","unresolved":false,"context_lines":[{"line_number":1687,"context_line":"                    LOG.exception(_LE(\"Error while synchronizing tunnels\"))"},{"line_number":1688,"context_line":"                    tunnel_sync \u003d True"},{"line_number":1689,"context_line":"            ovs_restarted |\u003d (ovs_status \u003d\u003d constants.OVS_RESTARTED)"},{"line_number":1690,"context_line":"            if self._agent_has_updates(polling_manager) or sync:"},{"line_number":1691,"context_line":"                try:"},{"line_number":1692,"context_line":"                    LOG.debug(\"Agent rpc_loop - iteration:%(iter_num)d - \""},{"line_number":1693,"context_line":"                              \"starting polling. Elapsed:%(elapsed).3f\","}],"source_content_type":"text/x-python","patch_set":25,"id":"da20952f_413faf86","line":1690,"in_reply_to":"da20952f_1615bfe3","updated":"2015-09-07 08:08:58.000000000","message":"i think you are mixing two things.\novs-vswitchd, which is what ovs_restarted is for,\nand ovsdb-server, which is polling_manager is talking with.\nthese two processes can be restarted independently.","commit_id":"02c9f7100bd8a1f8319b7b25436fac073d059e5b"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"015367a4a1e34ddf51ebdaaa12c7d8646de6da74","unresolved":false,"context_lines":[{"line_number":1687,"context_line":"                    LOG.exception(_LE(\"Error while synchronizing tunnels\"))"},{"line_number":1688,"context_line":"                    tunnel_sync \u003d True"},{"line_number":1689,"context_line":"            ovs_restarted |\u003d (ovs_status \u003d\u003d constants.OVS_RESTARTED)"},{"line_number":1690,"context_line":"            if self._agent_has_updates(polling_manager) or sync:"},{"line_number":1691,"context_line":"                try:"},{"line_number":1692,"context_line":"                    LOG.debug(\"Agent rpc_loop - iteration:%(iter_num)d - \""},{"line_number":1693,"context_line":"                              \"starting polling. Elapsed:%(elapsed).3f\","}],"source_content_type":"text/x-python","patch_set":25,"id":"da20952f_05dbd522","line":1690,"in_reply_to":"da20952f_413faf86","updated":"2015-09-08 13:27:08.000000000","message":"usually both processes are restarted at the same time if you use init.d anyway you have a good point. I modified the code to force the restart of the polling manager if ovs restarted","commit_id":"02c9f7100bd8a1f8319b7b25436fac073d059e5b"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"3c1d14b0bbd4a22a23068e65372fadb361954673","unresolved":false,"context_lines":[{"line_number":1687,"context_line":"                    LOG.exception(_LE(\"Error while synchronizing tunnels\"))"},{"line_number":1688,"context_line":"                    tunnel_sync \u003d True"},{"line_number":1689,"context_line":"            ovs_restarted |\u003d (ovs_status \u003d\u003d constants.OVS_RESTARTED)"},{"line_number":1690,"context_line":"            if self._agent_has_updates(polling_manager) or sync:"},{"line_number":1691,"context_line":"                try:"},{"line_number":1692,"context_line":"                    LOG.debug(\"Agent rpc_loop - iteration:%(iter_num)d - \""},{"line_number":1693,"context_line":"                              \"starting polling. Elapsed:%(elapsed).3f\","}],"source_content_type":"text/x-python","patch_set":25,"id":"da20952f_1615bfe3","line":1690,"in_reply_to":"da20952f_de78d1c6","updated":"2015-09-04 09:56:19.000000000","message":"yes because if OVS restarts ovsdb-client monitor exits and will be respawned since OvsdbMonitor inherits from AsyncProcess. When it starts ovsdb-client monitor has always updates since it processes all the ports on the bridge. So there\u0027s a guarantee that _agent_has_updates is true when OVS has restarted","commit_id":"02c9f7100bd8a1f8319b7b25436fac073d059e5b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"7179dba2a572bb25b60e2deba187efa5a8adf110","unresolved":false,"context_lines":[{"line_number":1773,"context_line":"                        sync \u003d False"},{"line_number":1774,"context_line":"                    else:"},{"line_number":1775,"context_line":"                        consecutive_resyncs \u003d 0"},{"line_number":1776,"context_line":"                        events \u003d polling_manager.get_events()"},{"line_number":1777,"context_line":"                        ancillary_ports \u003d ("},{"line_number":1778,"context_line":"                            ancillary_ports if self.ancillary_brs else None)"},{"line_number":1779,"context_line":"                        port_info, ancillary_port_info \u003d ("}],"source_content_type":"text/x-python","patch_set":28,"id":"da20952f_4708ecd9","line":1776,"updated":"2015-09-08 14:54:59.000000000","message":"windows impl doesn\u0027t seem to have get_events.","commit_id":"a9863cef854ac2cec5b909c75528a347f028c686"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ecadc07026e670a68a8aed1fc7f5c94aabc413bf","unresolved":false,"context_lines":[{"line_number":1773,"context_line":"                        sync \u003d False"},{"line_number":1774,"context_line":"                    else:"},{"line_number":1775,"context_line":"                        consecutive_resyncs \u003d 0"},{"line_number":1776,"context_line":"                        events \u003d polling_manager.get_events()"},{"line_number":1777,"context_line":"                        ancillary_ports \u003d ("},{"line_number":1778,"context_line":"                            ancillary_ports if self.ancillary_brs else None)"},{"line_number":1779,"context_line":"                        port_info, ancillary_port_info \u003d ("}],"source_content_type":"text/x-python","patch_set":28,"id":"da20952f_b77236af","line":1776,"in_reply_to":"da20952f_4708ecd9","updated":"2015-09-09 10:29:30.000000000","message":"good point. Well I forgot about the windows implementation, tbh I am not even sure ovs+windows is fully supported. I will ask around. To keep this change windows compatible it would make the code uglier and it won\u0027t be possible to remove the cache of registered ports. That sucks...","commit_id":"a9863cef854ac2cec5b909c75528a347f028c686"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"11e09f6652b16c8941b2c4a82835c668c3660673","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"                iface_id \u003d self.int_br.portid_from_external_ids("},{"line_number":1196,"context_line":"                    device[\u0027external_ids\u0027])"},{"line_number":1197,"context_line":"                if iface_id:"},{"line_number":1198,"context_line":"                    if device[\u0027ofport\u0027] \u003d\u003d ovs_lib.UNASSIGNED_OFPORT:"},{"line_number":1199,"context_line":"                        #TODO(rossella_s) it\u0027s extreme to trigger a full resync"},{"line_number":1200,"context_line":"                        # if a port is not ready, resync only the device that"},{"line_number":1201,"context_line":"                        # is not ready"}],"source_content_type":"text/x-python","patch_set":30,"id":"da20952f_3f90064e","line":1198,"updated":"2015-09-10 15:37:21.000000000","message":"how about INVALID_OFPORT?","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"17be922716c5939e3400ecfb8a371003d1d13ae4","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"                iface_id \u003d self.int_br.portid_from_external_ids("},{"line_number":1196,"context_line":"                    device[\u0027external_ids\u0027])"},{"line_number":1197,"context_line":"                if iface_id:"},{"line_number":1198,"context_line":"                    if device[\u0027ofport\u0027] \u003d\u003d ovs_lib.UNASSIGNED_OFPORT:"},{"line_number":1199,"context_line":"                        #TODO(rossella_s) it\u0027s extreme to trigger a full resync"},{"line_number":1200,"context_line":"                        # if a port is not ready, resync only the device that"},{"line_number":1201,"context_line":"                        # is not ready"}],"source_content_type":"text/x-python","patch_set":30,"id":"da20952f_7a10a700","line":1198,"in_reply_to":"da20952f_3f90064e","updated":"2015-09-11 09:31:46.000000000","message":"INVALID_OFPORT is handled later in get_vifs_by_ids called in treat_devices_added_or_updated . I agree that it\u0027s ugly to do the check in 2 different places but here are the reasons:\n\n1. Can\u0027t move the check away from get_vifs_by_ids because it\u0027s used by the code path that doesn\u0027t use InterfacePollingMinimizer\n2. I had to put this check here because ovsdb monitor notifies about port addition even if the port is not ready (UNASSIGNED_OFPORT) . The problem is that it won\u0027t notify the addition of this port again so I had to track them here.\n\nI agree the this agent code needs some refactor. I hope to do that in Mitaka","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"11e09f6652b16c8941b2c4a82835c668c3660673","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"                                  \u0027name\u0027])"},{"line_number":1205,"context_line":"                    # check if device belong to ancillary bridge"},{"line_number":1206,"context_line":"                    if device[\u0027name\u0027].startswith("},{"line_number":1207,"context_line":"                        l3_agent.EXTERNAL_DEV_PREFIX):"},{"line_number":1208,"context_line":"                        ancillary_devices.add(iface_id)"},{"line_number":1209,"context_line":"                    else:"},{"line_number":1210,"context_line":"                        devices.add(iface_id)"}],"source_content_type":"text/x-python","patch_set":30,"id":"da20952f_fffdaeb1","line":1207,"updated":"2015-09-10 15:37:21.000000000","message":"does this work in case ovs_use_veth\u003dTrue?\n\nwhy don\u0027t you look at the bridge which the port belongs to?","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"91f6fc8982b73efb21dd48bf86bac3e4d82263e8","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"                                  \u0027name\u0027])"},{"line_number":1205,"context_line":"                    # check if device belong to ancillary bridge"},{"line_number":1206,"context_line":"                    if device[\u0027name\u0027].startswith("},{"line_number":1207,"context_line":"                        l3_agent.EXTERNAL_DEV_PREFIX):"},{"line_number":1208,"context_line":"                        ancillary_devices.add(iface_id)"},{"line_number":1209,"context_line":"                    else:"},{"line_number":1210,"context_line":"                        devices.add(iface_id)"}],"source_content_type":"text/x-python","patch_set":30,"id":"9a1a9d01_f832690f","line":1207,"in_reply_to":"da20952f_20b0be42","updated":"2015-09-29 16:09:26.000000000","message":"I fixed this scanning for ports on the ancillary bridges. It\u0027s a temporary solution that will do until https://review.openstack.org/#/c/203381 gets merged","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"17be922716c5939e3400ecfb8a371003d1d13ae4","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"                                  \u0027name\u0027])"},{"line_number":1205,"context_line":"                    # check if device belong to ancillary bridge"},{"line_number":1206,"context_line":"                    if device[\u0027name\u0027].startswith("},{"line_number":1207,"context_line":"                        l3_agent.EXTERNAL_DEV_PREFIX):"},{"line_number":1208,"context_line":"                        ancillary_devices.add(iface_id)"},{"line_number":1209,"context_line":"                    else:"},{"line_number":1210,"context_line":"                        devices.add(iface_id)"}],"source_content_type":"text/x-python","patch_set":30,"id":"da20952f_20b0be42","line":1207,"in_reply_to":"da20952f_fffdaeb1","updated":"2015-09-11 09:31:46.000000000","message":"because to know to which bridge the port belongs I have to issue a call . In the events it\u0027s not reported to which bridge the port belongs.","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1fbd7ce39f9b64e9b392718fbe2c1fd78aa3bd64","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"                       consecutive_resyncs):"},{"line_number":1685,"context_line":"        # There are polling managers that don\u0027t have get_events, e.g."},{"line_number":1686,"context_line":"        # AlwaysPoll used by windows implementations"},{"line_number":1687,"context_line":"        if sync or not (hasattr(polling_manager, \u0027get_events\u0027)):"},{"line_number":1688,"context_line":"            if sync:"},{"line_number":1689,"context_line":"                LOG.info(_LI(\"Agent out of sync with plugin!\"))"},{"line_number":1690,"context_line":"                consecutive_resyncs \u003d consecutive_resyncs + 1"}],"source_content_type":"text/x-python","patch_set":30,"id":"da20952f_154f3e6b","line":1687,"updated":"2015-09-09 21:10:45.000000000","message":"imo, process_port_info implementation should be reworked in order to hide \"polling\" related details in BasePollingManager subclasses. It implies a large rework that we could address during Mitaka (so out of change scope!)","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c6c76108aaef093c1d5b8a7ac57f357d41f9df50","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"                       consecutive_resyncs):"},{"line_number":1685,"context_line":"        # There are polling managers that don\u0027t have get_events, e.g."},{"line_number":1686,"context_line":"        # AlwaysPoll used by windows implementations"},{"line_number":1687,"context_line":"        if sync or not (hasattr(polling_manager, \u0027get_events\u0027)):"},{"line_number":1688,"context_line":"            if sync:"},{"line_number":1689,"context_line":"                LOG.info(_LI(\"Agent out of sync with plugin!\"))"},{"line_number":1690,"context_line":"                consecutive_resyncs \u003d consecutive_resyncs + 1"}],"source_content_type":"text/x-python","patch_set":30,"id":"da20952f_e32e8241","line":1687,"in_reply_to":"da20952f_154f3e6b","updated":"2015-09-10 08:38:53.000000000","message":"I totally agree with you. Let\u0027s to that in Mitaka","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"91f6fc8982b73efb21dd48bf86bac3e4d82263e8","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"                       consecutive_resyncs):"},{"line_number":1685,"context_line":"        # There are polling managers that don\u0027t have get_events, e.g."},{"line_number":1686,"context_line":"        # AlwaysPoll used by windows implementations"},{"line_number":1687,"context_line":"        if sync or not (hasattr(polling_manager, \u0027get_events\u0027)):"},{"line_number":1688,"context_line":"            if sync:"},{"line_number":1689,"context_line":"                LOG.info(_LI(\"Agent out of sync with plugin!\"))"},{"line_number":1690,"context_line":"                consecutive_resyncs \u003d consecutive_resyncs + 1"}],"source_content_type":"text/x-python","patch_set":30,"id":"9a1a9d01_98880dc7","line":1687,"in_reply_to":"da20952f_e32e8241","updated":"2015-09-29 16:09:26.000000000","message":"I will do that in another patch, later.","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"f9d50e8416d13b6b996e1ef1f6abfb235ce4d249","unresolved":false,"context_lines":[{"line_number":1692,"context_line":"                        constants.MAX_DEVICE_RETRIES):"},{"line_number":1693,"context_line":"                    LOG.warn(_LW("},{"line_number":1694,"context_line":"                        \"Clearing cache of registered ports,\""},{"line_number":1695,"context_line":"                        \" retrials to resync were \u003e %s\"),"},{"line_number":1696,"context_line":"                             constants.MAX_DEVICE_RETRIES)"},{"line_number":1697,"context_line":"                    ports.clear()"},{"line_number":1698,"context_line":"                    ancillary_ports.clear()"}],"source_content_type":"text/x-python","patch_set":30,"id":"da20952f_5d1b8f1c","line":1695,"updated":"2015-09-10 07:46:08.000000000","message":"s/retrials/retries","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"39a555d89c67c106e63c77e3eaadffc6421d5067","unresolved":false,"context_lines":[{"line_number":1692,"context_line":"                        constants.MAX_DEVICE_RETRIES):"},{"line_number":1693,"context_line":"                    LOG.warn(_LW("},{"line_number":1694,"context_line":"                        \"Clearing cache of registered ports,\""},{"line_number":1695,"context_line":"                        \" retrials to resync were \u003e %s\"),"},{"line_number":1696,"context_line":"                             constants.MAX_DEVICE_RETRIES)"},{"line_number":1697,"context_line":"                    ports.clear()"},{"line_number":1698,"context_line":"                    ancillary_ports.clear()"}],"source_content_type":"text/x-python","patch_set":30,"id":"da20952f_c3bb3e74","line":1695,"in_reply_to":"da20952f_5d1b8f1c","updated":"2015-09-10 08:48:22.000000000","message":"Let\u0027s do that in Mitaka :)","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"91f6fc8982b73efb21dd48bf86bac3e4d82263e8","unresolved":false,"context_lines":[{"line_number":1692,"context_line":"                        constants.MAX_DEVICE_RETRIES):"},{"line_number":1693,"context_line":"                    LOG.warn(_LW("},{"line_number":1694,"context_line":"                        \"Clearing cache of registered ports,\""},{"line_number":1695,"context_line":"                        \" retrials to resync were \u003e %s\"),"},{"line_number":1696,"context_line":"                             constants.MAX_DEVICE_RETRIES)"},{"line_number":1697,"context_line":"                    ports.clear()"},{"line_number":1698,"context_line":"                    ancillary_ports.clear()"}],"source_content_type":"text/x-python","patch_set":30,"id":"9a1a9d01_d8a1a547","line":1695,"in_reply_to":"da20952f_c3bb3e74","updated":"2015-09-29 16:09:26.000000000","message":"Done","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1fbd7ce39f9b64e9b392718fbe2c1fd78aa3bd64","unresolved":false,"context_lines":[{"line_number":1766,"context_line":"                # all the current ports"},{"line_number":1767,"context_line":"                if isinstance("},{"line_number":1768,"context_line":"                    polling_manager, linux_polling.InterfacePollingMinimizer):"},{"line_number":1769,"context_line":"                    polling_manager.stop()"},{"line_number":1770,"context_line":"                    polling_manager.start()"},{"line_number":1771,"context_line":"            elif ovs_status \u003d\u003d constants.OVS_DEAD:"},{"line_number":1772,"context_line":"                # Agent doesn\u0027t apply any operations when ovs is dead, to"}],"source_content_type":"text/x-python","patch_set":30,"id":"da20952f_d23c7ce3","line":1769,"updated":"2015-09-09 21:10:45.000000000","message":"I would prefer to hide this in BasePollingManager subclasses by defining a an abstract \"reset\" (not sure it\u0027s the right name) method which:\n\n* stop/start the async process in InterfacePollingMinimizer\n* pass in AlwaysPoll because it\u0027s stateless","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"39a555d89c67c106e63c77e3eaadffc6421d5067","unresolved":false,"context_lines":[{"line_number":1766,"context_line":"                # all the current ports"},{"line_number":1767,"context_line":"                if isinstance("},{"line_number":1768,"context_line":"                    polling_manager, linux_polling.InterfacePollingMinimizer):"},{"line_number":1769,"context_line":"                    polling_manager.stop()"},{"line_number":1770,"context_line":"                    polling_manager.start()"},{"line_number":1771,"context_line":"            elif ovs_status \u003d\u003d constants.OVS_DEAD:"},{"line_number":1772,"context_line":"                # Agent doesn\u0027t apply any operations when ovs is dead, to"}],"source_content_type":"text/x-python","patch_set":30,"id":"da20952f_2349dab7","line":1769,"in_reply_to":"da20952f_03c85673","updated":"2015-09-10 08:48:22.000000000","message":"Ok","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c6c76108aaef093c1d5b8a7ac57f357d41f9df50","unresolved":false,"context_lines":[{"line_number":1766,"context_line":"                # all the current ports"},{"line_number":1767,"context_line":"                if isinstance("},{"line_number":1768,"context_line":"                    polling_manager, linux_polling.InterfacePollingMinimizer):"},{"line_number":1769,"context_line":"                    polling_manager.stop()"},{"line_number":1770,"context_line":"                    polling_manager.start()"},{"line_number":1771,"context_line":"            elif ovs_status \u003d\u003d constants.OVS_DEAD:"},{"line_number":1772,"context_line":"                # Agent doesn\u0027t apply any operations when ovs is dead, to"}],"source_content_type":"text/x-python","patch_set":30,"id":"da20952f_03c85673","line":1769,"in_reply_to":"da20952f_d23c7ce3","updated":"2015-09-10 08:38:53.000000000","message":"I would prefer that too but I wanted to avoid to create another patch just to refactor, it\u0027s getting late already. Let\u0027s do that in Mitaka.","commit_id":"fc6f42e549bd407eb3289d90e86b65884b4866d1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1dc6421e2118442c1c5b839fa525517292e2ccb1","unresolved":false,"context_lines":[{"line_number":1237,"context_line":"                        raise Exception("},{"line_number":1238,"context_line":"                            _(\"Port %s is not ready, resync needed\") % device["},{"line_number":1239,"context_line":"                                  \u0027name\u0027])"},{"line_number":1240,"context_line":"                    # check if device belong to ancillary bridge"},{"line_number":1241,"context_line":"                    if iface_id in cur_ancillary_ports:"},{"line_number":1242,"context_line":"                        ancillary_devices.add(iface_id)"},{"line_number":1243,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":31,"id":"7a2fa921_fb7b6326","line":1240,"updated":"2015-10-08 04:52:14.000000000","message":"i guess this check doesn\u0027t work as intended for \"removed\" events.","commit_id":"ee03fd33d6471ab285628e23a1ef4f99dda2cad7"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"752551497bba9d241f87f978958428151fd29ce9","unresolved":false,"context_lines":[{"line_number":1237,"context_line":"                        raise Exception("},{"line_number":1238,"context_line":"                            _(\"Port %s is not ready, resync needed\") % device["},{"line_number":1239,"context_line":"                                  \u0027name\u0027])"},{"line_number":1240,"context_line":"                    # check if device belong to ancillary bridge"},{"line_number":1241,"context_line":"                    if iface_id in cur_ancillary_ports:"},{"line_number":1242,"context_line":"                        ancillary_devices.add(iface_id)"},{"line_number":1243,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":31,"id":"7a2fa921_f3836e54","line":1240,"in_reply_to":"7a2fa921_ad091586","updated":"2015-10-08 15:03:26.000000000","message":"it seems you\u0027re right.  thank you for explanation.","commit_id":"ee03fd33d6471ab285628e23a1ef4f99dda2cad7"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"8b22ae55379a38628f402d2407d7cd578e7216fb","unresolved":false,"context_lines":[{"line_number":1237,"context_line":"                        raise Exception("},{"line_number":1238,"context_line":"                            _(\"Port %s is not ready, resync needed\") % device["},{"line_number":1239,"context_line":"                                  \u0027name\u0027])"},{"line_number":1240,"context_line":"                    # check if device belong to ancillary bridge"},{"line_number":1241,"context_line":"                    if iface_id in cur_ancillary_ports:"},{"line_number":1242,"context_line":"                        ancillary_devices.add(iface_id)"},{"line_number":1243,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":31,"id":"7a2fa921_ad091586","line":1240,"in_reply_to":"7a2fa921_fb7b6326","updated":"2015-10-08 14:52:46.000000000","message":"yes it does, if you look at line 1224 cur_ancillary_ports contains also the ports that were processed by the agent and then removed,  since ancillary_port_info[\u0027current\u0027] will be updated only at after line 1262","commit_id":"ee03fd33d6471ab285628e23a1ef4f99dda2cad7"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1dc6421e2118442c1c5b839fa525517292e2ccb1","unresolved":false,"context_lines":[{"line_number":1718,"context_line":"                       consecutive_resyncs):"},{"line_number":1719,"context_line":"        # There are polling managers that don\u0027t have get_events, e.g."},{"line_number":1720,"context_line":"        # AlwaysPoll used by windows implementations"},{"line_number":1721,"context_line":"        if sync or not (hasattr(polling_manager, \u0027get_events\u0027)):"},{"line_number":1722,"context_line":"            if sync:"},{"line_number":1723,"context_line":"                LOG.info(_LI(\"Agent out of sync with plugin!\"))"},{"line_number":1724,"context_line":"                consecutive_resyncs \u003d consecutive_resyncs + 1"}],"source_content_type":"text/x-python","patch_set":31,"id":"7a2fa921_dbfb07c0","line":1721,"updated":"2015-10-08 04:52:14.000000000","message":"as now we are targetting mitaka,\nhow about introducing cleaner abstraction?","commit_id":"ee03fd33d6471ab285628e23a1ef4f99dda2cad7"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"752551497bba9d241f87f978958428151fd29ce9","unresolved":false,"context_lines":[{"line_number":1718,"context_line":"                       consecutive_resyncs):"},{"line_number":1719,"context_line":"        # There are polling managers that don\u0027t have get_events, e.g."},{"line_number":1720,"context_line":"        # AlwaysPoll used by windows implementations"},{"line_number":1721,"context_line":"        if sync or not (hasattr(polling_manager, \u0027get_events\u0027)):"},{"line_number":1722,"context_line":"            if sync:"},{"line_number":1723,"context_line":"                LOG.info(_LI(\"Agent out of sync with plugin!\"))"},{"line_number":1724,"context_line":"                consecutive_resyncs \u003d consecutive_resyncs + 1"}],"source_content_type":"text/x-python","patch_set":31,"id":"7a2fa921_3091dcf1","line":1721,"in_reply_to":"7a2fa921_0d67e94d","updated":"2015-10-08 15:03:26.000000000","message":"i thought the only reason you did this way was the deadline was reaching, didn\u0027t you?","commit_id":"ee03fd33d6471ab285628e23a1ef4f99dda2cad7"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ef15139d9d11c3d5a33d8437933ffd7ef937e8b4","unresolved":false,"context_lines":[{"line_number":1718,"context_line":"                       consecutive_resyncs):"},{"line_number":1719,"context_line":"        # There are polling managers that don\u0027t have get_events, e.g."},{"line_number":1720,"context_line":"        # AlwaysPoll used by windows implementations"},{"line_number":1721,"context_line":"        if sync or not (hasattr(polling_manager, \u0027get_events\u0027)):"},{"line_number":1722,"context_line":"            if sync:"},{"line_number":1723,"context_line":"                LOG.info(_LI(\"Agent out of sync with plugin!\"))"},{"line_number":1724,"context_line":"                consecutive_resyncs \u003d consecutive_resyncs + 1"}],"source_content_type":"text/x-python","patch_set":31,"id":"7a2fa921_fe9c95c1","line":1721,"in_reply_to":"7a2fa921_3091dcf1","updated":"2015-10-08 15:19:42.000000000","message":"That was the reason why I wrote this horrible line. The reason still stands, if I create another patch to abstract the polling manager better, I am sure this one will take longer to merge and it\u0027s really time consuming to maintain this patch :/ I can add a TODO if you are OK and I promise to address it...I just don\u0027t want to see this patch blocked again. What do you think?","commit_id":"ee03fd33d6471ab285628e23a1ef4f99dda2cad7"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"8b22ae55379a38628f402d2407d7cd578e7216fb","unresolved":false,"context_lines":[{"line_number":1718,"context_line":"                       consecutive_resyncs):"},{"line_number":1719,"context_line":"        # There are polling managers that don\u0027t have get_events, e.g."},{"line_number":1720,"context_line":"        # AlwaysPoll used by windows implementations"},{"line_number":1721,"context_line":"        if sync or not (hasattr(polling_manager, \u0027get_events\u0027)):"},{"line_number":1722,"context_line":"            if sync:"},{"line_number":1723,"context_line":"                LOG.info(_LI(\"Agent out of sync with plugin!\"))"},{"line_number":1724,"context_line":"                consecutive_resyncs \u003d consecutive_resyncs + 1"}],"source_content_type":"text/x-python","patch_set":31,"id":"7a2fa921_0d67e94d","line":1721,"in_reply_to":"7a2fa921_dbfb07c0","updated":"2015-10-08 14:52:46.000000000","message":"I agree but please in a follow up patch, these patches have been hanging around for months, I\u0027d like to get those in, then we can move on and refactor.","commit_id":"ee03fd33d6471ab285628e23a1ef4f99dda2cad7"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2fc8eb0142072469c857f5d443f2490dc4ce46c7","unresolved":false,"context_lines":[{"line_number":1703,"context_line":"                       consecutive_resyncs):"},{"line_number":1704,"context_line":"        # There are polling managers that don\u0027t have get_events, e.g."},{"line_number":1705,"context_line":"        # AlwaysPoll used by windows implementations"},{"line_number":1706,"context_line":"        if sync or not (hasattr(polling_manager, \u0027get_events\u0027)):"},{"line_number":1707,"context_line":"            if sync:"},{"line_number":1708,"context_line":"                LOG.info(_LI(\"Agent out of sync with plugin!\"))"},{"line_number":1709,"context_line":"                consecutive_resyncs \u003d consecutive_resyncs + 1"}],"source_content_type":"text/x-python","patch_set":32,"id":"7a2fa921_1ef8d87b","line":1706,"updated":"2015-10-13 08:54:30.000000000","message":"can you put REVISIT comment for clean up?","commit_id":"ee1a3b905e30f4041993ba3c81f2a8d484d12027"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"74a8a3a313f8fbce27ec67aabec8c83925532ad6","unresolved":false,"context_lines":[{"line_number":1703,"context_line":"                       consecutive_resyncs):"},{"line_number":1704,"context_line":"        # There are polling managers that don\u0027t have get_events, e.g."},{"line_number":1705,"context_line":"        # AlwaysPoll used by windows implementations"},{"line_number":1706,"context_line":"        if sync or not (hasattr(polling_manager, \u0027get_events\u0027)):"},{"line_number":1707,"context_line":"            if sync:"},{"line_number":1708,"context_line":"                LOG.info(_LI(\"Agent out of sync with plugin!\"))"},{"line_number":1709,"context_line":"                consecutive_resyncs \u003d consecutive_resyncs + 1"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a2ca52d_973b51d1","line":1706,"in_reply_to":"7a2fa921_1ef8d87b","updated":"2015-10-14 21:41:40.000000000","message":"Done","commit_id":"ee1a3b905e30f4041993ba3c81f2a8d484d12027"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2fc8eb0142072469c857f5d443f2490dc4ce46c7","unresolved":false,"context_lines":[{"line_number":1786,"context_line":"                if isinstance("},{"line_number":1787,"context_line":"                    polling_manager, linux_polling.InterfacePollingMinimizer):"},{"line_number":1788,"context_line":"                    polling_manager.stop()"},{"line_number":1789,"context_line":"                    polling_manager.start()"},{"line_number":1790,"context_line":"            elif ovs_status \u003d\u003d constants.OVS_DEAD:"},{"line_number":1791,"context_line":"                # Agent doesn\u0027t apply any operations when ovs is dead, to"},{"line_number":1792,"context_line":"                # prevent unexpected failure or crash. Sleep and continue"}],"source_content_type":"text/x-python","patch_set":32,"id":"7a2fa921_3ef59482","line":1789,"updated":"2015-10-13 08:54:30.000000000","message":"can you put REVISIT comment for clean up?","commit_id":"ee1a3b905e30f4041993ba3c81f2a8d484d12027"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"74a8a3a313f8fbce27ec67aabec8c83925532ad6","unresolved":false,"context_lines":[{"line_number":1786,"context_line":"                if isinstance("},{"line_number":1787,"context_line":"                    polling_manager, linux_polling.InterfacePollingMinimizer):"},{"line_number":1788,"context_line":"                    polling_manager.stop()"},{"line_number":1789,"context_line":"                    polling_manager.start()"},{"line_number":1790,"context_line":"            elif ovs_status \u003d\u003d constants.OVS_DEAD:"},{"line_number":1791,"context_line":"                # Agent doesn\u0027t apply any operations when ovs is dead, to"},{"line_number":1792,"context_line":"                # prevent unexpected failure or crash. Sleep and continue"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a2ca52d_b7368de5","line":1789,"in_reply_to":"7a2fa921_3ef59482","updated":"2015-10-14 21:41:40.000000000","message":"Done","commit_id":"ee1a3b905e30f4041993ba3c81f2a8d484d12027"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4d6e639653963a2cd17be7e198b67c19ab4858e4","unresolved":false,"context_lines":[{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"        # if a port was added and then removed or viceversa since the agent"},{"line_number":1192,"context_line":"        # can\u0027t know the order of the operations, check the status of the port"},{"line_number":1193,"context_line":"        # to determine if the port was added or deleted"},{"line_number":1194,"context_line":"        device_removed_or_added \u003d ["},{"line_number":1195,"context_line":"            dev for dev in events[\u0027added\u0027] if dev in events[\u0027removed\u0027]]"},{"line_number":1196,"context_line":"        for device in device_removed_or_added:"}],"source_content_type":"text/x-python","patch_set":33,"id":"5a2ca52d_a18a8319","line":1193,"updated":"2015-10-16 05:45:18.000000000","message":"does this imply some api issues?","commit_id":"57a3bf228cf6052173089e8b0462d82e3241f806"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"88c3504fb5200e724d22d513ab9510e41229e894","unresolved":false,"context_lines":[{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"        # if a port was added and then removed or viceversa since the agent"},{"line_number":1192,"context_line":"        # can\u0027t know the order of the operations, check the status of the port"},{"line_number":1193,"context_line":"        # to determine if the port was added or deleted"},{"line_number":1194,"context_line":"        device_removed_or_added \u003d ["},{"line_number":1195,"context_line":"            dev for dev in events[\u0027added\u0027] if dev in events[\u0027removed\u0027]]"},{"line_number":1196,"context_line":"        for device in device_removed_or_added:"}],"source_content_type":"text/x-python","patch_set":33,"id":"3a29b11f_b91fdeb5","line":1193,"in_reply_to":"5a2ca52d_a18a8319","updated":"2015-10-22 15:55:46.000000000","message":"not really. Well it could be improvement to get the events in the time order they happen but it doesn\u0027t work that way atm","commit_id":"57a3bf228cf6052173089e8b0462d82e3241f806"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4dce8774e2d5cd0b3200939584edba862f281d5f","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"        ancillary_port_info[\u0027added\u0027] \u003d set()"},{"line_number":1225,"context_line":"        ancillary_port_info[\u0027removed\u0027] \u003d set()"},{"line_number":1226,"context_line":"        ancillary_port_info[\u0027current\u0027] \u003d ("},{"line_number":1227,"context_line":"            ancillary_ports if ancillary_ports else set())"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"        # if a port was added and then removed or viceversa since the agent"},{"line_number":1230,"context_line":"        # can\u0027t know the order of the operations, check the status of the port"}],"source_content_type":"text/x-python","patch_set":34,"id":"da85f559_6c52b215","line":1227,"updated":"2015-11-09 10:54:25.000000000","message":"is this conditional necessary?","commit_id":"1992d52d63dc32c63faa5a3f482d5b8ebe925a77"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"fe4ece2de48fc14268bc94aac87831260ebf05d4","unresolved":false,"context_lines":[{"line_number":1224,"context_line":"        ancillary_port_info[\u0027added\u0027] \u003d set()"},{"line_number":1225,"context_line":"        ancillary_port_info[\u0027removed\u0027] \u003d set()"},{"line_number":1226,"context_line":"        ancillary_port_info[\u0027current\u0027] \u003d ("},{"line_number":1227,"context_line":"            ancillary_ports if ancillary_ports else set())"},{"line_number":1228,"context_line":""},{"line_number":1229,"context_line":"        # if a port was added and then removed or viceversa since the agent"},{"line_number":1230,"context_line":"        # can\u0027t know the order of the operations, check the status of the port"}],"source_content_type":"text/x-python","patch_set":34,"id":"da85f559_e0ca234f","line":1227,"in_reply_to":"da85f559_6c52b215","updated":"2015-11-09 13:28:18.000000000","message":"Done","commit_id":"1992d52d63dc32c63faa5a3f482d5b8ebe925a77"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4dce8774e2d5cd0b3200939584edba862f281d5f","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"        # if a port was added and then removed or viceversa since the agent"},{"line_number":1230,"context_line":"        # can\u0027t know the order of the operations, check the status of the port"},{"line_number":1231,"context_line":"        # to determine if the port was added or deleted"},{"line_number":1232,"context_line":"        device_removed_or_added \u003d ["},{"line_number":1233,"context_line":"            dev for dev in events[\u0027added\u0027] if dev in events[\u0027removed\u0027]]"},{"line_number":1234,"context_line":"        for device in device_removed_or_added:"},{"line_number":1235,"context_line":"            if ovs_lib.BaseOVS().port_exists(device[\u0027name\u0027]):"}],"source_content_type":"text/x-python","patch_set":34,"id":"da85f559_b9f9be4f","line":1232,"range":{"start_line":1232,"start_character":8,"end_line":1232,"end_character":31},"updated":"2015-11-09 10:54:25.000000000","message":"device_removed_and_added?","commit_id":"1992d52d63dc32c63faa5a3f482d5b8ebe925a77"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"fe4ece2de48fc14268bc94aac87831260ebf05d4","unresolved":false,"context_lines":[{"line_number":1229,"context_line":"        # if a port was added and then removed or viceversa since the agent"},{"line_number":1230,"context_line":"        # can\u0027t know the order of the operations, check the status of the port"},{"line_number":1231,"context_line":"        # to determine if the port was added or deleted"},{"line_number":1232,"context_line":"        device_removed_or_added \u003d ["},{"line_number":1233,"context_line":"            dev for dev in events[\u0027added\u0027] if dev in events[\u0027removed\u0027]]"},{"line_number":1234,"context_line":"        for device in device_removed_or_added:"},{"line_number":1235,"context_line":"            if ovs_lib.BaseOVS().port_exists(device[\u0027name\u0027]):"}],"source_content_type":"text/x-python","patch_set":34,"id":"da85f559_a1873c0e","line":1232,"in_reply_to":"da85f559_b9f9be4f","updated":"2015-11-09 13:28:18.000000000","message":"Done","commit_id":"1992d52d63dc32c63faa5a3f482d5b8ebe925a77"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"48adc1271086403a463b81d10616c0f7e96cfcbc","unresolved":false,"context_lines":[{"line_number":1257,"context_line":"                        #TODO(rossella_s) it\u0027s extreme to trigger a full resync"},{"line_number":1258,"context_line":"                        # if a port is not ready, resync only the device that"},{"line_number":1259,"context_line":"                        # is not ready"},{"line_number":1260,"context_line":"                        raise Exception("},{"line_number":1261,"context_line":"                            _(\"Port %s is not ready, resync needed\") % device["},{"line_number":1262,"context_line":"                                  \u0027name\u0027])"},{"line_number":1263,"context_line":"                    # check if device belong to ancillary bridge"}],"source_content_type":"text/x-python","patch_set":34,"id":"da85f559_e4b18448","line":1260,"updated":"2015-11-10 18:08:57.000000000","message":"This is spamming the agent logs now, see bug 1514935.\n\nAlso, when you raise an exception here, it\u0027s not handled by the event looping that\u0027s processing the devices below so you\u0027re skipping everything else.","commit_id":"1992d52d63dc32c63faa5a3f482d5b8ebe925a77"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"e6e6bbca0b9f16a0db3db4617933f561f0fa8c11","unresolved":false,"context_lines":[{"line_number":1257,"context_line":"                        #TODO(rossella_s) it\u0027s extreme to trigger a full resync"},{"line_number":1258,"context_line":"                        # if a port is not ready, resync only the device that"},{"line_number":1259,"context_line":"                        # is not ready"},{"line_number":1260,"context_line":"                        raise Exception("},{"line_number":1261,"context_line":"                            _(\"Port %s is not ready, resync needed\") % device["},{"line_number":1262,"context_line":"                                  \u0027name\u0027])"},{"line_number":1263,"context_line":"                    # check if device belong to ancillary bridge"}],"source_content_type":"text/x-python","patch_set":34,"id":"da85f559_1d7de0b0","line":1260,"in_reply_to":"da85f559_445bb0f6","updated":"2015-11-11 10:37:40.000000000","message":"Because I was trying to have small re viewable patch. It was a bad idea, agreed.","commit_id":"1992d52d63dc32c63faa5a3f482d5b8ebe925a77"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dd08aa7cee9c699f01549a3d68bc7da293112d49","unresolved":false,"context_lines":[{"line_number":1257,"context_line":"                        #TODO(rossella_s) it\u0027s extreme to trigger a full resync"},{"line_number":1258,"context_line":"                        # if a port is not ready, resync only the device that"},{"line_number":1259,"context_line":"                        # is not ready"},{"line_number":1260,"context_line":"                        raise Exception("},{"line_number":1261,"context_line":"                            _(\"Port %s is not ready, resync needed\") % device["},{"line_number":1262,"context_line":"                                  \u0027name\u0027])"},{"line_number":1263,"context_line":"                    # check if device belong to ancillary bridge"}],"source_content_type":"text/x-python","patch_set":34,"id":"da85f559_445bb0f6","line":1260,"in_reply_to":"da85f559_e4b18448","updated":"2015-11-10 18:12:00.000000000","message":"Looks like there is a change after this one that\u0027s attempting to fix this:\n\nhttps://review.openstack.org/#/c/202098/29/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py\n\nWhy wasn\u0027t this just all done in the same change?","commit_id":"1992d52d63dc32c63faa5a3f482d5b8ebe925a77"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4dce8774e2d5cd0b3200939584edba862f281d5f","unresolved":false,"context_lines":[{"line_number":1785,"context_line":"            consecutive_resyncs \u003d 0"},{"line_number":1786,"context_line":"            events \u003d polling_manager.get_events()"},{"line_number":1787,"context_line":"            ancillary_ports \u003d ("},{"line_number":1788,"context_line":"                ancillary_ports if self.ancillary_brs else None)"},{"line_number":1789,"context_line":"            port_info, ancillary_port_info \u003d ("},{"line_number":1790,"context_line":"                self.process_ports_events(events, ports,"},{"line_number":1791,"context_line":"                                          ancillary_ports, updated_ports_copy))"}],"source_content_type":"text/x-python","patch_set":34,"id":"da85f559_19b6ca8a","line":1788,"range":{"start_line":1788,"start_character":59,"end_line":1788,"end_character":63},"updated":"2015-11-09 10:54:25.000000000","message":"is this conditional necessary?\n\nancillary_ports is always empty if not ancirllary_brs, isn\u0027t it?","commit_id":"1992d52d63dc32c63faa5a3f482d5b8ebe925a77"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"fe4ece2de48fc14268bc94aac87831260ebf05d4","unresolved":false,"context_lines":[{"line_number":1785,"context_line":"            consecutive_resyncs \u003d 0"},{"line_number":1786,"context_line":"            events \u003d polling_manager.get_events()"},{"line_number":1787,"context_line":"            ancillary_ports \u003d ("},{"line_number":1788,"context_line":"                ancillary_ports if self.ancillary_brs else None)"},{"line_number":1789,"context_line":"            port_info, ancillary_port_info \u003d ("},{"line_number":1790,"context_line":"                self.process_ports_events(events, ports,"},{"line_number":1791,"context_line":"                                          ancillary_ports, updated_ports_copy))"}],"source_content_type":"text/x-python","patch_set":34,"id":"da85f559_617ab426","line":1788,"in_reply_to":"da85f559_19b6ca8a","updated":"2015-11-09 13:28:18.000000000","message":"Done","commit_id":"1992d52d63dc32c63faa5a3f482d5b8ebe925a77"}],"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"e65e4e04f7ef744c7b3d4e6a7972873d3791d7fb","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"        for device in events[\u0027added\u0027]:"},{"line_number":1100,"context_line":"            _process_device(device, port_info[\u0027added\u0027])"},{"line_number":1101,"context_line":"        for device in events[\u0027removed\u0027]:"},{"line_number":1102,"context_line":"            _process_device(device, port_info[\u0027removed\u0027])"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"        if updated_ports is None:"},{"line_number":1105,"context_line":"            updated_ports \u003d set()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ab451fb_1199ec6e","line":1102,"updated":"2015-04-17 08:11:47.000000000","message":"as all tests are failing I would add some logging statements here.\nThe gut feeling is that either the events are empty (consumed somewhere else), or they\u0027re not being processed properly here","commit_id":"6c509a03f760ca476ffd62d9330fcead96bd7fca"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"d83a59e7d5dd6e4988764e2f2e5b1f582afdba25","unresolved":false,"context_lines":[{"line_number":1099,"context_line":"        for device in events[\u0027added\u0027]:"},{"line_number":1100,"context_line":"            _process_device(device, port_info[\u0027added\u0027])"},{"line_number":1101,"context_line":"        for device in events[\u0027removed\u0027]:"},{"line_number":1102,"context_line":"            _process_device(device, port_info[\u0027removed\u0027])"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"        if updated_ports is None:"},{"line_number":1105,"context_line":"            updated_ports \u003d set()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_370502c2","line":1102,"in_reply_to":"3ab451fb_1199ec6e","updated":"2015-04-29 00:10:36.000000000","message":"Thank for the suggestion, I think I found the reason.","commit_id":"6c509a03f760ca476ffd62d9330fcead96bd7fca"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"e65e4e04f7ef744c7b3d4e6a7972873d3791d7fb","unresolved":false,"context_lines":[{"line_number":1105,"context_line":"            updated_ports \u003d set()"},{"line_number":1106,"context_line":"        updated_ports.update(self.check_changed_vlans(registered_ports))"},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"        # Remove devices that the agent never noticed that were added"},{"line_number":1109,"context_line":"        port_info[\u0027removed\u0027] \u0026\u003d port_info[\u0027current\u0027]"},{"line_number":1110,"context_line":"        port_info[\u0027current\u0027] |\u003d port_info[\u0027added\u0027]"},{"line_number":1111,"context_line":"        port_info[\u0027current\u0027] -\u003d port_info[\u0027removed\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ab451fb_11ab2c8b","line":1108,"updated":"2015-04-17 08:11:47.000000000","message":"this comment is useful but misleading.\nI read as if you were going to \"remove devices that were never noticed by the agent\", where as you meant \"disregard devices that were never noticed by the agent\", I think","commit_id":"6c509a03f760ca476ffd62d9330fcead96bd7fca"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"d83a59e7d5dd6e4988764e2f2e5b1f582afdba25","unresolved":false,"context_lines":[{"line_number":1105,"context_line":"            updated_ports \u003d set()"},{"line_number":1106,"context_line":"        updated_ports.update(self.check_changed_vlans(registered_ports))"},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"        # Remove devices that the agent never noticed that were added"},{"line_number":1109,"context_line":"        port_info[\u0027removed\u0027] \u0026\u003d port_info[\u0027current\u0027]"},{"line_number":1110,"context_line":"        port_info[\u0027current\u0027] |\u003d port_info[\u0027added\u0027]"},{"line_number":1111,"context_line":"        port_info[\u0027current\u0027] -\u003d port_info[\u0027removed\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ad0253b_776c9a9c","line":1108,"in_reply_to":"3ab451fb_11ab2c8b","updated":"2015-04-29 00:10:36.000000000","message":"Thanks!","commit_id":"6c509a03f760ca476ffd62d9330fcead96bd7fca"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"51fb586e52cec1951d5a18de24f7c3892e10a7d1","unresolved":false,"context_lines":[{"line_number":1587,"context_line":"                    LOG.exception(_LE(\"Error while synchronizing tunnels\"))"},{"line_number":1588,"context_line":"                    tunnel_sync \u003d True"},{"line_number":1589,"context_line":"            ovs_restarted |\u003d (ovs_status \u003d\u003d constants.OVS_RESTARTED)"},{"line_number":1590,"context_line":"            if self._agent_has_updates(polling_manager) or sync:"},{"line_number":1591,"context_line":"                try:"},{"line_number":1592,"context_line":"                    LOG.debug(\"Agent rpc_loop - iteration:%(iter_num)d - \""},{"line_number":1593,"context_line":"                              \"starting polling. Elapsed:%(elapsed).3f\","}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_ca722511","line":1590,"updated":"2015-05-05 11:18:38.000000000","message":"can you help me understand how do ensure now that the agent in sync upon restart?\n\nat startup sync is false, so it seems the agent won\u0027t do anything unless there is an event. So can the agent stay out of sync for an indefinite amount of time?","commit_id":"3214b6d4f63bd913b913cce158f3ea2c6ee35cc3"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"595f4ed74537be0455396622ffa03890ef1bf762","unresolved":false,"context_lines":[{"line_number":1587,"context_line":"                    LOG.exception(_LE(\"Error while synchronizing tunnels\"))"},{"line_number":1588,"context_line":"                    tunnel_sync \u003d True"},{"line_number":1589,"context_line":"            ovs_restarted |\u003d (ovs_status \u003d\u003d constants.OVS_RESTARTED)"},{"line_number":1590,"context_line":"            if self._agent_has_updates(polling_manager) or sync:"},{"line_number":1591,"context_line":"                try:"},{"line_number":1592,"context_line":"                    LOG.debug(\"Agent rpc_loop - iteration:%(iter_num)d - \""},{"line_number":1593,"context_line":"                              \"starting polling. Elapsed:%(elapsed).3f\","}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_6b0d53e7","line":1590,"in_reply_to":"3acd31a7_ca722511","updated":"2015-05-05 12:37:29.000000000","message":"at startup _agent_has_updates is always true, because when ovsdb monitor starts it reports all the ports that are on the machine using \"initial\" as action type","commit_id":"3214b6d4f63bd913b913cce158f3ea2c6ee35cc3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"51fb586e52cec1951d5a18de24f7c3892e10a7d1","unresolved":false,"context_lines":[{"line_number":1604,"context_line":"                        port_info \u003d self.process_ports_events("},{"line_number":1605,"context_line":"                            events, ports, updated_ports_copy)"},{"line_number":1606,"context_line":"                    # there was a problem in syncing with the plugin, so"},{"line_number":1607,"context_line":"                    # scan all the ports"},{"line_number":1608,"context_line":"                    else:"},{"line_number":1609,"context_line":"                        if sync:"},{"line_number":1610,"context_line":"                            LOG.info(_LI(\"Agent out of sync with plugin!\"))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_ca1b45c9","line":1607,"updated":"2015-05-05 11:18:38.000000000","message":"I\u0027m not sure the comment above is properly placed","commit_id":"3214b6d4f63bd913b913cce158f3ea2c6ee35cc3"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"595f4ed74537be0455396622ffa03890ef1bf762","unresolved":false,"context_lines":[{"line_number":1604,"context_line":"                        port_info \u003d self.process_ports_events("},{"line_number":1605,"context_line":"                            events, ports, updated_ports_copy)"},{"line_number":1606,"context_line":"                    # there was a problem in syncing with the plugin, so"},{"line_number":1607,"context_line":"                    # scan all the ports"},{"line_number":1608,"context_line":"                    else:"},{"line_number":1609,"context_line":"                        if sync:"},{"line_number":1610,"context_line":"                            LOG.info(_LI(\"Agent out of sync with plugin!\"))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_2bfcfbb6","line":1607,"in_reply_to":"3acd31a7_ca1b45c9","updated":"2015-05-05 12:37:29.000000000","message":"right","commit_id":"3214b6d4f63bd913b913cce158f3ea2c6ee35cc3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"51fb586e52cec1951d5a18de24f7c3892e10a7d1","unresolved":false,"context_lines":[{"line_number":1613,"context_line":"                            sync \u003d False"},{"line_number":1614,"context_line":"                        reg_ports \u003d (set() if ovs_restarted else ports)"},{"line_number":1615,"context_line":"                        port_info \u003d self.scan_ports(reg_ports,"},{"line_number":1616,"context_line":"                                                    updated_ports_copy)"},{"line_number":1617,"context_line":"                    self.update_stale_ofport_rules()"},{"line_number":1618,"context_line":"                    LOG.debug(\"Agent rpc_loop - iteration:%(iter_num)d - \""},{"line_number":1619,"context_line":"                              \"port information retrieved. \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_253d4ac4","line":1616,"updated":"2015-05-05 11:18:38.000000000","message":"I think if we are here it\u0027s because either sync\u003dTrue or there are no events.\nIf sync is True it makes sense to do scan_ports. However, if sync is False, and there are no events, why is there a need to do that?","commit_id":"3214b6d4f63bd913b913cce158f3ea2c6ee35cc3"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"595f4ed74537be0455396622ffa03890ef1bf762","unresolved":false,"context_lines":[{"line_number":1613,"context_line":"                            sync \u003d False"},{"line_number":1614,"context_line":"                        reg_ports \u003d (set() if ovs_restarted else ports)"},{"line_number":1615,"context_line":"                        port_info \u003d self.scan_ports(reg_ports,"},{"line_number":1616,"context_line":"                                                    updated_ports_copy)"},{"line_number":1617,"context_line":"                    self.update_stale_ofport_rules()"},{"line_number":1618,"context_line":"                    LOG.debug(\"Agent rpc_loop - iteration:%(iter_num)d - \""},{"line_number":1619,"context_line":"                              \"port information retrieved. \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3acd31a7_6b331363","line":1616,"in_reply_to":"3acd31a7_253d4ac4","updated":"2015-05-05 12:37:29.000000000","message":"probably the code is not as clear as I\u0027d like it to be. If we are here, it\u0027s because\n1) sync is True\nor\n2) sync is False, there are events (see line 1590) and the polling_manager doesn\u0027t have \u0027get_events\u0027 method (see line ) . I had to add the third condition because some unit tests were failing, since only InterfacePollingMinimizer has \u0027get_events\u0027\n\nSo the need to scan the port is to cover case (2)","commit_id":"3214b6d4f63bd913b913cce158f3ea2c6ee35cc3"}],"neutron/tests/functional/agent/l2/base.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4dce8774e2d5cd0b3200939584edba862f281d5f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                    # if the event is not about a port that was created by"},{"line_number":136,"context_line":"                    # this test, we filter the event out. Since these tests are"},{"line_number":137,"context_line":"                    # not run in isolation processing all the events might make"},{"line_number":138,"context_line":"                    # some test fail ( e.g. the agent might keep resycing"},{"line_number":139,"context_line":"                    # because it keeps finding not ready ports that are created"},{"line_number":140,"context_line":"                    # by other tests)"},{"line_number":141,"context_line":"                    filtered_ports.append(dev)"}],"source_content_type":"text/x-python","patch_set":34,"id":"da85f559_0f6e78c9","line":138,"range":{"start_line":138,"start_character":65,"end_line":138,"end_character":73},"updated":"2015-11-09 10:54:25.000000000","message":"resyncing?","commit_id":"1992d52d63dc32c63faa5a3f482d5b8ebe925a77"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"fe4ece2de48fc14268bc94aac87831260ebf05d4","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                    # if the event is not about a port that was created by"},{"line_number":136,"context_line":"                    # this test, we filter the event out. Since these tests are"},{"line_number":137,"context_line":"                    # not run in isolation processing all the events might make"},{"line_number":138,"context_line":"                    # some test fail ( e.g. the agent might keep resycing"},{"line_number":139,"context_line":"                    # because it keeps finding not ready ports that are created"},{"line_number":140,"context_line":"                    # by other tests)"},{"line_number":141,"context_line":"                    filtered_ports.append(dev)"}],"source_content_type":"text/x-python","patch_set":34,"id":"da85f559_a0adfb89","line":138,"in_reply_to":"da85f559_0f6e78c9","updated":"2015-11-09 13:28:18.000000000","message":"Done","commit_id":"1992d52d63dc32c63faa5a3f482d5b8ebe925a77"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4dce8774e2d5cd0b3200939584edba862f281d5f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                    # by other tests)"},{"line_number":141,"context_line":"                    filtered_ports.append(dev)"},{"line_number":142,"context_line":"            return {\u0027added\u0027: filtered_ports, \u0027removed\u0027: events[\u0027removed\u0027]}"},{"line_number":143,"context_line":"        polling_manager.get_events \u003d mock.Mock(side_effect\u003dfilter_events)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def start_agent(self, agent, ports\u003dNone, unplug_ports\u003dNone):"},{"line_number":146,"context_line":"        if unplug_ports is None:"}],"source_content_type":"text/x-python","patch_set":34,"id":"da85f559_6fee2424","line":143,"updated":"2015-11-09 10:54:25.000000000","message":"better to use mock.object.patch","commit_id":"1992d52d63dc32c63faa5a3f482d5b8ebe925a77"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"fe4ece2de48fc14268bc94aac87831260ebf05d4","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                    # by other tests)"},{"line_number":141,"context_line":"                    filtered_ports.append(dev)"},{"line_number":142,"context_line":"            return {\u0027added\u0027: filtered_ports, \u0027removed\u0027: events[\u0027removed\u0027]}"},{"line_number":143,"context_line":"        polling_manager.get_events \u003d mock.Mock(side_effect\u003dfilter_events)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def start_agent(self, agent, ports\u003dNone, unplug_ports\u003dNone):"},{"line_number":146,"context_line":"        if unplug_ports is None:"}],"source_content_type":"text/x-python","patch_set":34,"id":"da85f559_60b633de","line":143,"in_reply_to":"da85f559_6fee2424","updated":"2015-11-09 13:28:18.000000000","message":"Done","commit_id":"1992d52d63dc32c63faa5a3f482d5b8ebe925a77"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"75a044f42a15f629f021d2b71d4082dd1f72b8ad","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        with mock.patch.object(self.agent, \u0027check_changed_vlans\u0027,"},{"line_number":310,"context_line":"                               return_value\u003dset()):"},{"line_number":311,"context_line":"            events \u003d {\u0027added\u0027: [], \u0027removed\u0027: []}"},{"line_number":312,"context_line":"            registered_ports \u003d set([1, 3])"},{"line_number":313,"context_line":"            ancillary_ports \u003d set([2, 5])"},{"line_number":314,"context_line":"            expected_ports \u003d {\u0027current\u0027: registered_ports, \u0027added\u0027: set(),"},{"line_number":315,"context_line":"                              \u0027removed\u0027: set()}"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a4dcd0f_751fa3b7","line":312,"updated":"2015-08-15 00:28:51.000000000","message":"cosmetic: {1, 3} is more readable","commit_id":"bb9fa02a049a7351c30d4a22f93ed573cf54e07e"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c30862e1cafdc18b1f18771569616864511518e2","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        with mock.patch.object(self.agent, \u0027check_changed_vlans\u0027,"},{"line_number":310,"context_line":"                               return_value\u003dset()):"},{"line_number":311,"context_line":"            events \u003d {\u0027added\u0027: [], \u0027removed\u0027: []}"},{"line_number":312,"context_line":"            registered_ports \u003d set([1, 3])"},{"line_number":313,"context_line":"            ancillary_ports \u003d set([2, 5])"},{"line_number":314,"context_line":"            expected_ports \u003d {\u0027current\u0027: registered_ports, \u0027added\u0027: set(),"},{"line_number":315,"context_line":"                              \u0027removed\u0027: set()}"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a4dcd0f_2b577727","line":312,"in_reply_to":"1a4dcd0f_751fa3b7","updated":"2015-08-15 15:17:03.000000000","message":"next PS is ready and I\u0027d like to push it, I will address this comment in next next one :)","commit_id":"bb9fa02a049a7351c30d4a22f93ed573cf54e07e"}]}
