)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3c15648d0a30cdd2e4795fc6e30333712640d078","unresolved":false,"context_lines":[{"line_number":10,"context_line":"python-openvswitch package to use OVSDB native. If an unknown"},{"line_number":11,"context_line":"Exception is thrown when doing a simple get_bridges() call, it will"},{"line_number":12,"context_line":"also fail, logging the exception."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibd2dac02c5a93bb391b620cc27bc46a6cdf6d817"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_6450915e","line":13,"updated":"2015-03-20 16:12:49.000000000","message":"Please refer to blueprint it belongs to.","commit_id":"3a7aa2d0e974fc8162179cd467bfaa4dd6d58a91"}],"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8a53cf38b462ee46b9cd02a262596fce69b7c9dc","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return True"},{"line_number":163,"context_line":"    except ImportError as ex:"},{"line_number":164,"context_line":"        LOG.error(_LE(\"Failed to import required modules. Ensure that the \""},{"line_number":165,"context_line":"                      \"python-openvswitch package is installed. Error: %s\") %"},{"line_number":166,"context_line":"                  ex.message)"},{"line_number":167,"context_line":"    except Exception as ex:"},{"line_number":168,"context_line":"        LOG.exception(ex)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_849ca56b","line":165,"updated":"2015-03-20 16:11:06.000000000","message":"% -\u003e ,","commit_id":"3a7aa2d0e974fc8162179cd467bfaa4dd6d58a91"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8a53cf38b462ee46b9cd02a262596fce69b7c9dc","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                      \"python-openvswitch package is installed. Error: %s\") %"},{"line_number":166,"context_line":"                  ex.message)"},{"line_number":167,"context_line":"    except Exception as ex:"},{"line_number":168,"context_line":"        LOG.exception(ex)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_c42cdd04","line":168,"updated":"2015-03-20 16:11:06.000000000","message":"As per https://review.openstack.org/#/c/147312/ , it\u0027s a bad pattern and may not work with oslo.log. For more details, see \"No more implicit conversion to unicode/str\" section in the patch I referred to.","commit_id":"3a7aa2d0e974fc8162179cd467bfaa4dd6d58a91"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c5021dcad55e143ca1425b16a1b3c6fabf22dfc4","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                      \"python-openvswitch package is installed. Error: %s\"),"},{"line_number":167,"context_line":"                  ex.message)"},{"line_number":168,"context_line":"    except Exception as ex:"},{"line_number":169,"context_line":"        LOG.exception(six.text_type(ex))"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_4488ba22","line":169,"updated":"2015-03-23 09:35:32.000000000","message":"Not sure why we need the LOG.exception here. Maybe consider adding the LOG.error","commit_id":"f3ee6841a7d88d23e2a80667d4b928f6abd83a32"}],"neutron/cmd/sanity_check.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8a53cf38b462ee46b9cd02a262596fce69b7c9dc","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"def check_ovsdb_native():"},{"line_number":133,"context_line":"    cfg.CONF.set_override(\u0027ovsdb_interface\u0027, \u0027native\u0027, group\u003d\u0027OVS\u0027)"},{"line_number":134,"context_line":"    result \u003d checks.ovsdb_native_supported()"},{"line_number":135,"context_line":"    if not result:"},{"line_number":136,"context_line":"        LOG.error(_LE(\u0027Check for native OVSDB support failed.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_e4bac1be","line":133,"updated":"2015-03-20 16:11:06.000000000","message":"I don\u0027t follow why we need to rewrite it. If we got here, it probably means that ovsdb_native check is enabled, meaning interface is already native (as per line 189).","commit_id":"3a7aa2d0e974fc8162179cd467bfaa4dd6d58a91"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8a53cf38b462ee46b9cd02a262596fce69b7c9dc","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        cfg.CONF.set_override(\u0027read_netns\u0027, True)"},{"line_number":187,"context_line":"    if cfg.CONF.dhcp_driver \u003d\u003d \u0027neutron.agent.linux.dhcp.Dnsmasq\u0027:"},{"line_number":188,"context_line":"        cfg.CONF.set_override(\u0027dnsmasq_version\u0027, True)"},{"line_number":189,"context_line":"    if cfg.CONF.OVS.ovsdb_interface \u003d\u003d \u0027nataive\u0027:"},{"line_number":190,"context_line":"        cfg.CONF.set_override(\u0027ovsdb_native\u0027, True)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_447d4d1b","line":189,"updated":"2015-03-20 16:11:06.000000000","message":"native?","commit_id":"3a7aa2d0e974fc8162179cd467bfaa4dd6d58a91"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fca5859bcd4d0e4bc81be90ede17ed914468ea1b","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"def check_ovsdb_native():"},{"line_number":133,"context_line":"    cfg.CONF.set_override(\u0027ovsdb_interface\u0027, \u0027native\u0027, group\u003d\u0027OVS\u0027)"},{"line_number":134,"context_line":"    result \u003d checks.ovsdb_native_supported()"},{"line_number":135,"context_line":"    if not result:"},{"line_number":136,"context_line":"        LOG.error(_LE(\u0027Check for native OVSDB support failed.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_dfbe64d3","line":133,"updated":"2015-03-20 16:30:38.000000000","message":"so why rewriting it here?","commit_id":"4320d85e98417db3c2504591b64e02a7363248d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b92439b63596993bbee889c7414a368502030231","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"def check_ovsdb_native():"},{"line_number":133,"context_line":"    cfg.CONF.set_override(\u0027ovsdb_interface\u0027, \u0027native\u0027, group\u003d\u0027OVS\u0027)"},{"line_number":134,"context_line":"    result \u003d checks.ovsdb_native_supported()"},{"line_number":135,"context_line":"    if not result:"},{"line_number":136,"context_line":"        LOG.error(_LE(\u0027Check for native OVSDB support failed.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_3fdce0e3","line":133,"in_reply_to":"9a80dd14_1fe8fcb1","updated":"2015-03-20 16:40:43.000000000","message":"Ah right. Thanks for explanation.","commit_id":"4320d85e98417db3c2504591b64e02a7363248d5"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c88f65c5786ae3477bf6b67aea0fc589fde3fda2","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"def check_ovsdb_native():"},{"line_number":133,"context_line":"    cfg.CONF.set_override(\u0027ovsdb_interface\u0027, \u0027native\u0027, group\u003d\u0027OVS\u0027)"},{"line_number":134,"context_line":"    result \u003d checks.ovsdb_native_supported()"},{"line_number":135,"context_line":"    if not result:"},{"line_number":136,"context_line":"        LOG.error(_LE(\u0027Check for native OVSDB support failed.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_1fe8fcb1","line":133,"in_reply_to":"9a80dd14_dfbe64d3","updated":"2015-03-20 16:36:19.000000000","message":"If someone just passes sanity-check --ovsdb_native without passing any config info, then the test wouldn\u0027t be actually be testing ovsdb native.\n\nI could change it from using get_bridges() to specifically importing impl_idl and manually running a transaction, but since that isn\u0027t how most things use OVSDB I figured I\u0027d test all the way through the process which gets/loads the impl_idl through BaseOVS(), etc.","commit_id":"4320d85e98417db3c2504591b64e02a7363248d5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fca5859bcd4d0e4bc81be90ede17ed914468ea1b","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        cfg.CONF.set_override(\u0027read_netns\u0027, True)"},{"line_number":187,"context_line":"    if cfg.CONF.dhcp_driver \u003d\u003d \u0027neutron.agent.linux.dhcp.Dnsmasq\u0027:"},{"line_number":188,"context_line":"        cfg.CONF.set_override(\u0027dnsmasq_version\u0027, True)"},{"line_number":189,"context_line":"    if cfg.CONF.OVS.ovsdb_interface \u003d\u003d \u0027nataive\u0027:"},{"line_number":190,"context_line":"        cfg.CONF.set_override(\u0027ovsdb_native\u0027, True)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_7fee58ee","line":189,"updated":"2015-03-20 16:30:38.000000000","message":"still wrong?","commit_id":"4320d85e98417db3c2504591b64e02a7363248d5"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c88f65c5786ae3477bf6b67aea0fc589fde3fda2","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        cfg.CONF.set_override(\u0027read_netns\u0027, True)"},{"line_number":187,"context_line":"    if cfg.CONF.dhcp_driver \u003d\u003d \u0027neutron.agent.linux.dhcp.Dnsmasq\u0027:"},{"line_number":188,"context_line":"        cfg.CONF.set_override(\u0027dnsmasq_version\u0027, True)"},{"line_number":189,"context_line":"    if cfg.CONF.OVS.ovsdb_interface \u003d\u003d \u0027nataive\u0027:"},{"line_number":190,"context_line":"        cfg.CONF.set_override(\u0027ovsdb_native\u0027, True)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_fffb2878","line":189,"in_reply_to":"9a80dd14_7fee58ee","updated":"2015-03-20 16:36:19.000000000","message":"Done","commit_id":"4320d85e98417db3c2504591b64e02a7363248d5"}]}