)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5a60169202e46827d4ee340ebbb0b6bf12c29c15","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lzklibj \u003clzklibj@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-21 09:58:15 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix l3-agent restart with last runtime fips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When L3-agent restart with last runtime floating IPs,"},{"line_number":10,"context_line":"it will miss to create rtr_fip_subnet for router_info. The"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6ced46_89cd7d89","line":7,"updated":"2015-03-21 23:31:29.000000000","message":"It is better to mention this bug occurs in DVR environment.","commit_id":"3fd8e8c5b763a62ce666c5b2a7ca5655a126798f"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"8e8838ac3b72cef6b2697a19951ff78c160d20e3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lzklibj \u003clzklibj@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-21 09:58:15 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix l3-agent restart with last runtime fips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When L3-agent restart with last runtime floating IPs,"},{"line_number":10,"context_line":"it will miss to create rtr_fip_subnet for router_info. The"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6ced46_2c1d7774","line":7,"in_reply_to":"1a6ced46_89cd7d89","updated":"2015-03-22 06:31:08.000000000","message":"Done. Thx :)","commit_id":"3fd8e8c5b763a62ce666c5b2a7ca5655a126798f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5a60169202e46827d4ee340ebbb0b6bf12c29c15","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix l3-agent restart with last runtime fips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When L3-agent restart with last runtime floating IPs,"},{"line_number":10,"context_line":"it will miss to create rtr_fip_subnet for router_info. The"},{"line_number":11,"context_line":"previous floating IPs can still work, but new associated"},{"line_number":12,"context_line":"floating IP on this L3-agent will fail to configure and not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6ced46_a9ca396c","line":9,"updated":"2015-03-21 23:31:29.000000000","message":"\"last runtime floating IP\" is not easy to understand. I cannot understand what is \"last runtime\" floating IP. Can you rephrase it?","commit_id":"3fd8e8c5b763a62ce666c5b2a7ca5655a126798f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2b379011d49f7f81e43e16ee19a28a73141d04cb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix l3-agent restart with last runtime fips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When L3-agent restart with last runtime floating IPs,"},{"line_number":10,"context_line":"it will miss to create rtr_fip_subnet for router_info. The"},{"line_number":11,"context_line":"previous floating IPs can still work, but new associated"},{"line_number":12,"context_line":"floating IP on this L3-agent will fail to configure and not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6ced46_37794094","line":9,"in_reply_to":"1a6ced46_6c176f52","updated":"2015-03-22 06:46:16.000000000","message":"thanks. The new message is easier to read :-)","commit_id":"3fd8e8c5b763a62ce666c5b2a7ca5655a126798f"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"8e8838ac3b72cef6b2697a19951ff78c160d20e3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix l3-agent restart with last runtime fips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When L3-agent restart with last runtime floating IPs,"},{"line_number":10,"context_line":"it will miss to create rtr_fip_subnet for router_info. The"},{"line_number":11,"context_line":"previous floating IPs can still work, but new associated"},{"line_number":12,"context_line":"floating IP on this L3-agent will fail to configure and not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6ced46_6c176f52","line":9,"in_reply_to":"1a6ced46_a9ca396c","updated":"2015-03-22 06:31:08.000000000","message":"I changed my words to explain, I hope that can be helpful.","commit_id":"3fd8e8c5b763a62ce666c5b2a7ca5655a126798f"},{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"3f80a16f6057e3bd8c265a0691fffadafde2145f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"node, the L3-agent will miss to create rtr_fip_subnet for"},{"line_number":12,"context_line":"router_info. The previous floating IP can still work, but"},{"line_number":13,"context_line":"new associated floating IP on this L3-agent will fail to"},{"line_number":14,"context_line":"configure and not work. This patch will fix this."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I3786eab86755a403991728ccb72d03f159ff8b63"},{"line_number":17,"context_line":"Closes-Bug: 1434824"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6ced46_9c5f550e","line":14,"updated":"2015-03-23 15:52:01.000000000","message":"Thanks for looking into this.  I am trying to understand the issue more.  Is the second VM on a different subnet or router?  If the issue really is only the rtr_fip_subnet being None, perhaps just adding that to the floating_ip_added_dist call would be enough.  Calling all of create_rtr_2_fip_link might be more than is needed. \nMore detail in code comments.","commit_id":"6c7fc8cb20777f20908836a8a6ef0c1f1af12c8e"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"92d55cd863f7cd9271eac64de0817208eef0ef8e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"node, the L3-agent will miss to create rtr_fip_subnet for"},{"line_number":12,"context_line":"router_info. The previous floating IP can still work, but"},{"line_number":13,"context_line":"new associated floating IP on this L3-agent will fail to"},{"line_number":14,"context_line":"configure and not work. This patch will fix this."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I3786eab86755a403991728ccb72d03f159ff8b63"},{"line_number":17,"context_line":"Closes-Bug: 1434824"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6ced46_26656fe1","line":14,"in_reply_to":"1a6ced46_9c5f550e","updated":"2015-03-23 16:33:19.000000000","message":"Both the two VMs should be on the same router, I didn\u0027t notice the difference of subnets on the same router, for VMs from same router\u0027s different subnets will share the same fip netns and related resource.\n\nVMs from different subnets, I think they will not be affected. I will test this later, or for now, I need get my commit message more clear.\n\nBtw, thx :)","commit_id":"6c7fc8cb20777f20908836a8a6ef0c1f1af12c8e"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"b67d1ba78fc854401e29b718e6187f5339076dcf","unresolved":false,"context_lines":[{"line_number":11,"context_line":"node, the L3-agent will miss to create rtr_fip_subnet for"},{"line_number":12,"context_line":"router_info. The previous floating IP can still work, but"},{"line_number":13,"context_line":"new associated floating IP on this L3-agent will fail to"},{"line_number":14,"context_line":"configure and not work. This patch will fix this."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I3786eab86755a403991728ccb72d03f159ff8b63"},{"line_number":17,"context_line":"Closes-Bug: 1434824"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6ced46_7f833804","line":14,"in_reply_to":"1a6ced46_9c5f550e","updated":"2015-03-24 15:58:42.000000000","message":"Hi, Mike, I changed my code in this patch.\nI still think the lazy way to create rtr_fip_subnet is better, so I update my commit message to explain more about my point.","commit_id":"6c7fc8cb20777f20908836a8a6ef0c1f1af12c8e"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"89e5205d63c54878d340d5a8c07d9e5244082191","unresolved":false,"context_lines":[{"line_number":11,"context_line":"node, the L3-agent will miss to create rtr_fip_subnet for"},{"line_number":12,"context_line":"router_info. The previous floating IP can still work, but"},{"line_number":13,"context_line":"new associated floating IP on this L3-agent will fail to"},{"line_number":14,"context_line":"configure and not work. This patch will fix this."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I3786eab86755a403991728ccb72d03f159ff8b63"},{"line_number":17,"context_line":"Closes-Bug: 1434824"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a6ced46_049f8b53","line":14,"in_reply_to":"1a6ced46_9c5f550e","updated":"2015-03-23 17:16:56.000000000","message":"Mike, I test again.\nVMs from a router\u0027s different subnets will also be affected.\nVMs from different routers, will not.\nSo the key point should be VMs related to the same router on the same host.","commit_id":"6c7fc8cb20777f20908836a8a6ef0c1f1af12c8e"}],"neutron/agent/l3/agent.py":[{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"3f80a16f6057e3bd8c265a0691fffadafde2145f","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                else:"},{"line_number":486,"context_line":"                    ri._set_subnet_info(fip_agent_port)"},{"line_number":487,"context_line":"                    ri.fip_ns.create_gateway_port(fip_agent_port)"},{"line_number":488,"context_line":"                    ri.fip_ns.create_rtr_2_fip_link(ri)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        if ri.fip_ns.agent_gateway_port and floating_ips:"},{"line_number":491,"context_line":"            if ri.dist_fip_count \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_bc7971fe","line":488,"updated":"2015-03-23 15:52:01.000000000","message":"This might be more than is needed.  A call was added to floating_ip_removed_dist to allocate rtr_fip_subnet in dvr_router.py, perhaps a similar call could be added to floating_ip_added_dist?","commit_id":"6c7fc8cb20777f20908836a8a6ef0c1f1af12c8e"},{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"2b0e5c58e592aa05f574b22d08d2bde6e495f762","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                else:"},{"line_number":486,"context_line":"                    ri._set_subnet_info(fip_agent_port)"},{"line_number":487,"context_line":"                    ri.fip_ns.create_gateway_port(fip_agent_port)"},{"line_number":488,"context_line":"                    ri.fip_ns.create_rtr_2_fip_link(ri)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        if ri.fip_ns.agent_gateway_port and floating_ips:"},{"line_number":491,"context_line":"            if ri.dist_fip_count \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_46498bcf","line":488,"in_reply_to":"1a6ced46_133fd326","updated":"2015-03-23 16:45:59.000000000","message":"You make good points regarding where the call should be made.  Allocating the object sooner is safer/better.\nYes, the logic is if rtr_fip_subnet does not exist, create it.  My suggestion is purely an optimization - your fix may just be doing more than that is needed.","commit_id":"6c7fc8cb20777f20908836a8a6ef0c1f1af12c8e"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"89e5205d63c54878d340d5a8c07d9e5244082191","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                else:"},{"line_number":486,"context_line":"                    ri._set_subnet_info(fip_agent_port)"},{"line_number":487,"context_line":"                    ri.fip_ns.create_gateway_port(fip_agent_port)"},{"line_number":488,"context_line":"                    ri.fip_ns.create_rtr_2_fip_link(ri)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        if ri.fip_ns.agent_gateway_port and floating_ips:"},{"line_number":491,"context_line":"            if ri.dist_fip_count \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_84461bbe","line":488,"in_reply_to":"1a6ced46_46498bcf","updated":"2015-03-23 17:16:56.000000000","message":"Well, I will take a consideration on your suggestion. If nothing need to discuss more, I will update it and submit a new patch on my day time.","commit_id":"6c7fc8cb20777f20908836a8a6ef0c1f1af12c8e"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"92d55cd863f7cd9271eac64de0817208eef0ef8e","unresolved":false,"context_lines":[{"line_number":485,"context_line":"                else:"},{"line_number":486,"context_line":"                    ri._set_subnet_info(fip_agent_port)"},{"line_number":487,"context_line":"                    ri.fip_ns.create_gateway_port(fip_agent_port)"},{"line_number":488,"context_line":"                    ri.fip_ns.create_rtr_2_fip_link(ri)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        if ri.fip_ns.agent_gateway_port and floating_ips:"},{"line_number":491,"context_line":"            if ri.dist_fip_count \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_133fd326","line":488,"in_reply_to":"1a6ced46_bc7971fe","updated":"2015-03-23 16:33:19.000000000","message":"Oops, I can\u0027t tell.\n\nFirst, let me get your point. Do you mean, we can add logic to check whether rtr_fip_subnet exists before we call rtr_fip_subnet, if not, we should create it. Right?\n\nThat makes sense to me. But this way will be a lazier one. We only need to do this when is_fisrt is true, not in every fip configuration. \n\nOther details, create_dvr_fip_interface and floating_ip_added_dist can be both traced from _process_external in agent.py, and create_dvr_fip_interface will be invoked earlier than the other, so it could work.","commit_id":"6c7fc8cb20777f20908836a8a6ef0c1f1af12c8e"}]}