)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"0f6711d75ea050c6bc11183b30ec1dd4bd32701e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reference:"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/165311/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For a VLAN underlays, DVR does not mandate l2-pop to be turned ON."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"So just checking for enable_tunneling and validating for l2-pop being"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6ced46_31bce36c","line":11,"updated":"2015-03-23 06:57:48.000000000","message":"Does DVR works with VLANS?","commit_id":"18b4d58ea1f2cb8ceda7da3844af54a0de53ef1a"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"98477d814130c9c005db243c6796e2b672e72411","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reference:"},{"line_number":10,"context_line":"https://review.openstack.org/#/c/165311/"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For a VLAN underlays, DVR does not mandate l2-pop to be turned ON."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"So just checking for enable_tunneling and validating for l2-pop being"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6ced46_f157ab24","line":11,"in_reply_to":"1a6ced46_31bce36c","updated":"2015-03-23 07:01:42.000000000","message":"Look at https://review.openstack.org/129884","commit_id":"18b4d58ea1f2cb8ceda7da3844af54a0de53ef1a"}],"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"0f6711d75ea050c6bc11183b30ec1dd4bd32701e","unresolved":false,"context_lines":[{"line_number":1559,"context_line":"            rpc_api.client.timeout \u003d timeout"},{"line_number":1560,"context_line":""},{"line_number":1561,"context_line":"    def _check_agent_configurations(self):"},{"line_number":1562,"context_line":"        if (self.enable_distributed_routing and self.enable_tunneling and"},{"line_number":1563,"context_line":"            not self.l2_pop):"},{"line_number":1564,"context_line":"            raise ValueError(_(\"DVR cannot be enabled without \""},{"line_number":1565,"context_line":"                               \"L2 population.\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_91a4b758","line":1562,"updated":"2015-03-23 06:57:48.000000000","message":"This method is called before self.enable_tunneling is set inside the constructor \nso it shouldnt work.\n\nAlso i think that DVR is not working with VLANS (unless i am mistaken and please correct me if i do)\nand hence you should check for that in a separate line in my opinion","commit_id":"18b4d58ea1f2cb8ceda7da3844af54a0de53ef1a"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"9b8b047de115b4b50a8780d709a6a871d5ed62f1","unresolved":false,"context_lines":[{"line_number":1562,"context_line":"        if (self.enable_distributed_routing and self.enable_tunneling and"},{"line_number":1563,"context_line":"            not self.l2_pop):"},{"line_number":1564,"context_line":"            raise ValueError(_(\"DVR cannot be enabled without \""},{"line_number":1565,"context_line":"                               \"L2 population.\"))"},{"line_number":1566,"context_line":""},{"line_number":1567,"context_line":""},{"line_number":1568,"context_line":"def _ofport_set_to_str(ofport_set):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_959f4203","line":1565,"updated":"2015-03-23 07:33:09.000000000","message":"Please put \n\n\"DVR deployments for VXLAN/GRE underlays require L2-pop to be turned on, in both the neutron-agent and neutron-server\" \n\nas error message.","commit_id":"9b1c75c7f30133022a3ffaf83a455db60694334b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"25102d2b159f141556cba60b031cbbcae2a70540","unresolved":false,"context_lines":[{"line_number":1559,"context_line":"            rpc_api.client.timeout \u003d timeout"},{"line_number":1560,"context_line":""},{"line_number":1561,"context_line":"    def _check_agent_configurations(self):"},{"line_number":1562,"context_line":"        if (self.enable_distributed_routing and self.enable_tunneling and"},{"line_number":1563,"context_line":"            not self.l2_pop):"},{"line_number":1564,"context_line":"            raise ValueError(_(\"DVR deployments for VXLAN/GRE underlays \""},{"line_number":1565,"context_line":"                               \"require L2-pop to be enabled, in both the \""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_6e5c30ee","line":1562,"updated":"2015-03-25 19:43:26.000000000","message":"technically speaking dvr works fine without l2pop, even though it sucks, anyhow, this condition has become a bit unreadable.","commit_id":"2dee2e617a72dc29304099930a7005ed75107e72"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"000eeabf9a6379b349004c631c21ba6e1467189e","unresolved":false,"context_lines":[{"line_number":1559,"context_line":"            rpc_api.client.timeout \u003d timeout"},{"line_number":1560,"context_line":""},{"line_number":1561,"context_line":"    def _check_agent_configurations(self):"},{"line_number":1562,"context_line":"        if (self.enable_distributed_routing and self.enable_tunneling and"},{"line_number":1563,"context_line":"            not self.l2_pop):"},{"line_number":1564,"context_line":"            raise ValueError(_(\"DVR deployments for VXLAN/GRE underlays \""},{"line_number":1565,"context_line":"                               \"require L2-pop to be enabled, in both the \""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_711964d6","line":1562,"in_reply_to":"1a6ced46_6e5c30ee","updated":"2015-03-26 05:16:29.000000000","message":"If DVR works fine without l2pop, then why we have merged this patchset?\nhttps://review.openstack.org/#/c/165311/, that was the actual fix and here I am trying to correct it as suggested by Vivek.\n\nPlease let me know clearly, do I need to revert the changes done in patch set below:\n    https://review.openstack.org/#/c/165311/\n\n\nAnd, how we could make it readable it\u0027s a simple \u0027if\u0027 statement.\n\nIs that something you mean:\n\n   if (self.enable_distributed_routing and self.enable_tunneling\n       and not self.l2_pop):","commit_id":"2dee2e617a72dc29304099930a7005ed75107e72"}],"neutron/tests/unit/openvswitch/test_ovs_neutron_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"25102d2b159f141556cba60b031cbbcae2a70540","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            self.assertFalse(set_ovs_db_func.called)"},{"line_number":168,"context_line":"            self.assertFalse(delete_flows_func.called)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def test_check_agent_configurations_raises(self):"},{"line_number":171,"context_line":"        self.agent.enable_distributed_routing \u003d True"},{"line_number":172,"context_line":"        self.agent.enable_tunneling \u003d True"},{"line_number":173,"context_line":"        self.agent.l2_pop \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_2e907849","line":170,"updated":"2015-03-25 19:43:26.000000000","message":"we\u0027re not testing your change, ie. the situation where tunnelling is false and l2pop is false shouldn\u0027t raise.","commit_id":"2dee2e617a72dc29304099930a7005ed75107e72"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"000eeabf9a6379b349004c631c21ba6e1467189e","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            self.assertFalse(set_ovs_db_func.called)"},{"line_number":168,"context_line":"            self.assertFalse(delete_flows_func.called)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def test_check_agent_configurations_raises(self):"},{"line_number":171,"context_line":"        self.agent.enable_distributed_routing \u003d True"},{"line_number":172,"context_line":"        self.agent.enable_tunneling \u003d True"},{"line_number":173,"context_line":"        self.agent.l2_pop \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_b1a2fc48","line":170,"in_reply_to":"1a6ced46_2e907849","updated":"2015-03-26 05:16:29.000000000","message":"In that case, I need to add one more test case.\nIt\u0027s, kind of  P\u0026C :)\n\nI will add it. Good catch.","commit_id":"2dee2e617a72dc29304099930a7005ed75107e72"}]}