)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"bf5cc886893388a34d5c4c7c2f7140bda1895e8e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"This patch set addresses the same."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Moved out few methods which are predominantly used in plugins"},{"line_number":20,"context_line":"from common.utils.py to plugins.common.utils.py."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Iecfb15c541ed5d3cce95ba48f072af7fa60ac6f1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9aa53dc9_a579d831","line":20,"updated":"2015-04-06 21:00:19.000000000","message":"Is there a bug or spec for this change ?","commit_id":"e90969d9f6386c8abe004b0a4ec08f73d852dadd"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3714c6e09bdb25b1863859f35e29e5e605c48713","unresolved":false,"context_lines":[{"line_number":17,"context_line":"This patch set addresses the same."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Moved out few methods which are predominantly used in plugins"},{"line_number":20,"context_line":"from common.utils.py to plugins.common.utils.py."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Iecfb15c541ed5d3cce95ba48f072af7fa60ac6f1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9aa53dc9_894b86b0","line":20,"in_reply_to":"9aa53dc9_a579d831","updated":"2015-04-07 04:29:56.000000000","message":"I feel it is not mandatory to have a bug for this. But for the safer side, I will create a Bug report for the same for tracking purpose.","commit_id":"e90969d9f6386c8abe004b0a4ec08f73d852dadd"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"81b2fa0c4786865adccc96e1a853f9f495c2a1be","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.ovsdb import api as ovsdb"},{"line_number":29,"context_line":"from neutron.common import exceptions"},{"line_number":30,"context_line":"from neutron.i18n import _LE, _LI, _LW"},{"line_number":31,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Default timeout for ovs-vsctl command"},{"line_number":34,"context_line":"DEFAULT_OVS_VSCTL_TIMEOUT \u003d 10"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6ced46_aa97de8e","line":31,"updated":"2015-03-26 09:52:59.000000000","message":"This renaming is done just for the consistency purpose, kindly see other files in this patch-set.","commit_id":"31d7e459ea59f9410bb87f82daa4f0737bcb5a30"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"18a3f2dc9c4feea95bb9e8a3f00af34b930e5920","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.ovsdb import api as ovsdb"},{"line_number":29,"context_line":"from neutron.common import exceptions"},{"line_number":30,"context_line":"from neutron.i18n import _LE, _LI, _LW"},{"line_number":31,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Default timeout for ovs-vsctl command"},{"line_number":34,"context_line":"DEFAULT_OVS_VSCTL_TIMEOUT \u003d 10"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa963961_121e780c","line":31,"updated":"2015-03-27 09:10:59.000000000","message":"This renaming is done just for the consistency purpose, kindly see other files in this patch-set.","commit_id":"7353663840c0772c6c678333c18c8f37a25b41ad"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3b72850347aac8ad32cf96d83b7ae45eb2e103df","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.ovsdb import api as ovsdb"},{"line_number":29,"context_line":"from neutron.common import exceptions"},{"line_number":30,"context_line":"from neutron.i18n import _LE, _LI, _LW"},{"line_number":31,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Default timeout for ovs-vsctl command"},{"line_number":34,"context_line":"DEFAULT_OVS_VSCTL_TIMEOUT \u003d 10"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa963961_7341460b","line":31,"updated":"2015-03-27 10:50:59.000000000","message":"This renaming is done just for the consistency purpose, kindly see other files in this patch-set.","commit_id":"75a318b9bc2759d11a50dacce822d4965d65a8a3"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"47d573d802341ae132501a413ee413d2b0f022e6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.ovsdb import api as ovsdb"},{"line_number":29,"context_line":"from neutron.common import exceptions"},{"line_number":30,"context_line":"from neutron.i18n import _LE, _LI, _LW"},{"line_number":31,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Default timeout for ovs-vsctl command"},{"line_number":34,"context_line":"DEFAULT_OVS_VSCTL_TIMEOUT \u003d 10"}],"source_content_type":"text/x-python","patch_set":8,"id":"da9b358b_37a91091","line":31,"updated":"2015-04-01 11:43:44.000000000","message":"This renaming is done just for the consistency purpose, kindly see other files in this patch-set.","commit_id":"e90969d9f6386c8abe004b0a4ec08f73d852dadd"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"ad3571f56e4b2b7f84823dfd42ec6459dace138e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.ovsdb import api as ovsdb"},{"line_number":29,"context_line":"from neutron.common import exceptions"},{"line_number":30,"context_line":"from neutron.i18n import _LE, _LI, _LW"},{"line_number":31,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Default timeout for ovs-vsctl command"},{"line_number":34,"context_line":"DEFAULT_OVS_VSCTL_TIMEOUT \u003d 10"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aa53dc9_04975391","line":31,"updated":"2015-04-07 09:58:32.000000000","message":"This renaming is done just for the consistency purpose, kindly see other files in this patch-set.","commit_id":"18b7715c914ce2bcb96d3743930324594a96f1be"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"79ba9b351949efdf7b6b691f575916965e206dfa","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.ovsdb import api as ovsdb"},{"line_number":29,"context_line":"from neutron.common import exceptions"},{"line_number":30,"context_line":"from neutron.i18n import _LE, _LI, _LW"},{"line_number":31,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Default timeout for ovs-vsctl command"},{"line_number":34,"context_line":"DEFAULT_OVS_VSCTL_TIMEOUT \u003d 10"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aaa499b_22692abf","line":31,"updated":"2015-04-13 07:50:37.000000000","message":"This renaming is done just for the consistency purpose, kindly see other files in this patch-set.","commit_id":"7f406805d93298d0e65d340c2a06ba0d2dd6ff76"}],"neutron/agent/linux/ovs_lib.py":[{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"b2ac6e366cb66a535077d69aabd3e50efffad626","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.ovsdb import api as ovsdb"},{"line_number":29,"context_line":"from neutron.common import exceptions"},{"line_number":30,"context_line":"from neutron.i18n import _LE, _LI, _LW"},{"line_number":31,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Default timeout for ovs-vsctl command"},{"line_number":34,"context_line":"DEFAULT_OVS_VSCTL_TIMEOUT \u003d 10"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_16ed06c4","line":31,"updated":"2015-03-23 15:15:49.000000000","message":"This renaming is done just for the consistency.","commit_id":"f927981e7bc70282b181623e22477ac8716174da"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"0a4f75fca025c7e1440d17b85b0d45b924c10142","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.ovsdb import api as ovsdb"},{"line_number":29,"context_line":"from neutron.common import exceptions"},{"line_number":30,"context_line":"from neutron.i18n import _LE, _LI, _LW"},{"line_number":31,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Default timeout for ovs-vsctl command"},{"line_number":34,"context_line":"DEFAULT_OVS_VSCTL_TIMEOUT \u003d 10"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_b365c8b6","line":31,"updated":"2015-03-25 10:57:02.000000000","message":"This renaming is done just for the consistency","commit_id":"4184b8aca83de0675c910c2cee6e46549715ff5e"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"2248e187daea18e1be464ca743cefdc81202013c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.ovsdb import api as ovsdb"},{"line_number":29,"context_line":"from neutron.common import exceptions"},{"line_number":30,"context_line":"from neutron.i18n import _LE, _LI, _LW"},{"line_number":31,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Default timeout for ovs-vsctl command"},{"line_number":34,"context_line":"DEFAULT_OVS_VSCTL_TIMEOUT \u003d 10"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_c296ec3e","line":31,"updated":"2015-03-25 13:17:51.000000000","message":"why do we need to rename this? there is no other constants used.","commit_id":"edb04dbc70367906ce73c955d425245a5eb463c5"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"427ffe5974bea2103998f659e1c7e2b40b7d68a2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.ovsdb import api as ovsdb"},{"line_number":29,"context_line":"from neutron.common import exceptions"},{"line_number":30,"context_line":"from neutron.i18n import _LE, _LI, _LW"},{"line_number":31,"context_line":"from neutron.plugins.common import constants as p_const"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Default timeout for ovs-vsctl command"},{"line_number":34,"context_line":"DEFAULT_OVS_VSCTL_TIMEOUT \u003d 10"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_82015408","line":31,"in_reply_to":"1a6ced46_c296ec3e","updated":"2015-03-25 13:27:57.000000000","message":"OMG, please don\u0027t screw me. I have been giving the reason for the same in my earlier patch PS1, PS2.\nhttps://review.openstack.org/#/c/166879/1/neutron/agent/linux/ovs_lib.py\nhttps://review.openstack.org/#/c/166879/2/neutron/agent/linux/ovs_lib.py\n\nJust now, I posted the new patch and it got removed.\n\nReason for the same:\n\"This renaming is done just for the consistency purpose, kindly see other files in this patch-set.\"","commit_id":"edb04dbc70367906ce73c955d425245a5eb463c5"}],"neutron/plugins/cisco/db/n1kv_db_v2.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"748ae0a1efc8fe6bf06217b147fc25b8e7fae938","unresolved":false,"context_lines":[{"line_number":1382,"context_line":"        seg_min, seg_max \u003d self._get_segment_range(net_p[\u0027segment_range\u0027])"},{"line_number":1383,"context_line":"        if segment_type \u003d\u003d c_const.NETWORK_TYPE_VLAN:"},{"line_number":1384,"context_line":"            if not ((seg_min \u003c\u003d seg_max) and"},{"line_number":1385,"context_line":"                    ((seg_min in range(p_const.MIN_VLAN_TAG,"},{"line_number":1386,"context_line":"                                       c_const.N1KV_VLAN_RESERVED_MIN) and"},{"line_number":1387,"context_line":"                      seg_max in range(p_const.MIN_VLAN_TAG,"},{"line_number":1388,"context_line":"                                       c_const.N1KV_VLAN_RESERVED_MIN)) or"}],"source_content_type":"text/x-python","patch_set":8,"id":"baa041b7_ac5f25e4","line":1385,"updated":"2015-04-05 14:40:22.000000000","message":"(out of scope) it is an awful code as it uses a range when:\n\n  p_const.MIN_VLAN_TAG \u003c\u003d seg_min \u003c c_const.N1KV_VLAN_RESERVED_MIN\n\nis more readable and more efficient.","commit_id":"e90969d9f6386c8abe004b0a4ec08f73d852dadd"}],"neutron/plugins/cisco/n1kv/n1kv_neutron_plugin.py":[{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"47d573d802341ae132501a413ee413d2b0f022e6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"from neutron.plugins.cisco.extensions import n1kv"},{"line_number":47,"context_line":"from neutron.plugins.cisco.n1kv import n1kv_client"},{"line_number":48,"context_line":"from neutron.plugins.common import constants as svc_constants"},{"line_number":49,"context_line":"from neutron.plugins.common import utils"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da9b358b_97bfbca9","line":49,"updated":"2015-04-01 11:43:44.000000000","message":"see line no. 522","commit_id":"e90969d9f6386c8abe004b0a4ec08f73d852dadd"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"47d573d802341ae132501a413ee413d2b0f022e6","unresolved":false,"context_lines":[{"line_number":518,"context_line":"                        msg \u003d _(\"Cannot add vxlan segment \u0027%s\u0027 as a member of \""},{"line_number":519,"context_line":"                                \"a vlan trunk segment\") % segment"},{"line_number":520,"context_line":"                        raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":521,"context_line":"                    try:"},{"line_number":522,"context_line":"                        if not utils.is_valid_vlan_tag(int(dot1qtag)):"},{"line_number":523,"context_line":"                            msg \u003d _(\"Vlan tag \u0027%s\u0027 is out of range\") % dot1qtag"},{"line_number":524,"context_line":"                            raise n_exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da9b358b_97a8dc78","line":521,"updated":"2015-04-01 11:43:44.000000000","message":"The import change is required for this.","commit_id":"e90969d9f6386c8abe004b0a4ec08f73d852dadd"}],"neutron/plugins/common/constants.py":[{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"1f74b9126206e76f33ab811377716b2ef68cde4e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"TYPE_VXLAN \u003d \u0027vxlan\u0027"},{"line_number":83,"context_line":"TYPE_VLAN \u003d \u0027vlan\u0027"},{"line_number":84,"context_line":"TYPE_NONE \u003d \u0027none\u0027"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Values for network_type"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# For VLAN Network"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_f35d807a","line":85,"updated":"2015-03-25 11:09:15.000000000","message":"@YAMAMOTO Takashi: Let me explain this, here you could see the comment \n\n  # Values for network_type\nBut, I could only see this VXLAN_UDP_PORT \u003d 4789.\n\nDon\u0027t you feel that network type ranges like:\n\nVLAN, VNI, GRE_ID are also network_type values???\n\nSince, we have all network_type constants here L77. What is the problem having its values in this constants file also.","commit_id":"4184b8aca83de0675c910c2cee6e46549715ff5e"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"75f4bba5cdb3ddc339bba32a8eab95fc35d0699e","unresolved":false,"context_lines":[{"line_number":82,"context_line":"TYPE_VXLAN \u003d \u0027vxlan\u0027"},{"line_number":83,"context_line":"TYPE_VLAN \u003d \u0027vlan\u0027"},{"line_number":84,"context_line":"TYPE_NONE \u003d \u0027none\u0027"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Values for network_type"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# For VLAN Network"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_addf210c","line":85,"in_reply_to":"1a6ced46_02e1e4fd","updated":"2015-03-25 13:42:02.000000000","message":"@Yamamoto:  You only answered your question.\n\nSince VXLAN is a protocol and it is declared  in plugins.common.constants.py as TYPE_VXLAN then why can\u0027t we have protocol-specific values resides in a same place??\n\nExample: MIN_VXLAN_VNI, MAX_VXLAN_VNI and VXLAN_UDP_PORT.","commit_id":"4184b8aca83de0675c910c2cee6e46549715ff5e"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"29784055012fac5c0f0e88589520f95d7e0a9301","unresolved":false,"context_lines":[{"line_number":82,"context_line":"TYPE_VXLAN \u003d \u0027vxlan\u0027"},{"line_number":83,"context_line":"TYPE_VLAN \u003d \u0027vlan\u0027"},{"line_number":84,"context_line":"TYPE_NONE \u003d \u0027none\u0027"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Values for network_type"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# For VLAN Network"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_02e1e4fd","line":85,"in_reply_to":"1a6ced46_762fbe88","updated":"2015-03-25 13:30:02.000000000","message":"to me, it seems that these values are protocol definitions not specific to plugins.","commit_id":"4184b8aca83de0675c910c2cee6e46549715ff5e"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"d885b60dd1d70ed5887819213ec8bef890f69d54","unresolved":false,"context_lines":[{"line_number":82,"context_line":"TYPE_VXLAN \u003d \u0027vxlan\u0027"},{"line_number":83,"context_line":"TYPE_VLAN \u003d \u0027vlan\u0027"},{"line_number":84,"context_line":"TYPE_NONE \u003d \u0027none\u0027"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Values for network_type"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# For VLAN Network"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_762fbe88","line":85,"in_reply_to":"1a6ced46_f35d807a","updated":"2015-03-25 11:21:35.000000000","message":"Also, I could observe that these constants are type driver specific which resides in neutron/plugins/...\n\nso, it\u0027s better to have them in plugins/constants.py instead of common/constants.py.","commit_id":"4184b8aca83de0675c910c2cee6e46549715ff5e"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"050632e7e96818b45595b11a88be0e193af5f2cb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# L3 Protocol name constants"},{"line_number":74,"context_line":"TCP \u003d \"tcp\""},{"line_number":75,"context_line":"UDP \u003d \"udp\""},{"line_number":76,"context_line":"ICMP \u003d \"icmp\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Network Type constants"},{"line_number":79,"context_line":"TYPE_FLAT \u003d \u0027flat\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa963961_e43fe0d4","line":76,"updated":"2015-03-26 20:50:11.000000000","message":"These L3 protocol name constants should probably be removed, because for instance, there exists a constant already in common/constants.py for tcp - PROTO_NAME_TCP","commit_id":"31d7e459ea59f9410bb87f82daa4f0737bcb5a30"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"8c02bf6872b5d2ac669e6ce96a93a8828b27c223","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# L3 Protocol name constants"},{"line_number":74,"context_line":"TCP \u003d \"tcp\""},{"line_number":75,"context_line":"UDP \u003d \"udp\""},{"line_number":76,"context_line":"ICMP \u003d \"icmp\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Network Type constants"},{"line_number":79,"context_line":"TYPE_FLAT \u003d \u0027flat\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa963961_38d27d01","line":76,"in_reply_to":"fa963961_3e402d56","updated":"2015-03-27 10:26:00.000000000","message":"@Sean M. Collins: I am reverting my changes as done in PS6, it\u0027s breaking the lot of CI\u0027s. Probably we need to do it reverse way. Any neutron dependent project like neutron-fwaas is using these constants should first starting pointing to common/constants. and eventually we will remove these constants from here.","commit_id":"31d7e459ea59f9410bb87f82daa4f0737bcb5a30"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"89c9f4e2c4879b4d215f163ff6298e1a56c2fd4c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"# L3 Protocol name constants"},{"line_number":74,"context_line":"TCP \u003d \"tcp\""},{"line_number":75,"context_line":"UDP \u003d \"udp\""},{"line_number":76,"context_line":"ICMP \u003d \"icmp\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"# Network Type constants"},{"line_number":79,"context_line":"TYPE_FLAT \u003d \u0027flat\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa963961_3e402d56","line":76,"in_reply_to":"fa963961_e43fe0d4","updated":"2015-03-27 07:13:33.000000000","message":"Ok, will do it.","commit_id":"31d7e459ea59f9410bb87f82daa4f0737bcb5a30"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"49da2b5c32ff2bdb1f0dad7bf22c4350b1862773","unresolved":false,"context_lines":[{"line_number":69,"context_line":"# FWaaS firewall rule action"},{"line_number":70,"context_line":"FWAAS_ALLOW \u003d \"allow\""},{"line_number":71,"context_line":"FWAAS_DENY \u003d \"deny\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# TODO(romilg): Remove L3 protocol name constants because for instance, there"},{"line_number":74,"context_line":"# exists a constant already in common/constants.py for tcp - PROTO_NAME_TCP"},{"line_number":75,"context_line":"# L3 Protocol name constants"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa963961_13f79ad4","line":72,"updated":"2015-03-27 10:53:31.000000000","message":"@Sean M. Collins: Any neutron dependent project like neutron-fwaas is using these constants should first starting pointing to common/constants. and eventually we will remove these constants from here.","commit_id":"75a318b9bc2759d11a50dacce822d4965d65a8a3"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"9810468252c866f1a40a206a7eecf88b8517966e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    PENDING_CREATE,"},{"line_number":66,"context_line":"    PENDING_UPDATE"},{"line_number":67,"context_line":")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# FWaaS firewall rule action"},{"line_number":70,"context_line":"FWAAS_ALLOW \u003d \"allow\""},{"line_number":71,"context_line":"FWAAS_DENY \u003d \"deny\""}],"source_content_type":"text/x-python","patch_set":8,"id":"9aa53dc9_c18739d6","line":68,"updated":"2015-04-06 16:42:42.000000000","message":"Remove firewall related constants once this patchset gets merged.\nhttps://review.openstack.org/#/c/168709/","commit_id":"e90969d9f6386c8abe004b0a4ec08f73d852dadd"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"47d573d802341ae132501a413ee413d2b0f022e6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"FWAAS_DENY \u003d \"deny\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# TODO(romilg): Remove L3 protocol name constants because for instance, there"},{"line_number":74,"context_line":"# exists a constant already in common/constants.py for tcp - PROTO_NAME_TCP"},{"line_number":75,"context_line":"# L3 Protocol name constants"},{"line_number":76,"context_line":"TCP \u003d \"tcp\""},{"line_number":77,"context_line":"UDP \u003d \"udp\""}],"source_content_type":"text/x-python","patch_set":8,"id":"da9b358b_77df980d","line":74,"updated":"2015-04-01 11:43:44.000000000","message":"https://review.openstack.org/#/c/168709/","commit_id":"e90969d9f6386c8abe004b0a4ec08f73d852dadd"}]}