)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"0e987f05dde4dabf17568b1567dd8bcc0ea76e33","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2015-03-24 13:36:06 -0400"},{"line_number":4,"context_line":"Commit:     Robert Li \u003cbaoli@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-24 13:36:06 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"allow neutron-keepalived-state-change to run when installed with devstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3abd1c173121dc8abb5738d1879db8ac9a98b690"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6ced46_92ab86d5","line":6,"updated":"2015-03-24 17:42:04.000000000","message":"I\u0027m not seeing issues on my local setups (But not stating that there isn\u0027t one), still, could you please expand the commit message to explain what\u0027s wrong?","commit_id":"a9c25094f93e0c3211b3ae4ee2f09d8787484c43"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"406fd75b097310b5f682c00f9c6fb7e6309820f6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2015-03-24 13:36:06 -0400"},{"line_number":4,"context_line":"Commit:     Robert Li \u003cbaoli@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-24 13:36:06 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"allow neutron-keepalived-state-change to run when installed with devstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I3abd1c173121dc8abb5738d1879db8ac9a98b690"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6ced46_dff07e00","line":6,"in_reply_to":"1a6ced46_92ab86d5","updated":"2015-03-25 14:40:10.000000000","message":"Sorry, forgot to add the bug id in the commit message. Details can be found from the bug report.\n\nAlso I was wondering if it makes sense to add the HA support into devstack. For example, by default, ha is disabled. But one should be able to enable it from devstack. it can be addressed by a different issue.","commit_id":"a9c25094f93e0c3211b3ae4ee2f09d8787484c43"}],"etc/neutron/rootwrap.d/l3.filters":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"b5a3461d395780a643dc0f946081c0eb7922657b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"# keepalived state change monitor"},{"line_number":55,"context_line":"keepalived_state_change: CommandFilter, neutron-keepalived-state-change, root"},{"line_number":56,"context_line":"# If installed from source (say, by devstack), the prefix will be"},{"line_number":57,"context_line":"# /usr/local instead of /usr/bin."},{"line_number":58,"context_line":"keepalived_state_change_local: CommandFilter, /usr/local/bin/neutron-keepalived-state-change, root"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"da9b358b_9f6938c1","line":57,"updated":"2015-03-31 15:23:34.000000000","message":"Last time I looked in to oslo rootwrap it handled local paths correctly (Like in line 55). I also don\u0027t have this problem in my devstack Fedora or Ubuntu VMs.","commit_id":"2feadee46711da2cfb525539b9e0f87cca0b4e17"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"c8959143854a0ce6144d5f0c33dd56bcd186f0b1","unresolved":false,"context_lines":[{"line_number":54,"context_line":"# keepalived state change monitor"},{"line_number":55,"context_line":"keepalived_state_change: CommandFilter, neutron-keepalived-state-change, root"},{"line_number":56,"context_line":"# If installed from source (say, by devstack), the prefix will be"},{"line_number":57,"context_line":"# /usr/local instead of /usr/bin."},{"line_number":58,"context_line":"keepalived_state_change_local: CommandFilter, /usr/local/bin/neutron-keepalived-state-change, root"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9aa53dc9_86bfccfa","line":57,"in_reply_to":"da9b358b_7439d6a3","updated":"2015-04-07 19:37:35.000000000","message":"You should modify rootwrap.conf as discussed in IRC, as to save some time to whoever introduces another process next.","commit_id":"2feadee46711da2cfb525539b9e0f87cca0b4e17"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"f291533f5085e926a249ee9037e49ee8bb65ab59","unresolved":false,"context_lines":[{"line_number":54,"context_line":"# keepalived state change monitor"},{"line_number":55,"context_line":"keepalived_state_change: CommandFilter, neutron-keepalived-state-change, root"},{"line_number":56,"context_line":"# If installed from source (say, by devstack), the prefix will be"},{"line_number":57,"context_line":"# /usr/local instead of /usr/bin."},{"line_number":58,"context_line":"keepalived_state_change_local: CommandFilter, /usr/local/bin/neutron-keepalived-state-change, root"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"da9b358b_bf387c3e","line":57,"in_reply_to":"da9b358b_9f6938c1","updated":"2015-03-31 15:31:24.000000000","message":"check etc/rootwrap.conf and see if /usr/local/bin is included in the  exec_dirs.\n\nline 23 of this this file does the same for metadata_proxy.\n\nI think that another solution is to modify etc/rootwrap.conf to add /usr/local/bin there. But cleanup would be required in the filters conf files.","commit_id":"2feadee46711da2cfb525539b9e0f87cca0b4e17"},{"author":{"_account_id":10257,"name":"Sridhar Gaddam","email":"sgaddam@redhat.com","username":"sridhargaddam"},"change_message_id":"21009461243242b1d98c72f457c5d23f4c1a958b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"# keepalived state change monitor"},{"line_number":55,"context_line":"keepalived_state_change: CommandFilter, neutron-keepalived-state-change, root"},{"line_number":56,"context_line":"# If installed from source (say, by devstack), the prefix will be"},{"line_number":57,"context_line":"# /usr/local instead of /usr/bin."},{"line_number":58,"context_line":"keepalived_state_change_local: CommandFilter, /usr/local/bin/neutron-keepalived-state-change, root"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"da9b358b_7439d6a3","line":57,"in_reply_to":"da9b358b_bf387c3e","updated":"2015-04-01 11:06:28.000000000","message":"I was facing the same issue in my devstack setup. \nJust when I was about to submit a patch, saw that Robert has already addressed it in this patch. Thanks Robert for fixing it.","commit_id":"2feadee46711da2cfb525539b9e0f87cca0b4e17"}],"etc/rootwrap.conf":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"2bfcb9f5f170e97efbb7b147f289af1bcedf31dd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# explicitely specify a full path (separated by \u0027,\u0027)"},{"line_number":11,"context_line":"# If not specified, defaults to system PATH environment variable."},{"line_number":12,"context_line":"# These directories MUST all be only writeable by root !"},{"line_number":13,"context_line":"exec_dirs\u003d/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Enable logging to syslog"},{"line_number":16,"context_line":"# Default value is False"}],"source_content_type":"text/plain","patch_set":7,"id":"7aaa499b_3d86afb9","line":13,"updated":"2015-04-14 16:52:47.000000000","message":"I would like some security expert to confirm that this is not a security issue.","commit_id":"a4d7a319b19feed9f7eab72212ba12d304e2a1e2"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"e1a31040cc19292a9f16e402bfab4a121c67f6ea","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# explicitely specify a full path (separated by \u0027,\u0027)"},{"line_number":11,"context_line":"# If not specified, defaults to system PATH environment variable."},{"line_number":12,"context_line":"# These directories MUST all be only writeable by root !"},{"line_number":13,"context_line":"exec_dirs\u003d/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Enable logging to syslog"},{"line_number":16,"context_line":"# Default value is False"}],"source_content_type":"text/plain","patch_set":7,"id":"7aaa499b_40106e4e","line":13,"in_reply_to":"7aaa499b_3d86afb9","updated":"2015-04-14 16:55:32.000000000","message":"Agree with Henry. Adding Robert Collins to get his input from the security perspective.","commit_id":"a4d7a319b19feed9f7eab72212ba12d304e2a1e2"}]}