)]}'
{"quantum/tests/unit/test_l3_plugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"e9a514631a041a9a18a3fa3ae9eb6ecb5b2674c5","unresolved":false,"context_lines":[{"line_number":791,"context_line":"        res \u003d req.get_response(self._api_for_resource(\u0027router\u0027))"},{"line_number":792,"context_line":"        self.assertEqual(res.status_int, 404)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    def test_router_delete_port_exsited_returns_409(self):"},{"line_number":795,"context_line":"        fmt \u003d \u0027json\u0027"},{"line_number":796,"context_line":"        with self.subnet() as subnet:"},{"line_number":797,"context_line":"            res \u003d self._create_router(fmt, _uuid())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2Fxjs%3D","line":794,"updated":"2012-11-26 10:40:59.000000000","message":"You\u0027re not raising when deleting a port here, but when deleting a router\n\nAlso Typo \"exsited\"","commit_id":"b6f5d88f146128a97c6a41cc06eee0244d8c30b1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"2b3760e0d7a42c5c6973e5cad49f2dcc39ca0fc1","unresolved":false,"context_lines":[{"line_number":791,"context_line":"        res \u003d req.get_response(self._api_for_resource(\u0027router\u0027))"},{"line_number":792,"context_line":"        self.assertEqual(res.status_int, 404)"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":"    def test_router_delete_port_exsited_returns_409(self):"},{"line_number":795,"context_line":"        fmt \u003d \u0027json\u0027"},{"line_number":796,"context_line":"        with self.subnet() as subnet:"},{"line_number":797,"context_line":"            res \u003d self._create_router(fmt, _uuid())"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2Fxd8%3D","line":794,"in_reply_to":"AAAAMH%2F%2Fxjs%3D","updated":"2012-11-26 14:10:02.000000000","message":"Sorry, I didn\u0027t totally understand your first word. Is this means the name should be \u0027test_router_delete_with port_existed_returns_409\u0027?\n\nDone for typo.","commit_id":"b6f5d88f146128a97c6a41cc06eee0244d8c30b1"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"e9a514631a041a9a18a3fa3ae9eb6ecb5b2674c5","unresolved":false,"context_lines":[{"line_number":808,"context_line":"                                          None)"},{"line_number":809,"context_line":"            self._delete(\u0027routers\u0027, router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"    def test_router_delete_floatingip_exsited_returns_409(self):"},{"line_number":812,"context_line":"        with self.port() as p:"},{"line_number":813,"context_line":"            private_sub \u003d {\u0027subnet\u0027: {\u0027id\u0027:"},{"line_number":814,"context_line":"                                      p[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027]}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2Fxjk%3D","line":811,"updated":"2012-11-26 10:40:59.000000000","message":"Typo \"existed\"","commit_id":"b6f5d88f146128a97c6a41cc06eee0244d8c30b1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"2b3760e0d7a42c5c6973e5cad49f2dcc39ca0fc1","unresolved":false,"context_lines":[{"line_number":808,"context_line":"                                          None)"},{"line_number":809,"context_line":"            self._delete(\u0027routers\u0027, router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":"    def test_router_delete_floatingip_exsited_returns_409(self):"},{"line_number":812,"context_line":"        with self.port() as p:"},{"line_number":813,"context_line":"            private_sub \u003d {\u0027subnet\u0027: {\u0027id\u0027:"},{"line_number":814,"context_line":"                                      p[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027subnet_id\u0027]}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2Fxd4%3D","line":811,"in_reply_to":"AAAAMH%2F%2Fxjk%3D","updated":"2012-11-26 14:10:02.000000000","message":"Done","commit_id":"b6f5d88f146128a97c6a41cc06eee0244d8c30b1"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"e9a514631a041a9a18a3fa3ae9eb6ecb5b2674c5","unresolved":false,"context_lines":[{"line_number":830,"context_line":"                floatingip \u003d self.deserialize(fmt, res)"},{"line_number":831,"context_line":"                self._remove_external_gateway_from_router("},{"line_number":832,"context_line":"                    r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":833,"context_line":"                    public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":834,"context_line":"                self._delete(\u0027routers\u0027, r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":835,"context_line":"                             expected_code\u003dexc.HTTPConflict.code)"},{"line_number":836,"context_line":"                # Cleanup"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2Fxjg%3D","line":833,"updated":"2012-11-26 10:40:59.000000000","message":"This would raise if your other patch is merged in the meanwhile... wouldn\u0027t it?","commit_id":"b6f5d88f146128a97c6a41cc06eee0244d8c30b1"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"2b3760e0d7a42c5c6973e5cad49f2dcc39ca0fc1","unresolved":false,"context_lines":[{"line_number":830,"context_line":"                floatingip \u003d self.deserialize(fmt, res)"},{"line_number":831,"context_line":"                self._remove_external_gateway_from_router("},{"line_number":832,"context_line":"                    r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":833,"context_line":"                    public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":834,"context_line":"                self._delete(\u0027routers\u0027, r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":835,"context_line":"                             expected_code\u003dexc.HTTPConflict.code)"},{"line_number":836,"context_line":"                # Cleanup"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2Fxd0%3D","line":833,"in_reply_to":"AAAAMH%2F%2Fxjg%3D","updated":"2012-11-26 14:10:02.000000000","message":"Thanks for notice this.","commit_id":"b6f5d88f146128a97c6a41cc06eee0244d8c30b1"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":726,"context_line":"                    r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":727,"context_line":"                    n[\u0027network\u0027][\u0027id\u0027], expected_code\u003dexc.HTTPBadRequest.code)"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    def test_router_remove_router_interface_inuse_returns_409(self):"},{"line_number":730,"context_line":"        with self.router() as r:"},{"line_number":731,"context_line":"            with self.subnet() as s:"},{"line_number":732,"context_line":"                self._router_interface_action(\u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F%2BmE%3D","line":729,"updated":"2012-12-04 03:44:13.000000000","message":"Minor nit: Since you are changing names here, I would prefer the name: test_router_remove_inuse_interface_returns_409\nIt\u0027s easier to understand what the test is doing versus the currently proposed name.","commit_id":"49f0b536eccddad43befe7f6cb9afeb72bf84857"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"2b3760e0d7a42c5c6973e5cad49f2dcc39ca0fc1","unresolved":false,"context_lines":[{"line_number":726,"context_line":"                    r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":727,"context_line":"                    n[\u0027network\u0027][\u0027id\u0027], expected_code\u003dexc.HTTPBadRequest.code)"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    def test_router_remove_router_interface_inuse_returns_409(self):"},{"line_number":730,"context_line":"        with self.router() as r:"},{"line_number":731,"context_line":"            with self.subnet() as s:"},{"line_number":732,"context_line":"                self._router_interface_action(\u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F%2BiU%3D","line":729,"in_reply_to":"AAAAMX%2F%2F%2BkY%3D","updated":"2012-12-04 06:20:24.000000000","message":"Sumit, second thinking. This format is similar with other test-case: test_[resource]_[action]_[some case]_return_[error code].\nAfter this case, we have a lot of test_router_remove_router_interface_*.  Becasue we have a lot of test case, this is good for other developer find test-case. Thanks. Alex","commit_id":"49f0b536eccddad43befe7f6cb9afeb72bf84857"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"2b3760e0d7a42c5c6973e5cad49f2dcc39ca0fc1","unresolved":false,"context_lines":[{"line_number":726,"context_line":"                    r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":727,"context_line":"                    n[\u0027network\u0027][\u0027id\u0027], expected_code\u003dexc.HTTPBadRequest.code)"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    def test_router_remove_router_interface_inuse_returns_409(self):"},{"line_number":730,"context_line":"        with self.router() as r:"},{"line_number":731,"context_line":"            with self.subnet() as s:"},{"line_number":732,"context_line":"                self._router_interface_action(\u0027add\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F%2BkY%3D","line":729,"in_reply_to":"AAAAMX%2F%2F%2BmE%3D","updated":"2012-12-04 04:56:18.000000000","message":"Done","commit_id":"49f0b536eccddad43befe7f6cb9afeb72bf84857"}]}