)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"4aaf73b7d5768c638b7e49178ba23a9121b1f917","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove use of contextlib.nested"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed use of contextlib.nested call from codebase, as it has been"},{"line_number":10,"context_line":"deprecated since Python 2.7."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is the first patch in a series for removing use of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3acd31a7_139e1163","line":9,"updated":"2015-05-05 13:45:52.000000000","message":"imo, your commit does not highlight the important points (in bug description):\n\n* not py3K compliant\n* buggy!\n\nThe change should be associated to neutron py3K spec[1]\n\n[1]https://review.openstack.org/172962","commit_id":"34ac6914d600079e4787ac483c2cdcbb3e08030e"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"9eb976b0340fe7a13f53d9b99a291bc1493cf89b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove use of contextlib.nested"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed use of contextlib.nested call from codebase, as it has been"},{"line_number":10,"context_line":"deprecated since Python 2.7."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is the first patch in a series for removing use of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1aca2d91_88b490f2","line":9,"in_reply_to":"3acd31a7_139e1163","updated":"2015-05-07 07:00:48.000000000","message":"Added above mentioned points in the commit message. \n\nneutron py3K spec is still under review, so we can refer this patch later in the spec to keep track the issues that have been addressed by this patch, once the spec is approved.","commit_id":"34ac6914d600079e4787ac483c2cdcbb3e08030e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f3e1f7bf3bea1b704d218b84c9e4d961c48d1af6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Added hacking check to catch if any new instances are added to"},{"line_number":23,"context_line":"the codebase."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Line continuation markers (e.g. \u0027\\\u0027) had to be used or syntax"},{"line_number":26,"context_line":"errors were thrown. While using parentheses is the preferred way"},{"line_number":27,"context_line":"for multiple line statements, but in case of long with statements"},{"line_number":28,"context_line":"backslashes are acceptable."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1aca2d91_383fbd88","line":25,"updated":"2015-05-08 21:42:59.000000000","message":"As long as the \u0027\\\u0027 is just used between multiple context managers and not just arbitrarily (which I think you\u0027ve done) I think this is necessary and ok.","commit_id":"4cd1600b2548b3d15cdbc9dcc368c375d2f7fee9"}],"neutron/tests/unit/_test_extension_portbindings.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b77d7200acca28eac13c0a8f38413d7272e91388","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        host_arg \u003d {portbindings.HOST_ID: self.hostname}"},{"line_number":216,"context_line":"        with self.port(name\u003d\u0027name1\u0027,"},{"line_number":217,"context_line":"                       arg_list\u003d(portbindings.HOST_ID,),"},{"line_number":218,"context_line":"                       **host_arg), self.port(name\u003d\u0027name2\u0027):"},{"line_number":219,"context_line":"            ctx \u003d context.get_admin_context()"},{"line_number":220,"context_line":"            ports \u003d self._list(\u0027ports\u0027, neutron_context\u003dctx)[\u0027ports\u0027]"},{"line_number":221,"context_line":"            self.assertEqual(2, len(ports))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_bc265366","line":218,"updated":"2015-05-07 17:50:59.000000000","message":"Nit: the second context is a bit hard to spot since it kind of looks like part of arg_list. (We now have a general problem of formatting nested contexts to be nicely readable. It annoys me a little but I am not going block reviews on this kind of thing.)","commit_id":"4cd1600b2548b3d15cdbc9dcc368c375d2f7fee9"}],"neutron/tests/unit/agent/linux/test_daemon.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f3e1f7bf3bea1b704d218b84c9e4d961c48d1af6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                                  daemon.setgid, \u0027321\u0027)"},{"line_number":70,"context_line":"                log_critical.assert_once_with(mock.ANY)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @mock.patch.object(os, \u0027setgroups\u0027)"},{"line_number":73,"context_line":"    @mock.patch.object(daemon, \u0027setgid\u0027)"},{"line_number":74,"context_line":"    @mock.patch.object(daemon, \u0027setuid\u0027)"},{"line_number":75,"context_line":"    def test_drop_no_privileges(self, mock_setuid, mock_setgid,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aca2d91_5865d9b2","line":72,"updated":"2015-05-08 21:42:59.000000000","message":"Thanks for using the decorator version where possible.  I think it cleans things up quite a bit.","commit_id":"4cd1600b2548b3d15cdbc9dcc368c375d2f7fee9"}]}