)]}'
{"plugins/openvswitch-plugin/README":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"ee7847bf93cb837dac990b19409841ebe4576352","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# -- Database config."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The Open vSwitch quantum service requires access to a mysql database or any "},{"line_number":59,"context_line":"other database engine supported by sqlalchemy in order to store configuration "},{"line_number":60,"context_line":"and mappings that will be used by the agent. "},{"line_number":61,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAACn%2F%2F938%3D","line":58,"updated":"2011-11-16 20:01:43.000000000","message":"trailing whitespace","commit_id":"cc43a89f222b50463b8aa57c95ced9b9805ea53a"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The Open vSwitch quantum service requires access to a mysql database or any"},{"line_number":59,"context_line":"other database engine supported by sqlalchemy in order to store configuration "},{"line_number":60,"context_line":"and mappings that will be used by the agent. "},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"A new database, \"ovs_quantum\", should be created, and servers running the"},{"line_number":63,"context_line":"ovs quantum agent must be able to communicate with the host running the"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAACn%2F%2F8Nc%3D","line":60,"updated":"2011-11-29 00:02:40.000000000","message":"trailing spaces...","commit_id":"70434d2726be37386fad8f65a518613394dc6b8e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"The Open vSwitch quantum service requires access to a mysql database or any"},{"line_number":59,"context_line":"other database engine supported by sqlalchemy in order to store configuration "},{"line_number":60,"context_line":"and mappings that will be used by the agent. "},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"A new database, \"ovs_quantum\", should be created, and servers running the"},{"line_number":63,"context_line":"ovs quantum agent must be able to communicate with the host running the"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAC3%2F%2F%2BXU%3D","line":60,"in_reply_to":"AAAACn%2F%2F8Nc%3D","updated":"2011-12-08 16:54:22.000000000","message":"Should we worry about them even in non-python files? just asking...","commit_id":"70434d2726be37386fad8f65a518613394dc6b8e"}],"plugins/openvswitch-plugin/etc/ovs_quantum_plugin.ini":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"ee7847bf93cb837dac990b19409841ebe4576352","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DATABASE]"},{"line_number":2,"context_line":"sql_connection \u003d sqlite://"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[OVS]"},{"line_number":5,"context_line":"integration-bridge \u003d br-int"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAACn%2F%2F9xk%3D","line":2,"updated":"2011-11-16 23:32:31.000000000","message":"I like this better when it was filled in with an example ;)","commit_id":"70434d2726be37386fad8f65a518613394dc6b8e"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DATABASE]"},{"line_number":2,"context_line":"sql_connection \u003d sqlite://"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[OVS]"},{"line_number":5,"context_line":"integration-bridge \u003d br-int"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAC3%2F%2F91A%3D","line":2,"in_reply_to":"AAAACn%2F%2F76Q%3D","updated":"2011-12-11 07:57:45.000000000","message":"That makes sense, but I still agree with brad.  The sqlite line may make the tests pass, but it is bad for anyone who wants an example for what the line should like like to actually get things working (in-memory DB can\u0027t work, since the agent must also access the DB).  \n\nI\u0027d prefer something like: mysql://root:nova@127.0.0.1:3336/ovs_quantum , at least in a comment in the config file.  It would be nice the comment also noted that this line MUST be changed to actually run the plugin.","commit_id":"70434d2726be37386fad8f65a518613394dc6b8e"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"6be18b0c47582dbd48eb55b1d6c45af06649905e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DATABASE]"},{"line_number":2,"context_line":"sql_connection \u003d sqlite://"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[OVS]"},{"line_number":5,"context_line":"integration-bridge \u003d br-int"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAACn%2F%2F76Q%3D","line":2,"in_reply_to":"AAAACn%2F%2F8NU%3D","updated":"2011-11-30 09:16:41.000000000","message":"ovs_plugin test use this file and database connection to perform the tests. Without a working database connection (like before mysql://root:nova@127.0.0.1), ovs_plugins tests fails because tests are not able to connect to the database. To solve this, i just put a in-memory db. \n\nMaybe, it would be possible to modified tests to use an \"hardcoded\" in memory database and put a full \"working\" example in this file.","commit_id":"70434d2726be37386fad8f65a518613394dc6b8e"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DATABASE]"},{"line_number":2,"context_line":"sql_connection \u003d sqlite://"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[OVS]"},{"line_number":5,"context_line":"integration-bridge \u003d br-int"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAACn%2F%2F8NU%3D","line":2,"in_reply_to":"AAAACn%2F%2F9uw%3D","updated":"2011-11-29 00:02:40.000000000","message":"Hi Ghe, can you explain your comment about tests a bit more.  Does sqlalchemy default to an in memory db or something such that the above sql_connection text allows the tests to pass?","commit_id":"70434d2726be37386fad8f65a518613394dc6b8e"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"6be18b0c47582dbd48eb55b1d6c45af06649905e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DATABASE]"},{"line_number":2,"context_line":"sql_connection \u003d sqlite://"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[OVS]"},{"line_number":5,"context_line":"integration-bridge \u003d br-int"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAACn%2F%2F9uw%3D","line":2,"in_reply_to":"AAAACn%2F%2F9xk%3D","updated":"2011-11-17 06:12:50.000000000","message":"Tests use this config file. If filled with a non-working example they file. Anyway on the README file there is a filled example.","commit_id":"70434d2726be37386fad8f65a518613394dc6b8e"}],"plugins/openvswitch-plugin/lib/quantum/plugins/openvswitch/agent/ovs_quantum_agent.py":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"ee7847bf93cb837dac990b19409841ebe4576352","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        plugin \u003d OVSQuantumAgent(integ_br)"},{"line_number":264,"context_line":"        plugin.daemon_loop(db)"},{"line_number":265,"context_line":"    finally:"},{"line_number":266,"context_line":"        pass"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    sys.exit(0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACn%2F%2F9%2BA%3D","line":266,"updated":"2011-11-16 16:50:30.000000000","message":"I think we can remove the finally clause now..","commit_id":"77d1fe9682a9b07aad29dd7a8d56e914ba0e76f3"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"ee7847bf93cb837dac990b19409841ebe4576352","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                (db.engine.url.database, db.engine.url.host))"},{"line_number":263,"context_line":"        plugin \u003d OVSQuantumAgent(integ_br)"},{"line_number":264,"context_line":"        plugin.daemon_loop(db)"},{"line_number":265,"context_line":"    finally:"},{"line_number":266,"context_line":"        pass"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    sys.exit(0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAACn%2F%2F934%3D","line":265,"updated":"2011-11-16 20:01:43.000000000","message":"Don\u0027t need the finally anymore","commit_id":"cc43a89f222b50463b8aa57c95ced9b9805ea53a"}]}
