)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"35f5907092771514c406667ca50fe6b71bd10faa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add log for metadata DB reset"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a debug log to remind user the metadata does not need DB connection,"},{"line_number":10,"context_line":"so reset it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8cbb04209cdc1370f14179e568536ad56cb8c559"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da9b358b_1d032f44","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":11},"updated":"2015-03-30 10:17:47.000000000","message":"it seems that the commit message needs an update.\nit isn\u0027t debug level anymore.","commit_id":"01a9133132b393d6a04f46c53af2150f119d9883"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"94660ccbb7404f3c2eed932536922ce28199fc4f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add log for metadata DB reset"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a debug log to remind user the metadata does not need DB connection,"},{"line_number":10,"context_line":"so reset it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8cbb04209cdc1370f14179e568536ad56cb8c559"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da9b358b_628cb47f","line":9,"in_reply_to":"da9b358b_1d032f44","updated":"2015-03-31 02:26:31.000000000","message":"Done, thanks","commit_id":"01a9133132b393d6a04f46c53af2150f119d9883"}],"neutron/agent/metadata_agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f167fcc7d8163a46977772cea336fdfff4eec564","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    config.init(sys.argv[1:])"},{"line_number":37,"context_line":"    config.setup_logging()"},{"line_number":38,"context_line":"    utils.log_opt_values(LOG)"},{"line_number":39,"context_line":"    # metadata agent need not connect DB"},{"line_number":40,"context_line":"    LOG.debug(\"Clean DB connection for metadata\")"},{"line_number":41,"context_line":"    cfg.CONF.set_override(\"connection\", \"\", \"database\")"},{"line_number":42,"context_line":"    proxy \u003d agent.UnixDomainMetadataProxy(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_c2ce055a","line":39,"updated":"2015-03-30 09:07:31.000000000","message":"Consider:\nif cfg.CONF.database.connection !\u003d \u0027\u0027:\n    LOG.warning(_LW(\"Clean DB connection for metadata\"))\n    cfg.CONF.set_override(\"connection\", \"\", \"database\")\n\nMaybe we should consider using:\ncfg.CONF.set_default(name\u003d\u0027connection\u0027, default\u003d\u0027\u0027, group\u003d\u0027database\u0027)\nBut I am not familiar with that :)","commit_id":"079c005e0c422bdfe0446f755357240d56f35ca6"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"cf014bc44e6c4a39df45cc58b9aac2fd7056d5c1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    config.init(sys.argv[1:])"},{"line_number":37,"context_line":"    config.setup_logging()"},{"line_number":38,"context_line":"    utils.log_opt_values(LOG)"},{"line_number":39,"context_line":"    # metadata agent need not connect DB"},{"line_number":40,"context_line":"    LOG.debug(\"Clean DB connection for metadata\")"},{"line_number":41,"context_line":"    cfg.CONF.set_override(\"connection\", \"\", \"database\")"},{"line_number":42,"context_line":"    proxy \u003d agent.UnixDomainMetadataProxy(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_bd5b2454","line":39,"in_reply_to":"da9b358b_c2ce055a","updated":"2015-03-30 09:51:52.000000000","message":"Hi Gary,\n\nThanks for your comment, I think set_override is a common method to change default value, so I keep it here.","commit_id":"079c005e0c422bdfe0446f755357240d56f35ca6"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"e5968d23c83ca39234e6aa98b6a80b2ea604e8af","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    config.setup_logging()"},{"line_number":38,"context_line":"    utils.log_opt_values(LOG)"},{"line_number":39,"context_line":"    # metadata agent need not connect DB"},{"line_number":40,"context_line":"    LOG.debug(\"Clean DB connection for metadata\")"},{"line_number":41,"context_line":"    cfg.CONF.set_override(\"connection\", \"\", \"database\")"},{"line_number":42,"context_line":"    proxy \u003d agent.UnixDomainMetadataProxy(cfg.CONF)"},{"line_number":43,"context_line":"    proxy.run()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_c2a04593","line":40,"updated":"2015-03-30 09:06:44.000000000","message":"nit: i would call it \"Override and clean DB connection configuration for metadata agent\"","commit_id":"079c005e0c422bdfe0446f755357240d56f35ca6"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"cf014bc44e6c4a39df45cc58b9aac2fd7056d5c1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    config.setup_logging()"},{"line_number":38,"context_line":"    utils.log_opt_values(LOG)"},{"line_number":39,"context_line":"    # metadata agent need not connect DB"},{"line_number":40,"context_line":"    LOG.debug(\"Clean DB connection for metadata\")"},{"line_number":41,"context_line":"    cfg.CONF.set_override(\"connection\", \"\", \"database\")"},{"line_number":42,"context_line":"    proxy \u003d agent.UnixDomainMetadataProxy(cfg.CONF)"},{"line_number":43,"context_line":"    proxy.run()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_1d445072","line":40,"in_reply_to":"da9b358b_c2a04593","updated":"2015-03-30 09:51:52.000000000","message":"Thanks. Done.","commit_id":"079c005e0c422bdfe0446f755357240d56f35ca6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"18830b1017e92bb53dfb5ab4622ef4a4f4dfd271","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.agent.metadata import agent"},{"line_number":22,"context_line":"from neutron.agent.metadata import config as metadata_conf"},{"line_number":23,"context_line":"from neutron.common import config"},{"line_number":24,"context_line":"from neutron.common import utils"},{"line_number":25,"context_line":"from neutron.openstack.common.cache import cache"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_86e24cd4","line":24,"updated":"2015-03-30 12:01:32.000000000","message":"please add:\nfrom neutron.i18n import _LW","commit_id":"01a9133132b393d6a04f46c53af2150f119d9883"}]}