)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a4c6cfbecf4af937a68053bc122bffc88005a88e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Kill hostname validation for subnet:dns_nameservers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DNS servers that are hostnames seem like a bad idea. They are also not"},{"line_number":10,"context_line":"supported by base_db_plugin_v2 [1] anyway, so there is no big reason to"},{"line_number":11,"context_line":"pass them thru API validation only to receive InvalidInput later inside"},{"line_number":12,"context_line":"plugin code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aca2d91_f86f0529","line":9,"updated":"2015-05-08 22:11:26.000000000","message":"There is nothing inherently wrong with hostnames as DNS servers.  It isn\u0027t supported in this context but I\u0027ve seen it before in other contexts.\n\nWhat obviously doesn\u0027t work is using names as dns servers that require a dns lookup to resolve, obviously, chicken-and-the-egg.  However, hostnames don\u0027t necessarily satisfy this condition.  They could be resolved through other means.  I\u0027ve encountered systems that use /etc/hosts to resolve the names for DNS servers.  It isn\u0027t common but it happens.\n\nSo, the commit message is just a little misleading.","commit_id":"fd162a82776d64af9abc5595d1b8d2473dfce8f2"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a4c6cfbecf4af937a68053bc122bffc88005a88e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Kill hostname validation for subnet:dns_nameservers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DNS servers that are hostnames seem like a bad idea. They are also not"},{"line_number":10,"context_line":"supported by base_db_plugin_v2 [1] anyway, so there is no big reason to"},{"line_number":11,"context_line":"pass them thru API validation only to receive InvalidInput later inside"},{"line_number":12,"context_line":"plugin code."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aca2d91_789775ec","line":10,"updated":"2015-05-08 22:11:26.000000000","message":"Maybe this should change?  I\u0027m not saying it should.  To boot a new VM image supporting names as the dns server would require some stuff baked in to the VM image.  It isn\u0027t a good idea and I doubt that anyone would go through that trouble.  So, forget I said this.  :)","commit_id":"fd162a82776d64af9abc5595d1b8d2473dfce8f2"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a329e3fd7f9bdbb40cf745501fb1ff7fc786fec1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"pass them thru API validation only to receive InvalidInput later inside"},{"line_number":12,"context_line":"plugin code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/db_base_plugin_v2.py#n1049"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2db00fe266fe0748d0e6327fbad22fa16b751da8"},{"line_number":17,"context_line":"Related-Bug: #1396932"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aca2d91_f82705c8","line":14,"updated":"2015-05-08 22:16:20.000000000","message":"One more thing:  Since this URL references a moving branch, the line number, file number, and possibly everything in this reference will be meaningless at some point.  Please try to get static references.","commit_id":"fd162a82776d64af9abc5595d1b8d2473dfce8f2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d23abb96c9e918b13c27283ff8d115594fbe2d6f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"pass them thru API validation only to receive InvalidInput later inside"},{"line_number":12,"context_line":"plugin code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/db_base_plugin_v2.py#n1049"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2db00fe266fe0748d0e6327fbad22fa16b751da8"},{"line_number":17,"context_line":"Related-Bug: #1396932"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9af37de9_96239805","line":14,"in_reply_to":"1aca2d91_f82705c8","updated":"2015-05-11 12:18:27.000000000","message":"I wonder how I can get static references for line pointers. Do you have an example?","commit_id":"fd162a82776d64af9abc5595d1b8d2473dfce8f2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"21786f799c4f6e0046d4ddc21f1278aff851ef24","unresolved":false,"context_lines":[{"line_number":11,"context_line":"pass them thru API validation only to receive InvalidInput later inside"},{"line_number":12,"context_line":"plugin code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/db_base_plugin_v2.py#n1049"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2db00fe266fe0748d0e6327fbad22fa16b751da8"},{"line_number":17,"context_line":"Related-Bug: #1396932"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9af37de9_8f4936d3","line":14,"in_reply_to":"9af37de9_2f312aa3","updated":"2015-05-11 15:25:50.000000000","message":"Ah right. Thanks Cedric!","commit_id":"fd162a82776d64af9abc5595d1b8d2473dfce8f2"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c9d9a7ed8fe723130c1ca1e196727ccf71bf49a9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"pass them thru API validation only to receive InvalidInput later inside"},{"line_number":12,"context_line":"plugin code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1]: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/db_base_plugin_v2.py#n1049"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I2db00fe266fe0748d0e6327fbad22fa16b751da8"},{"line_number":17,"context_line":"Related-Bug: #1396932"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9af37de9_2f312aa3","line":14,"in_reply_to":"9af37de9_96239805","updated":"2015-05-11 15:14:57.000000000","message":"We should use a specific commit not a (moving) branch:\n\n  https://github.com/openstack/neutron/blob/62ccf394c21eed132277b87b2428632efb07f1b0/neutron/db/db_base_plugin_v2.py#L1049","commit_id":"fd162a82776d64af9abc5595d1b8d2473dfce8f2"}],"neutron/api/v2/attributes.py":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"c82e2dda8b29603565e35bca9391dc52337729e6","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    hosts \u003d []"},{"line_number":269,"context_line":"    for host in data:"},{"line_number":270,"context_line":"        # This may be an IP address only"},{"line_number":271,"context_line":"        msg \u003d _validate_ip_address(host)"},{"line_number":272,"context_line":"        if msg:"},{"line_number":273,"context_line":"            msg \u003d _(\"\u0027%(host)s\u0027 is not a valid nameserver. %(msg)s\") % {"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_480d583d","line":270,"updated":"2015-03-30 22:00:32.000000000","message":"Whit this change, the working changes as well:\n\"This must/should be an IP address only\"","commit_id":"af434127b8d007e3b818eb521b5c4cef69f0c58a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"73444ffc23e378d70653ed2afcf69ed85a5af9b9","unresolved":false,"context_lines":[{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    hosts \u003d []"},{"line_number":269,"context_line":"    for host in data:"},{"line_number":270,"context_line":"        # This may be an IP address only"},{"line_number":271,"context_line":"        msg \u003d _validate_ip_address(host)"},{"line_number":272,"context_line":"        if msg:"},{"line_number":273,"context_line":"            msg \u003d _(\"\u0027%(host)s\u0027 is not a valid nameserver. %(msg)s\") % {"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_6710804f","line":270,"in_reply_to":"da9b358b_480d583d","updated":"2015-04-10 17:12:19.000000000","message":"Done","commit_id":"af434127b8d007e3b818eb521b5c4cef69f0c58a"}]}