)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"109e66f75e6a97d723c4dde3b667d2ff7b049226","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check ProcessMonitor running flag before checking processes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have a testing issue, where process monitor attempts to"},{"line_number":10,"context_line":"respawn processes even if we ordered it to stop."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is due to the loop design, and the checking interval,"},{"line_number":13,"context_line":"if the stop flag is set during a long check interval, the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_33d89853","line":10,"updated":"2015-12-17 05:56:42.000000000","message":"??","commit_id":"90ca19633168f9ef41e5c2b37770dbeebd39cc3b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"2b0b77f7ed3c54182a9e98985bca3e7f04ccf807","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check ProcessMonitor running flag before checking processes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have a testing issue, where process monitor attempts to"},{"line_number":10,"context_line":"respawn processes even if we ordered it to stop."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is due to the loop design, and the checking interval,"},{"line_number":13,"context_line":"if the stop flag is set during a long check interval, the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_3e9fb060","line":10,"updated":"2015-06-22 19:38:58.000000000","message":"Is this patch still necessary? I remember seeing another one that just stopped the ProcessMonitor IIRC","commit_id":"90ca19633168f9ef41e5c2b37770dbeebd39cc3b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c43b89a003e8cdf8e42dd866984c23c42a5c550e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"In this new loop the flag is checked right before attempting"},{"line_number":17,"context_line":"to start a checking thread."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ifb3d3b1d317f9cc372f69e21ab98a6db9b3cba11"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da9b358b_cbcccf37","line":19,"updated":"2015-03-30 16:56:31.000000000","message":"Bug # ?","commit_id":"90ca19633168f9ef41e5c2b37770dbeebd39cc3b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"dff01524b74fbe8dcab93eb980f926b36f89e1c9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"In this new loop the flag is checked right before attempting"},{"line_number":17,"context_line":"to start a checking thread."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ifb3d3b1d317f9cc372f69e21ab98a6db9b3cba11"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa32b979_d0389ad5","line":19,"in_reply_to":"da9b358b_cbcccf37","updated":"2015-06-24 11:51:24.000000000","message":"It\u0027s still necessary I think, it\u0027s just a nuance with testing mostly. Not causing tests to fail of anything, but making the logs confuse.","commit_id":"90ca19633168f9ef41e5c2b37770dbeebd39cc3b"}],"neutron/agent/linux/external_process.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"60f640018c477898c5b0e64c347db563b465ae8b","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            eventlet.sleep(0)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def _periodic_checking_thread(self):"},{"line_number":232,"context_line":"        eventlet.sleep(self._config.AGENT.check_child_processes_interval)"},{"line_number":233,"context_line":"        while self._monitor_processes:"},{"line_number":234,"context_line":"            eventlet.spawn(self._check_child_processes)"},{"line_number":235,"context_line":"            eventlet.sleep(self._config.AGENT.check_child_processes_interval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa041b7_e6235304","line":232,"updated":"2015-04-02 11:56:21.000000000","message":"wondering if FixedIntervalLoopingCall (with initial_delay) can be used here","commit_id":"90ca19633168f9ef41e5c2b37770dbeebd39cc3b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"94dbe875f32fcbe22a4a7e820d0ff589a71230eb","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            eventlet.sleep(0)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def _periodic_checking_thread(self):"},{"line_number":232,"context_line":"        eventlet.sleep(self._config.AGENT.check_child_processes_interval)"},{"line_number":233,"context_line":"        while self._monitor_processes:"},{"line_number":234,"context_line":"            eventlet.spawn(self._check_child_processes)"},{"line_number":235,"context_line":"            eventlet.sleep(self._config.AGENT.check_child_processes_interval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_1e9b3ccb","line":232,"in_reply_to":"baa041b7_e6235304","updated":"2015-04-06 16:06:59.000000000","message":"I will check that, I know I had some initial concern about using it, and we discussed it , but I can recall it now.\n\nI start to think it is a good thing now, as this implementation won\u0027t work very well if the checks take longer than the interval, and we\u0027re basically re-implementing it.","commit_id":"90ca19633168f9ef41e5c2b37770dbeebd39cc3b"}]}