)]}'
{"quantum/agent/linux/ip_lib.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":351,"context_line":"                    src \u003d \u0027\u0027"},{"line_number":352,"context_line":"                if (device \u003d\u003d interface_name):"},{"line_number":353,"context_line":"                    break"},{"line_number":354,"context_line":"                device_list.append((device, src))"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"            for (device, src) in device_list:"},{"line_number":357,"context_line":"                self._as_root(\u0027del\u0027, subnet, \u0027dev\u0027, device)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2Fvko%3D","line":354,"updated":"2012-11-27 18:02:40.000000000","message":"minor nit, only regard this is we need to re-rev the fix for another reason, but i think this logic would be more clearer if you put the append under a an if-check that confirms that device !\u003d interface name.\n\nalso, a short comment about what this function does would be helpful to someone browsing the code.","commit_id":"c27e4156059dd9f2ccdc142fe9b1b29ed05b6b1c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":351,"context_line":"                    src \u003d \u0027\u0027"},{"line_number":352,"context_line":"                if (device \u003d\u003d interface_name):"},{"line_number":353,"context_line":"                    break"},{"line_number":354,"context_line":"                device_list.append((device, src))"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"            for (device, src) in device_list:"},{"line_number":357,"context_line":"                self._as_root(\u0027del\u0027, subnet, \u0027dev\u0027, device)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMH%2F%2FveM%3D","line":354,"in_reply_to":"AAAAMH%2F%2Fvko%3D","updated":"2012-11-27 19:52:17.000000000","message":"Done","commit_id":"c27e4156059dd9f2ccdc142fe9b1b29ed05b6b1c"}],"quantum/tests/unit/test_linux_ip_lib.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"fd7606534083fe08784f65527f1ba10321343670","unresolved":false,"context_lines":[{"line_number":557,"context_line":"    def test_pullup_route(self):"},{"line_number":558,"context_line":"        # interface is not the first in the list - requires"},{"line_number":559,"context_line":"        # deleting and creating existing entries"},{"line_number":560,"context_line":"        self.output \u003d [DEVICE_ROUTE_SAMPLE, SUBNET_SAMPLE1]"},{"line_number":561,"context_line":"        self.parent._run \u003d mock.Mock(side_effect\u003dself._pullup_side_effect)"},{"line_number":562,"context_line":"        self.route_cmd.pullup_route(\u0027tap1d7888a7-10\u0027)"},{"line_number":563,"context_line":"        self._assert_sudo([], (\u0027del\u0027, \u002710.0.0.0/24\u0027, \u0027dev\u0027, \u0027qr-23380d11-d2\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2FvqA%3D","line":560,"updated":"2012-11-27 16:55:21.000000000","message":"You can actually declare a method inside of another method.\n     output \u003d [DEVICE_ROUTE_SAMPLE, SUBNET_SAMPLE1]\n     def pullup_side_effect(*args, **kwargs):\n         return output.pop(0)\n\n     self.parent._run \u003d mock.Mock(side_effect\u003dpullup_side_effect)","commit_id":"be7a2d8128441791d6b56a8accb416de37417cba"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":557,"context_line":"    def test_pullup_route(self):"},{"line_number":558,"context_line":"        # interface is not the first in the list - requires"},{"line_number":559,"context_line":"        # deleting and creating existing entries"},{"line_number":560,"context_line":"        self.output \u003d [DEVICE_ROUTE_SAMPLE, SUBNET_SAMPLE1]"},{"line_number":561,"context_line":"        self.parent._run \u003d mock.Mock(side_effect\u003dself._pullup_side_effect)"},{"line_number":562,"context_line":"        self.route_cmd.pullup_route(\u0027tap1d7888a7-10\u0027)"},{"line_number":563,"context_line":"        self._assert_sudo([], (\u0027del\u0027, \u002710.0.0.0/24\u0027, \u0027dev\u0027, \u0027qr-23380d11-d2\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMH%2F%2Fvp0%3D","line":560,"in_reply_to":"AAAAMH%2F%2FvqA%3D","updated":"2012-11-27 16:59:22.000000000","message":"Done","commit_id":"be7a2d8128441791d6b56a8accb416de37417cba"}]}