)]}'
{"quantum/tests/unit/test_db_plugin.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":433,"context_line":"                                               shared\u003dshared)"},{"line_number":434,"context_line":"                    yield subnet"},{"line_number":435,"context_line":"                finally:"},{"line_number":436,"context_line":"                    if subnet:"},{"line_number":437,"context_line":"                        self._delete(\u0027subnets\u0027, subnet[\u0027subnet\u0027][\u0027id\u0027])"},{"line_number":438,"context_line":"        else:"},{"line_number":439,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Ft1M%3D","line":436,"updated":"2012-11-28 23:10:39.000000000","message":"why is this case do we check if subnet is non-None, rather than checking if \u0027subnet\u0027 in subnet, as would be parallel with the above code for network?","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":433,"context_line":"                                               shared\u003dshared)"},{"line_number":434,"context_line":"                    yield subnet"},{"line_number":435,"context_line":"                finally:"},{"line_number":436,"context_line":"                    if subnet:"},{"line_number":437,"context_line":"                        self._delete(\u0027subnets\u0027, subnet[\u0027subnet\u0027][\u0027id\u0027])"},{"line_number":438,"context_line":"        else:"},{"line_number":439,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FtkU%3D","line":436,"in_reply_to":"AAAAMH%2F%2Ft1M%3D","updated":"2012-11-29 07:20:31.000000000","message":"Done\n\nActually, for network(), tests failed without \u0027network\u0027 in network, and for others, tests passed.\nBut it looks better be parallel.","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":450,"context_line":"                yield subnet"},{"line_number":451,"context_line":"            finally:"},{"line_number":452,"context_line":"                    if subnet:"},{"line_number":453,"context_line":"                        self._delete(\u0027subnets\u0027, subnet[\u0027subnet\u0027][\u0027id\u0027])"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    @contextlib.contextmanager"},{"line_number":456,"context_line":"    def port(self, subnet\u003dNone, fixed_ips\u003dNone, fmt\u003d\u0027json\u0027, no_delete\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Ft1Y%3D","line":453,"updated":"2012-11-28 23:10:39.000000000","message":"might be cleaner if the try: and finally: are outside the if/else, since they are the same.","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":450,"context_line":"                yield subnet"},{"line_number":451,"context_line":"            finally:"},{"line_number":452,"context_line":"                    if subnet:"},{"line_number":453,"context_line":"                        self._delete(\u0027subnets\u0027, subnet[\u0027subnet\u0027][\u0027id\u0027])"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    @contextlib.contextmanager"},{"line_number":456,"context_line":"    def port(self, subnet\u003dNone, fixed_ips\u003dNone, fmt\u003d\u0027json\u0027, no_delete\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FtkQ%3D","line":453,"in_reply_to":"AAAAMH%2F%2Ft1Y%3D","updated":"2012-11-29 07:20:31.000000000","message":"Done\n\nI\u0027d like to make try-catch as small as I can, so I separate them.\n\nAnd in this case, if I put try/finally outside if/else, then there\u0027s problem because \"with network()\" statement will release network  before releasing subnet.","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c929ef3b5a769315eae1f5f50f02e9833819a85a","unresolved":false,"context_lines":[{"line_number":469,"context_line":"                        raise webob.exc.HTTPClientError(code\u003dres.status_int)"},{"line_number":470,"context_line":"                    yield port"},{"line_number":471,"context_line":"                finally:"},{"line_number":472,"context_line":"                    if not no_delete and \u0027port\u0027 in port:"},{"line_number":473,"context_line":"                        self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":474,"context_line":"        else:"},{"line_number":475,"context_line":"            net_id \u003d subnet[\u0027subnet\u0027][\u0027network_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2Fta4%3D","line":472,"updated":"2012-11-29 09:43:51.000000000","message":"It shoud be \u0027if port and not no_delete and \u0027port\u0027 in port:\u0027 ?","commit_id":"d26a4be61a845a81401985c6d70e482a86b267f7"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":469,"context_line":"                        raise webob.exc.HTTPClientError(code\u003dres.status_int)"},{"line_number":470,"context_line":"                    yield port"},{"line_number":471,"context_line":"                finally:"},{"line_number":472,"context_line":"                    if not no_delete and \u0027port\u0027 in port:"},{"line_number":473,"context_line":"                        self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":474,"context_line":"        else:"},{"line_number":475,"context_line":"            net_id \u003d subnet[\u0027subnet\u0027][\u0027network_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2FsRA%3D","line":472,"in_reply_to":"AAAAMH%2F%2Fta4%3D","updated":"2012-11-30 02:33:04.000000000","message":"Done\n\nYou\u0027re right! thanks!","commit_id":"d26a4be61a845a81401985c6d70e482a86b267f7"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c929ef3b5a769315eae1f5f50f02e9833819a85a","unresolved":false,"context_lines":[{"line_number":387,"context_line":"                                       name,"},{"line_number":388,"context_line":"                                       admin_status_up,"},{"line_number":389,"context_line":"                                       **kwargs)"},{"line_number":390,"context_line":"            network \u003d None"},{"line_number":391,"context_line":"            network \u003d self.deserialize(fmt, res)"},{"line_number":392,"context_line":"            # TODO(salvatore-orlando): do exception handling in this test"},{"line_number":393,"context_line":"            # module in a uniform way (we do it differently for ports, subnets,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2FsQY%3D","line":390,"updated":"2012-11-30 02:58:25.000000000","message":"Define network out of try block. If there is any exception raise before this line, in finally network can\u0027t be find.","commit_id":"014b3610553e20b84e85a888b75d7ca67f771032"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":387,"context_line":"                                       name,"},{"line_number":388,"context_line":"                                       admin_status_up,"},{"line_number":389,"context_line":"                                       **kwargs)"},{"line_number":390,"context_line":"            network \u003d None"},{"line_number":391,"context_line":"            network \u003d self.deserialize(fmt, res)"},{"line_number":392,"context_line":"            # TODO(salvatore-orlando): do exception handling in this test"},{"line_number":393,"context_line":"            # module in a uniform way (we do it differently for ports, subnets,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2FsOE%3D","line":390,"in_reply_to":"AAAAMH%2F%2FsQY%3D","updated":"2012-11-30 07:00:40.000000000","message":"Done\n\nah....\nright!\nthanks!","commit_id":"014b3610553e20b84e85a888b75d7ca67f771032"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":395,"context_line":"            # so it can be caught by unit tests"},{"line_number":396,"context_line":"            if res.status_int \u003e\u003d 400:"},{"line_number":397,"context_line":"                raise webob.exc.HTTPClientError(code\u003dres.status_int)"},{"line_number":398,"context_line":"            yield network"},{"line_number":399,"context_line":"        finally:"},{"line_number":400,"context_line":"            if network and do_delete and \u0027network\u0027 in network:"},{"line_number":401,"context_line":"                # The do_delete parameter allows you to control whether the"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9VY%3D","line":398,"updated":"2012-12-04 22:15:17.000000000","message":"The try should probably go before the yield.  Currently the code works with the assumption that deserialize is safe, so you\u0027ve added lots of code to detect failures in the finally.  If only the yield is inside of the try, the finally will be simpler.","commit_id":"635bb51a5b130fa0b083a4b33e4f8f4e3b324dd4"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":395,"context_line":"            # so it can be caught by unit tests"},{"line_number":396,"context_line":"            if res.status_int \u003e\u003d 400:"},{"line_number":397,"context_line":"                raise webob.exc.HTTPClientError(code\u003dres.status_int)"},{"line_number":398,"context_line":"            yield network"},{"line_number":399,"context_line":"        finally:"},{"line_number":400,"context_line":"            if network and do_delete and \u0027network\u0027 in network:"},{"line_number":401,"context_line":"                # The do_delete parameter allows you to control whether the"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F8yA%3D","line":398,"in_reply_to":"AAAAMX%2F%2F9VY%3D","updated":"2012-12-05 13:54:37.000000000","message":"Thanks for review!\n\nI agree that try block should be minimal.\nBut in this case, I thought, _create_network() is logically creation of network, so the try block is valid, I think.\n\nIMHO, your suggestion is extracting this creation part as another method like _make_subnet().\n\nI thought, it\u0027s beyond the scope of this patch, but other people like you agree about the refactoring, it\u0027ll be great!","commit_id":"635bb51a5b130fa0b083a4b33e4f8f4e3b324dd4"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":432,"context_line":"                                               dns_nameservers,"},{"line_number":433,"context_line":"                                               host_routes,"},{"line_number":434,"context_line":"                                               shared\u003dshared)"},{"line_number":435,"context_line":"                    yield subnet"},{"line_number":436,"context_line":"                finally:"},{"line_number":437,"context_line":"                    if subnet and \u0027subnet\u0027 in subnet:"},{"line_number":438,"context_line":"                        self._delete(\u0027subnets\u0027, subnet[\u0027subnet\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9VU%3D","line":435,"updated":"2012-12-04 22:15:17.000000000","message":"Same observation here about limiting the code executed in the try.","commit_id":"635bb51a5b130fa0b083a4b33e4f8f4e3b324dd4"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":467,"context_line":"                    # so it can be caught by unit tests"},{"line_number":468,"context_line":"                    if res.status_int \u003e\u003d 400:"},{"line_number":469,"context_line":"                        raise webob.exc.HTTPClientError(code\u003dres.status_int)"},{"line_number":470,"context_line":"                    yield port"},{"line_number":471,"context_line":"                finally:"},{"line_number":472,"context_line":"                    if port and not no_delete and \u0027port\u0027 in port:"},{"line_number":473,"context_line":"                        self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9VQ%3D","line":470,"updated":"2012-12-04 22:15:17.000000000","message":"same as above","commit_id":"635bb51a5b130fa0b083a4b33e4f8f4e3b324dd4"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":401,"context_line":"                do_delete\u003dTrue,"},{"line_number":402,"context_line":"                **kwargs):"},{"line_number":403,"context_line":"        network \u003d None"},{"line_number":404,"context_line":"        try:"},{"line_number":405,"context_line":"            network \u003d self._make_network(fmt, name, admin_status_up, **kwargs)"},{"line_number":406,"context_line":"            yield network"},{"line_number":407,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMX%2F%2F8aQ%3D","line":404,"updated":"2012-12-05 19:16:40.000000000","message":"network \u003d self._make_network(fmt, name, admin_status_up, **kwargs)\ntry:\n    yield network\nfinally:\n    if do_delete:\n        # comments\n        self._delete(\u0027networks\u0027, network[\u0027network\u0027][\u0027id\u0027])","commit_id":"f3e91d138904c203a1c3f4ad4c7d8eb1b4cd591a"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":401,"context_line":"                do_delete\u003dTrue,"},{"line_number":402,"context_line":"                **kwargs):"},{"line_number":403,"context_line":"        network \u003d None"},{"line_number":404,"context_line":"        try:"},{"line_number":405,"context_line":"            network \u003d self._make_network(fmt, name, admin_status_up, **kwargs)"},{"line_number":406,"context_line":"            yield network"},{"line_number":407,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMX%2F%2F78M%3D","line":404,"in_reply_to":"AAAAMX%2F%2F8aQ%3D","updated":"2012-12-06 03:12:51.000000000","message":"ah....\nThanks! This looks better!","commit_id":"f3e91d138904c203a1c3f4ad4c7d8eb1b4cd591a"}],"quantum/tests/unit/test_extension_security_group.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c929ef3b5a769315eae1f5f50f02e9833819a85a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                raise webob.exc.HTTPClientError(code\u003dres.status_int)"},{"line_number":121,"context_line":"            yield security_group"},{"line_number":122,"context_line":"        finally:"},{"line_number":123,"context_line":"            if not no_delete:"},{"line_number":124,"context_line":"                self._delete(\u0027security-groups\u0027,"},{"line_number":125,"context_line":"                             security_group[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Fuxw%3D","line":123,"updated":"2012-11-28 09:22:27.000000000","message":"Should we check like in other files \u0027if not no_delete and \u0027security_groups\u0027\u0027?","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":120,"context_line":"                raise webob.exc.HTTPClientError(code\u003dres.status_int)"},{"line_number":121,"context_line":"            yield security_group"},{"line_number":122,"context_line":"        finally:"},{"line_number":123,"context_line":"            if not no_delete:"},{"line_number":124,"context_line":"                self._delete(\u0027security-groups\u0027,"},{"line_number":125,"context_line":"                             security_group[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FtkI%3D","line":123,"in_reply_to":"AAAAMH%2F%2Ft08%3D","updated":"2012-11-29 07:20:31.000000000","message":"Done\n\nFinally, I changed code like this.\nsecurity_group \u003d None\n.....\nif (security_group and not no_delete\n  and \u0027security_group\u0027 in security_group):\n\nThe reason checking security_group is that deserialize() might return None. And if deserialize() throws exception, security_group is not even defined, so I put explicit initialization of it.\n\nThanks","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":120,"context_line":"                raise webob.exc.HTTPClientError(code\u003dres.status_int)"},{"line_number":121,"context_line":"            yield security_group"},{"line_number":122,"context_line":"        finally:"},{"line_number":123,"context_line":"            if not no_delete:"},{"line_number":124,"context_line":"                self._delete(\u0027security-groups\u0027,"},{"line_number":125,"context_line":"                             security_group[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Ft08%3D","line":123,"in_reply_to":"AAAAMH%2F%2Fuxw%3D","updated":"2012-11-28 23:10:39.000000000","message":"or perhaps, if \u0027security_group\u0027 in security_group","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c929ef3b5a769315eae1f5f50f02e9833819a85a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                raise webob.exc.HTTPClientError(code\u003dres.status_int)"},{"line_number":146,"context_line":"            yield security_group_rule"},{"line_number":147,"context_line":"        finally:"},{"line_number":148,"context_line":"            if not no_delete:"},{"line_number":149,"context_line":"                self._delete(\u0027security-group-rules\u0027,"},{"line_number":150,"context_line":"                             security_group_rule[\u0027security_group_rule\u0027][\u0027id\u0027])"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Fuxk%3D","line":148,"updated":"2012-11-28 09:22:27.000000000","message":"same question as above","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":145,"context_line":"                raise webob.exc.HTTPClientError(code\u003dres.status_int)"},{"line_number":146,"context_line":"            yield security_group_rule"},{"line_number":147,"context_line":"        finally:"},{"line_number":148,"context_line":"            if not no_delete:"},{"line_number":149,"context_line":"                self._delete(\u0027security-group-rules\u0027,"},{"line_number":150,"context_line":"                             security_group_rule[\u0027security_group_rule\u0027][\u0027id\u0027])"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Ftjw%3D","line":148,"in_reply_to":"AAAAMH%2F%2Ft04%3D","updated":"2012-11-29 07:20:31.000000000","message":"Done","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":145,"context_line":"                raise webob.exc.HTTPClientError(code\u003dres.status_int)"},{"line_number":146,"context_line":"            yield security_group_rule"},{"line_number":147,"context_line":"        finally:"},{"line_number":148,"context_line":"            if not no_delete:"},{"line_number":149,"context_line":"                self._delete(\u0027security-group-rules\u0027,"},{"line_number":150,"context_line":"                             security_group_rule[\u0027security_group_rule\u0027][\u0027id\u0027])"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Ft04%3D","line":148,"in_reply_to":"AAAAMH%2F%2Fuxk%3D","updated":"2012-11-28 23:10:39.000000000","message":"same","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c929ef3b5a769315eae1f5f50f02e9833819a85a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            res \u003d self._create_security_group(fmt, name, description,"},{"line_number":117,"context_line":"                                              external_id)"},{"line_number":118,"context_line":"            security_group \u003d None"},{"line_number":119,"context_line":"            security_group \u003d self.deserialize(fmt, res)"},{"line_number":120,"context_line":"            if res.status_int \u003e\u003d 400:"},{"line_number":121,"context_line":"                raise webob.exc.HTTPClientError(code\u003dres.status_int)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2FsQU%3D","line":118,"updated":"2012-11-30 02:58:25.000000000","message":"Define security_group out of try block","commit_id":"014b3610553e20b84e85a888b75d7ca67f771032"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":115,"context_line":"        try:"},{"line_number":116,"context_line":"            res \u003d self._create_security_group(fmt, name, description,"},{"line_number":117,"context_line":"                                              external_id)"},{"line_number":118,"context_line":"            security_group \u003d None"},{"line_number":119,"context_line":"            security_group \u003d self.deserialize(fmt, res)"},{"line_number":120,"context_line":"            if res.status_int \u003e\u003d 400:"},{"line_number":121,"context_line":"                raise webob.exc.HTTPClientError(code\u003dres.status_int)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2FsOA%3D","line":118,"in_reply_to":"AAAAMH%2F%2FsQU%3D","updated":"2012-11-30 07:00:40.000000000","message":"Done\n\nThanks!","commit_id":"014b3610553e20b84e85a888b75d7ca67f771032"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c929ef3b5a769315eae1f5f50f02e9833819a85a","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                                   source_group_id,"},{"line_number":143,"context_line":"                                                   external_id)"},{"line_number":144,"context_line":"            res \u003d self._create_security_group_rule(\u0027json\u0027, rule)"},{"line_number":145,"context_line":"            security_group_rule \u003d None"},{"line_number":146,"context_line":"            security_group_rule \u003d self.deserialize(fmt, res)"},{"line_number":147,"context_line":"            if res.status_int \u003e\u003d 400:"},{"line_number":148,"context_line":"                raise webob.exc.HTTPClientError(code\u003dres.status_int)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2FsQQ%3D","line":145,"updated":"2012-11-30 02:58:25.000000000","message":"same","commit_id":"014b3610553e20b84e85a888b75d7ca67f771032"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                                   source_group_id,"},{"line_number":143,"context_line":"                                                   external_id)"},{"line_number":144,"context_line":"            res \u003d self._create_security_group_rule(\u0027json\u0027, rule)"},{"line_number":145,"context_line":"            security_group_rule \u003d None"},{"line_number":146,"context_line":"            security_group_rule \u003d self.deserialize(fmt, res)"},{"line_number":147,"context_line":"            if res.status_int \u003e\u003d 400:"},{"line_number":148,"context_line":"                raise webob.exc.HTTPClientError(code\u003dres.status_int)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2FsN4%3D","line":145,"in_reply_to":"AAAAMH%2F%2FsQQ%3D","updated":"2012-11-30 07:00:40.000000000","message":"Done","commit_id":"014b3610553e20b84e85a888b75d7ca67f771032"}],"quantum/tests/unit/test_l3_plugin.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":338,"context_line":"                                      admin_state_up\u003dadmin_status_up)"},{"line_number":339,"context_line":"            router \u003d self.deserialize(fmt, res)"},{"line_number":340,"context_line":"            yield router"},{"line_number":341,"context_line":"        finally:"},{"line_number":342,"context_line":"            self._delete(\u0027routers\u0027, router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    def test_router_crd_ops(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Ft0s%3D","line":341,"updated":"2012-11-28 23:10:39.000000000","message":"no check here?","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":338,"context_line":"                                      admin_state_up\u003dadmin_status_up)"},{"line_number":339,"context_line":"            router \u003d self.deserialize(fmt, res)"},{"line_number":340,"context_line":"            yield router"},{"line_number":341,"context_line":"        finally:"},{"line_number":342,"context_line":"            self._delete(\u0027routers\u0027, router[\u0027router\u0027][\u0027id\u0027])"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    def test_router_crd_ops(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FtjU%3D","line":341,"in_reply_to":"AAAAMH%2F%2Ft0s%3D","updated":"2012-11-29 07:20:31.000000000","message":"Done","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c929ef3b5a769315eae1f5f50f02e9833819a85a","unresolved":false,"context_lines":[{"line_number":833,"context_line":"    def floatingip_no_assoc(self, private_sub, fmt\u003d\u0027json\u0027):"},{"line_number":834,"context_line":"        with self.subnet(cidr\u003d\u002712.0.0.0/24\u0027) as public_sub:"},{"line_number":835,"context_line":"            self._set_net_external(public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":836,"context_line":"            with self.router() as r:"},{"line_number":837,"context_line":"                try:"},{"line_number":838,"context_line":"                    self._add_external_gateway_to_router("},{"line_number":839,"context_line":"                        r[\u0027router\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2Fux0%3D","line":836,"updated":"2012-11-28 09:22:27.000000000","message":"This isn\u0027t your patch\u0027s problem. It looks like we don\u0027t need create router when floatingip without association.","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":833,"context_line":"    def floatingip_no_assoc(self, private_sub, fmt\u003d\u0027json\u0027):"},{"line_number":834,"context_line":"        with self.subnet(cidr\u003d\u002712.0.0.0/24\u0027) as public_sub:"},{"line_number":835,"context_line":"            self._set_net_external(public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":836,"context_line":"            with self.router() as r:"},{"line_number":837,"context_line":"                try:"},{"line_number":838,"context_line":"                    self._add_external_gateway_to_router("},{"line_number":839,"context_line":"                        r[\u0027router\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FteY%3D","line":836,"in_reply_to":"AAAAMH%2F%2FtzA%3D","updated":"2012-11-29 07:20:31.000000000","message":"I think, this is separate issue, so it\u0027s better not to change in this patch.\n\nIf you think this can be issue, I\u0027d appreciate if you file another bug or dev-mailing.","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":833,"context_line":"    def floatingip_no_assoc(self, private_sub, fmt\u003d\u0027json\u0027):"},{"line_number":834,"context_line":"        with self.subnet(cidr\u003d\u002712.0.0.0/24\u0027) as public_sub:"},{"line_number":835,"context_line":"            self._set_net_external(public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":836,"context_line":"            with self.router() as r:"},{"line_number":837,"context_line":"                try:"},{"line_number":838,"context_line":"                    self._add_external_gateway_to_router("},{"line_number":839,"context_line":"                        r[\u0027router\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMH%2F%2FtzA%3D","line":836,"in_reply_to":"AAAAMH%2F%2Fux0%3D","updated":"2012-11-28 23:10:39.000000000","message":"actually, i think we do want to create the router, the goal is to set up everything except for the final association step (since we want to test that).  It is a bit wonky that one is not able to fetch the created router-id from the returned floating IP, but its easy enough to fetch it using a separate query, since there is only one router created.","commit_id":"072fe3b7a4ee5b717339ec45b22b37816d26b84b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c929ef3b5a769315eae1f5f50f02e9833819a85a","unresolved":false,"context_lines":[{"line_number":853,"context_line":"                    floatingip \u003d self.deserialize(fmt, res)"},{"line_number":854,"context_line":"                    yield floatingip"},{"line_number":855,"context_line":"                finally:"},{"line_number":856,"context_line":"                    self._delete(\u0027floatingips\u0027, floatingip[\u0027floatingip\u0027][\u0027id\u0027])"},{"line_number":857,"context_line":"                    self._router_interface_action(\u0027remove\u0027, r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":858,"context_line":"                                                  private_sub[\u0027subnet\u0027][\u0027id\u0027],"},{"line_number":859,"context_line":"                                                  None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2Fta0%3D","line":856,"updated":"2012-11-29 09:43:51.000000000","message":"Why this doesn\u0027t need check?","commit_id":"d26a4be61a845a81401985c6d70e482a86b267f7"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":853,"context_line":"                    floatingip \u003d self.deserialize(fmt, res)"},{"line_number":854,"context_line":"                    yield floatingip"},{"line_number":855,"context_line":"                finally:"},{"line_number":856,"context_line":"                    self._delete(\u0027floatingips\u0027, floatingip[\u0027floatingip\u0027][\u0027id\u0027])"},{"line_number":857,"context_line":"                    self._router_interface_action(\u0027remove\u0027, r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":858,"context_line":"                                                  private_sub[\u0027subnet\u0027][\u0027id\u0027],"},{"line_number":859,"context_line":"                                                  None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2FsRE%3D","line":856,"in_reply_to":"AAAAMH%2F%2Fta0%3D","updated":"2012-11-30 02:33:04.000000000","message":"Done\n\nOops.. I\u0027ll fix!","commit_id":"d26a4be61a845a81401985c6d70e482a86b267f7"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c929ef3b5a769315eae1f5f50f02e9833819a85a","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        try:"},{"line_number":337,"context_line":"            res \u003d self._create_router(fmt, tenant_id, name\u003dname,"},{"line_number":338,"context_line":"                                      admin_state_up\u003dadmin_status_up)"},{"line_number":339,"context_line":"            router \u003d None"},{"line_number":340,"context_line":"            router \u003d self.deserialize(fmt, res)"},{"line_number":341,"context_line":"            yield router"},{"line_number":342,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2FsQM%3D","line":339,"updated":"2012-11-30 02:58:25.000000000","message":"same","commit_id":"014b3610553e20b84e85a888b75d7ca67f771032"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":336,"context_line":"        try:"},{"line_number":337,"context_line":"            res \u003d self._create_router(fmt, tenant_id, name\u003dname,"},{"line_number":338,"context_line":"                                      admin_state_up\u003dadmin_status_up)"},{"line_number":339,"context_line":"            router \u003d None"},{"line_number":340,"context_line":"            router \u003d self.deserialize(fmt, res)"},{"line_number":341,"context_line":"            yield router"},{"line_number":342,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2FsN0%3D","line":339,"in_reply_to":"AAAAMH%2F%2FsQM%3D","updated":"2012-11-30 07:00:40.000000000","message":"Done","commit_id":"014b3610553e20b84e85a888b75d7ca67f771032"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c929ef3b5a769315eae1f5f50f02e9833819a85a","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                            public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":820,"context_line":"                            port_id\u003dprivate_port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":821,"context_line":"                        self.assertEqual(res.status_int, exc.HTTPCreated.code)"},{"line_number":822,"context_line":"                        floatingip \u003d None"},{"line_number":823,"context_line":"                        floatingip \u003d self.deserialize(fmt, res)"},{"line_number":824,"context_line":"                        yield floatingip"},{"line_number":825,"context_line":"                    finally:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2FsQk%3D","line":822,"updated":"2012-11-30 02:58:25.000000000","message":"This is missing from previous review.\nIf there is exception raise before this line, then in finally block will can\u0027t find the variable \u0027floatingip\u0027","commit_id":"014b3610553e20b84e85a888b75d7ca67f771032"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":819,"context_line":"                            public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":820,"context_line":"                            port_id\u003dprivate_port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":821,"context_line":"                        self.assertEqual(res.status_int, exc.HTTPCreated.code)"},{"line_number":822,"context_line":"                        floatingip \u003d None"},{"line_number":823,"context_line":"                        floatingip \u003d self.deserialize(fmt, res)"},{"line_number":824,"context_line":"                        yield floatingip"},{"line_number":825,"context_line":"                    finally:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2FsNs%3D","line":822,"in_reply_to":"AAAAMH%2F%2FsQk%3D","updated":"2012-11-30 07:00:40.000000000","message":"Done","commit_id":"014b3610553e20b84e85a888b75d7ca67f771032"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c929ef3b5a769315eae1f5f50f02e9833819a85a","unresolved":false,"context_lines":[{"line_number":850,"context_line":"                        fmt,"},{"line_number":851,"context_line":"                        public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":852,"context_line":"                    self.assertEqual(res.status_int, exc.HTTPCreated.code)"},{"line_number":853,"context_line":"                    floatingip \u003d None"},{"line_number":854,"context_line":"                    floatingip \u003d self.deserialize(fmt, res)"},{"line_number":855,"context_line":"                    yield floatingip"},{"line_number":856,"context_line":"                finally:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2FsQc%3D","line":853,"updated":"2012-11-30 02:58:25.000000000","message":"same","commit_id":"014b3610553e20b84e85a888b75d7ca67f771032"},{"author":{"_account_id":4405,"name":"Iryoung Jeong","email":"iryoung@gmail.com","username":"iryoung"},"unresolved":false,"context_lines":[{"line_number":850,"context_line":"                        fmt,"},{"line_number":851,"context_line":"                        public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":852,"context_line":"                    self.assertEqual(res.status_int, exc.HTTPCreated.code)"},{"line_number":853,"context_line":"                    floatingip \u003d None"},{"line_number":854,"context_line":"                    floatingip \u003d self.deserialize(fmt, res)"},{"line_number":855,"context_line":"                    yield floatingip"},{"line_number":856,"context_line":"                finally:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMH%2F%2FsNw%3D","line":853,"in_reply_to":"AAAAMH%2F%2FsQc%3D","updated":"2012-11-30 07:00:40.000000000","message":"Done","commit_id":"014b3610553e20b84e85a888b75d7ca67f771032"}]}
