)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a9ed6b328bf8b0b0af925dfbe2afd61aa936d8b2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Output warn log if * is used, and the related"},{"line_number":10,"context_line":"help message is modified accordingly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I13eb22afd7c0d011154b58a1bd218fd4fa82a8d9"},{"line_number":13,"context_line":"Closes-bug: 1437745"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da9b358b_7830b39e","line":11,"updated":"2015-04-01 05:42:39.000000000","message":"DocImpact?","commit_id":"b36a0dc1c83248264d81f8d22c3cffc3668cd5c4"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"1ba8b6d336d993bee7355c1dd745b40bc18ca361","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Output warn log if * is used, and the related"},{"line_number":10,"context_line":"help message is modified accordingly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I13eb22afd7c0d011154b58a1bd218fd4fa82a8d9"},{"line_number":13,"context_line":"Closes-bug: 1437745"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da9b358b_ecac0437","line":11,"in_reply_to":"da9b358b_7830b39e","updated":"2015-04-01 07:04:50.000000000","message":"Done","commit_id":"b36a0dc1c83248264d81f8d22c3cffc3668cd5c4"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"143587a5ef2dbb360c24b1e4aa74927f4cafe9b2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     gong yong sheng \u003cgong.yongsheng@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-04-01 15:06:18 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deprecate * for arbitary flat phsical network name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Output warn log if * is used, and the related"},{"line_number":10,"context_line":"help message is modified accordingly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da9b358b_34fc6e71","line":7,"updated":"2015-04-01 11:47:41.000000000","message":"typo: physical","commit_id":"d54f0fab81cd27b94fb0f25680b37fdc4d5a6d7a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"22b15939e3faa6f6cb594a192d2da49fd6c9eedf","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also, fix the empty list configuration for disabling flat networks."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I13eb22afd7c0d011154b58a1bd218fd4fa82a8d9"},{"line_number":18,"context_line":"Closes-bug: #1437745"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa80f949_545b722e","line":15,"updated":"2015-11-05 15:48:27.000000000","message":"Please add UpgradeImpact\nThe reason for this is we want people deploying to know that there could be a change in behavior","commit_id":"7974dddae6d99539a13858fab560193dee66ac7a"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"5c9f668775b95e3fbfd7454a9e98bcfc81ad1d12","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also, fix the empty list configuration for disabling flat networks."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I13eb22afd7c0d011154b58a1bd218fd4fa82a8d9"},{"line_number":18,"context_line":"Closes-bug: #1437745"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa80f949_942f9af5","line":15,"in_reply_to":"fa80f949_545b722e","updated":"2015-11-05 16:34:57.000000000","message":"ok, sure. Added.","commit_id":"7974dddae6d99539a13858fab560193dee66ac7a"}],"etc/neutron/plugins/ml2/ml2_conf.ini":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"e79be8b62169e7d69afe3e71640687cd3033e66d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"#"},{"line_number":58,"context_line":"# flat_networks \u003d"},{"line_number":59,"context_line":"# Example:flat_networks \u003d physnet1,physnet2"},{"line_number":60,"context_line":"# Example:flat_networks \u003d *"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"[ml2_type_vlan]"},{"line_number":63,"context_line":"# (ListOpt) List of \u003cphysical_network\u003e[:\u003cvlan_min\u003e:\u003cvlan_max\u003e] tuples"}],"source_content_type":"text/x-properties","patch_set":1,"id":"da9b358b_fd7395e5","line":60,"updated":"2015-04-01 05:03:47.000000000","message":"Shouldn\u0027t this example be removed since * is deprecated?","commit_id":"b36a0dc1c83248264d81f8d22c3cffc3668cd5c4"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"1ba8b6d336d993bee7355c1dd745b40bc18ca361","unresolved":false,"context_lines":[{"line_number":57,"context_line":"#"},{"line_number":58,"context_line":"# flat_networks \u003d"},{"line_number":59,"context_line":"# Example:flat_networks \u003d physnet1,physnet2"},{"line_number":60,"context_line":"# Example:flat_networks \u003d *"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"[ml2_type_vlan]"},{"line_number":63,"context_line":"# (ListOpt) List of \u003cphysical_network\u003e[:\u003cvlan_min\u003e:\u003cvlan_max\u003e] tuples"}],"source_content_type":"text/x-properties","patch_set":1,"id":"da9b358b_ccab801c","line":60,"in_reply_to":"da9b358b_58272f64","updated":"2015-04-01 07:04:50.000000000","message":"Done","commit_id":"b36a0dc1c83248264d81f8d22c3cffc3668cd5c4"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a9ed6b328bf8b0b0af925dfbe2afd61aa936d8b2","unresolved":false,"context_lines":[{"line_number":57,"context_line":"#"},{"line_number":58,"context_line":"# flat_networks \u003d"},{"line_number":59,"context_line":"# Example:flat_networks \u003d physnet1,physnet2"},{"line_number":60,"context_line":"# Example:flat_networks \u003d *"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"[ml2_type_vlan]"},{"line_number":63,"context_line":"# (ListOpt) List of \u003cphysical_network\u003e[:\u003cvlan_min\u003e:\u003cvlan_max\u003e] tuples"}],"source_content_type":"text/x-properties","patch_set":1,"id":"da9b358b_58272f64","line":60,"in_reply_to":"da9b358b_fd7395e5","updated":"2015-04-01 05:42:39.000000000","message":"+1","commit_id":"b36a0dc1c83248264d81f8d22c3cffc3668cd5c4"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"df4262c649a011ce7c586fe07000eac4d548a8f8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"[ml2_type_flat]"},{"line_number":63,"context_line":"# (ListOpt) List of physical_network names with which flat networks"},{"line_number":64,"context_line":"# can be created. Use default \u0027*\u0027 to allow flat networks with arbitrary"},{"line_number":65,"context_line":"# physical_network names. Use empty to  disables flat networks."},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# flat_networks \u003d *"},{"line_number":68,"context_line":"# Example:flat_networks \u003d physnet1,physnet2"}],"source_content_type":"text/x-properties","patch_set":3,"id":"fa80f949_e27f5d64","line":65,"updated":"2015-11-05 07:47:16.000000000","message":"Some nit comment:\n1) extra space between to and disables\n2) disables  ---\u003e disable","commit_id":"2de152a9208badcbfbf41266545618b164ae8da4"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"a955b74114e5248d6cad5e9c523d5c1eaf0622d4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"[ml2_type_flat]"},{"line_number":63,"context_line":"# (ListOpt) List of physical_network names with which flat networks"},{"line_number":64,"context_line":"# can be created. Use default \u0027*\u0027 to allow flat networks with arbitrary"},{"line_number":65,"context_line":"# physical_network names. Use empty to  disables flat networks."},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# flat_networks \u003d *"},{"line_number":68,"context_line":"# Example:flat_networks \u003d physnet1,physnet2"}],"source_content_type":"text/x-properties","patch_set":3,"id":"fa80f949_5aade92f","line":65,"in_reply_to":"fa80f949_e27f5d64","updated":"2015-11-05 12:55:18.000000000","message":"Done.","commit_id":"2de152a9208badcbfbf41266545618b164ae8da4"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"df4262c649a011ce7c586fe07000eac4d548a8f8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# flat_networks \u003d *"},{"line_number":68,"context_line":"# Example:flat_networks \u003d physnet1,physnet2"},{"line_number":69,"context_line":"# Example:flat_networks \u003d *"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"[ml2_type_vlan]"},{"line_number":72,"context_line":"# (ListOpt) List of \u003cphysical_network\u003e[:\u003cvlan_min\u003e:\u003cvlan_max\u003e] tuples"}],"source_content_type":"text/x-properties","patch_set":3,"id":"fa80f949_78c5608c","line":69,"updated":"2015-11-05 07:47:16.000000000","message":"Since this line is duplicated with line 67, This example can be:\nExample:flat_networks \u003d","commit_id":"2de152a9208badcbfbf41266545618b164ae8da4"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"a955b74114e5248d6cad5e9c523d5c1eaf0622d4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# flat_networks \u003d *"},{"line_number":68,"context_line":"# Example:flat_networks \u003d physnet1,physnet2"},{"line_number":69,"context_line":"# Example:flat_networks \u003d *"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"[ml2_type_vlan]"},{"line_number":72,"context_line":"# (ListOpt) List of \u003cphysical_network\u003e[:\u003cvlan_min\u003e:\u003cvlan_max\u003e] tuples"}],"source_content_type":"text/x-properties","patch_set":3,"id":"fa80f949_9a7111e3","line":69,"in_reply_to":"fa80f949_78c5608c","updated":"2015-11-05 12:55:18.000000000","message":"Good point, updated.","commit_id":"2de152a9208badcbfbf41266545618b164ae8da4"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"61131ccc55b8fb69ad793105d06e3a7983266a49","unresolved":false,"context_lines":[{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# flat_networks \u003d *"},{"line_number":68,"context_line":"# Example:flat_networks \u003d physnet1,physnet2"},{"line_number":69,"context_line":"# Example:flat_networks \u003d "},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"[ml2_type_vlan]"},{"line_number":72,"context_line":"# (ListOpt) List of \u003cphysical_network\u003e[:\u003cvlan_min\u003e:\u003cvlan_max\u003e] tuples"}],"source_content_type":"text/x-properties","patch_set":5,"id":"fa80f949_dcbf8ef9","line":69,"updated":"2015-11-05 14:54:17.000000000","message":"Extra whitespace.","commit_id":"7974dddae6d99539a13858fab560193dee66ac7a"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"c176152ebcf0ac74a3ac5a5441198c679a5fca42","unresolved":false,"context_lines":[{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# flat_networks \u003d *"},{"line_number":68,"context_line":"# Example:flat_networks \u003d physnet1,physnet2"},{"line_number":69,"context_line":"# Example:flat_networks \u003d "},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"[ml2_type_vlan]"},{"line_number":72,"context_line":"# (ListOpt) List of \u003cphysical_network\u003e[:\u003cvlan_min\u003e:\u003cvlan_max\u003e] tuples"}],"source_content_type":"text/x-properties","patch_set":5,"id":"fa80f949_34a6ee10","line":69,"in_reply_to":"fa80f949_dcbf8ef9","updated":"2015-11-05 15:48:30.000000000","message":"Space removed.","commit_id":"7974dddae6d99539a13858fab560193dee66ac7a"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e2681feea2dffd784f8d0faf7a946acc178b7512","unresolved":false,"context_lines":[{"line_number":62,"context_line":"[ml2_type_flat]"},{"line_number":63,"context_line":"# (ListOpt) List of physical_network names with which flat networks"},{"line_number":64,"context_line":"# can be created. Use default \u0027*\u0027 to allow flat networks with arbitrary"},{"line_number":65,"context_line":"# physical_network names. Use empty to disable flat networks."},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# flat_networks \u003d *"},{"line_number":68,"context_line":"# Example:flat_networks \u003d physnet1,physnet2"}],"source_content_type":"text/x-properties","patch_set":7,"id":"fa80f949_685fb5e5","line":65,"updated":"2015-11-05 17:12:31.000000000","message":"empty -\u003e an empty list","commit_id":"85d41c4b5ca57f7b18ab30a6cb9823989abfe6be"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"479b3d74080646cf6c7b040a920409f33ef037cd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"[ml2_type_flat]"},{"line_number":63,"context_line":"# (ListOpt) List of physical_network names with which flat networks"},{"line_number":64,"context_line":"# can be created. Use default \u0027*\u0027 to allow flat networks with arbitrary"},{"line_number":65,"context_line":"# physical_network names. Use empty to disable flat networks."},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# flat_networks \u003d *"},{"line_number":68,"context_line":"# Example:flat_networks \u003d physnet1,physnet2"}],"source_content_type":"text/x-properties","patch_set":7,"id":"fa80f949_0e5b9155","line":65,"in_reply_to":"fa80f949_685fb5e5","updated":"2015-11-05 18:04:33.000000000","message":"Done.","commit_id":"85d41c4b5ca57f7b18ab30a6cb9823989abfe6be"}],"neutron/plugins/ml2/drivers/type_flat.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"143587a5ef2dbb360c24b1e4aa74927f4cafe9b2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                default\u003d[],"},{"line_number":33,"context_line":"                help\u003d_(\"List of physical_network names with which flat \""},{"line_number":34,"context_line":"                       \"networks can be created. Empty, by default, allows \""},{"line_number":35,"context_line":"                       \"flat networks with arbitrary physical_network names .\""},{"line_number":36,"context_line":"                       \"The \u0027*\u0027 to allow arbitrary physical_network names \""},{"line_number":37,"context_line":"                       \"is deprecated.\"))"},{"line_number":38,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_54325260","line":35,"updated":"2015-04-01 11:47:41.000000000","message":"nit: redundant space after \u0027names\u0027. And space missing after the dot.","commit_id":"d54f0fab81cd27b94fb0f25680b37fdc4d5a6d7a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"143587a5ef2dbb360c24b1e4aa74927f4cafe9b2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def _parse_networks(self, entries):"},{"line_number":72,"context_line":"        self.flat_networks \u003d entries"},{"line_number":73,"context_line":"        if \u0027*\u0027 in self.flat_networks:"},{"line_number":74,"context_line":"            LOG.warn(_LW(\"The value \u0027*\u0027 to allow arbitrary flat \""},{"line_number":75,"context_line":"                         \"physical_network names is deprecated.\"))"},{"line_number":76,"context_line":"            self.flat_networks \u003d []"},{"line_number":77,"context_line":"        elif not all(self.flat_networks):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_94f7ba58","line":74,"updated":"2015-04-01 11:47:41.000000000","message":"Please use report_deprecated_feature from neutron.openstack.common.versionutils.","commit_id":"d54f0fab81cd27b94fb0f25680b37fdc4d5a6d7a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"4b614af9f7d2dc1433dbec7b6b8de1533f7cdc69","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            LOG.warn(_LW(\"The value \u0027*\u0027 to allow arbitrary flat \""},{"line_number":75,"context_line":"                         \"physical_network names is deprecated.\"))"},{"line_number":76,"context_line":"            self.flat_networks \u003d []"},{"line_number":77,"context_line":"        elif not all(self.flat_networks):"},{"line_number":78,"context_line":"            msg \u003d _(\"physical network name is empty\")"},{"line_number":79,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":80,"context_line":"        if self.flat_networks:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab921fb_51a948de","line":77,"updated":"2015-04-24 14:56:37.000000000","message":"I believe usage of all is the bug. The developer probably did not consider all([]) returns True. This is an error so silly I wonder how comes I\u0027m not the author of this line","commit_id":"d54f0fab81cd27b94fb0f25680b37fdc4d5a6d7a"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"df4262c649a011ce7c586fe07000eac4d548a8f8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            LOG.info(_LI(\"Arbitrary flat physical_network names allowed\"))"},{"line_number":75,"context_line":"            self.flat_networks \u003d None"},{"line_number":76,"context_line":"        elif not self.flat_networks:"},{"line_number":77,"context_line":"            LOG.info(_LI(\"Flat physical_network names are empty\"))"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            LOG.info(_LI(\"Allowable flat physical_network names: %s\"),"},{"line_number":80,"context_line":"                     self.flat_networks)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_7896c04d","line":77,"updated":"2015-11-05 07:47:16.000000000","message":"Adding some information about \"flat network is disabled\" will be good.","commit_id":"2de152a9208badcbfbf41266545618b164ae8da4"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"a955b74114e5248d6cad5e9c523d5c1eaf0622d4","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            LOG.info(_LI(\"Arbitrary flat physical_network names allowed\"))"},{"line_number":75,"context_line":"            self.flat_networks \u003d None"},{"line_number":76,"context_line":"        elif not self.flat_networks:"},{"line_number":77,"context_line":"            LOG.info(_LI(\"Flat physical_network names are empty\"))"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            LOG.info(_LI(\"Allowable flat physical_network names: %s\"),"},{"line_number":80,"context_line":"                     self.flat_networks)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_153172ec","line":77,"in_reply_to":"fa80f949_7896c04d","updated":"2015-11-05 12:55:18.000000000","message":"Yes, makes sense. Updated.","commit_id":"2de152a9208badcbfbf41266545618b164ae8da4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8eadf619c5e1e2d3624506897be7cd22062434d6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        physical_network \u003d segment.get(api.PHYSICAL_NETWORK)"},{"line_number":93,"context_line":"        if not physical_network:"},{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if self.flat_networks and physical_network not in self.flat_networks:"},{"line_number":97,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"},{"line_number":98,"context_line":"                   % physical_network)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_dbc7b110","line":95,"updated":"2015-11-04 23:40:04.000000000","message":"I think this needs to be updated to \u0027if self.flat_networks is not None and physical_network not in self.flat_networks\u0027 so we differentiate between the wildcard and an empty list. Otherwise we won\u0027t fail on an empty list as expected.","commit_id":"2de152a9208badcbfbf41266545618b164ae8da4"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"a955b74114e5248d6cad5e9c523d5c1eaf0622d4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        physical_network \u003d segment.get(api.PHYSICAL_NETWORK)"},{"line_number":93,"context_line":"        if not physical_network:"},{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if self.flat_networks and physical_network not in self.flat_networks:"},{"line_number":97,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"},{"line_number":98,"context_line":"                   % physical_network)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_b561863b","line":95,"in_reply_to":"fa80f949_dbc7b110","updated":"2015-11-05 12:55:18.000000000","message":"Sorry, my bad. I confused our discussion on IRC and thought it meant to pass through. Agreed, updated.","commit_id":"2de152a9208badcbfbf41266545618b164ae8da4"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"df4262c649a011ce7c586fe07000eac4d548a8f8","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if not physical_network:"},{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if self.flat_networks and physical_network not in self.flat_networks:"},{"line_number":97,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"},{"line_number":98,"context_line":"                   % physical_network)"},{"line_number":99,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_58badc0b","line":96,"updated":"2015-11-05 07:47:16.000000000","message":"Agree with Kevin.","commit_id":"2de152a9208badcbfbf41266545618b164ae8da4"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"a955b74114e5248d6cad5e9c523d5c1eaf0622d4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if not physical_network:"},{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if self.flat_networks and physical_network not in self.flat_networks:"},{"line_number":97,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"},{"line_number":98,"context_line":"                   % physical_network)"},{"line_number":99,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_955ec274","line":96,"in_reply_to":"fa80f949_58badc0b","updated":"2015-11-05 12:55:18.000000000","message":"Ditto, as above.","commit_id":"2de152a9208badcbfbf41266545618b164ae8da4"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"74d2cb61eae5eef0f2522c0a9548093b11a24fda","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if not physical_network:"},{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if self.flat_networks is not None and len(self.flat_networks) \u003d\u003d 0:"},{"line_number":97,"context_line":"            msg \u003d _(\"Flat provider network is disabled\")"},{"line_number":98,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":99,"context_line":"        if self.flat_networks and physical_network not in self.flat_networks:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_a12701b5","line":96,"updated":"2015-11-05 14:34:36.000000000","message":"Quoted from [1], \"For sequences, (strings, lists, tuples), use the fact that empty sequences are false.\"\n\nSo using len here is not appropriated.\n\n[1] https://www.python.org/dev/peps/pep-0008/","commit_id":"23599b3c34f2f4ea3b4d9b0d400992a20d6c1175"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"7d1b48fb2235e10beabc7a4802913b7d758db277","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if not physical_network:"},{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if self.flat_networks is not None and len(self.flat_networks) \u003d\u003d 0:"},{"line_number":97,"context_line":"            msg \u003d _(\"Flat provider network is disabled\")"},{"line_number":98,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":99,"context_line":"        if self.flat_networks and physical_network not in self.flat_networks:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_2179d1c8","line":96,"in_reply_to":"fa80f949_a12701b5","updated":"2015-11-05 14:48:12.000000000","message":"Hong Hui: sure, thanks for informing me. Updated.","commit_id":"23599b3c34f2f4ea3b4d9b0d400992a20d6c1175"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"22b15939e3faa6f6cb594a192d2da49fd6c9eedf","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    cfg.ListOpt(\u0027flat_networks\u0027,"},{"line_number":33,"context_line":"                default\u003d\u0027*\u0027,"},{"line_number":34,"context_line":"                help\u003d_(\"List of physical_network names with which flat \""},{"line_number":35,"context_line":"                       \"networks can be created. Use default \u0027*\u0027 to allow flat\""},{"line_number":36,"context_line":"                       \" networks with arbitrary physical_network names.\""},{"line_number":37,"context_line":"                       \"Use empty to disable flat networks.\"))"},{"line_number":38,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_b463bedb","line":35,"updated":"2015-11-05 15:48:27.000000000","message":"please have the space at the end of the line","commit_id":"7974dddae6d99539a13858fab560193dee66ac7a"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"2b20b28082021063507be954b37a0e9254d24fa1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    cfg.ListOpt(\u0027flat_networks\u0027,"},{"line_number":33,"context_line":"                default\u003d\u0027*\u0027,"},{"line_number":34,"context_line":"                help\u003d_(\"List of physical_network names with which flat \""},{"line_number":35,"context_line":"                       \"networks can be created. Use default \u0027*\u0027 to allow flat\""},{"line_number":36,"context_line":"                       \" networks with arbitrary physical_network names.\""},{"line_number":37,"context_line":"                       \"Use empty to disable flat networks.\"))"},{"line_number":38,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_bd308102","line":35,"in_reply_to":"fa80f949_94c0fae1","updated":"2015-11-05 16:54:01.000000000","message":"Moved around the text to get rid of space in ps 7.","commit_id":"7974dddae6d99539a13858fab560193dee66ac7a"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"5c9f668775b95e3fbfd7454a9e98bcfc81ad1d12","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    cfg.ListOpt(\u0027flat_networks\u0027,"},{"line_number":33,"context_line":"                default\u003d\u0027*\u0027,"},{"line_number":34,"context_line":"                help\u003d_(\"List of physical_network names with which flat \""},{"line_number":35,"context_line":"                       \"networks can be created. Use default \u0027*\u0027 to allow flat\""},{"line_number":36,"context_line":"                       \" networks with arbitrary physical_network names.\""},{"line_number":37,"context_line":"                       \"Use empty to disable flat networks.\"))"},{"line_number":38,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_94c0fae1","line":35,"in_reply_to":"fa80f949_b463bedb","updated":"2015-11-05 16:34:57.000000000","message":"I would like to but unfortunately I have reached the PEP8 limit of 79 characters. It seems the only way is to do it this way with space at start of line.","commit_id":"7974dddae6d99539a13858fab560193dee66ac7a"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e2681feea2dffd784f8d0faf7a946acc178b7512","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                help\u003d_(\"List of physical_network names with which flat \""},{"line_number":35,"context_line":"                       \"networks can be created. Use default \u0027*\u0027 to allow \""},{"line_number":36,"context_line":"                       \"flat networks with arbitrary physical_network names. \""},{"line_number":37,"context_line":"                       \"Use empty to disable flat networks.\"))"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"cfg.CONF.register_opts(flat_opts, \"ml2_type_flat\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_c868218a","line":37,"updated":"2015-11-05 17:12:31.000000000","message":"empty -\u003e an empty list","commit_id":"85d41c4b5ca57f7b18ab30a6cb9823989abfe6be"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"479b3d74080646cf6c7b040a920409f33ef037cd","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                help\u003d_(\"List of physical_network names with which flat \""},{"line_number":35,"context_line":"                       \"networks can be created. Use default \u0027*\u0027 to allow \""},{"line_number":36,"context_line":"                       \"flat networks with arbitrary physical_network names. \""},{"line_number":37,"context_line":"                       \"Use empty to disable flat networks.\"))"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"cfg.CONF.register_opts(flat_opts, \"ml2_type_flat\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_290a0f22","line":37,"in_reply_to":"fa80f949_c868218a","updated":"2015-11-05 18:04:33.000000000","message":"Done.","commit_id":"85d41c4b5ca57f7b18ab30a6cb9823989abfe6be"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e2681feea2dffd784f8d0faf7a946acc178b7512","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if self.flat_networks is not None and not self.flat_networks:"},{"line_number":97,"context_line":"            msg \u003d _(\"Flat provider network is disabled\")"},{"line_number":98,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":99,"context_line":"        if self.flat_networks and physical_network not in self.flat_networks:"},{"line_number":100,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_081dc90e","line":97,"updated":"2015-11-05 17:12:31.000000000","message":"network is -\u003e networks are","commit_id":"85d41c4b5ca57f7b18ab30a6cb9823989abfe6be"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"479b3d74080646cf6c7b040a920409f33ef037cd","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            msg \u003d _(\"physical_network required for flat provider network\")"},{"line_number":95,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":96,"context_line":"        if self.flat_networks is not None and not self.flat_networks:"},{"line_number":97,"context_line":"            msg \u003d _(\"Flat provider network is disabled\")"},{"line_number":98,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":99,"context_line":"        if self.flat_networks and physical_network not in self.flat_networks:"},{"line_number":100,"context_line":"            msg \u003d (_(\"physical_network \u0027%s\u0027 unknown for flat provider network\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_2921af9f","line":97,"in_reply_to":"fa80f949_081dc90e","updated":"2015-11-05 18:04:33.000000000","message":"Done.","commit_id":"85d41c4b5ca57f7b18ab30a6cb9823989abfe6be"}],"neutron/tests/unit/ml2/test_type_flat.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"143587a5ef2dbb360c24b1e4aa74927f4cafe9b2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                          self.driver._parse_networks,"},{"line_number":60,"context_line":"                          entries\u003d[\u0027flat_net1\u0027, \u0027\u0027])"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_validate_provider_segment_without_physnet_restri_default(self):"},{"line_number":63,"context_line":"        config.cfg.CONF.reset()"},{"line_number":64,"context_line":"        _driver \u003d type_flat.FlatTypeDriver()"},{"line_number":65,"context_line":"        segment \u003d {api.NETWORK_TYPE: p_const.TYPE_FLAT,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_570b748e","line":62,"updated":"2015-04-01 11:47:41.000000000","message":"can we avoid trimming words? test case names serve as documentation.","commit_id":"d54f0fab81cd27b94fb0f25680b37fdc4d5a6d7a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"143587a5ef2dbb360c24b1e4aa74927f4cafe9b2","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                          entries\u003d[\u0027flat_net1\u0027, \u0027\u0027])"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_validate_provider_segment_without_physnet_restri_default(self):"},{"line_number":63,"context_line":"        config.cfg.CONF.reset()"},{"line_number":64,"context_line":"        _driver \u003d type_flat.FlatTypeDriver()"},{"line_number":65,"context_line":"        segment \u003d {api.NETWORK_TYPE: p_const.TYPE_FLAT,"},{"line_number":66,"context_line":"                   api.PHYSICAL_NETWORK: \u0027other_flat_net\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_97445cb7","line":63,"updated":"2015-04-01 11:47:41.000000000","message":"It seems you don\u0027t really rely on setUp(), but instead you \u0027undo\u0027 all the things it did for you. So how about having a separate class for that?","commit_id":"d54f0fab81cd27b94fb0f25680b37fdc4d5a6d7a"}],"neutron/tests/unit/plugins/ml2/drivers/test_type_flat.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"037ef672a65edf32623a046137aa4182c6b5caca","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        self.assertEqual(0, self.driver.get_mtu(\u0027physnet1\u0027))"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"class FlatTypeDefaultTest(testlib_api.SqlTestCase):"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def setUp(self):"},{"line_number":145,"context_line":"        super(FlatTypeDefaultTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_7f9d18bb","line":142,"updated":"2015-11-06 06:05:00.000000000","message":"does this need to inherit from SqlTestCase?","commit_id":"32d20b8166121cbc19150100ae10ca26d9b7988e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"2c9abfa211f270fca5145d0e303ac0f3139daa00","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        self.assertEqual(0, self.driver.get_mtu(\u0027physnet1\u0027))"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"class FlatTypeDefaultTest(testlib_api.SqlTestCase):"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def setUp(self):"},{"line_number":145,"context_line":"        super(FlatTypeDefaultTest, self).setUp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_537cc81e","line":142,"in_reply_to":"fa80f949_7f9d18bb","updated":"2015-11-06 09:42:23.000000000","message":"Correct, no need. Updated.","commit_id":"32d20b8166121cbc19150100ae10ca26d9b7988e"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"26651512bc8a6d427c60b760baf25ad7e3497d09","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def setUp(self):"},{"line_number":145,"context_line":"        super(FlatTypeDefaultTest, self).setUp()"},{"line_number":146,"context_line":"        self.driver \u003d type_flat.FlatTypeDriver()"},{"line_number":147,"context_line":"        self.session \u003d db.get_session()"},{"line_number":148,"context_line":"        self.driver.physnet_mtus \u003d []"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_validate_provider_segment_default(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_ec7c04b7","line":147,"updated":"2015-11-06 05:52:27.000000000","message":"Is self.session needed?","commit_id":"32d20b8166121cbc19150100ae10ca26d9b7988e"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"2c9abfa211f270fca5145d0e303ac0f3139daa00","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def setUp(self):"},{"line_number":145,"context_line":"        super(FlatTypeDefaultTest, self).setUp()"},{"line_number":146,"context_line":"        self.driver \u003d type_flat.FlatTypeDriver()"},{"line_number":147,"context_line":"        self.session \u003d db.get_session()"},{"line_number":148,"context_line":"        self.driver.physnet_mtus \u003d []"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def test_validate_provider_segment_default(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_1372c049","line":147,"in_reply_to":"fa80f949_ec7c04b7","updated":"2015-11-06 09:42:23.000000000","message":"Correct, not needed. Updated.","commit_id":"32d20b8166121cbc19150100ae10ca26d9b7988e"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ca56ffa3b55739182debae0f7ec324914c4a2493","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                          segment\u003dsegment)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_validate_provider_phynet_name_multiple(self):"},{"line_number":62,"context_line":"        self.driver._parse_networks([\u0027flat_net1\u0027, \u0027\u0027])"},{"line_number":63,"context_line":"        segment \u003d {api.NETWORK_TYPE: p_const.TYPE_FLAT,"},{"line_number":64,"context_line":"                   api.PHYSICAL_NETWORK: \u0027flat_net1\u0027}"},{"line_number":65,"context_line":"        self.driver.validate_provider_segment(segment)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa80f949_bab700f4","line":62,"updated":"2015-11-06 13:18:57.000000000","message":"I am not sure what the second element \u0027\u0027 here buys us in the testing. I would suggest to make the second element \u0027flat_net2\u0027 and add a verification that \u0027flat_net3\u0027 fails.","commit_id":"1ef8a279166e76adbe1f7d5f1c69c33026957a88"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"6a7a353661357809fa3f890bb9a9436b630098e7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                          segment\u003dsegment)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_validate_provider_phynet_name_multiple(self):"},{"line_number":62,"context_line":"        self.driver._parse_networks([\u0027flat_net1\u0027, \u0027\u0027])"},{"line_number":63,"context_line":"        segment \u003d {api.NETWORK_TYPE: p_const.TYPE_FLAT,"},{"line_number":64,"context_line":"                   api.PHYSICAL_NETWORK: \u0027flat_net1\u0027}"},{"line_number":65,"context_line":"        self.driver.validate_provider_segment(segment)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa80f949_6696dd94","line":62,"in_reply_to":"fa80f949_0b4d9cc3","updated":"2015-11-06 14:03:06.000000000","message":"Ok, will do.","commit_id":"1ef8a279166e76adbe1f7d5f1c69c33026957a88"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8d2353ec086f128d91324aa85b4f076ee238e474","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                          segment\u003dsegment)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_validate_provider_phynet_name_multiple(self):"},{"line_number":62,"context_line":"        self.driver._parse_networks([\u0027flat_net1\u0027, \u0027\u0027])"},{"line_number":63,"context_line":"        segment \u003d {api.NETWORK_TYPE: p_const.TYPE_FLAT,"},{"line_number":64,"context_line":"                   api.PHYSICAL_NETWORK: \u0027flat_net1\u0027}"},{"line_number":65,"context_line":"        self.driver.validate_provider_segment(segment)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa80f949_0b4d9cc3","line":62,"in_reply_to":"fa80f949_bab700f4","updated":"2015-11-06 13:56:13.000000000","message":"Actually, as you pointed out to me on IRC, setUp() sets flat_networks to [\u0027flat_net1\u0027, \u0027flat_net2\u0027], and the unsupported case is tested at line 79. So this \u0027_multiple\u0027 test case should validate both \u0027flat_net1\u0027 and \u0027flat_net2\u0027. Hopefully I am making sense now. Thanks for the discussion on IRC.","commit_id":"1ef8a279166e76adbe1f7d5f1c69c33026957a88"}]}