)]}'
{"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"790095001f207a8ab56133e9cbc0d0617baa285e","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def start_rpc_listeners(self):"},{"line_number":160,"context_line":"        LOG.info(_LI(\u0027Setting up RPC\u0027))"},{"line_number":161,"context_line":"        self.endpoints \u003d [rpc.RpcCallbacks(self.notifier, self.type_manager),"},{"line_number":162,"context_line":"                          securitygroups_rpc.SecurityGroupServerRpcCallback(),"},{"line_number":163,"context_line":"                          dvr_rpc.DVRServerRpcCallback(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_f8cf1a7d","line":160,"updated":"2015-04-08 23:27:19.000000000","message":"Is there a reason these messages are duplicated?  Would the methods both run (suggesting a need for differentiation)?","commit_id":"c6ead21c3850fd3427323a1a503a06ffd6074af0"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"b48a0397850e8faf6e110f32c3615ef45324e151","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        )"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def start_rpc_listeners(self):"},{"line_number":160,"context_line":"        LOG.info(_LI(\u0027Setting up RPC\u0027))"},{"line_number":161,"context_line":"        self.endpoints \u003d [rpc.RpcCallbacks(self.notifier, self.type_manager),"},{"line_number":162,"context_line":"                          securitygroups_rpc.SecurityGroupServerRpcCallback(),"},{"line_number":163,"context_line":"                          dvr_rpc.DVRServerRpcCallback(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_78b78ad8","line":160,"in_reply_to":"9aa53dc9_f8cf1a7d","updated":"2015-04-08 23:28:56.000000000","message":"Yeah both this method and the one in L3 service plugin run, and the logging is prefixed with the module/method name (I checked), so it\u0027s OK.","commit_id":"c6ead21c3850fd3427323a1a503a06ffd6074af0"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"3eafce77a19849353065a7364c3876d6708a1fde","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                                  fanout\u003dFalse)"},{"line_number":171,"context_line":"        servers \u003d self.conn.consume_in_threads()"},{"line_number":172,"context_line":"        LOG.info(_LI(\u0027Finished setting up RPC\u0027))"},{"line_number":173,"context_line":"        return servers"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _filter_nets_provider(self, context, networks, filters):"},{"line_number":176,"context_line":"        return [network"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_21a10b95","line":173,"updated":"2015-04-13 21:36:21.000000000","message":"nit: this strikes me as boiler-plate that a decorator could make cleaner","commit_id":"c6ead21c3850fd3427323a1a503a06ffd6074af0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a96aa05c726246a12610b24d4328c59535bc8227","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                                  fanout\u003dFalse)"},{"line_number":171,"context_line":"        servers \u003d self.conn.consume_in_threads()"},{"line_number":172,"context_line":"        LOG.info(_LI(\u0027Finished setting up RPC\u0027))"},{"line_number":173,"context_line":"        return servers"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _filter_nets_provider(self, context, networks, filters):"},{"line_number":176,"context_line":"        return [network"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_41dc17e4","line":173,"in_reply_to":"7aaa499b_21a10b95","updated":"2015-04-13 21:50:33.000000000","message":"I think we already have such a decorator, like used here:\n\nhttps://github.com/openstack/neutron/blob/master/neutron/db/dvr_mac_db.py\nhttps://github.com/openstack/neutron/blob/master/neutron/agent/l2population_rpc.py\n\nDo you want to use that instead?","commit_id":"c6ead21c3850fd3427323a1a503a06ffd6074af0"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"6e2ea474cd9183007a6f965c24d1a18e07d43b70","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                                  fanout\u003dFalse)"},{"line_number":171,"context_line":"        servers \u003d self.conn.consume_in_threads()"},{"line_number":172,"context_line":"        LOG.info(_LI(\u0027Finished setting up RPC\u0027))"},{"line_number":173,"context_line":"        return servers"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _filter_nets_provider(self, context, networks, filters):"},{"line_number":176,"context_line":"        return [network"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aaa499b_1c3d582b","line":173,"in_reply_to":"7aaa499b_41dc17e4","updated":"2015-04-13 22:31:25.000000000","message":"I didn\u0027t know that existed, yeah I\u0027ll use it. It\u0027s using debug level... I guess that\u0027s fine.","commit_id":"c6ead21c3850fd3427323a1a503a06ffd6074af0"}]}