)]}'
{"run_tests.sh":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"81bb5d56093f919f4e4e8cfe741526a37c006f2c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"coverage\u003d0"},{"line_number":56,"context_line":"verbose\u003d0"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"i18n_black_list\u003d\"quantum/plugins/cisco/tests/unit/ quantum/tests/unit/\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"for arg in \"$@\"; do"},{"line_number":61,"context_line":"  process_option $arg"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAMH%2F%2Fr8s%3D","line":58,"updated":"2012-11-30 15:12:01.000000000","message":"quantum/openstack should be in this list too","commit_id":"d45772e76ae7333c4ba891cbd4b0310c35326295"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"  echo \"  -f, --force              Force a clean re-build of the virtual environment. Useful when dependencies have been added.\""},{"line_number":11,"context_line":"  echo \"  -p, --pep8               Just run pep8\""},{"line_number":12,"context_line":"  echo \"  -P, --no-pep8            Don\u0027t run pep8\""},{"line_number":13,"context_line":"  echo \"  -i, --i18n               Just run i18n\""},{"line_number":14,"context_line":"  echo \"  -I, --no-i18n            Don\u0027t run i18n\""},{"line_number":15,"context_line":"  echo \"  -l, --pylint             Just run pylint\""},{"line_number":16,"context_line":"  echo \"  -v, --verbose            Run verbose pylint analysis\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAMX%2F%2F%2F2o%3D","line":13,"updated":"2012-12-03 00:51:07.000000000","message":"\"run i18n\" is not easy to understand. I prefer to a message like\n\"Check if I18N messages are used.\"","commit_id":"eccefde6ac76d1fcf17e8c1afdba678cf861b2c0"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"81bb5d56093f919f4e4e8cfe741526a37c006f2c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  echo \"  -f, --force              Force a clean re-build of the virtual environment. Useful when dependencies have been added.\""},{"line_number":11,"context_line":"  echo \"  -p, --pep8               Just run pep8\""},{"line_number":12,"context_line":"  echo \"  -P, --no-pep8            Don\u0027t run pep8\""},{"line_number":13,"context_line":"  echo \"  -i, --i18n               Just run i18n\""},{"line_number":14,"context_line":"  echo \"  -I, --no-i18n            Don\u0027t run i18n\""},{"line_number":15,"context_line":"  echo \"  -l, --pylint             Just run pylint\""},{"line_number":16,"context_line":"  echo \"  -v, --verbose            Run verbose pylint analysis\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAMX%2F%2F9I0%3D","line":13,"in_reply_to":"AAAAMX%2F%2F%2F2o%3D","updated":"2012-12-05 04:46:31.000000000","message":"Done, Thanks!","commit_id":"eccefde6ac76d1fcf17e8c1afdba678cf861b2c0"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":129,"context_line":"      # check log message didn\u0027t wrapped by _()"},{"line_number":130,"context_line":"      grep -H -n -E \"LOG.${checked_level}\\(\\\"\" $f"},{"line_number":131,"context_line":"      # check message of exception didn\u0027t wrapped by _() except HTTP* exception"},{"line_number":132,"context_line":"      grep -H -n -E \"raise .*HTTP.*[^_]\\(\\\"\" $f -v |grep -E \"raise .*[^_]\\(\\\"\""},{"line_number":133,"context_line":"    fi"},{"line_number":134,"context_line":"  done"},{"line_number":135,"context_line":"  return 0"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAMX%2F%2F%2F3g%3D","line":132,"updated":"2012-12-03 00:15:53.000000000","message":"How do u deal with these cases:\nmsg \u003d \"test\"\nLOG.debug(msg)\n\nand:\nclass TestException(object):\n       message \u003d \"noi18n\"","commit_id":"eccefde6ac76d1fcf17e8c1afdba678cf861b2c0"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"81bb5d56093f919f4e4e8cfe741526a37c006f2c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"      # check log message didn\u0027t wrapped by _()"},{"line_number":130,"context_line":"      grep -H -n -E \"LOG.${checked_level}\\(\\\"\" $f"},{"line_number":131,"context_line":"      # check message of exception didn\u0027t wrapped by _() except HTTP* exception"},{"line_number":132,"context_line":"      grep -H -n -E \"raise .*HTTP.*[^_]\\(\\\"\" $f -v |grep -E \"raise .*[^_]\\(\\\"\""},{"line_number":133,"context_line":"    fi"},{"line_number":134,"context_line":"  done"},{"line_number":135,"context_line":"  return 0"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAMX%2F%2F9Iw%3D","line":132,"in_reply_to":"AAAAMX%2F%2F%2F3g%3D","updated":"2012-12-05 04:46:31.000000000","message":"thanks for point this out, I prepare use python compiler module rewrite this patch. That will cover this case","commit_id":"eccefde6ac76d1fcf17e8c1afdba678cf861b2c0"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"unresolved":false,"context_lines":[{"line_number":55,"context_line":"coverage\u003d0"},{"line_number":56,"context_line":"verbose\u003d0"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"i18n_black_list\u003d\"quantum/plugins/cisco/tests/unit/ quantum/tests/unit/ quantum/openstack\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"for arg in \"$@\"; do"},{"line_number":61,"context_line":"  process_option $arg"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAMX%2F%2F89w%3D","line":58,"updated":"2012-12-05 08:54:59.000000000","message":"I missing one \u0027quantum/plugins/bigswitch/tests\u0027","commit_id":"16d1a1e67044cfc78d8c6f9956684a662bb51e09"}],"tools/check_i18n.py":[{"author":{"_account_id":6462,"name":"Zhou Zheng Sheng","email":"zhshzhou@linux.vnet.ibm.com","username":"zhshzhou"},"change_message_id":"44e89501060a9f25d96dfa46c904c7f4e43d3a0d","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def check_log_callfunc(n):"},{"line_number":33,"context_line":"    # LOG.xxx(\u0027hello %s\u0027 % xyz)"},{"line_number":34,"context_line":"    if isinstance(n.parent, compiler.ast.Mod):"},{"line_number":35,"context_line":"        n \u003d n.parent"},{"line_number":36,"context_line":"    if isinstance(n.parent, compiler.ast.CallFunc):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9GY%3D","line":33,"updated":"2012-12-05 06:27:29.000000000","message":"It looks it covers two cases.\n  # LOG.xxx(\u0027hello %s\u0027 % xyz)\n  # LOG.xxx(\u0027hello %s\u0027)","commit_id":"5c3abf4f198fe2cffd36dc68cfe5a5afa2ab21d5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def check_log_callfunc(n):"},{"line_number":33,"context_line":"    # LOG.xxx(\u0027hello %s\u0027 % xyz)"},{"line_number":34,"context_line":"    if isinstance(n.parent, compiler.ast.Mod):"},{"line_number":35,"context_line":"        n \u003d n.parent"},{"line_number":36,"context_line":"    if isinstance(n.parent, compiler.ast.CallFunc):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9F8%3D","line":33,"in_reply_to":"AAAAMX%2F%2F9GY%3D","updated":"2012-12-05 06:42:49.000000000","message":"Yes, this will cover two cases.","commit_id":"5c3abf4f198fe2cffd36dc68cfe5a5afa2ab21d5"},{"author":{"_account_id":6462,"name":"Zhou Zheng Sheng","email":"zhshzhou@linux.vnet.ibm.com","username":"zhshzhou"},"change_message_id":"44e89501060a9f25d96dfa46c904c7f4e43d3a0d","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def check_wrong_i18n_format(n):"},{"line_number":74,"context_line":"    # LOG.xxx(\u0027hello %s\u0027 % xyz)"},{"line_number":75,"context_line":"    if isinstance(n.parent, compiler.ast.Mod):"},{"line_number":76,"context_line":"        n \u003d n.parent"},{"line_number":77,"context_line":"    if isinstance(n.parent, compiler.ast.CallFunc):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9GQ%3D","line":74,"updated":"2012-12-05 06:27:29.000000000","message":"It seem this predicate checks\n  # _(\u0027hello %s\u0027 % xyz)\nNot\n  # LOG.xxx(\u0027hello %s\u0027 % xyz)","commit_id":"5c3abf4f198fe2cffd36dc68cfe5a5afa2ab21d5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def check_wrong_i18n_format(n):"},{"line_number":74,"context_line":"    # LOG.xxx(\u0027hello %s\u0027 % xyz)"},{"line_number":75,"context_line":"    if isinstance(n.parent, compiler.ast.Mod):"},{"line_number":76,"context_line":"        n \u003d n.parent"},{"line_number":77,"context_line":"    if isinstance(n.parent, compiler.ast.CallFunc):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9F4%3D","line":74,"in_reply_to":"AAAAMX%2F%2F9GQ%3D","updated":"2012-12-05 06:42:49.000000000","message":"Yes, you are right. I will update the comment.","commit_id":"5c3abf4f198fe2cffd36dc68cfe5a5afa2ab21d5"},{"author":{"_account_id":6462,"name":"Zhou Zheng Sheng","email":"zhshzhou@linux.vnet.ibm.com","username":"zhshzhou"},"change_message_id":"44e89501060a9f25d96dfa46c904c7f4e43d3a0d","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# Used for check message need be localized or not."},{"line_number":85,"context_line":"i18n_msg_checkers \u003d ["},{"line_number":86,"context_line":"    # [\u0027hello world\u0027, 1]"},{"line_number":87,"context_line":"    (lambda n: isinstance(n.parent, compiler.ast.List), \u0027skip\u0027, \u0027\u0027),"},{"line_number":88,"context_line":"    # {\u0027hellow world\u0027, 1}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9G4%3D","line":85,"updated":"2012-12-05 06:27:29.000000000","message":"i18n_msg_predicates maybe a better name","commit_id":"5c3abf4f198fe2cffd36dc68cfe5a5afa2ab21d5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# Used for check message need be localized or not."},{"line_number":85,"context_line":"i18n_msg_checkers \u003d ["},{"line_number":86,"context_line":"    # [\u0027hello world\u0027, 1]"},{"line_number":87,"context_line":"    (lambda n: isinstance(n.parent, compiler.ast.List), \u0027skip\u0027, \u0027\u0027),"},{"line_number":88,"context_line":"    # {\u0027hellow world\u0027, 1}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9Fs%3D","line":85,"in_reply_to":"AAAAMX%2F%2F9G4%3D","updated":"2012-12-05 06:42:49.000000000","message":"Done, Thanks!","commit_id":"5c3abf4f198fe2cffd36dc68cfe5a5afa2ab21d5"},{"author":{"_account_id":6462,"name":"Zhou Zheng Sheng","email":"zhshzhou@linux.vnet.ibm.com","username":"zhshzhou"},"change_message_id":"44e89501060a9f25d96dfa46c904c7f4e43d3a0d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    (check_log_callfunc, \u0027error\u0027, \u0027Message must be localized\u0027),"},{"line_number":108,"context_line":"    # raise x.y.xx()"},{"line_number":109,"context_line":"    (check_raise_exception, \u0027error\u0027, \u0027Message must be localized\u0027),"},{"line_number":110,"context_line":"    # _(\u0027hello %s\u0027 % xyz) should be _(\u0027hello %s\u0027 % xyz)"},{"line_number":111,"context_line":"    (check_wrong_i18n_format, \u0027error\u0027,"},{"line_number":112,"context_line":"     (\"Message format was wrong, _(\u0027hello %s\u0027 % xyz) \""},{"line_number":113,"context_line":"      \"should be _(\u0027hello %s\u0027 % xyz)\")),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9Gk%3D","line":110,"updated":"2012-12-05 06:27:29.000000000","message":"Do you mean \"_(\u0027hello %s\u0027 % xyz) should be  _(\u0027hello %s\u0027 ) % xyz\" ?","commit_id":"5c3abf4f198fe2cffd36dc68cfe5a5afa2ab21d5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"unresolved":false,"context_lines":[{"line_number":107,"context_line":"    (check_log_callfunc, \u0027error\u0027, \u0027Message must be localized\u0027),"},{"line_number":108,"context_line":"    # raise x.y.xx()"},{"line_number":109,"context_line":"    (check_raise_exception, \u0027error\u0027, \u0027Message must be localized\u0027),"},{"line_number":110,"context_line":"    # _(\u0027hello %s\u0027 % xyz) should be _(\u0027hello %s\u0027 % xyz)"},{"line_number":111,"context_line":"    (check_wrong_i18n_format, \u0027error\u0027,"},{"line_number":112,"context_line":"     (\"Message format was wrong, _(\u0027hello %s\u0027 % xyz) \""},{"line_number":113,"context_line":"      \"should be _(\u0027hello %s\u0027 % xyz)\")),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9Fw%3D","line":110,"in_reply_to":"AAAAMX%2F%2F9Gk%3D","updated":"2012-12-05 06:42:49.000000000","message":"Yes, thanks, I will update the coment","commit_id":"5c3abf4f198fe2cffd36dc68cfe5a5afa2ab21d5"},{"author":{"_account_id":6462,"name":"Zhou Zheng Sheng","email":"zhshzhou@linux.vnet.ibm.com","username":"zhshzhou"},"change_message_id":"44e89501060a9f25d96dfa46c904c7f4e43d3a0d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    # raise x.y.xx()"},{"line_number":109,"context_line":"    (check_raise_exception, \u0027error\u0027, \u0027Message must be localized\u0027),"},{"line_number":110,"context_line":"    # _(\u0027hello %s\u0027 % xyz) should be _(\u0027hello %s\u0027 % xyz)"},{"line_number":111,"context_line":"    (check_wrong_i18n_format, \u0027error\u0027,"},{"line_number":112,"context_line":"     (\"Message format was wrong, _(\u0027hello %s\u0027 % xyz) \""},{"line_number":113,"context_line":"      \"should be _(\u0027hello %s\u0027 % xyz)\")),"},{"line_number":114,"context_line":"    # default"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9G0%3D","line":111,"updated":"2012-12-05 06:27:29.000000000","message":"I think it\u0027s more readable if these \"check_xxx\" function names are changed to \"is_xxx\".","commit_id":"5c3abf4f198fe2cffd36dc68cfe5a5afa2ab21d5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"unresolved":false,"context_lines":[{"line_number":108,"context_line":"    # raise x.y.xx()"},{"line_number":109,"context_line":"    (check_raise_exception, \u0027error\u0027, \u0027Message must be localized\u0027),"},{"line_number":110,"context_line":"    # _(\u0027hello %s\u0027 % xyz) should be _(\u0027hello %s\u0027 % xyz)"},{"line_number":111,"context_line":"    (check_wrong_i18n_format, \u0027error\u0027,"},{"line_number":112,"context_line":"     (\"Message format was wrong, _(\u0027hello %s\u0027 % xyz) \""},{"line_number":113,"context_line":"      \"should be _(\u0027hello %s\u0027 % xyz)\")),"},{"line_number":114,"context_line":"    # default"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9FE%3D","line":111,"in_reply_to":"AAAAMX%2F%2F9G0%3D","updated":"2012-12-05 06:42:49.000000000","message":"Done","commit_id":"5c3abf4f198fe2cffd36dc68cfe5a5afa2ab21d5"},{"author":{"_account_id":6462,"name":"Zhou Zheng Sheng","email":"zhshzhou@linux.vnet.ibm.com","username":"zhshzhou"},"change_message_id":"44e89501060a9f25d96dfa46c904c7f4e43d3a0d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    # _(\u0027hello %s\u0027 % xyz) should be _(\u0027hello %s\u0027 % xyz)"},{"line_number":111,"context_line":"    (check_wrong_i18n_format, \u0027error\u0027,"},{"line_number":112,"context_line":"     (\"Message format was wrong, _(\u0027hello %s\u0027 % xyz) \""},{"line_number":113,"context_line":"      \"should be _(\u0027hello %s\u0027 % xyz)\")),"},{"line_number":114,"context_line":"    # default"},{"line_number":115,"context_line":"    (lambda n: True, \u0027warn\u0027, \u0027Message might need localized\u0027)"},{"line_number":116,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9Go%3D","line":113,"updated":"2012-12-05 06:27:29.000000000","message":"What does it mean by \" _(\u0027hello %s\u0027 % xyz) should be _(\u0027hello %s\u0027 % xyz)\"? The two formats look the same.\n\nDo you mean \"_(\u0027hello %s\u0027 % xyz) should be _(\u0027hello %s\u0027 ) % xyz\" ?","commit_id":"5c3abf4f198fe2cffd36dc68cfe5a5afa2ab21d5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"unresolved":false,"context_lines":[{"line_number":110,"context_line":"    # _(\u0027hello %s\u0027 % xyz) should be _(\u0027hello %s\u0027 % xyz)"},{"line_number":111,"context_line":"    (check_wrong_i18n_format, \u0027error\u0027,"},{"line_number":112,"context_line":"     (\"Message format was wrong, _(\u0027hello %s\u0027 % xyz) \""},{"line_number":113,"context_line":"      \"should be _(\u0027hello %s\u0027 % xyz)\")),"},{"line_number":114,"context_line":"    # default"},{"line_number":115,"context_line":"    (lambda n: True, \u0027warn\u0027, \u0027Message might need localized\u0027)"},{"line_number":116,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F9Fo%3D","line":113,"in_reply_to":"AAAAMX%2F%2F9Go%3D","updated":"2012-12-05 06:42:49.000000000","message":"Yes, you are right, thanks!","commit_id":"5c3abf4f198fe2cffd36dc68cfe5a5afa2ab21d5"},{"author":{"_account_id":6462,"name":"Zhou Zheng Sheng","email":"zhshzhou@linux.vnet.ibm.com","username":"zhshzhou"},"change_message_id":"44e89501060a9f25d96dfa46c904c7f4e43d3a0d","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def is_wrong_i18n_format(n):"},{"line_number":72,"context_line":"    # check LOG.xxx(_(\u0027hello %s\u0027 % xyz))"},{"line_number":73,"context_line":"    if isinstance(n.parent, compiler.ast.Mod):"},{"line_number":74,"context_line":"        n \u003d n.parent"},{"line_number":75,"context_line":"    if isinstance(n.parent, compiler.ast.CallFunc):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMX%2F%2F9Ds%3D","line":72,"updated":"2012-12-05 07:00:08.000000000","message":"I thought you said you would delete \"LOG.xxx\" from the comment. In the code block below I can not find which line checks the \"LOG.xxx\" call.","commit_id":"5bd5f196bcd7ee9db2c605174d25596ed9c1302f"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def is_wrong_i18n_format(n):"},{"line_number":72,"context_line":"    # check LOG.xxx(_(\u0027hello %s\u0027 % xyz))"},{"line_number":73,"context_line":"    if isinstance(n.parent, compiler.ast.Mod):"},{"line_number":74,"context_line":"        n \u003d n.parent"},{"line_number":75,"context_line":"    if isinstance(n.parent, compiler.ast.CallFunc):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMX%2F%2F9Dg%3D","line":72,"in_reply_to":"AAAAMX%2F%2F9Ds%3D","updated":"2012-12-05 07:11:22.000000000","message":"you are right, I miss this. Thanks!","commit_id":"5bd5f196bcd7ee9db2c605174d25596ed9c1302f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import compiler"},{"line_number":18,"context_line":"from compiler.visitor import ASTVisitor"},{"line_number":19,"context_line":"import imp"},{"line_number":20,"context_line":"import os.path"},{"line_number":21,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMX%2F%2F5Pk%3D","line":18,"updated":"2012-12-10 07:45:18.000000000","message":"Do we need this if you have already imported compiler.\nWhy not use compiler.visitiro.ACVisitor in the code?","commit_id":"3d692c4aece8931d558f88fe0497cef0d451af1b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import compiler"},{"line_number":18,"context_line":"from compiler.visitor import ASTVisitor"},{"line_number":19,"context_line":"import imp"},{"line_number":20,"context_line":"import os.path"},{"line_number":21,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMX%2F%2F5M4%3D","line":18,"in_reply_to":"AAAAMX%2F%2F5Pk%3D","updated":"2012-12-10 08:40:38.000000000","message":"No special reason, just for input short. I\u0027m ok with \u0027compiler.visitiro.ACVisitor\u0027","commit_id":"3d692c4aece8931d558f88fe0497cef0d451af1b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def visitConst(self, node):"},{"line_number":57,"context_line":"        if not isinstance(node.value, str):"},{"line_number":58,"context_line":"                return"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if is_localized(node):"},{"line_number":61,"context_line":"            for (checker, msg) in self.msg_format_checkers:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMX%2F%2F5Pg%3D","line":58,"updated":"2012-12-10 07:45:18.000000000","message":"indentation","commit_id":"3d692c4aece8931d558f88fe0497cef0d451af1b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def visitConst(self, node):"},{"line_number":57,"context_line":"        if not isinstance(node.value, str):"},{"line_number":58,"context_line":"                return"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if is_localized(node):"},{"line_number":61,"context_line":"            for (checker, msg) in self.msg_format_checkers:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMX%2F%2F5M0%3D","line":58,"in_reply_to":"AAAAMX%2F%2F5Pg%3D","updated":"2012-12-10 08:40:38.000000000","message":"Thanks! Done","commit_id":"3d692c4aece8931d558f88fe0497cef0d451af1b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":60,"context_line":"        if is_localized(node):"},{"line_number":61,"context_line":"            for (checker, msg) in self.msg_format_checkers:"},{"line_number":62,"context_line":"                if checker(node):"},{"line_number":63,"context_line":"                    print \u003e\u003e sys.stderr, ("},{"line_number":64,"context_line":"                        \u0027%s:%d %s: %s\u0027 %"},{"line_number":65,"context_line":"                        (self.filename, node.lineno,"},{"line_number":66,"context_line":"                         self.lines[node.lineno - 1][:-1],"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMX%2F%2F5PY%3D","line":63,"updated":"2012-12-10 07:45:18.000000000","message":"is it worthwhile logging these to a file?","commit_id":"3d692c4aece8931d558f88fe0497cef0d451af1b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"unresolved":false,"context_lines":[{"line_number":60,"context_line":"        if is_localized(node):"},{"line_number":61,"context_line":"            for (checker, msg) in self.msg_format_checkers:"},{"line_number":62,"context_line":"                if checker(node):"},{"line_number":63,"context_line":"                    print \u003e\u003e sys.stderr, ("},{"line_number":64,"context_line":"                        \u0027%s:%d %s: %s\u0027 %"},{"line_number":65,"context_line":"                        (self.filename, node.lineno,"},{"line_number":66,"context_line":"                         self.lines[node.lineno - 1][:-1],"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAMX%2F%2F5Mw%3D","line":63,"in_reply_to":"AAAAMX%2F%2F5PY%3D","updated":"2012-12-10 08:40:38.000000000","message":"It \u0027Error\u0027 message, so I print it into \u0027stderr\u0027","commit_id":"3d692c4aece8931d558f88fe0497cef0d451af1b"}]}