)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9ba427961e96025e337a6357348f9038659473a0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"the policy.json file the enforce always evaluates a TrueCheck."},{"line_number":15,"context_line":"As a consequence not having context_is_admin in policy.json can"},{"line_number":16,"context_line":"be dangerous. However, since Havana policy.json is shipping with"},{"line_number":17,"context_line":"this policy."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Therefore this patch:"},{"line_number":20,"context_line":"- Removes the backward compatibility check, since it does not work"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dac4157f_bad8d2f0","line":17,"updated":"2015-04-20 13:49:50.000000000","message":"I think our discussion in irc revealed that it\u0027s not really the case, so it\u0027s better to clean up the commit message not to scare people too much (the thing described above would suggest that some deployments with old policy.json files could be exposed to unauthorized access being granted to everyone!)","commit_id":"5e7643667abb440dc0864eee56ce0e077cb39e1f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"6e7b6470892bdf033a32a2d09aedb75fa732cc07","unresolved":false,"context_lines":[{"line_number":14,"context_line":"the policy.json file the enforce always evaluates a TrueCheck."},{"line_number":15,"context_line":"As a consequence not having context_is_admin in policy.json can"},{"line_number":16,"context_line":"be dangerous. However, since Havana policy.json is shipping with"},{"line_number":17,"context_line":"this policy."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Therefore this patch:"},{"line_number":20,"context_line":"- Removes the backward compatibility check, since it does not work"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dac4157f_155af183","line":17,"in_reply_to":"dac4157f_bad8d2f0","updated":"2015-04-20 14:08:12.000000000","message":"Done","commit_id":"5e7643667abb440dc0864eee56ce0e077cb39e1f"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"308a513282ffd0585fc82a1c1aa0ec48bc51b14a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"- Removes the backward compatibility check, since it does not work"},{"line_number":21,"context_line":"- Fails, for safety, check_is_admin if \u0027context_is_admin\u0027 policy is"},{"line_number":22,"context_line":"  not specified"},{"line_number":23,"context_line":"- Fixeds check_is_advsvc in the same way (the backward compatibility"},{"line_number":24,"context_line":"  check never made any sense for this function)"},{"line_number":25,"context_line":"- Fixes unit tests adding appropriate tests for check_is_admin and"},{"line_number":26,"context_line":"  check_is_advsvc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab921fb_a5d8a51e","line":23,"range":{"start_line":23,"start_character":2,"end_line":23,"end_character":8},"updated":"2015-04-23 15:59:07.000000000","message":"Fixes","commit_id":"4625c45a30ffe09fbd29c16337e64e264de75bd8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"4c994357db6a5f47c8249af304b12a9d2bf25cf1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"- Removes the backward compatibility check, since it does not work"},{"line_number":21,"context_line":"- Fails, for safety, check_is_admin if \u0027context_is_admin\u0027 policy is"},{"line_number":22,"context_line":"  not specified"},{"line_number":23,"context_line":"- Fixeds check_is_advsvc in the same way (the backward compatibility"},{"line_number":24,"context_line":"  check never made any sense for this function)"},{"line_number":25,"context_line":"- Fixes unit tests adding appropriate tests for check_is_admin and"},{"line_number":26,"context_line":"  check_is_advsvc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab921fb_ecf1c16b","line":23,"in_reply_to":"bab921fb_a5d8a51e","updated":"2015-04-24 08:13:15.000000000","message":"Done","commit_id":"4625c45a30ffe09fbd29c16337e64e264de75bd8"}],"neutron/tests/unit/test_policy.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ce6fcb1fa404f8ec79858e648872b15fe2bcd98c","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    def test_nonadmin_read_on_shared_succeeds(self):"},{"line_number":339,"context_line":"        self._test_nonadmin_action_on_attr(\u0027get\u0027, \u0027shared\u0027, True)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def test_check_is_admin_with_admin_context_succeds(self):"},{"line_number":342,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":343,"context_line":"        self.assertTrue(policy.check_is_admin(admin_context))"},{"line_number":344,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_5b1d4e65","line":341,"updated":"2015-04-20 01:50:57.000000000","message":"s/succeds/succeeds/","commit_id":"2864e5d0efe3090cb4f3bc238818177c898ae3a9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"ba92974c59d8079c7b0a59ac24c011384bcf8aa2","unresolved":false,"context_lines":[{"line_number":338,"context_line":"    def test_nonadmin_read_on_shared_succeeds(self):"},{"line_number":339,"context_line":"        self._test_nonadmin_action_on_attr(\u0027get\u0027, \u0027shared\u0027, True)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def test_check_is_admin_with_admin_context_succeds(self):"},{"line_number":342,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":343,"context_line":"        self.assertTrue(policy.check_is_admin(admin_context))"},{"line_number":344,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_d0cecf59","line":341,"in_reply_to":"dac4157f_5b1d4e65","updated":"2015-04-20 11:15:16.000000000","message":"Done","commit_id":"2864e5d0efe3090cb4f3bc238818177c898ae3a9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ce6fcb1fa404f8ec79858e648872b15fe2bcd98c","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":351,"context_line":"        self.assertFalse(policy.check_is_admin(admin_context))"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    def test_check_is_advsvc_with_admin_context(self):"},{"line_number":354,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":355,"context_line":"        self.assertFalse(policy.check_is_advsvc(admin_context))"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_bb0d8a39","line":353,"updated":"2015-04-20 01:50:57.000000000","message":"better to have the _fails/_succeeds suffix for consistency.","commit_id":"2864e5d0efe3090cb4f3bc238818177c898ae3a9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"ba92974c59d8079c7b0a59ac24c011384bcf8aa2","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":351,"context_line":"        self.assertFalse(policy.check_is_admin(admin_context))"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    def test_check_is_advsvc_with_admin_context(self):"},{"line_number":354,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":355,"context_line":"        self.assertFalse(policy.check_is_advsvc(admin_context))"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_50e2bfd6","line":353,"in_reply_to":"dac4157f_bb0d8a39","updated":"2015-04-20 11:15:16.000000000","message":"Done","commit_id":"2864e5d0efe3090cb4f3bc238818177c898ae3a9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ce6fcb1fa404f8ec79858e648872b15fe2bcd98c","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":355,"context_line":"        self.assertFalse(policy.check_is_advsvc(admin_context))"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def test_check_is_advsvc_with_svc_context(self):"},{"line_number":358,"context_line":"        svc_context \u003d context.Context(\u0027\u0027, \u0027svc\u0027, roles\u003d[\u0027advsvc\u0027])"},{"line_number":359,"context_line":"        self.assertTrue(policy.check_is_advsvc(svc_context))"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_9b13e65c","line":357,"updated":"2015-04-20 01:50:57.000000000","message":"ditto","commit_id":"2864e5d0efe3090cb4f3bc238818177c898ae3a9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"ba92974c59d8079c7b0a59ac24c011384bcf8aa2","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":355,"context_line":"        self.assertFalse(policy.check_is_advsvc(admin_context))"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def test_check_is_advsvc_with_svc_context(self):"},{"line_number":358,"context_line":"        svc_context \u003d context.Context(\u0027\u0027, \u0027svc\u0027, roles\u003d[\u0027advsvc\u0027])"},{"line_number":359,"context_line":"        self.assertTrue(policy.check_is_advsvc(svc_context))"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_f0d1d3fc","line":357,"in_reply_to":"dac4157f_9b13e65c","updated":"2015-04-20 11:15:16.000000000","message":"sure","commit_id":"2864e5d0efe3090cb4f3bc238818177c898ae3a9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ce6fcb1fa404f8ec79858e648872b15fe2bcd98c","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        svc_context \u003d context.Context(\u0027\u0027, \u0027svc\u0027, roles\u003d[\u0027advsvc\u0027])"},{"line_number":364,"context_line":"        self.assertFalse(policy.check_is_advsvc(svc_context))"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def test_check_is_advsvc_with_user_context(self):"},{"line_number":367,"context_line":"        self.assertFalse(policy.check_is_advsvc(self.context))"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def _test_enforce_adminonly_attribute(self, action, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_7b10124f","line":366,"updated":"2015-04-20 01:50:57.000000000","message":"ditto","commit_id":"2864e5d0efe3090cb4f3bc238818177c898ae3a9"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"ba92974c59d8079c7b0a59ac24c011384bcf8aa2","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        svc_context \u003d context.Context(\u0027\u0027, \u0027svc\u0027, roles\u003d[\u0027advsvc\u0027])"},{"line_number":364,"context_line":"        self.assertFalse(policy.check_is_advsvc(svc_context))"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def test_check_is_advsvc_with_user_context(self):"},{"line_number":367,"context_line":"        self.assertFalse(policy.check_is_advsvc(self.context))"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def _test_enforce_adminonly_attribute(self, action, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_b0db5b1b","line":366,"in_reply_to":"dac4157f_7b10124f","updated":"2015-04-20 11:15:16.000000000","message":"Done","commit_id":"2864e5d0efe3090cb4f3bc238818177c898ae3a9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"308a513282ffd0585fc82a1c1aa0ec48bc51b14a","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":355,"context_line":"        self.assertFalse(policy.check_is_advsvc(admin_context))"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def test_check_is_advsvc_with_svc_context_suceeds(self):"},{"line_number":358,"context_line":"        svc_context \u003d context.Context(\u0027\u0027, \u0027svc\u0027, roles\u003d[\u0027advsvc\u0027])"},{"line_number":359,"context_line":"        self.assertTrue(policy.check_is_advsvc(svc_context))"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_253a5537","line":357,"range":{"start_line":357,"start_character":46,"end_line":357,"end_character":53},"updated":"2015-04-23 15:59:07.000000000","message":"s/suceeds/succeeds/","commit_id":"4625c45a30ffe09fbd29c16337e64e264de75bd8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"4c994357db6a5f47c8249af304b12a9d2bf25cf1","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":355,"context_line":"        self.assertFalse(policy.check_is_advsvc(admin_context))"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def test_check_is_advsvc_with_svc_context_suceeds(self):"},{"line_number":358,"context_line":"        svc_context \u003d context.Context(\u0027\u0027, \u0027svc\u0027, roles\u003d[\u0027advsvc\u0027])"},{"line_number":359,"context_line":"        self.assertTrue(policy.check_is_advsvc(svc_context))"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bab921fb_acebc977","line":357,"in_reply_to":"bab921fb_253a5537","updated":"2015-04-24 08:13:15.000000000","message":"Done","commit_id":"4625c45a30ffe09fbd29c16337e64e264de75bd8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9213721ca610a435da38e49507bf564291d7cf44","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":355,"context_line":"        self.assertFalse(policy.check_is_advsvc(admin_context))"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def test_check_is_advsvc_with_svc_context_suceeds(self):"},{"line_number":358,"context_line":"        svc_context \u003d context.Context(\u0027\u0027, \u0027svc\u0027, roles\u003d[\u0027advsvc\u0027])"},{"line_number":359,"context_line":"        self.assertTrue(policy.check_is_advsvc(svc_context))"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abe1de1_34d3c93a","line":357,"in_reply_to":"bab921fb_acebc977","updated":"2015-04-27 13:07:25.000000000","message":"change has now been approved I will amend this with another patch","commit_id":"4625c45a30ffe09fbd29c16337e64e264de75bd8"}]}