)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"34936cdd0bd54d4582e9603520b18e828c181d75","unresolved":false,"context_lines":[{"line_number":11,"context_line":"reintroducing performance drop in later patches. It didn\u0027t play well"},{"line_number":12,"context_line":"with stable backports of the fix, where context was lost when doing the"},{"line_number":13,"context_line":"backport, that left the bug unfixed in stable/juno even though the patch"},{"line_number":14,"context_line":"was merged there [1]."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The patch adds an explicit note in the code that suggests not to add new"},{"line_number":17,"context_line":"LOG.debug inside the loop to avoid regression, and a unit test was added"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dac4157f_b2790496","line":14,"updated":"2015-04-20 22:36:48.000000000","message":"Is there supposed to be a footnote?  I\u0027m not sure what reference to go to.","commit_id":"eea51dfc8b99de84da8bc49c8d48c92a96b1277d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e70794ed965c9d130a5224fa3807584ab6852e73","unresolved":false,"context_lines":[{"line_number":11,"context_line":"reintroducing performance drop in later patches. It didn\u0027t play well"},{"line_number":12,"context_line":"with stable backports of the fix, where context was lost when doing the"},{"line_number":13,"context_line":"backport, that left the bug unfixed in stable/juno even though the patch"},{"line_number":14,"context_line":"was merged there [1]."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The patch adds an explicit note in the code that suggests not to add new"},{"line_number":17,"context_line":"LOG.debug inside the loop to avoid regression, and a unit test was added"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dac4157f_6a7da3b0","line":14,"in_reply_to":"dac4157f_b2790496","updated":"2015-04-21 09:07:47.000000000","message":"Apparently my head has a huge hole, that\u0027s why I often forget to actually specify footnotes. Thanks and fixed!","commit_id":"eea51dfc8b99de84da8bc49c8d48c92a96b1277d"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"d6307d2c36ebb3512724b93feb10c2f9a47188b2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"was merged there [1]."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The patch adds an explicit note in the code that suggests not to add new"},{"line_number":17,"context_line":"LOG.debug inside the loop to avoid regression, and a unit test was added"},{"line_number":18,"context_line":"to capture it."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Once the test is merged in master, it will be proposed for stable/juno"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dac4157f_3b9c8cbf","line":17,"updated":"2015-04-21 16:41:08.000000000","message":"it\u0027d be LOG.anything and not just LOG.debug","commit_id":"11423e5d3ff5470ea29213d5e99f7b8fe3864727"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"347aa5da1136a5f89dd01962558457e996494b28","unresolved":false,"context_lines":[{"line_number":484,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in self.network.subnets"},{"line_number":485,"context_line":"                                   if s.enable_dhcp]"},{"line_number":486,"context_line":"        # NOTE(ihrachyshka): the loop should not LOG.debug anything inside it,"},{"line_number":487,"context_line":"        # to avoid potential performance drop when lots of hosts are dumped"},{"line_number":488,"context_line":"        for (port, alloc, hostname, name) in self._iter_hosts():"},{"line_number":489,"context_line":"            if not alloc:"},{"line_number":490,"context_line":"                if getattr(port, \u0027extra_dhcp_opts\u0027, False):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_1edc4de3","line":487,"updated":"2015-04-20 16:50:49.000000000","message":"Good Idea!","commit_id":"b77d7866c263dd0791ecbc38e6a57d22b0225ec3"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"d6307d2c36ebb3512724b93feb10c2f9a47188b2","unresolved":false,"context_lines":[{"line_number":483,"context_line":"        LOG.debug(\u0027Building host file: %s\u0027, filename)"},{"line_number":484,"context_line":"        dhcp_enabled_subnet_ids \u003d [s.id for s in self.network.subnets"},{"line_number":485,"context_line":"                                   if s.enable_dhcp]"},{"line_number":486,"context_line":"        # NOTE(ihrachyshka): the loop should not LOG.debug anything inside it,"},{"line_number":487,"context_line":"        # to avoid potential performance drop when lots of hosts are dumped"},{"line_number":488,"context_line":"        for (port, alloc, hostname, name) in self._iter_hosts():"},{"line_number":489,"context_line":"            if not alloc:"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_9bab98d6","line":486,"updated":"2015-04-21 16:41:08.000000000","message":"The same issue would apply to LOG.anything","commit_id":"11423e5d3ff5470ea29213d5e99f7b8fe3864727"}],"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"347aa5da1136a5f89dd01962558457e996494b28","unresolved":false,"context_lines":[{"line_number":1410,"context_line":"        # The method logs twice, at the start of and the end. There should be"},{"line_number":1411,"context_line":"        # no other logs, no matter how many hosts there are to dump in the"},{"line_number":1412,"context_line":"        # file."},{"line_number":1413,"context_line":"        self.assertEqual(2, len(debug.call_args_list))"},{"line_number":1414,"context_line":""},{"line_number":1415,"context_line":"    def test_only_populates_dhcp_enabled_subnets(self):"},{"line_number":1416,"context_line":"        exp_host_name \u003d \u0027/dhcp/eeeeeeee-eeee-eeee-eeee-eeeeeeeeeeee/host\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_3e094c2d","line":1413,"updated":"2015-04-20 16:50:49.000000000","message":"self.assertEqual(debug.call_count, 2)","commit_id":"b77d7866c263dd0791ecbc38e6a57d22b0225ec3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1058475ed7f29da0834dd8d100bcdc65711a642d","unresolved":false,"context_lines":[{"line_number":1410,"context_line":"        # The method logs twice, at the start of and the end. There should be"},{"line_number":1411,"context_line":"        # no other logs, no matter how many hosts there are to dump in the"},{"line_number":1412,"context_line":"        # file."},{"line_number":1413,"context_line":"        self.assertEqual(2, len(debug.call_args_list))"},{"line_number":1414,"context_line":""},{"line_number":1415,"context_line":"    def test_only_populates_dhcp_enabled_subnets(self):"},{"line_number":1416,"context_line":"        exp_host_name \u003d \u0027/dhcp/eeeeeeee-eeee-eeee-eeee-eeeeeeeeeeee/host\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"dac4157f_9e9cd86a","line":1413,"in_reply_to":"dac4157f_3e094c2d","updated":"2015-04-20 16:54:56.000000000","message":"Thanks for suggestion. As for the order of the arguments... some people claim that the first argument should be the expected value. I don\u0027t like that, but neither I want to fight for that non-sense with other people, so I\u0027m leaving the order intact.","commit_id":"b77d7866c263dd0791ecbc38e6a57d22b0225ec3"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"d6307d2c36ebb3512724b93feb10c2f9a47188b2","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"                                  \u0027bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb\u0027],"},{"line_number":1404,"context_line":"                                 sorted(result))"},{"line_number":1405,"context_line":""},{"line_number":1406,"context_line":"    def test__output_hosts_file_debug_log_only_once(self):"},{"line_number":1407,"context_line":"        dm \u003d self._get_dnsmasq(FakeDualStackNetworkSingleDHCP())"},{"line_number":1408,"context_line":"        with mock.patch.object(dhcp.LOG, \u0027process\u0027) as process:"},{"line_number":1409,"context_line":"            process.return_value \u003d (\u0027fake_message\u0027, {})"}],"source_content_type":"text/x-python","patch_set":4,"id":"dac4157f_bb69bcc0","line":1406,"updated":"2015-04-21 16:41:08.000000000","message":"I suppose I\u0027d take out \"debug\" here now.  It\u0027s also twice instead of once.","commit_id":"11423e5d3ff5470ea29213d5e99f7b8fe3864727"}]}
