)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"599c52708d2a9d4c835d5c5394480d81f9939381","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jason Zhang \u003cbearovercloud@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2012-12-05 17:38:32 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deleted router interface from router when using MetaPlugin."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I670aa45c804e660ee4afb5359e0ab1347f369986"},{"line_number":10,"context_line":"Fixes: bug #1085276"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAMX%2F%2F79A%3D","line":7,"updated":"2012-12-06 02:19:10.000000000","message":"add more detail","commit_id":"bec6b6786b1216ec26a04a464bd93c076a03e57a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jason Zhang \u003czhesen@nttmcl.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2012-12-07 15:52:08 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deleted the interface from the router when using the MetaPlugin."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The router interface cannot be deleted since the MetaPlugin"},{"line_number":10,"context_line":"cannot get the flavor information from the port which has"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAANH%2F%2F8Lc%3D","line":7,"updated":"2013-03-02 12:19:36.000000000","message":"\"Deleted\" seems strange. This commit does not deleted the interface but fixes the bug related to deleting the router interface.","commit_id":"cedb18ff99bbaf2bfe4448f7b90f0c27564b147c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Also the router interface cannot be deleted when using"},{"line_number":18,"context_line":"the openvswitch plugin since the l3_port_check flag"},{"line_number":19,"context_line":"not passing to the openvswitch by MetaPlugin."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I670aa45c804e660ee4afb5359e0ab1347f369986"},{"line_number":22,"context_line":"Fixes: bug #1085276"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAANH%2F%2F8Lg%3D","line":19,"updated":"2013-03-02 12:19:36.000000000","message":"Is it specific to \"openvswitch\" plugin? If not it would be to remove it.","commit_id":"cedb18ff99bbaf2bfe4448f7b90f0c27564b147c"}],"quantum/agent/linux/interface.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"599c52708d2a9d4c835d5c5394480d81f9939381","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import abc"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import netaddr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import re"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F79M%3D","line":19,"updated":"2012-12-06 02:19:10.000000000","message":"blank line is not needed","commit_id":"bec6b6786b1216ec26a04a464bd93c076a03e57a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import abc"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import netaddr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import re"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F7qk%3D","line":19,"in_reply_to":"AAAAMX%2F%2F79M%3D","updated":"2012-12-06 11:45:40.000000000","message":"I think that new line here is ok. I think that this is part of the HACKING.rst rules","commit_id":"bec6b6786b1216ec26a04a464bd93c076a03e57a"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"599c52708d2a9d4c835d5c5394480d81f9939381","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import abc"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import netaddr"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import re"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from quantum.agent.linux import ip_lib"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F79I%3D","line":21,"updated":"2012-12-06 02:19:10.000000000","message":"ditto","commit_id":"bec6b6786b1216ec26a04a464bd93c076a03e57a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":281,"context_line":"        try:"},{"line_number":282,"context_line":"            return utils.execute(cmd, self.conf.root_helper)"},{"line_number":283,"context_line":"        except Exception as e:"},{"line_number":284,"context_line":"            LOG.error(_(\"Unable to execute %s. Exception: %s\"), cmd, e)"},{"line_number":285,"context_line":"            raise e"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def _get_device_plugin_tag(self, device_name, namespace\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F7q0%3D","line":284,"updated":"2012-12-06 11:45:40.000000000","message":"This should be a dictionary and %(cmd)s and %(e)s. This will help the translators","commit_id":"bec6b6786b1216ec26a04a464bd93c076a03e57a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":295,"context_line":"                    plugin_tag \u003d dev_info_item.strip().split(\u0027 \u0027)[1]"},{"line_number":296,"context_line":"                    return plugin_tag"},{"line_number":297,"context_line":"        except Exception as e:"},{"line_number":298,"context_line":"            LOG.error(_(\"Unable to execute %s. Exception: %s\"), cmd, e)"},{"line_number":299,"context_line":"            raise e"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def get_device_name(self, port):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAMX%2F%2F7q4%3D","line":298,"updated":"2012-12-06 11:45:40.000000000","message":"This should be a dictionary and %(cmd)s and %(e)s.\nThis will help the translators","commit_id":"bec6b6786b1216ec26a04a464bd93c076a03e57a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"864a81f96ec6758e6f5876b73d57f683759371c0","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        plugin_tag \u003d self._get_flavor_by_network_id(network_id)"},{"line_number":274,"context_line":"        cmd \u003d [\u0027ip\u0027, \u0027link\u0027, \u0027set\u0027, device_name, \u0027alias\u0027, plugin_tag]"},{"line_number":275,"context_line":"        if namespace:"},{"line_number":276,"context_line":"            cmd \u003d [\u0027ip\u0027, \u0027netns\u0027, \u0027exec\u0027, namespace] + cmd"},{"line_number":277,"context_line":"        try:"},{"line_number":278,"context_line":"            return utils.execute(cmd, self.conf.root_helper)"},{"line_number":279,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F6X0%3D","line":276,"updated":"2012-12-07 16:22:16.000000000","message":"You should be using the ip_lib methods here; however you will need to add set_alias support to the IpLinkCommand class.  \n\n\nns \u003d ip_lib.IPWrapper(self.conf.root_helper, namespace)\ndev \u003d ns.device(device_name)\ndev.link.set_alias(plugin_tag)","commit_id":"740e9bb232986eeeb9710593b3415080e445bb4e"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"864a81f96ec6758e6f5876b73d57f683759371c0","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            cmd \u003d [\u0027ip\u0027, \u0027netns\u0027, \u0027exec\u0027, namespace] + cmd"},{"line_number":288,"context_line":"        try:"},{"line_number":289,"context_line":"            dev_info \u003d utils.execute(cmd, self.conf.root_helper)"},{"line_number":290,"context_line":"            for dev_info_item in dev_info.split(\u0027\\n\u0027):"},{"line_number":291,"context_line":"                if re.match(\u0027alias\u0027, dev_info_item.strip()):"},{"line_number":292,"context_line":"                    plugin_tag \u003d dev_info_item.strip().split(\u0027 \u0027)[1]"},{"line_number":293,"context_line":"                    return plugin_tag"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F6Yc%3D","line":290,"updated":"2012-12-07 16:22:16.000000000","message":"This parsing is already done in ip_lib, you should add an alias property.  Then you can do:\n\nip_ns \u003d ip_lib.IPWrapper(self.conf.root_helper, namespace)\nip_dev \u003d ip_ns.device(device_name)\nreturn ip_dev.alias","commit_id":"740e9bb232986eeeb9710593b3415080e445bb4e"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":305,"context_line":"        driver \u003d self._get_driver_by_network_id(network_id)"},{"line_number":306,"context_line":"        driver.plug(network_id, port_id, device_name, mac_address,"},{"line_number":307,"context_line":"                    bridge\u003dbridge, namespace\u003dnamespace, prefix\u003dprefix)"},{"line_number":308,"context_line":"        self._set_device_plugin_tag(network_id, device_name, namespace)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def unplug(self, device_name, bridge\u003dNone, namespace\u003dNone, prefix\u003dNone):"},{"line_number":311,"context_line":"        plugin_tag \u003d self._get_device_plugin_tag(device_name, namespace)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F6sg%3D","line":308,"updated":"2012-12-07 05:29:24.000000000","message":"Does this not need to return the status of the driver.plug() operation?","commit_id":"740e9bb232986eeeb9710593b3415080e445bb4e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b6c7e1c28ab1f4f07446c3751f90383f3179a18a","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        driver \u003d self._get_driver_by_network_id(network_id)"},{"line_number":287,"context_line":"        ret \u003d driver.plug(network_id, port_id, device_name, mac_address,"},{"line_number":288,"context_line":"                          bridge\u003dbridge, namespace\u003dnamespace, prefix\u003dprefix)"},{"line_number":289,"context_line":"        self._set_device_plugin_tag(network_id, device_name, namespace)"},{"line_number":290,"context_line":"        return ret"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def unplug(self, device_name, bridge\u003dNone, namespace\u003dNone, prefix\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAANH%2F%2F8HE%3D","line":289,"updated":"2013-03-02 14:39:03.000000000","message":"We get flavor of same network by \u0027_get_flavor_by_network_id\u0027 both in this function and \u0027_get_driver_by_network_id\u0027. It is inefficiency.\n\nHow about just get flavor of network by \u0027_get_flavor_by_network_id\u0027 one times, and share the result for those two function?","commit_id":"cedb18ff99bbaf2bfe4448f7b90f0c27564b147c"},{"author":{"_account_id":4184,"name":"Jason Zhang","email":"zhesen@nttmcl.com","username":"zzs"},"unresolved":false,"context_lines":[{"line_number":291,"context_line":"        driver \u003d self._get_driver_by_network_id(network_id)"},{"line_number":292,"context_line":"        ret \u003d driver.plug(network_id, port_id, device_name, mac_address,"},{"line_number":293,"context_line":"                          bridge\u003dbridge, namespace\u003dnamespace, prefix\u003dprefix)"},{"line_number":294,"context_line":"        self._set_device_plugin_tag(network_id, device_name, namespace)"},{"line_number":295,"context_line":"        return ret"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def unplug(self, device_name, bridge\u003dNone, namespace\u003dNone, prefix\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F9wc%3D","line":294,"updated":"2013-03-05 03:16:29.000000000","message":"That\u0027s correct, It will be better we can optimize this part.\nAnd thank you for your suggestions","commit_id":"c3d789d659840a3e0ddf78a5523d535866a98657"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b6c7e1c28ab1f4f07446c3751f90383f3179a18a","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        driver \u003d self._get_driver_by_network_id(network_id)"},{"line_number":292,"context_line":"        ret \u003d driver.plug(network_id, port_id, device_name, mac_address,"},{"line_number":293,"context_line":"                          bridge\u003dbridge, namespace\u003dnamespace, prefix\u003dprefix)"},{"line_number":294,"context_line":"        self._set_device_plugin_tag(network_id, device_name, namespace)"},{"line_number":295,"context_line":"        return ret"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def unplug(self, device_name, bridge\u003dNone, namespace\u003dNone, prefix\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F96g%3D","line":294,"updated":"2013-03-05 01:58:44.000000000","message":"We get flavor of same network by \u0027_get_flavor_by_network_id\u0027 both in this function and \u0027_get_driver_by_network_id\u0027. It is inefficiency.\nHow about just get flavor of network by \u0027_get_flavor_by_network_id\u0027 one times, and share the result for those two function?","commit_id":"c3d789d659840a3e0ddf78a5523d535866a98657"}]}
