)]}'
{"quantum/db/l3_db.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b466688a1308c9c6a766f0db70b90544902f4ccc","unresolved":false,"context_lines":[{"line_number":857,"context_line":"            if len(fixed_ips) \u003e 1:"},{"line_number":858,"context_line":"                LOG.error(_(\"Ignoring multiple IPs on router port %s\") %"},{"line_number":859,"context_line":"                          port[\u0027id\u0027])"},{"line_number":860,"context_line":"                ports.remove(port)"},{"line_number":861,"context_line":"                continue"},{"line_number":862,"context_line":"            # Empty fixed_ips should not happen"},{"line_number":863,"context_line":"            fixed_ip \u003d fixed_ips[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F5N8%3D","side":"PARENT","line":860,"updated":"2012-12-10 08:09:46.000000000","message":"This change the function behavior. Now it\u0027s return value was some port is with key \u0027subnet\u0027 , some port isn\u0027t. I\u0027m not sure this is ok for l3 agent.\nI see the function \u0027_set_subnet_info\u0027 in quantum.agent.l3_agent:264, it only show error messsage for multi fixed_ip, maybe forget return from function.\n\nBut that function is invoked when add new ports. And router won\u0027t add port with multi fixed ip. So it shouldn\u0027t have problem.","commit_id":"2e043a5a785b452f8f7fcb104b12c0746ca4a513"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":857,"context_line":"            if len(fixed_ips) \u003e 1:"},{"line_number":858,"context_line":"                LOG.error(_(\"Ignoring multiple IPs on router port %s\") %"},{"line_number":859,"context_line":"                          port[\u0027id\u0027])"},{"line_number":860,"context_line":"                ports.remove(port)"},{"line_number":861,"context_line":"                continue"},{"line_number":862,"context_line":"            # Empty fixed_ips should not happen"},{"line_number":863,"context_line":"            fixed_ip \u003d fixed_ips[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F4yg%3D","side":"PARENT","line":860,"in_reply_to":"AAAAMX%2F%2F41o%3D","updated":"2012-12-10 19:41:40.000000000","message":"Hi,\nPlease ignore my previous comment. Alex, what you have written makes sense.\nNow that I have taken a better look at the code I understand it a little better. \nThe purpose is to populate the subnet for the port. If the port has more than one IP defined then the subnet will not be populated as it was done prior. So I think that we are ok. That is I agree with you - it should not be a problem.\nThanks\nGary","commit_id":"2e043a5a785b452f8f7fcb104b12c0746ca4a513"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":857,"context_line":"            if len(fixed_ips) \u003e 1:"},{"line_number":858,"context_line":"                LOG.error(_(\"Ignoring multiple IPs on router port %s\") %"},{"line_number":859,"context_line":"                          port[\u0027id\u0027])"},{"line_number":860,"context_line":"                ports.remove(port)"},{"line_number":861,"context_line":"                continue"},{"line_number":862,"context_line":"            # Empty fixed_ips should not happen"},{"line_number":863,"context_line":"            fixed_ip \u003d fixed_ips[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMX%2F%2F41o%3D","side":"PARENT","line":860,"in_reply_to":"AAAAMX%2F%2F5N8%3D","updated":"2012-12-10 18:56:39.000000000","message":"I do not think that the port should be deleted.","commit_id":"2e043a5a785b452f8f7fcb104b12c0746ca4a513"}]}