)]}'
{"quantum/tests/unit/test_api_v2_resource.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"690c3a6f73af768c786ad1ca4bc4bf9cb6907f13","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# @author: Zhongyue Luo, Intel Corporation."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import logging"},{"line_number":21,"context_line":"import unittest"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F33I%3D","line":20,"updated":"2012-12-11 15:11:21.000000000","message":"Any reason why not using the common logging?","commit_id":"58767c4eb3afaa41ffc1e17a3c80aa880fb19c7f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"5d8ee154563912499531dd8506bb3bb7ac8935a6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# @author: Zhongyue Luo, Intel Corporation."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import logging"},{"line_number":21,"context_line":"import unittest"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F314%3D","line":20,"updated":"2012-12-11 15:27:22.000000000","message":"I know it appears in other test files, but this isn\u0027t used any where is this file other than create LOG which is never used.  We should leave this out of new code.","commit_id":"58767c4eb3afaa41ffc1e17a3c80aa880fb19c7f"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":"# @author: Zhongyue Luo, Intel Corporation."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import logging"},{"line_number":21,"context_line":"import unittest"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F3Gg%3D","line":20,"in_reply_to":"AAAAMX%2F%2F314%3D","updated":"2012-12-12 02:59:34.000000000","message":"Done","commit_id":"58767c4eb3afaa41ffc1e17a3c80aa880fb19c7f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"5d8ee154563912499531dd8506bb3bb7ac8935a6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import logging"},{"line_number":21,"context_line":"import unittest"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import mock"},{"line_number":24,"context_line":"from webob import exc"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F31A%3D","line":21,"updated":"2012-12-11 15:27:22.000000000","message":"import unittest2 as unittest","commit_id":"58767c4eb3afaa41ffc1e17a3c80aa880fb19c7f"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import logging"},{"line_number":21,"context_line":"import unittest"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import mock"},{"line_number":24,"context_line":"from webob import exc"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F3Gc%3D","line":21,"in_reply_to":"AAAAMX%2F%2F31A%3D","updated":"2012-12-12 02:59:34.000000000","message":"Done","commit_id":"58767c4eb3afaa41ffc1e17a3c80aa880fb19c7f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"5d8ee154563912499531dd8506bb3bb7ac8935a6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from quantum import context"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class RequestTestCase(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F310%3D","line":32,"updated":"2012-12-11 15:27:22.000000000","message":"see above","commit_id":"58767c4eb3afaa41ffc1e17a3c80aa880fb19c7f"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"from quantum import context"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class RequestTestCase(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F3GY%3D","line":32,"in_reply_to":"AAAAMX%2F%2F310%3D","updated":"2012-12-12 02:59:34.000000000","message":"Done","commit_id":"58767c4eb3afaa41ffc1e17a3c80aa880fb19c7f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"5d8ee154563912499531dd8506bb3bb7ac8935a6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.assertEquals(self.req.context, ctxt)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_context_without_quantum_context(self):"},{"line_number":49,"context_line":"        self.assertEquals(self.req.context.is_admin, True)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class ResourceTestCase(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F31M%3D","line":49,"updated":"2012-12-11 15:27:22.000000000","message":"Use unittest2.\n\nself.assertTrue(self.req.context.is_admin)","commit_id":"58767c4eb3afaa41ffc1e17a3c80aa880fb19c7f"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.assertEquals(self.req.context, ctxt)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_context_without_quantum_context(self):"},{"line_number":49,"context_line":"        self.assertEquals(self.req.context.is_admin, True)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class ResourceTestCase(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F3JQ%3D","line":49,"in_reply_to":"AAAAMX%2F%2F31M%3D","updated":"2012-12-12 01:27:27.000000000","message":"The problem I have with assertTrue is that it first boolean casts the value and then does assertion. Since assertEquals does \u0027is\u0027 operation, I think it is more accurate. Any comments?","commit_id":"58767c4eb3afaa41ffc1e17a3c80aa880fb19c7f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"5d8ee154563912499531dd8506bb3bb7ac8935a6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.req \u003d wsgi_resource.Request({\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_best_match_content_type(self):"},{"line_number":37,"context_line":"        self.assertEquals(self.req.best_match_content_type(),"},{"line_number":38,"context_line":"                          \u0027application/json\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_context_with_quantum_context(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMX%2F%2F144%3D","line":37,"updated":"2012-12-13 01:13:08.000000000","message":"I missed this the other day... self.assertEquals is deprecated.  Since this is a new file we should move to the proper form whenever it is used in this file. \n\nself.assertEqual()","commit_id":"d4851e9f305618590f16e3313c5d0160e905460f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertEquals(self.req.context, ctxt)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_context_without_quantum_context(self):"},{"line_number":46,"context_line":"        self.assertEquals(self.req.context.is_admin, True)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class ResourceTestCase(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAMX%2F%2F24s%3D","line":46,"updated":"2012-12-12 10:26:05.000000000","message":"As Mark suggested - assertTrue?","commit_id":"d4851e9f305618590f16e3313c5d0160e905460f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"5d8ee154563912499531dd8506bb3bb7ac8935a6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.req \u003d wsgi_resource.Request({\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_best_match_content_type(self):"},{"line_number":37,"context_line":"        self.assertEquals(self.req.best_match_content_type(),"},{"line_number":38,"context_line":"                          \u0027application/json\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_context_with_quantum_context(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMX%2F%2F1PM%3D","line":37,"updated":"2012-12-13 15:50:22.000000000","message":"In the previous comments, I mentioned that this should be changed to self.assertEqual().  assertEquals() has been deprecated in 2.7 and we should avoid using it in new files.","commit_id":"fc8ffb2dc95e8cd462c29dafd7ef23c751ad37b3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"5d8ee154563912499531dd8506bb3bb7ac8935a6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def test_context_with_quantum_context(self):"},{"line_number":41,"context_line":"        ctxt \u003d context.Context(\u0027fake_user\u0027, \u0027fake_tenant\u0027)"},{"line_number":42,"context_line":"        self.req.environ[\u0027quantum.context\u0027] \u003d ctxt"},{"line_number":43,"context_line":"        self.assertEquals(self.req.context, ctxt)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_context_without_quantum_context(self):"},{"line_number":46,"context_line":"        self.assertTrue(self.req.context.is_admin)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAMX%2F%2F1PI%3D","line":43,"updated":"2012-12-13 15:50:22.000000000","message":"same as above","commit_id":"fc8ffb2dc95e8cd462c29dafd7ef23c751ad37b3"}]}