)]}'
{"id":"openstack%2Fneutron~17841","triplet_id":"openstack%2Fneutron~master~I9ff5ba6a44c32ba4cf04b6a75ea7fd30fc769d2c","project":"openstack/neutron","branch":"master","topic":"bug/1085456","hashtags":[],"change_id":"I9ff5ba6a44c32ba4cf04b6a75ea7fd30fc769d2c","subject":"Completes coverage of quantum.api.v2.resource","status":"MERGED","created":"2012-12-14 04:09:29.000000000","updated":"2012-12-14 04:09:29.000000000","submitted":"2012-12-14 04:09:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":13,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"30cf4d1f040455e3cb9064ad1805689ed9910601","_number":17841,"virtual_id_number":17841,"owner":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"value":2,"date":"2012-12-14 04:09:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":1,"date":"2012-12-14 04:09:29.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"all":[{"value":2,"date":"2012-12-14 04:09:29.000000000","_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-12-14 04:09:29.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"date":"2012-12-14 04:09:29.000000000","_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-12-14 04:09:29.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-12-14 04:09:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2012-12-14 04:09:29.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2012-12-14 04:09:29.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-12-14 04:09:29.000000000","updated_by":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"reviewer":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"state":"REVIEWER"}],"messages":[{"id":"9ddc47f33849842e04e2ec25e2bae324ba8fc88c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/17841/2/check/gate-quantum-merge/3099 : SUCCESS\n- http://logs.openstack.org/17841/2/check/gate-quantum-docs/2338 : FAILURE\n- http://logs.openstack.org/17841/2/check/gate-quantum-pep8/2958 : SUCCESS\n- http://logs.openstack.org/17841/2/check/gate-quantum-python26/2728 : FAILURE\n- http://logs.openstack.org/17841/2/check/gate-quantum-python27/2729 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"3ad7f5f82becd0c70265e6c24d77da843f465323","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 2:\n\nBuild failed\n\n- http://logs.openstack.org/17841/2/check/gate-quantum-merge/3100 : SUCCESS\n- http://logs.openstack.org/17841/2/check/gate-quantum-docs/2339 : FAILURE\n- http://logs.openstack.org/17841/2/check/gate-quantum-pep8/2959 : SUCCESS\n- http://logs.openstack.org/17841/2/check/gate-quantum-python26/2729 : SUCCESS\n- http://logs.openstack.org/17841/2/check/gate-quantum-python27/2730 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"167beae2322ee5bcf5a29f49e6fe7db78b820146","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 2:\n\nBuild failed\n\n- http://logs.openstack.org/17841/2/check/gate-quantum-merge/3101 : SUCCESS\n- http://logs.openstack.org/17841/2/check/gate-quantum-docs/2340 : FAILURE\n- http://logs.openstack.org/17841/2/check/gate-quantum-pep8/2960 : SUCCESS\n- http://logs.openstack.org/17841/2/check/gate-quantum-python26/2730 : SUCCESS\n- http://logs.openstack.org/17841/2/check/gate-quantum-python27/2731 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"3069e54d3e31b817b2e3480a856ec2a8848c8c26","author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"eb468caf11270d00bbdc024e4046be888e2ffe1b","author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 2: Work In Progress","accounts_in_message":[],"_revision_number":2},{"id":"d35499a5b21f198e2ed7c49901ce3369ffb04264","author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"58074d603362d023bd46217d442ca71c84c2aa91","author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"date":"2012-12-14 04:09:29.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"00642262e0170dc851929fcb724f8013328f74e7","author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 2: Ready For Review","accounts_in_message":[],"_revision_number":2},{"id":"45117b5528cef08e4ba8d5c7ae2c22a1cc24d585","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 3: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17841/3/check/gate-quantum-merge/3103 : SUCCESS\n- http://logs.openstack.org/17841/3/check/gate-quantum-docs/2342 : SUCCESS\n- http://logs.openstack.org/17841/3/check/gate-quantum-pep8/2962 : SUCCESS\n- http://logs.openstack.org/17841/3/check/gate-quantum-python26/2732 : SUCCESS\n- http://logs.openstack.org/17841/3/check/gate-quantum-python27/2733 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"690c3a6f73af768c786ad1ca4bc4bf9cb6907f13","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"9a8428665c19a1c157062c25e982c9fa0bc67fe8","author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 3: (3 inline comments)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"732173ef815e1477e404d3a4e10dfe90559530f0","author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"date":"2012-12-14 04:09:29.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"7068fa04a8ecea77bd3c3ea4a8bcd8bfdd5e1e20","author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 3: (1 inline comment)\n\nMark, I wrote a comment about assertTrue.","accounts_in_message":[],"_revision_number":3},{"id":"4228bdbf5d0a39e13e6b12c8dbf1be74efea0de0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 4: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17841/4/check/gate-quantum-merge/3111 : SUCCESS\n- http://logs.openstack.org/17841/4/check/gate-quantum-docs/2350 : SUCCESS\n- http://logs.openstack.org/17841/4/check/gate-quantum-pep8/2970 : SUCCESS\n- http://logs.openstack.org/17841/4/check/gate-quantum-python26/2740 : SUCCESS\n- http://logs.openstack.org/17841/4/check/gate-quantum-python27/2741 : SUCCESS\n","accounts_in_message":[],"_revision_number":4},{"id":"d3e00038b2611aff9345a0648d6b0c16314d43d7","author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"date":"2012-12-14 04:09:29.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"ae4c5e75fa92fe44c868409fc86c9306e75bfa42","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 5: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17841/5/check/gate-quantum-merge/3118 : SUCCESS\n- http://logs.openstack.org/17841/5/check/gate-quantum-docs/2357 : SUCCESS\n- http://logs.openstack.org/17841/5/check/gate-quantum-pep8/2977 : SUCCESS\n- http://logs.openstack.org/17841/5/check/gate-quantum-python26/2747 : SUCCESS\n- http://logs.openstack.org/17841/5/check/gate-quantum-python27/2748 : SUCCESS\n","accounts_in_message":[],"_revision_number":5},{"id":"58d160850eb3dc6482de81feabf54754ed792350","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 5: (1 inline comment)\n\nOne minor inline issue","accounts_in_message":[],"_revision_number":5},{"id":"5030c7d5ca0fdc1688b4765a4bd08c4c327cc0d5","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 5:\n\nI think that a purist would go for AssertTrue. I would prefer that is be used just to be consistent with the rest of the code. \nThanks\nGary","accounts_in_message":[],"_revision_number":5},{"id":"f0b917e02f1e8cb5bbbbaa845fa1664c77cab517","author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"date":"2012-12-14 04:09:29.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"413e66e4668bc11c9d020a32c75821d335d55be5","author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 5:\n\ngaryk, I left a comment on patch 3 about assertTrue. Its just my concern that assertTrue first casts the value to bool and then verifies if it is True. Therefore I think assertEquals which uses \u0027is\u0027 for validation would be more accurate here. Your thoughts?","accounts_in_message":[],"_revision_number":5},{"id":"16411b458948f6538e598e89b994d990d5ae9069","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 6: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17841/6/check/gate-quantum-merge/3122 : SUCCESS\n- http://logs.openstack.org/17841/6/check/gate-quantum-docs/2361 : SUCCESS\n- http://logs.openstack.org/17841/6/check/gate-quantum-pep8/2981 : SUCCESS\n- http://logs.openstack.org/17841/6/check/gate-quantum-python26/2751 : SUCCESS\n- http://logs.openstack.org/17841/6/check/gate-quantum-python27/2752 : SUCCESS\n","accounts_in_message":[],"_revision_number":6},{"id":"175a438b3da21cb12501e9446c69903bed5d5be4","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"37929aae63b611503cc69093c1d4eeb6d618f706","author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"date":"2012-12-14 04:09:29.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"69f46e86b8a33da48aacbd810726d8dcf6778145","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 7: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17841/7/check/gate-quantum-merge/3146 : SUCCESS\n- http://logs.openstack.org/17841/7/check/gate-quantum-docs/2385 : SUCCESS\n- http://logs.openstack.org/17841/7/check/gate-quantum-pep8/3005 : SUCCESS\n- http://logs.openstack.org/17841/7/check/gate-quantum-python26/2775 : SUCCESS\n- http://logs.openstack.org/17841/7/check/gate-quantum-python27/2776 : SUCCESS\n","accounts_in_message":[],"_revision_number":7},{"id":"fc7396a2bca42da25fe7bdde5af069736368f39b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 7: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":7},{"id":"7eb5766d54dbf2ae29c15a66540c732faea0cb12","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 7: Verified\n\nBuild successful\n\n- http://logs.openstack.org/17841/7/gate/gate-quantum-merge/3149 : SUCCESS\n- http://logs.openstack.org/17841/7/gate/gate-quantum-docs/2388 : SUCCESS\n- http://logs.openstack.org/17841/7/gate/gate-quantum-pep8/3008 : SUCCESS\n- http://logs.openstack.org/17841/7/gate/gate-quantum-python26/2778 : SUCCESS\n- http://logs.openstack.org/17841/7/gate/gate-quantum-python27/2779 : SUCCESS\n","accounts_in_message":[],"_revision_number":7},{"id":"a7e2a1ce51bf3ba39cc0756d3719420680091628","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 7: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":7},{"id":"b516d2cef91c07f8bc1ce8a4c58bbe2da73d4943","author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"date":"2012-12-14 04:09:29.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"5ccdd8b35724a974d4fa454dd807dd4e14438233","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 3: Works for me\n\nSmokeStack Results (patch set 3):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/54226\n\tOpenvSwitch (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/54224\n\tLinuxBridge (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/54225\n","accounts_in_message":[],"_revision_number":3},{"id":"39c3a802d123341c072e775a59a3beea7931cb92","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 4: Works for me\n\nSmokeStack Results (patch set 4):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/54404\n\tOpenvSwitch (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/54402\n\tLinuxBridge (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/54403\n","accounts_in_message":[],"_revision_number":4},{"id":"30eea711acffc2496ca243ab91e3fd1ecff94764","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 5: Works for me\n\nSmokeStack Results (patch set 5):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/54447\n\tOpenvSwitch (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/54445\n\tLinuxBridge (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/54446\n","accounts_in_message":[],"_revision_number":5},{"id":"1cc375887f63d69178736ef55d19a2d59ba33247","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 6: Works for me\n\nSmokeStack Results (patch set 6):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/54809\n\tOpenvSwitch (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/54807\n\tLinuxBridge (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/54808\n","accounts_in_message":[],"_revision_number":6},{"id":"02330acbd3a226894dd57ed482e27da25d142d34","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 7: Works for me\n\nSmokeStack Results (patch set 7):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/55143\n\tOpenvSwitch (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/55141\n\tLinuxBridge (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/55142\n","accounts_in_message":[],"_revision_number":7},{"id":"5d8ee154563912499531dd8506bb3bb7ac8935a6","author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\n(4 inline comments)\n\nThanks for increasing the coverage.  A minor nits to address.","accounts_in_message":[],"_revision_number":3},{"id":"864c3f9851a555bb3a34959f2aed4562bd2cc836","author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 5: (1 inline comment)\n\n@zylou  You are sacrificing code readability on a misplaced concern.  assertTrue is significantly faster.  \n\nThe short explanation is that assertEqual goes a lot of extra steps to arrive at \"if not first \u003d\u003d second\".  Where assertTrue jumps directly to \"if not expr\"\n\n(see http://hg.python.org/cpython/file/6c8a7469670b/Lib/unittest/case.py)  \n\nThe forms themselves have speed differences too:\n\nHere\u0027s the run times of the various forms:\n$ python -m timeit \"x \u003d 1 if not True \u003d\u003d True else 0\"\n10000000 loops, best of 3: 0.108 usec per loop\n$ python -m timeit \"x \u003d 1 if not True is True else 0\"\n10000000 loops, best of 3: 0.0914 usec per loop\n$ python -m timeit \"x \u003d 1 if not True  else 0\"\n10000000 loops, best of 3: 0.0546 usec per loop","accounts_in_message":[],"_revision_number":5},{"id":"38dc02ff4ef8db3c33d8114c5d703e93f3f660f1","author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 6: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"3a35d8c13cd3204313754055e458fc349634da0a","author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"date":"2012-12-14 04:09:29.000000000","message":"Patch Set 7: Looks good to me (core reviewer)\n\nThanks for your patience.","accounts_in_message":[],"_revision_number":7},{"id":"f60d0eacabb9c296cf840eec5d28da49bd5098a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-12-14 04:09:29.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"bdcf00cfb1bc89c8475c0dc1f1c981d9ee78bcd1","revisions":{"5a013fd20a431462d3f26a2329a7a6c7ce7949bb":{"kind":"REWORK","_number":1,"created":"2012-12-14 04:09:29.000000000","uploader":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"ref":"refs/changes/41/17841/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/41/17841/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/41/17841/1"}}},"commit":{"parents":[{"commit":"eb0ba3680a0f5cd5361fe5dcfb44697f4da62c7b","subject":"Merge \"Remove unnecessary port deletion\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/eb0ba3680a0f5cd5361fe5dcfb44697f4da62c7b"}]}],"author":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-11 07:22:26.000000000","tz":480},"committer":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-11 08:29:28.000000000","tz":480},"subject":"Completes coverage of quantum.api.v2.resource","message":"Completes coverage of quantum.api.v2.resource\n\nMoved current resource testcases to new test script\nCreated test cases\n\nFixes bug #1085456\n\nChange-Id: I9ff5ba6a44c32ba4cf04b6a75ea7fd30fc769d2c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/5a013fd20a431462d3f26a2329a7a6c7ce7949bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/5a013fd20a431462d3f26a2329a7a6c7ce7949bb"}]},"branch":"refs/heads/master"},"752eedd78f9875b1826d865550928486767c43ed":{"kind":"REWORK","_number":2,"created":"2012-12-14 04:09:29.000000000","uploader":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"ref":"refs/changes/41/17841/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/41/17841/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/41/17841/2"}}},"commit":{"parents":[{"commit":"eb0ba3680a0f5cd5361fe5dcfb44697f4da62c7b","subject":"Merge \"Remove unnecessary port deletion\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/eb0ba3680a0f5cd5361fe5dcfb44697f4da62c7b"}]}],"author":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-11 07:22:26.000000000","tz":480},"committer":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-11 08:32:28.000000000","tz":480},"subject":"Completes coverage of quantum.api.v2.resource","message":"Completes coverage of quantum.api.v2.resource\n\nMoved current resource testcases to new test script\nCreated test cases\n\nFixes bug #1085456\n\nChange-Id: I9ff5ba6a44c32ba4cf04b6a75ea7fd30fc769d2c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/752eedd78f9875b1826d865550928486767c43ed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/752eedd78f9875b1826d865550928486767c43ed"}]},"branch":"refs/heads/master"},"58767c4eb3afaa41ffc1e17a3c80aa880fb19c7f":{"kind":"REWORK","_number":3,"created":"2012-12-14 04:09:29.000000000","uploader":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"ref":"refs/changes/41/17841/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/41/17841/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/41/17841/3"}}},"commit":{"parents":[{"commit":"eb0ba3680a0f5cd5361fe5dcfb44697f4da62c7b","subject":"Merge \"Remove unnecessary port deletion\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/eb0ba3680a0f5cd5361fe5dcfb44697f4da62c7b"}]}],"author":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-11 07:22:26.000000000","tz":480},"committer":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-11 13:32:24.000000000","tz":480},"subject":"Completes coverage of quantum.api.v2.resource","message":"Completes coverage of quantum.api.v2.resource\n\nMoved current resource testcases to new test script\nCreated test cases\n\nFixes bug #1085456\n\nChange-Id: I9ff5ba6a44c32ba4cf04b6a75ea7fd30fc769d2c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/58767c4eb3afaa41ffc1e17a3c80aa880fb19c7f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/58767c4eb3afaa41ffc1e17a3c80aa880fb19c7f"}]},"branch":"refs/heads/master"},"461b412e5432c9cc6876c4caa80d4e4b44c054fd":{"kind":"REWORK","_number":4,"created":"2012-12-14 04:09:29.000000000","uploader":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"ref":"refs/changes/41/17841/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/41/17841/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/41/17841/4"}}},"commit":{"parents":[{"commit":"8e7fe17cafa70c3346e2a5d70da2d6e2637c338e","subject":"Merge \"Adds validity checks for ethertype and protocol\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/8e7fe17cafa70c3346e2a5d70da2d6e2637c338e"}]}],"author":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-11 07:22:26.000000000","tz":480},"committer":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-12 02:56:04.000000000","tz":480},"subject":"Completes coverage of quantum.api.v2.resource","message":"Completes coverage of quantum.api.v2.resource\n\nMoved current resource testcases to new test script\nCreated test cases\n\nFixes bug #1085456\n\nChange-Id: I9ff5ba6a44c32ba4cf04b6a75ea7fd30fc769d2c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/461b412e5432c9cc6876c4caa80d4e4b44c054fd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/461b412e5432c9cc6876c4caa80d4e4b44c054fd"}]},"branch":"refs/heads/master"},"d4851e9f305618590f16e3313c5d0160e905460f":{"kind":"REWORK","_number":5,"created":"2012-12-14 04:09:29.000000000","uploader":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"ref":"refs/changes/41/17841/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/41/17841/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/41/17841/5"}}},"commit":{"parents":[{"commit":"8e7fe17cafa70c3346e2a5d70da2d6e2637c338e","subject":"Merge \"Adds validity checks for ethertype and protocol\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/8e7fe17cafa70c3346e2a5d70da2d6e2637c338e"}]}],"author":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-11 07:22:26.000000000","tz":480},"committer":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-12 06:53:50.000000000","tz":480},"subject":"Completes coverage of quantum.api.v2.resource","message":"Completes coverage of quantum.api.v2.resource\n\nMoved current resource testcases to new test script\nCreated test cases\n\nFixes bug #1085456\n\nChange-Id: I9ff5ba6a44c32ba4cf04b6a75ea7fd30fc769d2c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/d4851e9f305618590f16e3313c5d0160e905460f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/d4851e9f305618590f16e3313c5d0160e905460f"}]},"branch":"refs/heads/master"},"fc8ffb2dc95e8cd462c29dafd7ef23c751ad37b3":{"kind":"REWORK","_number":6,"created":"2012-12-14 04:09:29.000000000","uploader":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"ref":"refs/changes/41/17841/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/41/17841/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/41/17841/6"}}},"commit":{"parents":[{"commit":"8e7fe17cafa70c3346e2a5d70da2d6e2637c338e","subject":"Merge \"Adds validity checks for ethertype and protocol\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/8e7fe17cafa70c3346e2a5d70da2d6e2637c338e"}]}],"author":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-11 07:22:26.000000000","tz":480},"committer":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-13 01:55:00.000000000","tz":480},"subject":"Completes coverage of quantum.api.v2.resource","message":"Completes coverage of quantum.api.v2.resource\n\nMoved current resource testcases to new test script\nCreated test cases\n\nFixes bug #1085456\n\nChange-Id: I9ff5ba6a44c32ba4cf04b6a75ea7fd30fc769d2c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/fc8ffb2dc95e8cd462c29dafd7ef23c751ad37b3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/fc8ffb2dc95e8cd462c29dafd7ef23c751ad37b3"}]},"branch":"refs/heads/master"},"bdcf00cfb1bc89c8475c0dc1f1c981d9ee78bcd1":{"kind":"REWORK","_number":7,"created":"2012-12-14 04:09:29.000000000","uploader":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"ref":"refs/changes/41/17841/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/41/17841/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/41/17841/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/41/17841/7"}}},"commit":{"parents":[{"commit":"8e7fe17cafa70c3346e2a5d70da2d6e2637c338e","subject":"Merge \"Adds validity checks for ethertype and protocol\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/8e7fe17cafa70c3346e2a5d70da2d6e2637c338e"}]}],"author":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-11 07:22:26.000000000","tz":480},"committer":{"name":"Zhongyue Luo","email":"zhongyue.nah@intel.com","date":"2012-12-14 01:22:18.000000000","tz":480},"subject":"Completes coverage of quantum.api.v2.resource","message":"Completes coverage of quantum.api.v2.resource\n\nMoved current resource testcases to new test script\nCreated test cases\n\nFixes bug #1085456\n\nChange-Id: I9ff5ba6a44c32ba4cf04b6a75ea7fd30fc769d2c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/bdcf00cfb1bc89c8475c0dc1f1c981d9ee78bcd1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/bdcf00cfb1bc89c8475c0dc1f1c981d9ee78bcd1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}