)]}'
{"neutron/api/rpc/handlers/dvr_rpc.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"f143e15339f572a799b6d992ca3c9a7e382095c9","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        LOG.debug(\"DVR Agent requests list of VM ports on host %s\", host)"},{"line_number":95,"context_line":"        return self.plugin.get_ports_on_host_by_subnet(context,"},{"line_number":96,"context_line":"            host, subnet)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_subnet_for_dvr(self, context, **kwargs):"},{"line_number":99,"context_line":"        fixed_ips \u003d kwargs.get(\u0027fixed_ips\u0027)"},{"line_number":100,"context_line":"        return self.plugin.get_subnet_for_dvr(context, fixed_ips)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_8c114daf","line":97,"updated":"2015-05-06 23:15:40.000000000","message":"You need to take care of backwards compatibility. You also need to bump the RPC minor version.","commit_id":"ee0767351ca8e94d8e57e6c4faa11009821b6c07"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"75cc5986f92c4741c81c7419c9d203be02585652","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        LOG.debug(\"DVR Agent requests list of VM ports on host %s\", host)"},{"line_number":95,"context_line":"        return self.plugin.get_ports_on_host_by_subnet(context,"},{"line_number":96,"context_line":"            host, subnet)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_subnet_for_dvr(self, context, **kwargs):"},{"line_number":99,"context_line":"        fixed_ips \u003d kwargs.get(\u0027fixed_ips\u0027)"},{"line_number":100,"context_line":"        return self.plugin.get_subnet_for_dvr(context, fixed_ips)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_bc437741","line":97,"in_reply_to":"1aca2d91_8c114daf","updated":"2015-06-17 17:51:23.000000000","message":"Hi Assaf, what will be the best way to deal with this situation.\n\nRight now we can\u0027t fix this issue with the current function signature to have backward compatability.\n\nWe have to change the function argument in this case. Will it be ok, if we change the rpc version but still have the same function with two arguments.\n\nget_subnet_for_dvr(self, context, subnet, fixed_ips) or is it better to change the function name with the new argument.","commit_id":"ee0767351ca8e94d8e57e6c4faa11009821b6c07"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"83bc07778bb09a4f12a4d240300b839089daddaa","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        LOG.debug(\"DVR Agent requests list of VM ports on host %s\", host)"},{"line_number":95,"context_line":"        return self.plugin.get_ports_on_host_by_subnet(context,"},{"line_number":96,"context_line":"            host, subnet)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_subnet_for_dvr(self, context, **kwargs):"},{"line_number":99,"context_line":"        fixed_ips \u003d kwargs.get(\u0027fixed_ips\u0027)"},{"line_number":100,"context_line":"        return self.plugin.get_subnet_for_dvr(context, fixed_ips)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_af587bfb","line":97,"in_reply_to":"1aca2d91_8c114daf","updated":"2015-05-06 23:51:00.000000000","message":"Yes will work on this.","commit_id":"ee0767351ca8e94d8e57e6c4faa11009821b6c07"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"ae8cd3f30731bc4037fc81233b6ce240b7c87c0d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        LOG.debug(\"DVR Agent requests list of VM ports on host %s\", host)"},{"line_number":95,"context_line":"        return self.plugin.get_ports_on_host_by_subnet(context,"},{"line_number":96,"context_line":"            host, subnet)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_subnet_for_dvr(self, context, **kwargs):"},{"line_number":99,"context_line":"        fixed_ips \u003d kwargs.get(\u0027fixed_ips\u0027)"},{"line_number":100,"context_line":"        return self.plugin.get_subnet_for_dvr(context, fixed_ips)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_791ad2c7","line":97,"in_reply_to":"fa32b979_bc437741","updated":"2015-07-08 23:37:01.000000000","message":"You need to bump the minor RPC version, and this method needs to check if it got either fixed_ips or subnet and do the right thing in either case. Assuming this patch merges for L you can remove the \u0027subnet\u0027 parameter handling in M, and you need to add a comment explaining all of this.\n\nThe idea is that if the server is upgraded before an agent (You can have either an L server with K agents, or an L server with a mix of K or L agents since those will be upgraded one by one), the server will return a correct response in all cases.","commit_id":"ee0767351ca8e94d8e57e6c4faa11009821b6c07"}]}
