)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"5c40147ead46067048d90f4d2e172b580be8c6aa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"bridge regardless if the port is added by the ovs agent or not. This"},{"line_number":11,"context_line":"is not right, and will result in tons of race conditions as described"},{"line_number":12,"context_line":"in the bug report. The change is to remove this method. It\u0027s been"},{"line_number":13,"context_line":"verified that the issure reported in"},{"line_number":14,"context_line":"https://bugs.launchpad.net/neutron/+bug/1333365 doesn\u0027t occur with"},{"line_number":15,"context_line":"this change."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3acd31a7_0c5afd83","line":13,"updated":"2015-04-29 21:02:11.000000000","message":"nit: typo: \"issue\"","commit_id":"80049e84878ceddd756ba81e25a856c54fa85f39"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"14e1e109bb2043784aed55f0605930b2c966ded5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"with an instance. When it happens, neutron should notify nova of the"},{"line_number":11,"context_line":"port deletion event so that Nova can take proper actions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Refer to I998b6bb80cc0a81d665b61b8c4a424d7219c666f for the nova patch"},{"line_number":14,"context_line":"that handles the event."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iff88cd12ae18017ef3e776821bcf3ecf3b4f052f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5afe65bd_0f0ac421","line":13,"updated":"2015-06-03 05:45:36.000000000","message":"This should have been\n\nDepends-on: I998b6bb80cc0a81d665b61b8c4a424d7219c666f\n\nNext time you have a dependent patch, follow this syntax and it\u0027ll prevent from accidental merge, in case the one which we depend on hasn\u0027t merged yet.","commit_id":"0ace88fd4a75ff213dc36fd16c1f8e7080ab7d6d"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"8773c545da1bc9748fcbe1afe9d6c682f8f5b6fe","unresolved":false,"context_lines":[{"line_number":10,"context_line":"with an instance. When it happens, neutron should notify nova of the"},{"line_number":11,"context_line":"port deletion event so that Nova can take proper actions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Refer to I998b6bb80cc0a81d665b61b8c4a424d7219c666f for the nova patch"},{"line_number":14,"context_line":"that handles the event."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iff88cd12ae18017ef3e776821bcf3ecf3b4f052f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5afe65bd_2796bbf0","line":13,"in_reply_to":"5afe65bd_0f0ac421","updated":"2015-06-03 12:11:59.000000000","message":"I wasn\u0027t thinking that the two patches are dependent, but wanted to provide a reference to the other patch that handles the event.","commit_id":"0ace88fd4a75ff213dc36fd16c1f8e7080ab7d6d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"24cdec43dd86dd12d3f743c8e6077cc510488394","unresolved":false,"context_lines":[{"line_number":10,"context_line":"with an instance. When it happens, neutron should notify nova of the"},{"line_number":11,"context_line":"port deletion event so that Nova can take proper actions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Refer to I998b6bb80cc0a81d665b61b8c4a424d7219c666f for the nova patch"},{"line_number":14,"context_line":"that handles the event."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iff88cd12ae18017ef3e776821bcf3ecf3b4f052f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5afe65bd_7aac3ca0","line":13,"in_reply_to":"5afe65bd_2796bbf0","updated":"2015-06-03 16:56:54.000000000","message":"Technically speaking they are though. Why do you say they aren\u0027t? The log noise proves that the two needs to go hand in hand. This is actually problematic when running Neutron Liberty with Nova kilo, so a better approach needs to be figured out anyway.","commit_id":"0ace88fd4a75ff213dc36fd16c1f8e7080ab7d6d"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"732e917f2d58aede1461673a41c1d36cff213362","unresolved":false,"context_lines":[{"line_number":10,"context_line":"with an instance. When it happens, neutron should notify nova of the"},{"line_number":11,"context_line":"port deletion event so that Nova can take proper actions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Refer to I998b6bb80cc0a81d665b61b8c4a424d7219c666f for the nova patch"},{"line_number":14,"context_line":"that handles the event."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iff88cd12ae18017ef3e776821bcf3ecf3b4f052f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5afe65bd_c9bb68e4","line":13,"in_reply_to":"5afe65bd_7aac3ca0","updated":"2015-06-03 18:48:01.000000000","message":"see comments in this review https://review.openstack.org/#/c/187868/1//COMMIT_MSG.\n\nI have no objections to make them hand in hand. I could have done that if somebody raised that earlier.\n\nI agree that it\u0027s not perfect. But I don\u0027t believe it\u0027s going to be problematic when running neutron liberty with nova kilo except for the extra noise.","commit_id":"0ace88fd4a75ff213dc36fd16c1f8e7080ab7d6d"}],"neutron/notifiers/nova.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"bda3f4b3e9961b9c2aeca32201229ce1f3dd86ed","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"VIF_UNPLUGGED \u003d \u0027network-vif-unplugged\u0027"},{"line_number":37,"context_line":"VIF_PLUGGED \u003d \u0027network-vif-plugged\u0027"},{"line_number":38,"context_line":"VIF_DELETED \u003d \u0027network-vif-deleted\u0027"},{"line_number":39,"context_line":"NEUTRON_NOVA_EVENT_STATUS_MAP \u003d {constants.PORT_STATUS_ACTIVE: \u0027completed\u0027,"},{"line_number":40,"context_line":"                                 constants.PORT_STATUS_ERROR: \u0027failed\u0027,"},{"line_number":41,"context_line":"                                 constants.PORT_STATUS_DOWN: \u0027completed\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_2bcb2d20","line":38,"updated":"2015-05-01 02:57:33.000000000","message":"I looked around in the nova tree and I don\u0027t see this event. Can you point me to it?","commit_id":"861e05a07b2c95114de3179336b7e1d296c8b1c9"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"316675391ddfbaf0c509d2287a1253fa3d9112c8","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"VIF_UNPLUGGED \u003d \u0027network-vif-unplugged\u0027"},{"line_number":37,"context_line":"VIF_PLUGGED \u003d \u0027network-vif-plugged\u0027"},{"line_number":38,"context_line":"VIF_DELETED \u003d \u0027network-vif-deleted\u0027"},{"line_number":39,"context_line":"NEUTRON_NOVA_EVENT_STATUS_MAP \u003d {constants.PORT_STATUS_ACTIVE: \u0027completed\u0027,"},{"line_number":40,"context_line":"                                 constants.PORT_STATUS_ERROR: \u0027failed\u0027,"},{"line_number":41,"context_line":"                                 constants.PORT_STATUS_DOWN: \u0027completed\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_bc509e5f","line":38,"in_reply_to":"3acd31a7_2bcb2d20","updated":"2015-05-01 13:19:39.000000000","message":"this is new, and it\u0027s going to be in the nova patch that I\u0027m about to submit","commit_id":"861e05a07b2c95114de3179336b7e1d296c8b1c9"}],"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"c5a262d86e7b6a00b2cc16254062150d36cf51e7","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        self.updated_ports.add(port[\u0027id\u0027])"},{"line_number":337,"context_line":"        LOG.debug(\"port_update message processed for port %s\", port[\u0027id\u0027])"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    def port_delete(self, context, **kwargs):"},{"line_number":340,"context_line":"        port_id \u003d kwargs.get(\u0027port_id\u0027)"},{"line_number":341,"context_line":"        port \u003d self.int_br.get_vif_port_by_id(port_id)"},{"line_number":342,"context_line":"        # If port exists, delete it"}],"source_content_type":"text/x-python","patch_set":3,"id":"3acd31a7_90f38c9e","side":"PARENT","line":339,"updated":"2015-05-01 00:57:19.000000000","message":"so don\u0027t remove these","commit_id":"c5188d8bf8493e4b075689f64251f85231e696a2"}],"neutron/tests/unit/notifiers/test_nova.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"8737b7ab05aec77c4b384911999e6afb5b706a08","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                          \u0027tag\u0027: port_id}"},{"line_number":305,"context_line":"        event \u003d self.nova_notifier.create_port_changed_event(\u0027delete_port\u0027,"},{"line_number":306,"context_line":"                                                             {}, returned_obj)"},{"line_number":307,"context_line":"        self.assertEqual(event, expected_event)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a0c5dc1_59e201a1","line":307,"updated":"2015-05-12 11:07:00.000000000","message":"it should be:\n\n  self.assertEqual(expected, observed)","commit_id":"59b6cc4c869536c15e71c5ab7c211d421fbccd84"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"a5ad7c8e68d31b1cab68404ed16337bc3fd892d4","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                          \u0027tag\u0027: port_id}"},{"line_number":305,"context_line":"        event \u003d self.nova_notifier.create_port_changed_event(\u0027delete_port\u0027,"},{"line_number":306,"context_line":"                                                             {}, returned_obj)"},{"line_number":307,"context_line":"        self.assertEqual(event, expected_event)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a0c5dc1_0ea0b9f3","line":307,"in_reply_to":"9a0c5dc1_59e201a1","updated":"2015-05-12 13:14:51.000000000","message":"Done","commit_id":"59b6cc4c869536c15e71c5ab7c211d421fbccd84"}]}