)]}'
{"neutron/agent/l3/nat.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"777d6fb84e2b28219de91a1ab68d73a0f6fa2b3c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            (\u0027OUTPUT\u0027, \u0027-d %s -j DNAT --to %s\u0027 % (floating_ip, fixed_ip)),"},{"line_number":35,"context_line":"            (\u0027float-snat\u0027, \u0027-s %s -j SNAT --to %s\u0027 % (fixed_ip, floating_ip))]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def update_nats(self, nats):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        # Clear out all iptables rules for floating ips"},{"line_number":40,"context_line":"        nat_table \u003d self.iptables_manager.ipv4[\u0027nat\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_a8cdc65e","line":37,"updated":"2015-06-16 08:40:17.000000000","message":"what do you think about calling this method \"replace_nats\" or \"set_nats\" so it\u0027s clear it wipes out all existing translations?","commit_id":"239ccc06c922bbc9bbc656e335572e029e316ef9"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0ea5133363fd30b8fd4cad21dff14ef3d4ad3bbb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            (\u0027OUTPUT\u0027, \u0027-d %s -j DNAT --to %s\u0027 % (floating_ip, fixed_ip)),"},{"line_number":35,"context_line":"            (\u0027float-snat\u0027, \u0027-s %s -j SNAT --to %s\u0027 % (fixed_ip, floating_ip))]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def update_nats(self, nats):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        # Clear out all iptables rules for floating ips"},{"line_number":40,"context_line":"        nat_table \u003d self.iptables_manager.ipv4[\u0027nat\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_5e47144b","line":37,"in_reply_to":"fa32b979_a8cdc65e","updated":"2015-06-16 09:11:19.000000000","message":"set_nats!","commit_id":"239ccc06c922bbc9bbc656e335572e029e316ef9"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"777d6fb84e2b28219de91a1ab68d73a0f6fa2b3c","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def clean_nat_connections(self, device, ip):"},{"line_number":51,"context_line":"        \"\"\"Delete conntrack state associated with an IP address.\"\"\""},{"line_number":52,"context_line":"\tdevice.delete_conntrack_state(ip)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_48dc3a12","line":52,"updated":"2015-06-16 08:40:17.000000000","message":"^ some unicode char or something slipped in there?","commit_id":"239ccc06c922bbc9bbc656e335572e029e316ef9"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0ea5133363fd30b8fd4cad21dff14ef3d4ad3bbb","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def clean_nat_connections(self, device, ip):"},{"line_number":51,"context_line":"        \"\"\"Delete conntrack state associated with an IP address.\"\"\""},{"line_number":52,"context_line":"\tdevice.delete_conntrack_state(ip)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_de71e4a9","line":52,"in_reply_to":"fa32b979_48dc3a12","updated":"2015-06-16 09:11:19.000000000","message":"Done","commit_id":"239ccc06c922bbc9bbc656e335572e029e316ef9"}],"neutron/agent/linux/interface.py":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"9ae156a950efbb4ef5015cae791f208fb4a9b551","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        preserve_ips: list of ip cidrs that should not be removed from device"},{"line_number":87,"context_line":"        gateway_ips: For gateway ports, list of external gateway ip addresses"},{"line_number":88,"context_line":"        enable_ra_on_gw: Boolean to indicate configuring acceptance of IPv6 RA"},{"line_number":89,"context_line":"        ip_cleaner: Method to call on ip removal"},{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        device \u003d ip_lib.IPDevice(device_name, namespace\u003dnamespace)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a016987_f9cf037d","line":89,"updated":"2015-05-28 16:16:51.000000000","message":"I think this needs better documentation. The previous documentation for \"clean_connections\" should be incorporated. Perhaps the following:\n\nip_cleaner: Method to call to cleanup connections associated to the removed ips","commit_id":"21675f18cf09f030247bc6e1aac064f044bc15db"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"588cd366f8db069a1bcec0d5d53b8616dff1bf2b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        preserve_ips: list of ip cidrs that should not be removed from device"},{"line_number":87,"context_line":"        gateway_ips: For gateway ports, list of external gateway ip addresses"},{"line_number":88,"context_line":"        enable_ra_on_gw: Boolean to indicate configuring acceptance of IPv6 RA"},{"line_number":89,"context_line":"        ip_cleaner: Method to call on ip removal"},{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        device \u003d ip_lib.IPDevice(device_name, namespace\u003dnamespace)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5afe65bd_fb9cca5e","line":89,"in_reply_to":"7a016987_f9cf037d","updated":"2015-06-03 08:08:45.000000000","message":"init_l3 is no more responsible for cleaning connections but for calling ip_cleaner callback on ip removal. That\u0027s why the documentation is now in IptablesNatDriver[1].\n\n\n[1] https://review.openstack.org/#/c/181168/5/neutron/agent/l3/nat.py","commit_id":"21675f18cf09f030247bc6e1aac064f044bc15db"}],"neutron/tests/unit/agent/l3/test_nat.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"777d6fb84e2b28219de91a1ab68d73a0f6fa2b3c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        nat_table.assert_has_calls(calls)"},{"line_number":55,"context_line":"        self.iptables_manager.apply.assert_called_once_with()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_clean_nat_connections(self):"},{"line_number":58,"context_line":"        wrapper \u003d mock.Mock()"},{"line_number":59,"context_line":"        with mock.patch.object(ip_lib, \u0027IPWrapper\u0027, return_value\u003dwrapper):"},{"line_number":60,"context_line":"            self.driver.clean_nat_connections(\"fake-ns\", \"10.0.0.4\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_e8eaeeab","line":57,"updated":"2015-06-16 08:40:17.000000000","message":"I think these last 2 unit tests are enforcing a lot of specific behavior rather than outcomes. can you just write the functional test in such a way that the connection clearing is testing and then get rid of these unit tests?","commit_id":"239ccc06c922bbc9bbc656e335572e029e316ef9"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0ea5133363fd30b8fd4cad21dff14ef3d4ad3bbb","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        nat_table.assert_has_calls(calls)"},{"line_number":55,"context_line":"        self.iptables_manager.apply.assert_called_once_with()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_clean_nat_connections(self):"},{"line_number":58,"context_line":"        wrapper \u003d mock.Mock()"},{"line_number":59,"context_line":"        with mock.patch.object(ip_lib, \u0027IPWrapper\u0027, return_value\u003dwrapper):"},{"line_number":60,"context_line":"            self.driver.clean_nat_connections(\"fake-ns\", \"10.0.0.4\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_63f83f4a","line":57,"in_reply_to":"fa32b979_e8eaeeab","updated":"2015-06-16 09:11:19.000000000","message":"It\u0027s already the case, added functional tests fail if clean_nat_connections is not called","commit_id":"239ccc06c922bbc9bbc656e335572e029e316ef9"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"777d6fb84e2b28219de91a1ab68d73a0f6fa2b3c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        wrapper \u003d mock.Mock()"},{"line_number":59,"context_line":"        with mock.patch.object(ip_lib, \u0027IPWrapper\u0027, return_value\u003dwrapper):"},{"line_number":60,"context_line":"            self.driver.clean_nat_connections(\"fake-ns\", \"10.0.0.4\")"},{"line_number":61,"context_line":"            #raise Exception(wrapper.netns.execute.mock_calls)"},{"line_number":62,"context_line":"            calls \u003d ["},{"line_number":63,"context_line":"                mock.call([\"conntrack\", \"-D\", \"-d\", \"10.0.0.4\"],"},{"line_number":64,"context_line":"                          check_exit_code\u003dTrue, extra_ok_codes\u003d[1]),"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_88d242ff","line":61,"updated":"2015-06-16 08:40:17.000000000","message":"commented code","commit_id":"239ccc06c922bbc9bbc656e335572e029e316ef9"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0ea5133363fd30b8fd4cad21dff14ef3d4ad3bbb","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        wrapper \u003d mock.Mock()"},{"line_number":59,"context_line":"        with mock.patch.object(ip_lib, \u0027IPWrapper\u0027, return_value\u003dwrapper):"},{"line_number":60,"context_line":"            self.driver.clean_nat_connections(\"fake-ns\", \"10.0.0.4\")"},{"line_number":61,"context_line":"            #raise Exception(wrapper.netns.execute.mock_calls)"},{"line_number":62,"context_line":"            calls \u003d ["},{"line_number":63,"context_line":"                mock.call([\"conntrack\", \"-D\", \"-d\", \"10.0.0.4\"],"},{"line_number":64,"context_line":"                          check_exit_code\u003dTrue, extra_ok_codes\u003d[1]),"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_03c85321","line":61,"in_reply_to":"fa32b979_88d242ff","updated":"2015-06-16 09:11:19.000000000","message":"Done","commit_id":"239ccc06c922bbc9bbc656e335572e029e316ef9"}]}
