)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"6be942d1993052a8da18f32cd8c0b40e89bac2f9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lynn li \u003clynnli@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-08 10:55:42 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add an additional predefined device owner to support FIP with unbound port binding"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a dependant/child fix of patch 177439."},{"line_number":10,"context_line":"When an unbound port gets associated with an FIP entry in DVR environment, this port needs to be identified"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9af37de9_04a53a03","line":7,"updated":"2015-05-11 08:47:42.000000000","message":"line length in commit message should be \u003c\u003d72 characters","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"},{"author":{"_account_id":15769,"name":"Lynn Li","email":"lynn.li@hp.com","username":"lynnli"},"change_message_id":"d85132c1b5d4d43739cbe7ba992c154de3603cad","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lynn li \u003clynnli@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-08 10:55:42 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add an additional predefined device owner to support FIP with unbound port binding"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a dependant/child fix of patch 177439."},{"line_number":10,"context_line":"When an unbound port gets associated with an FIP entry in DVR environment, this port needs to be identified"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7ad8896b_c20e12e5","line":7,"in_reply_to":"9af37de9_04a53a03","updated":"2015-05-11 18:32:02.000000000","message":"will correct this on next patch.","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"305199f216d8f5086d56bdcaf0ea7344c770fdf6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add an additional predefined device owner to support FIP with unbound port binding"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a dependant/child fix of patch 177439."},{"line_number":10,"context_line":"When an unbound port gets associated with an FIP entry in DVR environment, this port needs to be identified"},{"line_number":11,"context_line":"as DVR service port. A predefined DVR owner, \"network:dvr_special_port\", is added to serve this purpose."},{"line_number":12,"context_line":"During port creation/update, user will need to specify this predefined owner in order for neutron to know"},{"line_number":13,"context_line":"it is a DVR service port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9af37de9_c44bb22a","line":10,"updated":"2015-05-11 08:52:39.000000000","message":"Not sure to understand how it works ... the new constant is only used in checks!","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"},{"author":{"_account_id":15769,"name":"Lynn Li","email":"lynn.li@hp.com","username":"lynnli"},"change_message_id":"d85132c1b5d4d43739cbe7ba992c154de3603cad","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add an additional predefined device owner to support FIP with unbound port binding"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a dependant/child fix of patch 177439."},{"line_number":10,"context_line":"When an unbound port gets associated with an FIP entry in DVR environment, this port needs to be identified"},{"line_number":11,"context_line":"as DVR service port. A predefined DVR owner, \"network:dvr_special_port\", is added to serve this purpose."},{"line_number":12,"context_line":"During port creation/update, user will need to specify this predefined owner in order for neutron to know"},{"line_number":13,"context_line":"it is a DVR service port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7ad8896b_5d9327a4","line":10,"in_reply_to":"9af37de9_c44bb22a","updated":"2015-05-11 18:32:02.000000000","message":"DVR service port constants are used in number of places such as L3 agent/dvr schedular, dvr_mac, dvr server .. etc,.  Without the change, unbound port will be missed in some business logics or mis-configured later.  For instance, before the change, L3 agent node would not be a L3 agent candidate in dvr_snat setup, if this unbound port is the only port in that node.  This unbound port could be associated with floating ip connection already.  In such scenario, this node is a valid L3 agent candidate.","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6286a021fb60f37ffde22f4f66dfc00c367f035d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add an additional predefined device owner to support FIP with unbound port binding"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a dependant/child fix of patch 177439."},{"line_number":10,"context_line":"When an unbound port gets associated with an FIP entry in DVR environment, this port needs to be identified"},{"line_number":11,"context_line":"as DVR service port. A predefined DVR owner, \"network:dvr_special_port\", is added to serve this purpose."},{"line_number":12,"context_line":"During port creation/update, user will need to specify this predefined owner in order for neutron to know"},{"line_number":13,"context_line":"it is a DVR service port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a0c5dc1_00a5e5b3","line":10,"in_reply_to":"9af37de9_c44bb22a","updated":"2015-05-13 18:54:31.000000000","message":"This device owner type is required for dvr schedulers to identify if these ports are servicable by dvr routers.","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"6be942d1993052a8da18f32cd8c0b40e89bac2f9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a dependant/child fix of patch 177439."},{"line_number":10,"context_line":"When an unbound port gets associated with an FIP entry in DVR environment, this port needs to be identified"},{"line_number":11,"context_line":"as DVR service port. A predefined DVR owner, \"network:dvr_special_port\", is added to serve this purpose."},{"line_number":12,"context_line":"During port creation/update, user will need to specify this predefined owner in order for neutron to know"},{"line_number":13,"context_line":"it is a DVR service port."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9af37de9_84b92a31","line":11,"updated":"2015-05-11 08:47:42.000000000","message":"\"network:dvr_special_port\" is not really meaningful","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6286a021fb60f37ffde22f4f66dfc00c367f035d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a dependant/child fix of patch 177439."},{"line_number":10,"context_line":"When an unbound port gets associated with an FIP entry in DVR environment, this port needs to be identified"},{"line_number":11,"context_line":"as DVR service port. A predefined DVR owner, \"network:dvr_special_port\", is added to serve this purpose."},{"line_number":12,"context_line":"During port creation/update, user will need to specify this predefined owner in order for neutron to know"},{"line_number":13,"context_line":"it is a DVR service port."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a0c5dc1_c0858d07","line":11,"in_reply_to":"7ad8896b_dd6277ad","updated":"2015-05-13 18:54:31.000000000","message":"I would suggest that we would go with \"network: dvr_service_port\"","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"},{"author":{"_account_id":15769,"name":"Lynn Li","email":"lynn.li@hp.com","username":"lynnli"},"change_message_id":"d85132c1b5d4d43739cbe7ba992c154de3603cad","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a dependant/child fix of patch 177439."},{"line_number":10,"context_line":"When an unbound port gets associated with an FIP entry in DVR environment, this port needs to be identified"},{"line_number":11,"context_line":"as DVR service port. A predefined DVR owner, \"network:dvr_special_port\", is added to serve this purpose."},{"line_number":12,"context_line":"During port creation/update, user will need to specify this predefined owner in order for neutron to know"},{"line_number":13,"context_line":"it is a DVR service port."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7ad8896b_dd6277ad","line":11,"in_reply_to":"9af37de9_84b92a31","updated":"2015-05-11 18:32:02.000000000","message":"Any better suggestion ?  How about network:dvr_unbound_port ??","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b1a8eaeca59128b2dddfbb3652c1613f1ce174d0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This is a dependant/child fix of patch 177439."},{"line_number":10,"context_line":"When an unbound port gets associated with an FIP entry in DVR environment, this port needs to be identified"},{"line_number":11,"context_line":"as DVR service port. A predefined DVR owner, \"network:dvr_special_port\", is added to serve this purpose."},{"line_number":12,"context_line":"During port creation/update, user will need to specify this predefined owner in order for neutron to know"},{"line_number":13,"context_line":"it is a DVR service port."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibee294f674c2f6978ffc50b95aefcba5f402325a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a0c5dc1_290024aa","line":12,"updated":"2015-05-12 09:05:39.000000000","message":"Not a good idea to burden users with such low-level details","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6286a021fb60f37ffde22f4f66dfc00c367f035d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This is a dependant/child fix of patch 177439."},{"line_number":10,"context_line":"When an unbound port gets associated with an FIP entry in DVR environment, this port needs to be identified"},{"line_number":11,"context_line":"as DVR service port. A predefined DVR owner, \"network:dvr_special_port\", is added to serve this purpose."},{"line_number":12,"context_line":"During port creation/update, user will need to specify this predefined owner in order for neutron to know"},{"line_number":13,"context_line":"it is a DVR service port."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibee294f674c2f6978ffc50b95aefcba5f402325a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a0c5dc1_40c07d2a","line":12,"in_reply_to":"9a0c5dc1_290024aa","updated":"2015-05-13 18:54:31.000000000","message":"This is not going to be easy to tackle until we have consensus.\nThere need to be a way to identify if this port is a dvr-service port or not.\nSince the port is unbound we don\u0027t have any clue on what this.\n\nIf this is a requirement from the tenant to use this unbound port use cases such as \"vrrp\" etc, then we need to find a way to add a specific device_owner to this field.\n\nI knew that this is kind of divergence from the centralized router model, but since dvr is very dynamic we need to adopt such strategy to fix this problem.","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b1a8eaeca59128b2dddfbb3652c1613f1ce174d0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"it is a DVR service port."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibee294f674c2f6978ffc50b95aefcba5f402325a"},{"line_number":16,"context_line":"Closes-Bug: #1447034"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a0c5dc1_69c17c80","line":16,"updated":"2015-05-12 09:05:39.000000000","message":"Can you please clarify how does this patch fixes the bug? Please check https://review.openstack.org/177507 as well","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6286a021fb60f37ffde22f4f66dfc00c367f035d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"it is a DVR service port."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibee294f674c2f6978ffc50b95aefcba5f402325a"},{"line_number":16,"context_line":"Closes-Bug: #1447034"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a0c5dc1_207a29f2","line":16,"in_reply_to":"9a0c5dc1_69c17c80","updated":"2015-05-13 18:54:31.000000000","message":"When floatingip_disassociate happens, it checks to see if there are dvr-servicable ports that use the FIP agent gateway port on that particular host. \n\nAt present it uses the \"device_owner\" field of the private-port associated with the fips to see if this is serviced by dvr-router.\n\nIf we don\u0027t have the \"device_owner\" field, then there is chance that this fip agent gateway port on that host will be deleted, thinking there is not dvr servicable ports on this host.","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"a9ef583ba1742e0e33b7debe041ee90a5d01eadc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add predefined DVR device owner for FIP w/unbound"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a dependent/child fix of patch 177439."},{"line_number":10,"context_line":"When an unbound port gets associated with an FIP entry in DVR"},{"line_number":11,"context_line":"environment, this port needs to be identified as a DVR service port"},{"line_number":12,"context_line":"in order for DVR schedulers to know it is serviceable by DVR routers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_18e7b2e5","line":9,"updated":"2015-05-27 13:58:07.000000000","message":"179439","commit_id":"7c7f36cb42ef9125ff4be090fe8eded2b1241457"},{"author":{"_account_id":15769,"name":"Lynn Li","email":"lynn.li@hp.com","username":"lynnli"},"change_message_id":"9b73b4218b6a2177d9386db6b91880afc2a62f5c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add predefined DVR device owner for FIP w/unbound"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a dependent/child fix of patch 177439."},{"line_number":10,"context_line":"When an unbound port gets associated with an FIP entry in DVR"},{"line_number":11,"context_line":"environment, this port needs to be identified as a DVR service port"},{"line_number":12,"context_line":"in order for DVR schedulers to know it is serviceable by DVR routers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_3c4930b8","line":9,"in_reply_to":"7a016987_18e7b2e5","updated":"2015-05-27 20:19:56.000000000","message":"thanks for pointing out.  it will be corrected.","commit_id":"7c7f36cb42ef9125ff4be090fe8eded2b1241457"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"56ee5222cebb42950eb04dbd56eaa97181370171","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add predefined DVR device owner for FIP w/unbound"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a dependent/child fix of patch 179439."},{"line_number":10,"context_line":"Change-Id: I8e94063009b29fab4f990674292989aaca572491"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When an unbound port gets associated with an FIP entry in DVR"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a41bdd9_09ec88f1","line":9,"updated":"2015-07-15 16:35:38.000000000","message":"There is no need for this and the extra change-id is bound to confuse people.  Please remove it.","commit_id":"5606022fefd552ced56c9c6af531d5e42ad71157"}],"neutron/common/constants.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6286a021fb60f37ffde22f4f66dfc00c367f035d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"DEVICE_OWNER_AGENT_GW \u003d \"network:floatingip_agent_gateway\""},{"line_number":40,"context_line":"DEVICE_OWNER_ROUTER_SNAT \u003d \"network:router_centralized_snat\""},{"line_number":41,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d \"neutron:LOADBALANCER\""},{"line_number":42,"context_line":"DEVICE_OWNER_DVR_SPECIAL_PORT \u003d \"network:dvr_special_port\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Collection used to identify devices owned by router interfaces."},{"line_number":45,"context_line":"# DEVICE_OWNER_ROUTER_HA_INTF is a special case and so is not included."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a0c5dc1_a055f950","line":42,"updated":"2015-05-13 18:54:31.000000000","message":"suggestion: change it to \"network:dvr_service_port\"\nService ports are unbound ports and can be used for any purpose with the dvr routers.","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"},{"author":{"_account_id":15769,"name":"Lynn Li","email":"lynn.li@hp.com","username":"lynnli"},"change_message_id":"ec0365e7b606929c4ba749b7578ed9c6e3a39ce8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"DEVICE_OWNER_AGENT_GW \u003d \"network:floatingip_agent_gateway\""},{"line_number":40,"context_line":"DEVICE_OWNER_ROUTER_SNAT \u003d \"network:router_centralized_snat\""},{"line_number":41,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d \"neutron:LOADBALANCER\""},{"line_number":42,"context_line":"DEVICE_OWNER_DVR_SPECIAL_PORT \u003d \"network:dvr_special_port\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Collection used to identify devices owned by router interfaces."},{"line_number":45,"context_line":"# DEVICE_OWNER_ROUTER_HA_INTF is a special case and so is not included."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4bdd046e","line":42,"in_reply_to":"9a0c5dc1_a055f950","updated":"2015-05-19 23:04:39.000000000","message":"will be done. thanks.","commit_id":"8967a5a8545159094a91f8e10d8546869c13a851"}]}