)]}'
{"bin/quantum-ovs-cleanup":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"99f6d7a145afe5bc20223ca0af4e1ef16142bc15","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":16,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from quantum.agent.ovs_cleanup_util import main"},{"line_number":20,"context_line":"main()"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2F%2BN8%3D","line":18,"updated":"2012-12-18 12:58:40.000000000","message":"Some file in ./bin add current path to sys.path as below:\n\nimport os\n\nimport sys\n\nsys.path.insert(0, os.getcwd())\n\nIs this used for running quantum in source code?\nShould we add this to all file in ./bin?","commit_id":"6d34d14ec3c130578500508866d03d651f7ebf20"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":16,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from quantum.agent.ovs_cleanup_util import main"},{"line_number":20,"context_line":"main()"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2F95w%3D","line":18,"in_reply_to":"AAAAM3%2F%2F%2BN8%3D","updated":"2012-12-18 16:32:30.000000000","message":"i am not sure. i\u0027ll update this one as it is new.","commit_id":"6d34d14ec3c130578500508866d03d651f7ebf20"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":"sys.path.insert(0, os.getcwd())"},{"line_number":22,"context_line":"from quantum.agent.ovs_cleanup_util import main"},{"line_number":23,"context_line":"main()"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAM3%2F%2F5lg%3D","line":22,"updated":"2012-12-22 15:40:09.000000000","message":"There should be two blank lines below here according to HACKING","commit_id":"e26cd1e8e7b03085dd3329bb288fb8f8a386e66b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":"sys.path.insert(0, os.getcwd())"},{"line_number":22,"context_line":"from quantum.agent.ovs_cleanup_util import main"},{"line_number":23,"context_line":"main()"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAM3%2F%2F5lI%3D","line":22,"in_reply_to":"AAAAM3%2F%2F5lg%3D","updated":"2012-12-22 18:38:38.000000000","message":"Done","commit_id":"e26cd1e8e7b03085dd3329bb288fb8f8a386e66b"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":"sys.path.insert(0, os.getcwd())"},{"line_number":22,"context_line":"from quantum.agent.ovs_cleanup_util import main"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAM3%2F%2F5K8%3D","line":21,"updated":"2012-12-24 13:16:24.000000000","message":"Minor nit: should these be separated by a blank line?","commit_id":"53314e1d80f5729962172f6a5bd7b35aee2b2b5e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":"sys.path.insert(0, os.getcwd())"},{"line_number":22,"context_line":"from quantum.agent.ovs_cleanup_util import main"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAM3%2F%2F5Kw%3D","line":21,"in_reply_to":"AAAAM3%2F%2F5K8%3D","updated":"2012-12-24 13:32:21.000000000","message":"Done","commit_id":"53314e1d80f5729962172f6a5bd7b35aee2b2b5e"}],"quantum/agent/ovs_cleanup_util.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"99f6d7a145afe5bc20223ca0af4e1ef16142bc15","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        ports \u003d ovs.get_port_name_list()"},{"line_number":59,"context_line":"        for port in ports:"},{"line_number":60,"context_line":"            ovs.delete_port(port)"},{"line_number":61,"context_line":"    LOG.info(\"OVS integrations bridge cleaned successfully\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F%2BPg%3D","line":61,"updated":"2012-12-18 12:58:40.000000000","message":"This should be wrapper with _()","commit_id":"6d34d14ec3c130578500508866d03d651f7ebf20"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":58,"context_line":"        ports \u003d ovs.get_port_name_list()"},{"line_number":59,"context_line":"        for port in ports:"},{"line_number":60,"context_line":"            ovs.delete_port(port)"},{"line_number":61,"context_line":"    LOG.info(\"OVS integrations bridge cleaned successfully\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F954%3D","line":61,"in_reply_to":"AAAAM3%2F%2F%2BPg%3D","updated":"2012-12-18 16:32:30.000000000","message":"Done","commit_id":"6d34d14ec3c130578500508866d03d651f7ebf20"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":84,"context_line":"    for bridge in bridges:"},{"line_number":85,"context_line":"        ovs \u003d ovs_lib.OVSBridge(bridge, conf.root_helper)"},{"line_number":86,"context_line":"        if conf.quantum_ports:"},{"line_number":87,"context_line":"            delete_quantum_ports(ovs)"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            delete_all_ports(ovs)"},{"line_number":90,"context_line":"    LOG.info(_(\"OVS cleanup completed successfully\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2F8bo%3D","line":87,"updated":"2012-12-19 17:05:35.000000000","message":"(Suggestion only) Consider moving port deletion to a method on the bridge, e.g.:\n\ndef delete_ports(self, all_ports\u003dFalse):\n  if all_ports:\n    port_names \u003d (x.port_name for x in self.get_vif_ports())\n  else\n    port_names \u003d self.get_port_name_list()\n  for port_name in port_names:\n    self.delete_port(port_name)\n\nThis solution would be simpler (only one function) and would be easier to discover if it were available on the bridge object rather than in a separate utility module.","commit_id":"380ad4d4fd6af09b37f6a7b2f6c7e78196e3128c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":84,"context_line":"    for bridge in bridges:"},{"line_number":85,"context_line":"        ovs \u003d ovs_lib.OVSBridge(bridge, conf.root_helper)"},{"line_number":86,"context_line":"        if conf.quantum_ports:"},{"line_number":87,"context_line":"            delete_quantum_ports(ovs)"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            delete_all_ports(ovs)"},{"line_number":90,"context_line":"    LOG.info(_(\"OVS cleanup completed successfully\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2F8QA%3D","line":87,"in_reply_to":"AAAAM3%2F%2F8bo%3D","updated":"2012-12-19 18:34:14.000000000","message":"nice suggestion. i\u0027ll update","commit_id":"380ad4d4fd6af09b37f6a7b2f6c7e78196e3128c"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":60,"context_line":"    bridges \u003d [conf.ovs_integration_bridge,"},{"line_number":61,"context_line":"               conf.external_network_bridge]"},{"line_number":62,"context_line":"    LOG.info(_(\"Configured bridges: %s\"), bridges)"},{"line_number":63,"context_line":"    for bridge in bridges:"},{"line_number":64,"context_line":"        ovs \u003d ovs_lib.OVSBridge(bridge, conf.root_helper)"},{"line_number":65,"context_line":"        if conf.quantum_ports:"},{"line_number":66,"context_line":"            port_names \u003d (port.port_name for port in ovs.get_vif_ports())"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2F8NQ%3D","line":63,"updated":"2012-12-19 18:59:49.000000000","message":"(Suggestion only) This change is good, but consider adding port deletion as a method to the OVSBridge class.","commit_id":"656e72fa8d0ad4447f56b216646cf443523682be"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":60,"context_line":"    bridges \u003d [conf.ovs_integration_bridge,"},{"line_number":61,"context_line":"               conf.external_network_bridge]"},{"line_number":62,"context_line":"    LOG.info(_(\"Configured bridges: %s\"), bridges)"},{"line_number":63,"context_line":"    for bridge in bridges:"},{"line_number":64,"context_line":"        ovs \u003d ovs_lib.OVSBridge(bridge, conf.root_helper)"},{"line_number":65,"context_line":"        if conf.quantum_ports:"},{"line_number":66,"context_line":"            port_names \u003d (port.port_name for port in ovs.get_vif_ports())"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2F8Hk%3D","line":63,"in_reply_to":"AAAAM3%2F%2F8NQ%3D","updated":"2012-12-19 20:03:11.000000000","message":"Ok, I\u0027ll add it.","commit_id":"656e72fa8d0ad4447f56b216646cf443523682be"}]}