)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13997,"name":"SHIGEMATSU Mitsuhiro","email":"shigematsu.mitsuhiro@lab.ntt.co.jp","username":"pshige"},"change_message_id":"329ce079fad9cec046fd97571316c18843354ccb","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TODO:"},{"line_number":16,"context_line":"* Add option cross_az_attach"},{"line_number":17,"context_line":"* Add schduler for HA Router"},{"line_number":18,"context_line":"* Add UT"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Co-Authored-By: IWAMOTO Toshihiro \u003ciwamoto@valinux.co.jp\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_35dba5ef","line":17,"updated":"2015-05-27 07:21:06.000000000","message":"s/schduler/scheduler/","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"8e6a3c7d46279d461085473f1e6edc18114b50d6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Co-Authored-By: IWAMOTO Toshihiro \u003ciwamoto@valinux.co.jp\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id7a62000ab0484412b3970199df8c374568fe70d"},{"line_number":18,"context_line":"Implements: blueprint add-availability-zone"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a41bdd9_bb3350f5","line":18,"updated":"2015-07-15 22:20:22.000000000","message":"Partially-implements now ?","commit_id":"059263f262452958f51ff97aff139613e65f0e98"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"948066cd1b5603983a19b82465ed4911b6cbe01a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Co-Authored-By: IWAMOTO Toshihiro \u003ciwamoto@valinux.co.jp\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id7a62000ab0484412b3970199df8c374568fe70d"},{"line_number":18,"context_line":"Implements: blueprint add-availability-zone"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a41bdd9_eccb56a2","line":18,"in_reply_to":"9a41bdd9_bb3350f5","updated":"2015-07-16 06:40:07.000000000","message":"Yes. I will update","commit_id":"059263f262452958f51ff97aff139613e65f0e98"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a278302e1133ae25f97b9d131f56fc723e07a9cb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add availability_zone support for API and DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the availability_zone attribute to agents, networks"},{"line_number":10,"context_line":"and routers, so that users can specify where network services run."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"ba15a1d1_b8f2e0d0","line":9,"updated":"2015-09-16 07:10:32.000000000","message":"what I am suggesting is to split this work into AZ support for network and AZ support for routers. Even though they\u0027ll make up the entire functionality of AZ support, they can as well be contributed as two separate patches. They are also independent. A possible way to break this down would be:\n\n- Basic agent addition and Migration (PATCH 1)\n- Network AZ support and Migration (PATCH 2)\n- Router AZ support and Migration (PATCH 3)","commit_id":"579e018bd3ef3cb87793e299e8ebf137c642c476"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"45a9a216e3bcaeddb7aeffc9a9e2e9e0fcfbfc85","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add availability_zone support for API and DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the availability_zone attribute to agents, networks"},{"line_number":10,"context_line":"and routers, so that users can specify where network services run."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"ba15a1d1_eb8ac4be","line":9,"in_reply_to":"ba15a1d1_988cbc36","updated":"2015-09-16 08:00:28.000000000","message":"Thank you very much for your suggestion. I will update.","commit_id":"579e018bd3ef3cb87793e299e8ebf137c642c476"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"397f2d26d750d536d5229a2ce7e925ae5cbd85c5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add availability_zone support for API and DB"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the availability_zone attribute to agents, networks"},{"line_number":10,"context_line":"and routers, so that users can specify where network services run."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":30,"id":"ba15a1d1_988cbc36","line":9,"in_reply_to":"ba15a1d1_b8f2e0d0","updated":"2015-09-16 07:12:31.000000000","message":"Bear in mind that I am not suggesting this if I didn\u0027t believe that it would give you the best chance at merging this quickly. It\u0027s not like I am doing it because I love you to do more work ;)","commit_id":"579e018bd3ef3cb87793e299e8ebf137c642c476"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"059008b8a50f8548ba2b324f2bb9e73f01d658bd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add availability_zone support base"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the availability_zone attribute to agents, networks"},{"line_number":10,"context_line":"and routers, so that users can specify where network services run."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"APIImpact"},{"line_number":13,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"ba15a1d1_6e5d3446","line":10,"updated":"2015-09-17 05:37:10.000000000","message":"It should be changed because net and router are moved to another patch.","commit_id":"383e490ab5b40d1fd003841dc4a51a4d45392605"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"95822655c67f0c6bb45f995f6c50c4a790dd37e4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add availability_zone support base"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the availability_zone attribute to agents, networks"},{"line_number":10,"context_line":"and routers, so that users can specify where network services run."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"APIImpact"},{"line_number":13,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"ba15a1d1_419841c0","line":10,"in_reply_to":"ba15a1d1_6e5d3446","updated":"2015-09-17 05:43:44.000000000","message":"You\u0027re right.","commit_id":"383e490ab5b40d1fd003841dc4a51a4d45392605"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4223f22ba34c4e510c7a70eed2fb01fff258cc9f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the schedulers are included in subsequent patches."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: IWAMOTO Toshihiro \u003ciwamoto@valinux.co.jp\u003e"},{"line_number":18,"context_line":"Change-Id: Id7a62000ab0484412b3970199df8c374568fe70d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":35,"id":"ba15a1d1_b9ca496d","line":15,"updated":"2015-09-20 17:29:40.000000000","message":"Does this have any upgrade impact?","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e3793934b62f7ea7b787f3b6fcc4ad894133ae2d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the schedulers are included in subsequent patches."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-Authored-By: IWAMOTO Toshihiro \u003ciwamoto@valinux.co.jp\u003e"},{"line_number":18,"context_line":"Change-Id: Id7a62000ab0484412b3970199df8c374568fe70d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":35,"id":"ba15a1d1_1f623517","line":15,"in_reply_to":"ba15a1d1_b9ca496d","updated":"2015-09-21 01:44:24.000000000","message":"I\u0027m not sure upgrade impact tag is needed. The tag is needed in the case \"Use the “UpgradeImpact” tag on changes which require configuration changes to be mentioned in the release notes[1].\" Therefore, I think that it\u0027s not needed here because this patch doesn\u0027t change existing configurations.\n\n[1]: http://docs.openstack.org/infra/manual/developers.html#peer-review","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"}],"neutron/agent/common/config.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6cbbd839fb7711f13bc3fe6bae9843cfff3b8cbe","unresolved":false,"context_lines":[{"line_number":76,"context_line":"]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# TODO(hichihara): Remove these two classes, once oslo fixes types.string"},{"line_number":80,"context_line":"# and cfg.StrOpt."},{"line_number":81,"context_line":"class LengthString(types.String):"},{"line_number":82,"context_line":"    def __init__(self, maxlen\u003dNone):"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_c91c4c6c","line":79,"updated":"2015-09-17 23:42:40.000000000","message":"is it tracked with a bug? Forgive my ignorance, but why wouldn\u0027t the string opt not be enough? What\u0027s the limitation?","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"82a863b95cd16114bc739949f6a40289d348a5bc","unresolved":false,"context_lines":[{"line_number":76,"context_line":"]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# TODO(hichihara): Remove these two classes, once oslo fixes types.string"},{"line_number":80,"context_line":"# and cfg.StrOpt."},{"line_number":81,"context_line":"class LengthString(types.String):"},{"line_number":82,"context_line":"    def __init__(self, maxlen\u003dNone):"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_fd16a64a","line":79,"in_reply_to":"ba15a1d1_c91c4c6c","updated":"2015-09-18 01:55:10.000000000","message":"I added it according with Akihiro\u0027s comment in models_v2(PS13). I will report this to oslo.cfg.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6cbbd839fb7711f13bc3fe6bae9843cfff3b8cbe","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def __call__(self, value):"},{"line_number":87,"context_line":"        value \u003d super(LengthString, self).__call__(value)"},{"line_number":88,"context_line":"        if self.maxlen and len(value) \u003e self.maxlen:"},{"line_number":89,"context_line":"            raise ValueError(_(\"String value \u0027%(value)s\u0027 exceeds max length \""},{"line_number":90,"context_line":"                               \"%(len)d\") % {\u0027value\u0027: value,"},{"line_number":91,"context_line":"                                             \u0027len\u0027: self.maxlen})"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_a9531816","line":88,"updated":"2015-09-17 23:42:40.000000000","message":"Can an availability zone be that much longer than 255 characters? In practice I don\u0027t even see us hit that limit. Do you?\n\nI\u0027d consider simplifying this, but I don\u0027t mind if you want to keep it.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"82a863b95cd16114bc739949f6a40289d348a5bc","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def __call__(self, value):"},{"line_number":87,"context_line":"        value \u003d super(LengthString, self).__call__(value)"},{"line_number":88,"context_line":"        if self.maxlen and len(value) \u003e self.maxlen:"},{"line_number":89,"context_line":"            raise ValueError(_(\"String value \u0027%(value)s\u0027 exceeds max length \""},{"line_number":90,"context_line":"                               \"%(len)d\") % {\u0027value\u0027: value,"},{"line_number":91,"context_line":"                                             \u0027len\u0027: self.maxlen})"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_bd1cae6a","line":88,"in_reply_to":"ba15a1d1_a9531816","updated":"2015-09-18 01:55:10.000000000","message":"ditto","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2b7053d7dc5508660471db1aa0a773346a132adf","unresolved":false,"context_lines":[{"line_number":76,"context_line":"]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# TODO(hichihara): Remove these two classes, once oslo fixes types.string"},{"line_number":80,"context_line":"# and cfg.StrOpt."},{"line_number":81,"context_line":"class LengthString(types.String):"},{"line_number":82,"context_line":"    def __init__(self, maxlen\u003dNone):"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba15a1d1_12434014","line":79,"updated":"2015-09-18 06:30:09.000000000","message":"Akihiro\u0027s comment makes sense...but I feel that\u0027s quite some work for very little gain. You could check and validate the length after the opt is loaded. I suspect you\u0027ll never get these into oslo...but I might be wrong. In case you think I am right, then you can get rid of these classes ;)","commit_id":"0f863ae89aa1071c58382897a22a77265bdf7aee"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"1631abd49046775edd427f8c67d895b5f5dbd658","unresolved":false,"context_lines":[{"line_number":76,"context_line":"]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# TODO(hichihara): Remove these two classes, once oslo fixes types.string"},{"line_number":80,"context_line":"# and cfg.StrOpt."},{"line_number":81,"context_line":"class LengthString(types.String):"},{"line_number":82,"context_line":"    def __init__(self, maxlen\u003dNone):"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba15a1d1_12ea6074","line":79,"in_reply_to":"ba15a1d1_12434014","updated":"2015-09-18 06:53:56.000000000","message":"\u003e You could check and validate the length after the opt is loaded.\n\nhmm, I don\u0027t think it is good idea to do check in each agent. It is code duplication.\n\nIMO, oslo.StrOpt shoud support max length check. I think this function is very valuable.","commit_id":"0f863ae89aa1071c58382897a22a77265bdf7aee"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"db4151a1736a7f9ad423d6d05fd70f7a5c4bb52c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# TODO(hichihara): Remove these two classes, once oslo fixes types.string"},{"line_number":80,"context_line":"# and cfg.StrOpt."},{"line_number":81,"context_line":"class LengthString(types.String):"},{"line_number":82,"context_line":"    def __init__(self, maxlen\u003dNone):"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba15a1d1_724ddcc2","line":79,"in_reply_to":"ba15a1d1_12434014","updated":"2015-09-18 07:06:53.000000000","message":"I agree with Oda but I almost agree with you too. I will propose this to oslo first. If the proposal is rejected, I will consider again.","commit_id":"0f863ae89aa1071c58382897a22a77265bdf7aee"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5562f9772de57eb09eb6b6ceff48139df589a772","unresolved":false,"context_lines":[{"line_number":76,"context_line":"]"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# TODO(hichihara): Remove these two classes, once oslo fixes types.string"},{"line_number":80,"context_line":"# and cfg.StrOpt."},{"line_number":81,"context_line":"class LengthString(types.String):"},{"line_number":82,"context_line":"    def __init__(self, maxlen\u003dNone):"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba15a1d1_3ea718a8","line":79,"in_reply_to":"ba15a1d1_12ea6074","updated":"2015-09-18 17:44:04.000000000","message":"Oda, the code can be in one place, where is the duplication coming from? The more I look at this the more I think we\u0027re shooting a fly with a cannon. Anyhow..nothing to be blocked on about.","commit_id":"0f863ae89aa1071c58382897a22a77265bdf7aee"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c2caa848c1ebf69458d2a7bd6803c6e77f9899d5","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# TODO(hichihara): Remove these two classes, once oslo fixes types.string"},{"line_number":80,"context_line":"# and cfg.StrOpt."},{"line_number":81,"context_line":"class LengthString(types.String):"},{"line_number":82,"context_line":"    def __init__(self, maxlen\u003dNone):"},{"line_number":83,"context_line":"        super(LengthString, self).__init__()"},{"line_number":84,"context_line":"        self.maxlen \u003d maxlen"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_19b9f5ec","line":81,"updated":"2015-09-20 17:28:59.000000000","message":"i am not sure why we need this? why not just do a concatenation of the db update?\nThe code also does not really seem in place here.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e3793934b62f7ea7b787f3b6fcc4ad894133ae2d","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"# TODO(hichihara): Remove these two classes, once oslo fixes types.string"},{"line_number":80,"context_line":"# and cfg.StrOpt."},{"line_number":81,"context_line":"class LengthString(types.String):"},{"line_number":82,"context_line":"    def __init__(self, maxlen\u003dNone):"},{"line_number":83,"context_line":"        super(LengthString, self).__init__()"},{"line_number":84,"context_line":"        self.maxlen \u003d maxlen"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_df427d68","line":81,"in_reply_to":"ba15a1d1_19b9f5ec","updated":"2015-09-21 01:44:24.000000000","message":"Please take a look at PS34 comments.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"edc56c08ae5c153b69e54e709a09512c6666c270","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"AVAILABILITY_ZONE_OPTS \u003d ["},{"line_number":103,"context_line":"    # the default name \u0027nova\u0027 followed nova and cinder"},{"line_number":104,"context_line":"    LengthStrOpt(\u0027availability_zone\u0027, maxlen\u003d255, default\u003d\u0027nova\u0027,"},{"line_number":105,"context_line":"                 help\u003d_(\"Availability zone of this node\")),"},{"line_number":106,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_3943b2b0","line":103,"updated":"2015-09-18 18:18:05.000000000","message":"Nit: I am unable to parse this comment. What does it mean?","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a4f3f2e452e0a37ab763843c4a135d8e0762a213","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"AVAILABILITY_ZONE_OPTS \u003d ["},{"line_number":103,"context_line":"    # the default name \u0027nova\u0027 followed nova and cinder"},{"line_number":104,"context_line":"    LengthStrOpt(\u0027availability_zone\u0027, maxlen\u003d255, default\u003d\u0027nova\u0027,"},{"line_number":105,"context_line":"                 help\u003d_(\"Availability zone of this node\")),"},{"line_number":106,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_738cd77f","line":103,"in_reply_to":"ba15a1d1_38fb9e49","updated":"2015-09-19 13:43:54.000000000","message":"There was the same comment in PS25. I have already done. Non-az aware agents is set empty.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e1f8b1f8327854491d9c448ae17d16f05b6a5d2b","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"AVAILABILITY_ZONE_OPTS \u003d ["},{"line_number":103,"context_line":"    # the default name \u0027nova\u0027 followed nova and cinder"},{"line_number":104,"context_line":"    LengthStrOpt(\u0027availability_zone\u0027, maxlen\u003d255, default\u003d\u0027nova\u0027,"},{"line_number":105,"context_line":"                 help\u003d_(\"Availability zone of this node\")),"},{"line_number":106,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_f5352fa8","line":103,"in_reply_to":"ba15a1d1_3943b2b0","updated":"2015-09-19 06:57:13.000000000","message":"I adopted \"nova\" as defalt name of availability_zone because Nova and Cinder projects use the same name as default.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"7f5d90c9ea3e6c6f51b90ed241de36944dd74ebc","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"AVAILABILITY_ZONE_OPTS \u003d ["},{"line_number":103,"context_line":"    # the default name \u0027nova\u0027 followed nova and cinder"},{"line_number":104,"context_line":"    LengthStrOpt(\u0027availability_zone\u0027, maxlen\u003d255, default\u003d\u0027nova\u0027,"},{"line_number":105,"context_line":"                 help\u003d_(\"Availability zone of this node\")),"},{"line_number":106,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_b6f62f8d","line":103,"in_reply_to":"ba15a1d1_4bb729d8","updated":"2015-09-24 07:44:30.000000000","message":"+1 amotoki\u0027s suggestion","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b56cc7c938c5b8f1de333d7ce6999b4bd5c7e6a","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"AVAILABILITY_ZONE_OPTS \u003d ["},{"line_number":103,"context_line":"    # the default name \u0027nova\u0027 followed nova and cinder"},{"line_number":104,"context_line":"    LengthStrOpt(\u0027availability_zone\u0027, maxlen\u003d255, default\u003d\u0027nova\u0027,"},{"line_number":105,"context_line":"                 help\u003d_(\"Availability zone of this node\")),"},{"line_number":106,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_4bb729d8","line":103,"in_reply_to":"ba15a1d1_738cd77f","updated":"2015-09-23 01:59:15.000000000","message":"Per Henry\u0027s comment, how about rephrasing it to:\n\n  The default AZ name \"nova\" is selected to match the default\n  AZ name in Nova and Cinder.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4748b50c8666418b4f42fd1186262bbfe7907fc2","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"AVAILABILITY_ZONE_OPTS \u003d ["},{"line_number":103,"context_line":"    # the default name \u0027nova\u0027 followed nova and cinder"},{"line_number":104,"context_line":"    LengthStrOpt(\u0027availability_zone\u0027, maxlen\u003d255, default\u003d\u0027nova\u0027,"},{"line_number":105,"context_line":"                 help\u003d_(\"Availability zone of this node\")),"},{"line_number":106,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a1a9d01_6e3da92a","line":103,"in_reply_to":"ba15a1d1_b6f62f8d","updated":"2015-09-25 16:09:00.000000000","message":"Done","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"4ac2870b636a5a8639366219986ff8b4ca08784a","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"AVAILABILITY_ZONE_OPTS \u003d ["},{"line_number":103,"context_line":"    # the default name \u0027nova\u0027 followed nova and cinder"},{"line_number":104,"context_line":"    LengthStrOpt(\u0027availability_zone\u0027, maxlen\u003d255, default\u003d\u0027nova\u0027,"},{"line_number":105,"context_line":"                 help\u003d_(\"Availability zone of this node\")),"},{"line_number":106,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_38fb9e49","line":103,"in_reply_to":"ba15a1d1_f5352fa8","updated":"2015-09-19 11:59:15.000000000","message":"I am thinking about how do u deal with existing non-az aware agents?\nif these agents are empty az value, can u just make empty as default value?","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6cbbd839fb7711f13bc3fe6bae9843cfff3b8cbe","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        self.agent_state \u003d {"},{"line_number":549,"context_line":"            \u0027binary\u0027: \u0027neutron-dhcp-agent\u0027,"},{"line_number":550,"context_line":"            \u0027host\u0027: host,"},{"line_number":551,"context_line":"            \u0027availability_zone\u0027: self.conf.AGENT.availability_zone,"},{"line_number":552,"context_line":"            \u0027topic\u0027: topics.DHCP_AGENT,"},{"line_number":553,"context_line":"            \u0027configurations\u0027: {"},{"line_number":554,"context_line":"                \u0027dhcp_driver\u0027: self.conf.dhcp_driver,"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_c98f6c73","line":551,"updated":"2015-09-17 23:42:40.000000000","message":"these change is probably best moved to:\n\nhttps://review.openstack.org/#/c/204436/","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"82a863b95cd16114bc739949f6a40289d348a5bc","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        self.agent_state \u003d {"},{"line_number":549,"context_line":"            \u0027binary\u0027: \u0027neutron-dhcp-agent\u0027,"},{"line_number":550,"context_line":"            \u0027host\u0027: host,"},{"line_number":551,"context_line":"            \u0027availability_zone\u0027: self.conf.AGENT.availability_zone,"},{"line_number":552,"context_line":"            \u0027topic\u0027: topics.DHCP_AGENT,"},{"line_number":553,"context_line":"            \u0027configurations\u0027: {"},{"line_number":554,"context_line":"                \u0027dhcp_driver\u0027: self.conf.dhcp_driver,"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_7d9e16ba","line":551,"in_reply_to":"ba15a1d1_c98f6c73","updated":"2015-09-18 01:55:10.000000000","message":"This patch must include stuff for agent DB and availability_zone API. Otherwise, we cannot test this patch. Russell hoped this.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"e8c2d88b3ba5971135497a9d7246d9de76a7d3c0","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        self.agent_state \u003d {"},{"line_number":549,"context_line":"            \u0027binary\u0027: \u0027neutron-dhcp-agent\u0027,"},{"line_number":550,"context_line":"            \u0027host\u0027: host,"},{"line_number":551,"context_line":"            \u0027availability_zone\u0027: self.conf.AGENT.availability_zone,"},{"line_number":552,"context_line":"            \u0027topic\u0027: topics.DHCP_AGENT,"},{"line_number":553,"context_line":"            \u0027configurations\u0027: {"},{"line_number":554,"context_line":"                \u0027dhcp_driver\u0027: self.conf.dhcp_driver,"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_1d01ac6a","line":551,"updated":"2015-09-22 01:40:34.000000000","message":"if we will put it in configuration with API, we should report it in configuration too.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d20b87ff800cb9092305bc079eba9bb13a2349b9","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        self.agent_state \u003d {"},{"line_number":549,"context_line":"            \u0027binary\u0027: \u0027neutron-dhcp-agent\u0027,"},{"line_number":550,"context_line":"            \u0027host\u0027: host,"},{"line_number":551,"context_line":"            \u0027availability_zone\u0027: self.conf.AGENT.availability_zone,"},{"line_number":552,"context_line":"            \u0027topic\u0027: topics.DHCP_AGENT,"},{"line_number":553,"context_line":"            \u0027configurations\u0027: {"},{"line_number":554,"context_line":"                \u0027dhcp_driver\u0027: self.conf.dhcp_driver,"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_5b4dec70","line":551,"in_reply_to":"ba15a1d1_1d01ac6a","updated":"2015-09-22 02:50:23.000000000","message":"Currently availability zone of agent is set by config file only so it\u0027s not needed. Can you elaborate on your worry?","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b56cc7c938c5b8f1de333d7ce6999b4bd5c7e6a","unresolved":false,"context_lines":[{"line_number":548,"context_line":"        self.agent_state \u003d {"},{"line_number":549,"context_line":"            \u0027binary\u0027: \u0027neutron-dhcp-agent\u0027,"},{"line_number":550,"context_line":"            \u0027host\u0027: host,"},{"line_number":551,"context_line":"            \u0027availability_zone\u0027: self.conf.AGENT.availability_zone,"},{"line_number":552,"context_line":"            \u0027topic\u0027: topics.DHCP_AGENT,"},{"line_number":553,"context_line":"            \u0027configurations\u0027: {"},{"line_number":554,"context_line":"                \u0027dhcp_driver\u0027: self.conf.dhcp_driver,"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_cbcb3952","line":551,"in_reply_to":"ba15a1d1_5b4dec70","updated":"2015-09-23 01:59:15.000000000","message":"I think he is just suggesting to move this to inside \"configurations\" below.\nEither choice sounds good to me.\n\nAs the RPC API, \"availability_zone\" comes from the conf file, so it is reasonable that \u0027availability_zone\u0027 is placed in \u0027configurations\u0027.\n\nOn the other hand, IIRC you received in a past patch set that you should keep \u0027configuration\u0027 in agent dict should match RPC API. To me, agent_dict in the server side and \u0027configurations\u0027 in RPC API are different things, so it doesn\u0027t matter to me.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"74a3c742be3558d9606d66260e721b20b5350105","unresolved":false,"context_lines":[{"line_number":552,"context_line":"            \u0027topic\u0027: topics.DHCP_AGENT,"},{"line_number":553,"context_line":"            \u0027configurations\u0027: {"},{"line_number":554,"context_line":"                \u0027dhcp_driver\u0027: self.conf.dhcp_driver,"},{"line_number":555,"context_line":"                \u0027use_namespaces\u0027: self.conf.use_namespaces,"},{"line_number":556,"context_line":"                \u0027dhcp_lease_duration\u0027: self.conf.dhcp_lease_duration,"},{"line_number":557,"context_line":"                \u0027log_agent_heartbeats\u0027: self.conf.AGENT.log_agent_heartbeats},"},{"line_number":558,"context_line":"            \u0027start_flag\u0027: True,"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_1f2bcb95","line":555,"updated":"2015-09-22 13:22:00.000000000","message":"can we put 551 here?","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4748b50c8666418b4f42fd1186262bbfe7907fc2","unresolved":false,"context_lines":[{"line_number":552,"context_line":"            \u0027topic\u0027: topics.DHCP_AGENT,"},{"line_number":553,"context_line":"            \u0027configurations\u0027: {"},{"line_number":554,"context_line":"                \u0027dhcp_driver\u0027: self.conf.dhcp_driver,"},{"line_number":555,"context_line":"                \u0027use_namespaces\u0027: self.conf.use_namespaces,"},{"line_number":556,"context_line":"                \u0027dhcp_lease_duration\u0027: self.conf.dhcp_lease_duration,"},{"line_number":557,"context_line":"                \u0027log_agent_heartbeats\u0027: self.conf.AGENT.log_agent_heartbeats},"},{"line_number":558,"context_line":"            \u0027start_flag\u0027: True,"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a1a9d01_6ed929f3","line":555,"in_reply_to":"ba15a1d1_1f2bcb95","updated":"2015-09-25 16:09:00.000000000","message":"The value is suited to top level not configurations so I changed get_agent of agents_db.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"}],"neutron/agent/dhcp_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6cbbd839fb7711f13bc3fe6bae9843cfff3b8cbe","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    config.register_interface_driver_opts_helper(conf)"},{"line_number":33,"context_line":"    config.register_use_namespaces_opts_helper(conf)"},{"line_number":34,"context_line":"    config.register_agent_state_opts_helper(conf)"},{"line_number":35,"context_line":"    config.register_availability_zone_opts_helper(conf)"},{"line_number":36,"context_line":"    conf.register_opts(dhcp_config.DHCP_AGENT_OPTS)"},{"line_number":37,"context_line":"    conf.register_opts(dhcp_config.DHCP_OPTS)"},{"line_number":38,"context_line":"    conf.register_opts(dhcp_config.DNSMASQ_OPTS)"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_e98a7063","line":35,"updated":"2015-09-17 23:42:40.000000000","message":"these change is probably best moved to:\n\nhttps://review.openstack.org/#/c/204436/","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"82a863b95cd16114bc739949f6a40289d348a5bc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    config.register_interface_driver_opts_helper(conf)"},{"line_number":33,"context_line":"    config.register_use_namespaces_opts_helper(conf)"},{"line_number":34,"context_line":"    config.register_agent_state_opts_helper(conf)"},{"line_number":35,"context_line":"    config.register_availability_zone_opts_helper(conf)"},{"line_number":36,"context_line":"    conf.register_opts(dhcp_config.DHCP_AGENT_OPTS)"},{"line_number":37,"context_line":"    conf.register_opts(dhcp_config.DHCP_OPTS)"},{"line_number":38,"context_line":"    conf.register_opts(dhcp_config.DNSMASQ_OPTS)"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_1d959a85","line":35,"in_reply_to":"ba15a1d1_e98a7063","updated":"2015-09-18 01:55:10.000000000","message":"This patch must include stuff for agent DB and availability_zone API. Otherwise, we cannot test this patch. Russell hoped this.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"}],"neutron/agent/l3/agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6cbbd839fb7711f13bc3fe6bae9843cfff3b8cbe","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        self.agent_state \u003d {"},{"line_number":616,"context_line":"            \u0027binary\u0027: \u0027neutron-l3-agent\u0027,"},{"line_number":617,"context_line":"            \u0027host\u0027: host,"},{"line_number":618,"context_line":"            \u0027availability_zone\u0027: self.conf.AGENT.availability_zone,"},{"line_number":619,"context_line":"            \u0027topic\u0027: topics.L3_AGENT,"},{"line_number":620,"context_line":"            \u0027configurations\u0027: {"},{"line_number":621,"context_line":"                \u0027agent_mode\u0027: self.conf.agent_mode,"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_c9e68c43","line":618,"updated":"2015-09-17 23:42:40.000000000","message":"This is best moved to:\n\nhttps://review.openstack.org/#/c/224418/","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"82a863b95cd16114bc739949f6a40289d348a5bc","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        self.agent_state \u003d {"},{"line_number":616,"context_line":"            \u0027binary\u0027: \u0027neutron-l3-agent\u0027,"},{"line_number":617,"context_line":"            \u0027host\u0027: host,"},{"line_number":618,"context_line":"            \u0027availability_zone\u0027: self.conf.AGENT.availability_zone,"},{"line_number":619,"context_line":"            \u0027topic\u0027: topics.L3_AGENT,"},{"line_number":620,"context_line":"            \u0027configurations\u0027: {"},{"line_number":621,"context_line":"                \u0027agent_mode\u0027: self.conf.agent_mode,"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_7decd629","line":618,"in_reply_to":"ba15a1d1_c9e68c43","updated":"2015-09-18 01:55:10.000000000","message":"This patch must include stuff for agent DB and availability_zone API. Otherwise, we cannot test this patch. Russell hoped this.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"2b1f32ef76fc5ceb547f19d94cd6aa344d38b964","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        self.agent_state \u003d {"},{"line_number":616,"context_line":"            \u0027binary\u0027: \u0027neutron-l3-agent\u0027,"},{"line_number":617,"context_line":"            \u0027host\u0027: host,"},{"line_number":618,"context_line":"            \u0027availability_zone\u0027: self.conf.AGENT.availability_zone,"},{"line_number":619,"context_line":"            \u0027topic\u0027: topics.L3_AGENT,"},{"line_number":620,"context_line":"            \u0027configurations\u0027: {"},{"line_number":621,"context_line":"                \u0027agent_mode\u0027: self.conf.agent_mode,"}],"source_content_type":"text/x-python","patch_set":36,"id":"9a1a9d01_ebf3eb71","line":618,"updated":"2015-09-25 15:22:14.000000000","message":"I don\u0027t know why you decide put this item here not under configurations dict just like other conf items.","commit_id":"6189618f283016782456e473c31179a7cbdba7b3"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6686efad5aa9cb1a440c6daeccd720df38dbdd14","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        self.agent_state \u003d {"},{"line_number":616,"context_line":"            \u0027binary\u0027: \u0027neutron-l3-agent\u0027,"},{"line_number":617,"context_line":"            \u0027host\u0027: host,"},{"line_number":618,"context_line":"            \u0027availability_zone\u0027: self.conf.AGENT.availability_zone,"},{"line_number":619,"context_line":"            \u0027topic\u0027: topics.L3_AGENT,"},{"line_number":620,"context_line":"            \u0027configurations\u0027: {"},{"line_number":621,"context_line":"                \u0027agent_mode\u0027: self.conf.agent_mode,"}],"source_content_type":"text/x-python","patch_set":36,"id":"9a1a9d01_0ebf4dfc","line":618,"in_reply_to":"9a1a9d01_ebf3eb71","updated":"2015-09-25 15:33:48.000000000","message":"Don\u0027t worry. I changed my mind that the value is managed as top level API. I think that your suggestion points out configurations or top level. Please look at agents_db and then you can confirm that availability_zone isn\u0027t under configurations.","commit_id":"6189618f283016782456e473c31179a7cbdba7b3"}],"neutron/agent/l3_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6cbbd839fb7711f13bc3fe6bae9843cfff3b8cbe","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    config.register_agent_state_opts_helper(conf)"},{"line_number":41,"context_line":"    conf.register_opts(interface.OPTS)"},{"line_number":42,"context_line":"    conf.register_opts(external_process.OPTS)"},{"line_number":43,"context_line":"    config.register_availability_zone_opts_helper(conf)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def main(manager\u003d\u0027neutron.agent.l3.agent.L3NATAgentWithStateReport\u0027):"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_e9e1102b","line":43,"updated":"2015-09-17 23:42:40.000000000","message":"This is best moved to:\n\nhttps://review.openstack.org/#/c/224418/","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"82a863b95cd16114bc739949f6a40289d348a5bc","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    config.register_agent_state_opts_helper(conf)"},{"line_number":41,"context_line":"    conf.register_opts(interface.OPTS)"},{"line_number":42,"context_line":"    conf.register_opts(external_process.OPTS)"},{"line_number":43,"context_line":"    config.register_availability_zone_opts_helper(conf)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def main(manager\u003d\u0027neutron.agent.l3.agent.L3NATAgentWithStateReport\u0027):"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_3df2de06","line":43,"in_reply_to":"ba15a1d1_e9e1102b","updated":"2015-09-18 01:55:10.000000000","message":"This patch must include stuff for agent DB and availability_zone API. Otherwise, we cannot test this patch. Russell hoped this.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"}],"neutron/db/agents_db.py":[{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"8a4fa8d4b203fb79002870153797de93b619fdd0","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        result \u003d {}"},{"line_number":264,"context_line":"        query \u003d self._get_collection_query(context, Agent, filters\u003dfilters)"},{"line_number":265,"context_line":"        for agent in (query."},{"line_number":266,"context_line":"                      group_by(Agent.admin_state_up, Agent.availability_zone)."},{"line_number":267,"context_line":"                      all()):"},{"line_number":268,"context_line":"            key \u003d agent.availability_zone"},{"line_number":269,"context_line":"            result[key] \u003d agent.admin_state_up or result.get(key, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_7e401136","line":266,"updated":"2015-06-16 13:02:41.000000000","message":"why is group_by here?","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"acff855a9ce74325ed8a9557e54fd91758364a70","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    # TOPIC.host is a target topic"},{"line_number":79,"context_line":"    host \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":80,"context_line":"    availability_zone \u003d sa.Column(sa.String(255), nullable\u003dFalse,"},{"line_number":81,"context_line":"                                  server_default\u003d\u0027nova\u0027)"},{"line_number":82,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean, default\u003dTrue,"},{"line_number":83,"context_line":"                               server_default\u003dsql.true(), nullable\u003dFalse)"},{"line_number":84,"context_line":"    # the time when first report came from agents"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_bb6b721d","line":81,"updated":"2015-07-08 22:59:45.000000000","message":"storing comma separated strings in a column doesn\u0027t scale well, as the number of AZs grows, will this create a pain point?","commit_id":"67098a259d0aad4d20b9dd28e39930110a7af36a"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e2c45870b48f166730f91dc91b440861ef20d10c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    # TOPIC.host is a target topic"},{"line_number":79,"context_line":"    host \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":80,"context_line":"    availability_zone \u003d sa.Column(sa.String(255), nullable\u003dFalse,"},{"line_number":81,"context_line":"                                  server_default\u003d\u0027nova\u0027)"},{"line_number":82,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean, default\u003dTrue,"},{"line_number":83,"context_line":"                               server_default\u003dsql.true(), nullable\u003dFalse)"},{"line_number":84,"context_line":"    # the time when first report came from agents"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_6f819ac2","line":81,"in_reply_to":"ba3cc151_bb6b721d","updated":"2015-07-09 04:48:04.000000000","message":"@Ryan,\n\nno. \n\nnumber of AZs in an availability_zone_hints/availability_zones of network/router is considered up to dhcp_agents_per_network/max_l3_agents_per_router.\nSo there is no scale problem.\n\nnote that Agent.availability_zone is a single string.","commit_id":"67098a259d0aad4d20b9dd28e39930110a7af36a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8963faf0fa9f286c3a47b727364b92b0050b37d4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        query \u003d self._get_collection_query(context, Agent, filters\u003dfilters)"},{"line_number":107,"context_line":"        for agent in (query."},{"line_number":108,"context_line":"                      group_by(Agent.admin_state_up, Agent.availability_zone)."},{"line_number":109,"context_line":"                      all()):"},{"line_number":110,"context_line":"            key \u003d agent.availability_zone"},{"line_number":111,"context_line":"            result[key] \u003d agent.admin_state_up or result.get(key, False)"},{"line_number":112,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_e1c5f25b","line":109,"range":{"start_line":109,"start_character":22,"end_line":109,"end_character":25},"updated":"2015-07-28 05:26:31.000000000","message":"is this all() necessary?","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1774f1ddb7460e6b33474f03c2529ea1da12441f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        query \u003d self._get_collection_query(context, Agent, filters\u003dfilters)"},{"line_number":107,"context_line":"        for agent in (query."},{"line_number":108,"context_line":"                      group_by(Agent.admin_state_up, Agent.availability_zone)."},{"line_number":109,"context_line":"                      all()):"},{"line_number":110,"context_line":"            key \u003d agent.availability_zone"},{"line_number":111,"context_line":"            result[key] \u003d agent.admin_state_up or result.get(key, False)"},{"line_number":112,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_1a3695b4","line":109,"in_reply_to":"3a50d1a3_e1c5f25b","updated":"2015-07-31 08:16:57.000000000","message":"Done","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8963faf0fa9f286c3a47b727364b92b0050b37d4","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":117,"context_line":"        return [{\u0027state\u0027: \u0027available\u0027 if v else \u0027unavailable\u0027, \u0027name\u0027: k}"},{"line_number":118,"context_line":"                for k, v in self._list_availability_zones(context, filters)."},{"line_number":119,"context_line":"                iteritems()]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def validate_availability_zones(self, context, availability_zones):"},{"line_number":122,"context_line":"        #TODO(hichihara): should filter by agent_type ?"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_61c7a298","line":119,"range":{"start_line":119,"start_character":16,"end_line":119,"end_character":25},"updated":"2015-07-28 05:26:31.000000000","message":"don\u0027t use iteritems in new code.","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1774f1ddb7460e6b33474f03c2529ea1da12441f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":117,"context_line":"        return [{\u0027state\u0027: \u0027available\u0027 if v else \u0027unavailable\u0027, \u0027name\u0027: k}"},{"line_number":118,"context_line":"                for k, v in self._list_availability_zones(context, filters)."},{"line_number":119,"context_line":"                iteritems()]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def validate_availability_zones(self, context, availability_zones):"},{"line_number":122,"context_line":"        #TODO(hichihara): should filter by agent_type ?"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_9a4aa526","line":119,"in_reply_to":"3a50d1a3_61c7a298","updated":"2015-07-31 08:16:57.000000000","message":"Done","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"a56699d0a1facf3d4dde4f5128633777bc3b599d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            query \u003d admin_ctx.session.query(Agent)"},{"line_number":126,"context_line":"            query \u003d query.filter_by(availability_zone\u003daz)"},{"line_number":127,"context_line":"            if query.count() \u003d\u003d 0:"},{"line_number":128,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"class AgentDbMixin(ext_agent.AgentPluginBase, AgentAvailabilityZoneMixin):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_b9a601a9","line":128,"updated":"2015-07-29 06:26:11.000000000","message":"instead of doing many db queries in a loop, you could  search the result set of the single query:\n\nsession.query(Agent.availability_zone).group_by(Agent.availability_zone).all()","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1774f1ddb7460e6b33474f03c2529ea1da12441f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            query \u003d admin_ctx.session.query(Agent)"},{"line_number":126,"context_line":"            query \u003d query.filter_by(availability_zone\u003daz)"},{"line_number":127,"context_line":"            if query.count() \u003d\u003d 0:"},{"line_number":128,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"class AgentDbMixin(ext_agent.AgentPluginBase, AgentAvailabilityZoneMixin):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_63bdb401","line":128,"in_reply_to":"3a50d1a3_b9a601a9","updated":"2015-07-31 08:16:57.000000000","message":"I\u0027m OK. I will update in netx patch together.","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"447a4fbb083e75d3747a7a487208373d20bef349","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    # TOPIC.host is a target topic"},{"line_number":80,"context_line":"    host \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":81,"context_line":"    availability_zone \u003d sa.Column(sa.String(255), nullable\u003dFalse,"},{"line_number":82,"context_line":"                                  server_default\u003d\u0027nova\u0027)"},{"line_number":83,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean, default\u003dTrue,"},{"line_number":84,"context_line":"                               server_default\u003dsql.true(), nullable\u003dFalse)"},{"line_number":85,"context_line":"    # the time when first report came from agents"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_e6853459","line":82,"updated":"2015-08-11 05:51:30.000000000","message":"why is this nova?","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9bada7e59ff52fa5b3ee81886c60000f29b1512","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    # TOPIC.host is a target topic"},{"line_number":80,"context_line":"    host \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":81,"context_line":"    availability_zone \u003d sa.Column(sa.String(255), nullable\u003dFalse,"},{"line_number":82,"context_line":"                                  server_default\u003d\u0027nova\u0027)"},{"line_number":83,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean, default\u003dTrue,"},{"line_number":84,"context_line":"                               server_default\u003dsql.true(), nullable\u003dFalse)"},{"line_number":85,"context_line":"    # the time when first report came from agents"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_f60fa236","line":82,"in_reply_to":"1a4dcd0f_76f07291","updated":"2015-08-13 07:41:41.000000000","message":"It is better to add a note here.","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e7f2844f03a5fa88c2d938f0345f8eb9916a335","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    # TOPIC.host is a target topic"},{"line_number":80,"context_line":"    host \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":81,"context_line":"    availability_zone \u003d sa.Column(sa.String(255), nullable\u003dFalse,"},{"line_number":82,"context_line":"                                  server_default\u003d\u0027nova\u0027)"},{"line_number":83,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean, default\u003dTrue,"},{"line_number":84,"context_line":"                               server_default\u003dsql.true(), nullable\u003dFalse)"},{"line_number":85,"context_line":"    # the time when first report came from agents"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_76f07291","line":82,"in_reply_to":"1a4dcd0f_e6853459","updated":"2015-08-13 07:30:23.000000000","message":"I referred to Nova and Cinder availability zone.","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"06d6eece9ffd543dcc0f05cf6dfe22c2fe54972d","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    # TOPIC.host is a target topic"},{"line_number":80,"context_line":"    host \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":81,"context_line":"    availability_zone \u003d sa.Column(sa.String(255), nullable\u003dFalse,"},{"line_number":82,"context_line":"                                  server_default\u003d\u0027nova\u0027)"},{"line_number":83,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean, default\u003dTrue,"},{"line_number":84,"context_line":"                               server_default\u003dsql.true(), nullable\u003dFalse)"},{"line_number":85,"context_line":"    # the time when first report came from agents"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa1b9901_d80d823f","line":82,"in_reply_to":"1a4dcd0f_f60fa236","updated":"2015-08-18 23:14:41.000000000","message":"Done","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"fc6b8ced5648c4ba55dbdb4f27f03f0b55aa968b","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        for agent in (query."},{"line_number":110,"context_line":"                      group_by(Agent.admin_state_up, Agent.availability_zone)):"},{"line_number":111,"context_line":"            key \u003d agent.availability_zone"},{"line_number":112,"context_line":"            result[key] \u003d agent.admin_state_up or result.get(key, False)"},{"line_number":113,"context_line":"        return result"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_availability_zones(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_ab964192","line":112,"updated":"2015-08-24 14:06:34.000000000","message":"result[key] may already be set to True here from a previous agent.  It\u0027s possible for this line to reset it to False.  Once set to True, it should never be set back to False.","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"428eb9aa6be345cb67f3946c10cc147e136295b2","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        for agent in (query."},{"line_number":110,"context_line":"                      group_by(Agent.admin_state_up, Agent.availability_zone)):"},{"line_number":111,"context_line":"            key \u003d agent.availability_zone"},{"line_number":112,"context_line":"            result[key] \u003d agent.admin_state_up or result.get(key, False)"},{"line_number":113,"context_line":"        return result"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_availability_zones(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_c1e9f81b","line":112,"in_reply_to":"fa1b9901_ab964192","updated":"2015-08-25 00:17:36.000000000","message":"if result[key] exists and it\u0027s True, this boolean operation result is True.","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2f550d4dd73565b5f362593f44f2b87ad559e582","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        for agent in (query."},{"line_number":110,"context_line":"                      group_by(Agent.admin_state_up, Agent.availability_zone)):"},{"line_number":111,"context_line":"            key \u003d agent.availability_zone"},{"line_number":112,"context_line":"            result[key] \u003d agent.admin_state_up or result.get(key, False)"},{"line_number":113,"context_line":"        return result"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_availability_zones(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_ef1dfa66","line":112,"in_reply_to":"fa1b9901_c1e9f81b","updated":"2015-08-25 08:40:09.000000000","message":"Oda is right.","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"1c1a63f55e29a8be62fe1fd616038fbcaf461b2c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        for agent in (query."},{"line_number":110,"context_line":"                      group_by(Agent.admin_state_up, Agent.availability_zone)):"},{"line_number":111,"context_line":"            key \u003d agent.availability_zone"},{"line_number":112,"context_line":"            result[key] \u003d agent.admin_state_up or result.get(key, False)"},{"line_number":113,"context_line":"        return result"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_availability_zones(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_9b758199","line":112,"in_reply_to":"fa1b9901_ef1dfa66","updated":"2015-08-25 18:46:56.000000000","message":"Ah, sure enough.  Thanks.","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"fc6b8ced5648c4ba55dbdb4f27f03f0b55aa968b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def get_availability_zones(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":116,"context_line":"                               sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":117,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":118,"context_line":"        #NOTE(hichihara): \u0027tenant_id\u0027 is dummy for policy check."},{"line_number":119,"context_line":"        # it is not visible."},{"line_number":120,"context_line":"        return [{\u0027state\u0027: \u0027available\u0027 if v else \u0027unavailable\u0027, \u0027name\u0027: k,"},{"line_number":121,"context_line":"                 \u0027tenant_id\u0027: context.tenant_id}"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_ab20814a","line":118,"updated":"2015-08-24 14:06:34.000000000","message":"nit: add a space after the \u0027#\u0027","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2f550d4dd73565b5f362593f44f2b87ad559e582","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def get_availability_zones(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":116,"context_line":"                               sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":117,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":118,"context_line":"        #NOTE(hichihara): \u0027tenant_id\u0027 is dummy for policy check."},{"line_number":119,"context_line":"        # it is not visible."},{"line_number":120,"context_line":"        return [{\u0027state\u0027: \u0027available\u0027 if v else \u0027unavailable\u0027, \u0027name\u0027: k,"},{"line_number":121,"context_line":"                 \u0027tenant_id\u0027: context.tenant_id}"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_0f194e79","line":118,"in_reply_to":"fa1b9901_ab20814a","updated":"2015-08-25 08:40:09.000000000","message":"Done","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"b66fa558e048712896684e53d4cc1ea303f1102b","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":123,"context_line":"        # NOTE(hichihara): \u0027tenant_id\u0027 is dummy for policy check."},{"line_number":124,"context_line":"        # it is not visible."},{"line_number":125,"context_line":"        return [{\u0027state\u0027: \u0027available\u0027 if v else \u0027unavailable\u0027, \u0027name\u0027: k,"},{"line_number":126,"context_line":"                 \u0027tenant_id\u0027: context.tenant_id}"},{"line_number":127,"context_line":"                for k, v in six.iteritems(self._list_availability_zones("},{"line_number":128,"context_line":"                                           context, filters))]"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_e6839501","line":125,"updated":"2015-09-05 06:50:11.000000000","message":"hope we can have type for az exposed.","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"57cb3ce94c63fbb07300d93d66c95f085c9bed0c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":123,"context_line":"        # NOTE(hichihara): \u0027tenant_id\u0027 is dummy for policy check."},{"line_number":124,"context_line":"        # it is not visible."},{"line_number":125,"context_line":"        return [{\u0027state\u0027: \u0027available\u0027 if v else \u0027unavailable\u0027, \u0027name\u0027: k,"},{"line_number":126,"context_line":"                 \u0027tenant_id\u0027: context.tenant_id}"},{"line_number":127,"context_line":"                for k, v in six.iteritems(self._list_availability_zones("},{"line_number":128,"context_line":"                                           context, filters))]"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_5cf476ef","line":125,"in_reply_to":"da20952f_cbef5ee7","updated":"2015-09-07 09:00:13.000000000","message":"I got your use case that is, when dhcp-agent with AZ1/AZ3 and l3-agent with AZ2/AZ3, user looks like AZ1, AZ2 and AZ3 with state \u0027available\u0027 but really user\u0027s router resource isn\u0027t assigned in AZ1 even if user creates router with availability_hints [AZ1, AZ2].\n\nI can understand the case but availability zone is used as high availability solution basically. The purpose provides high availability with users. When above case, user\u0027s router is assigned AZ2 and AZ3. This may be happened by other reasons(e.g. host fall over, maintenance by Admin). Therefore, I implemented availability zone so that it catches up such cases.\n\nFurthermore, in almost cases, these agents is together in a network node. If there is a use case which has special availability zone for each agents, I will propose it step-by-step. In any case, I will do next feature as described spec.","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"81c3f5bd9ef5e5d90f6b781fd1471c8840668ea3","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":123,"context_line":"        # NOTE(hichihara): \u0027tenant_id\u0027 is dummy for policy check."},{"line_number":124,"context_line":"        # it is not visible."},{"line_number":125,"context_line":"        return [{\u0027state\u0027: \u0027available\u0027 if v else \u0027unavailable\u0027, \u0027name\u0027: k,"},{"line_number":126,"context_line":"                 \u0027tenant_id\u0027: context.tenant_id}"},{"line_number":127,"context_line":"                for k, v in six.iteritems(self._list_availability_zones("},{"line_number":128,"context_line":"                                           context, filters))]"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_f337c2e0","line":125,"in_reply_to":"da20952f_e6839501","updated":"2015-09-07 06:39:27.000000000","message":"What for? What do you mean?","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"498fa5e4dbed1dd2f61e4cb299d383e267e6fb37","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":123,"context_line":"        # NOTE(hichihara): \u0027tenant_id\u0027 is dummy for policy check."},{"line_number":124,"context_line":"        # it is not visible."},{"line_number":125,"context_line":"        return [{\u0027state\u0027: \u0027available\u0027 if v else \u0027unavailable\u0027, \u0027name\u0027: k,"},{"line_number":126,"context_line":"                 \u0027tenant_id\u0027: context.tenant_id}"},{"line_number":127,"context_line":"                for k, v in six.iteritems(self._list_availability_zones("},{"line_number":128,"context_line":"                                           context, filters))]"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_cbef5ee7","line":125,"in_reply_to":"da20952f_f337c2e0","updated":"2015-09-07 07:15:59.000000000","message":"az is from agent, but we have ovs agent, dhcp agent, l3 agent, and lbaas agent later","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"b66fa558e048712896684e53d4cc1ea303f1102b","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _get_network_availability_zones(self, network_id):"},{"line_number":149,"context_line":"        pass"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _get_router_availability_zones(self, router_id):"},{"line_number":152,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_a694bd8a","line":149,"updated":"2015-09-05 06:50:11.000000000","message":"why not implement it?","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"81c3f5bd9ef5e5d90f6b781fd1471c8840668ea3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _get_network_availability_zones(self, network_id):"},{"line_number":149,"context_line":"        pass"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _get_router_availability_zones(self, router_id):"},{"line_number":152,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_b344ea46","line":149,"in_reply_to":"da20952f_a694bd8a","updated":"2015-09-07 06:39:27.000000000","message":"Because it\u0027s implemented on each resource type. Please take a look at agentschedulers_db.py","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"b66fa558e048712896684e53d4cc1ea303f1102b","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        pass"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _get_router_availability_zones(self, router_id):"},{"line_number":152,"context_line":"        pass"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def get_resource_availability_zones(self, resource_type, resource_id):"},{"line_number":155,"context_line":"        if resource_type \u003d\u003d \u0027network\u0027:"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_468da17a","line":152,"updated":"2015-09-05 06:50:11.000000000","message":"ditto","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"81c3f5bd9ef5e5d90f6b781fd1471c8840668ea3","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        pass"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _get_router_availability_zones(self, router_id):"},{"line_number":152,"context_line":"        pass"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def get_resource_availability_zones(self, resource_type, resource_id):"},{"line_number":155,"context_line":"        if resource_type \u003d\u003d \u0027network\u0027:"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_73797292","line":152,"in_reply_to":"da20952f_468da17a","updated":"2015-09-07 06:39:27.000000000","message":"Please take a look at l3_agentschedulers_db.py","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"b66fa558e048712896684e53d4cc1ea303f1102b","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    def get_configuration_dict(self, agent_db):"},{"line_number":194,"context_line":"        try:"},{"line_number":195,"context_line":"            conf \u003d jsonutils.loads(agent_db.configurations)"},{"line_number":196,"context_line":"            conf[\u0027availability_zone\u0027] \u003d agent_db[\u0027availability_zone\u0027]"},{"line_number":197,"context_line":"        except Exception:"},{"line_number":198,"context_line":"            msg \u003d _LW(\u0027Configuration for agent %(agent_type)s on host %(host)s\u0027"},{"line_number":199,"context_line":"                      \u0027 is invalid.\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_66d545e3","line":196,"updated":"2015-09-05 06:50:11.000000000","message":"a small tricky to save it not in configuration but return it in configuration. :)","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"81c3f5bd9ef5e5d90f6b781fd1471c8840668ea3","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    def get_configuration_dict(self, agent_db):"},{"line_number":194,"context_line":"        try:"},{"line_number":195,"context_line":"            conf \u003d jsonutils.loads(agent_db.configurations)"},{"line_number":196,"context_line":"            conf[\u0027availability_zone\u0027] \u003d agent_db[\u0027availability_zone\u0027]"},{"line_number":197,"context_line":"        except Exception:"},{"line_number":198,"context_line":"            msg \u003d _LW(\u0027Configuration for agent %(agent_type)s on host %(host)s\u0027"},{"line_number":199,"context_line":"                      \u0027 is invalid.\u0027)"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_73365204","line":196,"in_reply_to":"da20952f_66d545e3","updated":"2015-09-07 06:39:27.000000000","message":"Availability zone is static information with environment as host so  naturally the parameter should be attribute not configurations. However, current extension system doesn\u0027t allow agent to have it as attribute and using configurations is complicated. Therefore, I reluctantly implemented such as this.","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"b66fa558e048712896684e53d4cc1ea303f1102b","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":281,"context_line":"            res_keys \u003d [\u0027agent_type\u0027, \u0027binary\u0027, \u0027host\u0027, \u0027topic\u0027]"},{"line_number":282,"context_line":"            res \u003d dict((k, agent_state[k]) for k in res_keys)"},{"line_number":283,"context_line":"            res[\u0027availability_zone\u0027] \u003d agent_state.get(\u0027availability_zone\u0027,"},{"line_number":284,"context_line":"                                                       \u0027nova\u0027)"},{"line_number":285,"context_line":"            configurations_dict \u003d agent_state.get(\u0027configurations\u0027, {})"},{"line_number":286,"context_line":"            res[\u0027configurations\u0027] \u003d jsonutils.dumps(configurations_dict)"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_e6ff1564","line":283,"updated":"2015-09-05 06:50:11.000000000","message":"can we allow agent to report it in configuration but store it in res top level,  this is fair to other variable in configuration and be consistent in the agent side.","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"81c3f5bd9ef5e5d90f6b781fd1471c8840668ea3","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":281,"context_line":"            res_keys \u003d [\u0027agent_type\u0027, \u0027binary\u0027, \u0027host\u0027, \u0027topic\u0027]"},{"line_number":282,"context_line":"            res \u003d dict((k, agent_state[k]) for k in res_keys)"},{"line_number":283,"context_line":"            res[\u0027availability_zone\u0027] \u003d agent_state.get(\u0027availability_zone\u0027,"},{"line_number":284,"context_line":"                                                       \u0027nova\u0027)"},{"line_number":285,"context_line":"            configurations_dict \u003d agent_state.get(\u0027configurations\u0027, {})"},{"line_number":286,"context_line":"            res[\u0027configurations\u0027] \u003d jsonutils.dumps(configurations_dict)"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_79095194","line":283,"in_reply_to":"da20952f_e6ff1564","updated":"2015-09-07 06:39:27.000000000","message":"ditto","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"029ec0329e9bc556f9381698970b11697681ef35","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _get_network_availability_zones(self, network_id):"},{"line_number":149,"context_line":"        pass"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _get_router_availability_zones(self, router_id):"},{"line_number":152,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":23,"id":"da20952f_0b7f9615","line":149,"updated":"2015-09-07 07:16:46.000000000","message":"make it abstract?","commit_id":"3560ce10fd6c56f01f5512fa4d7ebe0867afd1e6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b24a805b37fff3954b89967b4061232b41313f45","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _get_network_availability_zones(self, network_id):"},{"line_number":149,"context_line":"        pass"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _get_router_availability_zones(self, router_id):"},{"line_number":152,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":23,"id":"da20952f_debddeb1","line":149,"in_reply_to":"da20952f_0b7f9615","updated":"2015-09-07 07:45:21.000000000","message":"No. Because l3 scheduler doesn\u0027t need to implement this method.","commit_id":"3560ce10fd6c56f01f5512fa4d7ebe0867afd1e6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"029ec0329e9bc556f9381698970b11697681ef35","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        pass"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _get_router_availability_zones(self, router_id):"},{"line_number":152,"context_line":"        pass"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def get_resource_availability_zones(self, resource_type, resource_id):"},{"line_number":155,"context_line":"        if resource_type \u003d\u003d \u0027network\u0027:"}],"source_content_type":"text/x-python","patch_set":23,"id":"da20952f_2b7a9a24","line":152,"updated":"2015-09-07 07:16:46.000000000","message":"ditto","commit_id":"3560ce10fd6c56f01f5512fa4d7ebe0867afd1e6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b24a805b37fff3954b89967b4061232b41313f45","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        pass"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _get_router_availability_zones(self, router_id):"},{"line_number":152,"context_line":"        pass"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def get_resource_availability_zones(self, resource_type, resource_id):"},{"line_number":155,"context_line":"        if resource_type \u003d\u003d \u0027network\u0027:"}],"source_content_type":"text/x-python","patch_set":23,"id":"da20952f_9ee206d4","line":152,"in_reply_to":"da20952f_2b7a9a24","updated":"2015-09-07 07:45:21.000000000","message":"No. Because dhcp scheduler doesn\u0027t need to implement this method.","commit_id":"3560ce10fd6c56f01f5512fa4d7ebe0867afd1e6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"927a74c5658e54c2950f1693c8d30d566e652c16","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        return not AgentDbMixin.is_agent_down(self.heartbeat_timestamp)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"class AgentAvailabilityZoneMixin(az_ext.AvailabilityZonePluginBase):"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _list_availability_zones(self, context, filters\u003dNone):"},{"line_number":112,"context_line":"        result \u003d {}"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_adb5357f","line":109,"updated":"2015-09-12 21:55:34.000000000","message":"Can we have docstrings on the public methods?","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b69608bdcd1db2de0f5f842f977e342eb5185abf","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        return not AgentDbMixin.is_agent_down(self.heartbeat_timestamp)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"class AgentAvailabilityZoneMixin(az_ext.AvailabilityZonePluginBase):"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _list_availability_zones(self, context, filters\u003dNone):"},{"line_number":112,"context_line":"        result \u003d {}"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_901133af","line":109,"in_reply_to":"ba15a1d1_adb5357f","updated":"2015-09-14 23:48:37.000000000","message":"Done","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"927a74c5658e54c2950f1693c8d30d566e652c16","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def validate_availability_zones(self, context, resource_type,"},{"line_number":131,"context_line":"                                    availability_zones):"},{"line_number":132,"context_line":"        if not availability_zones:"},{"line_number":133,"context_line":"            return"},{"line_number":134,"context_line":"        if resource_type \u003d\u003d \u0027network\u0027:"},{"line_number":135,"context_line":"            agent_type \u003d constants.AGENT_TYPE_DHCP"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_4da7b94f","line":132,"updated":"2015-09-12 21:55:34.000000000","message":"aren\u0027t these if blocks masking bad inputs?","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b69608bdcd1db2de0f5f842f977e342eb5185abf","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def validate_availability_zones(self, context, resource_type,"},{"line_number":131,"context_line":"                                    availability_zones):"},{"line_number":132,"context_line":"        if not availability_zones:"},{"line_number":133,"context_line":"            return"},{"line_number":134,"context_line":"        if resource_type \u003d\u003d \u0027network\u0027:"},{"line_number":135,"context_line":"            agent_type \u003d constants.AGENT_TYPE_DHCP"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_908853e9","line":132,"in_reply_to":"ba15a1d1_4da7b94f","updated":"2015-09-14 23:48:37.000000000","message":"The validation is in extensions.availability_zone._validate_availability_zone_hints. This checks empty list only.","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"927a74c5658e54c2950f1693c8d30d566e652c16","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        query \u003d admin_ctx.session.query(Agent.availability_zone).filter_by("},{"line_number":142,"context_line":"                    agent_type\u003dagent_type).group_by(Agent.availability_zone)"},{"line_number":143,"context_line":"        azs \u003d [item[0] for item in query]"},{"line_number":144,"context_line":"        for az in availability_zones:"},{"line_number":145,"context_line":"            if az not in azs:"},{"line_number":146,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_ed624d16","line":144,"updated":"2015-09-12 21:55:34.000000000","message":"why can\u0027t we do this check in SQL directly using the IN operator?\n\nWe could check that the resultset is non empty and if not, then raise the exception. It\u0027s a lot more efficient than going over the resultset.\n\nHave you considered that?","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b69608bdcd1db2de0f5f842f977e342eb5185abf","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        query \u003d admin_ctx.session.query(Agent.availability_zone).filter_by("},{"line_number":142,"context_line":"                    agent_type\u003dagent_type).group_by(Agent.availability_zone)"},{"line_number":143,"context_line":"        azs \u003d [item[0] for item in query]"},{"line_number":144,"context_line":"        for az in availability_zones:"},{"line_number":145,"context_line":"            if az not in azs:"},{"line_number":146,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_f04e6fc0","line":144,"in_reply_to":"ba15a1d1_ed624d16","updated":"2015-09-14 23:48:37.000000000","message":"Done","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"927a74c5658e54c2950f1693c8d30d566e652c16","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    def get_configuration_dict(self, agent_db):"},{"line_number":194,"context_line":"        try:"},{"line_number":195,"context_line":"            conf \u003d jsonutils.loads(agent_db.configurations)"},{"line_number":196,"context_line":"            conf[\u0027availability_zone\u0027] \u003d agent_db[\u0027availability_zone\u0027]"},{"line_number":197,"context_line":"        except Exception:"},{"line_number":198,"context_line":"            msg \u003d _LW(\u0027Configuration for agent %(agent_type)s on host %(host)s\u0027"},{"line_number":199,"context_line":"                      \u0027 is invalid.\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_0dc1c1e4","line":196,"updated":"2015-09-12 21:55:34.000000000","message":"putting this here is masking the fact that the server may be running with agents that do not have this capability, I think this should be handled more gracefully by checking for key existance.","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b69608bdcd1db2de0f5f842f977e342eb5185abf","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    def get_configuration_dict(self, agent_db):"},{"line_number":194,"context_line":"        try:"},{"line_number":195,"context_line":"            conf \u003d jsonutils.loads(agent_db.configurations)"},{"line_number":196,"context_line":"            conf[\u0027availability_zone\u0027] \u003d agent_db[\u0027availability_zone\u0027]"},{"line_number":197,"context_line":"        except Exception:"},{"line_number":198,"context_line":"            msg \u003d _LW(\u0027Configuration for agent %(agent_type)s on host %(host)s\u0027"},{"line_number":199,"context_line":"                      \u0027 is invalid.\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_30038744","line":196,"in_reply_to":"ba15a1d1_0dc1c1e4","updated":"2015-09-14 23:48:37.000000000","message":"Done. I updated so that this patch dones\u0027t affect other agents.","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"059482ec989090fa3ce43ec05115cdd92297cb2b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                               sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":131,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":132,"context_line":"        # NOTE(hichihara): \u0027tenant_id\u0027 is dummy for policy check."},{"line_number":133,"context_line":"        # it is not visible."},{"line_number":134,"context_line":"        return [{\u0027state\u0027: \u0027available\u0027 if v else \u0027unavailable\u0027,"},{"line_number":135,"context_line":"                 \u0027name\u0027: k[0], \u0027resource\u0027: k[1],"},{"line_number":136,"context_line":"                 \u0027tenant_id\u0027: context.tenant_id}"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba15a1d1_f88a98be","line":133,"updated":"2015-09-16 08:07:46.000000000","message":"not visible to what?","commit_id":"579e018bd3ef3cb87793e299e8ebf137c642c476"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"7de911b893a6ff5873845265ff830ec3bb7c71ec","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            else:"},{"line_number":123,"context_line":"                continue"},{"line_number":124,"context_line":"            key \u003d (agent.availability_zone, resource)"},{"line_number":125,"context_line":"            if key:"},{"line_number":126,"context_line":"                result[key] \u003d agent.admin_state_up or result.get(key, False)"},{"line_number":127,"context_line":"        return result"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"ba15a1d1_e5415664","line":125,"updated":"2015-09-17 10:55:38.000000000","message":"this seems always true, doesn\u0027t it?","commit_id":"fab993042937002f0c5469f91583dc5dfef72588"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0808535510d9c4a66ab3e507a484f9a2ae8d4e73","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            else:"},{"line_number":123,"context_line":"                continue"},{"line_number":124,"context_line":"            key \u003d (agent.availability_zone, resource)"},{"line_number":125,"context_line":"            if key:"},{"line_number":126,"context_line":"                result[key] \u003d agent.admin_state_up or result.get(key, False)"},{"line_number":127,"context_line":"        return result"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"ba15a1d1_cb3ea327","line":125,"in_reply_to":"ba15a1d1_e5415664","updated":"2015-09-17 11:39:38.000000000","message":"You\u0027re right. Done.","commit_id":"fab993042937002f0c5469f91583dc5dfef72588"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f7dacce9b9cb5ecc6624e1068c80f910217cf31d","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                                           context, filters))]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def validate_availability_zones(self, context, resource_type,"},{"line_number":141,"context_line":"                                    availability_zones):"},{"line_number":142,"context_line":"        if not availability_zones:"},{"line_number":143,"context_line":"            return"},{"line_number":144,"context_line":"        if resource_type \u003d\u003d \u0027network\u0027:"}],"source_content_type":"text/x-python","patch_set":32,"id":"ba15a1d1_5ff57154","line":141,"updated":"2015-09-17 10:23:27.000000000","message":"Add Docstring to this method. It is better to cover who calls it or something.","commit_id":"fab993042937002f0c5469f91583dc5dfef72588"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0808535510d9c4a66ab3e507a484f9a2ae8d4e73","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                                           context, filters))]"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def validate_availability_zones(self, context, resource_type,"},{"line_number":141,"context_line":"                                    availability_zones):"},{"line_number":142,"context_line":"        if not availability_zones:"},{"line_number":143,"context_line":"            return"},{"line_number":144,"context_line":"        if resource_type \u003d\u003d \u0027network\u0027:"}],"source_content_type":"text/x-python","patch_set":32,"id":"ba15a1d1_ab41efaa","line":141,"in_reply_to":"ba15a1d1_5ff57154","updated":"2015-09-17 11:39:38.000000000","message":"Done","commit_id":"fab993042937002f0c5469f91583dc5dfef72588"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6cbbd839fb7711f13bc3fe6bae9843cfff3b8cbe","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            result[key] \u003d agent.admin_state_up or result.get(key, False)"},{"line_number":126,"context_line":"        return result"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def get_availability_zones(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":129,"context_line":"                               sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":130,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":131,"context_line":"        # NOTE(hichihara): \u0027tenant_id\u0027 is dummy for policy check."}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_49c91cab","line":128,"updated":"2015-09-17 23:42:40.000000000","message":"please consider adding docstrings throughout","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"82a863b95cd16114bc739949f6a40289d348a5bc","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            result[key] \u003d agent.admin_state_up or result.get(key, False)"},{"line_number":126,"context_line":"        return result"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def get_availability_zones(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":129,"context_line":"                               sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":130,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":131,"context_line":"        # NOTE(hichihara): \u0027tenant_id\u0027 is dummy for policy check."}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_5df552ea","line":128,"in_reply_to":"ba15a1d1_49c91cab","updated":"2015-09-18 01:55:10.000000000","message":"I will do.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6cbbd839fb7711f13bc3fe6bae9843cfff3b8cbe","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    def get_configuration_dict(self, agent_db):"},{"line_number":193,"context_line":"        try:"},{"line_number":194,"context_line":"            conf \u003d jsonutils.loads(agent_db.configurations)"},{"line_number":195,"context_line":"            if agent_db[\u0027availability_zone\u0027]:"},{"line_number":196,"context_line":"                conf[\u0027availability_zone\u0027] \u003d agent_db[\u0027availability_zone\u0027]"},{"line_number":197,"context_line":"        except Exception:"},{"line_number":198,"context_line":"            msg \u003d _LW(\u0027Configuration for agent %(agent_type)s on host %(host)s\u0027"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_69cc20bb","line":195,"updated":"2015-09-17 23:42:40.000000000","message":"this should be:\n\n  if availability_zone in agent_db:\n\n\nOtherwise for old agents this will blow up, no?","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"82a863b95cd16114bc739949f6a40289d348a5bc","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    def get_configuration_dict(self, agent_db):"},{"line_number":193,"context_line":"        try:"},{"line_number":194,"context_line":"            conf \u003d jsonutils.loads(agent_db.configurations)"},{"line_number":195,"context_line":"            if agent_db[\u0027availability_zone\u0027]:"},{"line_number":196,"context_line":"                conf[\u0027availability_zone\u0027] \u003d agent_db[\u0027availability_zone\u0027]"},{"line_number":197,"context_line":"        except Exception:"},{"line_number":198,"context_line":"            msg \u003d _LW(\u0027Configuration for agent %(agent_type)s on host %(host)s\u0027"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_7dd37660","line":195,"in_reply_to":"ba15a1d1_69cc20bb","updated":"2015-09-18 01:55:10.000000000","message":"The key exists there after DB migration so null check only.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"7f5d90c9ea3e6c6f51b90ed241de36944dd74ebc","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            agent_type \u003d constants.AGENT_TYPE_L3"},{"line_number":149,"context_line":"        else:"},{"line_number":150,"context_line":"            return"},{"line_number":151,"context_line":"        admin_ctx \u003d context.elevated()"},{"line_number":152,"context_line":"        query \u003d admin_ctx.session.query(Agent.availability_zone).filter_by("},{"line_number":153,"context_line":"                    agent_type\u003dagent_type).group_by(Agent.availability_zone)"},{"line_number":154,"context_line":"        query \u003d query.filter(Agent.availability_zone.in_(availability_zones))"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_51c55d59","line":151,"updated":"2015-09-24 07:44:30.000000000","message":"is this elevated() necessary?","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3cac6d6925fda337cca3700a561ddda6bcacd0fb","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            agent_type \u003d constants.AGENT_TYPE_L3"},{"line_number":149,"context_line":"        else:"},{"line_number":150,"context_line":"            return"},{"line_number":151,"context_line":"        admin_ctx \u003d context.elevated()"},{"line_number":152,"context_line":"        query \u003d admin_ctx.session.query(Agent.availability_zone).filter_by("},{"line_number":153,"context_line":"                    agent_type\u003dagent_type).group_by(Agent.availability_zone)"},{"line_number":154,"context_line":"        query \u003d query.filter(Agent.availability_zone.in_(availability_zones))"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a1a9d01_93dcbde5","line":151,"in_reply_to":"9a1a9d01_6e0a8928","updated":"2015-09-28 07:26:34.000000000","message":"how?  i don\u0027t think it affects the following query.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0719d59bd4912a9e6e5969030f5d77690641478f","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            agent_type \u003d constants.AGENT_TYPE_L3"},{"line_number":149,"context_line":"        else:"},{"line_number":150,"context_line":"            return"},{"line_number":151,"context_line":"        admin_ctx \u003d context.elevated()"},{"line_number":152,"context_line":"        query \u003d admin_ctx.session.query(Agent.availability_zone).filter_by("},{"line_number":153,"context_line":"                    agent_type\u003dagent_type).group_by(Agent.availability_zone)"},{"line_number":154,"context_line":"        query \u003d query.filter(Agent.availability_zone.in_(availability_zones))"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a1a9d01_f6cdbe85","line":151,"in_reply_to":"9a1a9d01_93dcbde5","updated":"2015-09-28 23:52:49.000000000","message":"Sorry. I misunderstood. I updated.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4748b50c8666418b4f42fd1186262bbfe7907fc2","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            agent_type \u003d constants.AGENT_TYPE_L3"},{"line_number":149,"context_line":"        else:"},{"line_number":150,"context_line":"            return"},{"line_number":151,"context_line":"        admin_ctx \u003d context.elevated()"},{"line_number":152,"context_line":"        query \u003d admin_ctx.session.query(Agent.availability_zone).filter_by("},{"line_number":153,"context_line":"                    agent_type\u003dagent_type).group_by(Agent.availability_zone)"},{"line_number":154,"context_line":"        query \u003d query.filter(Agent.availability_zone.in_(availability_zones))"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a1a9d01_6e0a8928","line":151,"in_reply_to":"ba15a1d1_51c55d59","updated":"2015-09-25 16:09:00.000000000","message":"Yes. Because we need admin flag to access agent table.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"7f5d90c9ea3e6c6f51b90ed241de36944dd74ebc","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        query \u003d query.filter(Agent.availability_zone.in_(availability_zones))"},{"line_number":155,"context_line":"        azs \u003d [item[0] for item in query]"},{"line_number":156,"context_line":"        for az in availability_zones:"},{"line_number":157,"context_line":"            if az not in azs:"},{"line_number":158,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_b152b965","line":157,"updated":"2015-09-24 07:44:30.000000000","message":"\"not set(availability_zones) \u003c\u003d set(azs)\" is simpler to read.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"460b8da512d6ef6657aa8b3fe73486b54fb73447","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        query \u003d query.filter(Agent.availability_zone.in_(availability_zones))"},{"line_number":155,"context_line":"        azs \u003d [item[0] for item in query]"},{"line_number":156,"context_line":"        for az in availability_zones:"},{"line_number":157,"context_line":"            if az not in azs:"},{"line_number":158,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"9a1a9d01_ad8047c1","line":157,"in_reply_to":"9a1a9d01_56a34ab2","updated":"2015-09-29 10:04:55.000000000","message":"ah, i see.  thank you for explanation.\n\nyou can do:\n\n  diff \u003d set(availability_zones) - set(azs)\n  if diff:\n     raise az_ext.AvailabilityZoneNotFound(diff.pop())","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0719d59bd4912a9e6e5969030f5d77690641478f","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        query \u003d query.filter(Agent.availability_zone.in_(availability_zones))"},{"line_number":155,"context_line":"        azs \u003d [item[0] for item in query]"},{"line_number":156,"context_line":"        for az in availability_zones:"},{"line_number":157,"context_line":"            if az not in azs:"},{"line_number":158,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"9a1a9d01_56a34ab2","line":157,"in_reply_to":"9a1a9d01_73732916","updated":"2015-09-28 23:52:49.000000000","message":"You expect the following, don\u0027t you?\n\n if not set(availability_zones) \u003c\u003d set(azs):\n     raise az_ext.AvailabilityZoneNotFound()\n\nBut AvailabilityZoneNotFound needs a AZ value which server cannnot find.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"58c89102560d1bb5b49bc5f50054c8a9c5bbb47c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        query \u003d query.filter(Agent.availability_zone.in_(availability_zones))"},{"line_number":155,"context_line":"        azs \u003d [item[0] for item in query]"},{"line_number":156,"context_line":"        for az in availability_zones:"},{"line_number":157,"context_line":"            if az not in azs:"},{"line_number":158,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"9a1a9d01_1d062f1d","line":157,"in_reply_to":"9a1a9d01_ad8047c1","updated":"2015-09-29 15:53:43.000000000","message":"That\u0027s really right. Thank you for your advice.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3cac6d6925fda337cca3700a561ddda6bcacd0fb","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        query \u003d query.filter(Agent.availability_zone.in_(availability_zones))"},{"line_number":155,"context_line":"        azs \u003d [item[0] for item in query]"},{"line_number":156,"context_line":"        for az in availability_zones:"},{"line_number":157,"context_line":"            if az not in azs:"},{"line_number":158,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"9a1a9d01_73732916","line":157,"in_reply_to":"9a1a9d01_f976613d","updated":"2015-09-28 07:26:34.000000000","message":"?\nsorry, i don\u0027t understand.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4748b50c8666418b4f42fd1186262bbfe7907fc2","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        query \u003d query.filter(Agent.availability_zone.in_(availability_zones))"},{"line_number":155,"context_line":"        azs \u003d [item[0] for item in query]"},{"line_number":156,"context_line":"        for az in availability_zones:"},{"line_number":157,"context_line":"            if az not in azs:"},{"line_number":158,"context_line":"                raise az_ext.AvailabilityZoneNotFound(availability_zone\u003daz)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"9a1a9d01_f976613d","line":157,"in_reply_to":"ba15a1d1_b152b965","updated":"2015-09-25 16:09:00.000000000","message":"You\u0027re right but this cannot call AvailabilityZoneNotFound.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"4ac2870b636a5a8639366219986ff8b4ca08784a","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        try:"},{"line_number":195,"context_line":"            conf \u003d jsonutils.loads(agent_db.configurations)"},{"line_number":196,"context_line":"            if agent_db[\u0027availability_zone\u0027]:"},{"line_number":197,"context_line":"                conf[\u0027availability_zone\u0027] \u003d agent_db[\u0027availability_zone\u0027]"},{"line_number":198,"context_line":"        except Exception:"},{"line_number":199,"context_line":"            msg \u003d _LW(\u0027Configuration for agent %(agent_type)s on host %(host)s\u0027"},{"line_number":200,"context_line":"                      \u0027 is invalid.\u0027)"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_b89d6e0c","line":197,"updated":"2015-09-19 11:59:15.000000000","message":"since the agent reports az out of configuration, I don\u0027t think we should mix it in conf here.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b56cc7c938c5b8f1de333d7ce6999b4bd5c7e6a","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        try:"},{"line_number":195,"context_line":"            conf \u003d jsonutils.loads(agent_db.configurations)"},{"line_number":196,"context_line":"            if agent_db[\u0027availability_zone\u0027]:"},{"line_number":197,"context_line":"                conf[\u0027availability_zone\u0027] \u003d agent_db[\u0027availability_zone\u0027]"},{"line_number":198,"context_line":"        except Exception:"},{"line_number":199,"context_line":"            msg \u003d _LW(\u0027Configuration for agent %(agent_type)s on host %(host)s\u0027"},{"line_number":200,"context_line":"                      \u0027 is invalid.\u0027)"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_cb27b910","line":197,"in_reply_to":"ba15a1d1_9395eb89","updated":"2015-09-23 01:59:15.000000000","message":"It doesn\u0027t matter to me. agent report is an API between neutron agents and server, and the return value of this method is an internal interface. It would be nice if both matches, but I don\u0027t think it is a requirement.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a4f3f2e452e0a37ab763843c4a135d8e0762a213","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        try:"},{"line_number":195,"context_line":"            conf \u003d jsonutils.loads(agent_db.configurations)"},{"line_number":196,"context_line":"            if agent_db[\u0027availability_zone\u0027]:"},{"line_number":197,"context_line":"                conf[\u0027availability_zone\u0027] \u003d agent_db[\u0027availability_zone\u0027]"},{"line_number":198,"context_line":"        except Exception:"},{"line_number":199,"context_line":"            msg \u003d _LW(\u0027Configuration for agent %(agent_type)s on host %(host)s\u0027"},{"line_number":200,"context_line":"                      \u0027 is invalid.\u0027)"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_9395eb89","line":197,"in_reply_to":"ba15a1d1_b89d6e0c","updated":"2015-09-19 13:43:54.000000000","message":"I disagree because availability zone is set by config of agent. This was decided in spec too.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4748b50c8666418b4f42fd1186262bbfe7907fc2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        try:"},{"line_number":195,"context_line":"            conf \u003d jsonutils.loads(agent_db.configurations)"},{"line_number":196,"context_line":"            if agent_db[\u0027availability_zone\u0027]:"},{"line_number":197,"context_line":"                conf[\u0027availability_zone\u0027] \u003d agent_db[\u0027availability_zone\u0027]"},{"line_number":198,"context_line":"        except Exception:"},{"line_number":199,"context_line":"            msg \u003d _LW(\u0027Configuration for agent %(agent_type)s on host %(host)s\u0027"},{"line_number":200,"context_line":"                      \u0027 is invalid.\u0027)"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a1a9d01_6e75a9c9","line":197,"in_reply_to":"ba15a1d1_cb27b910","updated":"2015-09-25 16:09:00.000000000","message":"I moved it to agent top info.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9a992021f9abbd088a99bfdec0ad7e53367e27c3","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        res[\u0027alive\u0027] \u003d not AgentDbMixin.is_agent_down("},{"line_number":220,"context_line":"            res[\u0027heartbeat_timestamp\u0027])"},{"line_number":221,"context_line":"        res[\u0027configurations\u0027] \u003d self.get_configuration_dict(agent)"},{"line_number":222,"context_line":"        if agent[\u0027availability_zone\u0027]:"},{"line_number":223,"context_line":"            res[\u0027availability_zone\u0027] \u003d agent[\u0027availability_zone\u0027]"},{"line_number":224,"context_line":"        return self._fields(res, fields)"},{"line_number":225,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"9a1a9d01_65fa88bf","line":222,"updated":"2015-09-27 16:54:31.000000000","message":"if the agent doesn\u0027t report an availability_zone (during an upgrade you could have a server at version V and agents at version V-1), could this cause a KeyError exception?","commit_id":"6189618f283016782456e473c31179a7cbdba7b3"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"df9c2e5b4f967e9bafed0ff1401fe5129498c72e","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        res[\u0027alive\u0027] \u003d not AgentDbMixin.is_agent_down("},{"line_number":220,"context_line":"            res[\u0027heartbeat_timestamp\u0027])"},{"line_number":221,"context_line":"        res[\u0027configurations\u0027] \u003d self.get_configuration_dict(agent)"},{"line_number":222,"context_line":"        if agent[\u0027availability_zone\u0027]:"},{"line_number":223,"context_line":"            res[\u0027availability_zone\u0027] \u003d agent[\u0027availability_zone\u0027]"},{"line_number":224,"context_line":"        return self._fields(res, fields)"},{"line_number":225,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"9a1a9d01_00cb7a1f","line":222,"in_reply_to":"9a1a9d01_65fa88bf","updated":"2015-09-28 00:23:01.000000000","message":"You\u0027re right. I changed this behavior in new patchset. In the case, all agents show availability_zone attribute but the value of AZ unaware agents is always NULL.","commit_id":"6189618f283016782456e473c31179a7cbdba7b3"}],"neutron/db/agentschedulers_db.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"fc6b8ced5648c4ba55dbdb4f27f03f0b55aa968b","unresolved":false,"context_lines":[{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _get_network_availability_zones(self, network_id):"},{"line_number":459,"context_line":"        context \u003d ncontext.get_admin_context()"},{"line_number":460,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":461,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"},{"line_number":462,"context_line":"            query \u003d query.join(NetworkDhcpAgentBinding)"},{"line_number":463,"context_line":"            query \u003d query.filter("}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_318f0225","line":460,"updated":"2015-08-24 14:06:34.000000000","message":"I can see that subtransactions\u003dTrue is set nearly everywhere, but it doesn\u0027t seem to be needed in this case.  If so, I\u0027d remove it.","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2f550d4dd73565b5f362593f44f2b87ad559e582","unresolved":false,"context_lines":[{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _get_network_availability_zones(self, network_id):"},{"line_number":459,"context_line":"        context \u003d ncontext.get_admin_context()"},{"line_number":460,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":461,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"},{"line_number":462,"context_line":"            query \u003d query.join(NetworkDhcpAgentBinding)"},{"line_number":463,"context_line":"            query \u003d query.filter("}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_afd06254","line":460,"in_reply_to":"fa1b9901_318f0225","updated":"2015-08-25 08:40:09.000000000","message":"I guess it\u0027s needed... I can see all begin() is with subtransactions\u003dTrue. Could you tell me the reason why not needed?","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"1c1a63f55e29a8be62fe1fd616038fbcaf461b2c","unresolved":false,"context_lines":[{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _get_network_availability_zones(self, network_id):"},{"line_number":459,"context_line":"        context \u003d ncontext.get_admin_context()"},{"line_number":460,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":461,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"},{"line_number":462,"context_line":"            query \u003d query.join(NetworkDhcpAgentBinding)"},{"line_number":463,"context_line":"            query \u003d query.filter("}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_bbd6454d","line":460,"in_reply_to":"fa1b9901_afd06254","updated":"2015-08-25 18:46:56.000000000","message":"since it\u0027s used everywhere, you can just leave it for now ..","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"ae24bf098a1bb26f0bb290e263e69dc16e12e589","unresolved":false,"context_lines":[{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _get_network_availability_zones(self, network_id):"},{"line_number":459,"context_line":"        context \u003d ncontext.get_admin_context()"},{"line_number":460,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":461,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"},{"line_number":462,"context_line":"            query \u003d query.join(NetworkDhcpAgentBinding)"},{"line_number":463,"context_line":"            query \u003d query.filter("}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_351a2e70","line":460,"in_reply_to":"fa1b9901_bbd6454d","updated":"2015-08-26 04:58:14.000000000","message":"I got it.","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"927a74c5658e54c2950f1693c8d30d566e652c16","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        if self.network_scheduler:"},{"line_number":456,"context_line":"            self.network_scheduler.auto_schedule_networks(self, context, host)"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _get_network_availability_zones(self, network_id):"},{"line_number":459,"context_line":"        context \u003d ncontext.get_admin_context()"},{"line_number":460,"context_line":"        with context.session.begin():"},{"line_number":461,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_ad6c5509","line":458,"updated":"2015-09-12 21:55:34.000000000","message":"why is this being added as a private method? Adding it here seems odd for a private method. Perhaps this could be a public method.","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b69608bdcd1db2de0f5f842f977e342eb5185abf","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        if self.network_scheduler:"},{"line_number":456,"context_line":"            self.network_scheduler.auto_schedule_networks(self, context, host)"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    def _get_network_availability_zones(self, network_id):"},{"line_number":459,"context_line":"        context \u003d ncontext.get_admin_context()"},{"line_number":460,"context_line":"        with context.session.begin():"},{"line_number":461,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_90a4d357","line":458,"in_reply_to":"ba15a1d1_ad6c5509","updated":"2015-09-14 23:48:37.000000000","message":"Done","commit_id":"384b8b126c8688e24c92e45903691015911eed47"}],"neutron/db/availability_zone/router_az.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"059482ec989090fa3ce43ec05115cdd92297cb2b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def _extend_extra_router_dict(self, router_res, router_db):"},{"line_number":30,"context_line":"        super(RouterAvailabilityZoneMixin, self)._extend_extra_router_dict("},{"line_number":31,"context_line":"            router_res, router_db)"},{"line_number":32,"context_line":"        if not utils.is_extension_supported(self, \u0027l3_agent_scheduler\u0027):"},{"line_number":33,"context_line":"            return"},{"line_number":34,"context_line":"        router_res[\u0027availability_zone_hints\u0027] \u003d ("},{"line_number":35,"context_line":"            az_ext.convert_az_string_to_list("}],"source_content_type":"text/x-python","patch_set":30,"id":"ba15a1d1_6bdeb412","line":32,"range":{"start_line":32,"start_character":51,"end_line":32,"end_character":69},"updated":"2015-09-16 08:07:46.000000000","message":"why not router_availability_zone?","commit_id":"579e018bd3ef3cb87793e299e8ebf137c642c476"}],"neutron/db/availability_zone_db.py":[{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"8a4fa8d4b203fb79002870153797de93b619fdd0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            if self._get_collection_count(admin_ctx, agents_db.Agent,"},{"line_number":57,"context_line":"                                          filters\u003dfilters) \u003d\u003d 0:"},{"line_number":58,"context_line":"                LOG.warning(_LW(\"Unknown availability_zone \u0027%s\u0027 specified\"),"},{"line_number":59,"context_line":"                            az)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _get_availability_zones(self, context, id):"},{"line_number":62,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_9d96f8ee","line":59,"updated":"2015-06-16 13:02:41.000000000","message":"I think an exception should be raised if a user passes an availability zone that does not exist.","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"8a4fa8d4b203fb79002870153797de93b619fdd0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            query \u003d context.session.query(self._az_model).filter_by(**kwargs)"},{"line_number":65,"context_line":"            return [rec.availability_zone for rec in query]"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _create_availability_zones(self, context, id, availability_zones):"},{"line_number":68,"context_line":"        if availability_zones is None:"},{"line_number":69,"context_line":"            #NOTE: None comes from internal create network (eg. ha_network)"},{"line_number":70,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_7e25b108","line":67,"updated":"2015-06-16 13:02:41.000000000","message":"this actually creates availability zone bindings","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8963faf0fa9f286c3a47b727364b92b0050b37d4","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def _extend_availability_zone(plugin, net_res, net_db):"},{"line_number":28,"context_line":"    if not hasattr(plugin, \u0027get_network_availability_zones\u0027):"},{"line_number":29,"context_line":"        return"},{"line_number":30,"context_line":"    net_res[\u0027availability_zone_hints\u0027] \u003d az_ext.convert_az_string_to_list("},{"line_number":31,"context_line":"        net_db[\u0027availability_zone_hints\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_a1b7ead6","line":28,"updated":"2015-07-28 05:26:31.000000000","message":"can you try to avoid hasattr?","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1774f1ddb7460e6b33474f03c2529ea1da12441f","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def _extend_availability_zone(plugin, net_res, net_db):"},{"line_number":28,"context_line":"    if not hasattr(plugin, \u0027get_network_availability_zones\u0027):"},{"line_number":29,"context_line":"        return"},{"line_number":30,"context_line":"    net_res[\u0027availability_zone_hints\u0027] \u003d az_ext.convert_az_string_to_list("},{"line_number":31,"context_line":"        net_db[\u0027availability_zone_hints\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_5afbbd47","line":28,"in_reply_to":"3a50d1a3_1fbefcad","updated":"2015-07-31 08:16:57.000000000","message":"I mean test to support dhcp_agent_scheduler extension.","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f6fa6630ac51452c8e3e762f0d6a513ec660be6c","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def _extend_availability_zone(plugin, net_res, net_db):"},{"line_number":28,"context_line":"    if not hasattr(plugin, \u0027get_network_availability_zones\u0027):"},{"line_number":29,"context_line":"        return"},{"line_number":30,"context_line":"    net_res[\u0027availability_zone_hints\u0027] \u003d az_ext.convert_az_string_to_list("},{"line_number":31,"context_line":"        net_db[\u0027availability_zone_hints\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_1fbefcad","line":28,"in_reply_to":"3a50d1a3_21fc01b7","updated":"2015-07-29 04:08:42.000000000","message":"it\u0027s a general preference of mine.  i\u0027m not sure if it\u0027s project\u0027s.\nbesides that, it effectively extends plugin api.\n\nwhat exact condition you want to test here?\nif \"plugin\" supports dhcp_agent_scheduler?\nor something more complicated?","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1cb351c604f2961dc5681430c4d4dc8033cd9b47","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def _extend_availability_zone(plugin, net_res, net_db):"},{"line_number":28,"context_line":"    if not hasattr(plugin, \u0027get_network_availability_zones\u0027):"},{"line_number":29,"context_line":"        return"},{"line_number":30,"context_line":"    net_res[\u0027availability_zone_hints\u0027] \u003d az_ext.convert_az_string_to_list("},{"line_number":31,"context_line":"        net_db[\u0027availability_zone_hints\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_21fc01b7","line":28,"in_reply_to":"3a50d1a3_a1b7ead6","updated":"2015-07-29 02:46:30.000000000","message":"Please elaborate a little further? Is there any reason avoiding hasattr?","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8963faf0fa9f286c3a47b727364b92b0050b37d4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def _extend_extra_router_dict(self, router_res, router_db):"},{"line_number":49,"context_line":"        super(RouterAvailabilityZoneMixin, self)._extend_extra_router_dict("},{"line_number":50,"context_line":"            router_res, router_db)"},{"line_number":51,"context_line":"        if not hasattr(self, \u0027get_router_availability_zones\u0027):"},{"line_number":52,"context_line":"            return"},{"line_number":53,"context_line":"        router_res[\u0027availability_zone_hints\u0027] \u003d ("},{"line_number":54,"context_line":"            az_ext.convert_az_string_to_list("}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_c1bc76bd","line":51,"updated":"2015-07-28 05:26:31.000000000","message":"ditto","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1774f1ddb7460e6b33474f03c2529ea1da12441f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def _extend_extra_router_dict(self, router_res, router_db):"},{"line_number":49,"context_line":"        super(RouterAvailabilityZoneMixin, self)._extend_extra_router_dict("},{"line_number":50,"context_line":"            router_res, router_db)"},{"line_number":51,"context_line":"        if not hasattr(self, \u0027get_router_availability_zones\u0027):"},{"line_number":52,"context_line":"            return"},{"line_number":53,"context_line":"        router_res[\u0027availability_zone_hints\u0027] \u003d ("},{"line_number":54,"context_line":"            az_ext.convert_az_string_to_list("}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_fab72983","line":51,"in_reply_to":"3a50d1a3_c1bc76bd","updated":"2015-07-31 08:16:57.000000000","message":"I mean test to support l3_agent_scheduler extension.","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"b66fa558e048712896684e53d4cc1ea303f1102b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_ab87a6b3","line":2,"updated":"2015-09-05 06:50:11.000000000","message":"I think we should separate this file into two: one is for network, another is for router.\nsome vendor does not supports dhcp and l3 agents at the same time.","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"81c3f5bd9ef5e5d90f6b781fd1471c8840668ea3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":3,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":4,"context_line":"#    a copy of the License at"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_3359bafd","line":2,"in_reply_to":"da20952f_ab87a6b3","updated":"2015-09-07 06:39:27.000000000","message":"In future, we will have to do if we add more other resources into AZ. Currently, this patch has check whether or not plugin supports dhcp_agent_scheduler/l3_agent_scheduler.","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"b66fa558e048712896684e53d4cc1ea303f1102b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def _extend_extra_router_dict(self, router_res, router_db):"},{"line_number":48,"context_line":"        super(RouterAvailabilityZoneMixin, self)._extend_extra_router_dict("},{"line_number":49,"context_line":"            router_res, router_db)"},{"line_number":50,"context_line":"        if not utils.is_extension_supported(self, \u0027l3_agent_scheduler\u0027):"},{"line_number":51,"context_line":"            return"},{"line_number":52,"context_line":"        router_res[\u0027availability_zone_hints\u0027] \u003d ("},{"line_number":53,"context_line":"            az_ext.convert_az_string_to_list("}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_4bf92a4d","line":50,"updated":"2015-09-05 06:50:11.000000000","message":"print an warning here since we should have l3_agent_scheduler supported if we support the availability zone for router,\n\nif it is not true, maybe we should not just return here, we should continue if we have the case where we support the router az extension but we don\u0027t have l3 agent scheduler supported.","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"57cb3ce94c63fbb07300d93d66c95f085c9bed0c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def _extend_extra_router_dict(self, router_res, router_db):"},{"line_number":48,"context_line":"        super(RouterAvailabilityZoneMixin, self)._extend_extra_router_dict("},{"line_number":49,"context_line":"            router_res, router_db)"},{"line_number":50,"context_line":"        if not utils.is_extension_supported(self, \u0027l3_agent_scheduler\u0027):"},{"line_number":51,"context_line":"            return"},{"line_number":52,"context_line":"        router_res[\u0027availability_zone_hints\u0027] \u003d ("},{"line_number":53,"context_line":"            az_ext.convert_az_string_to_list("}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_1cc83e54","line":50,"in_reply_to":"da20952f_0bd476e9","updated":"2015-09-07 09:00:13.000000000","message":"If users use L3RouterPlugin, surely use l3_agent_scheduler. If users don\u0027t use L3RouterPlugin, this method just returns.\n\nDo you mean that we should care vendor plugin witch use availability zone but not use l3_agent_scheduler? What is the plugin? There is no such plugin.","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"81c3f5bd9ef5e5d90f6b781fd1471c8840668ea3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def _extend_extra_router_dict(self, router_res, router_db):"},{"line_number":48,"context_line":"        super(RouterAvailabilityZoneMixin, self)._extend_extra_router_dict("},{"line_number":49,"context_line":"            router_res, router_db)"},{"line_number":50,"context_line":"        if not utils.is_extension_supported(self, \u0027l3_agent_scheduler\u0027):"},{"line_number":51,"context_line":"            return"},{"line_number":52,"context_line":"        router_res[\u0027availability_zone_hints\u0027] \u003d ("},{"line_number":53,"context_line":"            az_ext.convert_az_string_to_list("}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_59f00d67","line":50,"in_reply_to":"da20952f_4bf92a4d","updated":"2015-09-07 06:39:27.000000000","message":"If l3-agent users use this extensions, they surely use l3_agent_scheduler.\n\nCurrently there is no plugin(except ml2) which supports AZ extension. In future, we will be able to add if such plugin appears.","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"498fa5e4dbed1dd2f61e4cb299d383e267e6fb37","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    def _extend_extra_router_dict(self, router_res, router_db):"},{"line_number":48,"context_line":"        super(RouterAvailabilityZoneMixin, self)._extend_extra_router_dict("},{"line_number":49,"context_line":"            router_res, router_db)"},{"line_number":50,"context_line":"        if not utils.is_extension_supported(self, \u0027l3_agent_scheduler\u0027):"},{"line_number":51,"context_line":"            return"},{"line_number":52,"context_line":"        router_res[\u0027availability_zone_hints\u0027] \u003d ("},{"line_number":53,"context_line":"            az_ext.convert_az_string_to_list("}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_0bd476e9","line":50,"in_reply_to":"da20952f_59f00d67","updated":"2015-09-07 07:15:59.000000000","message":"I still think we should deal with this case in more detail. we can have case which use availablityzone but not use l3_agent_scheduler.","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8963faf0fa9f286c3a47b727364b92b0050b37d4","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                if n[key] \u003d\u003d attributes.ATTR_NOT_SPECIFIED or n[key] \u003d\u003d \"\":"},{"line_number":257,"context_line":"                    args[key] \u003d \"\""},{"line_number":258,"context_line":"                else:"},{"line_number":259,"context_line":"                    self.validate_availability_zones(context, n[key])"},{"line_number":260,"context_line":"                    args[key] \u003d n[key]"},{"line_number":261,"context_line":"            network \u003d models_v2.Network(**args)"},{"line_number":262,"context_line":"            if n[\u0027shared\u0027]:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_e1ef32af","line":259,"updated":"2015-07-28 05:26:31.000000000","message":"does this mean you can\u0027t create a resource with az without agents running?","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1774f1ddb7460e6b33474f03c2529ea1da12441f","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                if n[key] \u003d\u003d attributes.ATTR_NOT_SPECIFIED or n[key] \u003d\u003d \"\":"},{"line_number":257,"context_line":"                    args[key] \u003d \"\""},{"line_number":258,"context_line":"                else:"},{"line_number":259,"context_line":"                    self.validate_availability_zones(context, n[key])"},{"line_number":260,"context_line":"                    args[key] \u003d n[key]"},{"line_number":261,"context_line":"            network \u003d models_v2.Network(**args)"},{"line_number":262,"context_line":"            if n[\u0027shared\u0027]:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_fd272361","line":259,"in_reply_to":"3a50d1a3_e1ef32af","updated":"2015-07-31 08:16:57.000000000","message":"It checks whether there is a agent with the az. Whether running doesn\u0027t matter.","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"927a74c5658e54c2950f1693c8d30d566e652c16","unresolved":false,"context_lines":[{"line_number":330,"context_line":"            if (\u0027vlan_transparent\u0027 in n and n[\u0027vlan_transparent\u0027] !\u003d"},{"line_number":331,"context_line":"                attributes.ATTR_NOT_SPECIFIED):"},{"line_number":332,"context_line":"                args[\u0027vlan_transparent\u0027] \u003d n[\u0027vlan_transparent\u0027]"},{"line_number":333,"context_line":"            key \u003d \u0027availability_zone_hints\u0027"},{"line_number":334,"context_line":"            if key in n:"},{"line_number":335,"context_line":"                # if the key exists, it means the plugin supports"},{"line_number":336,"context_line":"                # availability zone. so the relevant methods exist."}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_4d55791b","line":333,"updated":"2015-09-12 21:55:34.000000000","message":"I think these should be string literals","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b69608bdcd1db2de0f5f842f977e342eb5185abf","unresolved":false,"context_lines":[{"line_number":330,"context_line":"            if (\u0027vlan_transparent\u0027 in n and n[\u0027vlan_transparent\u0027] !\u003d"},{"line_number":331,"context_line":"                attributes.ATTR_NOT_SPECIFIED):"},{"line_number":332,"context_line":"                args[\u0027vlan_transparent\u0027] \u003d n[\u0027vlan_transparent\u0027]"},{"line_number":333,"context_line":"            key \u003d \u0027availability_zone_hints\u0027"},{"line_number":334,"context_line":"            if key in n:"},{"line_number":335,"context_line":"                # if the key exists, it means the plugin supports"},{"line_number":336,"context_line":"                # availability zone. so the relevant methods exist."}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_50871bb5","line":333,"in_reply_to":"ba15a1d1_4d55791b","updated":"2015-09-14 23:48:37.000000000","message":"Done","commit_id":"384b8b126c8688e24c92e45903691015911eed47"}],"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"fc6b8ced5648c4ba55dbdb4f27f03f0b55aa968b","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def _get_router_availability_zones(self, router_id):"},{"line_number":507,"context_line":"        context \u003d n_ctx.get_admin_context()"},{"line_number":508,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":509,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"},{"line_number":510,"context_line":"            query \u003d query.join(RouterL3AgentBinding)"},{"line_number":511,"context_line":"            query \u003d query.filter("}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_1cb775f6","line":508,"updated":"2015-08-24 14:06:34.000000000","message":"Is subtransactions\u003dTrue needed here?  It doesn\u0027t look like it.","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"ae24bf098a1bb26f0bb290e263e69dc16e12e589","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    def _get_router_availability_zones(self, router_id):"},{"line_number":507,"context_line":"        context \u003d n_ctx.get_admin_context()"},{"line_number":508,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":509,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"},{"line_number":510,"context_line":"            query \u003d query.join(RouterL3AgentBinding)"},{"line_number":511,"context_line":"            query \u003d query.filter("}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_5a003102","line":508,"in_reply_to":"fa1b9901_1cb775f6","updated":"2015-08-26 04:58:14.000000000","message":"Done","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"927a74c5658e54c2950f1693c8d30d566e652c16","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        res \u003d query.filter(agents_db.Agent.id.in_(agent_ids)).first()"},{"line_number":506,"context_line":"        return res[0]"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    def _get_router_availability_zones(self, router_id):"},{"line_number":509,"context_line":"        context \u003d n_ctx.get_admin_context()"},{"line_number":510,"context_line":"        with context.session.begin():"},{"line_number":511,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_ed300d0a","line":508,"updated":"2015-09-12 21:55:34.000000000","message":"same consideration as done for the dhcp agent mixin","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b69608bdcd1db2de0f5f842f977e342eb5185abf","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        res \u003d query.filter(agents_db.Agent.id.in_(agent_ids)).first()"},{"line_number":506,"context_line":"        return res[0]"},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    def _get_router_availability_zones(self, router_id):"},{"line_number":509,"context_line":"        context \u003d n_ctx.get_admin_context()"},{"line_number":510,"context_line":"        with context.session.begin():"},{"line_number":511,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_b0bc776d","line":508,"in_reply_to":"ba15a1d1_ed300d0a","updated":"2015-09-14 23:48:37.000000000","message":"Done","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"aacf1380cef2a81af6d413c802b9ab2ffc2f2715","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        res \u003d query.filter(agents_db.Agent.id.in_(agent_ids)).first()"},{"line_number":507,"context_line":"        return res[0]"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def get_router_availability_zones(self, router_id):"},{"line_number":510,"context_line":"        context \u003d n_ctx.get_admin_context()"},{"line_number":511,"context_line":"        with context.session.begin():"},{"line_number":512,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba15a1d1_f9514cd9","line":509,"updated":"2015-09-15 20:39:19.000000000","message":"but you didn\u0027t exactly do the same thing for DHCP, why?","commit_id":"94e83dc6951d8fa4a04aa1d753217af16404e296"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f2098a62a152bcf1cba245619a37274feebea142","unresolved":false,"context_lines":[{"line_number":506,"context_line":"        res \u003d query.filter(agents_db.Agent.id.in_(agent_ids)).first()"},{"line_number":507,"context_line":"        return res[0]"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def get_router_availability_zones(self, router_id):"},{"line_number":510,"context_line":"        context \u003d n_ctx.get_admin_context()"},{"line_number":511,"context_line":"        with context.session.begin():"},{"line_number":512,"context_line":"            query \u003d context.session.query(agents_db.Agent.availability_zone)"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba15a1d1_a3671624","line":509,"in_reply_to":"ba15a1d1_f9514cd9","updated":"2015-09-16 05:54:47.000000000","message":"in dhcp, it is get_network_availability_zones","commit_id":"94e83dc6951d8fa4a04aa1d753217af16404e296"}],"neutron/db/l3_attrs_db.py":[{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"acff855a9ce74325ed8a9557e54fd91758364a70","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                   nullable\u003dFalse)"},{"line_number":46,"context_line":"    ha_vr_id \u003d sa.Column(sa.Integer())"},{"line_number":47,"context_line":"    # Availability Zone support"},{"line_number":48,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    router \u003d orm.relationship("},{"line_number":51,"context_line":"        l3_db.Router,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_3b668251","line":48,"updated":"2015-07-08 22:59:45.000000000","message":"ditto comment on L81 of agents_db.py","commit_id":"67098a259d0aad4d20b9dd28e39930110a7af36a"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"059482ec989090fa3ce43ec05115cdd92297cb2b","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    extra_attributes \u003d ("},{"line_number":140,"context_line":"        l3_dvr_db.L3_NAT_with_dvr_db_mixin.extra_attributes +"},{"line_number":141,"context_line":"        router_az.RouterAvailabilityZoneMixin.extra_attributes + ["},{"line_number":142,"context_line":"            {\u0027name\u0027: \u0027ha\u0027, \u0027default\u0027: cfg.CONF.l3_ha},"},{"line_number":143,"context_line":"            {\u0027name\u0027: \u0027ha_vr_id\u0027, \u0027default\u0027: 0}])"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"ba15a1d1_0e10664d","line":141,"updated":"2015-09-16 08:07:46.000000000","message":"how about making ExtraAttributesMixin follow MRO,\ninstead of coupling these mixins tightly?","commit_id":"579e018bd3ef3cb87793e299e8ebf137c642c476"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6c90bf4e7857ab537505b8a21cddbfef1124b851","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    extra_attributes \u003d ("},{"line_number":140,"context_line":"        l3_dvr_db.L3_NAT_with_dvr_db_mixin.extra_attributes +"},{"line_number":141,"context_line":"        router_az.RouterAvailabilityZoneMixin.extra_attributes + ["},{"line_number":142,"context_line":"            {\u0027name\u0027: \u0027ha\u0027, \u0027default\u0027: cfg.CONF.l3_ha},"},{"line_number":143,"context_line":"            {\u0027name\u0027: \u0027ha_vr_id\u0027, \u0027default\u0027: 0}])"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"ba15a1d1_2b7c0eb4","line":141,"in_reply_to":"ba15a1d1_0e10664d","updated":"2015-09-17 04:57:16.000000000","message":"I haven\u0027t finished still. I\u0027m thinking about it.","commit_id":"579e018bd3ef3cb87793e299e8ebf137c642c476"}],"neutron/db/migration/alembic_migrations/versions/59cb5b6cf4d_availability_zone.py":[{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"acff855a9ce74325ed8a9557e54fd91758364a70","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    op.add_column(\u0027networks\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027availability_zone_hints\u0027, sa.String(255)))"},{"line_number":38,"context_line":"    op.add_column(\u0027router_extra_attributes\u0027,"},{"line_number":39,"context_line":"                  sa.Column(\u0027availability_zone_hints\u0027, sa.String(255)))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_7bdf2ad6","line":39,"updated":"2015-07-08 22:59:45.000000000","message":"ditto earlier comments","commit_id":"67098a259d0aad4d20b9dd28e39930110a7af36a"}],"neutron/db/migration/alembic_migrations/versions/liberty/expand/59cb5b6cf4d_availability_zone.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"fc6b8ced5648c4ba55dbdb4f27f03f0b55aa968b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_cb0e1532","line":1,"updated":"2015-08-24 14:06:34.000000000","message":"This likely is not accurate, so I would just remove this line.","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2f550d4dd73565b5f362593f44f2b87ad559e582","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_4a3bb438","line":1,"in_reply_to":"fa1b9901_cb0e1532","updated":"2015-08-25 08:40:09.000000000","message":"Done","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"fc6b8ced5648c4ba55dbdb4f27f03f0b55aa968b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027availability_zone\u0027, sa.String(length\u003d255),"},{"line_number":35,"context_line":"        nullable\u003dFalse, server_default\u003d\u0027nova\u0027))"},{"line_number":36,"context_line":"    op.add_column(\u0027networks\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027availability_zone_hints\u0027, sa.String(255)))"},{"line_number":38,"context_line":"    op.add_column(\u0027router_extra_attributes\u0027,"},{"line_number":39,"context_line":"                  sa.Column(\u0027availability_zone_hints\u0027, sa.String(255)))"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_a80c0743","line":37,"updated":"2015-08-24 14:06:34.000000000","message":"can you use length\u003d255 here and the next add_column() to be consistent with most other migrations?","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2f550d4dd73565b5f362593f44f2b87ad559e582","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027availability_zone\u0027, sa.String(length\u003d255),"},{"line_number":35,"context_line":"        nullable\u003dFalse, server_default\u003d\u0027nova\u0027))"},{"line_number":36,"context_line":"    op.add_column(\u0027networks\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027availability_zone_hints\u0027, sa.String(255)))"},{"line_number":38,"context_line":"    op.add_column(\u0027router_extra_attributes\u0027,"},{"line_number":39,"context_line":"                  sa.Column(\u0027availability_zone_hints\u0027, sa.String(255)))"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_0a45bcb1","line":37,"in_reply_to":"fa1b9901_a80c0743","updated":"2015-08-25 08:40:09.000000000","message":"Done","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6cbbd839fb7711f13bc3fe6bae9843cfff3b8cbe","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027agents\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027availability_zone\u0027, sa.String(length\u003d255)))"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_c9544ccb","line":33,"updated":"2015-09-17 23:42:40.000000000","message":"Don\u0027t we need a default?","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"82a863b95cd16114bc739949f6a40289d348a5bc","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027agents\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027availability_zone\u0027, sa.String(length\u003d255)))"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_5d5a32f3","line":33,"in_reply_to":"ba15a1d1_c9544ccb","updated":"2015-09-18 01:55:10.000000000","message":"Because there are some agents doesn\u0027t have availability_zone.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"edc56c08ae5c153b69e54e709a09512c6666c270","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027agents\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027availability_zone\u0027, sa.String(length\u003d255)))"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_9910be5a","line":33,"updated":"2015-09-18 18:18:05.000000000","message":"If a user upgrades an existing deployment, all their existing agent records will have null AZ fields. You might consider adding a SQL statement here to populate existing records with the configured AZ.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4748b50c8666418b4f42fd1186262bbfe7907fc2","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027agents\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027availability_zone\u0027, sa.String(length\u003d255)))"}],"source_content_type":"text/x-python","patch_set":35,"id":"9a1a9d01_f906611f","line":33,"in_reply_to":"ba15a1d1_2b14354b","updated":"2015-09-25 16:09:00.000000000","message":"The purpose is to set NULL to AZ unaware agents. Futhermore, if availability_zone extension isn\u0027t used in user\u0027s environment, this value must be NULL.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6b56cc7c938c5b8f1de333d7ce6999b4bd5c7e6a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027agents\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027availability_zone\u0027, sa.String(length\u003d255)))"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_2b14354b","line":33,"in_reply_to":"ba15a1d1_5a0d1136","updated":"2015-09-23 01:59:15.000000000","message":"I still wonder if we need server_default OR need to populate the default value when a neutron server aware of AZ receives report_state without AZ info from agents. Otherwise, during upgrade, only upgraded agents have AZ info and will be selected as candidates of scheduling. Thought?","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"475f9d021b38f38cd8e6fab3b7c44863f3d6de22","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027agents\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027availability_zone\u0027, sa.String(length\u003d255)))"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_9b974f3a","line":33,"in_reply_to":"ba15a1d1_9910be5a","updated":"2015-09-18 20:28:59.000000000","message":"I wondered if we needed a ServerDefault for this one...","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"e1f8b1f8327854491d9c448ae17d16f05b6a5d2b","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027agents\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027availability_zone\u0027, sa.String(length\u003d255)))"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_d5126b09","line":33,"in_reply_to":"ba15a1d1_9b974f3a","updated":"2015-09-19 06:57:13.000000000","message":"No problem. The value is set by config only. Even if all their existing agent records have null AZ fields, the value will be properly set by config.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a5cc24dfbfda461ca6a30a1800dd0e98b788c34d","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027agents\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027availability_zone\u0027, sa.String(length\u003d255)))"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_e5780f2e","line":33,"in_reply_to":"ba15a1d1_d5126b09","updated":"2015-09-21 08:17:46.000000000","message":"I missed that moment when server_default\u003d\u0027nova\u0027 disappeared from here as I remember it was here earliest patches . I realize that this value is set though config, but I\u0027ll be more comfortable if server_default will stay here. So, if you have to push another patch set return this parameter.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"dcead119c30e303bbdab08eff0c1f935e1b32b5f","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def upgrade():"},{"line_number":32,"context_line":"    op.add_column(\u0027agents\u0027,"},{"line_number":33,"context_line":"                  sa.Column(\u0027availability_zone\u0027, sa.String(length\u003d255)))"}],"source_content_type":"text/x-python","patch_set":35,"id":"ba15a1d1_5a0d1136","line":33,"in_reply_to":"ba15a1d1_e5780f2e","updated":"2015-09-21 11:01:18.000000000","message":"However, all agents don\u0027t have availability_zone value, for example, openvswitch_agent and metadata_agent.","commit_id":"fcd1d448f3adc401f55da4cd19b46409dd74e309"}],"neutron/db/models_v2.py":[{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"acff855a9ce74325ed8a9557e54fd91758364a70","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":259,"context_line":"    mtu \u003d sa.Column(sa.Integer, nullable\u003dTrue)"},{"line_number":260,"context_line":"    vlan_transparent \u003d sa.Column(sa.Boolean, nullable\u003dTrue)"},{"line_number":261,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_fbd25ad0","line":261,"updated":"2015-07-08 22:59:45.000000000","message":"ditto earlier comments","commit_id":"67098a259d0aad4d20b9dd28e39930110a7af36a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9bada7e59ff52fa5b3ee81886c60000f29b1512","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    rbac_entries \u003d orm.relationship(\"NetworkRBAC\", backref\u003d\u0027network\u0027,"},{"line_number":268,"context_line":"                                    lazy\u003d\u0027joined\u0027,"},{"line_number":269,"context_line":"                                    cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":270,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255))"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_d63ce630","line":270,"range":{"start_line":270,"start_character":50,"end_line":270,"end_character":53},"updated":"2015-08-13 07:41:41.000000000","message":"Could you define 255 as a constant?\n\nIn addition, do you have a check to the length of availability_zone_hints and availability_zone before storing the db table?","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"06d6eece9ffd543dcc0f05cf6dfe22c2fe54972d","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    rbac_entries \u003d orm.relationship(\"NetworkRBAC\", backref\u003d\u0027network\u0027,"},{"line_number":268,"context_line":"                                    lazy\u003d\u0027joined\u0027,"},{"line_number":269,"context_line":"                                    cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":270,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255))"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa1b9901_1342fb10","line":270,"in_reply_to":"1a4dcd0f_d63ce630","updated":"2015-08-18 23:14:41.000000000","message":"I cannot see the definitions in other files. I don\u0027t think that this patch need prepare 255 constant for all variables using 255.\n\navailability_zone_hints is checked by _convert_list_to_string. I think that availability_zone value is set by admin so we don\u0027t need the check. I can add it into check when agent starts if need. Do you think it\u0027s needed?","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dfe438c9808122fdaf9b0c0a72aca1c5d4b26a68","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    rbac_entries \u003d orm.relationship(\"NetworkRBAC\", backref\u003d\u0027network\u0027,"},{"line_number":268,"context_line":"                                    lazy\u003d\u0027joined\u0027,"},{"line_number":269,"context_line":"                                    cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":270,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255))"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa1b9901_9e4ef66d","line":270,"in_reply_to":"fa1b9901_1342fb10","updated":"2015-08-19 08:39:56.000000000","message":"I think the config value check at agent start would be helpful.","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9a352852346ccc45803dd12d92f35cc7ddc404fd","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    rbac_entries \u003d orm.relationship(\"NetworkRBAC\", backref\u003d\u0027network\u0027,"},{"line_number":268,"context_line":"                                    lazy\u003d\u0027joined\u0027,"},{"line_number":269,"context_line":"                                    cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":270,"context_line":"    availability_zone_hints \u003d sa.Column(sa.String(255))"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa1b9901_4789aac9","line":270,"in_reply_to":"fa1b9901_9e4ef66d","updated":"2015-08-24 05:02:33.000000000","message":"I got it. I will add the check into next patch.","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"}],"neutron/extensions/agent.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"5b0b0067ddcfeddef151a6d7b3ee411ccd2e62dc","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def update_attributes_map(self, attributes):"},{"line_number":112,"context_line":"        super(Agent, self).update_attributes_map("},{"line_number":113,"context_line":"            attributes, extension_attrs_map\u003dRESOURCE_ATTRIBUTE_MAP)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_extended_resources(self, version):"},{"line_number":116,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":38,"id":"9a1a9d01_139952c4","line":113,"updated":"2015-09-29 10:55:15.000000000","message":"why is this necessary?","commit_id":"5b9df9e3542aac07158aacc8c15ee7582d4544be"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"57e96291e57fac9e724c75e17a76666dc8c96b4c","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def update_attributes_map(self, attributes):"},{"line_number":112,"context_line":"        super(Agent, self).update_attributes_map("},{"line_number":113,"context_line":"            attributes, extension_attrs_map\u003dRESOURCE_ATTRIBUTE_MAP)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_extended_resources(self, version):"},{"line_number":116,"context_line":"        if version \u003d\u003d \"2.0\":"}],"source_content_type":"text/x-python","patch_set":38,"id":"9a1a9d01_98aecde4","line":113,"in_reply_to":"9a1a9d01_139952c4","updated":"2015-09-29 16:02:56.000000000","message":"Because I wasn\u0027t able to get availability_zone attribute via GET Agent API without this.","commit_id":"5b9df9e3542aac07158aacc8c15ee7582d4544be"}],"neutron/extensions/availability_zone.py":[{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"8a4fa8d4b203fb79002870153797de93b619fdd0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    message \u003d _(\"AvailabilityZone %(availability_zone)s could not be found\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class Availability_zone(object):"},{"line_number":49,"context_line":"    \"\"\"Availability zone extension.\"\"\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_3cf13bce","line":48,"updated":"2015-06-16 13:02:41.000000000","message":"AvailabilityZone?","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"8a4fa8d4b203fb79002870153797de93b619fdd0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        controller \u003d base.create_resource(AVAILABILITY_ZONES,"},{"line_number":79,"context_line":"                                          RESOURCE_NAME,"},{"line_number":80,"context_line":"                                          plugin, params"},{"line_number":81,"context_line":"                                          )"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        ex \u003d extensions.ResourceExtension(AVAILABILITY_ZONES,"},{"line_number":84,"context_line":"                                          controller)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_1c443fb5","line":81,"updated":"2015-06-16 13:02:41.000000000","message":"nit: L78 to L81 will fit on 2 lines:\n\n        controller \u003d base.create_resource(AVAILABILITY_ZONES,\n                                          RESOURCE_NAME, plugin, params)","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"8a4fa8d4b203fb79002870153797de93b619fdd0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                          )"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        ex \u003d extensions.ResourceExtension(AVAILABILITY_ZONES,"},{"line_number":84,"context_line":"                                          controller)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        return [ex]"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_dc7b47f3","line":84,"updated":"2015-06-16 13:02:41.000000000","message":"will fit on one line","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"8a4fa8d4b203fb79002870153797de93b619fdd0","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        \"\"\"This operation is not allow in REST API."},{"line_number":101,"context_line":"        @raise exceptions.BadRequest:"},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        raise exceptions.BadRequest()"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def delete_availability_zone(self, context, id):"},{"line_number":106,"context_line":"        \"\"\"This operation is not allow in REST API."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_0b50615c","line":103,"updated":"2015-06-16 13:02:41.000000000","message":"can you provide a more specific message","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"8a4fa8d4b203fb79002870153797de93b619fdd0","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        \"\"\"This operation is not allow in REST API."},{"line_number":107,"context_line":"        @raise exceptions.BadRequest:"},{"line_number":108,"context_line":"        \"\"\""},{"line_number":109,"context_line":"        raise exceptions.BadRequest()"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def update_availability_zone(self, context, availability_zone):"},{"line_number":112,"context_line":"        \"\"\"This operation is not allow in REST API."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_5d0ab022","line":109,"updated":"2015-06-16 13:02:41.000000000","message":"ditto","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"8a4fa8d4b203fb79002870153797de93b619fdd0","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        \"\"\"This operation is not allow in REST API."},{"line_number":113,"context_line":"        @raise exceptions.BadRequest:"},{"line_number":114,"context_line":"        \"\"\""},{"line_number":115,"context_line":"        raise exceptions.BadRequest()"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @abc.abstractmethod"},{"line_number":118,"context_line":"    def get_availability_zones(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_dd1ec062","line":115,"updated":"2015-06-16 13:02:41.000000000","message":"ditto","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8963faf0fa9f286c3a47b727364b92b0050b37d4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        msg \u003d _(\"availability_zone_hints must be a list\")"},{"line_number":28,"context_line":"        raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":29,"context_line":"    if not data:"},{"line_number":30,"context_line":"        return \"\""},{"line_number":31,"context_line":"    az_string \u003d \u0027,\u0027.join(data)"},{"line_number":32,"context_line":"    if len(az_string) \u003e 255:"},{"line_number":33,"context_line":"        msg \u003d _(\"too many availability_zone_hints specified\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_a12daa47","line":30,"updated":"2015-07-28 05:26:31.000000000","message":"L29-30 seems unnecessary","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1774f1ddb7460e6b33474f03c2529ea1da12441f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        msg \u003d _(\"availability_zone_hints must be a list\")"},{"line_number":28,"context_line":"        raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":29,"context_line":"    if not data:"},{"line_number":30,"context_line":"        return \"\""},{"line_number":31,"context_line":"    az_string \u003d \u0027,\u0027.join(data)"},{"line_number":32,"context_line":"    if len(az_string) \u003e 255:"},{"line_number":33,"context_line":"        msg \u003d _(\"too many availability_zone_hints specified\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_1dd20f35","line":30,"in_reply_to":"3a50d1a3_a12daa47","updated":"2015-07-31 08:16:57.000000000","message":"Done","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8963faf0fa9f286c3a47b727364b92b0050b37d4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    message \u003d _(\"AvailabilityZone %(availability_zone)s could not be found\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class Availability_zone(object):"},{"line_number":74,"context_line":"    \"\"\"Availability zone extension.\"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_61da424d","line":73,"updated":"2015-07-28 05:26:31.000000000","message":"inherit ExtensionDescriptor","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1774f1ddb7460e6b33474f03c2529ea1da12441f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    message \u003d _(\"AvailabilityZone %(availability_zone)s could not be found\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class Availability_zone(object):"},{"line_number":74,"context_line":"    \"\"\"Availability zone extension.\"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a50d1a3_dddb474e","line":73,"in_reply_to":"3a50d1a3_61da424d","updated":"2015-07-31 08:16:57.000000000","message":"Done","commit_id":"4b83af33e644853a3987ca3545b0fd8a5e803a80"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9bada7e59ff52fa5b3ee81886c60000f29b1512","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron import manager"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def _convert_list_to_string(data):"},{"line_number":26,"context_line":"    if not isinstance(data, list):"},{"line_number":27,"context_line":"        msg \u003d _(\"availability_zone_hints must be a list\")"},{"line_number":28,"context_line":"        raise exceptions.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_f65562c1","line":25,"updated":"2015-08-13 07:41:41.000000000","message":"Converting a value from a list to a string loses a data structure.\nWhy do you need to convert it into a string for internal processing?\nIf you really need a string, it is better to encode it into JSON.","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"06d6eece9ffd543dcc0f05cf6dfe22c2fe54972d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron import manager"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def _convert_list_to_string(data):"},{"line_number":26,"context_line":"    if not isinstance(data, list):"},{"line_number":27,"context_line":"        msg \u003d _(\"availability_zone_hints must be a list\")"},{"line_number":28,"context_line":"        raise exceptions.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa1b9901_ae1c04c2","line":25,"in_reply_to":"1a4dcd0f_f65562c1","updated":"2015-08-18 23:14:41.000000000","message":"Because this is stored into DB by one field. It\u0027s also just simple list so I guess that we don\u0027t need to use JSON.","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9bada7e59ff52fa5b3ee81886c60000f29b1512","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def convert_az_string_to_list(az_string):"},{"line_number":37,"context_line":"    return az_string.split(\u0027,\u0027) if az_string else []"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Attribute Map"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_9613be00","line":37,"range":{"start_line":37,"start_character":20,"end_line":37,"end_character":32},"updated":"2015-08-13 07:41:41.000000000","message":"If you depend on a comma, you should check a comma is not contained in a request.","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"06d6eece9ffd543dcc0f05cf6dfe22c2fe54972d","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def convert_az_string_to_list(az_string):"},{"line_number":37,"context_line":"    return az_string.split(\u0027,\u0027) if az_string else []"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Attribute Map"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa1b9901_ee1c3c15","line":37,"in_reply_to":"1a4dcd0f_9613be00","updated":"2015-08-18 23:14:41.000000000","message":"Done","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9bada7e59ff52fa5b3ee81886c60000f29b1512","unresolved":false,"context_lines":[{"line_number":42,"context_line":"AVAILABILITY_ZONES \u003d \u0027availability_zones\u0027"},{"line_number":43,"context_line":"AVAILABILITY_ZONE_HINTS \u003d \u0027availability_zone_hints\u0027"},{"line_number":44,"context_line":"AZ_KEYS \u003d [AVAILABILITY_ZONES, AVAILABILITY_ZONE_HINTS]"},{"line_number":45,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":46,"context_line":"    AVAILABILITY_ZONES: {"},{"line_number":47,"context_line":"        \u0027name\u0027: {\u0027is_visible\u0027: True},"},{"line_number":48,"context_line":"        \u0027state\u0027: {\u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_36918a47","line":45,"updated":"2015-08-13 07:41:41.000000000","message":"IMHO, it is better to split this map into RESOURCE_ATTRIBUTE_MAP and EXTENDED_ATTERIBUTE as security group extension does. It looks more clear to me.","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"06d6eece9ffd543dcc0f05cf6dfe22c2fe54972d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"AVAILABILITY_ZONES \u003d \u0027availability_zones\u0027"},{"line_number":43,"context_line":"AVAILABILITY_ZONE_HINTS \u003d \u0027availability_zone_hints\u0027"},{"line_number":44,"context_line":"AZ_KEYS \u003d [AVAILABILITY_ZONES, AVAILABILITY_ZONE_HINTS]"},{"line_number":45,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":46,"context_line":"    AVAILABILITY_ZONES: {"},{"line_number":47,"context_line":"        \u0027name\u0027: {\u0027is_visible\u0027: True},"},{"line_number":48,"context_line":"        \u0027state\u0027: {\u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa1b9901_4e7a08f3","line":45,"in_reply_to":"1a4dcd0f_36918a47","updated":"2015-08-18 23:14:41.000000000","message":"Done","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9bada7e59ff52fa5b3ee81886c60000f29b1512","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        \"\"\"This operation is not allow in REST API."},{"line_number":117,"context_line":"        @raise exceptions.BadRequest:"},{"line_number":118,"context_line":"        \"\"\""},{"line_number":119,"context_line":"        raise exceptions.BadRequest()"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def delete_availability_zone(self, context, id):"},{"line_number":122,"context_line":"        \"\"\"This operation is not allow in REST API."}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_36b8aac7","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":37},"updated":"2015-08-13 07:41:41.000000000","message":"BadRequest should describe the reason.","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"06d6eece9ffd543dcc0f05cf6dfe22c2fe54972d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        \"\"\"This operation is not allow in REST API."},{"line_number":117,"context_line":"        @raise exceptions.BadRequest:"},{"line_number":118,"context_line":"        \"\"\""},{"line_number":119,"context_line":"        raise exceptions.BadRequest()"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def delete_availability_zone(self, context, id):"},{"line_number":122,"context_line":"        \"\"\"This operation is not allow in REST API."}],"source_content_type":"text/x-python","patch_set":13,"id":"fa1b9901_ed8678da","line":119,"in_reply_to":"1a4dcd0f_36b8aac7","updated":"2015-08-18 23:14:41.000000000","message":"I noticed these definitions isn\u0027t needed because nobody excuses the API. Therefore, I removed","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"cb5e67b8cdf50736d548783217b7eea01fd7f452","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        raise exceptions.BadRequest()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @abc.abstractmethod"},{"line_number":134,"context_line":"    def get_availability_zones(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":135,"context_line":"                               sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":136,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":137,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":14,"id":"1a4dcd0f_42f5614e","line":134,"updated":"2015-08-13 16:03:00.000000000","message":"is a user without the admin role supposed to be able to GET availability_zones ? That doesn\u0027t work for me.\n\n    $ curl --silent -H GET http://192.168.2.2:9696/v2.0/availability_zones.json   -H \"X-Auth-Token: $TOKEN_ID\" | python -m json.tool\n    {\n        \"NeutronError\": {\n            \"detail\": \"\",\n            \"message\": \"Failed to check policy tenant_id:%(tenant_id)s because Unable to verify match:%(tenant_id)s as the parent resource: tenant was not found\",\n            \"type\": \"PolicyCheckError\"\n        }\n    }\n\n\nBut it works for admin:\n    $ curl --silent -H GET http://192.168.2.2:9696/v2.0/availability_zones.json   -H \"X-Auth-Token: $TOKEN_ID\" | python -m json.tool\n    {\n        \"availability_zones\": [\n            {\n                \"name\": \"zone1\",\n                \"state\": \"available\"\n            },\n            {\n                \"name\": \"nova\",\n                \"state\": \"available\"\n            }\n        ]\n    }","commit_id":"2fb0a21498188e03078cb24baa539a8636b8ad76"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a1af577d59336e531d42fa02b963cda851cb7df0","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        raise exceptions.BadRequest()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @abc.abstractmethod"},{"line_number":134,"context_line":"    def get_availability_zones(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":135,"context_line":"                               sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":136,"context_line":"                               page_reverse\u003dFalse):"},{"line_number":137,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa1b9901_7d86a866","line":134,"in_reply_to":"1a4dcd0f_42f5614e","updated":"2015-08-18 23:15:09.000000000","message":"Good catch! Thanks.","commit_id":"2fb0a21498188e03078cb24baa539a8636b8ad76"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"fc6b8ced5648c4ba55dbdb4f27f03f0b55aa968b","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def convert_az_string_to_list(az_string):"},{"line_number":41,"context_line":"    return az_string.split(\u0027,\u0027) if az_string else []"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Attribute Map"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_3c04b97c","line":41,"updated":"2015-08-24 14:06:34.000000000","message":"We can support a list of strings via the API, why not just do it that way?\n\nFurther, I\u0027m not sure it actually makes any sense to support specifying more than one AZ anyway.  The spec seems to imply it\u0027s a single AZ.  The description of \"availability_zone_hints\" is \"availability zone candidate for the network\", which sounds like a single AZ.  I\u0027d make it a single AZ and change \"hints\" to \"hint\".","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2f550d4dd73565b5f362593f44f2b87ad559e582","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def convert_az_string_to_list(az_string):"},{"line_number":41,"context_line":"    return az_string.split(\u0027,\u0027) if az_string else []"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Attribute Map"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_6ccd75b6","line":41,"in_reply_to":"fa1b9901_3c04b97c","updated":"2015-08-25 08:40:09.000000000","message":"I don\u0027t understand your question. Is it the same Motoki\u0027s question in PS13?\n\nBecause this AZ supports DHCP HA and L3HA. This patch enables these high availability function to use availability zones.","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"1c1a63f55e29a8be62fe1fd616038fbcaf461b2c","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def convert_az_string_to_list(az_string):"},{"line_number":41,"context_line":"    return az_string.split(\u0027,\u0027) if az_string else []"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Attribute Map"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_3be6b515","line":41,"in_reply_to":"fa1b9901_6ccd75b6","updated":"2015-08-25 18:46:56.000000000","message":"Sorry, ignore this, I read the code backwards..","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"d9bd7778135a57642cb0787a4cea1fefef9acd36","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        if \u0027,\u0027 in az:"},{"line_number":30,"context_line":"            msg \u003d _(\"availability_zone_hints must not include comma\")"},{"line_number":31,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":32,"context_line":"    az_string \u003d \u0027,\u0027.join(data)"},{"line_number":33,"context_line":"    if len(az_string) \u003e 255:"},{"line_number":34,"context_line":"        msg \u003d _(\"too many availability_zone_hints specified\")"},{"line_number":35,"context_line":"        raise exceptions.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da20952f_ddd3fb02","line":32,"updated":"2015-08-28 18:27:50.000000000","message":"Akihiro Motoki suggested to use a json string encoding instead of a simple comma separation here back on patch 13.  I think that\u0027s a good idea.  It avoids having to reject a \",\" in an AZ name.  The change would be something like\n\n    az_string \u003d json.dumps(data)\n\nexcept use the jsonutils module from oslo_serialization.","commit_id":"39e3c4cabb7ebbf17a7480a49cb652c0fea5653c"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"bcf5e54f6b8c6285086a050d5eeb5c9cf951c254","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        if \u0027,\u0027 in az:"},{"line_number":30,"context_line":"            msg \u003d _(\"availability_zone_hints must not include comma\")"},{"line_number":31,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":32,"context_line":"    az_string \u003d \u0027,\u0027.join(data)"},{"line_number":33,"context_line":"    if len(az_string) \u003e 255:"},{"line_number":34,"context_line":"        msg \u003d _(\"too many availability_zone_hints specified\")"},{"line_number":35,"context_line":"        raise exceptions.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da20952f_dc018f39","line":32,"in_reply_to":"da20952f_c74b0186","updated":"2015-08-31 06:23:12.000000000","message":"Done","commit_id":"39e3c4cabb7ebbf17a7480a49cb652c0fea5653c"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"f58d4cb61805a1cac8d54a77baf7fec62a989aa1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        if \u0027,\u0027 in az:"},{"line_number":30,"context_line":"            msg \u003d _(\"availability_zone_hints must not include comma\")"},{"line_number":31,"context_line":"            raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":32,"context_line":"    az_string \u003d \u0027,\u0027.join(data)"},{"line_number":33,"context_line":"    if len(az_string) \u003e 255:"},{"line_number":34,"context_line":"        msg \u003d _(\"too many availability_zone_hints specified\")"},{"line_number":35,"context_line":"        raise exceptions.InvalidInput(error_message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da20952f_c74b0186","line":32,"in_reply_to":"da20952f_ddd3fb02","updated":"2015-08-30 22:11:38.000000000","message":"Isn\u0027t it necessary to check each az is string any way ?","commit_id":"39e3c4cabb7ebbf17a7480a49cb652c0fea5653c"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"b66fa558e048712896684e53d4cc1ea303f1102b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":67,"context_line":"    AVAILABILITY_ZONES: {"},{"line_number":68,"context_line":"        \u0027name\u0027: {\u0027is_visible\u0027: True},"},{"line_number":69,"context_line":"        \u0027state\u0027: {\u0027is_visible\u0027: True}"},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":"}"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_26950d32","line":69,"updated":"2015-09-05 06:50:11.000000000","message":"add type of az?","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"81c3f5bd9ef5e5d90f6b781fd1471c8840668ea3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":67,"context_line":"    AVAILABILITY_ZONES: {"},{"line_number":68,"context_line":"        \u0027name\u0027: {\u0027is_visible\u0027: True},"},{"line_number":69,"context_line":"        \u0027state\u0027: {\u0027is_visible\u0027: True}"},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":"}"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_a8d55043","line":69,"in_reply_to":"da20952f_26950d32","updated":"2015-09-07 06:39:27.000000000","message":"What is type? I referred nova and cinder AZ.","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"57cb3ce94c63fbb07300d93d66c95f085c9bed0c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":67,"context_line":"    AVAILABILITY_ZONES: {"},{"line_number":68,"context_line":"        \u0027name\u0027: {\u0027is_visible\u0027: True},"},{"line_number":69,"context_line":"        \u0027state\u0027: {\u0027is_visible\u0027: True}"},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":"}"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_1c5cbe49","line":69,"in_reply_to":"da20952f_4b0a6e7a","updated":"2015-09-07 09:00:13.000000000","message":"Please take a look at my comment in agents_db.py","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"498fa5e4dbed1dd2f61e4cb299d383e267e6fb37","unresolved":false,"context_lines":[{"line_number":66,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":67,"context_line":"    AVAILABILITY_ZONES: {"},{"line_number":68,"context_line":"        \u0027name\u0027: {\u0027is_visible\u0027: True},"},{"line_number":69,"context_line":"        \u0027state\u0027: {\u0027is_visible\u0027: True}"},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":"}"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_4b0a6e7a","line":69,"in_reply_to":"da20952f_a8d55043","updated":"2015-09-07 07:15:59.000000000","message":"our type can be from l3 agent, dhcp agent, and even lbaas agent later. so it is better list the zone\u0027s agent type.","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"b66fa558e048712896684e53d4cc1ea303f1102b","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":74,"context_line":"    \u0027networks\u0027: {"},{"line_number":75,"context_line":"        AVAILABILITY_ZONES: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":76,"context_line":"                             \u0027is_visible\u0027: True},"},{"line_number":77,"context_line":"        AVAILABILITY_ZONE_HINTS: {"},{"line_number":78,"context_line":"                \u0027allow_post\u0027: True, \u0027allow_put\u0027: False, \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_0b057278","line":75,"updated":"2015-09-05 06:50:11.000000000","message":"why not allow \u0027put\u0027?","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"81c3f5bd9ef5e5d90f6b781fd1471c8840668ea3","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":74,"context_line":"    \u0027networks\u0027: {"},{"line_number":75,"context_line":"        AVAILABILITY_ZONES: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":76,"context_line":"                             \u0027is_visible\u0027: True},"},{"line_number":77,"context_line":"        AVAILABILITY_ZONE_HINTS: {"},{"line_number":78,"context_line":"                \u0027allow_post\u0027: True, \u0027allow_put\u0027: False, \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_480d94e6","line":75,"in_reply_to":"da20952f_0b057278","updated":"2015-09-07 06:39:27.000000000","message":"Because availability_zones is specified by neutron, on the other hand availability_zone_hints is specified by users.","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"498fa5e4dbed1dd2f61e4cb299d383e267e6fb37","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        AVAILABILITY_ZONES: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":76,"context_line":"                             \u0027is_visible\u0027: True},"},{"line_number":77,"context_line":"        AVAILABILITY_ZONE_HINTS: {"},{"line_number":78,"context_line":"                \u0027allow_post\u0027: True, \u0027allow_put\u0027: False, \u0027is_visible\u0027: True,"},{"line_number":79,"context_line":"                \u0027validate\u0027: {\u0027type:validate_availability_zone_hints\u0027: None},"},{"line_number":80,"context_line":"                \u0027default\u0027: []}},"},{"line_number":81,"context_line":"    \u0027routers\u0027: {"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_cb1e7eba","line":78,"updated":"2015-09-07 07:15:59.000000000","message":"sorry, I mean AVAILABILITY_ZONE_HINTS should support put","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"57cb3ce94c63fbb07300d93d66c95f085c9bed0c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        AVAILABILITY_ZONES: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":76,"context_line":"                             \u0027is_visible\u0027: True},"},{"line_number":77,"context_line":"        AVAILABILITY_ZONE_HINTS: {"},{"line_number":78,"context_line":"                \u0027allow_post\u0027: True, \u0027allow_put\u0027: False, \u0027is_visible\u0027: True,"},{"line_number":79,"context_line":"                \u0027validate\u0027: {\u0027type:validate_availability_zone_hints\u0027: None},"},{"line_number":80,"context_line":"                \u0027default\u0027: []}},"},{"line_number":81,"context_line":"    \u0027routers\u0027: {"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_bc9112f3","line":78,"in_reply_to":"da20952f_cb1e7eba","updated":"2015-09-07 09:00:13.000000000","message":"No. If PUT is supported, it allow user to move their resource between hosts. Currently, admin can do only(i.e l3-agent-router-add, l3-agent-router-remove).","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"b66fa558e048712896684e53d4cc1ea303f1102b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                \u0027validate\u0027: {\u0027type:validate_availability_zone_hints\u0027: None},"},{"line_number":80,"context_line":"                \u0027default\u0027: []}},"},{"line_number":81,"context_line":"    \u0027routers\u0027: {"},{"line_number":82,"context_line":"        AVAILABILITY_ZONES: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":83,"context_line":"                             \u0027is_visible\u0027: True},"},{"line_number":84,"context_line":"        AVAILABILITY_ZONE_HINTS: {"},{"line_number":85,"context_line":"                \u0027allow_post\u0027: True, \u0027allow_put\u0027: False, \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_2b0ab68a","line":82,"updated":"2015-09-05 06:50:11.000000000","message":"the same question","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"81c3f5bd9ef5e5d90f6b781fd1471c8840668ea3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                \u0027validate\u0027: {\u0027type:validate_availability_zone_hints\u0027: None},"},{"line_number":80,"context_line":"                \u0027default\u0027: []}},"},{"line_number":81,"context_line":"    \u0027routers\u0027: {"},{"line_number":82,"context_line":"        AVAILABILITY_ZONES: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":83,"context_line":"                             \u0027is_visible\u0027: True},"},{"line_number":84,"context_line":"        AVAILABILITY_ZONE_HINTS: {"},{"line_number":85,"context_line":"                \u0027allow_post\u0027: True, \u0027allow_put\u0027: False, \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":22,"id":"da20952f_68109800","line":82,"in_reply_to":"da20952f_2b0ab68a","updated":"2015-09-07 06:39:27.000000000","message":"ditto","commit_id":"c0dab9497deebbd4ebcb5055a73278a7a6e9440e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"927a74c5658e54c2950f1693c8d30d566e652c16","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def convert_az_string_to_list(az_string):"},{"line_number":31,"context_line":"    # some unit tests pass az_string as a mock object and these tests"},{"line_number":32,"context_line":"    # hard to fix."},{"line_number":33,"context_line":"    return (jsonutils.loads(az_string)"},{"line_number":34,"context_line":"            if az_string and isinstance(az_string, six.string_types)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_ad11b55f","line":31,"updated":"2015-09-12 21:55:34.000000000","message":"this comment is too cryptic to understand the consequences, can you elaborate what this  means exactly? Besides, mentioning unit tests here is simply evil","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b69608bdcd1db2de0f5f842f977e342eb5185abf","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def convert_az_string_to_list(az_string):"},{"line_number":31,"context_line":"    # some unit tests pass az_string as a mock object and these tests"},{"line_number":32,"context_line":"    # hard to fix."},{"line_number":33,"context_line":"    return (jsonutils.loads(az_string)"},{"line_number":34,"context_line":"            if az_string and isinstance(az_string, six.string_types)"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_f0aaef18","line":31,"in_reply_to":"ba15a1d1_ad11b55f","updated":"2015-09-14 23:48:37.000000000","message":"Done","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"938445c1887ff730c513a1571f636cf944e6ed26","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def convert_az_string_to_list(az_string):"},{"line_number":31,"context_line":"    # some unit tests pass az_string as a mock object and these tests"},{"line_number":32,"context_line":"    # hard to fix."},{"line_number":33,"context_line":"    return (jsonutils.loads(az_string)"},{"line_number":34,"context_line":"            if az_string and isinstance(az_string, six.string_types)"},{"line_number":35,"context_line":"            else [])"}],"source_content_type":"text/x-python","patch_set":25,"id":"da20952f_a6314fa4","line":32,"updated":"2015-09-11 05:38:45.000000000","message":"is this too difficult to fix?","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b69608bdcd1db2de0f5f842f977e342eb5185abf","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def convert_az_string_to_list(az_string):"},{"line_number":31,"context_line":"    # some unit tests pass az_string as a mock object and these tests"},{"line_number":32,"context_line":"    # hard to fix."},{"line_number":33,"context_line":"    return (jsonutils.loads(az_string)"},{"line_number":34,"context_line":"            if az_string and isinstance(az_string, six.string_types)"},{"line_number":35,"context_line":"            else [])"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_10a8c31e","line":32,"in_reply_to":"da20952f_a6314fa4","updated":"2015-09-14 23:48:37.000000000","message":"Done","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ab4867d1b96f618e8841cd57d29ab40b7208a12d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    message \u003d _(\"AvailabilityZone %(availability_zone)s could not be found\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class Availability_zone(extensions.ExtensionDescriptor):"},{"line_number":92,"context_line":"    \"\"\"Availability zone extension.\"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba15a1d1_05a50303","line":91,"updated":"2015-09-14 11:31:28.000000000","message":"It is better to add the following:\n\n    def get_required_extensions(self):\n        return [\"agent\"]\n\nto declare this extension depends on the agent extension.\n\nIf this depends on scheduler extensions too, you can add them to the aboce list, but you need to do so carefully because L2/L3 features are plugabble.","commit_id":"5eae8b6035f4d1cf9754c330cfe20fa49bb27d70"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"06b6c7b094a98881518af40dc98359038bed9cdb","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    message \u003d _(\"AvailabilityZone %(availability_zone)s could not be found\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class Availability_zone(extensions.ExtensionDescriptor):"},{"line_number":92,"context_line":"    \"\"\"Availability zone extension.\"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba15a1d1_9baad26f","line":91,"in_reply_to":"ba15a1d1_05a50303","updated":"2015-09-14 12:27:58.000000000","message":"Thank you for your suggestion. I will update.","commit_id":"5eae8b6035f4d1cf9754c330cfe20fa49bb27d70"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6917b2e95f6fdbd9c612fedd47de60a1b9263723","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    message \u003d _(\"AvailabilityZone %(availability_zone)s could not be found\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class Availability_zone(extensions.ExtensionDescriptor):"},{"line_number":92,"context_line":"    \"\"\"Availability zone extension.\"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":27,"id":"ba15a1d1_f6aa0385","line":91,"in_reply_to":"ba15a1d1_9baad26f","updated":"2015-09-14 12:50:01.000000000","message":"\u003e you need to do so carefully because L2/L3 features are plugabble.\n\nI\u0027m OK. I will devide AZs into L2/L3 by the feature is achieved.","commit_id":"5eae8b6035f4d1cf9754c330cfe20fa49bb27d70"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0d820b20754596fc3028d11f1e1648edb9346273","unresolved":false,"context_lines":[{"line_number":63,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":64,"context_line":"    AVAILABILITY_ZONES: {"},{"line_number":65,"context_line":"        \u0027name\u0027: {\u0027is_visible\u0027: True},"},{"line_number":66,"context_line":"        \u0027state\u0027: {\u0027is_visible\u0027: True}"},{"line_number":67,"context_line":"    }"},{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ba15a1d1_921293b3","line":66,"updated":"2015-09-15 04:31:37.000000000","message":"it should be a trivial effort to add az_type to help user.","commit_id":"94e83dc6951d8fa4a04aa1d753217af16404e296"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0786a15d601ce262fd14fda6c91724f50b9a5860","unresolved":false,"context_lines":[{"line_number":63,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":64,"context_line":"    AVAILABILITY_ZONES: {"},{"line_number":65,"context_line":"        \u0027name\u0027: {\u0027is_visible\u0027: True},"},{"line_number":66,"context_line":"        \u0027state\u0027: {\u0027is_visible\u0027: True}"},{"line_number":67,"context_line":"    }"},{"line_number":68,"context_line":"}"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ba15a1d1_39790430","line":66,"in_reply_to":"ba15a1d1_921293b3","updated":"2015-09-15 20:50:17.000000000","message":"+1","commit_id":"94e83dc6951d8fa4a04aa1d753217af16404e296"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f7dacce9b9cb5ecc6624e1068c80f910217cf31d","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class AvailabilityZonePluginBase(object):"},{"line_number":84,"context_line":"    \"\"\"REST API to operate the Availability Zone."},{"line_number":85,"context_line":"    \"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @abc.abstractmethod"},{"line_number":88,"context_line":"    def get_availability_zones(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":32,"id":"ba15a1d1_9f722910","line":85,"updated":"2015-09-17 10:23:27.000000000","message":"oneline docstring should be \"\"\"xxxx\"\".","commit_id":"fab993042937002f0c5469f91583dc5dfef72588"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0808535510d9c4a66ab3e507a484f9a2ae8d4e73","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class AvailabilityZonePluginBase(object):"},{"line_number":84,"context_line":"    \"\"\"REST API to operate the Availability Zone."},{"line_number":85,"context_line":"    \"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @abc.abstractmethod"},{"line_number":88,"context_line":"    def get_availability_zones(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":32,"id":"ba15a1d1_eb32875d","line":85,"in_reply_to":"ba15a1d1_9f722910","updated":"2015-09-17 11:39:38.000000000","message":"Done","commit_id":"fab993042937002f0c5469f91583dc5dfef72588"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6cbbd839fb7711f13bc3fe6bae9843cfff3b8cbe","unresolved":false,"context_lines":[{"line_number":26,"context_line":"AVAILABILITY_ZONES \u003d \u0027availability_zones\u0027"},{"line_number":27,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":28,"context_line":"    AVAILABILITY_ZONES: {"},{"line_number":29,"context_line":"        \u0027name\u0027: {\u0027is_visible\u0027: True},"},{"line_number":30,"context_line":"        \u0027resource\u0027: {\u0027is_visible\u0027: True},"},{"line_number":31,"context_line":"        \u0027state\u0027: {\u0027is_visible\u0027: True}"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_09fd64b3","line":29,"updated":"2015-09-17 23:42:40.000000000","message":"would be nice to define types for these attributes, so that it is easier to understand, by reading this code, what resource and state are for.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"82a863b95cd16114bc739949f6a40289d348a5bc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"AVAILABILITY_ZONES \u003d \u0027availability_zones\u0027"},{"line_number":27,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":28,"context_line":"    AVAILABILITY_ZONES: {"},{"line_number":29,"context_line":"        \u0027name\u0027: {\u0027is_visible\u0027: True},"},{"line_number":30,"context_line":"        \u0027resource\u0027: {\u0027is_visible\u0027: True},"},{"line_number":31,"context_line":"        \u0027state\u0027: {\u0027is_visible\u0027: True}"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_5d11d202","line":29,"in_reply_to":"ba15a1d1_09fd64b3","updated":"2015-09-18 01:55:10.000000000","message":"However, this value is readonly. I can add comment here if it helps reviewer.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"bb5e2ed3553330333d9ea3bc743a503de2ce0a92","unresolved":false,"context_lines":[{"line_number":26,"context_line":"AVAILABILITY_ZONES \u003d \u0027availability_zones\u0027"},{"line_number":27,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":28,"context_line":"    AVAILABILITY_ZONES: {"},{"line_number":29,"context_line":"        \u0027name\u0027: {\u0027is_visible\u0027: True},"},{"line_number":30,"context_line":"        \u0027resource\u0027: {\u0027is_visible\u0027: True},"},{"line_number":31,"context_line":"        \u0027state\u0027: {\u0027is_visible\u0027: True}"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_726b9c85","line":29,"in_reply_to":"ba15a1d1_5d11d202","updated":"2015-09-18 06:29:01.000000000","message":"+1","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"097b86a5d1fef948936744ea04a0f5959e2d37e2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"AVAILABILITY_ZONES \u003d \u0027availability_zones\u0027"},{"line_number":27,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":28,"context_line":"    AVAILABILITY_ZONES: {"},{"line_number":29,"context_line":"        \u0027name\u0027: {\u0027is_visible\u0027: True},"},{"line_number":30,"context_line":"        \u0027resource\u0027: {\u0027is_visible\u0027: True},"},{"line_number":31,"context_line":"        \u0027state\u0027: {\u0027is_visible\u0027: True}"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_1214a04a","line":29,"in_reply_to":"ba15a1d1_726b9c85","updated":"2015-09-18 07:03:23.000000000","message":"I will do.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6cbbd839fb7711f13bc3fe6bae9843cfff3b8cbe","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class AvailabilityZoneNotFound(exceptions.NotFound):"},{"line_number":37,"context_line":"    message \u003d _(\"AvailabilityZone %(availability_zone)s could not be found\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class Availability_zone(extensions.ExtensionDescriptor):"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_0976c46f","line":37,"updated":"2015-09-17 23:42:40.000000000","message":"period at the end?","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"82a863b95cd16114bc739949f6a40289d348a5bc","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class AvailabilityZoneNotFound(exceptions.NotFound):"},{"line_number":37,"context_line":"    message \u003d _(\"AvailabilityZone %(availability_zone)s could not be found\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class Availability_zone(extensions.ExtensionDescriptor):"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_1df83ac2","line":37,"in_reply_to":"ba15a1d1_0976c46f","updated":"2015-09-18 01:55:10.000000000","message":"I will do.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6cbbd839fb7711f13bc3fe6bae9843cfff3b8cbe","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        pass"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @abc.abstractmethod"},{"line_number":93,"context_line":"    def validate_availability_zones(self, context, resource_type,"},{"line_number":94,"context_line":"                                    availability_zones):"},{"line_number":95,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_890894db","line":93,"updated":"2015-09-17 23:42:40.000000000","message":"why is this part of the plugin API?","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"82a863b95cd16114bc739949f6a40289d348a5bc","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        pass"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @abc.abstractmethod"},{"line_number":93,"context_line":"    def validate_availability_zones(self, context, resource_type,"},{"line_number":94,"context_line":"                                    availability_zones):"},{"line_number":95,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_9dbc4abc","line":93,"in_reply_to":"ba15a1d1_890894db","updated":"2015-09-18 01:55:10.000000000","message":"Because this is what plugin should define a method called as API extend","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"8df64d2e503c868f865224c7d41a55e36508269c","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def get_name(cls):"},{"line_number":56,"context_line":"        return \"Availability Zone\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def get_alias(cls):"}],"source_content_type":"text/x-python","patch_set":38,"id":"9a1a9d01_e14dfa3e","line":56,"updated":"2015-09-29 00:24:02.000000000","message":"Availability Zone Base is better","commit_id":"5b9df9e3542aac07158aacc8c15ee7582d4544be"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"57e96291e57fac9e724c75e17a76666dc8c96b4c","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def get_name(cls):"},{"line_number":56,"context_line":"        return \"Availability Zone\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def get_alias(cls):"}],"source_content_type":"text/x-python","patch_set":38,"id":"9a1a9d01_18dabd4c","line":56,"in_reply_to":"9a1a9d01_e14dfa3e","updated":"2015-09-29 16:02:56.000000000","message":"I understand your suggestion but it may confuse users because this patch doesn\u0027t use \"Base\" in other places. It\u0027s added to title for reviewer only.","commit_id":"5b9df9e3542aac07158aacc8c15ee7582d4544be"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"8df64d2e503c868f865224c7d41a55e36508269c","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def get_alias(cls):"},{"line_number":60,"context_line":"        return \"availability_zone\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @classmethod"},{"line_number":63,"context_line":"    def get_description(cls):"}],"source_content_type":"text/x-python","patch_set":38,"id":"9a1a9d01_014b4e2b","line":60,"updated":"2015-09-29 00:24:02.000000000","message":"availability_zone_base ?","commit_id":"5b9df9e3542aac07158aacc8c15ee7582d4544be"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"57e96291e57fac9e724c75e17a76666dc8c96b4c","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def get_alias(cls):"},{"line_number":60,"context_line":"        return \"availability_zone\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @classmethod"},{"line_number":63,"context_line":"    def get_description(cls):"}],"source_content_type":"text/x-python","patch_set":38,"id":"9a1a9d01_98948d43","line":60,"in_reply_to":"9a1a9d01_014b4e2b","updated":"2015-09-29 16:02:56.000000000","message":"No. \"availability_zone\" is right for alias.","commit_id":"5b9df9e3542aac07158aacc8c15ee7582d4544be"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"927a74c5658e54c2950f1693c8d30d566e652c16","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                    \"multi-provider\", \"allowed-address-pairs\","},{"line_number":119,"context_line":"                                    \"extra_dhcp_opt\", \"subnet_allocation\","},{"line_number":120,"context_line":"                                    \"net-mtu\", \"vlan-transparent\","},{"line_number":121,"context_line":"                                    \"dns-integration\", \"availability_zone\"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @property"},{"line_number":124,"context_line":"    def supported_extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_1f048413","line":121,"updated":"2015-09-12 21:55:34.000000000","message":"you\u0027re adding availability zone support to the agent classes etc, but you only expose the extension in the ML2 plugin. What about other plugins that do use the agent extension? They will see the side effects of your change without exposing the actual extension...and this isn\u0027t right.\n\nYou should try to add this support to your agent in a backward compatible way so that existing plugins that do not explicit pull in the availability_zone support are not affected.","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b69608bdcd1db2de0f5f842f977e342eb5185abf","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                    \"multi-provider\", \"allowed-address-pairs\","},{"line_number":119,"context_line":"                                    \"extra_dhcp_opt\", \"subnet_allocation\","},{"line_number":120,"context_line":"                                    \"net-mtu\", \"vlan-transparent\","},{"line_number":121,"context_line":"                                    \"dns-integration\", \"availability_zone\"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @property"},{"line_number":124,"context_line":"    def supported_extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_83f80fe7","line":121,"in_reply_to":"ba15a1d1_1f048413","updated":"2015-09-14 23:48:37.000000000","message":"I updated so that availability zone isn\u0027t invasive any extension and any plugin. Current code completely achieves backward compatibility.","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0786a15d601ce262fd14fda6c91724f50b9a5860","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                    \"multi-provider\", \"allowed-address-pairs\","},{"line_number":119,"context_line":"                                    \"extra_dhcp_opt\", \"subnet_allocation\","},{"line_number":120,"context_line":"                                    \"net-mtu\", \"vlan-transparent\","},{"line_number":121,"context_line":"                                    \"dns-integration\", \"availability_zone\"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @property"},{"line_number":124,"context_line":"    def supported_extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba15a1d1_1941a0a9","line":121,"updated":"2015-09-15 20:50:17.000000000","message":"I am thinking that we should break down these into a patch that takes care of AZ support for Networks and AZ support for routers, and we should have network_availability_zone addressed here for ML2 and router_availability_zone addressed by the L3 service plugin. You\u0027re conflating two things into one and the problem I can see here is that if ML2 works with a different L3 service plugin things do not work as they should.\n\nsee:\n\nhttps://github.com/openstack/neutron/blob/master/neutron/services/l3_router/l3_router_plugin.py#L54","commit_id":"94e83dc6951d8fa4a04aa1d753217af16404e296"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"41d75b7a0024c82ec531a5830de109b3ad24df56","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                    \"multi-provider\", \"allowed-address-pairs\","},{"line_number":119,"context_line":"                                    \"extra_dhcp_opt\", \"subnet_allocation\","},{"line_number":120,"context_line":"                                    \"net-mtu\", \"vlan-transparent\","},{"line_number":121,"context_line":"                                    \"dns-integration\", \"availability_zone\"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @property"},{"line_number":124,"context_line":"    def supported_extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba15a1d1_9127c0b5","line":121,"in_reply_to":"ba15a1d1_1941a0a9","updated":"2015-09-15 23:46:21.000000000","message":"I can understand your point but first availability zone is reference model as written AZ spec: ML2plugin, L3agent, DHCPagent. I have a plan this implementation in Liberty and I will update other things in Mitaka. I also added get_required_extensions according with amotoki so we can avoid using availability zone with unsupported plugin.","commit_id":"94e83dc6951d8fa4a04aa1d753217af16404e296"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f2098a62a152bcf1cba245619a37274feebea142","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                    \"multi-provider\", \"allowed-address-pairs\","},{"line_number":119,"context_line":"                                    \"extra_dhcp_opt\", \"subnet_allocation\","},{"line_number":120,"context_line":"                                    \"net-mtu\", \"vlan-transparent\","},{"line_number":121,"context_line":"                                    \"dns-integration\", \"availability_zone\"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @property"},{"line_number":124,"context_line":"    def supported_extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba15a1d1_4345da6d","line":121,"in_reply_to":"ba15a1d1_5436f652","updated":"2015-09-16 05:54:47.000000000","message":"I have similar comment at https://review.openstack.org/#/c/183369/22/neutron/db/availability_zone_db.py","commit_id":"94e83dc6951d8fa4a04aa1d753217af16404e296"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9a89a06015bcc608c6a61a6023a70a0c868c0ea4","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                    \"multi-provider\", \"allowed-address-pairs\","},{"line_number":119,"context_line":"                                    \"extra_dhcp_opt\", \"subnet_allocation\","},{"line_number":120,"context_line":"                                    \"net-mtu\", \"vlan-transparent\","},{"line_number":121,"context_line":"                                    \"dns-integration\", \"availability_zone\"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @property"},{"line_number":124,"context_line":"    def supported_extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba15a1d1_5436f652","line":121,"in_reply_to":"ba15a1d1_9127c0b5","updated":"2015-09-16 00:47:09.000000000","message":"availability_zone cannot be an extension of ML2 plugin only, because it captures both L2 and L3 constructs and ML2 is L2 only. You got to split this up, for the reasons above: we must have two separate extensions: one for network AZ\u0027s and one for router AZ\u0027s. Routers is L3\u0027s responsibility, networks is ML2\u0027s.","commit_id":"94e83dc6951d8fa4a04aa1d753217af16404e296"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c6058f7a496bba64276999ce74724e3c5e82793f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                    \"multi-provider\", \"allowed-address-pairs\","},{"line_number":119,"context_line":"                                    \"extra_dhcp_opt\", \"subnet_allocation\","},{"line_number":120,"context_line":"                                    \"net-mtu\", \"vlan-transparent\","},{"line_number":121,"context_line":"                                    \"dns-integration\", \"availability_zone\","},{"line_number":122,"context_line":"                                    \"network_availability_zone\"]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba15a1d1_186f4c93","line":121,"updated":"2015-09-16 07:06:38.000000000","message":"not sure if this is still WIP, but I this should not be here, it shoudl be on the l3 service plugin.","commit_id":"579e018bd3ef3cb87793e299e8ebf137c642c476"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"059482ec989090fa3ce43ec05115cdd92297cb2b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                    \"multi-provider\", \"allowed-address-pairs\","},{"line_number":119,"context_line":"                                    \"extra_dhcp_opt\", \"subnet_allocation\","},{"line_number":120,"context_line":"                                    \"net-mtu\", \"vlan-transparent\","},{"line_number":121,"context_line":"                                    \"dns-integration\", \"availability_zone\","},{"line_number":122,"context_line":"                                    \"network_availability_zone\"]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":30,"id":"ba15a1d1_9864bc49","line":121,"in_reply_to":"ba15a1d1_186f4c93","updated":"2015-09-16 08:07:46.000000000","message":"he splited the extension into three.\naz, network-az, router-az.","commit_id":"579e018bd3ef3cb87793e299e8ebf137c642c476"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6cbbd839fb7711f13bc3fe6bae9843cfff3b8cbe","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                    \"multi-provider\", \"allowed-address-pairs\","},{"line_number":119,"context_line":"                                    \"extra_dhcp_opt\", \"subnet_allocation\","},{"line_number":120,"context_line":"                                    \"net-mtu\", \"vlan-transparent\","},{"line_number":121,"context_line":"                                    \"dns-integration\", \"availability_zone\"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @property"},{"line_number":124,"context_line":"    def supported_extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_098004f4","line":121,"updated":"2015-09-17 23:42:40.000000000","message":"ok, I am having a hard time explaining why adding this extension is not ideal. \n\nAvailability zone is a composite extension: you are adding agent support both for networks and routers. ML2 is only in charge of \u0027networks\u0027, and can work with any L3 service plugin (agent or agentless). So by not making a distinction here a client would believe that both may be available when they aren\u0027t.\n\nThe same way ML2 only exposes \u0027dhcp_agent_scheduler\u0027 so it should for network_availability_zone.\n\nSo in a nutshell: I believe after this blueprint is complete we should see two extensions added: dhcp_availability_zone and l3_availability_zone. One exposed by the ML2 plugin, the other but the L3 plugin.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"cac46eeebf19beffc2df3b798c959857ee96a711","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                    \"multi-provider\", \"allowed-address-pairs\","},{"line_number":119,"context_line":"                                    \"extra_dhcp_opt\", \"subnet_allocation\","},{"line_number":120,"context_line":"                                    \"net-mtu\", \"vlan-transparent\","},{"line_number":121,"context_line":"                                    \"dns-integration\", \"availability_zone\"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @property"},{"line_number":124,"context_line":"    def supported_extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_ac0a4688","line":121,"in_reply_to":"ba15a1d1_098004f4","updated":"2015-09-18 00:25:04.000000000","message":"Armando,\n\nIt is same structure of \"agent\"(availability_zone) extension and \"dhcp_agent_scheduler\"(network_availability_zone), \"l3_agent_scheduler\"(router_availability_zone).\n\n\"agent\"(availability_zone) extension exposes resource independent agent (availability_zone) API. \"agent\"(availability_zone) is related with both l2 and l3 but defined l2 only now, because an extension can not be defined in two plugins.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"82a863b95cd16114bc739949f6a40289d348a5bc","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                    \"multi-provider\", \"allowed-address-pairs\","},{"line_number":119,"context_line":"                                    \"extra_dhcp_opt\", \"subnet_allocation\","},{"line_number":120,"context_line":"                                    \"net-mtu\", \"vlan-transparent\","},{"line_number":121,"context_line":"                                    \"dns-integration\", \"availability_zone\"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @property"},{"line_number":124,"context_line":"    def supported_extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_9de3ead8","line":121,"in_reply_to":"ba15a1d1_8cf1826d","updated":"2015-09-18 01:55:10.000000000","message":"Thanks, Oda. I agree with Oda.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c72da06004109c3b9086dc53a085b10de5bb087c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                    \"multi-provider\", \"allowed-address-pairs\","},{"line_number":119,"context_line":"                                    \"extra_dhcp_opt\", \"subnet_allocation\","},{"line_number":120,"context_line":"                                    \"net-mtu\", \"vlan-transparent\","},{"line_number":121,"context_line":"                                    \"dns-integration\", \"availability_zone\"]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @property"},{"line_number":124,"context_line":"    def supported_extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba15a1d1_8cf1826d","line":121,"in_reply_to":"ba15a1d1_ac0a4688","updated":"2015-09-18 00:36:12.000000000","message":"Yes, I am with you. I only now noticed that the extension was split and that the two \u0027tokens\u0027 have been added in the right places in the follow-on patches, so that\u0027s good.\n\nI personally wonder what\u0027s the use of availability_zone alone though. Granted it tells the user that the AZ attribute has been added, but what good comes out of it? It won\u0027t work alone. In a nutshell I feel like it\u0027s redundant, but I don\u0027t mind if you keep it.","commit_id":"8343685550ff7114c9e2af52fb87914ccf5f5ce6"}],"neutron/scheduler/dhcp_agent_scheduler.py":[{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"55ae2cb11054f0babf9e42765dcd2c33486ea687","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        \"\"\"Return the agents that can host the network.\"\"\""},{"line_number":179,"context_line":"        agents_dict \u003d self._get_network_hostable_dhcp_agents("},{"line_number":180,"context_line":"                                    plugin, context, network)"},{"line_number":181,"context_line":"        if not agents_dict[\u0027hostable_agents\u0027] or agents_dict[\u0027n_agents\u0027] \u003c\u003d 0:"},{"line_number":182,"context_line":"            return {\u0027n_agents\u0027: 0, \u0027hostable_agents\u0027: []}"},{"line_number":183,"context_line":"        return agents_dict"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_c0fcc274","line":181,"updated":"2015-05-25 20:12:28.000000000","message":"Returned dict needs a hosted_networks key, or we get an exception on L111.","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"12cb27b972c4fe8443a32dbad8c32758c926e571","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        \"\"\"Return the agents that can host the network.\"\"\""},{"line_number":179,"context_line":"        agents_dict \u003d self._get_network_hostable_dhcp_agents("},{"line_number":180,"context_line":"                                    plugin, context, network)"},{"line_number":181,"context_line":"        if not agents_dict[\u0027hostable_agents\u0027] or agents_dict[\u0027n_agents\u0027] \u003c\u003d 0:"},{"line_number":182,"context_line":"            return {\u0027n_agents\u0027: 0, \u0027hostable_agents\u0027: []}"},{"line_number":183,"context_line":"        return agents_dict"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_134b3a2d","line":181,"in_reply_to":"7a016987_c0fcc274","updated":"2015-05-26 17:21:51.000000000","message":"sorry - I meant \u0027hosted_agents\u0027 key.","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"55ae2cb11054f0babf9e42765dcd2c33486ea687","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                return"},{"line_number":199,"context_line":"        return network_hosted_agents"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def _get_active_agents(self, plugin, context, network):"},{"line_number":202,"context_line":"        \"\"\"Return a list of active dhcp agents.\"\"\""},{"line_number":203,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":204,"context_line":"            filters \u003d {\u0027agent_type\u0027: [constants.AGENT_TYPE_DHCP],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_60e3ce06","line":201,"updated":"2015-05-25 20:12:28.000000000","message":"Why not just pass availability_zones here instead of network?","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"55ae2cb11054f0babf9e42765dcd2c33486ea687","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def _get_network_hostable_dhcp_agents(self, plugin, context, network):"},{"line_number":216,"context_line":"        \"\"\"Return number of agents which will actually host the given network"},{"line_number":217,"context_line":"           and a list of dhcp agents which can host the given network"},{"line_number":218,"context_line":"        \"\"\""},{"line_number":219,"context_line":"        hosted_agents \u003d self._get_dhcp_agents_hosting_network(plugin,"},{"line_number":220,"context_line":"                                                              context, network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_00877a13","line":217,"updated":"2015-05-25 20:12:28.000000000","message":"Comment needs to be updated. But now the method name is not so accurate.\n\nMaybe instead of sending back hosted_agents from here, could we call\nself._get_dhcp_agents_hosting_network() from filter_agents() and add the hosted_agents key there?","commit_id":"927242067fe5a0d6333969a72f255df3f57736fb"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"acff855a9ce74325ed8a9557e54fd91758364a70","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        for agent in hostable_agents:"},{"line_number":122,"context_line":"            az_agent \u003d agent[\u0027availability_zone\u0027]"},{"line_number":123,"context_line":"            if az_agent not in num_az_agents:"},{"line_number":124,"context_line":"                num_az_agents[az_agent] \u003d 0"},{"line_number":125,"context_line":"        for agent in hosted_agents:"},{"line_number":126,"context_line":"            az_agent \u003d agent[\u0027availability_zone\u0027]"},{"line_number":127,"context_line":"            if az_agent in num_az_agents:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_5b034610","line":124,"updated":"2015-07-08 22:59:45.000000000","message":"why are we looping through hostable_agents twice?\nit makes more sense to me to have L123 and 124 be in the above for block?","commit_id":"67098a259d0aad4d20b9dd28e39930110a7af36a"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"e2c45870b48f166730f91dc91b440861ef20d10c","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        for agent in hostable_agents:"},{"line_number":122,"context_line":"            az_agent \u003d agent[\u0027availability_zone\u0027]"},{"line_number":123,"context_line":"            if az_agent not in num_az_agents:"},{"line_number":124,"context_line":"                num_az_agents[az_agent] \u003d 0"},{"line_number":125,"context_line":"        for agent in hosted_agents:"},{"line_number":126,"context_line":"            az_agent \u003d agent[\u0027availability_zone\u0027]"},{"line_number":127,"context_line":"            if az_agent in num_az_agents:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_ef560a29","line":124,"in_reply_to":"ba3cc151_5b034610","updated":"2015-07-09 04:48:04.000000000","message":"+1","commit_id":"67098a259d0aad4d20b9dd28e39930110a7af36a"}],"neutron/tests/common/helpers.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"657dcc4dfadebf005985ff5f06a9f315df4fc99f","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _get_l3_agent_dict(host, agent_mode, internal_only\u003dTrue,"},{"line_number":50,"context_line":"                       ext_net_id\u003d\u0027\u0027, ext_bridge\u003d\u0027\u0027, router_id\u003dNone,"},{"line_number":51,"context_line":"                       az\u003d\u0027nova\u0027):"},{"line_number":52,"context_line":"    return {"},{"line_number":53,"context_line":"        \u0027agent_type\u0027: constants.AGENT_TYPE_L3,"},{"line_number":54,"context_line":"        \u0027binary\u0027: \u0027neutron-l3-agent\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_dbc76a10","line":51,"updated":"2015-08-12 07:34:06.000000000","message":"you can set constant DEFAULT_AZ \u003d \u0027nova\u0027 and use in scope of this module.","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e7f2844f03a5fa88c2d938f0345f8eb9916a335","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _get_l3_agent_dict(host, agent_mode, internal_only\u003dTrue,"},{"line_number":50,"context_line":"                       ext_net_id\u003d\u0027\u0027, ext_bridge\u003d\u0027\u0027, router_id\u003dNone,"},{"line_number":51,"context_line":"                       az\u003d\u0027nova\u0027):"},{"line_number":52,"context_line":"    return {"},{"line_number":53,"context_line":"        \u0027agent_type\u0027: constants.AGENT_TYPE_L3,"},{"line_number":54,"context_line":"        \u0027binary\u0027: \u0027neutron-l3-agent\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_368aea1b","line":51,"in_reply_to":"1a4dcd0f_dbc76a10","updated":"2015-08-13 07:30:23.000000000","message":"Done","commit_id":"0d001eaa5054ad637c2922c110415e2dc1870b4e"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"fc6b8ced5648c4ba55dbdb4f27f03f0b55aa968b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.db import common_db_mixin"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"HOST \u003d \u0027localhost\u0027"},{"line_number":28,"context_line":"DEFAULT_AZ \u003d \u0027nova\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def find_file(filename, path):"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_bc3f6924","line":28,"updated":"2015-08-24 14:06:34.000000000","message":"It might be worth a comment here to explain that the reason this is the default is because it\u0027s following Nova\u0027s default AZ.","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"1c1a63f55e29a8be62fe1fd616038fbcaf461b2c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.db import common_db_mixin"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"HOST \u003d \u0027localhost\u0027"},{"line_number":28,"context_line":"DEFAULT_AZ \u003d \u0027nova\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def find_file(filename, path):"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_5bb12900","line":28,"in_reply_to":"fa1b9901_6cb335ea","updated":"2015-08-25 18:46:56.000000000","message":"fair enough.","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2f550d4dd73565b5f362593f44f2b87ad559e582","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.db import common_db_mixin"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"HOST \u003d \u0027localhost\u0027"},{"line_number":28,"context_line":"DEFAULT_AZ \u003d \u0027nova\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def find_file(filename, path):"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_6cb335ea","line":28,"in_reply_to":"fa1b9901_bc3f6924","updated":"2015-08-25 08:40:09.000000000","message":"I don\u0027t think the comment is needed because this is test file and there is the comment in neutron/db/agents_db.py.","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"}],"neutron/tests/unit/extensions/test_availability_zone.py":[{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"f6825f1f496ec9c7186afcd40bac311bfe8296f7","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# This plugin class is just for testing"},{"line_number":52,"context_line":"class TestAZPlugin(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":53,"context_line":"                   agentschedulers_db.DhcpAgentSchedulerDbMixin):"},{"line_number":54,"context_line":"    supported_extension_aliases \u003d [\"agent\", \"availability_zone\"]"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_0488c66f","line":52,"updated":"2015-07-16 17:21:02.000000000","message":"I think the convention is that testcase classes start with \"Test\". Maybe something like AZTestPlugin is better here.","commit_id":"059263f262452958f51ff97aff139613e65f0e98"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"af4ecdfaaf65ed813c2de5f02e2fd7fbb5c9950f","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# This plugin class is just for testing"},{"line_number":52,"context_line":"class TestAZPlugin(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":53,"context_line":"                   agentschedulers_db.DhcpAgentSchedulerDbMixin):"},{"line_number":54,"context_line":"    supported_extension_aliases \u003d [\"agent\", \"availability_zone\"]"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_4a0ea7e6","line":52,"in_reply_to":"9a41bdd9_0488c66f","updated":"2015-07-17 06:21:52.000000000","message":"Done","commit_id":"059263f262452958f51ff97aff139613e65f0e98"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"f6825f1f496ec9c7186afcd40bac311bfe8296f7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    supported_extension_aliases \u003d [\"agent\", \"availability_zone\"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class TestRouterAZPlugin(common_db_mixin.CommonDbMixin,"},{"line_number":58,"context_line":"                         l3_db.L3_NAT_db_mixin,"},{"line_number":59,"context_line":"                         az_db.RouterAvailabilityZoneMixin,"},{"line_number":60,"context_line":"                         l3_agentschedulers_db.L3AgentSchedulerDbMixin):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_64e0b229","line":57,"updated":"2015-07-16 17:21:02.000000000","message":"maybe AZRouterTestPlugin","commit_id":"059263f262452958f51ff97aff139613e65f0e98"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"af4ecdfaaf65ed813c2de5f02e2fd7fbb5c9950f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    supported_extension_aliases \u003d [\"agent\", \"availability_zone\"]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class TestRouterAZPlugin(common_db_mixin.CommonDbMixin,"},{"line_number":58,"context_line":"                         l3_db.L3_NAT_db_mixin,"},{"line_number":59,"context_line":"                         az_db.RouterAvailabilityZoneMixin,"},{"line_number":60,"context_line":"                         l3_agentschedulers_db.L3AgentSchedulerDbMixin):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_8a04afc6","line":57,"in_reply_to":"9a41bdd9_64e0b229","updated":"2015-07-17 06:21:52.000000000","message":"Done","commit_id":"059263f262452958f51ff97aff139613e65f0e98"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"f6825f1f496ec9c7186afcd40bac311bfe8296f7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            return router_db"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class AZDBTestCase(test_db_base_plugin_v2.NeutronDbPluginV2TestCase,"},{"line_number":80,"context_line":"                   test_l3.L3NatTestCaseMixin):"},{"line_number":81,"context_line":"    def setUp(self):"},{"line_number":82,"context_line":"        plugin \u003d (\u0027neutron.tests.unit.extensions.\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_046446b6","line":79,"updated":"2015-07-16 17:21:02.000000000","message":"TestAZDBCase","commit_id":"059263f262452958f51ff97aff139613e65f0e98"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"af4ecdfaaf65ed813c2de5f02e2fd7fbb5c9950f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            return router_db"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class AZDBTestCase(test_db_base_plugin_v2.NeutronDbPluginV2TestCase,"},{"line_number":80,"context_line":"                   test_l3.L3NatTestCaseMixin):"},{"line_number":81,"context_line":"    def setUp(self):"},{"line_number":82,"context_line":"        plugin \u003d (\u0027neutron.tests.unit.extensions.\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_ea68db89","line":79,"in_reply_to":"9a41bdd9_046446b6","updated":"2015-07-17 06:21:52.000000000","message":"Done","commit_id":"059263f262452958f51ff97aff139613e65f0e98"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"f6825f1f496ec9c7186afcd40bac311bfe8296f7","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        az_hints \u003d [\u0027nova1\u0027]"},{"line_number":131,"context_line":"        with self.network(availability_zone_hints\u003daz_hints) as net:"},{"line_number":132,"context_line":"            res \u003d self._show(\u0027networks\u0027, net[\u0027network\u0027][\u0027id\u0027])"},{"line_number":133,"context_line":"            self._validate_azs(az_hints, res[\u0027network\u0027])"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_create_network_with_azs(self):"},{"line_number":136,"context_line":"        self._register_azs()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_e1602fa7","line":133,"updated":"2015-07-16 17:21:02.000000000","message":"why not just\nself.assertItemsEqual(az_hints, res[\u0027network\u0027][\u0027availability_zone_hints\u0027]) ?","commit_id":"059263f262452958f51ff97aff139613e65f0e98"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"af4ecdfaaf65ed813c2de5f02e2fd7fbb5c9950f","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        az_hints \u003d [\u0027nova1\u0027]"},{"line_number":131,"context_line":"        with self.network(availability_zone_hints\u003daz_hints) as net:"},{"line_number":132,"context_line":"            res \u003d self._show(\u0027networks\u0027, net[\u0027network\u0027][\u0027id\u0027])"},{"line_number":133,"context_line":"            self._validate_azs(az_hints, res[\u0027network\u0027])"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_create_network_with_azs(self):"},{"line_number":136,"context_line":"        self._register_azs()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_ca6b9784","line":133,"in_reply_to":"9a41bdd9_e1602fa7","updated":"2015-07-17 06:21:52.000000000","message":"Done","commit_id":"059263f262452958f51ff97aff139613e65f0e98"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"fc6b8ced5648c4ba55dbdb4f27f03f0b55aa968b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_dc21fdfd","line":2,"updated":"2015-08-24 14:06:34.000000000","message":"I would remove these two lines.","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2f550d4dd73565b5f362593f44f2b87ad559e582","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa1b9901_6cea55ae","line":2,"in_reply_to":"fa1b9901_dc21fdfd","updated":"2015-08-25 08:40:09.000000000","message":"Done","commit_id":"5d4e9504a810e70e7d77b57636a714b952477ad9"},{"author":{"_account_id":4149,"name":"Itsuro Oda","email":"oda@valinux.co.jp","username":"oda-g"},"change_message_id":"059008b8a50f8548ba2b324f2bb9e73f01d658bd","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        ext_mgr \u003d AZExtensionManager()"},{"line_number":61,"context_line":"        super(TestAZAgentCase, self).setUp(plugin\u003dplugin, ext_mgr\u003dext_mgr)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _register_azs(self):"},{"line_number":64,"context_line":"        self.agent1 \u003d helpers.register_dhcp_agent(host\u003d\u0027host1\u0027, az\u003d\u0027nova1\u0027)"},{"line_number":65,"context_line":"        self.agent2 \u003d helpers.register_dhcp_agent(host\u003d\u0027host2\u0027, az\u003d\u0027nova2\u0027)"},{"line_number":66,"context_line":"        self.agent3 \u003d helpers.register_l3_agent(host\u003d\u0027host2\u0027, az\u003d\u0027nova2\u0027)"}],"source_content_type":"text/x-python","patch_set":31,"id":"ba15a1d1_2e7c1cb4","line":63,"updated":"2015-09-17 05:37:10.000000000","message":"it seems forgot to delete.","commit_id":"383e490ab5b40d1fd003841dc4a51a4d45392605"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"95822655c67f0c6bb45f995f6c50c4a790dd37e4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        ext_mgr \u003d AZExtensionManager()"},{"line_number":61,"context_line":"        super(TestAZAgentCase, self).setUp(plugin\u003dplugin, ext_mgr\u003dext_mgr)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _register_azs(self):"},{"line_number":64,"context_line":"        self.agent1 \u003d helpers.register_dhcp_agent(host\u003d\u0027host1\u0027, az\u003d\u0027nova1\u0027)"},{"line_number":65,"context_line":"        self.agent2 \u003d helpers.register_dhcp_agent(host\u003d\u0027host2\u0027, az\u003d\u0027nova2\u0027)"},{"line_number":66,"context_line":"        self.agent3 \u003d helpers.register_l3_agent(host\u003d\u0027host2\u0027, az\u003d\u0027nova2\u0027)"}],"source_content_type":"text/x-python","patch_set":31,"id":"ba15a1d1_018ec978","line":63,"in_reply_to":"ba15a1d1_2e7c1cb4","updated":"2015-09-17 05:43:44.000000000","message":"I will update.","commit_id":"383e490ab5b40d1fd003841dc4a51a4d45392605"}],"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"938445c1887ff730c513a1571f636cf944e6ed26","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                data[\u0027router\u0027][arg] \u003d kwargs[arg]"},{"line_number":334,"context_line":"        key \u003d \u0027availability_zone_hints\u0027"},{"line_number":335,"context_line":"        if key in kwargs:"},{"line_number":336,"context_line":"            data[\u0027router\u0027][key] \u003d kwargs[key]"},{"line_number":337,"context_line":"        router_req \u003d self.new_create_request(\u0027routers\u0027, data, fmt)"},{"line_number":338,"context_line":"        if set_context and tenant_id:"},{"line_number":339,"context_line":"            # create a specific auth context for this request"}],"source_content_type":"text/x-python","patch_set":25,"id":"da20952f_c6ffa3a9","line":336,"updated":"2015-09-11 05:38:45.000000000","message":"why don\u0027t you add this to the list in L330?","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b69608bdcd1db2de0f5f842f977e342eb5185abf","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                data[\u0027router\u0027][arg] \u003d kwargs[arg]"},{"line_number":334,"context_line":"        key \u003d \u0027availability_zone_hints\u0027"},{"line_number":335,"context_line":"        if key in kwargs:"},{"line_number":336,"context_line":"            data[\u0027router\u0027][key] \u003d kwargs[key]"},{"line_number":337,"context_line":"        router_req \u003d self.new_create_request(\u0027routers\u0027, data, fmt)"},{"line_number":338,"context_line":"        if set_context and tenant_id:"},{"line_number":339,"context_line":"            # create a specific auth context for this request"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_907293e4","line":336,"in_reply_to":"da20952f_c6ffa3a9","updated":"2015-09-14 23:48:37.000000000","message":"Done","commit_id":"384b8b126c8688e24c92e45903691015911eed47"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"927a74c5658e54c2950f1693c8d30d566e652c16","unresolved":false,"context_lines":[{"line_number":1611,"context_line":"        plugin._get_host_port_if_changed \u003d mock.Mock("},{"line_number":1612,"context_line":"            return_value\u003dnew_host_port)"},{"line_number":1613,"context_line":"        plugin._check_mac_update_allowed \u003d mock.Mock(return_value\u003dTrue)"},{"line_number":1614,"context_line":"        plugin.extension_manager.extension_aliases \u003d mock.Mock(return_value\u003d[])"},{"line_number":1615,"context_line":"        plugin.get_resource_availability_zones \u003d mock.Mock(return_value\u003d[])"},{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"        self.notify.side_effect \u003d ("}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_df0dac38","line":1614,"updated":"2015-09-12 21:55:34.000000000","message":"?? This doesn\u0027t seem right.","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b69608bdcd1db2de0f5f842f977e342eb5185abf","unresolved":false,"context_lines":[{"line_number":1611,"context_line":"        plugin._get_host_port_if_changed \u003d mock.Mock("},{"line_number":1612,"context_line":"            return_value\u003dnew_host_port)"},{"line_number":1613,"context_line":"        plugin._check_mac_update_allowed \u003d mock.Mock(return_value\u003dTrue)"},{"line_number":1614,"context_line":"        plugin.extension_manager.extension_aliases \u003d mock.Mock(return_value\u003d[])"},{"line_number":1615,"context_line":"        plugin.get_resource_availability_zones \u003d mock.Mock(return_value\u003d[])"},{"line_number":1616,"context_line":""},{"line_number":1617,"context_line":"        self.notify.side_effect \u003d ("}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_300dc73e","line":1614,"in_reply_to":"ba15a1d1_df0dac38","updated":"2015-09-14 23:48:37.000000000","message":"I updated. Currently, I set mock to plugin._extend_availability_zone because mock is passed to _extend_availability_zone\u0027s parameter.","commit_id":"384b8b126c8688e24c92e45903691015911eed47"}],"neutron/tests/unit/plugins/oneconvergence/test_nvsd_plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"927a74c5658e54c2950f1693c8d30d566e652c16","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            super(OneConvergencePluginV2TestCase,"},{"line_number":52,"context_line":"                  self).setUp(self._plugin_name)"},{"line_number":53,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":54,"context_line":"        plugin.get_resource_availability_zones \u003d mock.Mock(return_value\u003d[])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class TestOneConvergencePluginNetworksV2(test_plugin.TestNetworksV2,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_9f109450","line":54,"updated":"2015-09-12 21:55:34.000000000","message":"this is exactly what I was talking about on plugins/ml2/plugin.py\n\nYou\u0027re not suppose to touch these to make tests \u0027pass\u0027, this most likely means you\u0027re breaking an awful lot of plugins out of tree.","commit_id":"384b8b126c8688e24c92e45903691015911eed47"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b69608bdcd1db2de0f5f842f977e342eb5185abf","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            super(OneConvergencePluginV2TestCase,"},{"line_number":52,"context_line":"                  self).setUp(self._plugin_name)"},{"line_number":53,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":54,"context_line":"        plugin.get_resource_availability_zones \u003d mock.Mock(return_value\u003d[])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class TestOneConvergencePluginNetworksV2(test_plugin.TestNetworksV2,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba15a1d1_f0818f90","line":54,"in_reply_to":"ba15a1d1_9f109450","updated":"2015-09-14 23:48:37.000000000","message":"Done","commit_id":"384b8b126c8688e24c92e45903691015911eed47"}],"neutron/tests/unit/scheduler/test_l3_agent_scheduler.py":[{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"acff855a9ce74325ed8a9557e54fd91758364a70","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        sync_router \u003d {"},{"line_number":472,"context_line":"            \u0027id\u0027: \u0027foo_router_id\u0027,"},{"line_number":473,"context_line":"            \u0027distributed\u0027: True,"},{"line_number":474,"context_line":"            \u0027availability_zone_hints\u0027: [\u0027nova\u0027]"},{"line_number":475,"context_line":"        }"},{"line_number":476,"context_line":"        plugin.get_router.return_value \u003d sync_router"},{"line_number":477,"context_line":"        with mock.patch.object(scheduler, \u0027bind_router\u0027),\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_7eb3984d","line":474,"updated":"2015-07-08 22:59:45.000000000","message":"There should be a test around the limit on the availability zone length","commit_id":"67098a259d0aad4d20b9dd28e39930110a7af36a"}]}
