)]}'
{"quantum/api/v2/base.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b9edc8c8cb9e10b51bf7a25be7f54f706d1655ce","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        else:"},{"line_number":296,"context_line":"            items \u003d [body]"},{"line_number":297,"context_line":"        for item in items:"},{"line_number":298,"context_line":"            self._validate_network_tenant_ownership(request,"},{"line_number":299,"context_line":"                                                    item[self._resource])"},{"line_number":300,"context_line":"            try:"},{"line_number":301,"context_line":"                policy.enforce(request.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F5Nk%3D","line":298,"updated":"2012-12-24 07:30:30.000000000","message":"What if there is an exception here?","commit_id":"8dd615811e0620b8517b2e5e545b7ae0b986bda7"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"027bf9c9a896b85629c87bb5cda9d31ef8b46959","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        else:"},{"line_number":296,"context_line":"            items \u003d [body]"},{"line_number":297,"context_line":"        for item in items:"},{"line_number":298,"context_line":"            self._validate_network_tenant_ownership(request,"},{"line_number":299,"context_line":"                                                    item[self._resource])"},{"line_number":300,"context_line":"            try:"},{"line_number":301,"context_line":"                policy.enforce(request.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F5J0%3D","line":298,"in_reply_to":"AAAAM3%2F%2F5Nc%3D","updated":"2012-12-24 15:21:10.000000000","message":"This throws webob.exc.HTTPForbidden and it wasn\u0027t being catched at all. I should also write a test script for this part.","commit_id":"8dd615811e0620b8517b2e5e545b7ae0b986bda7"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"027bf9c9a896b85629c87bb5cda9d31ef8b46959","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        else:"},{"line_number":296,"context_line":"            items \u003d [body]"},{"line_number":297,"context_line":"        for item in items:"},{"line_number":298,"context_line":"            self._validate_network_tenant_ownership(request,"},{"line_number":299,"context_line":"                                                    item[self._resource])"},{"line_number":300,"context_line":"            try:"},{"line_number":301,"context_line":"                policy.enforce(request.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F5Nc%3D","line":298,"in_reply_to":"AAAAM3%2F%2F5Nk%3D","updated":"2012-12-24 07:49:28.000000000","message":"oops missed that. I\u0027ll include it in the block","commit_id":"8dd615811e0620b8517b2e5e545b7ae0b986bda7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"7cb414aaf312b0f7e2c423cc8f8e63472b7adc47","unresolved":false,"context_lines":[{"line_number":315,"context_line":"            except Exception:"},{"line_number":316,"context_line":"                raise"},{"line_number":317,"context_line":"            else:"},{"line_number":318,"context_line":"                QUOTAS.limit_check(request.context,"},{"line_number":319,"context_line":"                                   item[self._resource][\u0027tenant_id\u0027],"},{"line_number":320,"context_line":"                                   **kwargs)"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F5Fg%3D","line":318,"updated":"2012-12-24 17:15:04.000000000","message":"This can be cleaned up further.  Move this statement until after line 308 and then remove lines 315-317.","commit_id":"8dd615811e0620b8517b2e5e545b7ae0b986bda7"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":315,"context_line":"            except Exception:"},{"line_number":316,"context_line":"                raise"},{"line_number":317,"context_line":"            else:"},{"line_number":318,"context_line":"                QUOTAS.limit_check(request.context,"},{"line_number":319,"context_line":"                                   item[self._resource][\u0027tenant_id\u0027],"},{"line_number":320,"context_line":"                                   **kwargs)"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F4%2FQ%3D","line":318,"in_reply_to":"AAAAM3%2F%2F5Dk%3D","updated":"2012-12-25 01:27:33.000000000","message":"Mark, apparently _validate_network_tenant_ownership() raises a webob.exc.HTTPForbidden. Therefore I think line 315 should be kept. I\u0027ll send in a new patch once you verify this.","commit_id":"8dd615811e0620b8517b2e5e545b7ae0b986bda7"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":315,"context_line":"            except Exception:"},{"line_number":316,"context_line":"                raise"},{"line_number":317,"context_line":"            else:"},{"line_number":318,"context_line":"                QUOTAS.limit_check(request.context,"},{"line_number":319,"context_line":"                                   item[self._resource][\u0027tenant_id\u0027],"},{"line_number":320,"context_line":"                                   **kwargs)"},{"line_number":321,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2F5Dk%3D","line":318,"in_reply_to":"AAAAM3%2F%2F5Fg%3D","updated":"2012-12-24 21:07:48.000000000","message":"Done","commit_id":"8dd615811e0620b8517b2e5e545b7ae0b986bda7"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"08f659f813bc475c54bc972cdc6047d22dd44c1c","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        for item in items:"},{"line_number":300,"context_line":"            try:"},{"line_number":301,"context_line":"                self._validate_network_tenant_ownership(request,"},{"line_number":302,"context_line":"                                                        item[self._resource])"},{"line_number":303,"context_line":"                policy.enforce(request.context,"},{"line_number":304,"context_line":"                               action,"},{"line_number":305,"context_line":"                               item[self._resource],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F4mM%3D","line":302,"updated":"2012-12-26 14:09:53.000000000","message":"This can be out of the try block?","commit_id":"3663532aa3c047cfeb928e9632bc4b50adcbedbb"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":299,"context_line":"        for item in items:"},{"line_number":300,"context_line":"            try:"},{"line_number":301,"context_line":"                self._validate_network_tenant_ownership(request,"},{"line_number":302,"context_line":"                                                        item[self._resource])"},{"line_number":303,"context_line":"                policy.enforce(request.context,"},{"line_number":304,"context_line":"                               action,"},{"line_number":305,"context_line":"                               item[self._resource],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F4Ug%3D","line":302,"in_reply_to":"AAAAM3%2F%2F4U8%3D","updated":"2012-12-27 07:40:09.000000000","message":"_validate_network_tenant_ownership(..) raises exceptions.PolicyNotAuthorized, which is already mapped to webob.exc.HTTPForbidden by FAULT_MAP. So we don\u0027t need to put it into the try block since we don\u0027t do anything for it.\nsimilarly, the Line 303 can live out of the try block too.\n\nwe can remove Line 311.","commit_id":"3663532aa3c047cfeb928e9632bc4b50adcbedbb"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"08f659f813bc475c54bc972cdc6047d22dd44c1c","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        for item in items:"},{"line_number":300,"context_line":"            try:"},{"line_number":301,"context_line":"                self._validate_network_tenant_ownership(request,"},{"line_number":302,"context_line":"                                                        item[self._resource])"},{"line_number":303,"context_line":"                policy.enforce(request.context,"},{"line_number":304,"context_line":"                               action,"},{"line_number":305,"context_line":"                               item[self._resource],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F4UU%3D","line":302,"in_reply_to":"AAAAM3%2F%2F4Ug%3D","updated":"2012-12-27 07:45:07.000000000","message":"And I think we should remove lines 317-318 too.\n\nso code should looks like:\n\ntry:\n    count \u003d QUOTAS.count(request.context, self._resource,\n                         self._plugin, self._collection,\n                         item[self._resource][\u0027tenant_id\u0027])\n    kwargs \u003d {self._resource: count + 1}\nexcept exceptions.QuotaResourceUnknown as e:\n    # We don\u0027t want to quota this resource\n    LOG.debug(e)\nelse:\n    QUOTAS.limit_check(request.context,\n                       item[self._resource][\u0027tenant_id\u0027],\n                       **kwargs)","commit_id":"3663532aa3c047cfeb928e9632bc4b50adcbedbb"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":299,"context_line":"        for item in items:"},{"line_number":300,"context_line":"            try:"},{"line_number":301,"context_line":"                self._validate_network_tenant_ownership(request,"},{"line_number":302,"context_line":"                                                        item[self._resource])"},{"line_number":303,"context_line":"                policy.enforce(request.context,"},{"line_number":304,"context_line":"                               action,"},{"line_number":305,"context_line":"                               item[self._resource],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F4U8%3D","line":302,"in_reply_to":"AAAAM3%2F%2F4WA%3D","updated":"2012-12-27 07:28:11.000000000","message":"Alex, I get your point. You are saying that this line was not handled by this try block in the original code, right? How ever Gary commented that exceptions from this line should be catched so I placed this line here to meet Gary\u0027s request without changing the original behavior of the code. Do you agree?","commit_id":"3663532aa3c047cfeb928e9632bc4b50adcbedbb"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"08f659f813bc475c54bc972cdc6047d22dd44c1c","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        for item in items:"},{"line_number":300,"context_line":"            try:"},{"line_number":301,"context_line":"                self._validate_network_tenant_ownership(request,"},{"line_number":302,"context_line":"                                                        item[self._resource])"},{"line_number":303,"context_line":"                policy.enforce(request.context,"},{"line_number":304,"context_line":"                               action,"},{"line_number":305,"context_line":"                               item[self._resource],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F4kw%3D","line":302,"in_reply_to":"AAAAM3%2F%2F4k4%3D","updated":"2012-12-27 03:09:19.000000000","message":"Yes, But it just catch exception, then raise again. It looks like meanless. And there is principle about keep the size of try block small. Thanks Alex","commit_id":"3663532aa3c047cfeb928e9632bc4b50adcbedbb"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":299,"context_line":"        for item in items:"},{"line_number":300,"context_line":"            try:"},{"line_number":301,"context_line":"                self._validate_network_tenant_ownership(request,"},{"line_number":302,"context_line":"                                                        item[self._resource])"},{"line_number":303,"context_line":"                policy.enforce(request.context,"},{"line_number":304,"context_line":"                               action,"},{"line_number":305,"context_line":"                               item[self._resource],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F4WA%3D","line":302,"in_reply_to":"AAAAM3%2F%2F4kw%3D","updated":"2012-12-27 03:47:35.000000000","message":"Alex, this patch aims to shrink the try/catch block size from its previous range which was the whole for loop. Therefore changing the behavior of exception handling should be done in another patch after reporting a bug IMO.","commit_id":"3663532aa3c047cfeb928e9632bc4b50adcbedbb"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"08f659f813bc475c54bc972cdc6047d22dd44c1c","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        for item in items:"},{"line_number":300,"context_line":"            try:"},{"line_number":301,"context_line":"                self._validate_network_tenant_ownership(request,"},{"line_number":302,"context_line":"                                                        item[self._resource])"},{"line_number":303,"context_line":"                policy.enforce(request.context,"},{"line_number":304,"context_line":"                               action,"},{"line_number":305,"context_line":"                               item[self._resource],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F4lU%3D","line":302,"in_reply_to":"AAAAM3%2F%2F4l8%3D","updated":"2012-12-26 14:56:23.000000000","message":"But the exception raised by this function isn\u0027t processed by this try bock","commit_id":"3663532aa3c047cfeb928e9632bc4b50adcbedbb"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":299,"context_line":"        for item in items:"},{"line_number":300,"context_line":"            try:"},{"line_number":301,"context_line":"                self._validate_network_tenant_ownership(request,"},{"line_number":302,"context_line":"                                                        item[self._resource])"},{"line_number":303,"context_line":"                policy.enforce(request.context,"},{"line_number":304,"context_line":"                               action,"},{"line_number":305,"context_line":"                               item[self._resource],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F4k4%3D","line":302,"in_reply_to":"AAAAM3%2F%2F4lU%3D","updated":"2012-12-26 15:19:52.000000000","message":"it is catched at line 317","commit_id":"3663532aa3c047cfeb928e9632bc4b50adcbedbb"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"unresolved":false,"context_lines":[{"line_number":299,"context_line":"        for item in items:"},{"line_number":300,"context_line":"            try:"},{"line_number":301,"context_line":"                self._validate_network_tenant_ownership(request,"},{"line_number":302,"context_line":"                                                        item[self._resource])"},{"line_number":303,"context_line":"                policy.enforce(request.context,"},{"line_number":304,"context_line":"                               action,"},{"line_number":305,"context_line":"                               item[self._resource],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F4l8%3D","line":302,"in_reply_to":"AAAAM3%2F%2F4mM%3D","updated":"2012-12-26 14:35:36.000000000","message":"This method also throws exceptions thus should be inside the block","commit_id":"3663532aa3c047cfeb928e9632bc4b50adcbedbb"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"08f659f813bc475c54bc972cdc6047d22dd44c1c","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                                     self._plugin, self._collection,"},{"line_number":309,"context_line":"                                     item[self._resource][\u0027tenant_id\u0027])"},{"line_number":310,"context_line":"                kwargs \u003d {self._resource: count + 1}"},{"line_number":311,"context_line":"            except exceptions.PolicyNotAuthorized:"},{"line_number":312,"context_line":"                LOG.exception(_(\"Create operation not authorized\"))"},{"line_number":313,"context_line":"                raise webob.exc.HTTPForbidden()"},{"line_number":314,"context_line":"            except exceptions.QuotaResourceUnknown as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F44I%3D","line":311,"updated":"2012-12-25 12:02:25.000000000","message":"Why we don\u0027t raise \u0027exceptions.PolicyNotAuthorized\u0027 directly? We have mapping at FAULT_MAP","commit_id":"3663532aa3c047cfeb928e9632bc4b50adcbedbb"}]}
