)]}'
{"neutron/db/common_db_mixin.py":[{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"973a87863d3f92fcdd2526ae78611052f1b2e8f1","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        if context.is_admin and \u0027tenant_id\u0027 in resource:"},{"line_number":122,"context_line":"            tenant_id \u003d resource[\u0027tenant_id\u0027]"},{"line_number":123,"context_line":"            keystone_conf \u003d cfg.CONF.keystone_authtoken"},{"line_number":124,"context_line":"            client \u003d keyclient.Client(token \u003d context.auth_token,"},{"line_number":125,"context_line":"                                      endpoint \u003d keystone_conf.auth_uri)"},{"line_number":126,"context_line":"            # check if the tenant_id is exist, if not, raise an exception"},{"line_number":127,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_5cb73ef5","line":124,"updated":"2015-05-28 06:07:13.000000000","message":"This is a very costly call to keystone client. Things will fail or choke or effect performance badly when we process concurrent calls from admin. \n\nIs existing 404 not sufficient for operator?","commit_id":"952165a431ab8d8c52a03d602b8d6a4c702d3565"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"dedd0209b9ee185b12b5801e6a18c78c511e39cd","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        if context.is_admin and \u0027tenant_id\u0027 in resource:"},{"line_number":122,"context_line":"            tenant_id \u003d resource[\u0027tenant_id\u0027]"},{"line_number":123,"context_line":"            keystone_conf \u003d cfg.CONF.keystone_authtoken"},{"line_number":124,"context_line":"            client \u003d keyclient.Client(token \u003d context.auth_token,"},{"line_number":125,"context_line":"                                      endpoint \u003d keystone_conf.auth_uri)"},{"line_number":126,"context_line":"            # check if the tenant_id is exist, if not, raise an exception"},{"line_number":127,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_85bbfce4","line":124,"in_reply_to":"7a016987_0fc62649","updated":"2015-05-28 17:50:22.000000000","message":"Thanks. Since this is not a blocker issue and it is not very common to run into this issue, it will be worthwhile to spend more time and come up with a better alternative, which does not compromise the points mentioned above or existing error should be okay; it won\u0027t be pretty but it will prevent the admin from doing something on the tenant which does not exist, which I believe is the end goal.","commit_id":"952165a431ab8d8c52a03d602b8d6a4c702d3565"},{"author":{"_account_id":7515,"name":"Jian LI","email":"ljianbj@cn.ibm.com","username":"leejian0612"},"change_message_id":"2026dda1e3b9a6cfa9f85a566b25a9084f6dec15","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        if context.is_admin and \u0027tenant_id\u0027 in resource:"},{"line_number":122,"context_line":"            tenant_id \u003d resource[\u0027tenant_id\u0027]"},{"line_number":123,"context_line":"            keystone_conf \u003d cfg.CONF.keystone_authtoken"},{"line_number":124,"context_line":"            client \u003d keyclient.Client(token \u003d context.auth_token,"},{"line_number":125,"context_line":"                                      endpoint \u003d keystone_conf.auth_uri)"},{"line_number":126,"context_line":"            # check if the tenant_id is exist, if not, raise an exception"},{"line_number":127,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_0fc62649","line":124,"in_reply_to":"7a016987_5cb73ef5","updated":"2015-05-28 06:41:58.000000000","message":"Thanks for your reply!\nI know this solution is not elegant, but it works now, if we don\u0027t send identify request to keystone everytime, there always will be potential that the tenant_id may be fake, or could we add some cache mechnism, like db or python dict to store tenant information, if we take this way, how could we sync our cache with keystone, periodic duty and callback function, this may need a little change on keystone!\n\nThis is not just a neutron problem, other components link nova may also hava it.\n\nanyway I will try to implement it in other way.","commit_id":"952165a431ab8d8c52a03d602b8d6a4c702d3565"}]}
