)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"75546b049e8613d467501621d36c2faf6cb465c8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Assaf Muller \u003camuller@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-29 19:17:34 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify ipset functional tests to pass on older machines"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I08b2f59197ed76e59b2e58b5a10820653e857cda"},{"line_number":10,"context_line":"Closes-Bug: #1460220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_a70a40d0","line":7,"updated":"2015-05-30 15:46:08.000000000","message":"Could you develop why this change enables ipset functional tests on older machines?\n\nNo ipset isolation per namespace?","commit_id":"e3c1968e70a4f8424aa6f56220b4a52405c56944"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"5182fb04bf9771fb8f4d656c50f88999c42962a0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Assaf Muller \u003camuller@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-29 19:17:34 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify ipset functional tests to pass on older machines"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I08b2f59197ed76e59b2e58b5a10820653e857cda"},{"line_number":10,"context_line":"Closes-Bug: #1460220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5afe65bd_e58eb626","line":7,"in_reply_to":"7a016987_269ac062","updated":"2015-06-01 15:44:09.000000000","message":"I had an explanation in the bug report, I\u0027ll copy it here.","commit_id":"e3c1968e70a4f8424aa6f56220b4a52405c56944"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"982b64257d944cc2be99b4a19409bc9d37d6ad1f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Assaf Muller \u003camuller@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-29 19:17:34 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify ipset functional tests to pass on older machines"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I08b2f59197ed76e59b2e58b5a10820653e857cda"},{"line_number":10,"context_line":"Closes-Bug: #1460220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_269ac062","line":7,"in_reply_to":"7a016987_a70a40d0","updated":"2015-06-01 11:03:20.000000000","message":"Yes, more broad description would be of help to other reviewers.","commit_id":"e3c1968e70a4f8424aa6f56220b4a52405c56944"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d2d650059739745c72150f5a44e5539490ac74b1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Production code uses ipset exclusively in the root namespace,"},{"line_number":10,"context_line":"however functional testing uses ipset in namespace for isolation."},{"line_number":11,"context_line":"This poses an issue as ipset is not supported in namespaces on"},{"line_number":12,"context_line":"all kernels and distributions (I\u0027m looking at you CentOS/RHEL 7.1)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch changes the ipset functional tests to work in the root"},{"line_number":15,"context_line":"namespace while taking care of cleanups."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5afe65bd_0590b2eb","line":12,"updated":"2015-06-01 15:58:31.000000000","message":"LoL","commit_id":"6e00cb450de05184ffbc3708f3952885e7c17b91"}],"neutron/tests/functional/agent/linux/test_ipset.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"75546b049e8613d467501621d36c2faf6cb465c8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            machine_fixtures.PeerMachines(bridge)).machines"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.ipset_name \u003d base.get_rand_name(MAX_IPSET_NAME_LENGTH, \u0027set-\u0027)"},{"line_number":39,"context_line":"        self.ICMP_ACCEPT_RULE \u003d (\u0027-p icmp -m set --match-set %s src -j ACCEPT\u0027"},{"line_number":40,"context_line":"                                 % self.ipset_name)"},{"line_number":41,"context_line":"        self.ipset \u003d self._create_ipset_manager_and_set("},{"line_number":42,"context_line":"            ip_lib.IPWrapper(self.destination.namespace), self.ipset_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4775cc61","line":39,"updated":"2015-05-30 15:46:08.000000000","message":"using a lowercase attribute would be less confusing","commit_id":"e3c1968e70a4f8424aa6f56220b4a52405c56944"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"5182fb04bf9771fb8f4d656c50f88999c42962a0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            machine_fixtures.PeerMachines(bridge)).machines"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        self.ipset_name \u003d base.get_rand_name(MAX_IPSET_NAME_LENGTH, \u0027set-\u0027)"},{"line_number":39,"context_line":"        self.ICMP_ACCEPT_RULE \u003d (\u0027-p icmp -m set --match-set %s src -j ACCEPT\u0027"},{"line_number":40,"context_line":"                                 % self.ipset_name)"},{"line_number":41,"context_line":"        self.ipset \u003d self._create_ipset_manager_and_set("},{"line_number":42,"context_line":"            ip_lib.IPWrapper(self.destination.namespace), self.ipset_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_059c3268","line":39,"in_reply_to":"7a016987_4775cc61","updated":"2015-06-01 15:44:09.000000000","message":"Done","commit_id":"e3c1968e70a4f8424aa6f56220b4a52405c56944"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d2d650059739745c72150f5a44e5539490ac74b1","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _remove_iptables_ipset_rules(self):"},{"line_number":58,"context_line":"        self.dst_iptables.ipv4[\u0027filter\u0027].remove_rule("},{"line_number":59,"context_line":"            \u0027INPUT\u0027, self.icmp_accept_rule)"},{"line_number":60,"context_line":"        self.dst_iptables.apply()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _add_iptables_ipset_rules(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_28bee3ff","line":59,"updated":"2015-06-01 15:58:31.000000000","message":"We should cleanUp the BLOCK rule (L66) as we are (could be?) configuring the root namespace.","commit_id":"6e00cb450de05184ffbc3708f3952885e7c17b91"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"013932b832eb8a185d253ddfbe99401b833c5d1a","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def _remove_iptables_ipset_rules(self):"},{"line_number":58,"context_line":"        self.dst_iptables.ipv4[\u0027filter\u0027].remove_rule("},{"line_number":59,"context_line":"            \u0027INPUT\u0027, self.icmp_accept_rule)"},{"line_number":60,"context_line":"        self.dst_iptables.apply()"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _add_iptables_ipset_rules(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_87f93dcb","line":59,"in_reply_to":"5afe65bd_28bee3ff","updated":"2015-06-01 20:26:10.000000000","message":"Done","commit_id":"6e00cb450de05184ffbc3708f3952885e7c17b91"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"03b431ee371e366eeb63e461ad95f28324fed0a0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_62c4e63f","line":1,"updated":"2015-06-02 02:14:50.000000000","message":"nit: not sure you need to update this, but if you do should be 2014-2015 I believe.","commit_id":"96e2314c8c0f06967b53828b0a771973f0031243"}]}