)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"7f569feb5d1bfed6385c607f80c25cf067b236ea","unresolved":false,"context_lines":[{"line_number":10,"context_line":"methods:"},{"line_number":11,"context_line":"* get_endpoint_by_host"},{"line_number":12,"context_line":"* get_endpoint_by_ip"},{"line_number":13,"context_line":"* delete_endpoint"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change abstracts these methods and moves them to the new class"},{"line_number":16,"context_line":"EndpointTunnelTypeDriver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_dc95be40","line":13,"updated":"2015-06-02 04:24:49.000000000","message":"If you considered these methods., why you didn\u0027t consider add_endpoint and get_endpoints for having similar implementations?\n\nI feel let it be AS-IS :)\nThere are other things that we could refactor in  type_vxlan and type_gre first as suggested in the below patch-set.\nhttps://review.openstack.org/#/c/153891/20/neutron/plugins/ml2/drivers/type_tunnel.py","commit_id":"f64830577b6638911975a6d0f5db5c64735d015e"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c80bcf459c487bd5a2203d3e737c09cd601daa54","unresolved":false,"context_lines":[{"line_number":10,"context_line":"methods:"},{"line_number":11,"context_line":"* get_endpoint_by_host"},{"line_number":12,"context_line":"* get_endpoint_by_ip"},{"line_number":13,"context_line":"* delete_endpoint"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change abstracts these methods and moves them to the new class"},{"line_number":16,"context_line":"EndpointTunnelTypeDriver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_cb960e94","line":13,"in_reply_to":"5afe65bd_dc95be40","updated":"2015-06-02 08:08:21.000000000","message":"sync_allocations is not concerned (see https://review.openstack.org/111198)","commit_id":"f64830577b6638911975a6d0f5db5c64735d015e"}],"neutron/plugins/ml2/drivers/type_tunnel.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"2409945da9338f1c40b193db563235d6790b6025","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class TunnelTypeDriver(helpers.SegmentTypeDriver):"},{"line_number":34,"context_line":"    \"\"\"Define stable abstract interface for ML2 type drivers."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    tunnel type networks rely on tunnel endpoints. This class defines abstract"},{"line_number":37,"context_line":"    methods to manage these endpoints."}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_7d9a8215","line":34,"updated":"2015-06-01 14:44:30.000000000","message":"The changes to this class seem to run counter this statement.","commit_id":"126f5d1c4da78108778fc1728c2baa4fa86dc076"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"079128f22913d705a357eb1107f8d28b5e809b51","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class TunnelTypeDriver(helpers.SegmentTypeDriver):"},{"line_number":34,"context_line":"    \"\"\"Define stable abstract interface for ML2 type drivers."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    tunnel type networks rely on tunnel endpoints. This class defines abstract"},{"line_number":37,"context_line":"    methods to manage these endpoints."}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_e57356b3","line":34,"in_reply_to":"7a016987_7d9a8215","updated":"2015-06-01 15:36:29.000000000","message":"Done","commit_id":"126f5d1c4da78108778fc1728c2baa4fa86dc076"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"432d832638b2834c50331c1f08cb5709d46128c5","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        return min(mtu) if mtu else 0"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class EndpointTunnelTypeDriver(TunnelTypeDriver):"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def __init__(self, segment_model, endpoint_model):"},{"line_number":204,"context_line":"        super(EndpointTunnelTypeDriver, self).__init__(segment_model)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_61e4db3a","line":201,"updated":"2015-06-02 09:26:11.000000000","message":"it isn\u0027t clear why you want to introduce another level of indirection.  can you explain?","commit_id":"46223363bd4d41639102ae1923dd1dfb306ec808"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"d962c55d9167e2054e32d5d1ba2eed36089478ca","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        return min(mtu) if mtu else 0"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class EndpointTunnelTypeDriver(TunnelTypeDriver):"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def __init__(self, segment_model, endpoint_model):"},{"line_number":204,"context_line":"        super(EndpointTunnelTypeDriver, self).__init__(segment_model)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_d14a2a83","line":201,"in_reply_to":"5afe65bd_61e4db3a","updated":"2015-06-02 17:52:40.000000000","message":"I think he is trying to reduce the duplicate code.","commit_id":"46223363bd4d41639102ae1923dd1dfb306ec808"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f85aa0b01cbcd458f862a2b1e92915d0c8441f93","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        return min(mtu) if mtu else 0"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"class EndpointTunnelTypeDriver(TunnelTypeDriver):"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def __init__(self, segment_model, endpoint_model):"},{"line_number":204,"context_line":"        super(EndpointTunnelTypeDriver, self).__init__(segment_model)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_2c2361bf","line":201,"in_reply_to":"5afe65bd_61e4db3a","updated":"2015-06-02 18:15:17.000000000","message":"TunnelTypeDriver is considered as a stable interface (L33, remark from Mark in PS2). Sharing endpoint related implementation implies to changes __init__ signature in order to provide endpoint_model. That\u0027s why endpoint related implementation are in a specific class","commit_id":"46223363bd4d41639102ae1923dd1dfb306ec808"}]}