)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"3c1112208276efa37325b9b08cf174dfdb494b66","unresolved":false,"context_lines":[{"line_number":11,"context_line":"but it will not be helpful to locate issue in neutron"},{"line_number":12,"context_line":"log when booting instances failed with \"virt_binding\""},{"line_number":13,"context_line":"error message in nova compute log, in case openvswith"},{"line_number":14,"context_line":"agent dead or bridge mappings dismatch. This patch"},{"line_number":15,"context_line":"will change log level to error for that case."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I232d3634cadcffa64e50a79197ba35db2ad90dbd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_0baa0171","line":14,"updated":"2015-06-01 16:26:56.000000000","message":"Why an error in nova implies an error in neutron?\n\nIMO, all changed logs should be warnings","commit_id":"d960b29bf30c94f715057db8e6ffdf0cb71bfae4"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"5bff50c2990bab274d31bf14c94b2d124373fa38","unresolved":false,"context_lines":[{"line_number":11,"context_line":"but it will not be helpful to locate issue in neutron"},{"line_number":12,"context_line":"log when booting instances failed with \"virt_binding\""},{"line_number":13,"context_line":"error message in nova compute log, in case openvswith"},{"line_number":14,"context_line":"agent dead or bridge mappings dismatch. This patch"},{"line_number":15,"context_line":"will change log level to error for that case."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I232d3634cadcffa64e50a79197ba35db2ad90dbd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_02e2d2d5","line":14,"in_reply_to":"5afe65bd_0baa0171","updated":"2015-06-02 02:17:44.000000000","message":"I don\u0027t think it\u0027s wise enough to talk about network without nodes. We use neutron to support network service for instances, not just for a network.\n\nIndeed, it\u0027s neutron\u0027s problem cause nova booting failed. neutron fail to bind port, return some invalid vif binding, then nova booting failed.\n\nOh, I recognize I made mistake in nova compute error message, it should be \"Unexpected vif_type\u003dbinding_failed\", maybe vif is more like a network error, a neutron error.","commit_id":"d960b29bf30c94f715057db8e6ffdf0cb71bfae4"}],"neutron/plugins/ml2/drivers/mech_agent.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"02d312d58739255bffdffe901a58103a6d06ca14","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        if network_type in [p_constants.TYPE_FLAT, p_constants.TYPE_VLAN]:"},{"line_number":197,"context_line":"            physnet \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":198,"context_line":"            if not self.physnet_in_mappings(physnet, mappings):"},{"line_number":199,"context_line":"                LOG.error(_LE("},{"line_number":200,"context_line":"                    \u0027Network %(network_id)s is connected to physical \u0027"},{"line_number":201,"context_line":"                    \u0027network %(physnet)s, but agent %(agent)s reported \u0027"},{"line_number":202,"context_line":"                    \u0027physical networks %(mappings)s. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_529537e2","line":199,"updated":"2015-06-02 06:30:32.000000000","message":"these are intentionally kept at debug level, considering deployments with multiple mech drivers.\n\nplease take a look at the discussion in\nhttps://review.openstack.org/#/c/125115/\naround PS11.","commit_id":"d846a0caa8d0d9721083880e01daa02508b4cfdc"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"bed6ed0a5012775a95e24e406860f1123ab972e1","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        if network_type in [p_constants.TYPE_FLAT, p_constants.TYPE_VLAN]:"},{"line_number":197,"context_line":"            physnet \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":198,"context_line":"            if not self.physnet_in_mappings(physnet, mappings):"},{"line_number":199,"context_line":"                LOG.error(_LE("},{"line_number":200,"context_line":"                    \u0027Network %(network_id)s is connected to physical \u0027"},{"line_number":201,"context_line":"                    \u0027network %(physnet)s, but agent %(agent)s reported \u0027"},{"line_number":202,"context_line":"                    \u0027physical networks %(mappings)s. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_55608135","line":199,"in_reply_to":"5afe65bd_529537e2","updated":"2015-06-02 07:05:37.000000000","message":"Thanks, that\u0027s the most powerful comments I\u0027ve get for this patch up to now.\n\nI\u0027ve read those comments around PS11, specially Robert\u0027s, now I agree that, it\u0027s no necessary for L186 to use ERROR level for log. \n\nBut to L199, I still couldn\u0027t buy it yet. It\u0027s more obvious configuration error than L186, and easy to fix, and once it\u0027s fixed, the error messages here will raise no more. I think it\u0027s worth to notify users that they got a configuration error.\n\nAnd to L76, after reading link 125115, it\u0027s also acceptable for me to keep WARNING level.","commit_id":"d846a0caa8d0d9721083880e01daa02508b4cfdc"}]}