)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"010167a67da82be2517428e7de6a422a502a7dbe","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  https://tools.ietf.org/pdf/draft-gross-geneve-02.pdf"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8c29a1c1a7c79e02c26ac9e2ad2645d30dfbeefc"},{"line_number":13,"context_line":"Closes-Bug: #1461069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5afe65bd_70d23002","line":13,"updated":"2015-06-03 11:23:41.000000000","message":"Sounds to me more like an RFE :)","commit_id":"f5a92d513b99b8107f2903bfad826ee8c732c437"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cf9e0297b4ac561d40e3a8ff0cde16d8ab891d3b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  https://tools.ietf.org/pdf/draft-gross-geneve-02.pdf"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8c29a1c1a7c79e02c26ac9e2ad2645d30dfbeefc"},{"line_number":13,"context_line":"Closes-Bug: #1461069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5afe65bd_5a4cee6f","line":13,"in_reply_to":"5afe65bd_27a23baf","updated":"2015-06-03 12:19:00.000000000","message":"Then just ignore me :) I didn\u0027t know about this agreement.","commit_id":"f5a92d513b99b8107f2903bfad826ee8c732c437"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"36f713c56975e828a1df583ab6884f8531698187","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  https://tools.ietf.org/pdf/draft-gross-geneve-02.pdf"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8c29a1c1a7c79e02c26ac9e2ad2645d30dfbeefc"},{"line_number":13,"context_line":"Closes-Bug: #1461069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5afe65bd_27a23baf","line":13,"in_reply_to":"5afe65bd_70d23002","updated":"2015-06-03 12:05:23.000000000","message":"I think there was an agreement that this can be handled as a bug, but if something has changed i can try the new process ;)","commit_id":"f5a92d513b99b8107f2903bfad826ee8c732c437"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ee2d6ba8859ab9b622c0f7227f1d89f140047c69","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gal Sagie \u003cgal.sagie@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-04 12:04:20 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Geneve type driver support to ML2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"More information about Geneve protocol can be found here:"},{"line_number":10,"context_line":"  https://tools.ietf.org/pdf/draft-gross-geneve-02.pdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_be916df3","line":7,"updated":"2015-06-04 09:12:11.000000000","message":"(perhaps out of change scope) Should we document the differences between each tunneling techno?","commit_id":"2c54ddb7a583e379154d5cf769c26653d2dab2a8"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"88202fac5a5db0dd90f2614a473d37f9eccd49be","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gal Sagie \u003cgal.sagie@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-04 12:04:20 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Geneve type driver support to ML2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"More information about Geneve protocol can be found here:"},{"line_number":10,"context_line":"  https://tools.ietf.org/pdf/draft-gross-geneve-02.pdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_c449f861","line":7,"in_reply_to":"5afe65bd_be916df3","updated":"2015-06-04 09:51:30.000000000","message":"I will work on that in another patch\nbut that sounds like a good addition","commit_id":"2c54ddb7a583e379154d5cf769c26653d2dab2a8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"474c4716d2b3d37e705f0fa366077190be30d463","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"More information about Geneve protocol can be found here:"},{"line_number":10,"context_line":"  https://tools.ietf.org/pdf/draft-gross-geneve-02.pdf"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8c29a1c1a7c79e02c26ac9e2ad2645d30dfbeefc"},{"line_number":13,"context_line":"Closes-Bug: #1461069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5afe65bd_5ecf1429","line":11,"updated":"2015-06-04 11:21:54.000000000","message":"Please add DocImpact and list the configuration variables that have been added","commit_id":"171eb26af821563cbf4dde9e2f5f796f9cd8aae9"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"c0d79f56595f1a7f87e0c46b2a83bb570e64acdd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"More information about Geneve protocol can be found here:"},{"line_number":10,"context_line":"  https://tools.ietf.org/pdf/draft-gross-geneve-02.pdf"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8c29a1c1a7c79e02c26ac9e2ad2645d30dfbeefc"},{"line_number":13,"context_line":"Closes-Bug: #1461069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5afe65bd_4123b5a7","line":11,"in_reply_to":"5afe65bd_5ecf1429","updated":"2015-06-04 11:29:06.000000000","message":"Done","commit_id":"171eb26af821563cbf4dde9e2f5f796f9cd8aae9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a591578dfcee3e6ee2a707528b7657393e178c23","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add Geneve type driver support to ML2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"More information about Geneve protocol can be found here:"},{"line_number":10,"context_line":"  https://tools.ietf.org/pdf/draft-gross-geneve-02.pdf"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Following configuration variables were added:"},{"line_number":13,"context_line":"[ml2_type_geneve]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"fa32b979_4688e922","line":10,"updated":"2015-06-15 02:50:00.000000000","message":"https://tools.ietf.org/pdf/draft-ietf-nvo3-geneve-00.pdf\nis better.\n\n(and i personally prefer text version than pdf but i guess it doesn\u0027t matter these days)","commit_id":"98bcc61621836db0e7597cc5a246ea3dccdf2acd"}],"doc/source/devref/openvswitch_agent.rst":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4e0a99a8494736b354c5f982b1a20711f27f781b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"It is important to note that currently it is only supported in"},{"line_number":33,"context_line":"newer kernels. (kernel \u003e\u003d 3.18, OVS version \u003e\u003d2.4)"},{"line_number":34,"context_line":"More information can be found in the `Geneve RFC document."},{"line_number":35,"context_line":"\u003chttps://tools.ietf.org/pdf/draft-gross-geneve-02.pdf\u003e`_"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Further Reading"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3afb71cf_1b0f6c38","line":35,"updated":"2015-06-09 10:48:46.000000000","message":"https://tools.ietf.org/html/draft-ietf-nvo3-geneve-00 is better","commit_id":"06c33021c61088661b75cf15b1854b452701313e"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"c53d743cc6bd8db1fa7e5ee98169fe873724346e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"It is important to note that currently it is only supported in"},{"line_number":33,"context_line":"newer kernels. (kernel \u003e\u003d 3.18, OVS version \u003e\u003d2.4)"},{"line_number":34,"context_line":"More information can be found in the `Geneve RFC document."},{"line_number":35,"context_line":"\u003chttps://tools.ietf.org/pdf/draft-gross-geneve-02.pdf\u003e`_"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Further Reading"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3afb71cf_ea7f18a9","line":35,"in_reply_to":"3afb71cf_1b0f6c38","updated":"2015-06-09 12:22:36.000000000","message":"Done","commit_id":"06c33021c61088661b75cf15b1854b452701313e"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"85e7de1b0050990f8767c4914e43f57880ac4ba6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"It is important to note that currently it is only supported in"},{"line_number":32,"context_line":"newer kernels. (kernel \u003e\u003d 3.18, OVS version \u003e\u003d2.4)"},{"line_number":33,"context_line":"More information can be found in the `Geneve RFC document."},{"line_number":34,"context_line":"\u003chttps://tools.ietf.org/html/draft-ietf-nvo3-geneve-00\u003e`_"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Further Reading"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa32b979_f1c6b215","line":34,"updated":"2015-06-13 02:16:51.000000000","message":"I think version 02 is the latest version.","commit_id":"b045cffbf6905acf6107a90a94f503e1f1f673cb"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"adfeae0d3c875f5523f8d00f99d5abda7f0b592d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"It is important to note that currently it is only supported in"},{"line_number":32,"context_line":"newer kernels. (kernel \u003e\u003d 3.18, OVS version \u003e\u003d2.4)"},{"line_number":33,"context_line":"More information can be found in the `Geneve RFC document."},{"line_number":34,"context_line":"\u003chttps://tools.ietf.org/html/draft-ietf-nvo3-geneve-00\u003e`_"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Further Reading"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fa32b979_a9ff5e33","line":34,"in_reply_to":"fa32b979_f1c6b215","updated":"2015-06-13 05:41:50.000000000","message":"If you look at https://datatracker.ietf.org/doc/draft-gross-geneve/\nwhich has 02 draft, it says its replaced by the above link.\n\nSo i believe this is the latest one, did you mean something else?","commit_id":"b045cffbf6905acf6107a90a94f503e1f1f673cb"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1fc66ca52ae00e3bc881b7e081fc918811ad7126","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Geneve uses UDP as its transport protocol and is dynamic"},{"line_number":41,"context_line":"in size using extensible option headers."},{"line_number":42,"context_line":"It is important to note that currently it is only supported in"},{"line_number":43,"context_line":"newer kernels. (kernel \u003e\u003d 3.18, OVS version \u003e\u003d2.4)"},{"line_number":44,"context_line":"More information can be found in the `Geneve RFC document."},{"line_number":45,"context_line":"\u003chttps://tools.ietf.org/html/draft-ietf-nvo3-geneve-00\u003e`_"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"fa32b979_9ea079f6","line":43,"updated":"2015-06-15 05:19:32.000000000","message":"When will the ovs be released?","commit_id":"98bcc61621836db0e7597cc5a246ea3dccdf2acd"}],"etc/neutron/plugins/ml2/ml2_conf.ini":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ee2d6ba8859ab9b622c0f7227f1d89f140047c69","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# (ListOpt) List of network type driver entrypoints to be loaded from"},{"line_number":3,"context_line":"# the neutron.ml2.type_drivers namespace."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# type_drivers \u003d local,flat,vlan,gre,vxlan,stt,geneve"},{"line_number":6,"context_line":"# Example: type_drivers \u003d flat,vlan,gre,vxlan,stt,geneve"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# (ListOpt) Ordered list of network_types to allocate as tenant"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5afe65bd_1e5d2179","line":5,"updated":"2015-06-04 09:12:11.000000000","message":"stt should be added in parent change","commit_id":"2c54ddb7a583e379154d5cf769c26653d2dab2a8"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"88202fac5a5db0dd90f2614a473d37f9eccd49be","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# (ListOpt) List of network type driver entrypoints to be loaded from"},{"line_number":3,"context_line":"# the neutron.ml2.type_drivers namespace."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# type_drivers \u003d local,flat,vlan,gre,vxlan,stt,geneve"},{"line_number":6,"context_line":"# Example: type_drivers \u003d flat,vlan,gre,vxlan,stt,geneve"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# (ListOpt) Ordered list of network_types to allocate as tenant"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5afe65bd_446ce8cf","line":5,"in_reply_to":"5afe65bd_1e5d2179","updated":"2015-06-04 09:51:30.000000000","message":"Done","commit_id":"2c54ddb7a583e379154d5cf769c26653d2dab2a8"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ee2d6ba8859ab9b622c0f7227f1d89f140047c69","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# the neutron.ml2.type_drivers namespace."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# type_drivers \u003d local,flat,vlan,gre,vxlan,stt,geneve"},{"line_number":6,"context_line":"# Example: type_drivers \u003d flat,vlan,gre,vxlan,stt,geneve"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# (ListOpt) Ordered list of network_types to allocate as tenant"},{"line_number":9,"context_line":"# networks. The default value \u0027local\u0027 is useful for single-box testing"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5afe65bd_9e4911ba","line":6,"updated":"2015-06-04 09:12:11.000000000","message":"itto","commit_id":"2c54ddb7a583e379154d5cf769c26653d2dab2a8"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"88202fac5a5db0dd90f2614a473d37f9eccd49be","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# the neutron.ml2.type_drivers namespace."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# type_drivers \u003d local,flat,vlan,gre,vxlan,stt,geneve"},{"line_number":6,"context_line":"# Example: type_drivers \u003d flat,vlan,gre,vxlan,stt,geneve"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# (ListOpt) Ordered list of network_types to allocate as tenant"},{"line_number":9,"context_line":"# networks. The default value \u0027local\u0027 is useful for single-box testing"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5afe65bd_2471eca8","line":6,"in_reply_to":"5afe65bd_9e4911ba","updated":"2015-06-04 09:51:30.000000000","message":"Done","commit_id":"2c54ddb7a583e379154d5cf769c26653d2dab2a8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4e0a99a8494736b354c5f982b1a20711f27f781b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"# this is the sum of the sizes of the outer ETH+IP+UDP+GENEVE"},{"line_number":112,"context_line":"# header sizes."},{"line_number":113,"context_line":"#"},{"line_number":114,"context_line":"# max_header_size \u003d"},{"line_number":115,"context_line":"# Example: max_header_size \u003d 50 (Geneve headers with no additional options)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"[securitygroup]"}],"source_content_type":"text/x-properties","patch_set":7,"id":"3afb71cf_fe3ebe26","line":114,"updated":"2015-06-09 10:48:46.000000000","message":"can you document the default?","commit_id":"06c33021c61088661b75cf15b1854b452701313e"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"c53d743cc6bd8db1fa7e5ee98169fe873724346e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"# this is the sum of the sizes of the outer ETH+IP+UDP+GENEVE"},{"line_number":112,"context_line":"# header sizes."},{"line_number":113,"context_line":"#"},{"line_number":114,"context_line":"# max_header_size \u003d"},{"line_number":115,"context_line":"# Example: max_header_size \u003d 50 (Geneve headers with no additional options)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"[securitygroup]"}],"source_content_type":"text/x-properties","patch_set":7,"id":"3afb71cf_ca7c5cb7","line":114,"in_reply_to":"3afb71cf_fe3ebe26","updated":"2015-06-09 12:22:36.000000000","message":"Done","commit_id":"06c33021c61088661b75cf15b1854b452701313e"}],"neutron/db/migration/alembic_migrations/versions/9388eb9e944_add_geneve_type_driver.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"2a5cebc6c9c1e807975bfbff01b2c3e5247b6d98","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        sa.PrimaryKeyConstraint(\u0027geneve_vni\u0027),"},{"line_number":40,"context_line":"    )"},{"line_number":41,"context_line":"    op.create_index(op.f(\u0027ix_ml2_geneve_allocations_allocated\u0027),"},{"line_number":42,"context_line":"                    \u0027ml2_geneve_allocations\u0027, [\u0027allocated\u0027], unique\u003dFalse)"},{"line_number":43,"context_line":"    op.create_table("},{"line_number":44,"context_line":"        \u0027ml2_geneve_endpoints\u0027,"},{"line_number":45,"context_line":"        sa.Column(\u0027ip_address\u0027, sa.String(length\u003d64), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_30f278d3","line":42,"updated":"2015-06-03 12:44:17.000000000","message":"you can add index by \"index\u003dTrue\" in columns parameters.","commit_id":"f5a92d513b99b8107f2903bfad826ee8c732c437"}],"neutron/db/migration/alembic_migrations/versions/liberty/contract/46d5732df460_add_ml2_geneve_type_driver.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"e20c69cd4252190ed27863155756b2557a25db2f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"empty message"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: 46d5732df460"},{"line_number":19,"context_line":"Revises: 2e5352a0ad4d"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa1b9901_f03121a3","line":16,"updated":"2015-08-26 07:06:11.000000000","message":"Please, revert to \"add geneve ml2 type driver\"","commit_id":"1e17b132a944c6b6c50608610beca81489c8be79"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"4df918a78bbb26bb4860641a09eeae601d7ee968","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"empty message"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: 46d5732df460"},{"line_number":19,"context_line":"Revises: 2e5352a0ad4d"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa1b9901_e131510c","line":16,"in_reply_to":"fa1b9901_f03121a3","updated":"2015-08-26 08:34:30.000000000","message":"Done","commit_id":"1e17b132a944c6b6c50608610beca81489c8be79"}],"neutron/plugins/ml2/drivers/type_geneve.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"474c4716d2b3d37e705f0fa366077190be30d463","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        try:"},{"line_number":87,"context_line":"            self._initialize(cfg.CONF.ml2_type_geneve.vni_ranges)"},{"line_number":88,"context_line":"        except n_exc.NetworkTunnelRangeError:"},{"line_number":89,"context_line":"            LOG.exception(_LE(\"Failed to parse vni_ranges. \""},{"line_number":90,"context_line":"                              \"Service terminated!\"))"},{"line_number":91,"context_line":"            raise SystemExit()"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_bef72858","line":89,"updated":"2015-06-04 11:21:54.000000000","message":"I am not sure the exception trace here is useful. Can we use LOG.error?","commit_id":"171eb26af821563cbf4dde9e2f5f796f9cd8aae9"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"c0d79f56595f1a7f87e0c46b2a83bb570e64acdd","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        try:"},{"line_number":87,"context_line":"            self._initialize(cfg.CONF.ml2_type_geneve.vni_ranges)"},{"line_number":88,"context_line":"        except n_exc.NetworkTunnelRangeError:"},{"line_number":89,"context_line":"            LOG.exception(_LE(\"Failed to parse vni_ranges. \""},{"line_number":90,"context_line":"                              \"Service terminated!\"))"},{"line_number":91,"context_line":"            raise SystemExit()"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_01ddbd6e","line":89,"in_reply_to":"5afe65bd_bef72858","updated":"2015-06-04 11:29:06.000000000","message":"Done","commit_id":"171eb26af821563cbf4dde9e2f5f796f9cd8aae9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"474c4716d2b3d37e705f0fa366077190be30d463","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                  not alloc.allocated)]"},{"line_number":118,"context_line":"            # Immediately delete vnis in chunks. This leaves no work for"},{"line_number":119,"context_line":"            # flush at the end of transaction"},{"line_number":120,"context_line":"            bulk_size \u003d 100"},{"line_number":121,"context_line":"            chunked_vnis \u003d (vnis_to_remove[i:i + bulk_size] for i in"},{"line_number":122,"context_line":"                            range(0, len(vnis_to_remove), bulk_size))"},{"line_number":123,"context_line":"            for vni_list in chunked_vnis:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_dea8a422","line":120,"updated":"2015-06-04 11:21:54.000000000","message":"i am not sure what we need this - having said that i am not at all familiar with this protocol and its implementations","commit_id":"171eb26af821563cbf4dde9e2f5f796f9cd8aae9"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"c0d79f56595f1a7f87e0c46b2a83bb570e64acdd","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                  not alloc.allocated)]"},{"line_number":118,"context_line":"            # Immediately delete vnis in chunks. This leaves no work for"},{"line_number":119,"context_line":"            # flush at the end of transaction"},{"line_number":120,"context_line":"            bulk_size \u003d 100"},{"line_number":121,"context_line":"            chunked_vnis \u003d (vnis_to_remove[i:i + bulk_size] for i in"},{"line_number":122,"context_line":"                            range(0, len(vnis_to_remove), bulk_size))"},{"line_number":123,"context_line":"            for vni_list in chunked_vnis:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5afe65bd_81f08dff","line":120,"in_reply_to":"5afe65bd_dea8a422","updated":"2015-06-04 11:29:06.000000000","message":"This is not related to the protocol, this just sync the allocated VNI\u0027s (which is the same for vxlan and stt as well)\n\nThis is why the TODO comment in the start as this code can be shared (and is similar to all these type drivers)","commit_id":"171eb26af821563cbf4dde9e2f5f796f9cd8aae9"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f6acc89fd2c599b7ff4ed76f49c75f42d23e0c4d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # can refactor common code"},{"line_number":96,"context_line":"        geneve_vnis \u003d set()"},{"line_number":97,"context_line":"        for tun_min, tun_max in self.tunnel_ranges:"},{"line_number":98,"context_line":"            if tun_max + 1 - tun_min \u003e p_const.MAX_GENEVE_VNI:"},{"line_number":99,"context_line":"                LOG.error(_LE(\"Skipping unreasonable GENEVE VNI range \""},{"line_number":100,"context_line":"                              \"%(tun_min)s:%(tun_max)s\"),"},{"line_number":101,"context_line":"                          {\u0027tun_min\u0027: tun_min, \u0027tun_max\u0027: tun_max})"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af86dd1_8969348e","line":98,"updated":"2015-06-12 19:39:39.000000000","message":"This check is already done in TunnelTypeDriver._parse_tunnel_range","commit_id":"b045cffbf6905acf6107a90a94f503e1f1f673cb"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"9fe4c8a9c8dcbb871f154bcb99763f734b6ae28f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        # can refactor common code"},{"line_number":96,"context_line":"        geneve_vnis \u003d set()"},{"line_number":97,"context_line":"        for tun_min, tun_max in self.tunnel_ranges:"},{"line_number":98,"context_line":"            if tun_max + 1 - tun_min \u003e p_const.MAX_GENEVE_VNI:"},{"line_number":99,"context_line":"                LOG.error(_LE(\"Skipping unreasonable GENEVE VNI range \""},{"line_number":100,"context_line":"                              \"%(tun_min)s:%(tun_max)s\"),"},{"line_number":101,"context_line":"                          {\u0027tun_min\u0027: tun_min, \u0027tun_max\u0027: tun_max})"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa32b979_49581257","line":98,"in_reply_to":"1af86dd1_8969348e","updated":"2015-06-13 05:55:24.000000000","message":"this check is not done for Geneve as i didn\u0027t add its validations methods in plugins/common/utils.py.\nI will add this in the next commit.\n\nAlso, this is the same code in VXLAN, so maybe it should be \"fixed\" in next patch for all of the tunnels","commit_id":"b045cffbf6905acf6107a90a94f503e1f1f673cb"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a591578dfcee3e6ee2a707528b7657393e178c23","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            raise SystemExit()"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def sync_allocations(self):"},{"line_number":94,"context_line":"        # TODO(gsagie) this method is the same for vxlan/stt/geneve"},{"line_number":95,"context_line":"        # can refactor common code"},{"line_number":96,"context_line":"        geneve_vnis \u003d set()"},{"line_number":97,"context_line":"        for tun_min, tun_max in self.tunnel_ranges:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa32b979_e6e49d0e","line":94,"range":{"start_line":94,"start_character":57,"end_line":94,"end_character":60},"updated":"2015-06-15 02:50:00.000000000","message":"stt is not there yet but probably ok.","commit_id":"98bcc61621836db0e7597cc5a246ea3dccdf2acd"}],"neutron/tests/unit/plugins/ml2/drivers/test_type_geneve.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3475aebe13a2b3bebb1cd4e68655a75228294c66","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        ip_endpoint \u003d self.driver.get_endpoint_by_host(HOST_TWO)"},{"line_number":58,"context_line":"        self.assertIsNone(ip_endpoint)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_get_endpoint_by_ip(self):"},{"line_number":61,"context_line":"        self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        ip_endpoint \u003d self.driver.get_endpoint_by_ip(TUNNEL_IP_ONE)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_7609eadc","line":60,"updated":"2015-06-08 22:26:38.000000000","message":"can you adapt unit tests after commit I13b0507991e840ff34de7ed7ffd31d359691b0ca ?","commit_id":"b33389b769872016f093981224e384a335c0630b"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"4e653f6aa1688b3f8ad73f95368c55470dacd1b7","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        ip_endpoint \u003d self.driver.get_endpoint_by_host(HOST_TWO)"},{"line_number":58,"context_line":"        self.assertIsNone(ip_endpoint)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def test_get_endpoint_by_ip(self):"},{"line_number":61,"context_line":"        self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        ip_endpoint \u003d self.driver.get_endpoint_by_ip(TUNNEL_IP_ONE)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afb71cf_1d9d2e59","line":60,"in_reply_to":"3afb71cf_7609eadc","updated":"2015-06-09 04:48:17.000000000","message":"Done","commit_id":"b33389b769872016f093981224e384a335c0630b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"7d0ce3131d0bb3285b738a5acaadda492a1c4935","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    DRIVER_CLASS \u003d type_geneve.GeneveTypeDriver"},{"line_number":36,"context_line":"    TYPE \u003d p_const.TYPE_GENEVE"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_add_endpoint(self):"},{"line_number":39,"context_line":"        endpoint \u003d self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE)"},{"line_number":40,"context_line":"        self.assertEqual(TUNNEL_IP_ONE, endpoint.ip_address)"},{"line_number":41,"context_line":"        self.assertEqual(HOST_ONE, endpoint.host)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af86dd1_1290f2eb","line":38,"updated":"2015-06-12 00:22:16.000000000","message":"nit: these tests can be removed as they are now in base_type_tunnel. Check out what i did  in my latest patch set here.","commit_id":"b045cffbf6905acf6107a90a94f503e1f1f673cb"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"9b3dab18dd3e6c22ca71af9b136a452bf2c70d17","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    DRIVER_CLASS \u003d type_geneve.GeneveTypeDriver"},{"line_number":36,"context_line":"    TYPE \u003d p_const.TYPE_GENEVE"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_add_endpoint(self):"},{"line_number":39,"context_line":"        endpoint \u003d self.driver.add_endpoint(TUNNEL_IP_ONE, HOST_ONE)"},{"line_number":40,"context_line":"        self.assertEqual(TUNNEL_IP_ONE, endpoint.ip_address)"},{"line_number":41,"context_line":"        self.assertEqual(HOST_ONE, endpoint.host)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af86dd1_21f93e81","line":38,"in_reply_to":"1af86dd1_1290f2eb","updated":"2015-06-12 17:46:25.000000000","message":"Done","commit_id":"b045cffbf6905acf6107a90a94f503e1f1f673cb"}]}
