)]}'
{"quantum/db/l3_db.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"0eec434357305d2582ab6a201fae04bc630632e9","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                                          filters\u003dfilters)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def _check_for_dup_router_subnet(self, context, router_id,"},{"line_number":266,"context_line":"                                     network_id, subnet_id, subnet_cidr\u003dNone):"},{"line_number":267,"context_line":"        try:"},{"line_number":268,"context_line":"            rport_qry \u003d context.session.query(models_v2.Port)"},{"line_number":269,"context_line":"            rports \u003d rport_qry.filter_by("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F1Wc%3D","line":266,"updated":"2013-01-03 03:00:09.000000000","message":"based on your description of the bug, does this mean that this function has different requirements about what the context must be based on whether or not subnet_cidr is None?  That seems pretty tricky for someone who comes back to the code later.  \n\nIt seems like 2/3 invocations of _check_for_dup_router() could easily pass in the cidr, so would it be reasonable to just make subnet_cidr required, and have the one extra call do a one liner to fetch the right value of subnet_cidr?","commit_id":"3ea438211f6ab59676c085d2adcb55332dd8c7ce"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":263,"context_line":"                                          filters\u003dfilters)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def _check_for_dup_router_subnet(self, context, router_id,"},{"line_number":266,"context_line":"                                     network_id, subnet_id, subnet_cidr\u003dNone):"},{"line_number":267,"context_line":"        try:"},{"line_number":268,"context_line":"            rport_qry \u003d context.session.query(models_v2.Port)"},{"line_number":269,"context_line":"            rports \u003d rport_qry.filter_by("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F008%3D","line":266,"in_reply_to":"AAAAM3%2F%2F1Wc%3D","updated":"2013-01-03 16:24:14.000000000","message":"totally agree with you. I wanted to keep the diff as short as possible, so I went for this approach.\n\nChanging the remaining two points in which this routine is invoked is 10 times better.","commit_id":"3ea438211f6ab59676c085d2adcb55332dd8c7ce"}],"quantum/tests/unit/test_db_plugin.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"0eec434357305d2582ab6a201fae04bc630632e9","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        req \u003d self.new_update_request(resource, new_data, id)"},{"line_number":385,"context_line":"        if context:"},{"line_number":386,"context_line":"            # create a specific auth context for this request"},{"line_number":387,"context_line":"            req.environ[\u0027quantum.context\u0027] \u003d context"},{"line_number":388,"context_line":"        res \u003d req.get_response(self._api_for_resource(resource))"},{"line_number":389,"context_line":"        self.assertEqual(res.status_int, expected_code)"},{"line_number":390,"context_line":"        return self.deserialize(\u0027json\u0027, res)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F1WU%3D","line":387,"updated":"2013-01-03 03:00:09.000000000","message":"this is probably generally useful for all of the _delete, _show, _update, and _list commands, as well as the creates.  Assuming its simple, for consistency, I\u0027d think about adding it to each, rather than having someone solve the problem slightly differently when they latter find out they need to set the context of a delete request.","commit_id":"3ea438211f6ab59676c085d2adcb55332dd8c7ce"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":384,"context_line":"        req \u003d self.new_update_request(resource, new_data, id)"},{"line_number":385,"context_line":"        if context:"},{"line_number":386,"context_line":"            # create a specific auth context for this request"},{"line_number":387,"context_line":"            req.environ[\u0027quantum.context\u0027] \u003d context"},{"line_number":388,"context_line":"        res \u003d req.get_response(self._api_for_resource(resource))"},{"line_number":389,"context_line":"        self.assertEqual(res.status_int, expected_code)"},{"line_number":390,"context_line":"        return self.deserialize(\u0027json\u0027, res)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F004%3D","line":387,"in_reply_to":"AAAAM3%2F%2F1WU%3D","updated":"2013-01-03 16:24:14.000000000","message":"My answer to this comment is exactly the same as the previous one!\n\nI\u0027ll do that.","commit_id":"3ea438211f6ab59676c085d2adcb55332dd8c7ce"}],"quantum/tests/unit/test_l3_plugin.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"0eec434357305d2582ab6a201fae04bc630632e9","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    def _make_router(self, fmt, tenant_id, name\u003dNone,"},{"line_number":314,"context_line":"                     admin_state_up\u003dNone, set_context\u003dFalse):"},{"line_number":315,"context_line":"        res \u003d self._create_router(fmt, tenant_id, name,"},{"line_number":316,"context_line":"                                  admin_state_up, set_context)"},{"line_number":317,"context_line":"        return self.deserialize(fmt, res)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def _add_external_gateway_to_router(self, router_id, network_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F1WQ%3D","line":316,"updated":"2013-01-03 03:00:09.000000000","message":"similar comment about consistency here.","commit_id":"3ea438211f6ab59676c085d2adcb55332dd8c7ce"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":313,"context_line":"    def _make_router(self, fmt, tenant_id, name\u003dNone,"},{"line_number":314,"context_line":"                     admin_state_up\u003dNone, set_context\u003dFalse):"},{"line_number":315,"context_line":"        res \u003d self._create_router(fmt, tenant_id, name,"},{"line_number":316,"context_line":"                                  admin_state_up, set_context)"},{"line_number":317,"context_line":"        return self.deserialize(fmt, res)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def _add_external_gateway_to_router(self, router_id, network_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2F000%3D","line":316,"in_reply_to":"AAAAM3%2F%2F1WQ%3D","updated":"2013-01-03 16:24:14.000000000","message":"similar answer about diff size here.","commit_id":"3ea438211f6ab59676c085d2adcb55332dd8c7ce"}]}