)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"903fc9bd1250aee75225a3d6db391505cdc54f06","unresolved":false,"context_lines":[{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":"APIImpact"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Authored-By: Numan Siddique \u003cnusiddiq@redhat.com\u003e"},{"line_number":19,"context_line":"Change-Id: Icabdd22577cfda0e1fbf6042e4b05b8080e54fdb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa32b979_0142a110","line":18,"updated":"2015-06-15 21:18:15.000000000","message":"+1 Let\u0027s make sure we recognize all co-authors","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"2b8199f546d47e7c5f32ec0b6570483b7dcc681e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":"APIImpact"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Authored-By: Numan Siddique \u003cnusiddiq@redhat.com\u003e"},{"line_number":19,"context_line":"Change-Id: Icabdd22577cfda0e1fbf6042e4b05b8080e54fdb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa32b979_02d4d444","line":18,"in_reply_to":"fa32b979_0142a110","updated":"2015-06-16 06:31:22.000000000","message":"Sure. I will check with Vikram if there are other contributors :) to this patch before I pitched in.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"950c815ea68593a75dfd58b93e6701845ce27df5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Subsequent patches will be added to use this address scope"},{"line_number":11,"context_line":"on subnet pools."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"(Work in progress: api tests)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa32b979_56836dcc","line":13,"updated":"2015-06-23 03:29:16.000000000","message":"Is your plan to put those in this same change?  If not, I think we can remove this and post a follow-on for the API tests.","commit_id":"a16000ca5503687dc2f562ed2572659b893c1218"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"26217a6b1f7f1fd8fc4929d9573c4650d50820dd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Subsequent patches will be added to use this address scope"},{"line_number":11,"context_line":"on subnet pools."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"(Work in progress: api tests)"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa32b979_b1820351","line":13,"in_reply_to":"fa32b979_56836dcc","updated":"2015-06-23 04:24:03.000000000","message":"I agree. I will remove this and have a follow up patch.","commit_id":"a16000ca5503687dc2f562ed2572659b893c1218"}],"etc/policy.json":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e69c33d0368638dd908396e7d980933716f967f7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"update_subnetpool\": \"rule:admin_or_owner\","},{"line_number":25,"context_line":"    \"delete_subnetpool\": \"rule:admin_or_owner\","},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"create_addrscope\": \"\","},{"line_number":28,"context_line":"    \"create_addrscope:shared\": \"rule:admin_only\","},{"line_number":29,"context_line":"    \"get_addrscope\": \"rule:admin_or_owner or rule:shared_addrscopes\","},{"line_number":30,"context_line":"    \"update_addrscope\": \"rule:admin_or_owner\","}],"source_content_type":"application/json","patch_set":1,"id":"3afb71cf_95eae772","line":27,"updated":"2015-06-10 19:33:01.000000000","message":"Any reason to abbreviate addressscopes?  The \"sss\"?  :)  How about:\n\n  create_address_scope\n\nIt makes me wish that we had used subnet_pool instead of subnetpool but that ship has sailed.","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"d1052cc9ce248a424fedc695f7ecfd20a3026af0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"update_subnetpool\": \"rule:admin_or_owner\","},{"line_number":25,"context_line":"    \"delete_subnetpool\": \"rule:admin_or_owner\","},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"create_addrscope\": \"\","},{"line_number":28,"context_line":"    \"create_addrscope:shared\": \"rule:admin_only\","},{"line_number":29,"context_line":"    \"get_addrscope\": \"rule:admin_or_owner or rule:shared_addrscopes\","},{"line_number":30,"context_line":"    \"update_addrscope\": \"rule:admin_or_owner\","}],"source_content_type":"application/json","patch_set":1,"id":"fa32b979_41ba13e3","line":27,"in_reply_to":"3afb71cf_95eae772","updated":"2015-06-15 03:41:51.000000000","message":"+1, consider using address_scope.  The guy that gave us subnetpool instead of subnet_pool needs a stern talking-to :)","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"cc095a4d8cd54aca5fa7017f2185678ca428201f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"update_subnetpool\": \"rule:admin_or_owner\","},{"line_number":25,"context_line":"    \"delete_subnetpool\": \"rule:admin_or_owner\","},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \"create_addrscope\": \"\","},{"line_number":28,"context_line":"    \"create_addrscope:shared\": \"rule:admin_only\","},{"line_number":29,"context_line":"    \"get_addrscope\": \"rule:admin_or_owner or rule:shared_addrscopes\","},{"line_number":30,"context_line":"    \"update_addrscope\": \"rule:admin_or_owner\","}],"source_content_type":"application/json","patch_set":1,"id":"fa32b979_54d70c23","line":27,"in_reply_to":"fa32b979_41ba13e3","updated":"2015-06-15 20:22:55.000000000","message":"We share that responsibility.  I took it on when I +2ed the change.","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d7f58f2aa2026a5472ed2602d150b58045ba8850","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \"shared_firewalls\": \"field:firewalls:shared\u003dTrue\","},{"line_number":10,"context_line":"    \"shared_firewall_policies\": \"field:firewall_policies:shared\u003dTrue\","},{"line_number":11,"context_line":"    \"shared_subnetpools\": \"field:subnetpools:shared\u003dTrue\","},{"line_number":12,"context_line":"    \"shared_address_scopes\": \"field:address_scopes:shared\u003dTrue\","},{"line_number":13,"context_line":"    \"external\": \"field:networks:router:external\u003dTrue\","},{"line_number":14,"context_line":"    \"default\": \"rule:admin_or_owner\","},{"line_number":15,"context_line":""}],"source_content_type":"application/json","patch_set":7,"id":"fa32b979_1d8e2b2e","line":12,"updated":"2015-06-24 05:22:10.000000000","message":"Do you want to rename it as \"shared_addressscopes\"? Check at other places.","commit_id":"1be86aaece83c0850fd9c2e31c72b0aed7b1bc6b"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"bd5939cd2dc639c8cb1db5d66ce6b7f4bf8e5ba8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \"shared_firewalls\": \"field:firewalls:shared\u003dTrue\","},{"line_number":10,"context_line":"    \"shared_firewall_policies\": \"field:firewall_policies:shared\u003dTrue\","},{"line_number":11,"context_line":"    \"shared_subnetpools\": \"field:subnetpools:shared\u003dTrue\","},{"line_number":12,"context_line":"    \"shared_address_scopes\": \"field:address_scopes:shared\u003dTrue\","},{"line_number":13,"context_line":"    \"external\": \"field:networks:router:external\u003dTrue\","},{"line_number":14,"context_line":"    \"default\": \"rule:admin_or_owner\","},{"line_number":15,"context_line":""}],"source_content_type":"application/json","patch_set":7,"id":"fa32b979_c3b0e0ff","line":12,"in_reply_to":"fa32b979_0896e7ef","updated":"2015-06-24 07:18:51.000000000","message":"IMO, \u0027address_scope\u0027 is fine","commit_id":"1be86aaece83c0850fd9c2e31c72b0aed7b1bc6b"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"a6bb670ac8a56ce3a3d8ce94c6267b791ddaa4f2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \"shared_firewalls\": \"field:firewalls:shared\u003dTrue\","},{"line_number":10,"context_line":"    \"shared_firewall_policies\": \"field:firewall_policies:shared\u003dTrue\","},{"line_number":11,"context_line":"    \"shared_subnetpools\": \"field:subnetpools:shared\u003dTrue\","},{"line_number":12,"context_line":"    \"shared_address_scopes\": \"field:address_scopes:shared\u003dTrue\","},{"line_number":13,"context_line":"    \"external\": \"field:networks:router:external\u003dTrue\","},{"line_number":14,"context_line":"    \"default\": \"rule:admin_or_owner\","},{"line_number":15,"context_line":""}],"source_content_type":"application/json","patch_set":7,"id":"fa32b979_0896e7ef","line":12,"in_reply_to":"fa32b979_1d8e2b2e","updated":"2015-06-24 06:20:38.000000000","message":"Based on the comments from Carl and Ryan, I changed the name to \"address_scope\" \n\nhttps://review.openstack.org/#/c/189741/1/neutron/api/v2/attributes.py\nhttps://review.openstack.org/#/c/189741/1/etc/policy.json\n\nI am a bit confused on to use \"addressscope\" or \"address_scope\". I would prefer  the latter.","commit_id":"1be86aaece83c0850fd9c2e31c72b0aed7b1bc6b"}],"neutron/api/v2/attributes.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e69c33d0368638dd908396e7d980933716f967f7","unresolved":false,"context_lines":[{"line_number":614,"context_line":"SUBNETS \u003d \u0027%ss\u0027 % SUBNET"},{"line_number":615,"context_line":"SUBNETPOOL \u003d \u0027subnetpool\u0027"},{"line_number":616,"context_line":"SUBNETPOOLS \u003d \u0027%ss\u0027 % SUBNETPOOL"},{"line_number":617,"context_line":"ADDRSCOPE \u003d \u0027addrscope\u0027"},{"line_number":618,"context_line":"ADDRSCOPES \u003d \u0027%ss\u0027 % ADDRSCOPE"},{"line_number":619,"context_line":"# Note: a default of ATTR_NOT_SPECIFIED indicates that an"},{"line_number":620,"context_line":"# attribute is not required, but will be generated by the plugin"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_75b2cb95","line":617,"updated":"2015-06-10 19:33:01.000000000","message":"I think the abbreviation of address scopes is a common theme.  How about:\n\nADDRESS_SCOPES \u003d \u0027address_scope\u0027","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"d1052cc9ce248a424fedc695f7ecfd20a3026af0","unresolved":false,"context_lines":[{"line_number":614,"context_line":"SUBNETS \u003d \u0027%ss\u0027 % SUBNET"},{"line_number":615,"context_line":"SUBNETPOOL \u003d \u0027subnetpool\u0027"},{"line_number":616,"context_line":"SUBNETPOOLS \u003d \u0027%ss\u0027 % SUBNETPOOL"},{"line_number":617,"context_line":"ADDRSCOPE \u003d \u0027addrscope\u0027"},{"line_number":618,"context_line":"ADDRSCOPES \u003d \u0027%ss\u0027 % ADDRSCOPE"},{"line_number":619,"context_line":"# Note: a default of ATTR_NOT_SPECIFIED indicates that an"},{"line_number":620,"context_line":"# attribute is not required, but will be generated by the plugin"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_61bf17d1","line":617,"in_reply_to":"3afb71cf_75b2cb95","updated":"2015-06-15 03:41:51.000000000","message":"+1","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"d1052cc9ce248a424fedc695f7ecfd20a3026af0","unresolved":false,"context_lines":[{"line_number":835,"context_line":"                       \u0027validate\u0027: {\u0027type:non_negative\u0027: None},"},{"line_number":836,"context_line":"                       \u0027convert_to\u0027: convert_to_int,"},{"line_number":837,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":838,"context_line":"        \u0027addrscope_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":839,"context_line":"                      \u0027allow_put\u0027: False,"},{"line_number":840,"context_line":"                      \u0027default\u0027: ATTR_NOT_SPECIFIED,"},{"line_number":841,"context_line":"                      \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_21b58fcc","line":838,"updated":"2015-06-15 03:41:51.000000000","message":"Again, I\u0027d suggest constraining the scope of this patch to CRUD on the address_scope entity and introducing address_scope_id to subnetpools in a different patch.","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e69c33d0368638dd908396e7d980933716f967f7","unresolved":false,"context_lines":[{"line_number":836,"context_line":"                       \u0027convert_to\u0027: convert_to_int,"},{"line_number":837,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":838,"context_line":"        \u0027addrscope_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":839,"context_line":"                      \u0027allow_put\u0027: False,"},{"line_number":840,"context_line":"                      \u0027default\u0027: ATTR_NOT_SPECIFIED,"},{"line_number":841,"context_line":"                      \u0027is_visible\u0027: True},"},{"line_number":842,"context_line":"        SHARED: {\u0027allow_post\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_555d8f45","line":839,"updated":"2015-06-10 19:33:01.000000000","message":"I\u0027d prefer not to perpetuate the funny indentation here.  Looks like the precedent started at L821 but can we go back to indenting like before L821?\n\nIn other words, indent these lines two more spaces.","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e69c33d0368638dd908396e7d980933716f967f7","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                      \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":863,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":864,"context_line":"                      \u0027is_visible\u0027: True},"},{"line_number":865,"context_line":"        SHARED: {\u0027allow_post\u0027: True,"},{"line_number":866,"context_line":"                 \u0027allow_put\u0027: False,"},{"line_number":867,"context_line":"                 \u0027default\u0027: False,"},{"line_number":868,"context_line":"                 \u0027convert_to\u0027: convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_98221ea2","line":865,"updated":"2015-06-10 19:33:01.000000000","message":"I don\u0027t think we\u0027ll have the concept of a shared address scope.  If anything, it could be shared for reading.  So, maybe it is useful.  I also think that maybe other tenants don\u0027t need to know about address scopes owned by admin.  Thoughts?","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"d1052cc9ce248a424fedc695f7ecfd20a3026af0","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                      \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":863,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":864,"context_line":"                      \u0027is_visible\u0027: True},"},{"line_number":865,"context_line":"        SHARED: {\u0027allow_post\u0027: True,"},{"line_number":866,"context_line":"                 \u0027allow_put\u0027: False,"},{"line_number":867,"context_line":"                 \u0027default\u0027: False,"},{"line_number":868,"context_line":"                 \u0027convert_to\u0027: convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_e1a00793","line":865,"in_reply_to":"3afb71cf_98221ea2","updated":"2015-06-15 03:41:51.000000000","message":"Consider the use case of an operator with globally routable address space.  This address space should be managed by the operator.  I could imagine an operator creating a shared address_scope and communicating to tenants that subnets will only be routable when allocated from subnet pools in this address scope.  The address_scope is owned by the operator, but would be read-only for tenants.\n\nNow consider a tenant who has test/dev workloads and wants to simulate a production environment.  That tenant could create a couple of address scopes that act as sandboxes for their work.  These address scopes are tenant-owned, but would not be shared.\n\nI think \u0027shared\u0027 is a useful attribute.  Perhaps it complicates the solution for making routers scope-aware, but I see real use cases for both shared and un-shared address scopes.","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"fbc9d81e5f0373b6825a430e32904364d1350977","unresolved":false,"context_lines":[{"line_number":862,"context_line":"                      \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":863,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":864,"context_line":"                      \u0027is_visible\u0027: True},"},{"line_number":865,"context_line":"        SHARED: {\u0027allow_post\u0027: True,"},{"line_number":866,"context_line":"                 \u0027allow_put\u0027: False,"},{"line_number":867,"context_line":"                 \u0027default\u0027: False,"},{"line_number":868,"context_line":"                 \u0027convert_to\u0027: convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f4abc087","line":865,"in_reply_to":"fa32b979_e1a00793","updated":"2015-06-15 20:29:21.000000000","message":"You sold me.  Good example.  I think it is valuable for tenants to be able to read a shared address scope.","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"903fc9bd1250aee75225a3d6db391505cdc54f06","unresolved":false,"context_lines":[{"line_number":859,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":860,"context_line":"                      \u0027is_visible\u0027: True},"},{"line_number":861,"context_line":"        SHARED: {\u0027allow_post\u0027: True,"},{"line_number":862,"context_line":"                 \u0027allow_put\u0027: False,"},{"line_number":863,"context_line":"                 \u0027default\u0027: False,"},{"line_number":864,"context_line":"                 \u0027convert_to\u0027: convert_to_boolean,"},{"line_number":865,"context_line":"                 \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_8f2b3d94","line":862,"updated":"2015-06-15 21:18:15.000000000","message":"I wonder if there is value in allowing an address scope to flip from unshared to shared.  Certainly going from shared to unshared is not so clean once the address scope starts getting used, but being able to take an unshared scope and make it shared might be useful. I don\u0027t see too many pitfalls in turning an address scope into a shared address scope.  Going from shared to unshared requires more thought and may just lead us back to this solution.  Just some food for thought....","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"012927cf0d615ce9cc7ebf1bf59fe3b1b97809a0","unresolved":false,"context_lines":[{"line_number":859,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":860,"context_line":"                      \u0027is_visible\u0027: True},"},{"line_number":861,"context_line":"        SHARED: {\u0027allow_post\u0027: True,"},{"line_number":862,"context_line":"                 \u0027allow_put\u0027: False,"},{"line_number":863,"context_line":"                 \u0027default\u0027: False,"},{"line_number":864,"context_line":"                 \u0027convert_to\u0027: convert_to_boolean,"},{"line_number":865,"context_line":"                 \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_9ed7dcbe","line":862,"updated":"2015-06-16 09:23:49.000000000","message":"well you can always enforce constraints on going from shared back to unshared in the code.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fd2f1e375558797bec9a9813d4433d992dfe1f35","unresolved":false,"context_lines":[{"line_number":859,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":860,"context_line":"                      \u0027is_visible\u0027: True},"},{"line_number":861,"context_line":"        SHARED: {\u0027allow_post\u0027: True,"},{"line_number":862,"context_line":"                 \u0027allow_put\u0027: False,"},{"line_number":863,"context_line":"                 \u0027default\u0027: False,"},{"line_number":864,"context_line":"                 \u0027convert_to\u0027: convert_to_boolean,"},{"line_number":865,"context_line":"                 \u0027is_visible\u0027: True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_b6644422","line":862,"in_reply_to":"fa32b979_9ed7dcbe","updated":"2015-06-16 10:47:08.000000000","message":"agree that we can switch an address scope from unshared to shared safely. Switching to unshared may require more checks like checking who uses it. Note that it can be deferred to the later patches and can be out of scope in the initial implementation.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"}],"neutron/api/v2/router.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"eeebbde0e89790f802755e961674f0fd04464c42","unresolved":false,"context_lines":[{"line_number":36,"context_line":"RESOURCES \u003d {\u0027network\u0027: \u0027networks\u0027,"},{"line_number":37,"context_line":"             \u0027subnet\u0027: \u0027subnets\u0027,"},{"line_number":38,"context_line":"             \u0027subnetpool\u0027: \u0027subnetpools\u0027,"},{"line_number":39,"context_line":"             \u0027address_scope\u0027: \u0027address_scopes\u0027,"},{"line_number":40,"context_line":"             \u0027port\u0027: \u0027ports\u0027}"},{"line_number":41,"context_line":"SUB_RESOURCES \u003d {}"},{"line_number":42,"context_line":"COLLECTION_ACTIONS \u003d [\u0027index\u0027, \u0027create\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_74fd7039","line":39,"updated":"2015-06-15 20:36:53.000000000","message":"I\u0027d like to get @Salvatore\u0027s thoughts on adding this again to the core API.  This is following the pattern set by subnet pools, which makes sense to me.  But, I don\u0027t fully know the future of the API.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"012927cf0d615ce9cc7ebf1bf59fe3b1b97809a0","unresolved":false,"context_lines":[{"line_number":36,"context_line":"RESOURCES \u003d {\u0027network\u0027: \u0027networks\u0027,"},{"line_number":37,"context_line":"             \u0027subnet\u0027: \u0027subnets\u0027,"},{"line_number":38,"context_line":"             \u0027subnetpool\u0027: \u0027subnetpools\u0027,"},{"line_number":39,"context_line":"             \u0027address_scope\u0027: \u0027address_scopes\u0027,"},{"line_number":40,"context_line":"             \u0027port\u0027: \u0027ports\u0027}"},{"line_number":41,"context_line":"SUB_RESOURCES \u003d {}"},{"line_number":42,"context_line":"COLLECTION_ACTIONS \u003d [\u0027index\u0027, \u0027create\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_7edc58e4","line":39,"updated":"2015-06-16 09:23:49.000000000","message":"Is this something that comes for free if a plugin inherits from db_base_plugin_v2? If not, I don\u0027t think the the core API is a great place for it because many of the plugins will just  explode when you try to use the feature. As an extension, support would be discoverable via the ext-list command in the client.\n\nIMO, having broken things in the core API sort of defeats the purpose of the core API.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1a07a97ce2bc118bc29c3aae740652d8161b4afd","unresolved":false,"context_lines":[{"line_number":36,"context_line":"RESOURCES \u003d {\u0027network\u0027: \u0027networks\u0027,"},{"line_number":37,"context_line":"             \u0027subnet\u0027: \u0027subnets\u0027,"},{"line_number":38,"context_line":"             \u0027subnetpool\u0027: \u0027subnetpools\u0027,"},{"line_number":39,"context_line":"             \u0027address_scope\u0027: \u0027address_scopes\u0027,"},{"line_number":40,"context_line":"             \u0027port\u0027: \u0027ports\u0027}"},{"line_number":41,"context_line":"SUB_RESOURCES \u003d {}"},{"line_number":42,"context_line":"COLLECTION_ACTIONS \u003d [\u0027index\u0027, \u0027create\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_b7d217ff","line":39,"in_reply_to":"fa32b979_74fd7039","updated":"2015-06-15 22:35:59.000000000","message":"I see parallels with subnetpools. There are no references from existing resources to this one, so it looks OK to me. I agree, though, to get @Salvatore\u0027s and @Akihiro\u0027s inputs on this.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fd2f1e375558797bec9a9813d4433d992dfe1f35","unresolved":false,"context_lines":[{"line_number":36,"context_line":"RESOURCES \u003d {\u0027network\u0027: \u0027networks\u0027,"},{"line_number":37,"context_line":"             \u0027subnet\u0027: \u0027subnets\u0027,"},{"line_number":38,"context_line":"             \u0027subnetpool\u0027: \u0027subnetpools\u0027,"},{"line_number":39,"context_line":"             \u0027address_scope\u0027: \u0027address_scopes\u0027,"},{"line_number":40,"context_line":"             \u0027port\u0027: \u0027ports\u0027}"},{"line_number":41,"context_line":"SUB_RESOURCES \u003d {}"},{"line_number":42,"context_line":"COLLECTION_ACTIONS \u003d [\u0027index\u0027, \u0027create\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_796f8fc5","line":39,"in_reply_to":"fa32b979_7edc58e4","updated":"2015-06-16 10:47:08.000000000","message":"IMHO all changes/additions should be implemented as an extension.\nEven if it is related to subnet, I don\u0027t see there is a special reason to change the core resources directly so far.\n\nIn my understanding, a way of implementing the subnet pool feature was very special and in general I think it should be implemented as a *normal* extension. \"Shim extension\" is just a compromise due to the time limitation before the release.\n\nI believe at least \"shim extension\" is required because we need a way to identify a way the feature is available from outside.\n\nI know \"shim\" vs \"normal\" extension is a choice of implementation. If we touch core API code directly, I think it is better to break the core API code (including db plugin code) into resources (network/subnet/port). It would help us to keep modules small.\nIf not, I prefer to using the normal way as many extensions do.\nUnless the implementation would be so complicated, I prefer the way of a normal extension rather than \"shim extension\".","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"}],"neutron/db/address_scope_db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"950c815ea68593a75dfd58b93e6701845ce27df5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_566e0dca","line":1,"updated":"2015-06-23 03:29:16.000000000","message":"nit:  Not copyright Openstack Foundation.  I\u0027d just leave it out.","commit_id":"a16000ca5503687dc2f562ed2572659b893c1218"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"950c815ea68593a75dfd58b93e6701845ce27df5","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def create_address_scope(self, context, address_scope):"},{"line_number":54,"context_line":"        \"\"\"Create a address scope.\"\"\""},{"line_number":55,"context_line":"        addr_scope \u003d address_scope[\u0027address_scope\u0027]"},{"line_number":56,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, addr_scope)"},{"line_number":57,"context_line":"        address_scope_id \u003d addr_scope.get(\u0027id\u0027) or uuidutils.generate_uuid()"},{"line_number":58,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_f68ba166","line":55,"updated":"2015-06-23 03:29:16.000000000","message":"nit:  This is fine the way it is but the distinction between address_scope and addr_scope is a bit strange.  What would you think about naming this inner_scope, inner_addr_scope, or something?","commit_id":"a16000ca5503687dc2f562ed2572659b893c1218"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"26217a6b1f7f1fd8fc4929d9573c4650d50820dd","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def create_address_scope(self, context, address_scope):"},{"line_number":54,"context_line":"        \"\"\"Create a address scope.\"\"\""},{"line_number":55,"context_line":"        addr_scope \u003d address_scope[\u0027address_scope\u0027]"},{"line_number":56,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, addr_scope)"},{"line_number":57,"context_line":"        address_scope_id \u003d addr_scope.get(\u0027id\u0027) or uuidutils.generate_uuid()"},{"line_number":58,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_31d27301","line":55,"in_reply_to":"fa32b979_f68ba166","updated":"2015-06-23 04:24:03.000000000","message":"I will name it as \"a_s\" as the way it is done for other resources (like \"sp\" for subnetpools)","commit_id":"a16000ca5503687dc2f562ed2572659b893c1218"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"950c815ea68593a75dfd58b93e6701845ce27df5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        return self._make_address_scope_dict(addr_scope)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def update_address_scope(self, context, id, address_scope):"},{"line_number":69,"context_line":"        new_addr_scope \u003d address_scope[\u0027address_scope\u0027]"},{"line_number":70,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":71,"context_line":"            addr_scope \u003d self._get_address_scope(context, id)"},{"line_number":72,"context_line":"            if addr_scope.shared and not new_addr_scope.get(\u0027shared\u0027, True):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_56f36d0a","line":69,"updated":"2015-06-23 03:29:16.000000000","message":"ditto.  I\u0027m not sure the new_ at the beginning helps much.  But, it is just a nit.","commit_id":"a16000ca5503687dc2f562ed2572659b893c1218"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"7e360ae41b911402da7ffccd9a82e0b27d4edc59","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        address_scope \u003d self._get_address_scope(context, id)"},{"line_number":83,"context_line":"        return self._make_address_scope_dict(address_scope, fields)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def get_address_scopes(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":86,"context_line":"                           sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":87,"context_line":"                           page_reverse\u003dFalse):"},{"line_number":88,"context_line":"        marker_obj \u003d self._get_marker_obj(context, \u0027addrscope\u0027, limit, marker)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_f509de84","line":85,"updated":"2015-06-25 09:38:29.000000000","message":"add one more function get_address_scopes_count?","commit_id":"74e54153ea614abe5abaabbe901efdf84ebdc1e7"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"7a03a75f0ed2e8ddd2b38d5ebf2b7be2b4604eba","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    __tablename__ \u003d \"address_scopes\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":33,"context_line":"    shared \u003d sa.Column(sa.Boolean, nullable\u003dFalse)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_81a81b22","line":32,"updated":"2015-06-26 10:50:36.000000000","message":"nullable\u003dFalse","commit_id":"fd2346dbfddda753435feb3390f4ce90357bf76e"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"2823fa9eb7391f52fafbccde0c7ce92c7dee3afe","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    __tablename__ \u003d \"address_scopes\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":33,"context_line":"    shared \u003d sa.Column(sa.Boolean, nullable\u003dFalse)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa32b979_7c74a035","line":32,"in_reply_to":"fa32b979_81a81b22","updated":"2015-06-26 11:04:46.000000000","message":"Thanks. done","commit_id":"fd2346dbfddda753435feb3390f4ce90357bf76e"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e69c33d0368638dd908396e7d980933716f967f7","unresolved":false,"context_lines":[{"line_number":1132,"context_line":"        # Can\u0027t be both."},{"line_number":1133,"context_line":"        # Steps: 1. Delete existing subnetpools"},{"line_number":1134,"context_line":"        #        2. Recreate"},{"line_number":1135,"context_line":"        #        3. Associate it with the new addrscope"},{"line_number":1136,"context_line":"        pass"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"    def get_addrscope(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_2943b0b3","line":1135,"updated":"2015-06-10 19:33:01.000000000","message":"Also, we have to maintain non-overlap of IP address across the scope.  I imagine this will require a lock on the address scope row to allow looking across the subnet pools for overlap (Cedric (zzelle) will be a good resource to help with this).  This point is still under discussion in the spec so you might not want to get to far along with the code before the discussion concludes.","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"}],"neutron/db/migration/alembic_migrations/versions/52c5312f6baf_address_scopes.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"950c815ea68593a75dfd58b93e6701845ce27df5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_3664a9e3","line":1,"updated":"2015-06-23 03:29:16.000000000","message":"Ditto","commit_id":"a16000ca5503687dc2f562ed2572659b893c1218"},{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"1dba1c575116aa704ce8e6589469f048b32eb289","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def upgrade():"},{"line_number":29,"context_line":"    op.create_table("},{"line_number":30,"context_line":"        \u0027addressscopes\u0027,"},{"line_number":31,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":32,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255)),"},{"line_number":33,"context_line":"        sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255), nullable\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_c2e3fed6","line":30,"updated":"2015-06-24 04:20:58.000000000","message":"nit: how about address_scopes instead?","commit_id":"1be86aaece83c0850fd9c2e31c72b0aed7b1bc6b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"7e360ae41b911402da7ffccd9a82e0b27d4edc59","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    op.create_table("},{"line_number":30,"context_line":"        \u0027address_scopes\u0027,"},{"line_number":31,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":32,"context_line":"        sa.Column(\u0027name\u0027, sa.String(length\u003d255)),"},{"line_number":33,"context_line":"        sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255), nullable\u003dTrue,"},{"line_number":34,"context_line":"                  index\u003dTrue),"},{"line_number":35,"context_line":"        sa.Column(\u0027shared\u0027, sa.Boolean(), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa32b979_d5793a30","line":32,"updated":"2015-06-25 09:38:29.000000000","message":"name is nullable or not?","commit_id":"74e54153ea614abe5abaabbe901efdf84ebdc1e7"}],"neutron/db/models_v2.py":[{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"d1052cc9ce248a424fedc695f7ecfd20a3026af0","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    addrscope_id \u003d sa.Column(sa.String(255))"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"class AddrScope(model_base.BASEV2, HasId, HasTenant):"},{"line_number":251,"context_line":"    \"\"\"Represents a neutron address scope."},{"line_number":252,"context_line":"    \"\"\""},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_01e72be5","line":250,"updated":"2015-06-15 03:41:51.000000000","message":"Needs a alembic migration","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"eeebbde0e89790f802755e961674f0fd04464c42","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                                lazy\u003d\u0027joined\u0027)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"class AddressScope(model_base.BASEV2, HasId, HasTenant):"},{"line_number":250,"context_line":"    \"\"\"Represents a neutron address scope."},{"line_number":251,"context_line":"    \"\"\""},{"line_number":252,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_f4fe606a","line":249,"updated":"2015-06-15 20:36:53.000000000","message":"This needs a migration.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fd2f1e375558797bec9a9813d4433d992dfe1f35","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"class AddressScope(model_base.BASEV2, HasId, HasTenant):"},{"line_number":250,"context_line":"    \"\"\"Represents a neutron address scope."},{"line_number":251,"context_line":"    \"\"\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":254,"context_line":"    shared \u003d sa.Column(sa.Boolean, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_79e8efb4","line":251,"updated":"2015-06-16 10:47:08.000000000","message":"nit: the docstring should be a single line in this case.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1a07a97ce2bc118bc29c3aae740652d8161b4afd","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    \"\"\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":254,"context_line":"    shared \u003d sa.Column(sa.Boolean, nullable\u003dFalse)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"class Network(model_base.BASEV2, HasId, HasTenant):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_371367ba","line":254,"updated":"2015-06-15 22:35:59.000000000","message":"Needs a default.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"012927cf0d615ce9cc7ebf1bf59fe3b1b97809a0","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    \"\"\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":254,"context_line":"    shared \u003d sa.Column(sa.Boolean, nullable\u003dFalse)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"class Network(model_base.BASEV2, HasId, HasTenant):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_3ee6d0b4","line":254,"updated":"2015-06-16 09:23:49.000000000","message":"not if it\u0027s not nullable, right?","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"}],"neutron/extensions/address_scope.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"950c815ea68593a75dfd58b93e6701845ce27df5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation."},{"line_number":2,"context_line":"# All rights reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_7671d1a7","line":1,"updated":"2015-06-23 03:29:16.000000000","message":"Ditto","commit_id":"a16000ca5503687dc2f562ed2572659b893c1218"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"223d3fc762a29cfc7bbba9cf2948f6a07d188389","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":36,"context_line":"        \u0027name\u0027: {\u0027allow_post\u0027: True,"},{"line_number":37,"context_line":"                 \u0027allow_put\u0027: True,"},{"line_number":38,"context_line":"                 \u0027validate\u0027: {\u0027type:not_empty_string\u0027: None},"},{"line_number":39,"context_line":"                 \u0027is_visible\u0027: True},"},{"line_number":40,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":41,"context_line":"                      \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_696b0bba","line":38,"updated":"2015-06-23 18:16:02.000000000","message":"Hmm.... we need to check the maximum length for string fields. We need to improve the validator method (not_empty_string). It is not specific to this patch, so you don\u0027t need to make an action in this patch. I will follow-up.","commit_id":"a36fcad95f8a7e490a97d016b83698f97cb2d43d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"223d3fc762a29cfc7bbba9cf2948f6a07d188389","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                 \u0027is_visible\u0027: True},"},{"line_number":40,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":41,"context_line":"                      \u0027allow_put\u0027: False,"},{"line_number":42,"context_line":"                      \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":43,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":44,"context_line":"                      \u0027is_visible\u0027: True},"},{"line_number":45,"context_line":"        attr.SHARED: {\u0027allow_post\u0027: True,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_e95f1b0d","line":42,"updated":"2015-06-23 18:16:02.000000000","message":"Please specify TENANT_ID_MAX_LEN instead of None.","commit_id":"a36fcad95f8a7e490a97d016b83698f97cb2d43d"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"0dddfb70e1a0aed22d326a089e383732144a91cc","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                \"%(reason)s\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class Address_scope(extensions.ExtensionDescriptor):"},{"line_number":71,"context_line":"    \"\"\"Extension class supporting Address Scopes.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_66002602","line":70,"updated":"2015-06-23 13:40:16.000000000","message":"Very few classes in Neutron use underscore in class names. I only see couple uses the underscore when the name contains some abbreviations. Camel case for this class probably is better especially when you are trying to make Address Scope first class thing.","commit_id":"a36fcad95f8a7e490a97d016b83698f97cb2d43d"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"f26b8e8ea8ac80909ad4ff6ad6724566b2e2b479","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                \"%(reason)s\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class Address_scope(extensions.ExtensionDescriptor):"},{"line_number":71,"context_line":"    \"\"\"Extension class supporting Address Scopes.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_5114a2e7","line":70,"in_reply_to":"fa32b979_2e7e5baf","updated":"2015-06-24 01:50:57.000000000","message":"I renamed all other files for consistency. But I forgot to rename alembic migration file.\nLet me know if this also needs to be renamed.","commit_id":"a36fcad95f8a7e490a97d016b83698f97cb2d43d"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"0d7bb6c8ab3096a186cec43889b6f00d51a7d1ff","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                \"%(reason)s\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class Address_scope(extensions.ExtensionDescriptor):"},{"line_number":71,"context_line":"    \"\"\"Extension class supporting Address Scopes.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_2e7e5baf","line":70,"in_reply_to":"fa32b979_4653946b","updated":"2015-06-24 01:33:24.000000000","message":"Sure. I think we may have to use \"Addressscope\" in which case the file name also needs to be renamed to adddressscope.py\n\nI am keeping the file names : address_scope_db.py and test_address_scope.py  AS IS.\nPlease let me know if these needs to be renamed to addressscope_db.py and test_addressscope.py for consistency.","commit_id":"a36fcad95f8a7e490a97d016b83698f97cb2d43d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"223d3fc762a29cfc7bbba9cf2948f6a07d188389","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                \"%(reason)s\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class Address_scope(extensions.ExtensionDescriptor):"},{"line_number":71,"context_line":"    \"\"\"Extension class supporting Address Scopes.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_4653946b","line":70,"in_reply_to":"fa32b979_66002602","updated":"2015-06-23 18:16:02.000000000","message":"+1 for AddressScope or Addresscope.\n\nIIRC, the extension manager may have an assumption on a class name, so we may need to use Addressscope.","commit_id":"a36fcad95f8a7e490a97d016b83698f97cb2d43d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e19a699889e538ad6177602e62c68f071540c15d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":36,"context_line":"        \u0027name\u0027: {\u0027allow_post\u0027: True,"},{"line_number":37,"context_line":"                 \u0027allow_put\u0027: True,"},{"line_number":38,"context_line":"                 \u0027validate\u0027: {\u0027type:not_empty_string\u0027: None},"},{"line_number":39,"context_line":"                 \u0027is_visible\u0027: True},"},{"line_number":40,"context_line":"        \u0027tenant_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":41,"context_line":"                      \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba3cc151_24b3ccea","line":38,"updated":"2015-07-02 07:21:59.000000000","message":"Why not_empty_string? Most \"name\" fields accept an empty string.\nI would like to keep \"name\" field consistent as possible as we can.\n\nIn addition, None should be attr.NAME_MAX_LEN.\n\nMy suggestion is:\n\n  \u0027default\u0027: \u0027\u0027,\n  \u0027validate\u0027: {\u0027type:string\u0027: attr.NAME_MAX_LEN},","commit_id":"e36988cfdcb377e0035e4633625ceab5d997bedb"}],"neutron/extensions/addressscope.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d7f58f2aa2026a5472ed2602d150b58045ba8850","unresolved":false,"context_lines":[{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class AddressScopeNotFound(nexception.NotFound):"},{"line_number":57,"context_line":"    message \u003d _(\"Address scope %(address_scope_id)s could not be found\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_1dbcebb9","line":56,"updated":"2015-06-24 05:22:10.000000000","message":"I feel it will be good to have a separate file listing all the exceptions. Exception strings will be extended when more functionalities (subnetpool association, RD/RT support and etc.) for address scopes will come in the future.","commit_id":"1be86aaece83c0850fd9c2e31c72b0aed7b1bc6b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f8c75c9cc011bb4661ee94c3b689c7407801ba1f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class AddressScopeNotFound(nexception.NotFound):"},{"line_number":57,"context_line":"    message \u003d _(\"Address scope %(address_scope_id)s could not be found\")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_caa8db22","line":56,"in_reply_to":"fa32b979_1dbcebb9","updated":"2015-06-24 15:21:17.000000000","message":"At now it is a convention widely used in neutron tree.\nIt can be revisit once pecan work completes.","commit_id":"1be86aaece83c0850fd9c2e31c72b0aed7b1bc6b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d7f58f2aa2026a5472ed2602d150b58045ba8850","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                \"%(reason)s\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class Addressscope(extensions.ExtensionDescriptor):"},{"line_number":71,"context_line":"    \"\"\"Extension class supporting Address Scopes.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_9dc8fb56","line":70,"updated":"2015-06-24 05:22:10.000000000","message":"Naming this class as \"AddressScope\" will be consistent.","commit_id":"1be86aaece83c0850fd9c2e31c72b0aed7b1bc6b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f8c75c9cc011bb4661ee94c3b689c7407801ba1f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                \"%(reason)s\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class Addressscope(extensions.ExtensionDescriptor):"},{"line_number":71,"context_line":"    \"\"\"Extension class supporting Address Scopes.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_4a9dab08","line":70,"in_reply_to":"fa32b979_885f5740","updated":"2015-06-24 15:21:17.000000000","message":"We need to handle an extension module specially. As Numan commented, there is a dependency between a module (\u003d filename) and a class name. If a file name is \u0027addressscope.py\u0027, a corresponding class name must be \u0027Addressscope\u0027.\n\nFrom the above observation, I am fine either of Address_scope or Addressscope. Triple-consecutive \u0027s\u0027 looks difficult to read, so my vote is Address_scope, but either works for me.","commit_id":"1be86aaece83c0850fd9c2e31c72b0aed7b1bc6b"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"a6bb670ac8a56ce3a3d8ce94c6267b791ddaa4f2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                \"%(reason)s\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class Addressscope(extensions.ExtensionDescriptor):"},{"line_number":71,"context_line":"    \"\"\"Extension class supporting Address Scopes.\"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_885f5740","line":70,"in_reply_to":"fa32b979_9dc8fb56","updated":"2015-06-24 06:20:38.000000000","message":"Extension Manager when loading this extension will look for the class name \"Addressscope\" and not \"AddressScope\". So it can\u0027t be renamed to \"AddressScope\".\n\nIn the previous patch, the file name was \"address_scope.py\" and the class name \"Address_scope\".\n\n@All - please provide your comments on this","commit_id":"1be86aaece83c0850fd9c2e31c72b0aed7b1bc6b"}],"neutron/ipam/subnet_alloc.py":[{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"d1052cc9ce248a424fedc695f7ecfd20a3026af0","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        self._read_prefix_bounds(subnetpool)"},{"line_number":203,"context_line":"        self._read_attrs(subnetpool,"},{"line_number":204,"context_line":"                         [\u0027tenant_id\u0027, \u0027name\u0027, \u0027shared\u0027])"},{"line_number":205,"context_line":"        self._read_addrscope(subnetpool)"},{"line_number":206,"context_line":"        self.subnetpool \u003d {\u0027id\u0027: self.id,"},{"line_number":207,"context_line":"                           \u0027name\u0027: self.name,"},{"line_number":208,"context_line":"                           \u0027tenant_id\u0027: self.tenant_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_811a5b16","line":205,"updated":"2015-06-15 03:41:51.000000000","message":"See L294","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"d1052cc9ce248a424fedc695f7ecfd20a3026af0","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                           \u0027default_prefix\u0027: self.default_prefix,"},{"line_number":215,"context_line":"                           \u0027default_prefixlen\u0027: self.default_prefixlen,"},{"line_number":216,"context_line":"                           \u0027default_quota\u0027: self.default_quota,"},{"line_number":217,"context_line":"                           \u0027addrscope_id\u0027: self.addrscope_id,"},{"line_number":218,"context_line":"                           \u0027shared\u0027: self.shared}"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def _read_attrs(self, subnetpool, keys):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_a1175fec","line":217,"updated":"2015-06-15 03:41:51.000000000","message":"See L294","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"d1052cc9ce248a424fedc695f7ecfd20a3026af0","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        self.ip_version \u003d ip_version"},{"line_number":292,"context_line":"        self.prefixes \u003d self._compact_subnetpool_prefix_list(prefix_list)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def _read_addrscope(self, subnetpool):"},{"line_number":295,"context_line":"        id \u003d subnetpool.get(\u0027addrscope_id\u0027, attributes.ATTR_NOT_SPECIFIED)"},{"line_number":296,"context_line":"        self.addrscope_id \u003d id"},{"line_number":297,"context_line":"        if id is attributes.ATTR_NOT_SPECIFIED:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_613cf793","line":294,"updated":"2015-06-15 03:41:51.000000000","message":"For basic CRUD on address scopes this is unnecessary.  I\u0027d suggest keeping the scope of this patch to basic CRUD on address scopes and moving this code to a dependent review that focuses on introducing address scopes to subnet pools.","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"d1052cc9ce248a424fedc695f7ecfd20a3026af0","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        if id is attributes.ATTR_NOT_SPECIFIED:"},{"line_number":298,"context_line":"            # TODO(Vikram): Check what to fill here."},{"line_number":299,"context_line":"            # Do we really require this?"},{"line_number":300,"context_line":"            self.addrscope_id \u003d id"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _compact_subnetpool_prefix_list(self, prefix_list):"},{"line_number":303,"context_line":"        \"\"\"Compact any overlapping prefixes in prefix_list and return the"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_613157a2","line":300,"updated":"2015-06-15 03:41:51.000000000","message":"Consider using None instead of attributes.ATTR_NOT_SPECIFIED for an unspecified address_scope_id.  attributes.ATTR_NOT_SPECIFIED should really only be used in the REST layer.","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"}],"neutron/neutron_plugin_base_v2.py":[{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"c2064b8e3334db793c699ff54cbb9fcf80eecb8c","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        raise NotImplementedError()"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def create_addrscope(self, context, subnetpool):"},{"line_number":170,"context_line":"        \"\"\"Create a address scope."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_61307757","line":169,"updated":"2015-06-15 03:46:24.000000000","message":"Looks like we\u0027re not implementing this as an extension, should we consult Salvatore\u0027s microversioning proposal?  Should this be an extension, do we need a shim extension?  I know I need to brush up on what direction evolving the API is taking, let\u0027s make sure we\u0027re doing the right thing.","commit_id":"8736ef6bf29e235ed470b44f2f4c99f5808ed0f8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"012927cf0d615ce9cc7ebf1bf59fe3b1b97809a0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        raise NotImplementedError()"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def create_address_scope(self, context, adress_scope):"},{"line_number":170,"context_line":"        \"\"\"Create a address scope."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_5ee15499","line":169,"updated":"2015-06-16 09:23:49.000000000","message":"I don\u0027t really see what decorating it would buy us. They either will override it if they want to support the feature, or they won\u0027t and it will just give a server error when a user wants to use it.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"903fc9bd1250aee75225a3d6db391505cdc54f06","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        raise NotImplementedError()"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def create_address_scope(self, context, adress_scope):"},{"line_number":170,"context_line":"        \"\"\"Create a address scope."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_217245ae","line":169,"updated":"2015-06-15 21:18:15.000000000","message":"This issue came up with subnetpools and we didn\u0027t explore it too deeply at the time, but maybe it makes sense to re-visit:  should these methods be annotated with @abc.abstractmethod?  If this is an addition to the core API shouldn\u0027t third-party plugins at a minimum stub out implementations for these methods? We didn\u0027t decorate the subnetpool methods because it required changes to the opencontrail plugin because it doesn\u0027t extend the DB plugin and we didn\u0027t think it was appropriate to touch it.  Since we\u0027re possibly talking about expanding the core API again, should we force this on all plugins?","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fd2f1e375558797bec9a9813d4433d992dfe1f35","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        raise NotImplementedError()"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def create_address_scope(self, context, adress_scope):"},{"line_number":170,"context_line":"        \"\"\"Create a address scope."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_39dd87e0","line":169,"in_reply_to":"fa32b979_217245ae","updated":"2015-06-16 10:47:08.000000000","message":"We are not changing the core API. In theory the feature should be implemented as an extension.\n\nIMO \"subnet pool\" should be implemented as an extension rather than changing this class. \"shim extension\" is just a compromise due to the time limitation before the release. It was unfortunate and what Ryan says is a negative side of \"shim extension\".","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d7f58f2aa2026a5472ed2602d150b58045ba8850","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                                    \"multi-provider\", \"allowed-address-pairs\","},{"line_number":116,"context_line":"                                    \"extra_dhcp_opt\", \"subnet_allocation\","},{"line_number":117,"context_line":"                                    \"net-mtu\", \"vlan-transparent\","},{"line_number":118,"context_line":"                                    \"address-scope\"]"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @property"},{"line_number":121,"context_line":"    def supported_extension_aliases(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_7dd2d701","line":118,"updated":"2015-06-24 05:22:10.000000000","message":"I feel naming it as \"address_scope\" will consistent.","commit_id":"1be86aaece83c0850fd9c2e31c72b0aed7b1bc6b"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fd2f1e375558797bec9a9813d4433d992dfe1f35","unresolved":false,"context_lines":[{"line_number":626,"context_line":"    @contextlib.contextmanager"},{"line_number":627,"context_line":"    def address_scope(self, admin\u003dFalse, **kwargs):"},{"line_number":628,"context_line":"        addr_scope \u003d self._make_address_scope(self.fmt, admin, **kwargs)"},{"line_number":629,"context_line":"        yield addr_scope"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def _test_list_with_sort(self, resource,"},{"line_number":632,"context_line":"                             items, sorts, resources\u003dNone, query_params\u003d\u0027\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_796eaf02","line":629,"updated":"2015-06-16 10:47:08.000000000","message":"nit: Isn\u0027t it better to move it before port()?\naddress_scope is related to subnet/subnetpool, so it is better to be placed near them.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fd2f1e375558797bec9a9813d4433d992dfe1f35","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                                 sorted(keys[k]))"},{"line_number":740,"context_line":"            else:"},{"line_number":741,"context_line":"                self.assertEqual(resource[res_name][k], keys[k])"},{"line_number":742,"context_line":""},{"line_number":743,"context_line":"    def _create_address_scope(self, fmt, expected_res_status\u003dNone,"},{"line_number":744,"context_line":"                              admin\u003dFalse, **kwargs):"},{"line_number":745,"context_line":"        address_scope \u003d {\u0027address_scope\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_3c15753f","line":742,"updated":"2015-06-16 10:47:08.000000000","message":"If we go to the way of changing the core API code,\nit is better to move L.743-766 to around _make_subnetpool.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"4920c95d93ca0b5201b30b95b0b6946321568c2e","unresolved":false,"context_lines":[{"line_number":4675,"context_line":"                          name\u003dself._POOL_NAME,"},{"line_number":4676,"context_line":"                          tenant_id\u003dself._tenant_id,"},{"line_number":4677,"context_line":"                          min_prefixlen\u003d\u002721\u0027)"},{"line_number":4678,"context_line":"        self.assertEqual(1, 2)"},{"line_number":4679,"context_line":""},{"line_number":4680,"context_line":"    def test_create_subnetpool_ipv4_24_with_defaults(self):"},{"line_number":4681,"context_line":"        subnet \u003d netaddr.IPNetwork(\u002710.10.10.0/24\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_c99f054f","line":4678,"updated":"2015-06-15 20:01:36.000000000","message":"Its by mistake. I will remove it in the next patch.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":14258,"name":"Ryan Tidwell","email":"rktidwell85@gmail.com","username":"tidwellr"},"change_message_id":"903fc9bd1250aee75225a3d6db391505cdc54f06","unresolved":false,"context_lines":[{"line_number":5617,"context_line":""},{"line_number":5618,"context_line":""},{"line_number":5619,"context_line":"class TestAddressScope(NeutronDbPluginV2TestCase):"},{"line_number":5620,"context_line":""},{"line_number":5621,"context_line":"    def _test_create_address_scope(self, expected\u003dNone, admin\u003dFalse, **kwargs):"},{"line_number":5622,"context_line":"        keys \u003d kwargs.copy()"},{"line_number":5623,"context_line":"        keys.setdefault(\u0027tenant_id\u0027, self._tenant_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_21f7a5f6","line":5620,"updated":"2015-06-15 21:18:15.000000000","message":"These unit tests are cheap to write, we get decent coverage from them, and they represent a good return on time invested.  However, let\u0027s not neglect API tests and functional tests as they become appropriate.","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"2b8199f546d47e7c5f32ec0b6570483b7dcc681e","unresolved":false,"context_lines":[{"line_number":5617,"context_line":""},{"line_number":5618,"context_line":""},{"line_number":5619,"context_line":"class TestAddressScope(NeutronDbPluginV2TestCase):"},{"line_number":5620,"context_line":""},{"line_number":5621,"context_line":"    def _test_create_address_scope(self, expected\u003dNone, admin\u003dFalse, **kwargs):"},{"line_number":5622,"context_line":"        keys \u003d kwargs.copy()"},{"line_number":5623,"context_line":"        keys.setdefault(\u0027tenant_id\u0027, self._tenant_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_82ab04d6","line":5620,"in_reply_to":"fa32b979_21f7a5f6","updated":"2015-06-16 06:31:22.000000000","message":"Sure. Next up are the API tests :).","commit_id":"be9c694c02c7f9af3ac1dc74ded33a5dfb3e39fe"}],"neutron/tests/unit/extensions/test_address_scope.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"950c815ea68593a75dfd58b93e6701845ce27df5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Openstack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_7338033e","line":1,"updated":"2015-06-23 03:29:16.000000000","message":"Ditto","commit_id":"a16000ca5503687dc2f562ed2572659b893c1218"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"223d3fc762a29cfc7bbba9cf2948f6a07d188389","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        neutron_context \u003d context.Context(\u0027\u0027, \u0027not-the-owner\u0027)"},{"line_number":200,"context_line":"        req.environ[\u0027neutron.context\u0027] \u003d neutron_context"},{"line_number":201,"context_line":"        res \u003d req.get_response(self.ext_api)"},{"line_number":202,"context_line":"        self.assertEqual(res.status_int, 404)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def test_get_address_scope_different_tenants_shared(self):"},{"line_number":205,"context_line":"        addr_scope \u003d self._test_create_address_scope(name\u003d\u0027foo-addr-scope\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_89f52fee","line":202,"updated":"2015-06-23 18:16:02.000000000","message":"In other assertEqual in this file, you use the style of assertEqual(expected, actual), but this is not. It is better to keep the consistency in the file.","commit_id":"a36fcad95f8a7e490a97d016b83698f97cb2d43d"}],"neutron/tests/unit/extensions/test_addressscope.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d7f58f2aa2026a5472ed2602d150b58045ba8850","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        super(TestAddressScope, self).setUp(plugin\u003dplugin, ext_mgr\u003dext_mgr)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_create_address_scope(self):"},{"line_number":122,"context_line":"        expected_addr_scope \u003d {\u0027name\u0027: \u0027foo-addr-scope\u0027,"},{"line_number":123,"context_line":"                               \u0027tenant_id\u0027: self._tenant_id,"},{"line_number":124,"context_line":"                               \u0027shared\u0027: False}"},{"line_number":125,"context_line":"        self._test_create_address_scope(name\u003d\u0027foo-addr-scope\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_7d273712","line":122,"updated":"2015-06-24 05:22:10.000000000","message":"Can we rename \u0027foo-addr-scope\" to \"foo-address-scope\" for consistency. I may sound stupid but just a thought. Anyways it\u0027s useless as far as the functionality is considered ;)","commit_id":"1be86aaece83c0850fd9c2e31c72b0aed7b1bc6b"}]}
