)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"081e9491548ea36cf686ac2d0788afe3e9c010cd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unique constraints in Subnet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027network_id\u0027, \u0027cidr\u0027 should be unique in the table."},{"line_number":10,"context_line":"These constraints are essential to detect concurrent modifications"},{"line_number":11,"context_line":"of the Subnet table if there are multiple neutron-server."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_5899ff77","line":9,"updated":"2015-06-11 08:04:39.000000000","message":"The real constraint is: \n\n  subnet cidrs belonging to the same network should not overlap\n\nwhich is not ensured by proposed change and seems impossible to ensure using db constraints.","commit_id":"0b6d4ebc5262d00286fd5df036ec234d524b0c95"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"42fc05b189bc5a575d19a2f42687a73c108b7e2a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unique constraints in Subnet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027network_id\u0027, \u0027cidr\u0027 should be unique in the table."},{"line_number":10,"context_line":"These constraints are essential to detect concurrent modifications"},{"line_number":11,"context_line":"of the Subnet table if there are multiple neutron-server."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_782efba5","line":9,"in_reply_to":"3afb71cf_5899ff77","updated":"2015-06-11 08:23:25.000000000","message":"hi Cedric Brandily, thanks for you review, see the reply in bellow","commit_id":"0b6d4ebc5262d00286fd5df036ec234d524b0c95"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9f2c61336091afb86a610d7e7e2eae7e095cdfa0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027network_id\u0027, \u0027cidr\u0027 should be unique in the table."},{"line_number":10,"context_line":"These constraints are essential to detect concurrent modifications"},{"line_number":11,"context_line":"of the Subnet table if there are multiple neutron-server."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I996acfe4cc31774255a5c86f197e3a6d35f45b43"},{"line_number":14,"context_line":"Closes-bug: #1464116"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_d8104f02","line":11,"updated":"2015-06-11 07:59:53.000000000","message":"i suspect it doesn\u0027t help much as cidr overlop can\u0027t be detected at sql level.","commit_id":"0b6d4ebc5262d00286fd5df036ec234d524b0c95"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"985df94459a8ed4ad8c3c8c7d0a1eac716595472","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027network_id\u0027, \u0027cidr\u0027 should be unique in the table."},{"line_number":10,"context_line":"These constraints are essential to detect concurrent modifications"},{"line_number":11,"context_line":"of the Subnet table if there are multiple neutron-server."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I996acfe4cc31774255a5c86f197e3a6d35f45b43"},{"line_number":14,"context_line":"Closes-bug: #1464116"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_fb5665cc","line":11,"in_reply_to":"3afb71cf_985c174c","updated":"2015-06-11 08:30:38.000000000","message":"It doesn\u0027t solve the real trouble ... if any as the bug doesn\u0027t prove it\u0027s possible","commit_id":"0b6d4ebc5262d00286fd5df036ec234d524b0c95"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"42fc05b189bc5a575d19a2f42687a73c108b7e2a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027network_id\u0027, \u0027cidr\u0027 should be unique in the table."},{"line_number":10,"context_line":"These constraints are essential to detect concurrent modifications"},{"line_number":11,"context_line":"of the Subnet table if there are multiple neutron-server."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I996acfe4cc31774255a5c86f197e3a6d35f45b43"},{"line_number":14,"context_line":"Closes-bug: #1464116"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_985c174c","line":11,"in_reply_to":"3afb71cf_d8104f02","updated":"2015-06-11 08:23:25.000000000","message":"hi YAMAMOTO Takashi, thanks for your review, what do you think the bellow use case:\n1. there are two neutron-server which behind haproxy in one openstack.\n2. two users create a subnet with 192.168.0.0/24 in one network at same, then the two requests are send apart to two neutron-server by haproxy.\n3. the two user all create subnet successfully, so in one network, it has same CIDR subnet, but it should not be allowed.\n\nIf we add the constraints for subnet, this can\u0027t happen. \nwhat do you think?","commit_id":"0b6d4ebc5262d00286fd5df036ec234d524b0c95"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"6e9faa6032b28007ea979e07c34a9ce5d43db3f5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027network_id\u0027, \u0027cidr\u0027 should be unique in the table."},{"line_number":10,"context_line":"These constraints are essential to detect concurrent modifications"},{"line_number":11,"context_line":"of the Subnet table if there are multiple neutron-server."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I996acfe4cc31774255a5c86f197e3a6d35f45b43"},{"line_number":14,"context_line":"Closes-bug: #1464116"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_bbfb4d78","line":11,"in_reply_to":"3afb71cf_fb5665cc","updated":"2015-06-11 08:40:12.000000000","message":"hi Cedric Brandily, I know that it doesn\u0027t solve the subnet overlap prolem, but at least one network will not has same CIDR subnet.","commit_id":"0b6d4ebc5262d00286fd5df036ec234d524b0c95"}]}